robotcode-language-server 2.6.2__py3-none-any.whl → 2.8.0.dev548__py3-none-any.whl

robotcode/language_server/robotframework/parts/references.py

@@ -26,6 +26,7 @@ from robotcode.robot.diagnostics.entities import (
     ResourceEntry,
     VariableDefinition,
     VariableDefinitionType,
+    VariablesEntry,
 )
 from robotcode.robot.diagnostics.library_doc import (
     RESOURCE_FILE_EXTENSION,
@@ -33,7 +34,6 @@ from robotcode.robot.diagnostics.library_doc import (
     KeywordDoc,
     LibraryDoc,
 )
-from robotcode.robot.diagnostics.model_helper import ModelHelper
 from robotcode.robot.diagnostics.namespace import Namespace
 from robotcode.robot.utils import RF_VERSION
 from robotcode.robot.utils.ast import (
@@ -55,7 +55,7 @@ _ReferencesMethod = Callable[
 ]
 
 
-class RobotReferencesProtocolPart(RobotLanguageServerProtocolPart, ModelHelper):
+class RobotReferencesProtocolPart(RobotLanguageServerProtocolPart):
     _logger = LoggingDescriptor()
 
     def __init__(self, parent: "RobotLanguageServerProtocol") -> None:
@@ -68,7 +68,7 @@ class RobotReferencesProtocolPart(RobotLanguageServerProtocolPart, ModelHelper):
 
         parent.references.collect.add(self.collect)
         parent.documents.did_change.add(self.document_did_change)
-        parent.documents.on_document_cache_invalidated(self.document_did_change)
+        parent.documents.on_document_cache_invalidated.add(self.document_did_change)
         parent.diagnostics.on_workspace_diagnostics_break.add(self.on_workspace_diagnostics_break)
 
     @event
@@ -80,7 +80,8 @@ class RobotReferencesProtocolPart(RobotLanguageServerProtocolPart, ModelHelper):
             f"**/*.{{{ROBOT_FILE_EXTENSION[1:]},{RESOURCE_FILE_EXTENSION[1:]}}}",
             WatchKind.CREATE | WatchKind.DELETE,
         )
-        self.parent.documents_cache.namespace_invalidated(self.namespace_invalidated)
+        self.parent.documents_cache.namespace_invalidated.add(self.namespace_invalidated)
+        self.parent.documents_cache.namespace_initialized.add(self.namespace_initialized)
 
     def do_on_file_changed(self, sender: Any, files: List[FileEvent]) -> None:
         self.clear_cache()
@@ -93,6 +94,11 @@ class RobotReferencesProtocolPart(RobotLanguageServerProtocolPart, ModelHelper):
     def namespace_invalidated(self, sender: Any, namespace: Namespace) -> None:
         self.clear_cache()
 
+    @language_id("robotframework")
+    def namespace_initialized(self, sender: Any, namespace: Namespace) -> None:
+        # the new analysis changed the index, so a result found before it can miss its references
+        self.clear_cache()
+
     def on_workspace_diagnostics_break(self, sender: Any) -> None:
         self.clear_cache()
 
@@ -330,18 +336,21 @@ class RobotReferencesProtocolPart(RobotLanguageServerProtocolPart, ModelHelper):
     def _find_library_import_references_in_file(self, doc: TextDocument, library_doc: LibraryDoc) -> List[Location]:
         namespace = self.parent.documents_cache.get_namespace(doc)
 
-        result: List[Location] = []
-        for lib_entry in namespace.libraries.values():
-            if (
-                lib_entry.import_source == str(doc.uri.to_path())
-                and lib_entry.library_doc.source_or_origin == library_doc.source_or_origin
-            ):
-                result.append(Location(str(doc.uri), lib_entry.import_range))
-
+        # every import statement, also one of a library that is already imported
+        result: List[Location] = [
+            Location(str(doc.uri), lib_entry.import_range)
+            for lib_entry in namespace.import_entries.values()
+            if not isinstance(lib_entry, (ResourceEntry, VariablesEntry))
+            and lib_entry.import_source == str(doc.uri.to_path())
+            and lib_entry.library_doc.source_or_origin == library_doc.source_or_origin
+            and lib_entry.library_doc.name == library_doc.name
+        ]
+
+        # the analysis also keeps a repeated import as a reference of the first one
         references = namespace.namespace_references
         for k, v in references.items():
             if not k.alias and k.library_doc == library_doc:
-                result.extend(v)
+                result.extend(location for location in v if location not in result)
 
         return result
 
@@ -415,17 +424,20 @@ class RobotReferencesProtocolPart(RobotLanguageServerProtocolPart, ModelHelper):
     def _find_resource_import_references_in_file(self, doc: TextDocument, entry: ResourceEntry) -> List[Location]:
         namespace = self.parent.documents_cache.get_namespace(doc)
 
-        result: List[Location] = []
-        for lib_entry in namespace.resources.values():
-            if (
-                lib_entry.import_source == str(doc.uri.to_path())
-                and lib_entry.library_doc.source == entry.library_doc.source
-            ):
-                result.append(Location(str(doc.uri), lib_entry.import_range))
+        # every import statement, also one of a resource file that is already imported
+        result: List[Location] = [
+            Location(str(doc.uri), lib_entry.import_range)
+            for lib_entry in namespace.import_entries.values()
+            if isinstance(lib_entry, ResourceEntry)
+            and lib_entry.import_source == str(doc.uri.to_path())
+            and lib_entry.library_doc.source == entry.library_doc.source
+        ]
 
+        # the calls with the resource's name as prefix, in every file that imports the resource
         references = namespace.namespace_references
-        if entry in references:
-            result.extend(references[entry])
+        for k, v in references.items():
+            if isinstance(k, ResourceEntry) and k.library_doc.source == entry.library_doc.source:
+                result.extend(location for location in v if location not in result)
 
         return result
 
@@ -448,12 +460,14 @@ class RobotReferencesProtocolPart(RobotLanguageServerProtocolPart, ModelHelper):
         if not name_token:
             return None
 
-        entries = namespace.resources
+        # the entry of this statement, also of a repeated import of the resource file
         entry = next(
             (
                 v
-                for v in entries.values()
-                if v.import_source == namespace.source and v.import_range == range_from_token(name_token)
+                for v in namespace.import_entries.values()
+                if isinstance(v, ResourceEntry)
+                and v.import_source == namespace.source
+                and v.import_range == range_from_token(name_token)
             ),
             None,
         )
@@ -484,12 +498,14 @@ class RobotReferencesProtocolPart(RobotLanguageServerProtocolPart, ModelHelper):
     def _find_variables_import_references_in_file(self, doc: TextDocument, library_doc: LibraryDoc) -> List[Location]:
         namespace = self.parent.documents_cache.get_namespace(doc)
 
-        result: List[Location] = []
-        for lib_entry in namespace.variables_imports.values():
-            if lib_entry.import_source == str(doc.uri.to_path()) and lib_entry.library_doc.source == library_doc.source:
-                result.append(Location(str(doc.uri), lib_entry.import_range))
-
-        return result
+        # every import statement, also one of a variable file that is already imported
+        return [
+            Location(str(doc.uri), lib_entry.import_range)
+            for lib_entry in namespace.import_entries.values()
+            if isinstance(lib_entry, VariablesEntry)
+            and lib_entry.import_source == str(doc.uri.to_path())
+            and lib_entry.library_doc.source == library_doc.source
+        ]
 
     def references_VariablesImport(  # noqa: N802
         self,

robotcode/language_server/robotframework/parts/rename.py

@@ -33,7 +33,6 @@ from robotcode.robot.diagnostics.entities import (
     VariableDefinitionType,
 )
 from robotcode.robot.diagnostics.library_doc import KeywordDoc
-from robotcode.robot.diagnostics.model_helper import ModelHelper
 
 from ...common.parts.rename import CantRenameError
 from .protocol_part import RobotLanguageServerProtocolPart
@@ -48,7 +47,7 @@ _PrepareRenameMethod = Callable[[ast.AST, TextDocument, Position], Optional[Prep
 _T = TypeVar("_T", bound=Callable[..., Any])
 
 
-class RobotRenameProtocolPart(RobotLanguageServerProtocolPart, ModelHelper):
+class RobotRenameProtocolPart(RobotLanguageServerProtocolPart):
     _logger = LoggingDescriptor()
 
     def __init__(self, parent: "RobotLanguageServerProtocol") -> None:

robotcode/language_server/robotframework/parts/robot_workspace.py

@@ -1,18 +1,35 @@
+import importlib
+import threading
 from concurrent.futures import CancelledError
 from logging import CRITICAL
+from pathlib import Path
 from threading import Event
-from typing import TYPE_CHECKING, Any, Optional
+from typing import TYPE_CHECKING, Any, Dict, List, Optional
 
-from robotcode.core.ignore_spec import DEFAULT_SPEC_RULES, GIT_IGNORE_FILE, ROBOT_IGNORE_FILE, IgnoreSpec, iter_files
+from robotcode.core.concurrent import run_as_task
+from robotcode.core.documents_manager import CantReadDocumentError
+from robotcode.core.ignore_spec import (
+    DEFAULT_SPEC_RULES,
+    GIT_IGNORE_FILE,
+    ROBOT_IGNORE_FILE,
+    IgnoreSpec,
+    iter_files,
+    iter_files_includes,
+)
 from robotcode.core.language import language_id
+from robotcode.core.lsp.types import DocumentUri, FileChangeType, FileEvent, WatchKind
+from robotcode.core.text_document import TextDocument
 from robotcode.core.uri import Uri
 from robotcode.core.utils.logging import LoggingDescriptor
+from robotcode.core.utils.path import probe_disk_info
+from robotcode.core.workspace import WorkspaceFolder
 from robotcode.jsonrpc2.protocol import rpc_method
 from robotcode.language_server.common.parts.diagnostics import (
     AnalysisProgressMode,
     DiagnosticsMode,
 )
 from robotcode.language_server.robotframework.configuration import AnalysisConfig
+from robotcode.robot.diagnostics.imports_manager import ImportsManager
 from robotcode.robot.diagnostics.library_doc import (
     RESOURCE_FILE_EXTENSION,
     ROBOT_FILE_EXTENSION,
@@ -25,6 +42,9 @@ if TYPE_CHECKING:
 
 from .protocol_part import RobotLanguageServerProtocolPart
 
+WORKSPACE_FILE_EXTENSIONS = [ROBOT_FILE_EXTENSION, RESOURCE_FILE_EXTENSION]
+WORKSPACE_IGNORE_FILES = [ROBOT_IGNORE_FILE, GIT_IGNORE_FILE]
+
 
 class RobotWorkspaceProtocolPart(RobotLanguageServerProtocolPart):
     _logger = LoggingDescriptor()
@@ -32,11 +52,43 @@ class RobotWorkspaceProtocolPart(RobotLanguageServerProtocolPart):
     def __init__(self, parent: "RobotLanguageServerProtocol") -> None:
         super().__init__(parent)
         self.parent.documents.on_read_document_text.add(self.on_read_document_text)
+        self.parent.documents.did_create_uri.add(self._on_did_create_uri)
+        self.parent.on_initialized.add(self._on_initialized)
+        self.parent.diagnostics.on_workspace_loaded.add(self._on_workspace_loaded)
+        self.parent.on_shutdown.add(self._stop_file_checks)
         self.parent.diagnostics.load_workspace_documents.add(self.load_workspace_documents)
         self.parent.diagnostics.on_get_diagnostics_mode.add(self.on_get_diagnostics_mode)
         self.parent.diagnostics.on_get_analysis_progress_mode.add(self.on_get_analysis_progress_mode)
         self.documents_loaded = Event()
 
+        # the periodic check of the files of each workspace folder, by the folder's URI
+        self._file_check_lock = threading.RLock()
+        self._file_check_timers: Dict[str, threading.Timer] = {}
+        self._file_checks_stopped = False
+
+    def _on_initialized(self, sender: Any) -> None:
+        # the workspace exists only after the initialize request, the parts of the protocol already before it
+        self.parent.workspace.did_change_configuration.add(self._on_did_change_configuration)
+        self.parent.workspace.add_file_watcher(
+            self._on_files_deleted,
+            f"**/*.{{{ROBOT_FILE_EXTENSION[1:]},{RESOURCE_FILE_EXTENSION[1:]}}}",
+            WatchKind.DELETE,
+        )
+
+    def _on_files_deleted(self, sender: Any, changes: List[FileEvent]) -> None:
+        for change in changes:
+            if change.type != FileChangeType.DELETED:
+                continue
+
+            uri = Uri(change.uri).normalized()
+            if uri.scheme != "file":
+                continue
+
+            path = uri.to_path()
+            # the cache keeps the entries of a file that is there again
+            if path.suffix in WORKSPACE_FILE_EXTENSIONS and not path.exists():
+                self.parent.documents_cache.remove_cached_analysis(path)
+
     @language_id("robotframework")
     def on_read_document_text(self, sender: Any, uri: Uri) -> Optional[str]:
         from robot.utils import FileReader
@@ -52,36 +104,67 @@ class RobotWorkspaceProtocolPart(RobotLanguageServerProtocolPart):
         config = self.parent.workspace.get_configuration(AnalysisConfig, uri)
         return config.progress_mode
 
+    def _exclude_spec(self, folder: WorkspaceFolder) -> IgnoreSpec:
+        config = self.parent.workspace.get_configuration(RobotCodeConfig, folder.uri)
+        exclude_patterns = [
+            *self.parent.analysis_config.exclude_patterns,
+            *(config.workspace.exclude_patterns or []),
+        ]
+        return IgnoreSpec.from_list([*DEFAULT_SPEC_RULES, *exclude_patterns], folder.uri.to_path())
+
+    def collect_workspace_files(self, folder: WorkspaceFolder) -> List[Path]:
+        """The Robot Framework files of a workspace folder, without the excluded and ignored ones."""
+        return [
+            f
+            for f in iter_files(
+                folder.uri.to_path(),
+                ignore_files=WORKSPACE_IGNORE_FILES,
+                include_hidden=False,
+                parent_spec=self._exclude_spec(folder),
+                verbose_callback=self._logger.debug,
+                verbose_trace=False,
+            )
+            if f.suffix in WORKSPACE_FILE_EXTENSIONS
+        ]
+
+    def is_workspace_file(self, folder: WorkspaceFolder, path: Path) -> bool:
+        """Whether `collect_workspace_files` would return `path`."""
+        return path.suffix in WORKSPACE_FILE_EXTENSIONS and iter_files_includes(
+            path,
+            folder.uri.to_path(),
+            ignore_files=WORKSPACE_IGNORE_FILES,
+            include_hidden=False,
+            parent_spec=self._exclude_spec(folder),
+        )
+
+    def _on_did_create_uri(self, sender: Any, uri: DocumentUri) -> None:
+        # a created file is analyzed like the files found at startup
+        file_uri = Uri(uri)
+        if file_uri.scheme != "file":
+            return
+
+        path = file_uri.to_path()
+        folder = self.parent.workspace.get_workspace_folder(file_uri)
+        if folder is None or not self.is_workspace_file(folder, path):
+            return
+
+        try:
+            document = self.parent.documents.get_or_open_document(path)
+        except CantReadDocumentError as e:
+            ex = e
+            self._logger.debug(lambda: f"Can't load created document {path}: {ex}")
+            return
+
+        self.parent.diagnostics.force_refresh_document(document)
+
     def load_workspace_documents(self, sender: Any) -> None:
         with self._logger.measure_time(lambda: "loading workspace documents", context_name="load_workspace_documents"):
             try:
                 for folder in self.parent.workspace.workspace_folders:
                     config = self.parent.workspace.get_configuration(RobotCodeConfig, folder.uri)
 
-                    extensions = [ROBOT_FILE_EXTENSION, RESOURCE_FILE_EXTENSION]
-
-                    exclude_patterns = [
-                        *self.parent.analysis_config.exclude_patterns,
-                        *(config.workspace.exclude_patterns or []),
-                    ]
-
                     with self.parent.window.progress("Collect sources", cancellable=False):
-                        files = list(
-                            filter(
-                                lambda f: f.suffix in extensions,
-                                iter_files(
-                                    folder.uri.to_path(),
-                                    ignore_files=[ROBOT_IGNORE_FILE, GIT_IGNORE_FILE],
-                                    include_hidden=False,
-                                    parent_spec=IgnoreSpec.from_list(
-                                        [*DEFAULT_SPEC_RULES, *exclude_patterns],
-                                        folder.uri.to_path(),
-                                    ),
-                                    verbose_callback=self._logger.debug,
-                                    verbose_trace=False,
-                                ),
-                            )
-                        )
+                        files = self.collect_workspace_files(folder)
 
                     canceled = False
                     self._logger.debug(
@@ -122,6 +205,127 @@ class RobotWorkspaceProtocolPart(RobotLanguageServerProtocolPart):
                 if canceled:
                     self._logger.info(lambda: "Workspace loading canceled")
 
+    def _documents_of(self, folder: WorkspaceFolder) -> List[TextDocument]:
+        result = []
+        for document in list(self.parent.documents.documents):
+            document_folder = self.parent.workspace.get_workspace_folder(document.uri)
+            if document_folder is not None and document_folder.uri == folder.uri:
+                result.append(document)
+        return result
+
+    def check_workspace_folder(self, folder: WorkspaceFolder) -> None:
+        """Find the changes of the files of a workspace folder, and handle them like the file events of the client."""
+        changes: Dict[str, FileEvent] = {}
+
+        def report(path: Path, change: FileChangeType) -> None:
+            uri = str(Uri.from_path(path))
+            if uri not in changes:
+                changes[uri] = FileEvent(uri, change)
+
+        for path in self.collect_workspace_files(folder):
+            if self.parent.documents.get(Uri.from_path(path).normalized()) is None:
+                report(path, FileChangeType.CREATED)
+
+        # the documents open in the editor are the editor's
+        for document in self._documents_of(folder):
+            if document.opened_in_editor or document.uri.scheme != "file":
+                continue
+
+            path = document.uri.to_path()
+            disk_info = probe_disk_info(path)
+            if disk_info is None:
+                report(path, FileChangeType.DELETED)
+            elif disk_info != document.disk_info:
+                report(path, FileChangeType.CHANGED)
+
+        imports_manager = self.parent.documents_cache.get_imports_manager_for_workspace_folder(folder)
+        for file in imports_manager.changed_import_files():
+            report(Path(file), FileChangeType.CHANGED if Path(file).exists() else FileChangeType.DELETED)
+
+        for file in self._found_failed_imports(folder, imports_manager):
+            report(Path(file), FileChangeType.CREATED)
+
+        if changes:
+            self.parent.workspace.did_change_watched_files(self.parent.workspace, list(changes.values()))
+
+    def _found_failed_imports(self, folder: WorkspaceFolder, imports_manager: ImportsManager) -> List[str]:
+        """The files of the failed imports whose file or module was not found and is there now."""
+        # a module created since the import failed is found only with fresh finder caches
+        importlib.invalidate_caches()
+
+        result: List[str] = []
+        for document in self._documents_of(folder):
+            namespace = self.parent.documents_cache.get_only_initialized_namespace(document)
+            if namespace is None:
+                continue
+
+            for failed in namespace.failed_imports:
+                if failed.found:
+                    continue
+                file = imports_manager.find_import_source(failed.imp, failed.base_dir, failed.variables)
+                if file is not None:
+                    result.append(file)
+        return result
+
+    def _on_workspace_loaded(self, sender: Any) -> None:
+        self._schedule_file_checks()
+
+    def _on_did_change_configuration(self, sender: Any, settings: Dict[str, Any]) -> None:
+        # the interval of a folder may have changed; the configuration is read off the thread of the notification
+        run_as_task(self._schedule_file_checks)
+
+    def _schedule_file_checks(self) -> None:
+        if self._file_checks_stopped or not self.parent.diagnostics.workspace_loaded_event.is_set():
+            return
+
+        for folder in self.parent.workspace.workspace_folders:
+            self._schedule_file_check(folder)
+
+    def _file_check_interval(self, folder: WorkspaceFolder) -> int:
+        try:
+            interval = self.parent.workspace.get_configuration(AnalysisConfig, folder.uri).file_check_interval
+        except (SystemExit, KeyboardInterrupt):
+            raise
+        except BaseException as e:
+            # without a timer the folder would not be checked again
+            self._logger.exception(e)
+            interval = AnalysisConfig().file_check_interval
+        return min(max(interval, 1), 1440)
+
+    def _schedule_file_check(self, folder: WorkspaceFolder) -> None:
+        # reading the configuration can wait for the client, so it happens without the lock that the shutdown takes
+        interval = self._file_check_interval(folder)
+
+        with self._file_check_lock:
+            if self._file_checks_stopped:
+                return
+
+            timer = self._file_check_timers.pop(str(folder.uri), None)
+            if timer is not None:
+                timer.cancel()
+
+            timer = threading.Timer(interval * 60, self._run_file_check, (folder,))
+            timer.daemon = True
+            self._file_check_timers[str(folder.uri)] = timer
+            timer.start()
+
+    def _run_file_check(self, folder: WorkspaceFolder) -> None:
+        try:
+            self.check_workspace_folder(folder)
+        except (SystemExit, KeyboardInterrupt):
+            raise
+        except BaseException as e:
+            self._logger.exception(e)
+        finally:
+            self._schedule_file_check(folder)
+
+    def _stop_file_checks(self, sender: Any) -> None:
+        with self._file_check_lock:
+            self._file_checks_stopped = True
+            for timer in self._file_check_timers.values():
+                timer.cancel()
+            self._file_check_timers.clear()
+
     @rpc_method(name="robot/cache/clear", threaded=True)
     def robot_cache_clear(self) -> None:
         for folder in self.parent.workspace.workspace_folders:

robotcode/language_server/robotframework/parts/selection_range.py

@@ -14,13 +14,14 @@ from robotcode.robot.utils.ast import (
     range_from_token,
 )
 
+from .model_variables import find_model_variable_range_at
 from .protocol_part import RobotLanguageServerProtocolPart
 
 if TYPE_CHECKING:
     from ..protocol import RobotLanguageServerProtocol
 
 
-class RobotSelectionRangeProtocolPart(RobotLanguageServerProtocolPart, ModelHelper):
+class RobotSelectionRangeProtocolPart(RobotLanguageServerProtocolPart):
     _logger = LoggingDescriptor()
 
     def __init__(self, parent: "RobotLanguageServerProtocol") -> None:
@@ -32,10 +33,12 @@ class RobotSelectionRangeProtocolPart(RobotLanguageServerProtocolPart, ModelHelp
     @_logger.call
     def collect(self, sender: Any, document: TextDocument, positions: List[Position]) -> Optional[List[SelectionRange]]:
         namespace = self.parent.documents_cache.get_namespace(document)
+        semantic_model = namespace.semantic_model
+        model = self.parent.documents_cache.get_model(document)
 
         results: List[SelectionRange] = []
         for position in positions:
-            nodes = get_nodes_at_position(self.parent.documents_cache.get_model(document), position)
+            nodes = get_nodes_at_position(model, position)
 
             if not nodes:
                 break
@@ -52,17 +55,27 @@ class RobotSelectionRangeProtocolPart(RobotLanguageServerProtocolPart, ModelHelp
                         token = tokens[-1]
                         if token is not None:
                             current_range = SelectionRange(range_from_token(token), current_range)
-                            for var_token, _ in self.iter_variables_from_token(
-                                token,
-                                namespace,
-                                position,
-                                return_not_found=True,
-                            ):
-                                var_token_range = range_from_token(var_token)
-
-                                if position in var_token_range:
-                                    current_range = SelectionRange(var_token_range, current_range)
-                                    break
+                            if semantic_model is not None:
+                                # Model path: variable step from the model's
+                                # statement tokens; the structural node/token
+                                # walk above stays on the AST.
+                                var_range = find_model_variable_range_at(
+                                    semantic_model, position, range_from_token(token)
+                                )
+                                if var_range is not None:
+                                    current_range = SelectionRange(var_range, current_range)
+                            else:
+                                for var_token, _ in ModelHelper.iter_variables_from_token(
+                                    token,
+                                    namespace,
+                                    position,
+                                    return_not_found=True,
+                                ):
+                                    var_token_range = range_from_token(var_token)
+
+                                    if position in var_token_range:
+                                        current_range = SelectionRange(var_token_range, current_range)
+                                        break
 
                 results.append(current_range)