ripperdoc 0.1.0__py3-none-any.whl → 0.2.2__py3-none-any.whl

ripperdoc/tools/notebook_edit_tool.py

@@ -101,7 +101,7 @@ class NotebookEditTool(Tool[NotebookEditInput, NotebookEditOutput]):
         return [
             ToolUseExample(
                 description="Replace a markdown cell by id",
-                input={
+                example={
                     "notebook_path": "/repo/notebooks/analysis.ipynb",
                     "cell_id": "abc123",
                     "new_source": "# Updated overview\\nThis notebook analyzes revenue.",
@@ -111,7 +111,7 @@ class NotebookEditTool(Tool[NotebookEditInput, NotebookEditOutput]):
             ),
             ToolUseExample(
                 description="Insert a new code cell at the beginning",
-                input={
+                example={
                     "notebook_path": "/repo/notebooks/analysis.ipynb",
                     "cell_type": "code",
                     "edit_mode": "insert",
@@ -165,8 +165,8 @@ class NotebookEditTool(Tool[NotebookEditInput, NotebookEditOutput]):
         try:
             raw = path.read_text(encoding="utf-8")
             nb_json = json.loads(raw)
-        except Exception as exc:
-            logger.error(f"Failed to parse notebook {path}: {exc}")
+        except Exception:
+            logger.exception("Failed to parse notebook", extra={"path": str(path)})
             return ValidationResult(
                 result=False, message="Notebook is not valid JSON.", error_code=6
             )
@@ -246,7 +246,7 @@ class NotebookEditTool(Tool[NotebookEditInput, NotebookEditOutput]):
                         "id": new_id,
                         "source": new_source,
                         "metadata": {},
-                        "execution_count": 0,
+                        "execution_count": None,  # type: ignore[dict-item]
                         "outputs": [],
                     }
                 )
@@ -285,7 +285,10 @@ class NotebookEditTool(Tool[NotebookEditInput, NotebookEditOutput]):
                 data=output, result_for_assistant=self.render_result_for_assistant(output)
             )
         except Exception as exc:  # pragma: no cover - error path
-            logger.error(f"Error editing notebook {input_data.notebook_path}: {exc}")
+            logger.exception(
+                "Error editing notebook",
+                extra={"path": input_data.notebook_path, "error": str(exc)},
+            )
             output = NotebookEditOutput(
                 new_source=new_source,
                 cell_type=cell_type or "code",

ripperdoc/tools/task_tool.py

@@ -19,6 +19,9 @@ from ripperdoc.core.query import QueryContext, query
 from ripperdoc.core.system_prompt import build_environment_prompt
 from ripperdoc.core.tool import Tool, ToolOutput, ToolProgress, ToolResult, ToolUseContext
 from ripperdoc.utils.messages import AssistantMessage, create_user_message
+from ripperdoc.utils.log import get_logger
+
+logger = get_logger()
 
 
 class TaskToolInput(BaseModel):
@@ -85,7 +88,7 @@ class TaskTool(Tool[TaskToolInput, TaskToolOutput]):
         details: List[str] = []
         if output.tool_use_count:
             details.append(f"{output.tool_use_count} tool uses")
-        details.append(f"{output.duration_ms/1000:.1f}s")
+        details.append(f"{output.duration_ms / 1000:.1f}s")
         if output.missing_tools:
             details.append(f"missing tools: {', '.join(output.missing_tools)}")
 
@@ -125,11 +128,18 @@ class TaskTool(Tool[TaskToolInput, TaskToolOutput]):
                 f"Missing or unknown tools: {', '.join(missing_tools) if missing_tools else 'none'}"
             )
 
-        agent_system_prompt = self._build_agent_prompt(target_agent, agent_tools)
+        # Type conversion: List[object] -> List[Tool[Any, Any]]
+        from ripperdoc.core.tool import Tool
+
+        typed_agent_tools: List[Tool[Any, Any]] = [
+            tool for tool in agent_tools if isinstance(tool, Tool)
+        ]
+
+        agent_system_prompt = self._build_agent_prompt(target_agent, typed_agent_tools)
         subagent_messages = [create_user_message(input_data.prompt)]
 
         subagent_context = QueryContext(
-            tools=agent_tools,
+            tools=typed_agent_tools,
             safe_mode=context.safe_mode,
             verbose=context.verbose,
             model=target_agent.model or "task",
@@ -142,7 +152,7 @@ class TaskTool(Tool[TaskToolInput, TaskToolOutput]):
         yield ToolProgress(content=f"Launching subagent '{target_agent.agent_type}'")
 
         async for message in query(
-            subagent_messages,
+            subagent_messages,  # type: ignore[arg-type]
             agent_system_prompt,
             {},
             subagent_context,
@@ -183,7 +193,8 @@ class TaskTool(Tool[TaskToolInput, TaskToolOutput]):
                                     )
                                     yield ToolProgress(content=f"Subagent: {short}")
                 assistant_messages.append(message)  # type: ignore[arg-type]
-                tool_use_count += self._count_tool_uses(message)
+                if isinstance(message, AssistantMessage):
+                    tool_use_count += self._count_tool_uses(message)
 
         duration_ms = (time.time() - start) * 1000
         result_text = (
@@ -276,6 +287,10 @@ class TaskTool(Tool[TaskToolInput, TaskToolOutput]):
             try:
                 serialized = json.dumps(inp, ensure_ascii=False)
             except Exception:
+                logger.exception(
+                    "[task_tool] Failed to serialize tool_use input",
+                    extra={"tool_use_input": str(inp)},
+                )
                 serialized = str(inp)
             return serialized if len(serialized) <= 120 else serialized[:117] + "..."
 

ripperdoc/tools/todo_tool.py

@@ -14,6 +14,7 @@ from ripperdoc.core.tool import (
     ToolUseExample,
     ValidationResult,
 )
+from ripperdoc.utils.log import get_logger
 from ripperdoc.utils.todo import (
     TodoItem,
     TodoPriority,
@@ -27,9 +28,14 @@ from ripperdoc.utils.todo import (
     validate_todos,
 )
 
+logger = get_logger()
+
+DEFAULT_ACTION = "Edit"
+
 TODO_WRITE_PROMPT = dedent(
-    """\
-    Use this tool to create and manage a structured task list for your current coding session. This helps you track progress, organize complex tasks, and demonstrate thoroughness to the user. It also helps the user understand the progress of the task and overall progress of their requests.
+    f"""\
+    Use this tool to create and manage a structured task list for your current coding session. This helps you track progress, organize complex tasks, and demonstrate thoroughness to the user.
+    It also helps the user understand the progress of the task and overall progress of their requests.
 
     ## When to Use This Tool
     Use this tool proactively in these scenarios:
@@ -52,30 +58,155 @@ TODO_WRITE_PROMPT = dedent(
 
     NOTE that you should not use this tool if there is only one trivial task to do. In this case you are better off just doing the task directly.
 
+    ## Examples of When to Use the Todo List
+
+    <example>
+    User: I want to add a dark mode toggle to the application settings. Make sure you run the tests and build when you're done!
+    Assistant: I'll help add a dark mode toggle to your application settings. Let me create a todo list to track this implementation.
+    *Creates todo list with the following items:*
+    1. Create dark mode toggle component in Settings page
+    2. Add dark mode state management (context/store)
+    3. Implement CSS-in-JS styles for dark theme
+    4. Update existing components to support theme switching
+    5. Run tests and build process, addressing any failures or errors that occur
+    *Begins working on the first task*
+
+    <reasoning>
+    The assistant used the todo list because:
+    1. Adding dark mode is a multi-step feature requiring UI, state management, and styling changes
+    2. The user explicitly requested tests and build be run afterward
+    3. The assistant inferred that tests and build need to pass by adding "Ensure tests and build succeed" as the final task
+    </reasoning>
+    </example>
+
+    <example>
+    User: Help me rename the function getCwd to getCurrentWorkingDirectory across my project
+    Assistant: Let me first search through your codebase to find all occurrences of 'getCwd'.
+    *Uses grep or search tools to locate all instances of getCwd in the codebase*
+    Assistant: I've found 15 instances of 'getCwd' across 8 different files. Let me create a todo list to track these changes.
+    *Creates todo list with specific items for each file that needs updating*
+
+    <reasoning>
+    The assistant used the todo list because:
+    1. First, the assistant searched to understand the scope of the task
+    2. Upon finding multiple occurrences across different files, it determined this was a complex task with multiple steps
+    3. The todo list helps ensure every instance is tracked and updated systematically
+    4. This approach prevents missing any occurrences and maintains code consistency
+    </reasoning>
+    </example>
+
+
+    <example>
+    User: I need to implement these features for my e-commerce site: user registration, product catalog, shopping cart, and checkout flow.
+    Assistant: I'll help implement these features. First, let's add all the features to the todo list.
+    *Creates a todo list breaking down each feature into specific tasks based on the project architecture*
+    Assistant: Let's start with user registration. This will involve creating database models, API endpoints, and frontend forms that integrate with your existing authentication system.
+
+    <reasoning>
+    The assistant used the todo list because:
+    1. The user provided multiple complex features to implement in a comma separated list
+    2. The todo list helps organize these large features into manageable tasks
+    3. This approach allows for tracking progress across the entire implementation
+    </reasoning>
+    </example>
+
+    <example>
+    User: Can you help optimize my React application? It's rendering slowly and has performance issues.</user>
+    Assistant: I'll help optimize your React application. First, let me examine your codebase to identify potential performance bottlenecks.
+    *Reviews component structure, render patterns, state management, and data fetching*
+    Assistant: After analyzing your codebase, I've identified several performance issues. Let me create a todo list to track our optimization efforts.
+    *Creates todo list with items like: 1) Implement memoization for expensive calculations in ProductList, 2) Add virtualization for long lists in Dashboard, 3) Optimize image loading in Gallery component, 4) Fix state update loops in ShoppingCart, 5) Review bundle size and implement code splitting*
+    Let's start by implementing memoization for the expensive calculations in your ProductList component.</assistant>
+
+    <reasoning>
+    The assistant used the todo list because:
+    1. First, the assistant examined the codebase to identify specific performance issues
+    2. Based on this analysis, it identified multiple optimization opportunities
+    3. Performance optimization is a non-trivial task requiring multiple steps
+    4. The todo list helps methodically track improvements across different components
+    5. This systematic approach ensures all performance bottlenecks are addressed
+    </reasoning>
+    </example>
+
+    ## Examples of When NOT to Use the Todo List
+
+    <example>
+    User: How do I print 'Hello World' in Python?
+    Assistant: In Python, you can print "Hello World" with this simple code:
+
+    python
+    print("Hello World")
+
+    This will output the text "Hello World" to the console when executed.</assistant>
+
+    <reasoning>
+    The assistant did not use the todo list because this is a single, trivial task that can be completed in one step. There's no need to track multiple tasks or steps for such a straightforward request.
+    </reasoning>
+    </example>
+
+    <example>
+    User: What does the git status command do?
+    Assistant: The git status command shows the current state of your working directory and staging area. It displays which changes have been staged, which haven't, and which files aren't being tracked by Git. This is a fundamental command for understanding the current state of your repository before making commits.
+
+    <reasoning>
+    The assistant did not use the todo list because this is an informational request with no actual coding task to complete. The user is simply asking for an explanation, not for the assistant to perform multiple steps or tasks.
+    </reasoning>
+    </example>
+
+    <example>
+    User: Can you add a comment to the calculateTotal function to explain what it does?
+    Assistant: Sure, let me add a comment to the calculateTotal function to explain what it does.
+    * Uses the ${DEFAULT_ACTION} tool to add a comment to the calculateTotal function *
+
+    <reasoning>
+    The assistant did not use the todo list because this is a single, straightforward task confined to one location in the code. Adding a comment doesn't require tracking multiple steps or systematic organization.
+    </reasoning>
+    </example>
+
+    <example>
+    User: Run npm install for me and tell me what happens.
+    Assistant: I'll run the npm install command for you.
+
+    *Executes: npm install*
+
+    The command completed successfully. Here's the output:
+    [Output of npm install command]
+
+    All dependencies have been installed according to your package.json file.
+
+    <reasoning>
+    The assistant did not use the todo list because this is a single command execution with immediate results. There are no multiple steps to track or organize, making the todo list unnecessary for this straightforward task.
+    </reasoning>
+    </example>
+
     ## Task States and Management
 
-    1. Task States:
-       - pending: Task not yet started
-       - in_progress: Currently working on (limit to ONE task at a time)
-       - completed: Task finished successfully
-
-    2. Task Management:
-       - Update task status in real-time as you work
-       - Mark tasks complete IMMEDIATELY after finishing (don't batch completions)
-       - Only have ONE task in_progress at any time
-       - Complete current tasks before starting new ones
-       - Remove tasks that are no longer relevant from the list entirely
-
-    3. Task Completion Requirements:
-       - ONLY mark a task as completed when you have FULLY accomplished it
-       - If you encounter errors, blockers, or cannot finish, keep the task as in_progress
-       - When blocked, create a new task describing what needs to be resolved
-       - Never mark a task as completed if tests are failing, implementation is partial, errors are unresolved, or needed files are missing
-
-    4. Task Breakdown:
-       - Create specific, actionable items
-       - Break complex tasks into smaller, manageable steps
-       - Use clear, descriptive task names
+    1. **Task States**: Use these states to track progress:
+    - pending: Task not yet started
+    - in_progress: Currently working on (limit to ONE task at a time)
+    - completed: Task finished successfully
+
+    2. **Task Management**:
+    - Update task status in real-time as you work
+    - Mark tasks complete IMMEDIATELY after finishing (don't batch completions)
+    - Only have ONE task in_progress at any time
+    - Complete current tasks before starting new ones
+    - Remove tasks that are no longer relevant from the list entirely
+
+    3. **Task Completion Requirements**:
+    - ONLY mark a task as completed when you have FULLY accomplished it
+    - If you encounter errors, blockers, or cannot finish, keep the task as in_progress
+    - When blocked, create a new task describing what needs to be resolved
+    - Never mark a task as completed if:
+        - Tests are failing
+        - Implementation is partial
+        - You encountered unresolved errors
+        - You couldn't find necessary files or dependencies
+
+    4. **Task Breakdown**:
+    - Create specific, actionable items
+    - Break complex tasks into smaller, manageable steps
+    - Use clear, descriptive task names
 
     When in doubt, use this tool. Being proactive with task management demonstrates attentiveness and ensures you complete all requirements successfully.
     """
@@ -130,7 +261,7 @@ class TodoWriteTool(Tool[TodoWriteToolInput, TodoToolOutput]):
         return "TodoWrite"
 
     async def description(self) -> str:
-        return "Create and update a structured task list for the current session."
+        return "Update the todo list for the current session. To be used proactively and often to track progress and pending tasks."
 
     @property
     def input_schema(self) -> type[TodoWriteToolInput]:
@@ -140,7 +271,7 @@ class TodoWriteTool(Tool[TodoWriteToolInput, TodoToolOutput]):
         return [
             ToolUseExample(
                 description="Seed a three-step plan",
-                input={
+                example={
                     "todos": [
                         {
                             "id": "plan",
@@ -165,7 +296,7 @@ class TodoWriteTool(Tool[TodoWriteToolInput, TodoToolOutput]):
             ),
             ToolUseExample(
                 description="Update a single task already in progress",
-                input={
+                example={
                     "todos": [
                         {
                             "id": "bugfix-123",
@@ -230,6 +361,9 @@ class TodoWriteTool(Tool[TodoWriteToolInput, TodoToolOutput]):
             )
             yield ToolResult(data=output, result_for_assistant=result_text)
         except Exception as exc:
+            logger.exception(
+                "[todo_tool] Error updating todos", extra={"error": str(exc)}
+            )
             error = f"Error updating todos: {exc}"
             yield ToolResult(
                 data=TodoToolOutput(
@@ -263,11 +397,11 @@ class TodoReadTool(Tool[TodoReadToolInput, TodoToolOutput]):
         return [
             ToolUseExample(
                 description="Get only the next actionable todo",
-                input={"next_only": True},
+                example={"next_only": True},
             ),
             ToolUseExample(
                 description="List recent completed tasks with a limit",
-                input={"status": ["completed"], "limit": 5},
+                example={"status": ["completed"], "limit": 5},
             ),
         ]
 

ripperdoc/tools/tool_search_tool.py

@@ -19,6 +19,10 @@ from ripperdoc.core.tool import (
     ValidationResult,
     build_tool_description,
 )
+from ripperdoc.utils.log import get_logger
+
+
+logger = get_logger()
 
 
 class ToolSearchInput(BaseModel):
@@ -94,11 +98,11 @@ class ToolSearchTool(Tool[ToolSearchInput, ToolSearchOutput]):
         return [
             ToolUseExample(
                 description="Search for notebook-related tools and activate top results",
-                input={"query": "notebook", "max_results": 3},
+                example={"query": "notebook", "max_results": 3},
             ),
             ToolUseExample(
                 description="Activate a known tool by name",
-                input={"names": ["mcp__search__query"], "auto_activate": True},
+                example={"names": ["mcp__search__query"], "auto_activate": True},
             ),
         ]
 
@@ -119,7 +123,9 @@ class ToolSearchTool(Tool[ToolSearchInput, ToolSearchOutput]):
         return False
 
     async def validate_input(
-        self, input_data: ToolSearchInput, context: Optional[ToolUseContext] = None  # noqa: ARG002
+        self,
+        input_data: ToolSearchInput,
+        context: Optional[ToolUseContext] = None,  # noqa: ARG002
     ) -> ValidationResult:
         if not (input_data.query or input_data.names):
             return ValidationResult(
@@ -172,6 +178,7 @@ class ToolSearchTool(Tool[ToolSearchInput, ToolSearchOutput]):
                 regex = re.compile(normalized[1:-1], re.IGNORECASE)
             except re.error:
                 regex = None
+                logger.exception("[tool_search] Invalid regex search query", extra={"query": query})
 
         def _tokenize(text: str) -> List[str]:
             return re.findall(r"[a-z0-9]+", text.lower())
@@ -184,6 +191,10 @@ class ToolSearchTool(Tool[ToolSearchInput, ToolSearchOutput]):
                 )
             except Exception:
                 description = ""
+                logger.exception(
+                    "[tool_search] Failed to build tool description",
+                    extra={"tool_name": getattr(tool, "name", None)},
+                )
             doc_text = " ".join([name, tool.user_facing_name(), description])
             tokens = _tokenize(doc_text)
             corpus.append((name, tool, tokens, len(tokens), description))
@@ -193,7 +204,7 @@ class ToolSearchTool(Tool[ToolSearchInput, ToolSearchOutput]):
 
         avg_len = sum(doc_len for _, _, _, doc_len, _ in corpus) / len(corpus)
         query_terms = _tokenize(normalized)
-        df = defaultdict(int)
+        df: Dict[str, int] = defaultdict(int)
         for _, _, tokens, _, _ in corpus:
             seen_terms = set(tokens)
             for term in query_terms: