reciprocalspaceship 1.0.3__py3-none-any.whl → 1.0.4__py3-none-any.whl

reciprocalspaceship/VERSION

@@ -1 +1 @@
-1.0.3
+1.0.4

reciprocalspaceship/commandline/cifdump.py

@@ -0,0 +1,115 @@
+#!/usr/bin/env python
+"""
+Summarize the contents of a CIF file.
+
+Examples
+--------
+In order to summarize contents of file.cif::
+
+    > rs.cifdump file.cif
+
+If you would like to interactively inspect file.cif in an IPython
+shell, use the "--embed" argument::
+
+    > rs.cifdump file.cif --embed
+
+If multiple CIF files are listed, they will be summarized sequentially,
+and can be accessed in an IPython shell as a dictionary called `cifs`::
+
+    > rs.cifdump file1.cif file2.cif file3.cif --embed
+
+Usage Details
+-------------
+"""
+import argparse
+
+import pandas as pd
+
+import reciprocalspaceship as rs
+
+# If matplotlib is available, use pylab to setup IPython environment
+try:
+    from pylab import *
+except:
+    pass
+
+
+def parse_arguments():
+    """Parse commandline arguments"""
+
+    parser = argparse.ArgumentParser(
+        formatter_class=argparse.RawTextHelpFormatter, description=__doc__
+    )
+
+    # Required arguments
+    parser.add_argument("cif", nargs="+", help="CIF file(s) to summarize")
+
+    # Optional arguments
+    parser.add_argument(
+        "--embed",
+        action="store_true",
+        help=(
+            "CIF file(s) will be summarized, and an IPython " "shell will be started"
+        ),
+    )
+    parser.add_argument(
+        "-p",
+        "--precision",
+        type=int,
+        default=3,
+        help="Number of significant digits to output for floats",
+    )
+
+    return parser
+
+
+def summarize(cif, precision):
+    """Summarize contents of CIF file"""
+    with pd.option_context("display.precision", precision):
+        print(f"Spacegroup: {cif.spacegroup.short_name()}")
+        print(f"Extended Hermann-Mauguin name: {cif.spacegroup.xhm()}")
+        print(
+            (
+                f"Unit cell dimensions: {cif.cell.a:.3f} {cif.cell.b:.3f} {cif.cell.c:.3f} "
+                f"{cif.cell.alpha:.3f} {cif.cell.beta:.3f} {cif.cell.gamma:.3f}"
+            )
+        )
+        print(f"\ncif.head():\n\n{cif.head()}")
+        print(f"\ncif.describe():\n\n{cif.describe()}")
+        print(f"\ncif.dtypes:\n\n{cif.dtypes}")
+    return
+
+
+def main():
+    # Parse commandline arguments
+    parser = parse_arguments()
+    args = parser.parse_args()
+
+    if len(args.cif) == 1:
+        cif = rs.read_cif(args.cif[0])
+        summarize(cif, args.precision)
+    else:
+        cifs = dict(zip(args.cif, map(rs.read_cif, args.cif)))
+        for key, value in cifs.items():
+            print(f"CIF file: {key}\n")
+            summarize(value, args.precision)
+            print(f"{'-'*50}")
+
+    # Begin IPython shell
+    if args.embed:
+        from IPython import embed
+
+        bold = "\033[1m"
+        end = "\033[0m"
+        if "cifs" in locals():
+            header = f"rs.DataSets stored in {bold}cifs{end} dictionary"
+        else:
+            header = f"rs.DataSet stored as {bold}cif{end}"
+        print()
+        embed(colors="neutral", header=header)
+
+    return
+
+
+if __name__ == "__main__":
+    parser = main()

reciprocalspaceship/commandline/mtzdump.py

@@ -74,9 +74,13 @@ def summarize(mtz, precision):
                 f"{mtz.cell.alpha:.3f} {mtz.cell.beta:.3f} {mtz.cell.gamma:.3f}"
             )
         )
-        print(f"\nmtz.head():\n\n{mtz.head()}")
-        print(f"\nmtz.describe():\n\n{mtz.describe()}")
-        print(f"\nmtz.dtypes:\n\n{mtz.dtypes}")
+        if mtz.cell is not None:
+            dHKL = mtz.compute_dHKL().dHKL
+            print(f"Resolution range:  {dHKL.max():.3f} - {dHKL.min():.3f} Å")
+        with pd.option_context("display.max_rows", None):
+            print(f"\nmtz.head():\n\n{mtz.head()}")
+            print(f"\nmtz.describe().T:\n\n{mtz.describe().T}")
+            print(f"\nmtz.dtypes:\n\n{mtz.dtypes}")
     return
 
 

reciprocalspaceship/dataset.py

@@ -43,6 +43,23 @@ class DataSet(pd.DataFrame):
     and attributes, please see the `Pandas.DataFrame documentation`_.
 
     .. _Pandas.DataFrame documentation: https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.html
+
+    Attributes
+    ----------
+    acentrics : rs.DataSet
+        Access only the acentric reflections in this dataset
+    cell : gemmi.UnitCell
+        The unit cell
+    centrics : rs.DataSet
+        Access only the centric reflections in this dataset
+    hkls : ndarray, shape=(n_reflections, 3)
+        Miller indices in DataSet.
+    merged : bool
+        Whether this is a merged dataset or unmerged
+    spacegroup : gemmi.SpaceGroup
+        The space group
+    reindexing_ops : list
+        Possible reindexing ops consistent with the cell and spacegroup
     """
 
     _metadata = ["_spacegroup", "_cell", "_index_dtypes", "_merged"]
@@ -131,6 +148,38 @@ class DataSet(pd.DataFrame):
     def merged(self, val):
         self._merged = val
 
+    @property
+    @range_indexed
+    def hkls(self):
+        """Miller indices"""
+        hkl = self[["H", "K", "L"]].to_numpy(dtype=np.int32)
+        return hkl
+
+    def get_hkls(self):
+        """Get the Miller indices of the dataset."""
+        return self.hkls
+
+    @hkls.setter
+    @range_indexed
+    def hkls(self, hkls):
+        if isinstance(hkls, DataSet):
+            """Convert to numpy if hkls is a dataset"""
+            hkls = hkls.hkls
+        if isinstance(hkls, np.ndarray):
+            h, k, l = hkls[..., 0], hkls[..., 1], hkls[..., 2]
+        else:
+            """Try coercing to numpy"""
+            try:
+                hkls = np.array(hkls)
+                h, k, l = hkls[..., 0], hkls[..., 1], hkls[..., 2]
+            except:
+                raise ValueError(
+                    "Unable to convert hkls to a suitable type. Please ensure hkls is a numpy array or rs.DataSet"
+                )
+        self["H"] = DataSeries(h, index=self.index, dtype="H")
+        self["K"] = DataSeries(k, index=self.index, dtype="H")
+        self["L"] = DataSeries(l, index=self.index, dtype="H")
+
     @property
     def centrics(self):
         """Access centric reflections in DataSet"""
@@ -1585,24 +1634,6 @@ class DataSet(pd.DataFrame):
         warnings.simplefilter("always")
         warnings.warn(message, DeprecationWarning)
 
-        if dmin is not None:
-            ds = self.loc[self.compute_dHKL().dHKL >= dmin, [key]]
-        else:
-            ds = self.loc[:, [key]]
-
-        if gridsize is None:
-            gridsize = self.get_reciprocal_grid_size(dmin=dmin, sample_rate=sample_rate)
-
-        # Set up P1 unit cell
-        p1 = ds.expand_to_p1()
-        p1 = p1.expand_anomalous()
-
-        # Get data and indices
-        data = p1[key].to_numpy()
-        H = p1.get_hkls()
-
-        # Populate grid
-        grid = np.zeros(gridsize, dtype=data.dtype)
-        grid[H[:, 0], H[:, 1], H[:, 2]] = data
-
-        return grid
+        return self.to_reciprocal_grid(
+            key, sample_rate=sample_rate, dmin=dmin, grid_size=gridsize
+        )

reciprocalspaceship/io/precognition.py

@@ -31,7 +31,7 @@ def read_precognition(hklfile, spacegroup=None, cell=None, logfile=None):
         F = pd.read_csv(
             hklfile,
             header=None,
-            delim_whitespace=True,
+            sep="\\s+",
             names=["H", "K", "L", "F(+)", "SigF(+)", "F(-)", "SigF(-)"],
             usecols=usecols,
         )
@@ -49,7 +49,7 @@ def read_precognition(hklfile, spacegroup=None, cell=None, logfile=None):
         F = pd.read_csv(
             hklfile,
             header=None,
-            delim_whitespace=True,
+            sep="\\s+",
             names=[
                 "H",
                 "K",

reciprocalspaceship/utils/cell.py

@@ -29,7 +29,7 @@ def compute_dHKL(H, cell):
     if inverse.shape[-1] == 1:
         inverse = inverse.squeeze(-1)
 
-    F = np.array(cell.fractionalization_matrix.tolist()).astype(np.float64)
+    F = np.array(cell.frac.mat, dtype=np.float64)
     dhkls = np.reciprocal(np.linalg.norm((hkls @ F), 2, 1)).astype(np.float32)
     return dhkls[inverse]
 

reciprocalspaceship/utils/grid.py

@@ -50,6 +50,7 @@ def get_reciprocal_grid_size(cell, dmin, sample_rate=3.0, spacegroup=None):
 
     # Use gemmi.Mtz to find valid grid (FFT-friendly and obeys symmetry)
     m = gemmi.Mtz()
-    m.spacegroup = spacegroup
+    if spacegroup is not None:
+        m.spacegroup = spacegroup
 
     return m.get_size_for_hkl(min_size=min_size)

reciprocalspaceship/utils/structurefactors.py

@@ -131,4 +131,4 @@ def is_absent(H, spacegroup):
     absent : array
         Boolean array of length n. absent[i] == True if H[i] is systematically absent in sg.
     """
-    return spacegroup.operations().systematic_absences(H)
+    return spacegroup.operations().systematic_absences(np.array(H, dtype=np.int32))

{reciprocalspaceship-1.0.3.dist-info → reciprocalspaceship-1.0.4.dist-info}/METADATA

@@ -1,6 +1,6 @@
-Metadata-Version: 2.1
+Metadata-Version: 2.4
 Name: reciprocalspaceship
-Version: 1.0.3
+Version: 1.0.4
 Summary: Tools for exploring reciprocal space
 Home-page: https://rs-station.github.io/reciprocalspaceship/
 Author: Kevin M. Dalton, Jack B. Greisman
@@ -19,7 +19,7 @@ Classifier: Topic :: Software Development :: Libraries :: Python Modules
 Classifier: Programming Language :: Python
 Requires-Python: >=3.9
 License-File: LICENSE
-Requires-Dist: gemmi<=0.6.7,>=0.5.5
+Requires-Dist: gemmi<=0.7.1,>=0.7.0
 Requires-Dist: pandas<=2.2.3,>=2.2.2
 Requires-Dist: numpy
 Requires-Dist: scipy
@@ -31,7 +31,7 @@ Requires-Dist: pytest-cov; extra == "dev"
 Requires-Dist: pytest-xdist; extra == "dev"
 Requires-Dist: ray; extra == "dev"
 Requires-Dist: sphinx; extra == "dev"
-Requires-Dist: sphinx-rtd-theme; extra == "dev"
+Requires-Dist: sphinx_rtd_theme; extra == "dev"
 Requires-Dist: nbsphinx; extra == "dev"
 Requires-Dist: sphinx-design; extra == "dev"
 Requires-Dist: sphinxcontrib-autoprogram; extra == "dev"
@@ -49,6 +49,18 @@ Requires-Dist: matplotlib; extra == "examples"
 Requires-Dist: seaborn; extra == "examples"
 Requires-Dist: celluloid; extra == "examples"
 Requires-Dist: scikit-image; extra == "examples"
+Dynamic: author
+Dynamic: author-email
+Dynamic: classifier
+Dynamic: description
+Dynamic: home-page
+Dynamic: license
+Dynamic: license-file
+Dynamic: project-url
+Dynamic: provides-extra
+Dynamic: requires-dist
+Dynamic: requires-python
+Dynamic: summary
 
 
 ``reciprocalspaceship`` provides a ``pandas``-style interface for

{reciprocalspaceship-1.0.3.dist-info → reciprocalspaceship-1.0.4.dist-info}/RECORD

@@ -1,15 +1,16 @@
-reciprocalspaceship/VERSION,sha256=9eXJU0UyhA_NRbsALmnthcYduidTRQ4mtEi33xSB4k0,6
+reciprocalspaceship/VERSION,sha256=0bd7iPS59nWpAOQUOsdoohIYYjz-FwPKQxYjiMMnG9Y,6
 reciprocalspaceship/__init__.py,sha256=m6pXLI-HuXwefCfSE2Rs_2McqzuHw5W6yMBXEbceke8,2034
 reciprocalspaceship/concat.py,sha256=v2eg8-RBiNLYHkkPDeaozh3HvGCaFbmlC15FaeNJMgY,1695
 reciprocalspaceship/dataseries.py,sha256=ibU1bHMd8zORFxRtDswtvLh_n-miAyBqO0ghLmY29Js,6188
-reciprocalspaceship/dataset.py,sha256=6GMIMWVdKzOFhFsgODgvFn2-hrrMRMPw3-oDzlbL0YQ,57698
+reciprocalspaceship/dataset.py,sha256=xLgTcmVuypcyTepu1gnLu3YpBz1KowzNQcCQwNpADDM,58889
 reciprocalspaceship/decorators.py,sha256=sZAPAV5fk5zUlwzub2VZy-u28XVNXjBpnqwnKjESWgY,5721
 reciprocalspaceship/algorithms/__init__.py,sha256=r5IYCGswTHXpSs9Q7c6PfEz8_P8d1fEei2SyTkp5aYY,258
 reciprocalspaceship/algorithms/intensity.py,sha256=iDHaqqrMAe0v-aTVT5jf54JwkNQLSQ7HhezPw6qZndg,2657
 reciprocalspaceship/algorithms/merge.py,sha256=iwPrDfjtliBwLqEzHbcIfoTkvS_0s2_CszS5IfrEUXI,2154
 reciprocalspaceship/algorithms/scale_merged_intensities.py,sha256=hNKKISCCDvchail1PZ_0r6sq1Rbgoraqaz1aDCayTYQ,11269
 reciprocalspaceship/commandline/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-reciprocalspaceship/commandline/mtzdump.py,sha256=JBg_W-CWQ6rbOOVmtK7TsErFXhCBR5pmC5RRSCapEZg,2939
+reciprocalspaceship/commandline/cifdump.py,sha256=X9dU2nTFX-5sPlb6miWo7feMc7BPrTnBJsrbS_fOxmo,2938
+reciprocalspaceship/commandline/mtzdump.py,sha256=ERSk2ORoOTtsdjml-QdxgozS6uzjMvAFWgKv163nVyM,3169
 reciprocalspaceship/dtypes/__init__.py,sha256=cO0M2F6pO_0jtqx-MlkbzqxLSmK1Ibmon5p_ksWmcbk,1038
 reciprocalspaceship/dtypes/base.py,sha256=1X56U4jKt_wjVkW930C9gP2Di0RpCMDZsDKNTxYle5I,1052
 reciprocalspaceship/dtypes/floating.py,sha256=jOQ25GZEE4QromaJA3_oeu0Tkjq1iT4dHCke_7W6TYo,19675
@@ -26,37 +27,37 @@ reciprocalspaceship/io/dials.py,sha256=FQQa3eT9TQw7h43ohyvNI3huViHE-eP9Y4IbRQL5d
 reciprocalspaceship/io/dials_mpi.py,sha256=wvm-sQqFG7N7bgcnxd5jn94eyKveimA3rvP8ns1B5Jg,1212
 reciprocalspaceship/io/mtz.py,sha256=_gdlx7Vi6Z0HyFBZFP6Ptmla7Pd_mON2KaGL4Q3N7Ik,8071
 reciprocalspaceship/io/pickle.py,sha256=clnSTK8T2O_d7midS_E54WHmXEHrL10d386gWx7ztsM,818
-reciprocalspaceship/io/precognition.py,sha256=DWRE2erXPVpm9-y5DjIWUHfmv9jZcsqoa47ienp1Sao,3641
+reciprocalspaceship/io/precognition.py,sha256=xHBeKarVABmtm1DaYUOSs2UYsS3CFTDLCAd47jO03nI,3619
 reciprocalspaceship/stats/__init__.py,sha256=jdAWbpD_CKAn0W0sO_MKSnTu3bZSoLAXgb1_Y6jDMzk,197
 reciprocalspaceship/stats/completeness.py,sha256=1QM-Ac_V58nTLJoewbOK5CL69qsb0C0sc8L0c59WorQ,6702
 reciprocalspaceship/utils/__init__.py,sha256=bKJwbkxXa-TX2etIQgIESKkv9kdag1rHL77JLhI-2B8,1714
 reciprocalspaceship/utils/asu.py,sha256=WwxvIq-_QEF2UvyELuNudVo53daty9wiN-vaOYAUbKI,8680
 reciprocalspaceship/utils/binning.py,sha256=CHf5z8EsHSg34ZgC-yM_8Gd3D2BB8cqTtHAf7vwfgLo,2786
-reciprocalspaceship/utils/cell.py,sha256=aNIaugA3F8CRs9n8Ck0Rjc8YI7qHZcW3lJPE7yvj0dk,2053
-reciprocalspaceship/utils/grid.py,sha256=xB7sw1xrhgzFojrVHbC_uVBT3NMTBsvKsCqaRrVfvTQ,1893
+reciprocalspaceship/utils/cell.py,sha256=MCebTyHrPiiy1H0A6OX3KWTrssw2LJ7ziA-anrfZULU,2027
+reciprocalspaceship/utils/grid.py,sha256=MCpQ9wy0XN0U-Q7H3fwGmWlMzO1RiZtBYkIdDWxG7p4,1928
 reciprocalspaceship/utils/math.py,sha256=m6Iq9u0fjiieftzjQPAEHTN2htBIOwLhBCJdrcIN5Ao,1019
 reciprocalspaceship/utils/phases.py,sha256=zyiE99bq-TV_4aI6ZhBi4MLAvKwE3Sx1dFqppJL5rkE,2438
 reciprocalspaceship/utils/rfree.py,sha256=qFgepLOfgdU-cvZIMu8WfzlFExTc4jILff2ro7iu8FQ,3411
 reciprocalspaceship/utils/stats.py,sha256=p_1R3bTVVAVlDWh-hzcurlT8GOHkJA8ovFuQjD0w5AY,3681
-reciprocalspaceship/utils/structurefactors.py,sha256=ZW6CVPn_04dxay0DDnA0-byUrZnGraQ0kItqN1m5F3k,3686
+reciprocalspaceship/utils/structurefactors.py,sha256=ykcog4yTuVrANrEnQxB7La5QQFn-7D38xsK3on_qVa0,3712
 reciprocalspaceship/utils/symmetry.py,sha256=xsYmEUo0PTH57-kctJdUq_-k14ci5LUGeG5LwzmjjPU,2963
 reciprocalspaceship/utils/units.py,sha256=ng-2hzZBERYo9bnQDPr-HLr7xPah-JzOthfrpHH816Y,388
+reciprocalspaceship-1.0.4.dist-info/licenses/LICENSE,sha256=E22aZlYy5qJsJCJ94EkO_Vt3COio5UcLg59dZLPam7I,1093
 tests/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tests/conftest.py,sha256=bQZClqzu3lonsI01OdP5X38asMd7F76fAGzlWWYPXAI,3930
 tests/test_dataseries.py,sha256=go-q5tT8lLq3tlRVnmrwUytK7PlaoKs3CBPjWryGfGg,3309
-tests/test_dataset.py,sha256=Ir9cFhrzAtMAnoLZikrkiLqKUbDvCTr3xqdzeaKLH3M,23759
+tests/test_dataset.py,sha256=VTyLNJggHtisRsYpegshbtFTYgOGES6QIAo2faVwnic,25011
 tests/test_dataset_anomalous.py,sha256=LQb1inSS_oDbVYEIyyx_GBFAkXGlEQYZ-ZhpwMeyMmQ,6963
 tests/test_dataset_binning.py,sha256=NgD_vy-TUh3vQrUVgysVBSZu75xN66LR6hRu2_qAUTs,3564
-tests/test_dataset_grid.py,sha256=S2EswVAbcg08WT9TjLtQ3YF1_zJmEKcucHrN3Lw5EM8,4086
+tests/test_dataset_grid.py,sha256=tVFEUl3YA8XhCJa8tMNXQelakIgm5kStp10VhwTPzkY,4070
 tests/test_dataset_index.py,sha256=-6sMVgAKkkcYRc7UfLuVEH3p7D83o1S7e7c6MbrOrZo,2842
 tests/test_dataset_preserve_attributes.py,sha256=gwQQJGsiBZld2KKmLrcMkuc9zesR3FD7GVnPDNRScto,5314
 tests/test_dataset_signatures.py,sha256=ZbH9JNzqAWJDfVh9gqZVQXx8glmmBUhsbPmQBHe8Cuo,1554
 tests/test_dataset_symops.py,sha256=PV86tLu1qDACuk-YqjYQszk8Ctb0-h_NsQRnuCDFnOU,10864
 tests/test_decorators.py,sha256=ExR7mCU0iIqhHo4ho6ywPrZIEaGcsElaI4jtH9o5afE,5331
 tests/test_summarize_mtz_dtypes.py,sha256=JE0ctXMWii1AV-cmKogF6hjb8NCHrgvxNZ0ZRCHh-Ho,696
-reciprocalspaceship-1.0.3.dist-info/LICENSE,sha256=E22aZlYy5qJsJCJ94EkO_Vt3COio5UcLg59dZLPam7I,1093
-reciprocalspaceship-1.0.3.dist-info/METADATA,sha256=nvD6MJEEv_RHH-Dx5gj5fIvyHRRoTVUfkZxts37goQ4,3079
-reciprocalspaceship-1.0.3.dist-info/WHEEL,sha256=bFJAMchF8aTQGUgMZzHJyDDMPTO3ToJ7x23SLJa1SVo,92
-reciprocalspaceship-1.0.3.dist-info/entry_points.txt,sha256=Bqjl2J8UrG4UAHHhPbdH5r-xYaOdLCEdyRH6zJ9joDw,76
-reciprocalspaceship-1.0.3.dist-info/top_level.txt,sha256=tOo679MsLFS7iwiYZDwnKTuTpJLYVFBk6g9xnnB_s-w,26
-reciprocalspaceship-1.0.3.dist-info/RECORD,,
+reciprocalspaceship-1.0.4.dist-info/METADATA,sha256=KhsqyH2rHwyy83eL3383KyLkX0EeoAbuHB11kdjd8VU,3326
+reciprocalspaceship-1.0.4.dist-info/WHEEL,sha256=0CuiUZ_p9E4cD6NyLD6UG80LBXYyiSYZOKDm5lp32xk,91
+reciprocalspaceship-1.0.4.dist-info/entry_points.txt,sha256=g-Bn5ZXMuODBSvJWj0PWIv4SVE-ibEplzFeiHH4kMDE,134
+reciprocalspaceship-1.0.4.dist-info/top_level.txt,sha256=tOo679MsLFS7iwiYZDwnKTuTpJLYVFBk6g9xnnB_s-w,26
+reciprocalspaceship-1.0.4.dist-info/RECORD,,

{reciprocalspaceship-1.0.3.dist-info → reciprocalspaceship-1.0.4.dist-info}/WHEEL

@@ -1,5 +1,5 @@
 Wheel-Version: 1.0
-Generator: bdist_wheel (0.45.0)
+Generator: setuptools (80.3.1)
 Root-Is-Purelib: true
 Tag: py3-none-any
 

{reciprocalspaceship-1.0.3.dist-info → reciprocalspaceship-1.0.4.dist-info}/entry_points.txt

@@ -1,2 +1,3 @@
 [console_scripts]
+rs.cifdump = reciprocalspaceship.commandline.cifdump:main
 rs.mtzdump = reciprocalspaceship.commandline.mtzdump:main

tests/test_dataset.py

@@ -711,3 +711,50 @@ def test_select_mtzdtype_ValueError(data_merged, dtype):
     """
     with pytest.raises(ValueError):
         data_merged.select_mtzdtype(dtype)
+
+
+@pytest.mark.parametrize("merged", [True, False])
+@pytest.mark.parametrize("hkl_type", ["ds", "index", "numpy"])
+@pytest.mark.parametrize("range_index", [True, False])
+def test_hkls_property_setter(
+    data_merged, data_unmerged, merged, hkl_type, range_index
+):
+    """
+    Test the setter for the .hkls property of rs datasets
+    """
+    if merged:
+        input_ds = data_merged
+    else:
+        input_ds = data_unmerged
+
+    hkls = input_ds.copy().reset_index()[["H", "K", "L"]]
+
+    ds = input_ds.copy()
+    if range_index:
+        ds = ds.reset_index()
+
+    # Confirm we're starting with equivalent miller indices
+    expected = ds.hkls
+    value = hkls
+
+    # Shuffle the hkls
+    hkls = hkls.sample(frac=1.0)
+
+    # confirm shuffling
+    assert not np.array_equal(hkls, ds.hkls)
+
+    # confirm setter
+    if hkl_type == "ds":
+        ds.hkls = hkls
+    elif hkl_type == "index":
+        ds.hkls = hkls.set_index(["H", "K", "L"])
+    elif hkl_type == "numpy":
+        ds.hkls = hkls.to_numpy()
+    expected = ds.hkls
+    value = hkls.hkls
+    assert np.array_equal(value, expected)
+
+    # Test that all data remained the same
+    for k in input_ds:
+        if k not in ["H", "K", "L"]:
+            assert np.array_equal(ds[k], input_ds[k])

tests/test_dataset_grid.py

@@ -22,10 +22,10 @@ def test_to_reciprocal_grid_gemmi(mtz_by_spacegroup, sample_rate, p1, use_sf):
     grid_size = dataset.get_reciprocal_grid_size(sample_rate=sample_rate)
 
     if use_sf:
-        gemmigrid = gemmimtz.get_f_phi_on_grid("FMODEL", "PHIFMODEL", size=grid_size)
-        expected = np.array(gemmigrid, copy=False)
         dataset["sf"] = dataset.to_structurefactor("FMODEL", "PHIFMODEL")
         result = dataset.to_reciprocal_grid("sf", grid_size=grid_size)
+        gemmigrid = gemmimtz.get_f_phi_on_grid("FMODEL", "PHIFMODEL", size=grid_size)
+        expected = gemmigrid.array
 
         # Requires rtol due to truncations applied in gemmi
         assert np.allclose(result, expected, rtol=1e-4)