rasa-pro 3.14.0.dev5__py3-none-any.whl → 3.14.0.dev6__py3-none-any.whl

rasa/graph_components/validators/default_recipe_validator.py

@@ -10,46 +10,40 @@ from rasa.core.policies.flow_policy import FlowPolicy
 from rasa.core.policies.memoization import AugmentedMemoizationPolicy, MemoizationPolicy
 from rasa.core.policies.policy import Policy, SupportedData
 from rasa.core.policies.rule_policy import RulePolicy
-from rasa.core.policies.ted_policy import TEDPolicy
-from rasa.core.policies.unexpected_intent_policy import UnexpecTEDIntentPolicy
+
+# from rasa.core.policies.ted_policy import TEDPolicy
+# from rasa.core.policies.unexpected_intent_policy import UnexpecTEDIntentPolicy
 from rasa.engine.graph import ExecutionContext, GraphComponent, GraphSchema, SchemaNode
 from rasa.engine.storage.resource import Resource
 from rasa.engine.storage.storage import ModelStorage
-from rasa.nlu.classifiers.diet_classifier import DIETClassifier
-from rasa.nlu.extractors.crf_entity_extractor import (
-    CRFEntityExtractor,
-    CRFEntityExtractorOptions,
-)
+
+# from rasa.nlu.classifiers.diet_classifier import DIETClassifier
+# from rasa.nlu.extractors.crf_entity_extractor import (
+#     CRFEntityExtractor,
+#     CRFEntityExtractorOptions,
+# )
 from rasa.nlu.extractors.entity_synonyms import EntitySynonymMapper
 from rasa.nlu.extractors.mitie_entity_extractor import MitieEntityExtractor
 from rasa.nlu.extractors.regex_entity_extractor import RegexEntityExtractor
 from rasa.nlu.featurizers.featurizer import Featurizer
 from rasa.nlu.featurizers.sparse_featurizer.regex_featurizer import RegexFeaturizer
-from rasa.nlu.selectors.response_selector import ResponseSelector
+
+# from rasa.nlu.selectors.response_selector import ResponseSelector
 from rasa.nlu.tokenizers.tokenizer import Tokenizer
 from rasa.shared.constants import (
-    DEFAULT_CONFIG_PATH,
     DOCS_URL_COMPONENTS,
-    DOCS_URL_DEFAULT_ACTIONS,
     DOCS_URL_NLU_BASED_POLICIES,
-    DOCS_URL_RULES,
 )
-from rasa.shared.core.constants import (
-    ACTION_BACK_NAME,
-    ACTION_RESTART_NAME,
-    USER_INTENT_BACK,
-    USER_INTENT_RESTART,
-)
-from rasa.shared.core.domain import Domain, InvalidDomain
+from rasa.shared.core.domain import Domain
 from rasa.shared.core.training_data.structures import RuleStep, StoryGraph
 from rasa.shared.exceptions import InvalidConfigException
 from rasa.shared.importers.importer import TrainingDataImporter
 from rasa.shared.nlu.training_data.training_data import TrainingData
 
 # TODO: Can we replace this with the registered types from the regitry?
-TRAINABLE_EXTRACTORS = [MitieEntityExtractor, CRFEntityExtractor, DIETClassifier]
+TRAINABLE_EXTRACTORS = [MitieEntityExtractor]  # , CRFEntityExtractor, DIETClassifier]
 # TODO: replace these once the Recipe is merged (used in tests)
-POLICY_CLASSSES = {TEDPolicy, MemoizationPolicy, RulePolicy}
+POLICY_CLASSSES = {MemoizationPolicy, RulePolicy}
 
 
 def _types_to_str(types: Iterable[Type]) -> Text:
@@ -135,16 +129,17 @@ class DefaultV1RecipeValidator(GraphComponent):
         """
         if (
             training_data.response_examples
-            and ResponseSelector not in self._component_types
+            # and ResponseSelector not in self._component_types
         ):
-            rasa.shared.utils.io.raise_warning(
-                f"You have defined training data with examples for training a response "
-                f"selector, but your NLU configuration does not include a response "
-                f"selector component. "
-                f"To train a model on your response selector data, add a "
-                f"'{ResponseSelector.__name__}' to your configuration.",
-                docs=DOCS_URL_COMPONENTS,
-            )
+            pass
+            # rasa.shared.utils.io.raise_warning(
+            #     f"You have defined training data with examples for training a response "  # noqa: E501
+            #     f"selector, but your NLU configuration does not include a response "
+            #     f"selector component. "
+            #     f"To train a model on your response selector data, add a "
+            #     f"'{ResponseSelector.__name__}' to your configuration.",
+            #     docs=DOCS_URL_COMPONENTS,
+            # )
 
         if training_data.entity_examples and self._component_types.isdisjoint(
             TRAINABLE_EXTRACTORS
@@ -158,21 +153,21 @@ class DefaultV1RecipeValidator(GraphComponent):
                 docs=DOCS_URL_COMPONENTS,
             )
 
-        if training_data.entity_examples and self._component_types.isdisjoint(
-            {DIETClassifier, CRFEntityExtractor}
-        ):
-            if training_data.entity_roles_groups_used():
-                rasa.shared.utils.io.raise_warning(
-                    f"You have defined training data with entities that "
-                    f"have roles/groups, but your NLU configuration does not "
-                    f"include a '{DIETClassifier.__name__}' "
-                    f"or a '{CRFEntityExtractor.__name__}'. "
-                    f"To train entities that have roles/groups, "
-                    f"add either '{DIETClassifier.__name__}' "
-                    f"or '{CRFEntityExtractor.__name__}' to your "
-                    f"configuration.",
-                    docs=DOCS_URL_COMPONENTS,
-                )
+        # if training_data.entity_examples and self._component_types.isdisjoint(
+        #     {DIETClassifier, CRFEntityExtractor}
+        # ):
+        #     if training_data.entity_roles_groups_used():
+        #         rasa.shared.utils.io.raise_warning(
+        #             f"You have defined training data with entities that "
+        #             f"have roles/groups, but your NLU configuration does not "
+        #             f"include a '{DIETClassifier.__name__}' "
+        #             f"or a '{CRFEntityExtractor.__name__}'. "
+        #             f"To train entities that have roles/groups, "
+        #             f"add either '{DIETClassifier.__name__}' "
+        #             f"or '{CRFEntityExtractor.__name__}' to your "
+        #             f"configuration.",
+        #             docs=DOCS_URL_COMPONENTS,
+        #         )
 
         if training_data.regex_features and self._component_types.isdisjoint(
             [RegexFeaturizer, RegexEntityExtractor]
@@ -202,45 +197,45 @@ class DefaultV1RecipeValidator(GraphComponent):
                 docs=DOCS_URL_COMPONENTS,
             )
 
-        if training_data.lookup_tables:
-            if self._component_types.isdisjoint([CRFEntityExtractor, DIETClassifier]):
-                rasa.shared.utils.io.raise_warning(
-                    f"You have defined training data consisting of lookup tables, but "
-                    f"your NLU configuration does not include any components "
-                    f"that uses the features created from the lookup table. "
-                    f"To make use of the features that are created with the "
-                    f"help of the lookup tables, "
-                    f"add a '{DIETClassifier.__name__}' or a "
-                    f"'{CRFEntityExtractor.__name__}' "
-                    f"with the 'pattern' feature "
-                    f"to your configuration.",
-                    docs=DOCS_URL_COMPONENTS,
-                )
-
-            elif CRFEntityExtractor in self._component_types:
-                crf_schema_nodes = [
-                    schema_node
-                    for schema_node in self._graph_schema.nodes.values()
-                    if schema_node.uses == CRFEntityExtractor
-                ]
-                has_pattern_feature = any(
-                    CRFEntityExtractorOptions.PATTERN in feature_list
-                    for crf in crf_schema_nodes
-                    for feature_list in crf.config.get("features", [])
-                )
-
-                if not has_pattern_feature:
-                    rasa.shared.utils.io.raise_warning(
-                        f"You have defined training data consisting of "
-                        f"lookup tables, but your NLU configuration's "
-                        f"'{CRFEntityExtractor.__name__}' "
-                        f"does not include the "
-                        f"'pattern' feature. To featurize lookup tables, "
-                        f"add the 'pattern' feature to the "
-                        f"'{CRFEntityExtractor.__name__}' "
-                        "in your configuration.",
-                        docs=DOCS_URL_COMPONENTS,
-                    )
+        # if training_data.lookup_tables:
+        #     if self._component_types.isdisjoint([CRFEntityExtractor, DIETClassifier]):
+        #         rasa.shared.utils.io.raise_warning(
+        #             f"You have defined training data consisting of lookup tables, but "   # noqa: E501
+        #             f"your NLU configuration does not include any components "
+        #             f"that uses the features created from the lookup table. "
+        #             f"To make use of the features that are created with the "
+        #             f"help of the lookup tables, "
+        #             f"add a '{DIETClassifier.__name__}' or a "
+        #             f"'{CRFEntityExtractor.__name__}' "
+        #             f"with the 'pattern' feature "
+        #             f"to your configuration.",
+        #             docs=DOCS_URL_COMPONENTS,
+        #         )
+
+        #     elif CRFEntityExtractor in self._component_types:
+        #         crf_schema_nodes = [
+        #             schema_node
+        #             for schema_node in self._graph_schema.nodes.values()
+        #             if schema_node.uses == CRFEntityExtractor
+        #         ]
+        #         has_pattern_feature = any(
+        #             CRFEntityExtractorOptions.PATTERN in feature_list
+        #             for crf in crf_schema_nodes
+        #             for feature_list in crf.config.get("features", [])
+        #         )
+
+        #         if not has_pattern_feature:
+        #             rasa.shared.utils.io.raise_warning(
+        #                 f"You have defined training data consisting of "
+        #                 f"lookup tables, but your NLU configuration's "
+        #                 f"'{CRFEntityExtractor.__name__}' "
+        #                 f"does not include the "
+        #                 f"'pattern' feature. To featurize lookup tables, "
+        #                 f"add the 'pattern' feature to the "
+        #                 f"'{CRFEntityExtractor.__name__}' "
+        #                 "in your configuration.",
+        #                 docs=DOCS_URL_COMPONENTS,
+        #             )
 
         if (
             training_data.entity_synonyms
@@ -392,21 +387,22 @@ class DefaultV1RecipeValidator(GraphComponent):
 
     def _warn_if_no_policy_handles_default_intents(self) -> None:
         """Warns if there is no policy handling the default intents."""
-        policies_handling_default_indents = (RulePolicy, FlowPolicy)
-
-        contains_policy_handling_default_intents = any(
-            issubclass(node.uses, policies_handling_default_indents)
-            for node in self._policy_schema_nodes
-        )
-        if not contains_policy_handling_default_intents:
-            rasa.shared.utils.io.raise_warning(
-                f"'{RulePolicy.__name__}' is not included in the model's "
-                f"policy configuration. Default intents such as "
-                f"'{USER_INTENT_RESTART}' and '{USER_INTENT_BACK}' will "
-                f"not trigger actions '{ACTION_RESTART_NAME}' and "
-                f"'{ACTION_BACK_NAME}'.",
-                docs=DOCS_URL_DEFAULT_ACTIONS,
-            )
+        # policies_handling_default_indents = (RulePolicy, FlowPolicy)
+        #
+        # contains_policy_handling_default_intents = any(
+        #     issubclass(node.uses, policies_handling_default_indents)
+        #     for node in self._policy_schema_nodes
+        # )
+        # if not contains_policy_handling_default_intents:
+        #     rasa.shared.utils.io.raise_warning(
+        #         f"'{RulePolicy.__name__}' is not included in the model's "
+        #         f"policy configuration. Default intents such as "
+        #         f"'{USER_INTENT_RESTART}' and '{USER_INTENT_BACK}' will "
+        #         f"not trigger actions '{ACTION_RESTART_NAME}' and "
+        #         f"'{ACTION_BACK_NAME}'.",
+        #         docs=DOCS_URL_DEFAULT_ACTIONS,
+        #     )
+        pass
 
     def _raise_if_domain_contains_form_names_but_no_rule_policy_given(
         self, domain: Domain
@@ -416,19 +412,20 @@ class DefaultV1RecipeValidator(GraphComponent):
         Raises:
             `InvalidConfigException` if domain and rule policies do not match
         """
-        contains_rule_policy = any(
-            schema_node
-            for schema_node in self._graph_schema.nodes.values()
-            if issubclass(schema_node.uses, RulePolicy)
-        )
-
-        if domain.form_names and not contains_rule_policy:
-            raise InvalidDomain(
-                "You have defined a form action, but have not added the "
-                f"'{RulePolicy.__name__}' to your policy ensemble. "
-                f"Either remove all forms from your domain or add the "
-                f"'{RulePolicy.__name__}' to your policy configuration."
-            )
+        pass
+        # contains_rule_policy = any(
+        #     schema_node
+        #     for schema_node in self._graph_schema.nodes.values()
+        #     if issubclass(schema_node.uses, RulePolicy)
+        # )
+
+        # if domain.form_names and not contains_rule_policy:
+        #     raise InvalidDomain(
+        #         "You have defined a form action, but have not added the "
+        #         f"'{RulePolicy.__name__}' to your policy ensemble. "
+        #         f"Either remove all forms from your domain or add the "
+        #         f"'{RulePolicy.__name__}' to your policy configuration."
+        #     )
 
     def _raise_if_dm1_and_calm_policies_used_at_the_same_time(self) -> None:
         """Validates that there exists a rule policy if forms are defined.
@@ -447,11 +444,11 @@ class DefaultV1RecipeValidator(GraphComponent):
 
         # if we are using a flow policy, there shouldn't be any dm1 policies
         dm1_policies = (
-            RulePolicy,
-            TEDPolicy,
+            # RulePolicy,
+            # TEDPolicy,
             MemoizationPolicy,
             AugmentedMemoizationPolicy,
-            UnexpecTEDIntentPolicy,
+            # UnexpecTEDIntentPolicy,
         )
 
         for schema_node in self._graph_schema.nodes.values():
@@ -472,10 +469,11 @@ class DefaultV1RecipeValidator(GraphComponent):
             `InvalidDomain` if domain and rule policies do not match
         """
         for schema_node in self._graph_schema.nodes.values():
-            if schema_node.uses == RulePolicy:
-                RulePolicy.raise_if_incompatible_with_domain(
-                    config=schema_node.config, domain=domain
-                )
+            # if schema_node.uses == RulePolicy:
+            #     RulePolicy.raise_if_incompatible_with_domain(
+            #         config=schema_node.config, domain=domain
+            #     )
+            pass
 
     def _validate_policy_priorities(self) -> None:
         """Checks if every policy has a valid priority value.
@@ -531,20 +529,22 @@ class DefaultV1RecipeValidator(GraphComponent):
         )
 
         if consuming_rule_data and not contains_rule_tracker:
-            rasa.shared.utils.io.raise_warning(
-                f"Found a rule-based policy in your configuration but "
-                f"no rule-based training data. Please add rule-based "
-                f"stories to your training data or "
-                f"remove the rule-based policy "
-                f"(`{RulePolicy.__name__}`) from your "
-                f"your configuration.",
-                docs=DOCS_URL_RULES,
-            )
+            # rasa.shared.utils.io.raise_warning(
+            #     f"Found a rule-based policy in your configuration but "
+            #     f"no rule-based training data. Please add rule-based "
+            #     f"stories to your training data or "
+            #     f"remove the rule-based policy "
+            #     f"(`{RulePolicy.__name__}`) from your "
+            #     f"your configuration.",
+            #     docs=DOCS_URL_RULES,
+            # )
+            pass
         elif not consuming_rule_data and contains_rule_tracker:
-            rasa.shared.utils.io.raise_warning(
-                f"Found rule-based training data but no policy supporting rule-based "
-                f"data. Please add `{RulePolicy.__name__}` "
-                f"or another rule-supporting "
-                f"policy to the `policies` section in `{DEFAULT_CONFIG_PATH}`.",
-                docs=DOCS_URL_RULES,
-            )
+            # rasa.shared.utils.io.raise_warning(
+            #     f"Found rule-based training data but no policy supporting rule-based "
+            #     f"data. Please add `{RulePolicy.__name__}` "
+            #     f"or another rule-supporting "
+            #     f"policy to the `policies` section in `{DEFAULT_CONFIG_PATH}`.",
+            #     docs=DOCS_URL_RULES,
+            # )
+            pass

rasa/hooks.py

@@ -19,7 +19,7 @@ hookimpl = pluggy.HookimplMarker("rasa")
 logger = logging.getLogger(__name__)
 
 
-@hookimpl  # type: ignore[misc]
+@hookimpl
 def refine_cli(
     subparsers: "SubParsersAction",
     parent_parsers: List[argparse.ArgumentParser],
@@ -37,7 +37,7 @@ def refine_cli(
     return None
 
 
-@hookimpl  # type: ignore[misc]
+@hookimpl
 def configure_commandline(cmdline_arguments: argparse.Namespace) -> Optional[Text]:
     from rasa.cli import x as rasa_x
     from rasa.tracing import config
@@ -59,21 +59,21 @@ def configure_commandline(cmdline_arguments: argparse.Namespace) -> Optional[Tex
     return endpoints_file
 
 
-@hookimpl  # type: ignore[misc]
+@hookimpl
 def init_telemetry(endpoints_file: Optional[Text]) -> None:
     import rasa.telemetry
 
     rasa.telemetry.identify_endpoint_config_traits(endpoints_file)
 
 
-@hookimpl  # type: ignore[misc]
+@hookimpl
 def init_managers(endpoints_file: Optional[Text]) -> None:
     from rasa.core.secrets_manager.factory import load_secret_manager
 
     load_secret_manager(endpoints_file)
 
 
-@hookimpl  # type: ignore[misc]
+@hookimpl
 def create_tracker_store(
     endpoint_config: Union["TrackerStore", "EndpointConfig"],
     domain: "Domain",

rasa/llm_fine_tuning/utils.py

@@ -61,9 +61,9 @@ def patch_invoke_llm_in_generators(mock_impl: Callable) -> Generator:
     try:
         # apply the monkey-patch everywhere
         for cls in originals:
-            cls.invoke_llm = mock_impl  # type: ignore[assignment]
+            cls.invoke_llm = mock_impl  # type: ignore[method-assign]
         yield
     finally:
         # restore originals (even if an exception happened)
         for cls, orig in originals.items():
-            cls.invoke_llm = orig  # type: ignore[assignment]
+            cls.invoke_llm = orig  # type: ignore[method-assign]

rasa/model_manager/model_api.py

@@ -39,9 +39,11 @@ from rasa.model_manager.trainer_service import (
     update_training_status,
 )
 from rasa.model_manager.utils import (
+    InvalidPathException,
     get_logs_content,
     logs_base_path,
     models_base_path,
+    subpath,
 )
 from rasa.model_manager.warm_rasa_process import (
     initialize_warm_rasa_process,
@@ -51,7 +53,6 @@ from rasa.server import ErrorResponse
 from rasa.shared.exceptions import InvalidConfigException
 from rasa.shared.utils.yaml import dump_obj_as_yaml_to_string
 from rasa.studio.upload import build_calm_import_parts
-from rasa.utils.io import InvalidPathException, subpath
 
 dotenv.load_dotenv()
 
@@ -570,10 +571,10 @@ def external_blueprint() -> Blueprint:
     """Create a blueprint for the model manager API."""
     from rasa.core.channels.socketio import SocketBlueprint
 
-    sio_server = AsyncServer(async_mode="sanic", cors_allowed_origins="*")
-    bp = SocketBlueprint(sio_server, "", "model_api_external")
+    sio = AsyncServer(async_mode="sanic", cors_allowed_origins="*")
+    bp = SocketBlueprint(sio, "", "model_api_external")
 
-    create_bridge_server(sio_server, running_bots)
+    create_bridge_server(sio, running_bots)
 
     @bp.get("/health")
     async def health(request: Request) -> response.HTTPResponse:

rasa/model_manager/runner_service.py

@@ -15,11 +15,11 @@ from rasa.model_manager import config
 from rasa.model_manager.utils import (
     logs_path,
     models_base_path,
+    subpath,
     write_encoded_data_to_file,
 )
 from rasa.model_manager.warm_rasa_process import start_rasa_process
 from rasa.studio.prompts import handle_prompts
-from rasa.utils.io import subpath
 
 structlogger = structlog.get_logger()
 

rasa/model_manager/socket_bridge.py

@@ -19,7 +19,7 @@ socket_proxy_clients = {}
 
 
 async def socketio_websocket_traffic_wrapper(
-    sio_server: AsyncServer,
+    sio: AsyncServer,
     running_bots: Dict[str, BotSession],
     sid: str,
     auth: Optional[Dict],
@@ -55,9 +55,7 @@ async def socketio_websocket_traffic_wrapper(
         structlogger.error("model_runner.bot_not_alive", deployment_id=deployment_id)
         raise ConnectionRefusedError("model_runner.bot_not_alive")
 
-    client = await create_bridge_client(
-        sio_server, bot.internal_url, sid, deployment_id
-    )
+    client = await create_bridge_client(sio, bot.internal_url, sid, deployment_id)
 
     if client.sid is not None:
         structlogger.debug(
@@ -72,24 +70,20 @@ async def socketio_websocket_traffic_wrapper(
         raise ConnectionRefusedError("model_runner.bot_connection_failed")
 
 
-def create_bridge_server(
-    sio_server: AsyncServer, running_bots: Dict[str, BotSession]
-) -> None:
+def create_bridge_server(sio: AsyncServer, running_bots: Dict[str, BotSession]) -> None:
     """Create handlers for the socket server side.
 
     Forwards messages coming from the user to the bot.
     """
 
-    @sio_server.on("connect")
+    @sio.on("connect")
     async def socketio_websocket_traffic(
         sid: str, environ: Dict, auth: Optional[Dict]
     ) -> bool:
         """Bridge websockets between user chat socket and bot server."""
-        return await socketio_websocket_traffic_wrapper(
-            sio_server, running_bots, sid, auth
-        )
+        return await socketio_websocket_traffic_wrapper(sio, running_bots, sid, auth)
 
-    @sio_server.on("disconnect")
+    @sio.on("disconnect")
     async def disconnect(sid: str) -> None:
         """Disconnect the bot connection."""
         structlogger.debug("model_runner.bot_disconnect", sid=sid)
@@ -97,7 +91,7 @@ def create_bridge_server(
             await socket_proxy_clients[sid].disconnect()
             del socket_proxy_clients[sid]
 
-    @sio_server.on("*")
+    @sio.on("*")
     async def handle_message(event: str, sid: str, data: Dict[str, Any]) -> None:
         """Bridge messages between user and bot.
 
@@ -114,7 +108,7 @@ def create_bridge_server(
 
 
 async def create_bridge_client(
-    sio_server: AsyncServer, url: str, sid: str, deployment_id: str
+    sio: AsyncServer, url: str, sid: str, deployment_id: str
 ) -> AsyncClient:
     """Create a new socket bridge client.
 
@@ -129,36 +123,36 @@ async def create_bridge_client(
         structlogger.debug(
             "model_runner.bot_session_confirmed", deployment_id=deployment_id
         )
-        await sio_server.emit("session_confirm", room=sid)
+        await sio.emit("session_confirm", room=sid)
 
     @client.event  # type: ignore[misc]
     async def bot_message(data: Dict[str, Any]) -> None:
         structlogger.debug("model_runner.bot_message", deployment_id=deployment_id)
-        await sio_server.emit("bot_message", data, room=sid)
+        await sio.emit("bot_message", data, room=sid)
 
     @client.event  # type: ignore[misc]
     async def error(data: Dict[str, Any]) -> None:
         structlogger.debug(
             "model_runner.bot_error", deployment_id=deployment_id, data=data
         )
-        await sio_server.emit("error", data, room=sid)
+        await sio.emit("error", data, room=sid)
 
     @client.event  # type: ignore[misc]
     async def tracker(data: Dict[str, Any]) -> None:
-        await sio_server.emit("tracker", json.loads(data), room=sid)
+        await sio.emit("tracker", json.loads(data), room=sid)
 
     @client.event  # type: ignore[misc]
     async def disconnect() -> None:
         structlogger.debug(
             "model_runner.bot_connection_closed", deployment_id=deployment_id
         )
-        await sio_server.emit("disconnect", room=sid)
+        await sio.emit("disconnect", room=sid)
 
     @client.event  # type: ignore[misc]
     async def connect_error() -> None:
         structlogger.error(
             "model_runner.bot_connection_error", deployment_id=deployment_id
         )
-        await sio_server.emit("disconnect", room=sid)
+        await sio.emit("disconnect", room=sid)
 
     return client

rasa/model_manager/trainer_service.py

@@ -14,6 +14,7 @@ from rasa.model_manager.utils import (
     ensure_base_directory_exists,
     logs_path,
     models_base_path,
+    subpath,
     write_encoded_data_to_file,
 )
 from rasa.model_manager.warm_rasa_process import (
@@ -21,7 +22,6 @@ from rasa.model_manager.warm_rasa_process import (
 )
 from rasa.model_training import generate_random_model_name
 from rasa.studio.prompts import handle_prompts
-from rasa.utils.io import subpath
 
 structlogger = structlog.get_logger()
 
@@ -53,15 +53,6 @@ class TrainingSession(BaseModel):
         """Check if the training is running."""
         return self.status == TrainingSessionStatus.RUNNING
 
-    def has_just_finished(self) -> bool:
-        if not self.is_status_indicating_alive():
-            # skip if the training is not running
-            return False
-        if self.process.poll() is None:
-            # process is still running
-            return False
-        return True
-
     def model_path(self) -> str:
         """Return the path to the model."""
         return subpath(models_base_path(), f"{self.model_name}.tar.gz")
@@ -98,8 +89,14 @@ def terminate_training(training: TrainingSession) -> None:
 
 
 def update_training_status(training: TrainingSession) -> None:
-    if training.has_just_finished():
-        complete_training(training)
+    if not training.is_status_indicating_alive():
+        # skip if the training is not running
+        return
+    if training.process.poll() is None:
+        # process is still running
+        return
+
+    complete_training(training)
 
 
 def complete_training(training: TrainingSession) -> None:

rasa/model_manager/utils.py

@@ -5,11 +5,15 @@ from typing import Optional
 import structlog
 
 from rasa.model_manager import config
-from rasa.utils.io import subpath
+from rasa.shared.exceptions import RasaException
 
 structlogger = structlog.get_logger()
 
 
+class InvalidPathException(RasaException):
+    """Raised if a path is invalid - e.g. path traversal is detected."""
+
+
 def write_encoded_data_to_file(encoded_data: bytes, file: str) -> None:
     """Write base64 encoded data to a file."""
     # create the directory if it does not exist of the parent directory
@@ -49,6 +53,30 @@ def logs_path(action_id: str) -> str:
     return subpath(logs_base_path(), f"{action_id}.txt")
 
 
+def subpath(parent: str, child: str) -> str:
+    """Return the path to the child directory of the parent directory.
+
+    Ensures, that child doesn't navigate to parent directories. Prevents
+    path traversal. Raises an InvalidPathException if the path is invalid.
+
+    Based on Snyk's directory traversal mitigation:
+    https://learn.snyk.io/lesson/directory-traversal/
+    """
+    safe_path = os.path.abspath(os.path.join(parent, child))
+    parent = os.path.abspath(parent)
+
+    common_base = os.path.commonpath([parent, safe_path])
+    if common_base != parent:
+        raise InvalidPathException(f"Invalid path: {safe_path}")
+
+    if os.path.basename(safe_path) != child:
+        raise InvalidPathException(
+            f"Invalid path - path traversal detected: {safe_path}"
+        )
+
+    return safe_path
+
+
 def get_logs_content(action_id: str) -> Optional[str]:
     """Return the content of the log file for a given action id."""
     try: