rasa-pro 3.14.0.dev4__py3-none-any.whl → 3.14.0.dev5__py3-none-any.whl

rasa/engine/caching.py

@@ -5,7 +5,7 @@ import logging
 import shutil
 from datetime import datetime
 from pathlib import Path
-from typing import Any, List, Optional, Text, Tuple, Union
+from typing import Any, List, Optional, Text, Tuple
 
 import sqlalchemy as sa
 import sqlalchemy.orm
@@ -294,7 +294,7 @@ class LocalTrainingCache(TrainingCache):
 
     def _cache_output_to_disk(
         self, output: Cacheable, model_storage: ModelStorage
-    ) -> Tuple[Optional[Union[Path, Text]], Optional[Text]]:
+    ) -> Tuple[Optional[Text], Optional[Text]]:
         tempdir_name = rasa.utils.common.get_temp_dir_name()
 
         # Use `TempDirectoryPath` instead of `tempfile.TemporaryDirectory` as this

rasa/engine/recipes/default_components.py

@@ -1,7 +1,10 @@
 from rasa.core.policies.enterprise_search_policy import EnterpriseSearchPolicy
 from rasa.core.policies.flow_policy import FlowPolicy
 from rasa.core.policies.intentless_policy import IntentlessPolicy
-from rasa.core.policies.memoization import AugmentedMemoizationPolicy
+from rasa.core.policies.memoization import AugmentedMemoizationPolicy, MemoizationPolicy
+from rasa.core.policies.rule_policy import RulePolicy
+from rasa.core.policies.ted_policy import TEDPolicy
+from rasa.core.policies.unexpected_intent_policy import UnexpecTEDIntentPolicy
 from rasa.dialogue_understanding.coexistence.intent_based_router import (
     IntentBasedRouter,
 )
@@ -10,6 +13,7 @@ from rasa.dialogue_understanding.generator import (
     LLMCommandGenerator,
 )
 from rasa.dialogue_understanding.generator.nlu_command_adapter import NLUCommandAdapter
+from rasa.nlu.classifiers.diet_classifier import DIETClassifier
 from rasa.nlu.classifiers.fallback_classifier import FallbackClassifier
 from rasa.nlu.classifiers.keyword_intent_classifier import KeywordIntentClassifier
 from rasa.nlu.classifiers.logistic_regression_classifier import (
@@ -17,11 +21,14 @@ from rasa.nlu.classifiers.logistic_regression_classifier import (
 )
 from rasa.nlu.classifiers.mitie_intent_classifier import MitieIntentClassifier
 from rasa.nlu.classifiers.sklearn_intent_classifier import SklearnIntentClassifier
+from rasa.nlu.extractors.crf_entity_extractor import CRFEntityExtractor
 from rasa.nlu.extractors.duckling_entity_extractor import DucklingEntityExtractor
 from rasa.nlu.extractors.entity_synonyms import EntitySynonymMapper
 from rasa.nlu.extractors.mitie_entity_extractor import MitieEntityExtractor
 from rasa.nlu.extractors.regex_entity_extractor import RegexEntityExtractor
 from rasa.nlu.extractors.spacy_entity_extractor import SpacyEntityExtractor
+from rasa.nlu.featurizers.dense_featurizer.convert_featurizer import ConveRTFeaturizer
+from rasa.nlu.featurizers.dense_featurizer.lm_featurizer import LanguageModelFeaturizer
 from rasa.nlu.featurizers.dense_featurizer.mitie_featurizer import MitieFeaturizer
 from rasa.nlu.featurizers.dense_featurizer.spacy_featurizer import SpacyFeaturizer
 from rasa.nlu.featurizers.sparse_featurizer.count_vectors_featurizer import (
@@ -31,6 +38,7 @@ from rasa.nlu.featurizers.sparse_featurizer.lexical_syntactic_featurizer import
     LexicalSyntacticFeaturizer,
 )
 from rasa.nlu.featurizers.sparse_featurizer.regex_featurizer import RegexFeaturizer
+from rasa.nlu.selectors.response_selector import ResponseSelector
 from rasa.nlu.tokenizers.jieba_tokenizer import JiebaTokenizer
 from rasa.nlu.tokenizers.mitie_tokenizer import MitieTokenizer
 from rasa.nlu.tokenizers.spacy_tokenizer import SpacyTokenizer
@@ -40,7 +48,7 @@ from rasa.nlu.utils.spacy_utils import SpacyNLP
 
 DEFAULT_COMPONENTS = [
     # Message Classifiers
-    # DIETClassifier,
+    DIETClassifier,
     FallbackClassifier,
     KeywordIntentClassifier,
     MitieIntentClassifier,
@@ -51,9 +59,9 @@ DEFAULT_COMPONENTS = [
     LLMBasedRouter,
     IntentBasedRouter,
     # Response Selectors
-    # ResponseSelector,
+    ResponseSelector,
     # Message Entity Extractors
-    # CRFEntityExtractor,
+    CRFEntityExtractor,
     DucklingEntityExtractor,
     EntitySynonymMapper,
     MitieEntityExtractor,
@@ -61,11 +69,11 @@ DEFAULT_COMPONENTS = [
     RegexEntityExtractor,
     # Message Feauturizers
     LexicalSyntacticFeaturizer,
-    # ConveRTFeaturizer,
+    ConveRTFeaturizer,
     MitieFeaturizer,
     SpacyFeaturizer,
     CountVectorsFeaturizer,
-    # LanguageModelFeaturizer,
+    LanguageModelFeaturizer,
     RegexFeaturizer,
     # Tokenizers
     JiebaTokenizer,
@@ -76,10 +84,10 @@ DEFAULT_COMPONENTS = [
     MitieNLP,
     SpacyNLP,
     # Dialogue Management Policies
-    # TEDPolicy,
-    # UnexpecTEDIntentPolicy,
-    # RulePolicy,
-    # MemoizationPolicy,
+    TEDPolicy,
+    UnexpecTEDIntentPolicy,
+    RulePolicy,
+    MemoizationPolicy,
     AugmentedMemoizationPolicy,
     FlowPolicy,
     EnterpriseSearchPolicy,

rasa/engine/storage/local_model_storage.py

@@ -1,14 +1,16 @@
 from __future__ import annotations
 
 import logging
+import os
 import shutil
 import sys
+import tarfile
 import tempfile
 import uuid
 from contextlib import contextmanager
 from datetime import datetime
 from pathlib import Path
-from typing import Generator, Optional, Text, Tuple, Union
+from typing import Callable, Generator, Optional, Text, Tuple, Union
 
 from tarsafe import TarSafe
 
@@ -57,6 +59,35 @@ def windows_safe_temporary_directory(
             yield temporary_directory
 
 
+def filter_normpath(member: tarfile.TarInfo, dest_path: str) -> tarfile.TarInfo:
+    """Normalize tar member paths for safe extraction"""
+    if member.name:
+        member.name = os.path.normpath(member.name)
+    return member
+
+
+FilterFunction = Callable[[tarfile.TarInfo, str], Optional[tarfile.TarInfo]]
+
+
+def create_combined_filter(existing_filter: Optional[FilterFunction]) -> FilterFunction:
+    """Create a filter that combines existing filter with path normalization"""
+
+    def combined_filter(
+        member: tarfile.TarInfo, dest_path: str
+    ) -> Optional[tarfile.TarInfo]:
+        """Apply existing filter first, then path normalization"""
+        if existing_filter is not None:
+            filtered_member = existing_filter(member, dest_path)
+            if filtered_member is None:
+                return None  # Rejected by existing filter
+            member = filtered_member  # Use the filtered result
+
+        # Apply our path normalization
+        return filter_normpath(member, dest_path)
+
+    return combined_filter
+
+
 class LocalModelStorage(ModelStorage):
     """Stores and provides output of `GraphComponents` on local disk."""
 
@@ -122,7 +153,19 @@ class LocalModelStorage(ModelStorage):
                 # this restriction in environments where it's not possible
                 # to override this behavior, mostly for internal policy reasons
                 # reference: https://stackoverflow.com/a/49102229
-                tar.extractall(f"\\\\?\\{temporary_directory}")
+                try:
+                    # Use extraction filter to normalize paths for compatibility
+                    # before trying the \\?\ prefix approach first
+                    prev_filter = getattr(tar, "extraction_filter", None)
+                    tar.extraction_filter = create_combined_filter(prev_filter)
+                    tar.extractall(f"\\\\?\\{temporary_directory}")
+                except Exception:
+                    # Fallback for Python versions with tarfile security fix
+                    logger.warning(
+                        "Failed to extract model archive with long path support. "
+                        "Falling back to regular extraction."
+                    )
+                    tar.extractall(temporary_directory)
             else:
                 tar.extractall(temporary_directory)
         LocalModelStorage._assert_not_rasa2_archive(temporary_directory)

rasa/graph_components/validators/default_recipe_validator.py

@@ -10,40 +10,46 @@ from rasa.core.policies.flow_policy import FlowPolicy
 from rasa.core.policies.memoization import AugmentedMemoizationPolicy, MemoizationPolicy
 from rasa.core.policies.policy import Policy, SupportedData
 from rasa.core.policies.rule_policy import RulePolicy
-
-# from rasa.core.policies.ted_policy import TEDPolicy
-# from rasa.core.policies.unexpected_intent_policy import UnexpecTEDIntentPolicy
+from rasa.core.policies.ted_policy import TEDPolicy
+from rasa.core.policies.unexpected_intent_policy import UnexpecTEDIntentPolicy
 from rasa.engine.graph import ExecutionContext, GraphComponent, GraphSchema, SchemaNode
 from rasa.engine.storage.resource import Resource
 from rasa.engine.storage.storage import ModelStorage
-
-# from rasa.nlu.classifiers.diet_classifier import DIETClassifier
-# from rasa.nlu.extractors.crf_entity_extractor import (
-#     CRFEntityExtractor,
-#     CRFEntityExtractorOptions,
-# )
+from rasa.nlu.classifiers.diet_classifier import DIETClassifier
+from rasa.nlu.extractors.crf_entity_extractor import (
+    CRFEntityExtractor,
+    CRFEntityExtractorOptions,
+)
 from rasa.nlu.extractors.entity_synonyms import EntitySynonymMapper
 from rasa.nlu.extractors.mitie_entity_extractor import MitieEntityExtractor
 from rasa.nlu.extractors.regex_entity_extractor import RegexEntityExtractor
 from rasa.nlu.featurizers.featurizer import Featurizer
 from rasa.nlu.featurizers.sparse_featurizer.regex_featurizer import RegexFeaturizer
-
-# from rasa.nlu.selectors.response_selector import ResponseSelector
+from rasa.nlu.selectors.response_selector import ResponseSelector
 from rasa.nlu.tokenizers.tokenizer import Tokenizer
 from rasa.shared.constants import (
+    DEFAULT_CONFIG_PATH,
     DOCS_URL_COMPONENTS,
+    DOCS_URL_DEFAULT_ACTIONS,
     DOCS_URL_NLU_BASED_POLICIES,
+    DOCS_URL_RULES,
 )
-from rasa.shared.core.domain import Domain
+from rasa.shared.core.constants import (
+    ACTION_BACK_NAME,
+    ACTION_RESTART_NAME,
+    USER_INTENT_BACK,
+    USER_INTENT_RESTART,
+)
+from rasa.shared.core.domain import Domain, InvalidDomain
 from rasa.shared.core.training_data.structures import RuleStep, StoryGraph
 from rasa.shared.exceptions import InvalidConfigException
 from rasa.shared.importers.importer import TrainingDataImporter
 from rasa.shared.nlu.training_data.training_data import TrainingData
 
 # TODO: Can we replace this with the registered types from the regitry?
-TRAINABLE_EXTRACTORS = [MitieEntityExtractor]  # , CRFEntityExtractor, DIETClassifier]
+TRAINABLE_EXTRACTORS = [MitieEntityExtractor, CRFEntityExtractor, DIETClassifier]
 # TODO: replace these once the Recipe is merged (used in tests)
-POLICY_CLASSSES = {MemoizationPolicy, RulePolicy}
+POLICY_CLASSSES = {TEDPolicy, MemoizationPolicy, RulePolicy}
 
 
 def _types_to_str(types: Iterable[Type]) -> Text:
@@ -129,17 +135,16 @@ class DefaultV1RecipeValidator(GraphComponent):
         """
         if (
             training_data.response_examples
-            # and ResponseSelector not in self._component_types
+            and ResponseSelector not in self._component_types
         ):
-            pass
-            # rasa.shared.utils.io.raise_warning(
-            #     f"You have defined training data with examples for training a response "  # noqa: E501
-            #     f"selector, but your NLU configuration does not include a response "
-            #     f"selector component. "
-            #     f"To train a model on your response selector data, add a "
-            #     f"'{ResponseSelector.__name__}' to your configuration.",
-            #     docs=DOCS_URL_COMPONENTS,
-            # )
+            rasa.shared.utils.io.raise_warning(
+                f"You have defined training data with examples for training a response "
+                f"selector, but your NLU configuration does not include a response "
+                f"selector component. "
+                f"To train a model on your response selector data, add a "
+                f"'{ResponseSelector.__name__}' to your configuration.",
+                docs=DOCS_URL_COMPONENTS,
+            )
 
         if training_data.entity_examples and self._component_types.isdisjoint(
             TRAINABLE_EXTRACTORS
@@ -153,21 +158,21 @@ class DefaultV1RecipeValidator(GraphComponent):
                 docs=DOCS_URL_COMPONENTS,
             )
 
-        # if training_data.entity_examples and self._component_types.isdisjoint(
-        #     {DIETClassifier, CRFEntityExtractor}
-        # ):
-        #     if training_data.entity_roles_groups_used():
-        #         rasa.shared.utils.io.raise_warning(
-        #             f"You have defined training data with entities that "
-        #             f"have roles/groups, but your NLU configuration does not "
-        #             f"include a '{DIETClassifier.__name__}' "
-        #             f"or a '{CRFEntityExtractor.__name__}'. "
-        #             f"To train entities that have roles/groups, "
-        #             f"add either '{DIETClassifier.__name__}' "
-        #             f"or '{CRFEntityExtractor.__name__}' to your "
-        #             f"configuration.",
-        #             docs=DOCS_URL_COMPONENTS,
-        #         )
+        if training_data.entity_examples and self._component_types.isdisjoint(
+            {DIETClassifier, CRFEntityExtractor}
+        ):
+            if training_data.entity_roles_groups_used():
+                rasa.shared.utils.io.raise_warning(
+                    f"You have defined training data with entities that "
+                    f"have roles/groups, but your NLU configuration does not "
+                    f"include a '{DIETClassifier.__name__}' "
+                    f"or a '{CRFEntityExtractor.__name__}'. "
+                    f"To train entities that have roles/groups, "
+                    f"add either '{DIETClassifier.__name__}' "
+                    f"or '{CRFEntityExtractor.__name__}' to your "
+                    f"configuration.",
+                    docs=DOCS_URL_COMPONENTS,
+                )
 
         if training_data.regex_features and self._component_types.isdisjoint(
             [RegexFeaturizer, RegexEntityExtractor]
@@ -197,45 +202,45 @@ class DefaultV1RecipeValidator(GraphComponent):
                 docs=DOCS_URL_COMPONENTS,
             )
 
-        # if training_data.lookup_tables:
-        #     if self._component_types.isdisjoint([CRFEntityExtractor, DIETClassifier]):
-        #         rasa.shared.utils.io.raise_warning(
-        #             f"You have defined training data consisting of lookup tables, but "   # noqa: E501
-        #             f"your NLU configuration does not include any components "
-        #             f"that uses the features created from the lookup table. "
-        #             f"To make use of the features that are created with the "
-        #             f"help of the lookup tables, "
-        #             f"add a '{DIETClassifier.__name__}' or a "
-        #             f"'{CRFEntityExtractor.__name__}' "
-        #             f"with the 'pattern' feature "
-        #             f"to your configuration.",
-        #             docs=DOCS_URL_COMPONENTS,
-        #         )
-
-        #     elif CRFEntityExtractor in self._component_types:
-        #         crf_schema_nodes = [
-        #             schema_node
-        #             for schema_node in self._graph_schema.nodes.values()
-        #             if schema_node.uses == CRFEntityExtractor
-        #         ]
-        #         has_pattern_feature = any(
-        #             CRFEntityExtractorOptions.PATTERN in feature_list
-        #             for crf in crf_schema_nodes
-        #             for feature_list in crf.config.get("features", [])
-        #         )
-
-        #         if not has_pattern_feature:
-        #             rasa.shared.utils.io.raise_warning(
-        #                 f"You have defined training data consisting of "
-        #                 f"lookup tables, but your NLU configuration's "
-        #                 f"'{CRFEntityExtractor.__name__}' "
-        #                 f"does not include the "
-        #                 f"'pattern' feature. To featurize lookup tables, "
-        #                 f"add the 'pattern' feature to the "
-        #                 f"'{CRFEntityExtractor.__name__}' "
-        #                 "in your configuration.",
-        #                 docs=DOCS_URL_COMPONENTS,
-        #             )
+        if training_data.lookup_tables:
+            if self._component_types.isdisjoint([CRFEntityExtractor, DIETClassifier]):
+                rasa.shared.utils.io.raise_warning(
+                    f"You have defined training data consisting of lookup tables, but "
+                    f"your NLU configuration does not include any components "
+                    f"that uses the features created from the lookup table. "
+                    f"To make use of the features that are created with the "
+                    f"help of the lookup tables, "
+                    f"add a '{DIETClassifier.__name__}' or a "
+                    f"'{CRFEntityExtractor.__name__}' "
+                    f"with the 'pattern' feature "
+                    f"to your configuration.",
+                    docs=DOCS_URL_COMPONENTS,
+                )
+
+            elif CRFEntityExtractor in self._component_types:
+                crf_schema_nodes = [
+                    schema_node
+                    for schema_node in self._graph_schema.nodes.values()
+                    if schema_node.uses == CRFEntityExtractor
+                ]
+                has_pattern_feature = any(
+                    CRFEntityExtractorOptions.PATTERN in feature_list
+                    for crf in crf_schema_nodes
+                    for feature_list in crf.config.get("features", [])
+                )
+
+                if not has_pattern_feature:
+                    rasa.shared.utils.io.raise_warning(
+                        f"You have defined training data consisting of "
+                        f"lookup tables, but your NLU configuration's "
+                        f"'{CRFEntityExtractor.__name__}' "
+                        f"does not include the "
+                        f"'pattern' feature. To featurize lookup tables, "
+                        f"add the 'pattern' feature to the "
+                        f"'{CRFEntityExtractor.__name__}' "
+                        "in your configuration.",
+                        docs=DOCS_URL_COMPONENTS,
+                    )
 
         if (
             training_data.entity_synonyms
@@ -387,22 +392,21 @@ class DefaultV1RecipeValidator(GraphComponent):
 
     def _warn_if_no_policy_handles_default_intents(self) -> None:
         """Warns if there is no policy handling the default intents."""
-        # policies_handling_default_indents = (RulePolicy, FlowPolicy)
-        #
-        # contains_policy_handling_default_intents = any(
-        #     issubclass(node.uses, policies_handling_default_indents)
-        #     for node in self._policy_schema_nodes
-        # )
-        # if not contains_policy_handling_default_intents:
-        #     rasa.shared.utils.io.raise_warning(
-        #         f"'{RulePolicy.__name__}' is not included in the model's "
-        #         f"policy configuration. Default intents such as "
-        #         f"'{USER_INTENT_RESTART}' and '{USER_INTENT_BACK}' will "
-        #         f"not trigger actions '{ACTION_RESTART_NAME}' and "
-        #         f"'{ACTION_BACK_NAME}'.",
-        #         docs=DOCS_URL_DEFAULT_ACTIONS,
-        #     )
-        pass
+        policies_handling_default_indents = (RulePolicy, FlowPolicy)
+
+        contains_policy_handling_default_intents = any(
+            issubclass(node.uses, policies_handling_default_indents)
+            for node in self._policy_schema_nodes
+        )
+        if not contains_policy_handling_default_intents:
+            rasa.shared.utils.io.raise_warning(
+                f"'{RulePolicy.__name__}' is not included in the model's "
+                f"policy configuration. Default intents such as "
+                f"'{USER_INTENT_RESTART}' and '{USER_INTENT_BACK}' will "
+                f"not trigger actions '{ACTION_RESTART_NAME}' and "
+                f"'{ACTION_BACK_NAME}'.",
+                docs=DOCS_URL_DEFAULT_ACTIONS,
+            )
 
     def _raise_if_domain_contains_form_names_but_no_rule_policy_given(
         self, domain: Domain
@@ -412,20 +416,19 @@ class DefaultV1RecipeValidator(GraphComponent):
         Raises:
             `InvalidConfigException` if domain and rule policies do not match
         """
-        pass
-        # contains_rule_policy = any(
-        #     schema_node
-        #     for schema_node in self._graph_schema.nodes.values()
-        #     if issubclass(schema_node.uses, RulePolicy)
-        # )
-
-        # if domain.form_names and not contains_rule_policy:
-        #     raise InvalidDomain(
-        #         "You have defined a form action, but have not added the "
-        #         f"'{RulePolicy.__name__}' to your policy ensemble. "
-        #         f"Either remove all forms from your domain or add the "
-        #         f"'{RulePolicy.__name__}' to your policy configuration."
-        #     )
+        contains_rule_policy = any(
+            schema_node
+            for schema_node in self._graph_schema.nodes.values()
+            if issubclass(schema_node.uses, RulePolicy)
+        )
+
+        if domain.form_names and not contains_rule_policy:
+            raise InvalidDomain(
+                "You have defined a form action, but have not added the "
+                f"'{RulePolicy.__name__}' to your policy ensemble. "
+                f"Either remove all forms from your domain or add the "
+                f"'{RulePolicy.__name__}' to your policy configuration."
+            )
 
     def _raise_if_dm1_and_calm_policies_used_at_the_same_time(self) -> None:
         """Validates that there exists a rule policy if forms are defined.
@@ -444,11 +447,11 @@ class DefaultV1RecipeValidator(GraphComponent):
 
         # if we are using a flow policy, there shouldn't be any dm1 policies
         dm1_policies = (
-            # RulePolicy,
-            # TEDPolicy,
+            RulePolicy,
+            TEDPolicy,
             MemoizationPolicy,
             AugmentedMemoizationPolicy,
-            # UnexpecTEDIntentPolicy,
+            UnexpecTEDIntentPolicy,
         )
 
         for schema_node in self._graph_schema.nodes.values():
@@ -469,11 +472,10 @@ class DefaultV1RecipeValidator(GraphComponent):
             `InvalidDomain` if domain and rule policies do not match
         """
         for schema_node in self._graph_schema.nodes.values():
-            # if schema_node.uses == RulePolicy:
-            #     RulePolicy.raise_if_incompatible_with_domain(
-            #         config=schema_node.config, domain=domain
-            #     )
-            pass
+            if schema_node.uses == RulePolicy:
+                RulePolicy.raise_if_incompatible_with_domain(
+                    config=schema_node.config, domain=domain
+                )
 
     def _validate_policy_priorities(self) -> None:
         """Checks if every policy has a valid priority value.
@@ -529,22 +531,20 @@ class DefaultV1RecipeValidator(GraphComponent):
         )
 
         if consuming_rule_data and not contains_rule_tracker:
-            # rasa.shared.utils.io.raise_warning(
-            #     f"Found a rule-based policy in your configuration but "
-            #     f"no rule-based training data. Please add rule-based "
-            #     f"stories to your training data or "
-            #     f"remove the rule-based policy "
-            #     f"(`{RulePolicy.__name__}`) from your "
-            #     f"your configuration.",
-            #     docs=DOCS_URL_RULES,
-            # )
-            pass
+            rasa.shared.utils.io.raise_warning(
+                f"Found a rule-based policy in your configuration but "
+                f"no rule-based training data. Please add rule-based "
+                f"stories to your training data or "
+                f"remove the rule-based policy "
+                f"(`{RulePolicy.__name__}`) from your "
+                f"your configuration.",
+                docs=DOCS_URL_RULES,
+            )
         elif not consuming_rule_data and contains_rule_tracker:
-            # rasa.shared.utils.io.raise_warning(
-            #     f"Found rule-based training data but no policy supporting rule-based "
-            #     f"data. Please add `{RulePolicy.__name__}` "
-            #     f"or another rule-supporting "
-            #     f"policy to the `policies` section in `{DEFAULT_CONFIG_PATH}`.",
-            #     docs=DOCS_URL_RULES,
-            # )
-            pass
+            rasa.shared.utils.io.raise_warning(
+                f"Found rule-based training data but no policy supporting rule-based "
+                f"data. Please add `{RulePolicy.__name__}` "
+                f"or another rule-supporting "
+                f"policy to the `policies` section in `{DEFAULT_CONFIG_PATH}`.",
+                docs=DOCS_URL_RULES,
+            )

rasa/hooks.py

@@ -19,7 +19,7 @@ hookimpl = pluggy.HookimplMarker("rasa")
 logger = logging.getLogger(__name__)
 
 
-@hookimpl
+@hookimpl  # type: ignore[misc]
 def refine_cli(
     subparsers: "SubParsersAction",
     parent_parsers: List[argparse.ArgumentParser],
@@ -37,7 +37,7 @@ def refine_cli(
     return None
 
 
-@hookimpl
+@hookimpl  # type: ignore[misc]
 def configure_commandline(cmdline_arguments: argparse.Namespace) -> Optional[Text]:
     from rasa.cli import x as rasa_x
     from rasa.tracing import config
@@ -59,21 +59,21 @@ def configure_commandline(cmdline_arguments: argparse.Namespace) -> Optional[Tex
     return endpoints_file
 
 
-@hookimpl
+@hookimpl  # type: ignore[misc]
 def init_telemetry(endpoints_file: Optional[Text]) -> None:
     import rasa.telemetry
 
     rasa.telemetry.identify_endpoint_config_traits(endpoints_file)
 
 
-@hookimpl
+@hookimpl  # type: ignore[misc]
 def init_managers(endpoints_file: Optional[Text]) -> None:
     from rasa.core.secrets_manager.factory import load_secret_manager
 
     load_secret_manager(endpoints_file)
 
 
-@hookimpl
+@hookimpl  # type: ignore[misc]
 def create_tracker_store(
     endpoint_config: Union["TrackerStore", "EndpointConfig"],
     domain: "Domain",

rasa/llm_fine_tuning/utils.py

@@ -61,9 +61,9 @@ def patch_invoke_llm_in_generators(mock_impl: Callable) -> Generator:
     try:
         # apply the monkey-patch everywhere
         for cls in originals:
-            cls.invoke_llm = mock_impl  # type: ignore[method-assign]
+            cls.invoke_llm = mock_impl  # type: ignore[assignment]
         yield
     finally:
         # restore originals (even if an exception happened)
         for cls, orig in originals.items():
-            cls.invoke_llm = orig  # type: ignore[method-assign]
+            cls.invoke_llm = orig  # type: ignore[assignment]

rasa/model_manager/model_api.py

@@ -39,11 +39,9 @@ from rasa.model_manager.trainer_service import (
     update_training_status,
 )
 from rasa.model_manager.utils import (
-    InvalidPathException,
     get_logs_content,
     logs_base_path,
     models_base_path,
-    subpath,
 )
 from rasa.model_manager.warm_rasa_process import (
     initialize_warm_rasa_process,
@@ -53,6 +51,7 @@ from rasa.server import ErrorResponse
 from rasa.shared.exceptions import InvalidConfigException
 from rasa.shared.utils.yaml import dump_obj_as_yaml_to_string
 from rasa.studio.upload import build_calm_import_parts
+from rasa.utils.io import InvalidPathException, subpath
 
 dotenv.load_dotenv()
 
@@ -571,10 +570,10 @@ def external_blueprint() -> Blueprint:
     """Create a blueprint for the model manager API."""
     from rasa.core.channels.socketio import SocketBlueprint
 
-    sio = AsyncServer(async_mode="sanic", cors_allowed_origins="*")
-    bp = SocketBlueprint(sio, "", "model_api_external")
+    sio_server = AsyncServer(async_mode="sanic", cors_allowed_origins="*")
+    bp = SocketBlueprint(sio_server, "", "model_api_external")
 
-    create_bridge_server(sio, running_bots)
+    create_bridge_server(sio_server, running_bots)
 
     @bp.get("/health")
     async def health(request: Request) -> response.HTTPResponse:

rasa/model_manager/runner_service.py

@@ -15,11 +15,11 @@ from rasa.model_manager import config
 from rasa.model_manager.utils import (
     logs_path,
     models_base_path,
-    subpath,
     write_encoded_data_to_file,
 )
 from rasa.model_manager.warm_rasa_process import start_rasa_process
 from rasa.studio.prompts import handle_prompts
+from rasa.utils.io import subpath
 
 structlogger = structlog.get_logger()