ralphx 0.2.2__py3-none-any.whl → 0.3.5__py3-none-any.whl

ralphx/core/project_db.py

@@ -14,7 +14,8 @@ This makes projects portable - clone a repo with .ralphx/ and all data comes wit
 """
 
 import json
-import re
+import logging
+import shutil
 import sqlite3
 import threading
 from contextlib import contextmanager
@@ -22,30 +23,11 @@ from datetime import datetime
 from pathlib import Path
 from typing import Any, Iterator, Optional
 
-
-# Schema version for project DB
-PROJECT_SCHEMA_VERSION = 15
-
-# Namespace validation pattern: lowercase, alphanumeric, underscores, dashes, max 64 chars
-# Must start with a letter
-NAMESPACE_PATTERN = re.compile(r'^[a-z][a-z0-9_-]{0,63}$')
+logger = logging.getLogger(__name__)
 
 
-def validate_namespace(namespace: str) -> bool:
-    """Validate namespace format.
-
-    Namespaces must:
-    - Start with a lowercase letter
-    - Contain only lowercase letters, digits, underscores, and dashes
-    - Be 1-64 characters long
-
-    Args:
-        namespace: The namespace string to validate.
-
-    Returns:
-        True if valid, False otherwise.
-    """
-    return bool(NAMESPACE_PATTERN.match(namespace))
+# Schema version for project DB
+PROJECT_SCHEMA_VERSION = 16
 
 # Project database schema - all project-specific data
 PROJECT_SCHEMA_SQL = """
@@ -297,7 +279,6 @@ CREATE TABLE IF NOT EXISTS workflows (
     id TEXT PRIMARY KEY,
     template_id TEXT,                       -- Optional reference to template
     name TEXT NOT NULL,
-    namespace TEXT NOT NULL,                -- Workflow identifier
     status TEXT DEFAULT 'draft',            -- draft, active, paused, completed
     current_step INTEGER DEFAULT 1,
     created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
@@ -467,7 +448,6 @@ CREATE INDEX IF NOT EXISTS idx_loop_resources_type ON loop_resources(resource_ty
 
 -- Workflow indexes
 CREATE INDEX IF NOT EXISTS idx_workflows_status ON workflows(status);
-CREATE INDEX IF NOT EXISTS idx_workflows_namespace ON workflows(namespace);
 CREATE INDEX IF NOT EXISTS idx_workflow_steps_workflow ON workflow_steps(workflow_id, step_number);
 CREATE INDEX IF NOT EXISTS idx_workflow_steps_status ON workflow_steps(status);
 CREATE INDEX IF NOT EXISTS idx_planning_sessions_workflow ON planning_sessions(workflow_id);
@@ -598,9 +578,29 @@ class ProjectDatabase:
                     (PROJECT_SCHEMA_VERSION,),
                 )
             elif current_version < PROJECT_SCHEMA_VERSION:
+                # Create backup before running migrations
+                self._backup_before_migration(current_version)
                 # Run migrations (for future versions > 6)
                 self._run_migrations(conn, current_version)
 
+    def _backup_before_migration(self, from_version: int) -> None:
+        """Create a backup of the database before running migrations.
+
+        Creates a timestamped backup file in the same directory as the database.
+        This allows recovery if a migration fails or causes data loss.
+
+        Args:
+            from_version: Current schema version before migration.
+        """
+        try:
+            timestamp = datetime.now().strftime("%Y%m%d_%H%M%S")
+            backup_path = self.db_path.with_suffix(f".v{from_version}.{timestamp}.bak")
+            shutil.copy2(self.db_path, backup_path)
+            logger.info(f"Created database backup before migration: {backup_path}")
+        except Exception as e:
+            logger.warning(f"Failed to create backup before migration: {e}")
+            # Don't fail the migration if backup fails - just warn
+
     def _run_migrations(self, conn: sqlite3.Connection, from_version: int) -> None:
         """Run schema migrations from a version to the latest.
 
@@ -658,6 +658,11 @@ class ProjectDatabase:
         # Migration from v14 to v15: Add workflow_resource_versions table
         if from_version == 14:
             self._migrate_v14_to_v15(conn)
+            from_version = 15  # Continue to next migration
+
+        # Migration from v15 to v16: Remove namespace from workflows table
+        if from_version == 15:
+            self._migrate_v15_to_v16(conn)
 
         # Seed workflow templates for fresh databases
         self._seed_workflow_templates(conn)
@@ -960,6 +965,55 @@ class ProjectDatabase:
             ON workflow_resource_versions(workflow_resource_id, version_number DESC)
         """)
 
+    def _migrate_v15_to_v16(self, conn: sqlite3.Connection) -> None:
+        """Migrate from schema v15 to v16.
+
+        Removes:
+        - namespace column from workflows table (deprecated, replaced by workflow_id)
+        - idx_workflows_namespace index
+
+        SQLite doesn't support DROP COLUMN directly, so we recreate the table.
+
+        IMPORTANT: We must disable foreign keys before dropping the old table,
+        otherwise the ON DELETE CASCADE on workflow_steps will delete all steps!
+        """
+        # 0. Disable foreign keys to prevent CASCADE deletes during table swap
+        conn.execute("PRAGMA foreign_keys=OFF")
+
+        # 1. Create new table without namespace
+        conn.execute("""
+            CREATE TABLE workflows_new (
+                id TEXT PRIMARY KEY,
+                template_id TEXT,
+                name TEXT NOT NULL,
+                status TEXT DEFAULT 'draft',
+                current_step INTEGER DEFAULT 1,
+                created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
+                updated_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
+                archived_at TIMESTAMP
+            )
+        """)
+
+        # 2. Copy data (excluding namespace)
+        conn.execute("""
+            INSERT INTO workflows_new (id, template_id, name, status, current_step, created_at, updated_at, archived_at)
+            SELECT id, template_id, name, status, current_step, created_at, updated_at, archived_at
+            FROM workflows
+        """)
+
+        # 3. Drop old table and index
+        conn.execute("DROP INDEX IF EXISTS idx_workflows_namespace")
+        conn.execute("DROP TABLE workflows")
+
+        # 4. Rename new table
+        conn.execute("ALTER TABLE workflows_new RENAME TO workflows")
+
+        # 5. Recreate the status index on the new table
+        conn.execute("CREATE INDEX IF NOT EXISTS idx_workflows_status ON workflows(status)")
+
+        # 6. Re-enable foreign keys
+        conn.execute("PRAGMA foreign_keys=ON")
+
     # ========== Loops ==========
 
     def create_loop(
@@ -1808,9 +1862,8 @@ class ProjectDatabase:
         """Release all claims held by a specific loop.
 
         Used when deleting a loop to prevent orphaned claims.
-        Items with a namespace set are restored to 'completed' status so they
-        can be picked up by consumer loops again.
-        Items without a namespace are restored to 'pending'.
+        Released items are restored to 'pending' status so they can be
+        picked up by other loops.
 
         Args:
             loop_name: Name of the loop whose claims should be released.
@@ -1826,7 +1879,7 @@ class ProjectDatabase:
                 UPDATE work_items
                 SET claimed_by = NULL,
                     claimed_at = NULL,
-                    status = CASE WHEN namespace IS NOT NULL THEN 'completed' ELSE 'pending' END,
+                    status = 'pending',
                     updated_at = ?
                 WHERE claimed_by = ? AND status = 'claimed'
                 """,
@@ -1840,9 +1893,8 @@ class ProjectDatabase:
         This is an atomic operation that checks ownership and releases in one step
         to prevent TOCTOU race conditions.
 
-        Items with a namespace set are restored to 'completed' status so they
-        can be picked up by consumer loops again.
-        Items without a namespace are restored to 'pending'.
+        Released items are restored to 'pending' status so they can be
+        picked up by other loops.
 
         Args:
             id: Work item ID.
@@ -1858,7 +1910,7 @@ class ProjectDatabase:
                 UPDATE work_items
                 SET claimed_by = NULL,
                     claimed_at = NULL,
-                    status = CASE WHEN namespace IS NOT NULL THEN 'completed' ELSE 'pending' END,
+                    status = 'pending',
                     updated_at = ?
                 WHERE id = ? AND claimed_by = ? AND status = 'claimed'
                 """,
@@ -3093,11 +3145,12 @@ class ProjectDatabase:
         now = datetime.utcnow().isoformat()
 
         # Build Product workflow template
+        # Uses processing_type to reference PROCESSING_TYPES in mcp/tools/workflows.py
         build_product_phases = json.dumps([
             {
                 "number": 1,
-                "name": "Planning",
-                "type": "interactive",
+                "name": "Design Document",
+                "processing_type": "design_doc",
                 "description": "Describe what you want to build. Claude will help create a design document.",
                 "outputs": ["design_doc", "guardrails"],
                 "skippable": True,
@@ -3105,10 +3158,9 @@ class ProjectDatabase:
             },
             {
                 "number": 2,
-                "name": "Story Generation",
-                "type": "autonomous",
-                "loopType": "generator",
-                "description": "Claude generates detailed user stories from the design document.",
+                "name": "Story Generation (Extract)",
+                "processing_type": "extractgen_requirements",
+                "description": "Claude extracts user stories from the design document.",
                 "inputs": ["design_doc", "guardrails"],
                 "outputs": ["stories"],
                 "skippable": True,
@@ -3116,9 +3168,18 @@ class ProjectDatabase:
             },
             {
                 "number": 3,
+                "name": "Story Generation (Web)",
+                "processing_type": "webgen_requirements",
+                "description": "Claude discovers additional requirements via web research.",
+                "inputs": ["design_doc", "guardrails", "stories"],
+                "outputs": ["stories"],
+                "skippable": True,
+                "skipCondition": "Skip web research"
+            },
+            {
+                "number": 4,
                 "name": "Implementation",
-                "type": "autonomous",
-                "loopType": "consumer",
+                "processing_type": "implementation",
                 "description": "Claude implements each story, committing code to git.",
                 "inputs": ["stories", "design_doc", "guardrails"],
                 "outputs": ["code"],
@@ -3138,23 +3199,31 @@ class ProjectDatabase:
             ),
         )
 
-        # From Design Doc workflow - skips planning, starts with story generation
+        # From Design Doc workflow - skips design doc, starts with story generation
         from_design_doc_phases = json.dumps([
             {
                 "number": 1,
-                "name": "Story Generation",
-                "type": "autonomous",
-                "loopType": "generator",
-                "description": "Claude generates detailed user stories from your design document.",
+                "name": "Story Generation (Extract)",
+                "processing_type": "extractgen_requirements",
+                "description": "Claude extracts user stories from your design document.",
                 "inputs": ["design_doc"],
                 "outputs": ["stories"],
                 "skippable": False
             },
             {
                 "number": 2,
+                "name": "Story Generation (Web)",
+                "processing_type": "webgen_requirements",
+                "description": "Claude discovers additional requirements via web research.",
+                "inputs": ["design_doc", "stories"],
+                "outputs": ["stories"],
+                "skippable": True,
+                "skipCondition": "Skip web research"
+            },
+            {
+                "number": 3,
                 "name": "Implementation",
-                "type": "autonomous",
-                "loopType": "consumer",
+                "processing_type": "implementation",
                 "description": "Claude implements each story, committing code to git.",
                 "inputs": ["stories", "design_doc"],
                 "outputs": ["code"],
@@ -3179,8 +3248,7 @@ class ProjectDatabase:
             {
                 "number": 1,
                 "name": "Implementation",
-                "type": "autonomous",
-                "loopType": "consumer",
+                "processing_type": "implementation",
                 "description": "Claude implements each story, committing code to git.",
                 "inputs": ["stories"],
                 "outputs": ["code"],
@@ -3200,12 +3268,12 @@ class ProjectDatabase:
             ),
         )
 
-        # Planning Only workflow - just the interactive planning step
+        # Design Doc Only workflow - just the interactive design doc step
         planning_only_phases = json.dumps([
             {
                 "number": 1,
-                "name": "Planning",
-                "type": "interactive",
+                "name": "Design Document",
+                "processing_type": "design_doc",
                 "description": "Collaborate with Claude to create a comprehensive design document.",
                 "outputs": ["design_doc", "guardrails"],
                 "skippable": False
@@ -3273,7 +3341,6 @@ class ProjectDatabase:
         self,
         id: str,
         name: str,
-        namespace: str,
         template_id: Optional[str] = None,
         status: str = "draft",
     ) -> dict:
@@ -3282,29 +3349,19 @@ class ProjectDatabase:
         Args:
             id: Unique workflow identifier.
             name: User-facing workflow name.
-            namespace: Namespace to link all phases.
             template_id: Optional template ID this workflow is based on.
             status: Initial status (default: draft).
 
         Returns:
             The created workflow dict.
-
-        Raises:
-            ValueError: If namespace is invalid.
         """
-        if not validate_namespace(namespace):
-            raise ValueError(
-                f"Invalid namespace '{namespace}'. Must match pattern: "
-                "lowercase letter followed by up to 63 lowercase letters, digits, underscores, or dashes."
-            )
-
         with self._writer() as conn:
             now = datetime.utcnow().isoformat()
             conn.execute(
                 """INSERT INTO workflows
-                   (id, template_id, name, namespace, status, current_step, created_at, updated_at)
-                   VALUES (?, ?, ?, ?, ?, 1, ?, ?)""",
-                (id, template_id, name, namespace, status, now, now),
+                   (id, template_id, name, status, current_step, created_at, updated_at)
+                   VALUES (?, ?, ?, ?, 1, ?, ?)""",
+                (id, template_id, name, status, now, now),
             )
         return self.get_workflow(id)
 
@@ -3318,7 +3375,6 @@ class ProjectDatabase:
     def list_workflows(
         self,
         status: Optional[str] = None,
-        namespace: Optional[str] = None,
         include_archived: bool = False,
         archived_only: bool = False,
     ) -> list[dict]:
@@ -3326,7 +3382,6 @@ class ProjectDatabase:
 
         Args:
             status: Filter by workflow status.
-            namespace: Filter by namespace.
             include_archived: If True, include archived workflows.
             archived_only: If True, only return archived workflows.
         """
@@ -3337,9 +3392,6 @@ class ProjectDatabase:
             if status:
                 conditions.append("status = ?")
                 params.append(status)
-            if namespace:
-                conditions.append("namespace = ?")
-                params.append(namespace)
 
             # Handle archived filtering
             if archived_only:
@@ -4779,6 +4831,8 @@ class ProjectDatabase:
         workflow_id: str,
         step_id: int,
         messages: Optional[list] = None,
+        artifacts: Optional[dict] = None,
+        status: str = "active",
     ) -> dict:
         """Create a planning session for an interactive step.
 
@@ -4787,6 +4841,8 @@ class ProjectDatabase:
             workflow_id: Parent workflow ID.
             step_id: Parent step ID.
             messages: Initial messages (default: empty list).
+            artifacts: Optional artifacts dict.
+            status: Session status (default: 'active').
 
         Returns:
             The created session dict.
@@ -4794,11 +4850,12 @@ class ProjectDatabase:
         with self._writer() as conn:
             now = datetime.utcnow().isoformat()
             messages_json = json.dumps(messages or [])
+            artifacts_json = json.dumps(artifacts) if artifacts else None
             conn.execute(
                 """INSERT INTO planning_sessions
-                   (id, workflow_id, step_id, messages, status, created_at, updated_at)
-                   VALUES (?, ?, ?, ?, 'active', ?, ?)""",
-                (id, workflow_id, step_id, messages_json, now, now),
+                   (id, workflow_id, step_id, messages, artifacts, status, created_at, updated_at)
+                   VALUES (?, ?, ?, ?, ?, ?, ?, ?)""",
+                (id, workflow_id, step_id, messages_json, artifacts_json, status, now, now),
             )
         return self.get_planning_session(id)
 
@@ -4853,6 +4910,49 @@ class ProjectDatabase:
                 return result
             return None
 
+    def list_planning_sessions(
+        self,
+        workflow_id: Optional[str] = None,
+        status: Optional[str] = None,
+    ) -> list[dict]:
+        """List planning sessions with optional filtering.
+
+        Args:
+            workflow_id: Filter by workflow ID.
+            status: Filter by status ('active', 'completed').
+
+        Returns:
+            List of planning session dicts.
+        """
+        with self._reader() as conn:
+            conditions = []
+            params: list[Any] = []
+
+            if workflow_id:
+                conditions.append("workflow_id = ?")
+                params.append(workflow_id)
+            if status:
+                conditions.append("status = ?")
+                params.append(status)
+
+            where_clause = " AND ".join(conditions) if conditions else "1=1"
+            cursor = conn.execute(
+                f"""SELECT * FROM planning_sessions
+                   WHERE {where_clause}
+                   ORDER BY created_at DESC""",
+                params,
+            )
+
+            results = []
+            for row in cursor.fetchall():
+                result = dict(row)
+                if result.get("messages"):
+                    result["messages"] = json.loads(result["messages"])
+                if result.get("artifacts"):
+                    result["artifacts"] = json.loads(result["artifacts"])
+                results.append(result)
+            return results
+
     def add_planning_message(
         self,
         session_id: str,