qontract-reconcile 0.9.1rc174__py3-none-any.whl → 0.9.1rc175__py3-none-any.whl

{qontract_reconcile-0.9.1rc174.dist-info → qontract_reconcile-0.9.1rc175.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: qontract-reconcile
-Version: 0.9.1rc174
+Version: 0.9.1rc175
 Summary: Collection of tools to reconcile services with their desired state as defined in the app-interface DB.
 Home-page: https://github.com/app-sre/qontract-reconcile
 Author: Red Hat App-SRE Team

{qontract_reconcile-0.9.1rc174.dist-info → qontract_reconcile-0.9.1rc175.dist-info}/RECORD

@@ -125,7 +125,7 @@ reconcile/sql_query.py,sha256=Xbg6iqotgwwFMx5i5-dMX3L8w_HDn2XLWDkvNC1oG_A,22188
 reconcile/status.py,sha256=tRYtzPFsGETOfN57rcsLIJRl7cZVFkfQXNsUtoeJ7ns,545
 reconcile/template_tester.py,sha256=vZz8GM46waQUGd3OVnhW5OLTqctFMH_Hh1QXxT5hduM,2384
 reconcile/terraform_aws_route53.py,sha256=fDNLXs8P1RyijqxFORypb1tRwaZYGATfT_Db9_HXXbw,9085
-reconcile/terraform_cloudflare_dns.py,sha256=fut76uLzA9FPSh3kDGo2oTyfhDMlh16_p4P5CeNbEtc,11858
+reconcile/terraform_cloudflare_dns.py,sha256=1nYuAFAEAFh1k66mpDgjgfSywajTwC01j4noB4SxlYU,12616
 reconcile/terraform_cloudflare_resources.py,sha256=kLFW7JFRr3_zNtw1kxed8YJFyHojUFQVBL2nEyr5drs,7028
 reconcile/terraform_cloudflare_users.py,sha256=lTbrxi8OtW9Pfcr7Yp-70ihldMQKx9dJ7ZgbGHey1XE,13627
 reconcile/terraform_resources.py,sha256=GJtbB37YEUznHJ2ZNVPMVENeyEqIkB57iHUT3P4MxWI,21888
@@ -491,8 +491,8 @@ tools/sre_checkpoints/util.py,sha256=zEDbGr18ZeHNQwW8pUsr2JRjuXIPz--WAGJxZo9sv_Y
 tools/test/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tools/test/test_qontract_cli.py,sha256=awwTHEc2DWlykuqGIYM0WOBoSL0KRnOraCLk3C7izis,1401
 tools/test/test_sre_checkpoints.py,sha256=SKqPPTl9ua0RFdSSofnoQX-JZE6dFLO3LRhfQzqtfh8,2607
-qontract_reconcile-0.9.1rc174.dist-info/METADATA,sha256=F331IGWtbZ-5Rxvr77VlbW9oLaPL6UC0X4BUnJF1yi0,2241
-qontract_reconcile-0.9.1rc174.dist-info/WHEEL,sha256=pkctZYzUS4AYVn6dJ-7367OJZivF2e8RA9b_ZBjif18,92
-qontract_reconcile-0.9.1rc174.dist-info/entry_points.txt,sha256=3BPvsRryM1C4S_mb5kXmP5AVv-wJBzVCrOJyv6qUmc0,195
-qontract_reconcile-0.9.1rc174.dist-info/top_level.txt,sha256=j0CHPIc8TsVRB50wOz_jhxjjaRyCJB3NOQeXhuHS67c,34
-qontract_reconcile-0.9.1rc174.dist-info/RECORD,,
+qontract_reconcile-0.9.1rc175.dist-info/METADATA,sha256=gu4YwVziFqPE3otyqFSQFiqE8fqPuV0fzFWrd9Tgmqs,2241
+qontract_reconcile-0.9.1rc175.dist-info/WHEEL,sha256=pkctZYzUS4AYVn6dJ-7367OJZivF2e8RA9b_ZBjif18,92
+qontract_reconcile-0.9.1rc175.dist-info/entry_points.txt,sha256=3BPvsRryM1C4S_mb5kXmP5AVv-wJBzVCrOJyv6qUmc0,195
+qontract_reconcile-0.9.1rc175.dist-info/top_level.txt,sha256=j0CHPIc8TsVRB50wOz_jhxjjaRyCJB3NOQeXhuHS67c,34
+qontract_reconcile-0.9.1rc175.dist-info/RECORD,,

reconcile/terraform_cloudflare_dns.py

@@ -92,6 +92,10 @@ class TerraformCloudflareDNSIntegration(
 
         query_zones = self._get_cloudflare_desired_state()
 
+        if are_record_identifiers_duplicated_within_zone(query_zones):
+            logging.error("Duplicate DNS record identifier(s) detected.")
+            sys.exit(ExitCodes.ERROR)
+
         # Build Cloudflare clients
         cf_clients = TerraformConfigClientCollection()
         zone_clients = build_clients(
@@ -179,6 +183,22 @@ class TerraformCloudflareDNSIntegration(
         )
 
 
+def are_record_identifiers_duplicated_within_zone(
+    zone_query_data: CloudflareDnsZoneQueryData,
+) -> bool:
+    duplicate_exist = False
+    for zone in zone_query_data.zones or []:
+        existing_records = set()
+        for record in zone.records or []:
+            record_id = record.identifier
+            if record_id not in existing_records:
+                existing_records.add(record_id)
+            else:
+                logging.warning(f"{record_id} already exists in zone {zone.identifier}")
+                duplicate_exist = True
+    return duplicate_exist
+
+
 def get_cloudflare_provider_rps(
     records: Optional[Sequence[CloudflareDnsRecordV1]],
 ) -> int: