qontract-reconcile 0.9.1rc131__py3-none-any.whl → 0.9.1rc133__py3-none-any.whl

{qontract_reconcile-0.9.1rc131.dist-info → qontract_reconcile-0.9.1rc133.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: qontract-reconcile
-Version: 0.9.1rc131
+Version: 0.9.1rc133
 Summary: Collection of tools to reconcile services with their desired state as defined in the app-interface DB.
 Home-page: https://github.com/app-sre/qontract-reconcile
 Author: Red Hat App-SRE Team

{qontract_reconcile-0.9.1rc131.dist-info → qontract_reconcile-0.9.1rc133.dist-info}/RECORD

@@ -16,7 +16,7 @@ reconcile/aws_iam_password_reset.py,sha256=Fequr4Zs7oARnp0rpC4B4rVfyZvl6LXZ3kaDs
 reconcile/aws_support_cases_sos.py,sha256=UJEs3lpmCioUxLu9ek2WuySCI3sYyc2dVP9zU0FIh1s,2888
 reconcile/blackbox_exporter_endpoint_monitoring.py,sha256=4MrHEFUCaHDtSL8DPAo7iJgZ95Nl1HiVzNFvshAJ0_M,3552
 reconcile/checkpoint.py,sha256=figtZRuWUvdpdSnkhAqeGvO5dI02TT6J3heyeFhlwqM,5016
-reconcile/cli.py,sha256=BH6ADj_EGy3ruZ9k_W1fA9hNUC5Yehr3jYZvr8jZpOc,70745
+reconcile/cli.py,sha256=_CnhmVbwH6d97ud04cX2Y5GqxrKyMg1-pIAI3T502pM,70825
 reconcile/closedbox_endpoint_monitoring_base.py,sha256=Yl1_BzgIQbLS6Y16W-u0I82WMcXADpIUOpfQ4J88umY,4888
 reconcile/cluster_deployment_mapper.py,sha256=2Ah-nu-Mdig0pjuiZl_XLrmVAjYzFjORR3dMlCgkmw0,2352
 reconcile/dashdotdb_base.py,sha256=Ca75-OQiu5HeA8Q6zQpEYuhyCSjeuWe99K4y9ipTORM,4032
@@ -87,15 +87,15 @@ reconcile/openshift_resources.py,sha256=Lkn3KdIqxUCmOzlwoKjM2xVotTbJDfgjMGySvWtB
 reconcile/openshift_resources_base.py,sha256=tWUCzZNEEOTjrl-9Fj2BUwSMt1xNyhqiqwSLBPXlZr4,40756
 reconcile/openshift_rolebindings.py,sha256=1k0o3hb3ZhhlbUjc8cP7IjKFux0oZApT8kLT8Y-pvqI,6579
 reconcile/openshift_routes.py,sha256=fXvuPSjcjVw1X3j2EQvUAdbOepmIFdKk-M3qP8QzPiw,1075
-reconcile/openshift_saas_deploy.py,sha256=4Ufk_dbd2ZkeAI8Q-blAgDrnXg9qqtq63LrkPNiBSZs,7857
+reconcile/openshift_saas_deploy.py,sha256=URaGXvp5C4rrQS3rgBLS-Czw5eJadByvYh1wvbENajI,8710
 reconcile/openshift_saas_deploy_change_tester.py,sha256=gdEke-uNKv1v8vuveThCn8_zEdP-BpiltS_OugqDFhg,9105
-reconcile/openshift_saas_deploy_trigger_base.py,sha256=zWmglGA_MgSyBN9_jZMPXzeIlTCIt0jXdeWeHMgj4IY,12741
-reconcile/openshift_saas_deploy_trigger_cleaner.py,sha256=ns07ibujXsQK7p76Eii6IMJOBJCPeFvrshQesTlTFv0,2506
-reconcile/openshift_saas_deploy_trigger_configs.py,sha256=528tvl4ydOx9FsU1sqCtH0zTZ80IcopwQtSjbTvMtvo,876
-reconcile/openshift_saas_deploy_trigger_images.py,sha256=0ArPhCAWxBeXKbOi7Hgg_83uDpQKWLEwu0yGIxgrfO8,884
-reconcile/openshift_saas_deploy_trigger_moving_commits.py,sha256=55zSfu4jLR12nE9bN4PNd386nTD4uA20qMkXt9sC_DA,890
-reconcile/openshift_saas_deploy_trigger_upstream_jobs.py,sha256=lPMutgC_fFcMJ0-MrjGmxCh4pS4fKdJQRbAMOeXddyM,888
-reconcile/openshift_saas_deploy_wrapper.py,sha256=VhOYalFNOK0-szqU9W5f-kfwwobKf-8LMxoOgpiNbjk,1701
+reconcile/openshift_saas_deploy_trigger_base.py,sha256=WARMn3elQ8TN0Z-9NKQLQZMhtSN2JO6iD3pRaaa44GY,13343
+reconcile/openshift_saas_deploy_trigger_cleaner.py,sha256=fbSO48dnIMPV6XKPDoPD0pEFrhHYWfZcmvQfxAwQ-Ps,2728
+reconcile/openshift_saas_deploy_trigger_configs.py,sha256=uWzUV5D5CW0frdi1ys7BObNg-rA-VZKlefd4TD_Z-pY,959
+reconcile/openshift_saas_deploy_trigger_images.py,sha256=Yl4lMtxqab-c04I2Ju8isAJuYuNTbHN01Bk3dF9nTos,967
+reconcile/openshift_saas_deploy_trigger_moving_commits.py,sha256=VqjwgRhA-yOSq0WFPqGIJVgYkdq_UrTHcVusBzOFgMY,973
+reconcile/openshift_saas_deploy_trigger_upstream_jobs.py,sha256=etfBGj7GDXTOhNHKc40ee5QM0Chq3oHE40HrbWgopc8,971
+reconcile/openshift_saas_deploy_wrapper.py,sha256=worob8HdaQ31kndkQoWXqD-wK2jAIa4IR5um6KRsyf4,1854
 reconcile/openshift_serviceaccount_tokens.py,sha256=UlBRjfAxzf9-h4uxQwHqrYnBWMUGFqqfp6KvW2lM76k,6369
 reconcile/openshift_tekton_resources.py,sha256=nSJDPqL6Rl3jeUQKS6mFIqkWPdbXu_FNCeHER8w_GyY,13552
 reconcile/openshift_upgrade_watcher.py,sha256=4LtXziBS1tGfUiioGGzx6h7ZHXdGk97DSMLNblcGmHk,4843
@@ -482,8 +482,8 @@ tools/sre_checkpoints/util.py,sha256=zEDbGr18ZeHNQwW8pUsr2JRjuXIPz--WAGJxZo9sv_Y
 tools/test/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tools/test/test_qontract_cli.py,sha256=awwTHEc2DWlykuqGIYM0WOBoSL0KRnOraCLk3C7izis,1401
 tools/test/test_sre_checkpoints.py,sha256=SKqPPTl9ua0RFdSSofnoQX-JZE6dFLO3LRhfQzqtfh8,2607
-qontract_reconcile-0.9.1rc131.dist-info/METADATA,sha256=mYwrCQaanq6ma80w7TVxGjcsshxqPANYM9gShmsCrR8,2259
-qontract_reconcile-0.9.1rc131.dist-info/WHEEL,sha256=2wepM1nk4DS4eFpYrW1TTqPcoGNfHhhO_i5m4cOimbo,92
-qontract_reconcile-0.9.1rc131.dist-info/entry_points.txt,sha256=3BPvsRryM1C4S_mb5kXmP5AVv-wJBzVCrOJyv6qUmc0,195
-qontract_reconcile-0.9.1rc131.dist-info/top_level.txt,sha256=j0CHPIc8TsVRB50wOz_jhxjjaRyCJB3NOQeXhuHS67c,34
-qontract_reconcile-0.9.1rc131.dist-info/RECORD,,
+qontract_reconcile-0.9.1rc133.dist-info/METADATA,sha256=Y6ZjvDqi2URKKdxZeGYrSJwCyJ2Xv3yYZRFNRJHCR44,2259
+qontract_reconcile-0.9.1rc133.dist-info/WHEEL,sha256=2wepM1nk4DS4eFpYrW1TTqPcoGNfHhhO_i5m4cOimbo,92
+qontract_reconcile-0.9.1rc133.dist-info/entry_points.txt,sha256=3BPvsRryM1C4S_mb5kXmP5AVv-wJBzVCrOJyv6qUmc0,195
+qontract_reconcile-0.9.1rc133.dist-info/top_level.txt,sha256=j0CHPIc8TsVRB50wOz_jhxjjaRyCJB3NOQeXhuHS67c,34
+qontract_reconcile-0.9.1rc133.dist-info/RECORD,,

reconcile/cli.py

@@ -1044,12 +1044,12 @@ def openshift_saas_deploy(
     run_integration(
         reconcile.openshift_saas_deploy,
         ctx.obj,
-        thread_pool_size,
-        io_dir,
-        use_jump_host,
-        saas_file_name,
-        env_name,
-        gitlab_project_id,
+        thread_pool_size=thread_pool_size,
+        io_dir=io_dir,
+        use_jump_host=use_jump_host,
+        saas_file_name=saas_file_name,
+        env_name=env_name,
+        gitlab_project_id=gitlab_project_id,
     )
 
 

reconcile/openshift_saas_deploy.py

@@ -1,5 +1,10 @@
 import logging
 import sys
+from collections.abc import Callable
+from typing import (
+    Any,
+    Optional,
+)
 
 import reconcile.jenkins_plugins as jenkins_base
 import reconcile.openshift_base as ob
@@ -16,12 +21,15 @@ from reconcile.utils.openshift_resource import ResourceInventory
 from reconcile.utils.saasherder import SaasHerder
 from reconcile.utils.secret_reader import SecretReader
 from reconcile.utils.semver_helper import make_semver
+from reconcile.utils.slack_api import SlackApi
 
 QONTRACT_INTEGRATION = "openshift-saas-deploy"
 QONTRACT_INTEGRATION_VERSION = make_semver(0, 1, 0)
 
 
-def compose_console_url(saas_file, saas_file_name, env_name):
+def compose_console_url(
+    saas_file: dict[str, Any], saas_file_name: str, env_name: str
+) -> str:
     pp = saas_file["pipelinesProvider"]
     pp_ns = pp["namespace"]
     pp_ns_name = pp_ns["name"]
@@ -46,7 +54,14 @@ def compose_console_url(saas_file, saas_file_name, env_name):
     )
 
 
-def slack_notify(saas_file_name, env_name, slack, ri, console_url, in_progress):
+def slack_notify(
+    saas_file_name: str,
+    env_name: str,
+    slack: SlackApi,
+    ri: ResourceInventory,
+    console_url: str,
+    in_progress: bool,
+) -> None:
     success = not ri.has_error_registered()
     if in_progress:
         icon = ":yellow_jenkins_circle:"
@@ -67,15 +82,15 @@ def slack_notify(saas_file_name, env_name, slack, ri, console_url, in_progress):
 
 @defer
 def run(
-    dry_run,
-    thread_pool_size=10,
-    io_dir="throughput/",
-    use_jump_host=True,
-    saas_file_name=None,
-    env_name=None,
-    gitlab_project_id=None,
-    defer=None,
-):
+    dry_run: bool,
+    thread_pool_size: int = 10,
+    io_dir: str = "throughput/",
+    use_jump_host: bool = True,
+    saas_file_name: Optional[str] = None,
+    env_name: Optional[str] = None,
+    gitlab_project_id: Optional[str] = None,
+    defer: Optional[Callable] = None,
+) -> None:
     all_saas_files = queries.get_saas_files()
     saas_files = queries.get_saas_files(saas_file_name, env_name)
     if not saas_files:
@@ -91,6 +106,11 @@ def run(
         saas_file = saas_files[0]
         slack_info = saas_file.get("slack")
         if slack_info:
+            if not saas_file_name or not env_name:
+                raise RuntimeError(
+                    "saas_file_name and env_name must be provided "
+                    + "when using slack notifications"
+                )
             slack = slackapi_from_slack_workspace(
                 slack_info,
                 SecretReader(queries.get_secret_reader_settings()),
@@ -99,17 +119,20 @@ def run(
             )
             ri = ResourceInventory()
             console_url = compose_console_url(saas_file, saas_file_name, env_name)
-            # deployment result notification
-            defer(
-                lambda: slack_notify(
-                    saas_file_name,
-                    env_name,
-                    slack,
-                    ri,
-                    console_url,
-                    in_progress=False,
+            if (
+                defer
+            ):  # defer is provided by the method decorator. this makes just mypy happy
+                # deployment result notification
+                defer(
+                    lambda: slack_notify(
+                        saas_file_name,
+                        env_name,
+                        slack,
+                        ri,
+                        console_url,
+                        in_progress=False,
+                    )
                 )
-            )
             # deployment start notification
             slack_notifications = slack_info.get("notifications")
             if slack_notifications and slack_notifications.get("start"):
@@ -163,7 +186,8 @@ def run(
         cluster_admin=saasherder.cluster_admin,
         use_jump_host=use_jump_host,
     )
-    defer(oc_map.cleanup)
+    if defer:  # defer is provided by the method decorator. this makes just mypy happy
+        defer(oc_map.cleanup)
     saasherder.populate_desired_state(ri)
 
     # validate that this deployment is valid

reconcile/openshift_saas_deploy_trigger_base.py

@@ -1,7 +1,12 @@
 import datetime
 import logging
+from collections.abc import Callable
 from threading import Lock
-from typing import cast
+from typing import (
+    Any,
+    Optional,
+    cast,
+)
 
 from sretoolbox.utils import threaded
 
@@ -31,16 +36,16 @@ class TektonTimeoutBadValueError(Exception):
 
 @defer
 def run(
-    dry_run,
-    trigger_type,
-    integration,
-    integration_version,
-    thread_pool_size,
-    internal,
-    use_jump_host,
-    include_trigger_trace,
-    defer=None,
-):
+    dry_run: bool,
+    trigger_type: str,
+    integration: str,
+    integration_version: str,
+    thread_pool_size: int,
+    internal: bool,
+    use_jump_host: bool,
+    include_trigger_trace: bool,
+    defer: Optional[Callable] = None,
+) -> bool:
     """Run trigger integration
 
     Args:
@@ -67,12 +72,13 @@ def run(
     )
     if error:
         return error
-    defer(oc_map.cleanup)
+    if defer:  # defer is set by method decorator. this makes just mypy happy
+        defer(oc_map.cleanup)
 
     trigger_specs, diff_err = saasherder.get_diff(trigger_type, dry_run)
     # This will be populated by 'trigger' in the below loop and
     # we need it to be consistent across all iterations
-    already_triggered = set()
+    already_triggered: set[str] = set()
 
     errors = threaded.run(
         trigger,
@@ -91,13 +97,13 @@ def run(
 
 
 def setup(
-    thread_pool_size,
-    internal,
-    use_jump_host,
-    integration,
-    integration_version,
-    include_trigger_trace,
-):
+    thread_pool_size: int,
+    internal: bool,
+    use_jump_host: bool,
+    integration: str,
+    integration_version: str,
+    include_trigger_trace: bool,
+) -> tuple[SaasHerder, OC_Map, bool]:
     """Setup required resources for triggering integrations
 
     Args:
@@ -116,8 +122,7 @@ def setup(
 
     saas_files = queries.get_saas_files()
     if not saas_files:
-        logging.error("no saas files found")
-        return None, None, True
+        raise RuntimeError("no saas files found")
     saas_files = [sf for sf in saas_files if is_in_shard(sf["name"])]
 
     # Remove saas-file targets that are disabled
@@ -215,7 +220,7 @@ def _trigger_tekton(
     already_triggered: set[str],
     integration: str,
     integration_version: str,
-):
+) -> bool:
     saas_file_name = spec.saas_file_name
     env_name = spec.env_name
     timeout = spec.timeout
@@ -292,25 +297,29 @@ def _trigger_tekton(
     return error
 
 
-def _pipeline_exists(name, tkn_cluster_name, tkn_namespace_name, oc_map):
+def _pipeline_exists(
+    name: str, tkn_cluster_name: str, tkn_namespace_name: str, oc_map: OC_Map
+) -> bool:
     oc = oc_map.get(tkn_cluster_name)
-    return oc.get(
+    if oc.get(
         namespace=tkn_namespace_name, kind="Pipeline", name=name, allow_not_found=True
-    )
+    ):
+        return True
+    return False
 
 
 def _construct_tekton_trigger_resource(
-    saas_file_name,
-    env_name,
-    tkn_pipeline_name,
-    timeout,
-    tkn_cluster_console_url,
-    tkn_namespace_name,
-    integration,
-    integration_version,
-    include_trigger_trace,
-    reason,
-):
+    saas_file_name: str,
+    env_name: str,
+    tkn_pipeline_name: str,
+    timeout: Optional[str],
+    tkn_cluster_console_url: str,
+    tkn_namespace_name: str,
+    integration: str,
+    integration_version: str,
+    include_trigger_trace: bool,
+    reason: Optional[str],
+) -> tuple[OR, str]:
     """Construct a resource (PipelineRun) to trigger a deployment via Tekton.
 
     Args:
@@ -319,7 +328,7 @@ def _construct_tekton_trigger_resource(
         tkn_cluster_console_url (string): Cluster console URL of the cluster
                                           where the pipeline runs
         tkn_namespace_name (string): namespace where the pipeline runs
-        timeout (int): Timeout in minutes before the PipelineRun fails (must be > 60)
+        timeout (str): Timeout in minutes before the PipelineRun fails (must be > 60)
         integration (string): Name of calling integration
         integration_version (string): Version of calling integration
         include_trigger_trace (bool): Should include traces of the triggering integration and reason
@@ -343,13 +352,18 @@ def _construct_tekton_trigger_resource(
         {"name": "tkn_namespace_name", "value": tkn_namespace_name},
     ]
     if include_trigger_trace:
+        if not reason:
+            raise RuntimeError(
+                "reason must be provided if include_trigger_trace is True"
+            )
+
         parameters.extend(
             [
                 {"name": "trigger_integration", "value": integration},
                 {"name": "trigger_reason", "value": reason},
             ]
         )
-    body = {
+    body: dict[str, Any] = {
         "apiVersion": "tekton.dev/v1beta1",
         "kind": "PipelineRun",
         "metadata": {"name": name},
@@ -371,7 +385,7 @@ def _construct_tekton_trigger_resource(
     return OR(body, integration, integration_version, error_details=name), long_name
 
 
-def _register_trigger(name, already_triggered):
+def _register_trigger(name: str, already_triggered: set[str]) -> bool:
     """checks if a trigger should occur and registers as if it did
 
     Args:
@@ -382,8 +396,6 @@ def _register_trigger(name, already_triggered):
     Returns:
         bool: to trigger or not to trigger
     """
-    global _trigger_lock
-
     to_trigger = False
     with _trigger_lock:
         if name not in already_triggered:

reconcile/openshift_saas_deploy_trigger_cleaner.py

@@ -1,9 +1,14 @@
 import logging
+from collections.abc import Callable
 from datetime import (
     datetime,
     timedelta,
     timezone,
 )
+from typing import (
+    Any,
+    Optional,
+)
 
 from dateutil import parser
 
@@ -17,7 +22,7 @@ QONTRACT_INTEGRATION = "openshift-saas-deploy-trigger-cleaner"
 QONTRACT_INTEGRATION_VERSION = make_semver(0, 1, 0)
 
 
-def within_retention_days(resource, days):
+def within_retention_days(resource: dict[str, Any], days: int) -> bool:
     metadata = resource["metadata"]
     creation_date = parser.parse(metadata["creationTimestamp"])
     now_date = datetime.now(timezone.utc)
@@ -27,7 +32,13 @@ def within_retention_days(resource, days):
 
 
 @defer
-def run(dry_run, thread_pool_size=10, internal=None, use_jump_host=True, defer=None):
+def run(
+    dry_run: bool,
+    thread_pool_size: int = 10,
+    internal: Optional[bool] = None,
+    use_jump_host: bool = True,
+    defer: Optional[Callable] = None,
+) -> None:
     settings = queries.get_app_interface_settings()
     pipelines_providers = queries.get_pipelines_providers()
     tkn_namespaces = [
@@ -44,7 +55,8 @@ def run(dry_run, thread_pool_size=10, internal=None, use_jump_host=True, defer=N
         use_jump_host=use_jump_host,
         thread_pool_size=thread_pool_size,
     )
-    defer(oc_map.cleanup)
+    if defer:
+        defer(oc_map.cleanup)
 
     for pp in pipelines_providers:
         retention = pp.get("retention")

reconcile/openshift_saas_deploy_trigger_configs.py

@@ -1,4 +1,5 @@
 import sys
+from typing import Optional
 
 import reconcile.openshift_saas_deploy_trigger_base as osdt_base
 from reconcile.status import ExitCodes
@@ -10,12 +11,12 @@ QONTRACT_INTEGRATION_VERSION = make_semver(0, 3, 0)
 
 
 def run(
-    dry_run,
-    thread_pool_size=10,
-    internal=None,
-    use_jump_host=True,
-    include_trigger_trace=False,
-):
+    dry_run: bool,
+    thread_pool_size: int = 10,
+    internal: Optional[bool] = None,
+    use_jump_host: bool = True,
+    include_trigger_trace: bool = False,
+) -> None:
     error = osdt_base.run(
         dry_run=dry_run,
         trigger_type=TriggerTypes.CONFIGS,

reconcile/openshift_saas_deploy_trigger_images.py

@@ -1,4 +1,5 @@
 import sys
+from typing import Optional
 
 import reconcile.openshift_saas_deploy_trigger_base as osdt_base
 from reconcile.status import ExitCodes
@@ -10,12 +11,12 @@ QONTRACT_INTEGRATION_VERSION = make_semver(0, 1, 0)
 
 
 def run(
-    dry_run,
-    thread_pool_size=10,
-    internal=None,
-    use_jump_host=True,
-    include_trigger_trace=False,
-):
+    dry_run: bool,
+    thread_pool_size: int = 10,
+    internal: Optional[bool] = None,
+    use_jump_host: bool = True,
+    include_trigger_trace: bool = False,
+) -> None:
     error = osdt_base.run(
         dry_run=dry_run,
         trigger_type=TriggerTypes.CONTAINER_IMAGES,

reconcile/openshift_saas_deploy_trigger_moving_commits.py

@@ -1,4 +1,5 @@
 import sys
+from typing import Optional
 
 import reconcile.openshift_saas_deploy_trigger_base as osdt_base
 from reconcile.status import ExitCodes
@@ -10,12 +11,12 @@ QONTRACT_INTEGRATION_VERSION = make_semver(0, 3, 0)
 
 
 def run(
-    dry_run,
-    thread_pool_size=10,
-    internal=None,
-    use_jump_host=True,
-    include_trigger_trace=False,
-):
+    dry_run: bool,
+    thread_pool_size: int = 10,
+    internal: Optional[bool] = None,
+    use_jump_host: bool = True,
+    include_trigger_trace: bool = False,
+) -> None:
     error = osdt_base.run(
         dry_run=dry_run,
         trigger_type=TriggerTypes.MOVING_COMMITS,

reconcile/openshift_saas_deploy_trigger_upstream_jobs.py

@@ -1,4 +1,5 @@
 import sys
+from typing import Optional
 
 import reconcile.openshift_saas_deploy_trigger_base as osdt_base
 from reconcile.status import ExitCodes
@@ -10,12 +11,12 @@ QONTRACT_INTEGRATION_VERSION = make_semver(0, 3, 0)
 
 
 def run(
-    dry_run,
-    thread_pool_size=10,
-    internal=None,
-    use_jump_host=True,
-    include_trigger_trace=False,
-):
+    dry_run: bool,
+    thread_pool_size: int = 10,
+    internal: Optional[bool] = None,
+    use_jump_host: bool = True,
+    include_trigger_trace: bool = False,
+) -> None:
     error = osdt_base.run(
         dry_run=dry_run,
         trigger_type=TriggerTypes.UPSTREAM_JOBS,

reconcile/openshift_saas_deploy_wrapper.py

@@ -1,4 +1,5 @@
 import sys
+from typing import Optional
 
 from sretoolbox.utils import threaded
 
@@ -13,8 +14,12 @@ QONTRACT_INTEGRATION_VERSION = make_semver(0, 1, 0)
 
 
 def osd_run_wrapper(
-    diff, dry_run, available_thread_pool_size, use_jump_host, gitlab_project_id
-):
+    diff: dict[str, str],
+    dry_run: bool,
+    available_thread_pool_size: int,
+    use_jump_host: bool,
+    gitlab_project_id: Optional[str],
+) -> int:
     saas_file_name = diff["saas_file_name"]
     env_name = diff["environment"]
     exit_code = 0
@@ -33,12 +38,12 @@ def osd_run_wrapper(
 
 
 def run(
-    dry_run,
-    thread_pool_size=10,
-    io_dir="throughput/",
-    use_jump_host=True,
-    gitlab_project_id=None,
-):
+    dry_run: bool,
+    thread_pool_size: int = 10,
+    io_dir: str = "throughput/",
+    use_jump_host: bool = True,
+    gitlab_project_id: Optional[str] = None,
+) -> None:
     saas_file_owners_diffs = read_saas_file_owners_diffs(io_dir)
     if len(saas_file_owners_diffs) == 0:
         return