qontract-reconcile 0.10.1rc850__py3-none-any.whl → 0.10.1rc852__py3-none-any.whl

{qontract_reconcile-0.10.1rc850.dist-info → qontract_reconcile-0.10.1rc852.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: qontract-reconcile
-Version: 0.10.1rc850
+Version: 0.10.1rc852
 Summary: Collection of tools to reconcile services with their desired state as defined in the app-interface DB.
 Home-page: https://github.com/app-sre/qontract-reconcile
 Author: Red Hat App-SRE Team

{qontract_reconcile-0.10.1rc850.dist-info → qontract_reconcile-0.10.1rc852.dist-info}/RECORD

@@ -426,7 +426,7 @@ reconcile/saas_auto_promotions_manager/integration.py,sha256=8IXLEvpblgZRr2UPfTs
 reconcile/saas_auto_promotions_manager/meta.py,sha256=76Jp50r6Y_KyJoXFfSjrt5YrCtXyg_A4FXXxHYiS3TE,161
 reconcile/saas_auto_promotions_manager/publisher.py,sha256=am8b0uLZIhWjSAgUHPtSOu2fRpa5wXaMl_WnVe4gv2k,3009
 reconcile/saas_auto_promotions_manager/s3_exporter.py,sha256=IKlVWZmiPnvl7sKeF6JgAlhXZe5CovKTxQc0SNkNSx4,2583
-reconcile/saas_auto_promotions_manager/subscriber.py,sha256=gz6l6xSeyYrs2KyEcXJoYbiH5JGSWE_T3VIqWl03A7k,10501
+reconcile/saas_auto_promotions_manager/subscriber.py,sha256=zAqifs7LxssQurO9UwWNrUnOqomRLuD_Z7nTXhU490o,8519
 reconcile/saas_auto_promotions_manager/merge_request_manager/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 reconcile/saas_auto_promotions_manager/merge_request_manager/batcher.py,sha256=lHIULPE8nmPN9pJVfZFdD0l48EB20o4cAy4owahJenw,7848
 reconcile/saas_auto_promotions_manager/merge_request_manager/desired_state.py,sha256=isY8frVsL3PlcdZmdZ4O0qyp76oczl4DUMX9uMArs5Y,1222
@@ -532,7 +532,7 @@ reconcile/test/test_quay_repos.py,sha256=TdkcRF_a8PLp01Kti9eZZN-vGup2yPBT4Iba3k0
 reconcile/test/test_queries.py,sha256=SpH3RmNpBjEr_ne3VjAMCgKK8RE1z1zo7bypkT5uoO4,1946
 reconcile/test/test_repo_owners.py,sha256=uRYMLbMmh-9usF0TerabZTZV-Z1CS4I6ybT-LQqCLe8,1423
 reconcile/test/test_requests_sender.py,sha256=7fd9C2kEFS0-CYtlsif66N1kO9c44pzuBPAJKR9igqU,5385
-reconcile/test/test_saasherder.py,sha256=hSZk34aZFq-wspT-kJmFuHjh8ztSr7IzGc5QdRVrsJ8,47164
+reconcile/test/test_saasherder.py,sha256=QFX6JrPCpB9jS-K_VleIjTf6NaF8NDa4UwddXXo1yPk,52127
 reconcile/test/test_saasherder_allowed_secret_paths.py,sha256=5NHQwNJO66at6HiyMZ5sVRTQDwxdvlOQo0KmkBWCw5Q,4853
 reconcile/test/test_secret_reader.py,sha256=kz7nzcPjvA08cytnvcA_PMA98AEyqJWsESkYeRn5xCk,4994
 reconcile/test/test_slack_base.py,sha256=gpbWOLNxMMX6fyAbs1JakhLTnwfedb3f7WpUae4tQZE,5060
@@ -784,9 +784,9 @@ reconcile/utils/runtime/meta.py,sha256=X44HzyXIBprf3zcsGr2XLCgoeFkz6r3U2nlFXM1H7
 reconcile/utils/runtime/runner.py,sha256=72cc-I6yXyPov8UCLHpyERRy1eiMLpGite2roO0yUlo,7979
 reconcile/utils/runtime/sharding.py,sha256=roCdbnBklhTK_g34zbgQYqzpKPaNQ8J6Xd9XLO9-t6Q,16258
 reconcile/utils/saasherder/__init__.py,sha256=J3MBZBFa5YmhqYm08QsjBXz8mFcVOCiOCkyIcw41t7E,343
-reconcile/utils/saasherder/interfaces.py,sha256=XXY35h8VWQ66z3LBPxaoUAMkIW50264DQiecrzyV6oA,9076
-reconcile/utils/saasherder/models.py,sha256=1DKXUmiTS_MejUfSpFCeuBLMTgR4ldv2N1tAz8qHAwc,5547
-reconcile/utils/saasherder/saasherder.py,sha256=5rKp1ONBgRgfRO9tMHheEHXjQbipqWB8kUALSCKMGDc,86545
+reconcile/utils/saasherder/interfaces.py,sha256=Tte-BAJ71FZF1J_ADay1UVIxLCJZcbefq4SRua4mn5w,9141
+reconcile/utils/saasherder/models.py,sha256=XiAb9pSmTxaNFa3XqNNfe1JxlGgTqsmd1nLi17iIV_g,5566
+reconcile/utils/saasherder/saasherder.py,sha256=4S3Q4tb11hmBI3rux5ajk-BUs-6Lfpg47uHZJj2uNKk,86787
 reconcile/utils/terraform/__init__.py,sha256=zNbiyTWo35AT1sFTElL2j_AA0jJ_yWE_bfFn-nD2xik,250
 reconcile/utils/terraform/config.py,sha256=5UVrd563TMcvi4ooa5JvWVDW1I3bIWg484u79evfV_8,164
 reconcile/utils/terraform/config_client.py,sha256=py-Ree-QUYD6Hvng6bM40VgSuttteehIKNgwOSoJO1o,4706
@@ -834,8 +834,8 @@ tools/test/test_app_interface_metrics_exporter.py,sha256=SX7qL3D1SIRKFo95FoQztvf
 tools/test/test_qontract_cli.py,sha256=_D61RFGAN5x44CY1tYbouhlGXXABwYfxKSWSQx3Jrss,4941
 tools/test/test_sd_app_sre_alert_report.py,sha256=v363r9zM7__0kR5K6mvJoGFcM9BvE33fWAayrqkpojA,2116
 tools/test/test_sre_checkpoints.py,sha256=SKqPPTl9ua0RFdSSofnoQX-JZE6dFLO3LRhfQzqtfh8,2607
-qontract_reconcile-0.10.1rc850.dist-info/METADATA,sha256=2AQhJlZY2SAm-W89c68dz2HN_BAkeautQ3Zafjb4y9o,2273
-qontract_reconcile-0.10.1rc850.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
-qontract_reconcile-0.10.1rc850.dist-info/entry_points.txt,sha256=GKQqCl2j2X1BJQ69een6rHcR26PmnxnONLNOQB-nRjY,491
-qontract_reconcile-0.10.1rc850.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
-qontract_reconcile-0.10.1rc850.dist-info/RECORD,,
+qontract_reconcile-0.10.1rc852.dist-info/METADATA,sha256=iKUIKevX3oHc70SMvq6rkwA29a-RH-fO9SncYOwTdQ4,2273
+qontract_reconcile-0.10.1rc852.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
+qontract_reconcile-0.10.1rc852.dist-info/entry_points.txt,sha256=GKQqCl2j2X1BJQ69een6rHcR26PmnxnONLNOQB-nRjY,491
+qontract_reconcile-0.10.1rc852.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
+qontract_reconcile-0.10.1rc852.dist-info/RECORD,,

reconcile/saas_auto_promotions_manager/subscriber.py

@@ -1,9 +1,9 @@
 import hashlib
 import logging
-from collections.abc import Iterable, Mapping
+from collections.abc import Iterable
 from dataclasses import dataclass
 from datetime import datetime, timedelta, timezone
-from typing import Any, Optional
+from typing import Optional
 
 from reconcile.gql_definitions.fragments.saas_target_namespace import (
     SaasTargetNamespace,
@@ -78,56 +78,6 @@ class Subscriber:
         self._compute_desired_ref()
         self._compute_desired_config_hashes()
 
-    @staticmethod
-    def from_exported_dict(data: Mapping[str, Any]) -> "Subscriber":
-        subscriber = Subscriber(
-            saas_name=data["1"],
-            template_name=data["2"],
-            ref=data["3"],
-            target_file_path=data["4"],
-            use_target_config_hash=data["5"],
-            target_namespace=SaasTargetNamespace(**data["6"]),
-            uid=data["7"],
-            soak_days=data["8"],
-        )
-        subscriber.desired_hashes = data["9"]
-        subscriber.desired_ref = data["10"]
-        return subscriber
-
-    def to_exportable_dict(self) -> dict[str, Any]:
-        """
-        We will later persist subscriber data as json in MRs. We keep key size small to use less space.
-        Note, the data will be encoded and encrypted in another component.
-        """
-        data: dict[str, Any] = {}
-        data["1"] = self.saas_name
-        data["2"] = self.template_name
-        data["3"] = self.ref
-        data["4"] = self.target_file_path
-        data["5"] = self._use_target_config_hash
-        data["6"] = self.target_namespace.dict(by_alias=True)
-        data["7"] = self.uid
-        data["8"] = self.soak_days
-        data["9"] = self.desired_hashes
-        data["10"] = self.desired_ref
-        return data
-
-    def __eq__(self, other: object) -> bool:
-        if not isinstance(other, Subscriber):
-            # don't attempt to compare against unrelated types
-            return False
-        return (
-            self.saas_name == other.saas_name
-            and self.template_name == other.template_name
-            and self.ref == other.ref
-            and self.target_file_path == other.target_file_path
-            and self._use_target_config_hash == other._use_target_config_hash
-            and self.desired_ref == other.desired_ref
-            and self.desired_hashes == other.desired_hashes
-            and self.target_namespace == other.target_namespace
-            and self.uid == other.uid
-        )
-
     def _validate_deployment(
         self, publisher: Publisher, channel: Channel
     ) -> Optional[DeploymentInfo]:

reconcile/test/test_saasherder.py

@@ -3,6 +3,7 @@ from collections.abc import (
     Iterable,
     MutableMapping,
 )
+from datetime import datetime, timedelta, timezone
 from typing import (
     Any,
     Optional,
@@ -1026,7 +1027,7 @@ class TestConfigHashPromotionsValidation(TestCase):
 
     def setUp(self) -> None:
         self.saas_file = self.gql_class_factory(  # type: ignore[attr-defined] # it's set in the fixture
-            SaasFile, Fixtures("saasherder").get_anymarkup("saas.gql.yml")
+            SaasFile, Fixtures("saasherder").get_anymarkup("saas-multi-channel.gql.yml")
         )
         self.state_patcher = patch("reconcile.utils.state.State", autospec=True)
         self.state_mock = self.state_patcher.start().return_value
@@ -1095,12 +1096,24 @@ class TestConfigHashPromotionsValidation(TestCase):
         promotion_data. This could happen if the parent target has run again
         with the same ref before the subscriber target promotion MR is merged.
         """
-        publisher_state = {
-            "success": True,
-            "saas_file": self.saas_file.name,
-            "target_config_hash": "will_not_match",
-        }
-        self.state_mock.get.return_value = publisher_state
+        publisher_states = [
+            {
+                "success": True,
+                "saas_file": self.saas_file.name,
+                "target_config_hash": "ed2af38cf21f268c",
+            },
+            {
+                "success": True,
+                "saas_file": self.saas_file.name,
+                "target_config_hash": "ed2af38cf21f268c",
+            },
+            {
+                "success": True,
+                "saas_file": self.saas_file.name,
+                "target_config_hash": "will_not_match",
+            },
+        ]
+        self.state_mock.get.side_effect = publisher_states
         result = self.saasherder.validate_promotions()
         self.assertFalse(result)
 
@@ -1126,16 +1139,133 @@ class TestConfigHashPromotionsValidation(TestCase):
             "target_config_hash": "whatever",
         }
 
-        self.assertEqual(len(self.saasherder.promotions), 2)
-        self.assertIsNotNone(self.saasherder.promotions[1])
+        self.assertEqual(len(self.saasherder.promotions), 4)
+        self.assertIsNotNone(self.saasherder.promotions[3])
         # Remove promotion_data on the promoted target
-        self.saasherder.promotions[1].promotion_data = None  # type: ignore
+        self.saasherder.promotions[3].promotion_data = None  # type: ignore
 
         self.state_mock.get.return_value = publisher_state
         result = self.saasherder.validate_promotions()
         self.assertTrue(result)
 
 
+@pytest.mark.usefixtures("inject_gql_class_factory")
+class TestSoakDays(TestCase):
+    """TestCase to test SaasHerder soakDays gate. SaasHerder is
+    initialized with ResourceInventory population. Like is done in
+    openshift-saas-deploy"""
+
+    cluster: str
+    namespace: str
+    fxt: Any
+    template: Any
+
+    @classmethod
+    def setUpClass(cls) -> None:
+        cls.fxt = Fixtures("saasherder")
+        cls.cluster = "test-cluster"
+        cls.template = cls.fxt.get_anymarkup("template_1.yml")
+
+    def setUp(self) -> None:
+        self.saas_file = self.gql_class_factory(  # type: ignore[attr-defined] # it's set in the fixture
+            SaasFile, Fixtures("saasherder").get_anymarkup("saas-soak-days.gql.yml")
+        )
+        self.state_patcher = patch("reconcile.utils.state.State", autospec=True)
+        self.state_mock = self.state_patcher.start().return_value
+
+        self.ig_patcher = patch.object(SaasHerder, "_initiate_github", autospec=True)
+        self.ig_patcher.start()
+
+        self.image_auth_patcher = patch.object(SaasHerder, "_initiate_image_auth")
+        self.image_auth_patcher.start()
+
+        self.gfc_patcher = patch.object(SaasHerder, "_get_file_contents", autospec=True)
+        gfc_mock = self.gfc_patcher.start()
+        gfc_mock.return_value = (self.template, "url", "ahash")
+
+        self.deploy_current_state_fxt = self.fxt.get_anymarkup("saas_deploy.state.json")
+
+        self.post_deploy_current_state_fxt = self.fxt.get_anymarkup(
+            "saas_post_deploy.state.json"
+        )
+
+        self.saasherder = SaasHerder(
+            [self.saas_file],
+            secret_reader=MockSecretReader(),
+            thread_pool_size=1,
+            state=self.state_mock,
+            integration="",
+            integration_version="",
+            hash_length=24,
+            repo_url="https://repo-url.com",
+            all_saas_files=[self.saas_file],
+        )
+
+        # IMPORTANT: Populating desired state modify self.saas_files within
+        # saasherder object.
+        self.ri = ResourceInventory()
+        for ns in ["test-ns-publisher", "test-ns-subscriber"]:
+            for kind in ["Service", "Deployment"]:
+                self.ri.initialize_resource_type(self.cluster, ns, kind)
+
+        self.saasherder.populate_desired_state(self.ri)
+        if self.ri.has_error_registered():
+            raise Exception("Errors registered in Resourceinventory")
+
+    def tearDown(self) -> None:
+        self.state_patcher.stop()
+        self.ig_patcher.stop()
+        self.gfc_patcher.stop()
+
+    def test_soak_days_passed(self) -> None:
+        """A promotion is valid if the parent targets accumulated soak_days
+        passed. We have a soakDays setting of 2 days.
+        """
+        publisher_states = [
+            {
+                "success": True,
+                "saas_file": self.saas_file.name,
+                "target_config_hash": "ed2af38cf21f268c",
+                # the deployment happened 1 hour ago
+                "check_in": str(datetime.now(timezone.utc) - timedelta(hours=1)),
+            },
+            {
+                "success": True,
+                "saas_file": self.saas_file.name,
+                "target_config_hash": "ed2af38cf21f268c",
+                # the deployment happened 47 hours ago
+                "check_in": str(datetime.now(timezone.utc) - timedelta(hours=47)),
+            },
+        ]
+        self.state_mock.get.side_effect = publisher_states
+        result = self.saasherder.validate_promotions()
+        self.assertTrue(result)
+
+    def test_soak_days_not_passed(self) -> None:
+        """A promotion is valid if the parent target accumulated soak_days
+        passed. We have a soakDays setting of 2 days.
+        """
+        publisher_states = [
+            {
+                "success": True,
+                "saas_file": self.saas_file.name,
+                "target_config_hash": "ed2af38cf21f268c",
+                # the deployment happened 12 hours ago
+                "check_in": str(datetime.now(timezone.utc) - timedelta(hours=12)),
+            },
+            {
+                "success": True,
+                "saas_file": self.saas_file.name,
+                "target_config_hash": "ed2af38cf21f268c",
+                # the deployment happened 1 hour ago
+                "check_in": str(datetime.now(timezone.utc) - timedelta(hours=1)),
+            },
+        ]
+        self.state_mock.get.side_effect = publisher_states
+        result = self.saasherder.validate_promotions()
+        self.assertFalse(result)
+
+
 @pytest.mark.usefixtures("inject_gql_class_factory")
 class TestConfigHashTrigger(TestCase):
     """TestCase to test Openshift SAAS deploy configs trigger. SaasHerder is

reconcile/utils/saasherder/interfaces.py

@@ -242,6 +242,7 @@ class SaasResourceTemplateTargetPromotion(Protocol):
     auto: Optional[bool]
     publish: Optional[list[str]]
     subscribe: Optional[list[str]]
+    soak_days: Optional[int]
 
     @property
     def promotion_data(self) -> Optional[Sequence[SaasPromotionData]]: ...
@@ -261,6 +262,7 @@ class SaasPromotion(Protocol):
     publish: Optional[list[str]] = None
     saas_file_paths: Optional[list[str]] = None
     target_paths: Optional[list[str]] = None
+    soak_days: Optional[int] = None
 
     @property
     def promotion_data(self) -> Optional[Sequence[SaasPromotionData]]: ...

reconcile/utils/saasherder/models.py

@@ -179,6 +179,7 @@ class Promotion(BaseModel):
     saas_file: str
     target_config_hash: str
     saas_target_uid: str
+    soak_days: int
     auto: Optional[bool] = None
     publish: Optional[list[str]] = None
     subscribe: Optional[list[Channel]] = None

reconcile/utils/saasherder/saasherder.py

@@ -16,7 +16,7 @@ from collections.abc import (
     Sequence,
 )
 from contextlib import suppress
-from datetime import datetime, timezone
+from datetime import datetime, timedelta, timezone
 from types import TracebackType
 from typing import (
     Any,
@@ -1068,6 +1068,7 @@ class SaasHerder:  # pylint: disable=too-many-public-methods
                     parent_resource_template_name=resource_template_name,
                     parent_saas_file_name=saas_file_name,
                 ),
+                soak_days=target.promotion.soak_days or 0,
             )
         return resources, html_url, target_promotion
 
@@ -1880,82 +1881,98 @@ class SaasHerder:  # pylint: disable=too-many-public-methods
             # TODO: add environment.parameters to the include list!?!?
         )
 
-    def validate_promotions(self) -> bool:
-        """
-        If there were promotion sections in the participating saas files
-        validate that the conditions are met."""
+    def _validate_promotion(self, promotion: Promotion) -> bool:
+        # Placing this check here to make mypy happy
         if not (self.state and self._promotion_state):
             raise Exception("state is not initialized")
 
-        for promotion in self.promotions:
-            if promotion is None:
-                continue
-            # validate that the commit sha being promoted
-            # was successfully published to the subscribed channel(s)
-            if promotion.subscribe:
-                for channel in promotion.subscribe:
-                    config_hashes: set[str] = set()
-                    for target_uid in channel.publisher_uids:
-                        deployment = self._promotion_state.get_promotion_data(
-                            sha=promotion.commit_sha,
-                            channel=channel.name,
-                            target_uid=target_uid,
-                            local_lookup=False,
-                        )
-                        if not (deployment and deployment.success):
-                            logging.error(
-                                f"Commit {promotion.commit_sha} was not "
-                                + f"published with success to channel {channel.name}"
-                            )
-                            return False
-                        if deployment.target_config_hash:
-                            config_hashes.add(deployment.target_config_hash)
-
-                    # This code supports current saas targets that does
-                    # not have promotion_data yet
-                    if not config_hashes or not promotion.promotion_data:
-                        logging.info(
-                            "Promotion data is missing; rely on the success "
-                            "state only"
-                        )
-                        return True
-
-                    # Validate the promotion_data section.
-                    # Just validate parent_saas_config hash
-                    # promotion_data type by now.
-                    parent_saas_config = None
-                    for pd in promotion.promotion_data:
-                        if pd.channel == channel.name:
-                            for data in pd.data or []:
-                                if isinstance(data, SaasParentSaasPromotion):
-                                    parent_saas_config = data
-
-                    # This section might not exist due to a manual MR.
-                    # Promotion shall continue if this data is missing.
-                    # The parent at the same ref has succeed if this code
-                    # is reached though.
-                    if not parent_saas_config:
-                        logging.info(
-                            "Parent Saas config missing on target "
-                            "rely on the success state only"
-                        )
-                        return True
-
-                    # Validate that the state config_hash set by the parent
-                    # matches with the hash set in promotion_data
-                    if parent_saas_config.target_config_hash in config_hashes:
-                        return True
+        if not promotion.subscribe:
+            return True
 
+        now = datetime.now(timezone.utc)
+        passed_soak_days = timedelta(days=0)
+
+        for channel in promotion.subscribe:
+            config_hashes: set[str] = set()
+            for target_uid in channel.publisher_uids:
+                deployment = self._promotion_state.get_promotion_data(
+                    sha=promotion.commit_sha,
+                    channel=channel.name,
+                    target_uid=target_uid,
+                    local_lookup=False,
+                )
+                if not (deployment and deployment.success):
                     logging.error(
-                        "Parent saas target has run with a newer "
-                        "configuration and the same commit (ref). "
-                        "Check if other MR exists for this target, "
-                        f"or update {parent_saas_config.target_config_hash} "
-                        f"to any in {config_hashes} for channel {channel.name}"
+                        f"Commit {promotion.commit_sha} was not "
+                        + f"published with success to channel {channel.name}"
                     )
                     return False
+                if check_in := deployment.check_in:
+                    passed_soak_days += now - datetime.fromisoformat(check_in)
+                if deployment.target_config_hash:
+                    config_hashes.add(deployment.target_config_hash)
+
+            # This code supports current saas targets that does
+            # not have promotion_data yet
+            if not config_hashes or not promotion.promotion_data:
+                logging.info(
+                    "Promotion data is missing; rely on the success " "state only"
+                )
+                continue
+
+            # Validate the promotion_data section.
+            # Just validate parent_saas_config hash
+            # promotion_data type by now.
+            parent_saas_config = None
+            for pd in promotion.promotion_data:
+                if pd.channel == channel.name:
+                    for data in pd.data or []:
+                        if isinstance(data, SaasParentSaasPromotion):
+                            parent_saas_config = data
+
+            # This section might not exist due to a manual MR.
+            # Promotion shall continue if this data is missing.
+            # The parent at the same ref has succeed if this code
+            # is reached though.
+            if not parent_saas_config:
+                logging.info(
+                    "Parent Saas config missing on target "
+                    "rely on the success state only"
+                )
+                continue
+
+            # Validate that the state config_hash set by the parent
+            # matches with the hash set in promotion_data
+            if parent_saas_config.target_config_hash in config_hashes:
+                continue
+
+            logging.error(
+                "Parent saas target has run with a newer "
+                "configuration and the same commit (ref). "
+                "Check if other MR exists for this target, "
+                f"or update {parent_saas_config.target_config_hash} "
+                f"to any in {config_hashes} for channel {channel.name}"
+            )
+            return False
+
+        if passed_soak_days < timedelta(days=promotion.soak_days):
+            logging.error(
+                f"SoakDays in publishers did not pass. So far accumulated soakDays is {passed_soak_days},"
+                f"but we have a soakDays setting of {promotion.soak_days}. We cannot proceed with this promotion."
+            )
+            return False
         return True
 
+    def validate_promotions(self) -> bool:
+        """
+        If there were promotion sections in the participating saas files
+        validate that the conditions are met."""
+        return all(
+            self._validate_promotion(promotion)
+            for promotion in self.promotions
+            if promotion is not None
+        )
+
     def publish_promotions(
         self,
         success: bool,