qontract-reconcile 0.10.1rc757__py3-none-any.whl → 0.10.1rc759__py3-none-any.whl

{qontract_reconcile-0.10.1rc757.dist-info → qontract_reconcile-0.10.1rc759.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: qontract-reconcile
-Version: 0.10.1rc757
+Version: 0.10.1rc759
 Summary: Collection of tools to reconcile services with their desired state as defined in the app-interface DB.
 Home-page: https://github.com/app-sre/qontract-reconcile
 Author: Red Hat App-SRE Team

{qontract_reconcile-0.10.1rc757.dist-info → qontract_reconcile-0.10.1rc759.dist-info}/RECORD

@@ -105,7 +105,7 @@ reconcile/service_dependencies.py,sha256=PMKP9vc6oL-78rzyF_RE8DzLSQMSqN8vCqt9sWp
 reconcile/signalfx_endpoint_monitoring.py,sha256=D1m8iq0EAKie0OD59FOcVCtpWWZ7xlo6lwBS9urwMIk,2894
 reconcile/slack_base.py,sha256=K3fSYx46G1djoPb07_C9j6ChhMCt5LgV5l6v2TFkNZk,3479
 reconcile/slack_usergroups.py,sha256=XC7bYHP322EFWrEaR4Orw_sOoMFmuV3o08OC0UE4xLQ,27592
-reconcile/sql_query.py,sha256=zZkihfI-f0JjMez9A83HGTlVwqqbkP8lLjRg-z7sOUU,25878
+reconcile/sql_query.py,sha256=FAQI9EIHsokZBbGwvGU4vnjg1fHemxpYQE20UtCB1qo,25941
 reconcile/status.py,sha256=cY4IJFXemhxptRJqR4qaaOWqei9e4jgLXuVSGajMsjg,544
 reconcile/status_board.py,sha256=nA74_133jukxVShjPKJpkXOA3vggDTTEhYTegoXbN1M,8632
 reconcile/terraform_aws_route53.py,sha256=R8eZHlvP368nvtmLd_cMSK3RGxD7jso9qE7NP92iniU,9986
@@ -122,7 +122,7 @@ reconcile/vpc_peerings_validator.py,sha256=Kv22HJVlTW9l9GB2eXwjPWqdDbr_VuvQBNPtt
 reconcile/aus/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 reconcile/aus/advanced_upgrade_service.py,sha256=MPqcWpq1QeYzBsB8rtTlo102h_cR_q83oOYtWAncuAk,22391
 reconcile/aus/aus_label_source.py,sha256=qoP8Fgxuu1tCuhG6ixCWve7Ll-KD6a79E2uLAmC0ifw,4184
-reconcile/aus/base.py,sha256=RqFUwH2xiWFN1U6plp-UG77iFkK60b8YKODsD4YWWyc,49880
+reconcile/aus/base.py,sha256=89tNKGZAsfCiYivF-oU15nois91eP4b8tRRT45zaY9M,49886
 reconcile/aus/cluster_version_data.py,sha256=j4UyEBi5mQuvPq5Lo7a_L_0blxvH790wJV07uAiikFU,7126
 reconcile/aus/healthchecks.py,sha256=S8_KPn_zFiOo_wf5XlVmz-I3tUDYAim3EGSqiSPMvLQ,2707
 reconcile/aus/metrics.py,sha256=nKT4m2zGT-QOMR0c-z-npVNKWsNMubzdffpU_f9n4II,3927
@@ -437,7 +437,7 @@ reconcile/terraform_init/integration.py,sha256=xcFKTc_or3xB3kE_I3OECNkkgbwALIwwd
 reconcile/terraform_init/merge_request.py,sha256=3CYtgSd7Q9zjKg4wsDz437EPCRfGeZZ8fZ0Y-ChKXJY,1475
 reconcile/terraform_init/merge_request_manager.py,sha256=fMcT6hbdEF3nFATJpvr8BedvQHq_MzFkgVJSloBNwOQ,3101
 reconcile/test/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-reconcile/test/conftest.py,sha256=rQousYrxUz-EwAIbsYO6bIwR1B4CrOz9y_zaUVo2lfI,4466
+reconcile/test/conftest.py,sha256=0pO4UxFeBALKbL9gwemyap0VkbPR8n5TtZbf5c9pSv0,4303
 reconcile/test/fixtures.py,sha256=9SDWAUlSd1rCx7z3GhULHcpr-I6FyCsXxaFAZIqYQsQ,591
 reconcile/test/test_acs_notifiers.py,sha256=xf3WL6q6V7KQdTVSx6YI-pa4yzOX3mkvIJomgPUc3Mw,12746
 reconcile/test/test_acs_policies.py,sha256=8pwnXpAO-0OI-6oubjf_oPPlpZjVldeZfJJ9uhsNMWM,17579
@@ -455,7 +455,7 @@ reconcile/test/test_cli.py,sha256=qx_iBwh4Z-YkK3sbjK1wEziPTgn060EN-baf9DNvR3k,10
 reconcile/test/test_closedbox_endpoint_monitoring.py,sha256=isMHYwRWMFARU2nbJgbl69kD6H0eA86noCM4MPVI1fo,7151
 reconcile/test/test_dashdotdb_dora.py,sha256=MfHGAsX2eSQSvBVt9_1Sah3aQKNJBXA9Iu86X0NWD6c,7705
 reconcile/test/test_database_access_manager.py,sha256=-9fYo8wMNhbJUTK_bd7g_fS5zYsAlqQ0rBDDYBMZvZQ,19595
-reconcile/test/test_deadmanssnitch.py,sha256=qtn1zwWgIQYw5JULLPvDLaj0GWiecYnvky0HcuETjdo,9843
+reconcile/test/test_deadmanssnitch.py,sha256=YAf8wlZoEC60Ul7UA6Y6XqwnZ1yqf07J15ABqeLpqW4,9835
 reconcile/test/test_gabi_authorized_users.py,sha256=6XnV5Q9inxP81ktGMVKyWucjBTUj8Imy2L0HG3YHyUE,2496
 reconcile/test/test_gcr_mirror.py,sha256=A0y8auKZzr62-mGoxSQ__JnN0-ijZUltzjwR5miBgso,490
 reconcile/test/test_github_org.py,sha256=j3KeB4OnSln1gm2hidce49xdMru-j75NS3cM-AEgzZc,4511
@@ -473,7 +473,7 @@ reconcile/test/test_make.py,sha256=zTdjgq-3idFlec_0qJenk9wWw0QMLvSpJfPsptXmync,6
 reconcile/test/test_ocm_additional_routers.py,sha256=dtbpUnD5un6Q3VoLbuFRb_njmt5SSCnBzvSSBcO_Xxs,4248
 reconcile/test/test_ocm_clusters.py,sha256=aBzL3eW_g3bTP2wmKE1hr8-f33OOhBiKDxJ0fNxWGCQ,23888
 reconcile/test/test_ocm_clusters_manifest_updates.py,sha256=jFRVfc5jby1kI2x_gT6wcqPPgkav1et9wZH6JqQbNSY,3278
-reconcile/test/test_ocm_machine_pools.py,sha256=3qo6t2Jfr1Wee0NUacyLTDmatp0o7CUNpkVOpHiOiGk,29737
+reconcile/test/test_ocm_machine_pools.py,sha256=X4S5lksvljAgCMSW7fDGguc6JMtNQ0bO2WAoLC2AAJw,29737
 reconcile/test/test_ocm_update_recommended_version.py,sha256=iA4BVirTGVXlwcOyeR52IuNO81X_8NR6ZNd7ZFE7igs,4328
 reconcile/test/test_ocm_upgrade_scheduler_org_updater.py,sha256=V91g2XQMa2nvKwkLVWkiPwNL6pMQE16s4jO0oXJ6wdk,4330
 reconcile/test/test_openshift_base.py,sha256=YgTKcLmzmt9oR12s_022LAp9qr1R_CBOppYwoknspzE,33868
@@ -501,7 +501,7 @@ reconcile/test/test_secret_reader.py,sha256=kz7nzcPjvA08cytnvcA_PMA98AEyqJWsESkY
 reconcile/test/test_slack_base.py,sha256=gpbWOLNxMMX6fyAbs1JakhLTnwfedb3f7WpUae4tQZE,5060
 reconcile/test/test_slack_usergroups.py,sha256=UO-OzqbGMSpNsyddu2TbWOzSiVze6Bq95Ph1QIJqLWY,23990
 reconcile/test/test_sql_query.py,sha256=rC-lf1_isT9i2ZIV9W0hkUkLi2oBIjZMRMhk-6mV-34,11029
-reconcile/test/test_status_board.py,sha256=WdAq4pFoWWqcOcfgMzssZD3xfvT1QLrEHJqUARldtvA,7875
+reconcile/test/test_status_board.py,sha256=go3YSWo03OLIdK95SuiDJa1Nqk-eN_9QtS7dfmu9__8,7875
 reconcile/test/test_terraform_aws_route53.py,sha256=xHggb8K1P76OyCfFcogbkmyKle-NlUylcbDnuv3IqvY,771
 reconcile/test/test_terraform_cloudflare_dns.py,sha256=aQTXX8Vr4h9aWvJZTnpZEhMGYoBpT2d45ZxU_ECIQ6o,3425
 reconcile/test/test_terraform_cloudflare_resources.py,sha256=NK_uktyWihkQ3gMN4bCaKerpi43CXAVYGIKTfcz05rY,13550
@@ -513,7 +513,7 @@ reconcile/test/test_terraform_users.py,sha256=XOAfGvITCJPI1LTlISmHbA4ONMQMkxYUMT
 reconcile/test/test_terraform_vpc_peerings.py,sha256=ubcsKh0TrUIwuI1-W3ETIgzsFvzAyeoFmEJFC-IK6JY,20538
 reconcile/test/test_terraform_vpc_peerings_build_desired_state.py,sha256=DAfpb12I0PlqnuVUHK2vh4LH4d1OylT3H2GE_3TGZZI,47852
 reconcile/test/test_three_way_diff_strategy.py,sha256=2fjEqE2w4pIzKq18PRcADTSe01aGwsZfMGloU8xfNaE,3346
-reconcile/test/test_unleash.py,sha256=c1s_FRAZrAzzd3FbZrzHYjJzHELhoxPHBZnEzqsfMQg,6416
+reconcile/test/test_unleash.py,sha256=krPgOVmwTE6lb773040Ely9BPbNYOeOIY0_8BK72dgo,6690
 reconcile/test/test_utils_jinja2.py,sha256=TpzQlpFnLGzNEZp5WOh0o7AuBiGEktqO4MuwiiJW2YY,3895
 reconcile/test/test_vault_replication.py,sha256=wlc4jm9f8P641UvvxIFFFc5_unJysNkOVrKJscjhQr0,16867
 reconcile/test/test_vault_utils.py,sha256=vbJnc89XAuE07qbTuWxHM5o9F6R9SO5aHXA38fwxT7A,1122
@@ -597,7 +597,7 @@ reconcile/utils/binary.py,sha256=EsOGg82Y2QJh91SGJE0tYpBKqU0iaaagQVoYONBtQn8,235
 reconcile/utils/config.py,sha256=aId5zrPjM_84u_T4yTRE_Psu3zo5-5_JCR6_7Wgv5UQ,990
 reconcile/utils/constants.py,sha256=pOUd97bqZdsAu5RWJ8NUs9cwCY7K9y0eW9VVeJ4fZIU,138
 reconcile/utils/data_structures.py,sha256=VyKfnlNJTiRvZKNpfgIrjESQ2YgmEpWuPQXT14WA1vI,311
-reconcile/utils/deadmanssnitch_api.py,sha256=hkfbfbRAhzLpI39o6Du7FZKVtf4UVJ1OljOQNUkmODM,2478
+reconcile/utils/deadmanssnitch_api.py,sha256=OWwkqZxjLRNNfFrfZt-zJ4H1hm4OHg5EZ6lP55APOZc,2493
 reconcile/utils/defer.py,sha256=SniUsbgOEs9Pa8JkecLu0F94O63yQPByKXaElDYe0FI,377
 reconcile/utils/differ.py,sha256=kJmUp9ZffFPSUEviaAw3s9c92ErwRJeHaRexGPai7wA,7643
 reconcile/utils/disabled_integrations.py,sha256=avdDsFyl_LdTsrPVzlcIhWzT_V4C4MXw1ZC__aOtluE,1126
@@ -651,12 +651,12 @@ reconcile/utils/promtool.py,sha256=kT2rFZSBaRqW7SSHAuYzGZzQxM5Dzk8KW1NnEUYZU_s,2
 reconcile/utils/quay_api.py,sha256=EuOegpb-7ntEjkKLFwM2Oo4Nw7SyFtmyl3sQ9aXMtrM,8152
 reconcile/utils/raw_github_api.py,sha256=ZHC-SZuAyRe1zaMoOU7Krt1-zecDxENd9c_NzQYqK9g,2968
 reconcile/utils/repo_owners.py,sha256=j-pUjc9PuDzq7KpjNLpnhqfU8tUG4nj2WMhFp4ick7g,6629
-reconcile/utils/rest_api_base.py,sha256=uXLdXocNmRCxJsYFWOdUNLaTEu-dcxMLJg_CwRefETE,3970
+reconcile/utils/rest_api_base.py,sha256=X5o4idyRCDzwnF5xFwmjyoaHmM1tXSZnykTA54Z7D2Q,4006
 reconcile/utils/ruamel.py,sha256=FzL4_L0FnMOUZmgThrZSMJs5MTdXwiy-E9MZWfk8bh8,397
 reconcile/utils/secret_reader.py,sha256=2DeYAAQFjUULEKlLw3UDAUoND6gbqvCh9uKPtlc-0us,10403
 reconcile/utils/semver_helper.py,sha256=-WfPOMSA2v1h7hT3PwVf-Htg7wOsoKlQC1JdmDX2Ars,1268
 reconcile/utils/sharding.py,sha256=gkYf0lD3IUKQPEmdRJZ70mdDT1c9qWjbdP7evRsUis4,839
-reconcile/utils/slack_api.py,sha256=OPmzU6L9rJx2XXDlZkMlxLjOWu17yC-fVCoUItzQrXw,16295
+reconcile/utils/slack_api.py,sha256=C-VThgYRtrRWraq9ZE6hEf1bXrwzRDCDK0uRw3DP6ew,16425
 reconcile/utils/smtp_client.py,sha256=gJNbBQJpAt5PX4t_TaeNHsXM8vt50bFgndml6yK2b5o,2800
 reconcile/utils/sqs_gateway.py,sha256=gFl9DM4DmGnptuxTOe4lS3YTyE80eSAvK42ljS8h4dA,2287
 reconcile/utils/state.py,sha256=FK8NLT1xyumuXpYRm0Nk6pWpOE_U6-NovGn6zKCw8vw,16298
@@ -721,7 +721,7 @@ reconcile/utils/mr/ocm_upgrade_scheduler_org_updates.py,sha256=RzEKRT_BhvB2ud9py
 reconcile/utils/mr/user_maintenance.py,sha256=cHPBn8zrReWLHalyk-EFdkFJe9zjVjRoZhT4t2zZfGE,3956
 reconcile/utils/ocm/__init__.py,sha256=xv7CJp7K9LCQfa4gL_W0MMCOD1P4qOy8t5aZj1xXNUE,808
 reconcile/utils/ocm/addons.py,sha256=IHlqOO12TAdYwwU6Oedz3ussF1kELj9EI5GxPP6LKi8,7376
-reconcile/utils/ocm/base.py,sha256=sdcINGBy1FlotY0MZuVC--Yn3zcYDn_N33ownMD8SQE,14030
+reconcile/utils/ocm/base.py,sha256=KPS1CgiALlq7INdgTDpN7MmtZ6uQMSWcUDjeGHmp5Z4,14065
 reconcile/utils/ocm/cluster_groups.py,sha256=F8oqVqN_4QUnGL0K61zZhoYIzJeP57EcmZpwmoV0mr4,1751
 reconcile/utils/ocm/clusters.py,sha256=Nw9m-jgN3GHHCh6w9UOBbMV4rtS24_-Ep09jAWQ-_fE,7653
 reconcile/utils/ocm/identity_providers.py,sha256=dKed09N8iWmn39tI_MpwgVe47x23eLsknGbjMUxtwr4,2175
@@ -783,8 +783,8 @@ tools/test/test_app_interface_metrics_exporter.py,sha256=SX7qL3D1SIRKFo95FoQztvf
 tools/test/test_qontract_cli.py,sha256=w2l4BHB09k1d-BGJ1jBUNCqDv7zkqYrMHojQXg-21kQ,4155
 tools/test/test_sd_app_sre_alert_report.py,sha256=v363r9zM7__0kR5K6mvJoGFcM9BvE33fWAayrqkpojA,2116
 tools/test/test_sre_checkpoints.py,sha256=SKqPPTl9ua0RFdSSofnoQX-JZE6dFLO3LRhfQzqtfh8,2607
-qontract_reconcile-0.10.1rc757.dist-info/METADATA,sha256=0L4M3FIacdQTzZZs5uNpBMpcjoUWVgkQetpJ--aadfA,2382
-qontract_reconcile-0.10.1rc757.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
-qontract_reconcile-0.10.1rc757.dist-info/entry_points.txt,sha256=rIxI5zWtHNlfpDeq1a7pZXAPoqf7HG32KMTN3MeWK_8,429
-qontract_reconcile-0.10.1rc757.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
-qontract_reconcile-0.10.1rc757.dist-info/RECORD,,
+qontract_reconcile-0.10.1rc759.dist-info/METADATA,sha256=N17GmMBM1N_QQwB544Gd7bz5DTOnTnT4o284Cj2JVgI,2382
+qontract_reconcile-0.10.1rc759.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
+qontract_reconcile-0.10.1rc759.dist-info/entry_points.txt,sha256=rIxI5zWtHNlfpDeq1a7pZXAPoqf7HG32KMTN3MeWK_8,429
+qontract_reconcile-0.10.1rc759.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
+qontract_reconcile-0.10.1rc759.dist-info/RECORD,,

reconcile/aus/base.py

@@ -850,8 +850,8 @@ def is_gate_applicable_to_cluster(gate: OCMVersionGate, cluster: OCMCluster) ->
     # consider only gates after the clusters current minor version
     # OCM onls supports creating gate agreements for later minor versions than the
     # current cluster version
-    if not semver.match(
-        f"{cluster.minor_version()}.0", f"<{gate.version_raw_id_prefix}.0"
+    if not parse_semver(f"{cluster.minor_version()}.0").match(
+        f"<{gate.version_raw_id_prefix}.0"
     ):
         return False
 

reconcile/sql_query.py

@@ -15,7 +15,6 @@ from typing import (
 )
 
 import jinja2
-from ruamel import yaml
 
 from reconcile import (
     openshift_base,
@@ -34,6 +33,7 @@ from reconcile.utils.openshift_resource import (
     OpenshiftResource,
     ResourceInventory,
 )
+from reconcile.utils.ruamel import create_ruamel_instance
 from reconcile.utils.secret_reader import SecretReader
 from reconcile.utils.semver_helper import make_semver
 from reconcile.utils.smtp_client import (
@@ -591,6 +591,7 @@ def _build_openshift_resources(
     query_name = query["name"]
     common_resource_labels = _build_common_resource_labels(query)
     openshift_resources: list[OpenshiftResource] = []
+    yml = create_ruamel_instance()
     if pull_secret:
         labels = pull_secret["labels"] or {}
         labels.update(common_resource_labels)
@@ -651,7 +652,7 @@ def _build_openshift_resources(
     )
     openshift_resources.append(
         OpenshiftResource(
-            body=yaml.safe_load(job_yaml),
+            body=yml.load(job_yaml),
             integration=QONTRACT_INTEGRATION,
             integration_version=QONTRACT_INTEGRATION_VERSION,
         )

reconcile/test/conftest.py

@@ -12,10 +12,10 @@ from typing import (
 )
 from unittest.mock import create_autospec
 
-import httpretty as _httpretty
 import pytest
 from pydantic import BaseModel
 from pydantic.error_wrappers import ValidationError
+from pytest_httpserver import HTTPServer
 
 from reconcile.gql_definitions.fragments.vault_secret import VaultSecret
 from reconcile.test.fixtures import Fixtures
@@ -29,13 +29,6 @@ def patch_sleep(mocker):
     yield mocker.patch.object(time, "sleep")
 
 
-@pytest.fixture()
-def httpretty():
-    with _httpretty.enabled(allow_net_connect=False):
-        _httpretty.reset()
-        yield _httpretty
-
-
 @pytest.fixture
 def secret_reader(mocker) -> None:
     mock_secretreader = mocker.patch(
@@ -153,19 +146,18 @@ def gql_api_builder() -> Callable[[Optional[Mapping]], GqlApi]:
 
 
 @pytest.fixture
-def set_httpretty_responses_based_on_fixture(httpretty: _httpretty) -> Callable:
-    """Create httpretty responses based fixture files."""
+def set_httpserver_responses_based_on_fixture(httpserver: HTTPServer) -> Callable:
+    """Create httpserver responses based fixture files."""
 
-    def _(url: str, fx: Fixtures, paths: Iterable[str]) -> None:
+    def _(fx: Fixtures, paths: Iterable[str]) -> None:
         for path in paths:
             for method in ["get", "post", "put", "patch", "delete"]:
-                method_file = Path(fx.path(path)) / f"{method}.json"
+                method_file = Path(fx.path(path.lstrip("/"))) / f"{method}.json"
                 if method_file.exists():
-                    httpretty.register_uri(
-                        getattr(httpretty, method.upper()),
-                        f"{url}/{path}",
-                        body=method_file.read_text(),
-                        content_type="text/json",
+                    httpserver.expect_oneshot_request(
+                        path, method=method
+                    ).respond_with_data(
+                        method_file.read_text(), content_type="text/json"
                     )
 
     return _

reconcile/test/test_deadmanssnitch.py

@@ -20,7 +20,7 @@ from reconcile.utils.deadmanssnitch_api import (
 
 
 @pytest.fixture
-def deadmanssnitch_api() -> MockerFixture:
+def deadmanssnitch_api() -> MagicMock:
     return create_autospec(DeadMansSnitchApi)
 
 
@@ -55,7 +55,7 @@ def secret_reader(mocker: MockerFixture) -> MockerFixture:
 
 def test_get_current_state(
     secret_reader: MagicMock,
-    deadmanssnitch_api: MockerFixture,
+    deadmanssnitch_api: MagicMock,
     mocker: MockerFixture,
     deadmanssnitch_settings: DeadMansSnitchSettingsV1,
 ) -> None:

reconcile/test/test_ocm_machine_pools.py

@@ -32,7 +32,7 @@ from reconcile.ocm_machine_pools import (
 from reconcile.utils.ocm import OCM
 
 
-class TestPool(AbstractPool):
+class PoolStub(AbstractPool):
     created = False
     deleted = False
     updated = False
@@ -57,8 +57,8 @@ class TestPool(AbstractPool):
 
 
 @pytest.fixture
-def test_pool() -> TestPool:
-    return TestPool(
+def test_pool() -> PoolStub:
+    return PoolStub(
         id="pool1",
         replicas=2,
         labels=None,
@@ -133,7 +133,7 @@ def ocm_mock():
 
 
 def test_diff__has_diff_autoscale(cluster_machine_pool: ClusterMachinePoolV1):
-    pool = TestPool(id="pool1", cluster="cluster1", cluster_type=ClusterType.OSD)
+    pool = PoolStub(id="pool1", cluster="cluster1", cluster_type=ClusterType.OSD)
 
     assert cluster_machine_pool.autoscale is None
     assert not pool._has_diff_autoscale(cluster_machine_pool)

reconcile/test/test_status_board.py

@@ -18,7 +18,7 @@ from reconcile.status_board import (
 from reconcile.utils.ocm_base_client import OCMBaseClient
 
 
-class TestStatusBoard(AbstractStatusBoard):
+class StatusBoardStub(AbstractStatusBoard):
     created: Optional[bool] = False
     deleted: Optional[bool] = False
     summarized: Optional[bool] = False
@@ -99,21 +99,21 @@ def test_status_board_handler(mocker: MockerFixture) -> None:
     ocm = mocker.patch("reconcile.status_board.OCMBaseClient")
     h = StatusBoardHandler(
         action="create",
-        status_board_object=TestStatusBoard(name="foo", fullname="foo"),
+        status_board_object=StatusBoardStub(name="foo", fullname="foo"),
     )
 
     h.act(dry_run=False, ocm=ocm)
-    assert isinstance(h.status_board_object, TestStatusBoard)
+    assert isinstance(h.status_board_object, StatusBoardStub)
     assert h.status_board_object.created
     assert h.status_board_object.summarized
 
     h = StatusBoardHandler(
         action="delete",
-        status_board_object=TestStatusBoard(name="foo", fullname="foo"),
+        status_board_object=StatusBoardStub(name="foo", fullname="foo"),
     )
 
     h.act(dry_run=False, ocm=ocm)
-    assert isinstance(h.status_board_object, TestStatusBoard)
+    assert isinstance(h.status_board_object, StatusBoardStub)
     assert h.status_board_object.deleted
     assert h.status_board_object.summarized
 

reconcile/test/test_unleash.py

@@ -1,8 +1,8 @@
-import json
 import os
+from collections.abc import Callable
 
-import httpretty
 import pytest
+from pytest_httpserver import HTTPServer
 from UnleashClient.features import Feature
 
 import reconcile.utils.unleash
@@ -22,6 +22,75 @@ def reset_client():
     reconcile.utils.unleash.client = None
 
 
+def _setup_unleash_httpserver(features: dict, httpserver: HTTPServer) -> HTTPServer:
+    httpserver.expect_request("/client/features").respond_with_json(features)
+    httpserver.expect_request("/client/register", method="post").respond_with_data(
+        status=202
+    )
+    return httpserver
+
+
+@pytest.fixture
+def setup_unleash_disable_cluster_strategy(httpserver: HTTPServer):
+    def _(enabled: bool) -> HTTPServer:
+        features = {
+            "version": 2,
+            "features": [
+                {
+                    "strategies": [
+                        {
+                            "name": "disableCluster",
+                            "constraints": [],
+                            "parameters": {"cluster_name": "foo"},
+                        },
+                    ],
+                    "impressionData": False,
+                    "enabled": enabled,
+                    "name": "test-strategies",
+                    "description": "",
+                    "project": "default",
+                    "stale": False,
+                    "type": "release",
+                    "variants": [],
+                }
+            ],
+        }
+        return _setup_unleash_httpserver(features, httpserver)
+
+    return _
+
+
+@pytest.fixture
+def setup_unleash_enable_cluster_strategy(httpserver: HTTPServer):
+    def _(enabled: bool) -> HTTPServer:
+        features = {
+            "version": 2,
+            "features": [
+                {
+                    "strategies": [
+                        {
+                            "name": "enableCluster",
+                            "constraints": [],
+                            "parameters": {"cluster_name": "enabled-cluster"},
+                        },
+                    ],
+                    "impressionData": False,
+                    "enabled": enabled,
+                    "name": "test-strategies",
+                    "description": "",
+                    "project": "default",
+                    "stale": False,
+                    "type": "release",
+                    "variants": [],
+                }
+            ],
+        }
+
+        return _setup_unleash_httpserver(features, httpserver)
+
+    return _
+
+
 def test__get_unleash_api_client(mocker):
     mocked_unleash_client = mocker.patch(
         "reconcile.utils.unleash.UnleashClient",
@@ -108,42 +177,12 @@ def test_get_feature_toggles(mocker, monkeypatch):
     assert toggles["bar"] == "enabled"
 
 
-def setup_unleash_disable_cluster_strategy_httpretty(enabled: bool):
-    features = {
-        "version": 2,
-        "features": [
-            {
-                "strategies": [
-                    {
-                        "name": "disableCluster",
-                        "constraints": [],
-                        "parameters": {"cluster_name": "foo"},
-                    },
-                ],
-                "impressionData": False,
-                "enabled": enabled,
-                "name": "test-strategies",
-                "description": "",
-                "project": "default",
-                "stale": False,
-                "type": "release",
-                "variants": [],
-            }
-        ],
-    }
-
-    feature_param = (httpretty.GET, "http://unleash/api/client/features")
-    httpretty.register_uri(*feature_param, body=json.dumps(features), status=200)
-
-    register_param = (httpretty.POST, "http://unleash/api/client/register")
-    httpretty.register_uri(*register_param, status=202)
-
-
-@httpretty.activate(allow_net_connect=False)
-def test_get_feature_toggle_state_with_strategy(reset_client):
-    os.environ["UNLEASH_API_URL"] = "http://unleash/api"
+def test_get_feature_toggle_state_with_strategy(
+    reset_client: None, setup_unleash_disable_cluster_strategy: Callable
+):
+    httpserver = setup_unleash_disable_cluster_strategy(True)
+    os.environ["UNLEASH_API_URL"] = httpserver.url_for("/")
     os.environ["UNLEASH_CLIENT_ACCESS_TOKEN"] = "bar"
-    setup_unleash_disable_cluster_strategy_httpretty(True)
     assert not get_feature_toggle_state(
         "test-strategies", context={"cluster_name": "foo"}
     )
@@ -151,53 +190,24 @@ def test_get_feature_toggle_state_with_strategy(reset_client):
     _shutdown_client()
 
 
-@httpretty.activate(allow_net_connect=False)
-def test_get_feature_toggle_state_disabled_with_strategy(reset_client):
-    os.environ["UNLEASH_API_URL"] = "http://unleash/api"
+def test_get_feature_toggle_state_disabled_with_strategy(
+    reset_client: None, setup_unleash_disable_cluster_strategy: Callable
+):
+    httpserver = setup_unleash_disable_cluster_strategy(False)
+    os.environ["UNLEASH_API_URL"] = httpserver.url_for("/")
     os.environ["UNLEASH_CLIENT_ACCESS_TOKEN"] = "bar"
-    setup_unleash_disable_cluster_strategy_httpretty(False)
     assert not get_feature_toggle_state(
         "test-strategies", context={"cluster_name": "bar"}
     )
     _shutdown_client()
 
 
-def setup_unleash_enable_cluster_strategy_httpretty(enabled: bool):
-    features = {
-        "version": 2,
-        "features": [
-            {
-                "strategies": [
-                    {
-                        "name": "enableCluster",
-                        "constraints": [],
-                        "parameters": {"cluster_name": "enabled-cluster"},
-                    },
-                ],
-                "impressionData": False,
-                "enabled": enabled,
-                "name": "test-strategies",
-                "description": "",
-                "project": "default",
-                "stale": False,
-                "type": "release",
-                "variants": [],
-            }
-        ],
-    }
-
-    feature_param = (httpretty.GET, "http://unleash/api/client/features")
-    httpretty.register_uri(*feature_param, body=json.dumps(features), status=200)
-
-    register_param = (httpretty.POST, "http://unleash/api/client/register")
-    httpretty.register_uri(*register_param, status=202)
-
-
-@httpretty.activate(allow_net_connect=False)
-def test_get_feature_toggle_state_with_enable_cluster_strategy(reset_client):
-    os.environ["UNLEASH_API_URL"] = "http://unleash/api"
+def test_get_feature_toggle_state_with_enable_cluster_strategy(
+    reset_client: None, setup_unleash_enable_cluster_strategy: Callable
+):
+    httpserver = setup_unleash_enable_cluster_strategy(True)
+    os.environ["UNLEASH_API_URL"] = httpserver.url_for("/")
     os.environ["UNLEASH_CLIENT_ACCESS_TOKEN"] = "bar"
-    setup_unleash_enable_cluster_strategy_httpretty(True)
     assert get_feature_toggle_state(
         "test-strategies", context={"cluster_name": "enabled-cluster"}
     )

reconcile/utils/deadmanssnitch_api.py

@@ -49,10 +49,12 @@ class DeadMansSnitchApi:
         self.session.close()
 
     def get_snitches(self, tags: list[str]) -> list[Snitch]:
-        full_url = f"{self.url}?tags={','.join(tags)}"
         logging.debug("Getting snitches for tags:%s", tags)
         response = self.session.get(
-            url=full_url, auth=(self.token, ""), timeout=self.timeout
+            url=self.url,
+            params={"tags": ",".join(tags)},
+            auth=(self.token, ""),
+            timeout=self.timeout,
         )
         response.raise_for_status()
         snitches = [Snitch(**item) for item in response.json()]

reconcile/utils/ocm/base.py

@@ -8,13 +8,13 @@ from typing import (
     TypeVar,
 )
 
-import semver
 from pydantic import (
     BaseModel,
     Field,
 )
 
 from reconcile.utils.aws_helper import get_account_uid_from_arn, get_role_name_from_arn
+from reconcile.utils.semver_helper import parse_semver
 
 LabelSetTypeVar = TypeVar("LabelSetTypeVar", bound=BaseModel)
 ACTIVE_SUBSCRIPTION_STATES = {"Active", "Reserved"}
@@ -246,8 +246,8 @@ class OCMCluster(BaseModel):
     external_configuration: Optional[OCMExternalConfiguration]
 
     def minor_version(self) -> str:
-        version_info = semver.parse(self.version.raw_id)
-        return f"{version_info['major']}.{version_info['minor']}"
+        version_info = parse_semver(self.version.raw_id)
+        return f"{version_info.major}.{version_info.minor}"
 
     def available_upgrades(self) -> list[str]:
         return self.version.available_upgrades

reconcile/utils/rest_api_base.py

@@ -75,6 +75,7 @@ class ApiBase:
 
     def _get(self, url: str) -> dict[str, Any]:
         response = self.session.get(urljoin(self.host, url), timeout=self.read_timeout)
+        response.raise_for_status()
         return response.json()
 
     def _list(

reconcile/utils/slack_api.py

@@ -166,6 +166,7 @@ class SlackApi:
         api_config: Optional[SlackApiConfig] = None,
         init_usergroups: bool = True,
         channel: Optional[str] = None,
+        slack_url: Optional[str] = None,
         **chat_kwargs: Any,
     ) -> None:
         """
@@ -187,7 +188,11 @@ class SlackApi:
         else:
             self.config = SlackApiConfig()
 
-        self._sc = WebClient(token=token, timeout=self.config.timeout)
+        self._sc = WebClient(
+            token=token,
+            timeout=self.config.timeout,
+            base_url=slack_url or WebClient.BASE_URL,
+        )
         self._configure_client_retry()
 
         self._results: dict[str, Any] = {}