qontract-reconcile 0.10.1rc406__py3-none-any.whl → 0.10.1rc407__py3-none-any.whl

{qontract_reconcile-0.10.1rc406.dist-info → qontract_reconcile-0.10.1rc407.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: qontract-reconcile
-Version: 0.10.1rc406
+Version: 0.10.1rc407
 Summary: Collection of tools to reconcile services with their desired state as defined in the app-interface DB.
 Home-page: https://github.com/app-sre/qontract-reconcile
 Author: Red Hat App-SRE Team

{qontract_reconcile-0.10.1rc406.dist-info → qontract_reconcile-0.10.1rc407.dist-info}/RECORD

@@ -105,7 +105,7 @@ reconcile/status_board.py,sha256=xOKicOelyGv3h2sFJxa9FBj8HDroZyGhMaRWaNRGpQQ,810
 reconcile/template_tester.py,sha256=vZz8GM46waQUGd3OVnhW5OLTqctFMH_Hh1QXxT5hduM,2384
 reconcile/terraform_aws_route53.py,sha256=QJMlaYYwcw_N9TJu7VbgZfxrxxR8Wv62GuG05XVhSuE,10018
 reconcile/terraform_cloudflare_dns.py,sha256=auU4bzeLwd4S8D8oqpqJbrCUoEdELXrgi7vHOedjYFk,13332
-reconcile/terraform_cloudflare_resources.py,sha256=m4Xg3xmHa7XjbUEvAbg0a3BeRSnPLe-4CLUJPlQiTdc,15012
+reconcile/terraform_cloudflare_resources.py,sha256=EbQQaoDnZ7brvRCpbFtwlD7KLk2hDVNcjhrJGaAywEk,15023
 reconcile/terraform_cloudflare_users.py,sha256=DfeSnYC9YQgXX6AbJh85tQbJUDv1e2FjiGXgcpVQlPg,13964
 reconcile/terraform_repo.py,sha256=fIVjcxqhG6DR6H8QtQM1RpE9ukanjkjp8iH0tQRhEl8,13042
 reconcile/terraform_resources.py,sha256=WUM0ZEpf2jgcXjfjy3QSwrzpuD6zMN7cyOxetx88f9g,17167
@@ -404,8 +404,8 @@ reconcile/test/test_sql_query.py,sha256=rC-lf1_isT9i2ZIV9W0hkUkLi2oBIjZMRMhk-6mV
 reconcile/test/test_status_board.py,sha256=WdAq4pFoWWqcOcfgMzssZD3xfvT1QLrEHJqUARldtvA,7875
 reconcile/test/test_terraform_aws_route53.py,sha256=xHggb8K1P76OyCfFcogbkmyKle-NlUylcbDnuv3IqvY,771
 reconcile/test/test_terraform_cloudflare_dns.py,sha256=aQTXX8Vr4h9aWvJZTnpZEhMGYoBpT2d45ZxU_ECIQ6o,3425
-reconcile/test/test_terraform_cloudflare_resources.py,sha256=cWNE2UIhz19rLSWdpJG8xRwuEEYoIZWEkDZY7e2QN_g,3426
-reconcile/test/test_terraform_cloudflare_users.py,sha256=BEC4RCuuR6b3L-KR7cakEcOasPR7XJ7Mca0BnVbawvg,27480
+reconcile/test/test_terraform_cloudflare_resources.py,sha256=D-3yvANpQMW_hmxTthsUvRTuyguqCqLJoLaDX1THDks,9351
+reconcile/test/test_terraform_cloudflare_users.py,sha256=RAFtMMdqZha3jNnNNsqbNQQUDSqUzdoM63rCw7fs4Fo,27456
 reconcile/test/test_terraform_repo.py,sha256=E8Ilo9KCJh4kkUebGUoHZKxYQXh83X84U32CfUAsa28,11109
 reconcile/test/test_terraform_resources.py,sha256=1ny_QSFuRjV9jxZY8EeT4NVJ5dMv7cLrEEIx_cBpjgk,9075
 reconcile/test/test_terraform_tgw_attachments.py,sha256=GgDA8hlQ1ujh5g8PtzbYQbJGpNScEgZ8PvDbMFbn68g,35493
@@ -622,8 +622,8 @@ tools/test/test_app_interface_metrics_exporter.py,sha256=dmEcNwZltP1rd_4DbxIYakO
 tools/test/test_qontract_cli.py,sha256=awwTHEc2DWlykuqGIYM0WOBoSL0KRnOraCLk3C7izis,1401
 tools/test/test_sd_app_sre_alert_report.py,sha256=v363r9zM7__0kR5K6mvJoGFcM9BvE33fWAayrqkpojA,2116
 tools/test/test_sre_checkpoints.py,sha256=SKqPPTl9ua0RFdSSofnoQX-JZE6dFLO3LRhfQzqtfh8,2607
-qontract_reconcile-0.10.1rc406.dist-info/METADATA,sha256=jJdj2XbrMyThSCZevyBmdxx7QN7Y2eiyxU3rw8ZG3fc,2347
-qontract_reconcile-0.10.1rc406.dist-info/WHEEL,sha256=Xo9-1PvkuimrydujYJAjF7pCkriuXBpUPEjma1nZyJ0,92
-qontract_reconcile-0.10.1rc406.dist-info/entry_points.txt,sha256=rTjAv28I_CHLM8ID3OPqMI_suoQ9s7tFbim4aYjn9kk,376
-qontract_reconcile-0.10.1rc406.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
-qontract_reconcile-0.10.1rc406.dist-info/RECORD,,
+qontract_reconcile-0.10.1rc407.dist-info/METADATA,sha256=NcDwbiWeb552Q9aFx1UTWckd3qNwj3Mj0yuMKqzhCeo,2347
+qontract_reconcile-0.10.1rc407.dist-info/WHEEL,sha256=Xo9-1PvkuimrydujYJAjF7pCkriuXBpUPEjma1nZyJ0,92
+qontract_reconcile-0.10.1rc407.dist-info/entry_points.txt,sha256=rTjAv28I_CHLM8ID3OPqMI_suoQ9s7tFbim4aYjn9kk,376
+qontract_reconcile-0.10.1rc407.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
+qontract_reconcile-0.10.1rc407.dist-info/RECORD,,

reconcile/terraform_cloudflare_resources.py

@@ -342,7 +342,7 @@ def run(
     )
 
     if not cloudflare_namespaces:
-        logging.info("No namespaces were detected, nothing to do.")
+        logging.info("No cloudflare namespaces were detected, nothing to do.")
         sys.exit(ExitCodes.SUCCESS)
 
     # Build Cloudflare clients

reconcile/test/test_terraform_cloudflare_resources.py

@@ -1,11 +1,31 @@
+import logging
+
 import pytest
 
-from reconcile.gql_definitions.terraform_cloudflare_dns.terraform_cloudflare_zones import (
-    CloudflareDnsRecordV1,
+import reconcile.terraform_cloudflare_resources as integ
+from reconcile.gql_definitions.common.app_interface_vault_settings import (
+    AppInterfaceSettingsV1,
+)
+from reconcile.gql_definitions.fragments.vault_secret import VaultSecret
+from reconcile.gql_definitions.terraform_cloudflare_resources.terraform_cloudflare_accounts import (
+    AWSAccountV1,
+    AWSTerraformStateIntegrationsV1,
+)
+from reconcile.gql_definitions.terraform_cloudflare_resources.terraform_cloudflare_accounts import (
+    CloudflareAccountV1 as CFAccountV1,
+)
+from reconcile.gql_definitions.terraform_cloudflare_resources.terraform_cloudflare_accounts import (
+    DeletionApprovalV1,
+    TerraformCloudflareAccountsQueryData,
+    TerraformStateAWSV1,
 )
 from reconcile.gql_definitions.terraform_cloudflare_resources.terraform_cloudflare_resources import (
     CloudflareAccountV1,
+    CloudflareDnsRecordV1,
+    CloudflareZoneArgoV1,
+    CloudflareZoneCacheReserveV1,
     CloudflareZoneCertificateV1,
+    CloudflareZoneTieredCacheV1,
     CloudflareZoneWorkerV1,
     ClusterV1,
     NamespaceTerraformProviderResourceCloudflareV1,
@@ -60,16 +80,14 @@ def external_resources(provisioner_config):
                 plan="enterprise",
                 type="full",
                 settings='{"foo": "bar"}',
-                argo={
-                    "tiered_caching": True,
-                    "smart_routing": True,
-                },
-                tiered_cache={
-                    "cache_type": "smart",
-                },
-                cache_reserve={
-                    "enabled": True,
-                },
+                argo=CloudflareZoneArgoV1(
+                    tiered_caching=True,
+                    smart_routing=True,
+                ),
+                tiered_cache=CloudflareZoneTieredCacheV1(
+                    cache_type="smart",
+                ),
+                cache_reserve=CloudflareZoneCacheReserveV1(enabled=True),
                 records=[
                     CloudflareDnsRecordV1(
                         name="record",
@@ -78,8 +96,6 @@ def external_resources(provisioner_config):
                         value="example.com",
                         proxied=False,
                         identifier="record",
-                        priority=None,
-                        data=None,
                     ),
                 ],
                 workers=[
@@ -104,3 +120,154 @@ def external_resources(provisioner_config):
             ),
         ],
     )
+
+
+@pytest.fixture
+def mock_gql(mocker):
+    mocker.patch("reconcile.terraform_cloudflare_resources.gql", autospec=True)
+
+
+@pytest.fixture
+def mock_vault_secret(mocker):
+    mocked_vault_secret = mocker.patch(
+        "reconcile.terraform_cloudflare_resources.get_app_interface_vault_settings",
+        autospec=True,
+    )
+    mocked_vault_secret.return_value = AppInterfaceSettingsV1(vault=False)
+
+
+@pytest.fixture
+def mock_cloudflare_accounts(mocker):
+    mocked_cloudflare_accounts = mocker.patch(
+        "reconcile.terraform_cloudflare_resources.terraform_cloudflare_accounts",
+        autospec=True,
+    )
+    mocked_cloudflare_accounts.query.return_value = (
+        TerraformCloudflareAccountsQueryData(
+            accounts=[
+                CFAccountV1(
+                    name="cfaccount",
+                    providerVersion="0.33.x",
+                    apiCredentials=VaultSecret(
+                        path="somepath",
+                        field="key",
+                        version=1,
+                        format="??",
+                    ),
+                    terraformStateAccount=AWSAccountV1(
+                        name="awsaccoutn",
+                        automationToken=VaultSecret(
+                            path="someotherpath",
+                            field="token",
+                            version=1,
+                            format="",
+                        ),
+                        terraformState=TerraformStateAWSV1(
+                            provider="",
+                            bucket="",
+                            region="",
+                            integrations=[
+                                AWSTerraformStateIntegrationsV1(
+                                    integration="terraform-cloudflare-resources", key=""
+                                )
+                            ],
+                        ),
+                    ),
+                    deletionApprovals=[
+                        DeletionApprovalV1(expiration="", name="", type="")
+                    ],
+                    enforceTwofactor=False,
+                    type="?????",
+                )
+            ]
+        )
+    )
+
+
+@pytest.fixture
+def mock_cloudflare_resources(mocker, external_resources):
+    mocked_cloudflare_resources = mocker.patch(
+        "reconcile.terraform_cloudflare_resources.terraform_cloudflare_resources",
+        autospec=True,
+    )
+    mocked_cloudflare_resources.query.return_value = external_resources
+
+
+def test_cloudflare_accounts_validation(
+    mocker, caplog, mock_gql, mock_vault_secret, mock_cloudflare_resources
+):
+    # Mocking accounts with an empty response
+    mocked_cloudflare_accounts = mocker.patch(
+        "reconcile.terraform_cloudflare_resources.terraform_cloudflare_accounts",
+        autospec=True,
+    )
+    mocked_cloudflare_accounts.query.return_value = (
+        TerraformCloudflareAccountsQueryData(accounts=[])
+    )
+
+    with caplog.at_level(logging.INFO), pytest.raises(SystemExit) as sample:
+        integ.run(True, None, False, 10)
+    assert sample.value.code == 0
+    assert ["No Cloudflare accounts were detected, nothing to do."] == [
+        rec.message for rec in caplog.records
+    ]
+
+
+def test_namespace_validation(
+    mocker, caplog, mock_gql, mock_vault_secret, mock_cloudflare_accounts
+):
+    # Mocking resources without namespaces
+    mocked_resources = mocker.patch(
+        "reconcile.terraform_cloudflare_resources.terraform_cloudflare_resources",
+        autospec=True,
+    )
+
+    mocked_resources.query.return_value = TerraformCloudflareResourcesQueryData(
+        namespaces=[],
+    )
+
+    with caplog.at_level(logging.INFO), pytest.raises(SystemExit) as sample:
+        integ.run(True, None, False, 10)
+    assert sample.value.code == 0
+    assert ["No namespaces were detected, nothing to do."] == [
+        rec.message for rec in caplog.records
+    ]
+
+
+def test_cloudflare_namespace_validation(
+    mocker, caplog, mock_gql, mock_vault_secret, mock_cloudflare_accounts
+):
+    # Mocking resources without cloudflare namespaces
+    mocked_resources = mocker.patch(
+        "reconcile.terraform_cloudflare_resources.terraform_cloudflare_resources",
+        autospec=True,
+    )
+
+    mocked_resources.query.return_value = TerraformCloudflareResourcesQueryData(
+        namespaces=[
+            NamespaceV1(
+                name="namespace1",
+                clusterAdmin=True,
+                cluster=ClusterV1(
+                    name="test-cluster",
+                    serverUrl="http://localhost",
+                    insecureSkipTLSVerify=None,
+                    jumpHost=None,
+                    automationToken=None,
+                    clusterAdminAutomationToken=None,
+                    spec=None,
+                    internal=None,
+                    disable=None,
+                ),
+                managedExternalResources=True,
+                externalResources=[],
+            )
+        ],
+    )
+
+    with caplog.at_level(logging.INFO), pytest.raises(SystemExit) as sample:
+        integ.run(True, None, False, 10)
+    assert sample.value.code == 0
+    assert ["No cloudflare namespaces were detected, nothing to do."] == [
+        rec.message for rec in caplog.records
+    ]

reconcile/test/test_terraform_cloudflare_users.py

@@ -668,7 +668,6 @@ def test_external_spec_with_two_roles_from_different_account_one_user(
         ["redhat.com"],
     )
 
-    print(actual_users)
     expected_users = {
         "cloudflare-account-1": {
             "user1@redhat.com": CloudflareUser(