qontract-reconcile 0.10.1rc1202__py3-none-any.whl → 0.10.2.dev2__py3-none-any.whl

reconcile/test/test_checkpoint.py

@@ -1,178 +0,0 @@
-from http import HTTPStatus
-
-import pytest
-import requests
-
-import reconcile.checkpoint as sut
-
-
-@pytest.fixture
-def valid_app():
-    """How a valid application looks like."""
-    return {
-        "sopsUrl": "https://www.redhat.com/sops",
-        "architectureDocument": "https://www.redhat.com/arch",
-        "grafanaUrl": "https://www.redhat.com/graf",
-        "serviceOwners": [{"name": "A Name", "email": "aname@adomain.com"}],
-    }
-
-
-@pytest.fixture
-def valid_owner():
-    """How a valid owner looks like."""
-    return {"name": "A Name", "email": "a.name@redhat.com"}
-
-
-def invalid_owners():
-    """List the ways in which an owner can be invalid."""
-    return [
-        {"name": "A Name", "email": None},
-        {"name": "A Name", "email": "domainless"},
-        {"name": "A Name", "email": "@name.less"},
-        {"name": None, "email": "a-name@redhat.com"},
-    ]
-
-
-def test_valid_owner(valid_owner) -> None:
-    """Confirm that the valid owner is recognized as such."""
-    assert sut.valid_owners([valid_owner])
-
-
-@pytest.mark.parametrize("invalid_owner", invalid_owners())
-def test_invalid_owners(invalid_owner):
-    """Confirm that the invalid owners are flagged."""
-    assert not sut.valid_owners([invalid_owner])
-
-
-@pytest.mark.parametrize("invalid_owner", invalid_owners())
-def test_invalid_owners_remain_invalid(valid_owner, invalid_owner):
-    """Confirm rejection of invalid owners even mixed with good ones."""
-    assert not sut.valid_owners([valid_owner, invalid_owner])
-
-
-def test_url_makes_sense_ok(mocker):
-    """Good URLs are accepted."""
-    get = mocker.patch.object(requests, "get", autospec=True)
-    r = requests.Response()
-    r.status_code = HTTPStatus.OK
-    get.return_value = r
-
-    assert sut.url_makes_sense("https://www.redhat.com/existing")
-
-
-def test_url_makes_sense_unknown(mocker):
-    """Ensure rejection of URLs pointing to missing documents."""
-    get = mocker.patch.object(requests, "get", autospec=True)
-    r = requests.Response()
-    r.status_code = HTTPStatus.NOT_FOUND
-    get.return_value = r
-    assert not sut.url_makes_sense("https://www.redhat.com/nonexisting")
-
-
-def test_url_makes_sense_error():
-    """Ensure rejection of URLs returning ConnectionError."""
-    assert not sut.url_makes_sense("https://TODO")
-
-
-def test_url_makes_sense_empty():
-    """Ensure rejection of empty URLs."""
-    assert not sut.url_makes_sense("")
-
-
-def test_render_template():
-    """Confirm rendering of all placeholders in the ticket template."""
-    txt = sut.render_template(
-        sut.MISSING_DATA_TEMPLATE, "aname", "apath", "afield", "avalue"
-    )
-    assert "aname" in txt
-    assert "apath" in txt
-    assert "afield" in txt
-    assert "avalue" in txt
-
-
-def app_metadata():
-    """List some metadata for some fake apps.
-
-    Returns the app structure and whether we expect it to have a
-    ticket associated with it
-    """
-    return [
-        (
-            {
-                "name": "appname",
-                "sopsUrl": "https://www.somewhe.re",
-                "architectureDocument": "https://www.hereand.now",
-                "grafanaUrls": [],
-            },
-            False,
-        ),
-        # Missing field - should cut a ticket
-        (
-            {
-                "name": "appname",
-                "sopsUrl": "https://www.somewhe.re",
-                "grafanaUrls": [],
-            },
-            True,
-        ),
-        # Bad field - should cut a ticket
-        (
-            {
-                "name": "appname",
-                "architectureDocument": "",
-                "grafanaUrls": [],
-                "sopsUrl": "http://www.herea.nd",
-            },
-            True,
-        ),
-    ]
-
-
-@pytest.mark.parametrize("app,needs_ticket", app_metadata())
-def test_report_invalid_metadata(mocker, app, needs_ticket):
-    """Test that valid apps don't get tickets and that invalid apps do."""
-    # TODO: I'm pretty sure a fixture can help with this
-    jira = mocker.patch.object(sut, "JiraClient", autospec=True)
-    filer = mocker.patch.object(sut, "file_ticket", autospec=True)
-
-    valid = sut.VALIDATORS
-
-    sut.VALIDATORS = {
-        "sopsUrl": bool,
-        "architectureDocument": bool,
-        "grafanaUrls": lambda _: True,
-    }
-
-    sut.report_invalid_metadata(app, "/a/path", "jiraboard", {}, "TICKET-123")
-    if needs_ticket:
-        filer.assert_called_once_with(
-            jira=jira.return_value,
-            app_name=app["name"],
-            labels=sut.DEFAULT_CHECKPOINT_LABELS,
-            parent="TICKET-123",
-            field="architectureDocument",
-            bad_value=str(app.get("architectureDocument")),
-            app_path="/a/path",
-        )
-    else:
-        filer.assert_not_called()
-
-    sut.VALIDATORS = valid
-
-
-@pytest.mark.parametrize("app,needs_ticket", app_metadata())
-def test_report_invalid_metadata_dry_run(mocker, app, needs_ticket):
-    """Test the dry-run mode."""
-    renderer = mocker.patch.object(sut, "render_template", autospec=True)
-    valid = sut.VALIDATORS
-    sut.VALIDATORS = {
-        "sopsUrl": bool,
-        "architectureDocument": bool,
-        "grafanaUrls": lambda _: True,
-    }
-    sut.report_invalid_metadata(app, "/a/path", "jiraboard", {}, "TICKET-123", True)
-    if needs_ticket:
-        renderer.assert_called_once()
-    else:
-        renderer.assert_not_called()
-    sut.VALIDATORS = valid

reconcile/test/test_cli.py

@@ -1,41 +0,0 @@
-import pytest
-from click.testing import CliRunner
-
-import reconcile.cli as reconcile_cli
-
-
-def test_config_is_required():
-    runner = CliRunner()
-    result = runner.invoke(reconcile_cli.integration)
-    assert result.exit_code == 0
-
-
-def test_parse_image_tag_from_ref_valid():
-    t = ("env=main",)
-    expected = {"env": "main"}
-    result = reconcile_cli.parse_image_tag_from_ref(None, None, t)
-    assert result == expected
-
-
-def test_parse_image_tag_from_ref_invalid_1():
-    t = ("env=",)
-    with pytest.raises(SystemExit):
-        reconcile_cli.parse_image_tag_from_ref(None, None, t)
-
-
-def test_parse_image_tag_from_ref_invalid_2():
-    t = ("=main",)
-    with pytest.raises(SystemExit):
-        reconcile_cli.parse_image_tag_from_ref(None, None, t)
-
-
-def test_parse_image_tag_from_ref_invalid_3():
-    t = ("=",)
-    with pytest.raises(SystemExit):
-        reconcile_cli.parse_image_tag_from_ref(None, None, t)
-
-
-def test_parse_image_tag_from_ref_invalid_4():
-    t = ("env=main=test",)
-    with pytest.raises(SystemExit):
-        reconcile_cli.parse_image_tag_from_ref(None, None, t)

reconcile/test/test_closedbox_endpoint_monitoring.py

@@ -1,207 +0,0 @@
-from unittest.mock import ANY
-
-import pytest
-
-from reconcile.blackbox_exporter_endpoint_monitoring import (
-    PROVIDER as BLACKBOX_EXPORTER_PROVIDER,
-)
-from reconcile.blackbox_exporter_endpoint_monitoring import (
-    build_probe as blackbox_exporter_probe_builder,
-)
-from reconcile.closedbox_endpoint_monitoring_base import (
-    fill_desired_state,
-    get_endpoints,
-    parse_prober_url,
-    queries,
-)
-from reconcile.signalfx_endpoint_monitoring import PROVIDER as SIGNALFX_PROVIDER
-from reconcile.signalfx_endpoint_monitoring import build_probe as signalfx_probe_builder
-from reconcile.utils.openshift_resource import ResourceInventory
-
-from .fixtures import Fixtures
-
-fxt = Fixtures("closedbox_exporter_endpoint_monitoring")
-
-
-def get_endpoint_fixtures(path: str) -> dict:
-    return fxt.get_anymarkup(path)["appInterface"]["apps"]
-
-
-def test_invalid_endpoints(mocker):
-    query = mocker.patch.object(queries, "get_service_monitoring_endpoints")
-    query.return_value = get_endpoint_fixtures("test_invalid_endpoints.yaml")
-
-    endpoints = get_endpoints(BLACKBOX_EXPORTER_PROVIDER)
-    assert len(endpoints) == 0
-
-
-def test_blackbox_exporter_endpoint_loading(mocker):
-    ep_query = mocker.patch.object(queries, "get_service_monitoring_endpoints")
-    ep_query.return_value = get_endpoint_fixtures("test_endpoint.yaml")
-
-    endpoints = get_endpoints(BLACKBOX_EXPORTER_PROVIDER)
-    assert endpoints is not None
-    assert len(endpoints) == 1
-
-    provider = next(iter(endpoints.keys()))
-    assert provider.provider == BLACKBOX_EXPORTER_PROVIDER
-    provider_endpoints = endpoints.get(provider)
-    assert provider_endpoints is not None
-    assert len(provider_endpoints) == 1
-    assert len(provider_endpoints[0].monitoring) == 1
-
-
-def test_parse_prober_url():
-    assert parse_prober_url("http://host:1234/path") == {
-        "url": "host:1234",
-        "scheme": "http",
-        "path": "/path",
-    }
-
-    assert parse_prober_url("http://host") == {"url": "host", "scheme": "http"}
-
-
-def test_invalid_prober_url():
-    # scheme missing
-    with pytest.raises(ValueError):
-        parse_prober_url("host:1234/path")
-
-
-def test_blackbox_exporter_probe_building(mocker):
-    ep_query = mocker.patch.object(queries, "get_service_monitoring_endpoints")
-    ep_query.return_value = get_endpoint_fixtures("test_blackbox_probe_building.yaml")
-
-    endpoints = get_endpoints(BLACKBOX_EXPORTER_PROVIDER)
-    assert len(endpoints) == 1
-
-    provider = next(iter(endpoints.keys()))
-    provider_endpoints = endpoints.get(provider)
-    assert provider_endpoints is not None
-    probe_resource = blackbox_exporter_probe_builder(provider, provider_endpoints)
-    assert probe_resource is not None
-
-    # verify prober url decomposition
-    spec = probe_resource.body.get("spec")
-    assert spec.get("prober") == {
-        "url": "exporterhost:9115",
-        "scheme": "http",
-        "path": "/probe",
-    }
-
-    # verify labels
-    labels = spec["targets"]["staticConfig"]["labels"]
-    assert labels.get("environment") == "staging"
-
-    # verify timeout and interval
-    assert spec["scrapeTimeout"] == provider.timeout
-    assert spec["interval"] == provider.checkInterval
-
-    # verify targets
-    assert "https://test1.url" in spec["targets"]["staticConfig"]["static"]
-    assert "https://test2.url" in spec["targets"]["staticConfig"]["static"]
-
-
-def test_signalfx_probe_building(mocker):
-    ep_query = mocker.patch.object(queries, "get_service_monitoring_endpoints")
-    ep_query.return_value = get_endpoint_fixtures("test_signalfx_probe_building.yaml")
-
-    endpoints = get_endpoints(SIGNALFX_PROVIDER)
-    assert len(endpoints) == 1
-
-    provider = next(iter(endpoints.keys()))
-    provider_endpoints = endpoints.get(provider)
-    assert provider_endpoints is not None
-    probe_resource = signalfx_probe_builder(provider, provider_endpoints)
-    assert probe_resource is not None
-
-    # verify prober url decomposition
-    spec = probe_resource.body.get("spec")
-    assert spec.get("prober") == {
-        "url": "signalfxexporter:9091",
-        "scheme": "http",
-        "path": "/metrics/probe",
-    }
-
-    # verify labels
-    labels = spec["targets"]["staticConfig"]["labels"]
-    assert labels.get("environment") == "staging"
-
-    # verify timeout and interval
-    assert spec["scrapeTimeout"] == provider.timeout
-    assert spec["interval"] == provider.checkInterval
-
-    # verify targets
-    assert "test_1" in spec["targets"]["staticConfig"]["static"]
-    assert "test_2" in spec["targets"]["staticConfig"]["static"]
-
-    # verify relabeling
-    assert {
-        "action": "replace",
-        "regex": "^test_1$",
-        "replacement": "https://test1.url",
-        "sourceLabels": ["instance"],
-        "targetLabel": "instance",
-    } in spec["targets"]["staticConfig"]["relabelingConfigs"]
-    assert {
-        "action": "replace",
-        "regex": "^test_2$",
-        "replacement": "https://test2.url",
-        "sourceLabels": ["instance"],
-        "targetLabel": "instance",
-    } in spec["targets"]["staticConfig"]["relabelingConfigs"]
-
-
-def test_blackbox_exporter_filling_desired_state(mocker):
-    ep_query = mocker.patch.object(queries, "get_service_monitoring_endpoints")
-    ep_query.return_value = get_endpoint_fixtures("test_endpoint.yaml")
-    add_desired_mock = mocker.patch.object(ResourceInventory, "add_desired")
-
-    endpoints = get_endpoints(BLACKBOX_EXPORTER_PROVIDER)
-    provider = next(iter(endpoints.keys()))
-    probe = blackbox_exporter_probe_builder(provider, endpoints[provider])
-    assert probe is not None
-    fill_desired_state(provider, probe, ResourceInventory())
-
-    assert add_desired_mock.call_count == 1
-    add_desired_mock.assert_called_with(
-        cluster="app-sre-stage-01",
-        namespace="openshift-customer-monitoring",
-        resource_type="Probe",
-        name="blackbox-exporter-http-2xx",
-        value=ANY,
-    )
-
-
-def test_signalfx_filling_desired_state(mocker):
-    ep_query = mocker.patch.object(queries, "get_service_monitoring_endpoints")
-    ep_query.return_value = get_endpoint_fixtures("test_endpoint.yaml")
-    add_desired_mock = mocker.patch.object(ResourceInventory, "add_desired")
-
-    endpoints = get_endpoints(SIGNALFX_PROVIDER)
-    provider = next(iter(endpoints.keys()))
-    probe = signalfx_probe_builder(provider, endpoints[provider])
-    assert probe is not None
-    fill_desired_state(provider, probe, ResourceInventory())
-
-    assert add_desired_mock.call_count == 1
-    add_desired_mock.assert_called_with(
-        cluster="app-sre-stage-01",
-        namespace="openshift-customer-monitoring",
-        resource_type="Probe",
-        name="signalfx-exporter-http-2xx",
-        value=ANY,
-    )
-
-
-def test_loading_multiple_providers_per_endpoint(mocker):
-    ep_query = mocker.patch.object(queries, "get_service_monitoring_endpoints")
-    ep_query.return_value = get_endpoint_fixtures(
-        "test_multiple_providers_per_endpoint.yaml"
-    )
-    endpoints = get_endpoints(BLACKBOX_EXPORTER_PROVIDER)
-
-    assert len(endpoints) == 2
-
-    for provider, eps in endpoints.items():
-        assert provider.provider == BLACKBOX_EXPORTER_PROVIDER
-        assert len(eps) == 2

reconcile/test/test_dashdotdb_dora.py

@@ -1,245 +0,0 @@
-from datetime import datetime
-from unittest.mock import MagicMock
-
-import yaml
-from pytest_mock import MockerFixture
-
-from reconcile.dashdotdb_dora import (
-    AppEnv,
-    Commit,
-    DashdotdbDORA,
-    Deployment,
-    RepoChanges,
-    SaasTarget,
-)
-
-
-def test_get_repo_ref_for_sha(mocker: MockerFixture):
-    mocker.patch("reconcile.dashdotdb_dora.DashdotdbDORA.__init__").return_value = None
-    d = DashdotdbDORA(False, "1", 1)
-
-    # mock gl_app_interface_get_file
-    d.gl_app_interface_get_file = MagicMock(
-        return_value=yaml.safe_dump({
-            "resourceTemplates": [
-                {
-                    "name": "rt0",
-                    "url": "url0",
-                    "ref": "ref0",
-                    "targets": [
-                        {"namespace": {"$ref": "ns0"}, "ref": "ref0"},
-                        {"namespace": {"$ref": "ns3"}, "ref": "ref3"},
-                    ],
-                },
-                {
-                    "name": "rt1",
-                    "url": "url1",
-                    "ref": "ref1",
-                    "targets": [
-                        {"namespace": {"$ref": "ns0"}, "ref": "ref0"},
-                        {"namespace": {"$ref": "ns1"}, "ref": "ref1"},
-                    ],
-                },
-            ]
-        }).encode("utf-8")
-    )
-
-    saastarget = SaasTarget("app1", "env1", "/path1", "rt1", "ns1", "pipeline1")
-    info = d.get_repo_ref_for_sha(saastarget, "sha")
-
-    assert info == ("url1", "ref1")
-
-
-def test_get_repo_ref_for_sha_none(mocker: MockerFixture):
-    mocker.patch("reconcile.dashdotdb_dora.DashdotdbDORA.__init__").return_value = None
-    d = DashdotdbDORA(False, "1", 1)
-
-    # mock gl_app_interface_get_file
-    d.gl_app_interface_get_file = MagicMock(
-        return_value=yaml.safe_dump({
-            "resourceTemplates": [
-                {
-                    "name": "rt10",
-                    "url": "url0",
-                    "ref": "ref0",
-                    "targets": [
-                        {"namespace": {"$ref": "ns0"}, "ref": "ref0"},
-                        {"namespace": {"$ref": "ns3"}, "ref": "ref3"},
-                    ],
-                },
-                {
-                    "name": "rt11",
-                    "url": "url1",
-                    "ref": "ref1",
-                    "targets": [
-                        {"namespace": {"$ref": "ns0"}, "ref": "ref0"},
-                        {"namespace": {"$ref": "ns1"}, "ref": "ref1"},
-                    ],
-                },
-            ]
-        }).encode("utf-8")
-    )
-
-    saastarget = SaasTarget("app1", "env1", "/path1", "rt1", "ns1", "pipeline1")
-    info = d.get_repo_ref_for_sha(saastarget, "sha")
-
-    assert info == (None, None)
-
-
-def test_compare_gh(mocker: MockerFixture):
-    mocker.patch("reconcile.dashdotdb_dora.DashdotdbDORA.__init__").return_value = None
-    d = DashdotdbDORA(False, "1", 1)
-    ghapi_mock = MagicMock()
-
-    def gl_commit_mock(sha, date):
-        obj = MagicMock()
-        obj.sha = sha
-        obj.commit.committer.date = date
-        return obj
-
-    ghapi_mock.compare.return_value = [
-        gl_commit_mock(
-            "8cfb8408f614e1d0179d75af793f3fddf42d054a", datetime(2023, 9, 1, 0, 0, 0)
-        ),
-        gl_commit_mock(
-            "81677e1bc71324c9fa5c747b494add5a5af5e653", datetime(2023, 9, 2, 0, 0, 0)
-        ),
-        gl_commit_mock(
-            "566f37f8e9985d775e619cc959b806f5a254a380", datetime(2023, 9, 3, 0, 0, 0)
-        ),
-        gl_commit_mock(
-            "adab91701311fec1b0f5405adddaf68f886bba2c", datetime(2023, 9, 4, 0, 0, 0)
-        ),
-    ]
-
-    d._gh_apis = {"my/repo": ghapi_mock}
-
-    repo = "https://github.com/my/repo"
-
-    repo_changes = RepoChanges(
-        repo,
-        "e000dafd2e7bf34be41e7b3a5cb529ce7fbde257",
-        "adab91701311fec1b0f5405adddaf68f886bba2c",
-    )
-    rc, commits = d.compare(repo_changes)
-    assert rc == repo_changes
-    assert commits == [
-        Commit(
-            repo,
-            "8cfb8408f614e1d0179d75af793f3fddf42d054a",
-            datetime(2023, 9, 1, 0, 0, 0),
-        ),
-        Commit(
-            repo,
-            "81677e1bc71324c9fa5c747b494add5a5af5e653",
-            datetime(2023, 9, 2, 0, 0, 0),
-        ),
-        Commit(
-            repo,
-            "566f37f8e9985d775e619cc959b806f5a254a380",
-            datetime(2023, 9, 3, 0, 0, 0),
-        ),
-        Commit(
-            repo,
-            "adab91701311fec1b0f5405adddaf68f886bba2c",
-            datetime(2023, 9, 4, 0, 0, 0),
-        ),
-    ]
-
-
-def test_compare_gl(mocker: MockerFixture):
-    mocker.patch("reconcile.dashdotdb_dora.DashdotdbDORA.__init__").return_value = None
-    d = DashdotdbDORA(False, "1", 1)
-    d.gl = MagicMock()
-    d.gl.server = "https://gitlab.com"
-    d.gl.repository_compare.return_value = [
-        {
-            "id": "8cfb8408f614e1d0179d75af793f3fddf42d054a",
-            "committed_date": "2023-09-01T00:00:00",
-        },
-        {
-            "id": "81677e1bc71324c9fa5c747b494add5a5af5e653",
-            "committed_date": "2023-09-02T00:00:00",
-        },
-        {
-            "id": "566f37f8e9985d775e619cc959b806f5a254a380",
-            "committed_date": "2023-09-03T00:00:00",
-        },
-        {
-            "id": "adab91701311fec1b0f5405adddaf68f886bba2c",
-            "committed_date": "2023-09-04T00:00:00",
-        },
-    ]
-    repo = "https://gitlab.com/my/repo"
-
-    repo_changes = RepoChanges(
-        repo,
-        "e000dafd2e7bf34be41e7b3a5cb529ce7fbde257",
-        "adab91701311fec1b0f5405adddaf68f886bba2c",
-    )
-    rc, commits = d.compare(repo_changes)
-    assert rc == repo_changes
-    assert commits == [
-        Commit(
-            repo,
-            "8cfb8408f614e1d0179d75af793f3fddf42d054a",
-            datetime(2023, 9, 1, 0, 0, 0),
-        ),
-        Commit(
-            repo,
-            "81677e1bc71324c9fa5c747b494add5a5af5e653",
-            datetime(2023, 9, 2, 0, 0, 0),
-        ),
-        Commit(
-            repo,
-            "566f37f8e9985d775e619cc959b806f5a254a380",
-            datetime(2023, 9, 3, 0, 0, 0),
-        ),
-        Commit(
-            repo,
-            "adab91701311fec1b0f5405adddaf68f886bba2c",
-            datetime(2023, 9, 4, 0, 0, 0),
-        ),
-    ]
-
-
-def test_get_latest_with_default(mocker: MockerFixture):
-    mocker.patch("reconcile.dashdotdb_dora.DashdotdbDORA.__init__").return_value = None
-    d = DashdotdbDORA(False, "1", 1)
-    d.dashdotdb_url = "http://localhost"
-
-    date = datetime(2023, 9, 3, 0, 0, 0)
-    appenv = AppEnv("app1", "env1")
-
-    response = MagicMock()
-    response.status_code = 200
-    response.json.return_value = {"finish_timestamp": date.isoformat()}
-
-    d._do_get = MagicMock(return_value=response)  # type: ignore[method-assign]
-
-    latest = d.get_latest_with_default(date, appenv)
-    assert latest == (
-        AppEnv(app_name="app1", env_name="env1"),
-        datetime(2023, 9, 3, 0, 0),
-    )
-
-
-def test_get_repo_changes(mocker: MockerFixture):
-    mocker.patch("reconcile.dashdotdb_dora.DashdotdbDORA.__init__").return_value = None
-    d = DashdotdbDORA(False, "1", 1)
-
-    saastarget = SaasTarget("app1", "env1", "/path1", "rt1", "ns1", "pipeline1")
-    date = datetime(2023, 9, 3, 0, 0)
-    deployment = Deployment("trigger1", date)
-    saastarget_deployment = (saastarget, deployment)
-
-    d.get_repo_ref_for_sha = MagicMock(  # type: ignore[method-assign]
-        side_effect=[("repo1", "commitA"), ("repo1", "commitB")]
-    )
-
-    exp_saas_target, exp_deployment, repo_changes = d.get_repo_changes(
-        saastarget_deployment
-    )
-    assert exp_saas_target == saastarget
-    assert exp_deployment == deployment
-    assert repo_changes == RepoChanges("repo1", "commitA", "commitB")