qontract-reconcile 0.10.1rc1202__py3-none-any.whl → 0.10.2.dev1__py3-none-any.whl

reconcile/test/test_openshift_tekton_resources.py

@@ -1,265 +0,0 @@
-# Setting ignore[misc] for setters on TstData:
-# see https://github.com/python/mypy/issues/9160
-# Made this a complete ignore because there are even more errors here that need
-# to be addressed, but it was blocking other changes.
-# type: ignore
-
-from copy import deepcopy
-from typing import Any
-from unittest.mock import (
-    create_autospec,
-    patch,
-)
-
-import pytest
-
-from reconcile import openshift_tekton_resources as otr
-from reconcile.queries import PIPELINES_PROVIDERS_QUERY
-from reconcile.utils import gql
-
-from .fixtures import Fixtures
-
-MODULE = "reconcile.openshift_tekton_resources"
-
-
-class TstUnsupportedGqlQueryError(Exception):
-    pass
-
-
-class TstData:
-    """Class to add data to tests in setUp. It will be used by mocks"""
-
-    def __init__(self):
-        self._providers = []
-        self._saas_files = []
-
-    @property
-    def providers(self) -> list[dict[str, Any]]:
-        return self._providers
-
-    @property
-    def saas_files(self) -> list[dict[str, Any]]:
-        return self._saas_files
-
-    @providers.setter
-    def providers(self, providers: list[dict[str, Any]]) -> None:
-        if not isinstance(providers, list):
-            raise TypeError(f"Expecting list, have {type(providers)}")
-        self._providers = providers
-
-    @saas_files.setter
-    def saas_files(self, saas_files: list[dict[str, Any]]) -> None:
-        if not isinstance(saas_files, list):
-            raise TypeError(f"Expecting list, have {type(saas_files)}")
-        self._saas_files = saas_files
-
-
-# This was originally written in unittest, hence the use of xunit-style
-# setup/teardown methods instead of pytest fixtures.
-class TestOpenshiftTektonResources:
-    @staticmethod
-    def _test_deploy_resources_in_task(
-        desired_resources, task_name, deploy_resources
-    ) -> None:
-        """Helper method to test if deploy resources have been properly set"""
-        for dr in desired_resources:
-            if dr["name"] == task_name:
-                task = dr["value"].body
-                for step in task["spec"]["steps"]:
-                    if step["name"] == otr.DEFAULT_DEPLOY_RESOURCES_STEP_NAME:
-                        assert step["computeResources"] == deploy_resources
-                break
-
-    def mock_gql_get_resource(self, path: str) -> dict[str, str]:
-        """Mock for GqlApi.get_resources using fixtures"""
-        content = self.fxt.get(path)
-        return {
-            "path": path,
-            "content": content,
-            "sha256sum": "",
-        }  # we do not need it for these tests
-
-    def mock_gql_query(self, query: str) -> dict[str, Any]:
-        """Mock for GqlApi.query using test_data set in setUp"""
-        if query == otr.SAAS_FILES_QUERY:
-            return {"saas_files": self.test_data.saas_files}
-        if query == PIPELINES_PROVIDERS_QUERY:
-            return {"pipelines_providers": self.test_data.providers}
-        raise TstUnsupportedGqlQueryError("Unsupported query")
-
-    def setup_method(self) -> None:
-        self.test_data = TstData()
-
-        self.fxt = Fixtures("openshift_tekton_resources")
-
-        # Common fixtures
-        self.saas1 = self.fxt.get_json("saas1.json")
-        self.saas2 = self.fxt.get_json("saas2.json")
-        self.saas2_wr = self.fxt.get_json("saas2-with-resources.json")
-        self.provider1 = self.fxt.get_json("provider1.json")
-        self.provider2_wr = self.fxt.get_json("provider2-with-resources.json")
-
-        # Patcher for GqlApi methods
-        self.gql_patcher = patch.object(gql, "get_api", autospec=True)
-        self.gql = self.gql_patcher.start()
-        gqlapi_mock = create_autospec(gql.GqlApi)
-        self.gql.return_value = gqlapi_mock
-        gqlapi_mock.query.side_effect = self.mock_gql_query
-        gqlapi_mock.get_resource.side_effect = self.mock_gql_get_resource
-
-    def teardown_method(self) -> None:
-        """cleanup patches created in self.setUp"""
-        self.gql_patcher.stop()
-
-    def test_get_one_saas_file(self) -> None:
-        self.test_data.saas_files = [self.saas1, self.saas2]
-        saas_files = otr.fetch_saas_files(self.saas1["name"])
-        assert saas_files == [self.saas1]
-
-    def test_fetch_tkn_providers(self) -> None:
-        self.test_data.saas_files = [self.saas1, self.saas2]
-        self.test_data.providers = [self.provider1, self.provider2_wr]
-
-        tkn_providers = otr.fetch_tkn_providers(None)
-        keys_expected = {self.provider1["name"], self.provider2_wr["name"]}
-        assert tkn_providers.keys() == keys_expected
-
-    def test_duplicate_providers(self) -> None:
-        self.test_data.saas_files = [self.saas1]
-        provider1_duplicate = deepcopy(self.provider1)
-        self.test_data.providers = [self.provider1, provider1_duplicate]
-        msg = r"There are duplicates in tekton providers names: provider1"
-        with pytest.raises(otr.OpenshiftTektonResourcesBadConfigError, match=msg):
-            otr.fetch_tkn_providers(None)
-
-    def test_fetch_desired_resources(self) -> None:
-        self.test_data.saas_files = [self.saas1, self.saas2, self.saas2_wr]
-        self.test_data.providers = [self.provider1, self.provider2_wr]
-
-        desired_resources = otr.fetch_desired_resources(otr.fetch_tkn_providers(None))
-
-        # we have one task per namespace and a pipeline + task per saas file
-        assert len(desired_resources) == 8
-
-    def test_fetch_desired_resources_names(self) -> None:
-        self.test_data.saas_files = [self.saas1]
-        self.test_data.providers = [self.provider1]
-        desired_resources = otr.fetch_desired_resources(otr.fetch_tkn_providers(None))
-
-        expected_task_names = {
-            "o-push-gateway-openshift-saas-deploy-task-status-metric",
-            "o-openshift-saas-deploy-saas1",
-        }
-        expected_pipeline_name = "o-saas-deploy-saas1"
-
-        task_names = set()
-        for dr in desired_resources:
-            body = dr["value"].body
-            if body["kind"] == "Task":
-                task_names.add(body["metadata"]["name"])
-            else:
-                pipeline_name = body["metadata"]["name"]
-
-        assert task_names == expected_task_names
-        assert pipeline_name == expected_pipeline_name
-
-    def test_set_deploy_resources_default(self) -> None:
-        self.test_data.saas_files = [self.saas1]
-        self.test_data.providers = [self.provider1]
-        desired_resources = otr.fetch_desired_resources(otr.fetch_tkn_providers(None))
-
-        # we need to locate the onePerSaasFile task in the desired resources
-        # we could be very strict and find the onePerSaasFile task in
-        # self.provider1 or just use the actual structure of the fixtures
-        task_name = otr.build_one_per_saas_file_tkn_task_name(
-            template_name=self.provider1["taskTemplates"][0]["name"],
-            saas_file_name=self.saas1["name"],
-        )
-        self._test_deploy_resources_in_task(
-            desired_resources, task_name, otr.DEFAULT_DEPLOY_RESOURCES
-        )
-
-    def test_set_deploy_resources_from_provider(self) -> None:
-        self.test_data.saas_files = [self.saas2]
-        self.test_data.providers = [self.provider2_wr]
-        desired_resources = otr.fetch_desired_resources(otr.fetch_tkn_providers(None))
-
-        task_name = otr.build_one_per_saas_file_tkn_task_name(
-            template_name=self.provider2_wr["taskTemplates"][0]["name"],
-            saas_file_name=self.saas2["name"],
-        )
-        self._test_deploy_resources_in_task(
-            desired_resources, task_name, self.provider2_wr["deployResources"]
-        )
-
-    def test_set_deploy_resources_from_saas_file(self) -> None:
-        self.test_data.saas_files = [self.saas2_wr]
-        self.test_data.providers = [self.provider2_wr]
-        desired_resources = otr.fetch_desired_resources(otr.fetch_tkn_providers(None))
-
-        task_name = otr.build_one_per_saas_file_tkn_task_name(
-            template_name=self.provider2_wr["taskTemplates"][0]["name"],
-            saas_file_name=self.saas2["name"],
-        )
-        self._test_deploy_resources_in_task(
-            desired_resources, task_name, self.saas2_wr["deployResources"]
-        )
-
-    def test_task_templates_name_duplicates(self) -> None:
-        self.provider4_wtd = self.fxt.get_json("provider4-with-task-duplicates.json")
-        self.saas4 = self.fxt.get_json("saas4.json")
-        self.test_data.saas_files = [self.saas4]
-        self.test_data.providers = [self.provider4_wtd]
-
-        msg = (
-            r"There are duplicates in task templates names in tekton "
-            r"provider provider4-with-task-duplicates"
-        )
-        with pytest.raises(otr.OpenshiftTektonResourcesBadConfigError, match=msg):
-            otr.fetch_desired_resources(otr.fetch_tkn_providers(None))
-
-    def test_task_templates_unknown_task(self) -> None:
-        self.provider5_wut = self.fxt.get_json("provider5-with-unknown-task.json")
-        self.saas5 = self.fxt.get_json("saas5.json")
-        self.test_data.saas_files = [self.saas5]
-        self.test_data.providers = [self.provider5_wut]
-
-        msg = r"Unknown task this-is-an-unknown-task in pipeline template saas-deploy"
-        with pytest.raises(otr.OpenshiftTektonResourcesBadConfigError, match=msg):
-            otr.fetch_desired_resources(otr.fetch_tkn_providers(None))
-
-    @patch(f"{MODULE}.DEFAULT_DEPLOY_RESOURCES_STEP_NAME", "unknown-step")
-    def test_task_templates_unknown_deploy_resources_step(self) -> None:
-        self.test_data.saas_files = [self.saas1]
-        self.test_data.providers = [self.provider1]
-        msg = (
-            r"Cannot find a step named unknown-step to set resources in "
-            r"task template openshift-saas-deploy"
-        )
-        with pytest.raises(otr.OpenshiftTektonResourcesBadConfigError, match=msg):
-            otr.fetch_desired_resources(otr.fetch_tkn_providers(None))
-
-    @patch(f"{MODULE}.RESOURCE_MAX_LENGTH", 10)
-    def test_task_templates_resource_too_long(self) -> None:
-        self.test_data.saas_files = [self.saas1]
-        self.test_data.providers = [self.provider1]
-        msg = (
-            r"Resource name o-openshift-saas-deploy-saas1 is longer than 10 characters"
-        )
-        with pytest.raises(otr.OpenshiftTektonResourcesNameTooLongError, match=msg):
-            otr.fetch_desired_resources(otr.fetch_tkn_providers(None))
-
-    # This test describes a situation that should not take place in current app-interface since
-    # pipeline names are limited to 15 characters. But just in case, the code protects us from
-    # this situation to happen, hence the test.
-    def test_pipeline_templates_resource_too_long(self) -> None:
-        self.provider6_tlpn = self.fxt.get_json("provider6-too-long-pipeline-name.yaml")
-        self.saas6_39cn = self.fxt.get_json("saas6-39-chars-name.yaml")
-        self.test_data.saas_files = [self.saas6_39cn]
-        self.test_data.providers = [self.provider6_tlpn]
-        msg = (
-            r"Pipeline name o-saas-deploy-too-long-name-this-is-a-saas-file-with-a-39-char-name "
-            r"is longer than 56 characters"
-        )
-        with pytest.raises(otr.OpenshiftTektonResourcesNameTooLongError, match=msg):
-            otr.fetch_desired_resources(otr.fetch_tkn_providers(None))

reconcile/test/test_openshift_upgrade_watcher.py

@@ -1,223 +0,0 @@
-from datetime import (
-    datetime,
-    timedelta,
-)
-
-import pytest
-
-from reconcile import openshift_upgrade_watcher as ouw
-from reconcile.gql_definitions.common.clusters import ClusterV1
-from reconcile.test.fixtures import Fixtures
-from reconcile.utils.models import data_default_none
-
-fxt = Fixtures("openshift_upgrade_watcher")
-
-
-def load_cluster(path: str) -> ClusterV1:
-    content = fxt.get_anymarkup(path)
-    return ClusterV1(**data_default_none(ClusterV1, content))
-
-
-@pytest.fixture
-def state(mocker):
-    return mocker.patch("reconcile.utils.state.State", autospec=True).return_value
-
-
-@pytest.fixture
-def slack(mocker):
-    return mocker.patch(
-        "reconcile.utils.slack_api.SlackApi", autospec=True
-    ).return_value
-
-
-cluster_name = "cluster1"
-upgrade_at = datetime(2020, 6, 1, 0, 0, 0)
-old_version = "4.5.1"
-upgrade_version = "4.5.2"
-
-
-@pytest.fixture
-def ouw_oc_map(mocker):
-    map = mocker.patch("reconcile.utils.oc_map.OCMap", autospec=True).return_value
-    map.clusters.return_value = [cluster_name]
-    oc = mocker.patch("reconcile.utils.oc.OCNative", autospec=True)
-    oc.get.return_value = {"items": []}
-    map.get.return_value = oc
-    return map
-
-
-@pytest.fixture
-def ouw_ocm_map(mocker):
-    return mocker.patch("reconcile.utils.ocm.OCMMap", autospec=True)
-
-
-@pytest.fixture
-def upgrade_config():
-    return {
-        "items": [
-            {
-                "spec": {
-                    "upgradeAt": upgrade_at.strftime("%Y-%m-%dT%H:%M:%SZ"),
-                    "desired": {"version": upgrade_version},
-                }
-            }
-        ]
-    }
-
-
-@pytest.fixture
-def dt(mocker):
-    return mocker.patch(
-        "reconcile.openshift_upgrade_watcher.datetime",
-        mocker.Mock(datetime, wraps=datetime),
-    )
-
-
-def test_new_upgrade_pending(
-    mocker, state, slack, ouw_oc_map, ouw_ocm_map, upgrade_config, dt
-):
-    """There is an UpgradeConfig on the cluster but its upgradeAt is in the future"""
-    dt.utcnow.return_value = upgrade_at - timedelta(hours=1)
-    gso = mocker.patch(
-        "reconcile.openshift_upgrade_watcher._get_start_osd", autospec=True
-    )
-    gso.return_value = upgrade_at.strftime("%Y-%m-%dT%H:%M:%SZ"), upgrade_version
-    ouw.notify_upgrades_start(
-        ocm_map=ouw_ocm_map,
-        oc_map=ouw_oc_map,
-        clusters=[load_cluster("cluster1.yml")],
-        state=state,
-        slack=slack,
-    )
-    assert slack.chat_post_message.call_count == 0
-    assert state.add.call_count == 0
-
-
-def test_new_upgrade_notify(
-    mocker, state, slack, ouw_oc_map, ouw_ocm_map, upgrade_config, dt
-):
-    """There is an UpgradeConfig on the cluster, its upgradeAt is in the past,
-    and we did not already notify"""
-    dt.utcnow.return_value = upgrade_at + timedelta(hours=1)
-    gso = mocker.patch(
-        "reconcile.openshift_upgrade_watcher._get_start_osd", autospec=True
-    )
-    gso.return_value = upgrade_at.strftime("%Y-%m-%dT%H:%M:%SZ"), upgrade_version
-    state.exists.return_value = False
-    ouw.notify_upgrades_start(
-        ocm_map=ouw_ocm_map,
-        oc_map=ouw_oc_map,
-        clusters=[load_cluster("cluster1.yml")],
-        state=state,
-        slack=slack,
-    )
-    assert slack.chat_post_message.call_count == 1
-    assert state.add.call_count == 1
-
-
-def test_new_upgrade_already_notified(
-    mocker, state, slack, ouw_oc_map, ouw_ocm_map, upgrade_config, dt
-):
-    """There is an UpgradeConfig on the cluster, its upgradeAt is in the past,
-    and we already notified"""
-    state.exists.return_value = True
-    state.get.return_value = None
-    dt.utcnow.return_value = upgrade_at + timedelta(hours=1)
-    gso = mocker.patch(
-        "reconcile.openshift_upgrade_watcher._get_start_osd", autospec=True
-    )
-    gso.return_value = upgrade_at.strftime("%Y-%m-%dT%H:%M:%SZ"), upgrade_version
-    ouw.notify_upgrades_start(
-        ocm_map=ouw_ocm_map,
-        oc_map=ouw_oc_map,
-        clusters=[load_cluster("cluster1.yml")],
-        state=state,
-        slack=slack,
-    )
-    assert slack.chat_post_message.call_count == 0
-    assert state.add.call_count == 0
-
-
-@pytest.fixture
-def clusters():
-    cluster = load_cluster("cluster1.yml")
-    cluster.name = cluster_name
-    if not cluster.spec:
-        raise RuntimeError("This test requires a cluster_spec. Check your fixture.")
-    cluster.spec.version = upgrade_version
-    return [cluster]
-
-
-def test_new_version_no_op(mocker, state, slack, clusters):
-    """We already notified for this cluster & version"""
-    state.exists.return_value = True
-    state.get.return_value = upgrade_version  # same version, already notified
-    ouw.notify_cluster_new_version(clusters, state=state, slack=slack)
-    assert slack.chat_post_message.call_count == 0
-    assert state.add.call_count == 0
-
-
-def test_new_version_no_state(mocker, state, slack, clusters):
-    """We never notified for this cluster"""
-    state.exists.return_value = False  # never notified for this cluster
-    state.get.return_value = None
-    ouw.notify_cluster_new_version(clusters, state=state, slack=slack)
-    assert slack.chat_post_message.call_count == 1
-    assert state.add.call_count == 1
-
-
-def test_new_version_notify(mocker, state, slack, clusters):
-    """We already notified for this cluster, but on an old version"""
-    state.exists.return_value = True
-    state.get.return_value = old_version  # different version
-    ouw.notify_cluster_new_version(clusters, state=state, slack=slack)
-    assert slack.chat_post_message.call_count == 1
-    assert state.add.call_count == 1
-
-
-def test__get_start_hypershift_started(mocker):
-    get_control_plane_upgrade_policies_mock = mocker.patch.object(
-        ouw, "get_control_plane_upgrade_policies", autospec=True
-    )
-    get_control_plane_upgrade_policies_mock.return_value = [
-        {
-            "next_run": upgrade_at,
-            "version": upgrade_version,
-            "state": "started",
-        }
-    ]
-    ocm_api_mock = mocker.patch(
-        "reconcile.utils.ocm_base_client.OCMBaseClient", autospec=True
-    )
-    next_run, version = ouw._get_start_hypershift(ocm_api_mock, "cluster-id")
-    assert next_run == upgrade_at
-    assert version == upgrade_version
-
-
-def test__get_start_hypershift_noop(mocker):
-    get_control_plane_upgrade_policies_mock = mocker.patch.object(
-        ouw, "get_control_plane_upgrade_policies", autospec=True
-    )
-    get_control_plane_upgrade_policies_mock.return_value = []
-    ocm_api_mock = mocker.patch(
-        "reconcile.utils.ocm_base_client.OCMBaseClient", autospec=True
-    )
-    next_run, version = ouw._get_start_hypershift(ocm_api_mock, "cluster-id")
-    assert not next_run
-    assert not version
-
-
-def test__get_start_osd_no_op(ouw_oc_map):
-    """There is no UpgradeConfig on the cluster"""
-    next_run, version = ouw._get_start_osd(ouw_oc_map, cluster_name)
-    assert not next_run
-    assert not version
-
-
-def test__get_start_osd_started(ouw_oc_map, upgrade_config):
-    """There is no UpgradeConfig on the cluster"""
-    oc = ouw_oc_map.get.return_value
-    oc.get.return_value = upgrade_config
-    next_run, version = ouw._get_start_osd(ouw_oc_map, cluster_name)
-    assert next_run == "2020-06-01T00:00:00Z"
-    assert version == "4.5.2"

reconcile/test/test_prometheus_rules_tester.py

@@ -1,151 +0,0 @@
-from typing import Any
-from unittest.mock import (
-    create_autospec,
-    patch,
-)
-
-import pytest
-
-from reconcile.gql_definitions.common.app_interface_vault_settings import (
-    AppInterfaceSettingsV1,
-)
-from reconcile.openshift_resources_base import NAMESPACES_QUERY
-from reconcile.prometheus_rules_tester.integration import Test as PTest
-from reconcile.prometheus_rules_tester.integration import (
-    check_rules_and_tests,
-    run,
-)
-from reconcile.status import ExitCodes
-from reconcile.utils import gql
-
-from .fixtures import Fixtures
-
-THREAD_POOL_SIZE = 2
-
-
-class TstUnsupportedGqlQueryError(Exception):
-    pass
-
-
-class TestPrometheusRulesTester:
-    def mock_gql_get_resource(self, path: str) -> dict[str, str]:
-        """Mock for GqlApi.get_resources using fixtures. Namespace fixtures have paths
-        that refer to files in fixture dir so that this methos loads them."""
-        content = self.fxt.get(path)
-        return {
-            "path": path,
-            "content": content,
-            "sha256sum": "",
-        }
-
-    def mock_gql_query(self, query: str) -> dict[str, Any]:
-        """Mock for GqlApi.query using test_data set in setup_method."""
-        if query == NAMESPACES_QUERY:
-            return {"namespaces": self.ns_data}
-
-        raise TstUnsupportedGqlQueryError("Unsupported query")
-
-    def setup_method(self) -> None:
-        self.ns_data: dict[str, Any] = {}
-
-        self.fxt = Fixtures("prometheus_rules_tester")
-        self.alerting_services = {"yak-shaver"}
-        self.vault_settings = AppInterfaceSettingsV1(vault=False)
-
-        # Patcher for GqlApi methods
-        self.gql_patcher = patch.object(gql, "get_api", autospec=True)
-        self.gql = self.gql_patcher.start()
-        gqlapi_mock = create_autospec(gql.GqlApi)
-        self.gql.return_value = gqlapi_mock
-        gqlapi_mock.query.side_effect = self.mock_gql_query
-        gqlapi_mock.get_resource.side_effect = self.mock_gql_get_resource
-
-    def teardown_method(self) -> None:
-        """cleanup patches created in setup_method"""
-        self.gql_patcher.stop()
-
-    def run_check(self, cluster_name=None) -> list[PTest]:
-        return check_rules_and_tests(
-            vault_settings=self.vault_settings,
-            alerting_services=self.alerting_services,
-            thread_pool_size=THREAD_POOL_SIZE,
-            cluster_names=cluster_name,
-        )
-
-    def test_ok_non_templated(self) -> None:
-        self.ns_data = self.fxt.get_anymarkup("ns-ok-non-templated.yaml")
-        assert self.run_check() == []
-
-    def test_ok_templated(self) -> None:
-        self.ns_data = self.fxt.get_anymarkup("ns-ok-templated.yaml")
-        assert self.run_check() == []
-
-    # Bad rule syntax should me caught by schema, but since we check it, we test it."
-    def test_bad_rule(self) -> None:
-        self.ns_data = self.fxt.get_anymarkup("ns-bad-rule.yaml")
-        failed = self.run_check()
-        assert len(failed) == 1
-        assert "Error running promtool command" in str(failed[0].result)
-
-    def test_bad_alerting_service(self) -> None:
-        self.ns_data = self.fxt.get_anymarkup("ns-ok-templated.yaml")
-        self.alerting_services = {"not-a-yak-shaver"}
-        failed = self.run_check()
-        assert len(failed) == 1
-        assert "services are missing from alertingServices" in str(failed[0].result)
-
-    @patch("reconcile.prometheus_rules_tester.integration.MAX_CONFIGMAP_SIZE", 1)
-    def test_rule_too_long(self) -> None:
-        self.ns_data = self.fxt.get_anymarkup("ns-ok-non-templated.yaml")
-        failed = self.run_check()
-        assert len(failed) == 1
-        assert "Rules spec is larger than 1 bytes" in str(failed[0].result)
-
-    def test_bad_test(self) -> None:
-        self.ns_data = self.fxt.get_anymarkup("ns-bad-test.yaml")
-        failed = self.run_check()
-        assert len(failed) == 1
-        assert "Error running promtool command" in str(failed[0].result)
-
-    # Tests regarding filtering by cluster name.
-    def test_2_ns_bad_alerting_service_unfiltered(self) -> None:
-        self.ns_data = self.fxt.get_anymarkup("2-ns-ok-non-templated.yaml")
-        self.alerting_services = {"not-a-yak-shaver"}
-        assert len(self.run_check()) == 2
-
-    def test_2_ns_bad_alerting_service_filtered(self) -> None:
-        self.ns_data = self.fxt.get_anymarkup("2-ns-ok-non-templated.yaml")
-        self.alerting_services = {"not-a-yak-shaver"}
-
-        failed = self.run_check(cluster_name="appint-ex-01")
-        assert len(failed) == 1
-
-        failed = self.run_check(cluster_name="appint-ex-02")
-        assert len(failed) == 1
-
-        failed = self.run_check(cluster_name="no-such-cluster")
-        assert len(failed) == 0
-
-    @patch("reconcile.prometheus_rules_tester.integration.get_alerting_services")
-    @patch(
-        "reconcile.prometheus_rules_tester.integration.get_app_interface_vault_settings"
-    )
-    def test_run_logs_error(
-        self, mocker_vault_settings, mocker_alerting_services, caplog
-    ) -> None:
-        self.ns_data = self.fxt.get_anymarkup("ns-bad-test.yaml")
-        mocker_alerting_services.return_value = {"yak-shaver"}
-        mocker_vault_settings.return_value = AppInterfaceSettingsV1(vault=False)
-        cluster_name = ("appint-ex-01",)
-
-        with pytest.raises(SystemExit) as exc:
-            run(False, THREAD_POOL_SIZE, cluster_names=cluster_name)
-
-        assert exc.value.code == ExitCodes.ERROR
-
-        error_msg = (
-            "Error checking rule bad-test.prometheusrules.yaml "
-            "from namespace openshift-customer-monitoring in "
-            f"cluster {cluster_name[0]}: Error running promtool command"
-        )
-        assert error_msg in caplog.text