qontract-reconcile 0.10.1rc1191__py3-none-any.whl → 0.10.1rc1192__py3-none-any.whl

{qontract_reconcile-0.10.1rc1191.dist-info → qontract_reconcile-0.10.1rc1192.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: qontract-reconcile
-Version: 0.10.1rc1191
+Version: 0.10.1rc1192
 Summary: Collection of tools to reconcile services with their desired state as defined in the app-interface DB.
 Home-page: https://github.com/app-sre/qontract-reconcile
 Author: Red Hat App-SRE Team

{qontract_reconcile-0.10.1rc1191.dist-info → qontract_reconcile-0.10.1rc1192.dist-info}/RECORD

@@ -818,7 +818,7 @@ reconcile/utils/runtime/sharding.py,sha256=r0ieUtNed7NvknSw6qQrCkKpVXE1shuHGnfFc
 reconcile/utils/saasherder/__init__.py,sha256=3U8plqMAPRE1kjwZ5YnIsYsggTf4_gS7flRUEuXVBAs,343
 reconcile/utils/saasherder/interfaces.py,sha256=C2wrw34OXypshVocAsPrVZsSHptgw4g9u7Haa2wulZQ,9087
 reconcile/utils/saasherder/models.py,sha256=z8ln03zi2a8cu716NcNUDHp8Dv1VcVbhqdWVxCl7x9A,10148
-reconcile/utils/saasherder/saasherder.py,sha256=t7dqcXj9FFULROG_gUmdoSNQOLKfhdlquzwxw710yOA,85358
+reconcile/utils/saasherder/saasherder.py,sha256=120A33jOQefZfYUpeDzaeNR4-Twe5V5bsBSe0DoOCSo,86115
 reconcile/utils/terraform/__init__.py,sha256=zNbiyTWo35AT1sFTElL2j_AA0jJ_yWE_bfFn-nD2xik,250
 reconcile/utils/terraform/config.py,sha256=5UVrd563TMcvi4ooa5JvWVDW1I3bIWg484u79evfV_8,164
 reconcile/utils/terraform/config_client.py,sha256=gRL1rQ0AqvShei_rcGqC3HDYGskOFKE1nPrJyJE9yno,4676
@@ -882,8 +882,8 @@ tools/test/test_qontract_cli.py,sha256=iuzKbQ6ahinvjoQmQLBrG4shey0z-1rB6qCgS8T6d
 tools/test/test_saas_promotion_state.py,sha256=dy4kkSSAQ7bC0Xp2CociETGN-2aABEfL6FU5D9Jl00Y,6056
 tools/test/test_sd_app_sre_alert_report.py,sha256=v363r9zM7__0kR5K6mvJoGFcM9BvE33fWAayrqkpojA,2116
 tools/test/test_sre_checkpoints.py,sha256=SKqPPTl9ua0RFdSSofnoQX-JZE6dFLO3LRhfQzqtfh8,2607
-qontract_reconcile-0.10.1rc1191.dist-info/METADATA,sha256=PYtZqqEcXMwJNmaFvFxZTdM7fWRL05zlsWrO6ZboOOQ,2213
-qontract_reconcile-0.10.1rc1191.dist-info/WHEEL,sha256=tZoeGjtWxWRfdplE7E3d45VPlLNQnvbKiYnx7gwAy8A,92
-qontract_reconcile-0.10.1rc1191.dist-info/entry_points.txt,sha256=GKQqCl2j2X1BJQ69een6rHcR26PmnxnONLNOQB-nRjY,491
-qontract_reconcile-0.10.1rc1191.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
-qontract_reconcile-0.10.1rc1191.dist-info/RECORD,,
+qontract_reconcile-0.10.1rc1192.dist-info/METADATA,sha256=xvVSmRGPTAuwy6U0jB-TwMzTgaD5b8OZIP5Em_jdZlo,2213
+qontract_reconcile-0.10.1rc1192.dist-info/WHEEL,sha256=tZoeGjtWxWRfdplE7E3d45VPlLNQnvbKiYnx7gwAy8A,92
+qontract_reconcile-0.10.1rc1192.dist-info/entry_points.txt,sha256=GKQqCl2j2X1BJQ69een6rHcR26PmnxnONLNOQB-nRjY,491
+qontract_reconcile-0.10.1rc1192.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
+qontract_reconcile-0.10.1rc1192.dist-info/RECORD,,

reconcile/utils/saasherder/saasherder.py

@@ -1112,29 +1112,54 @@ class SaasHerder:  # pylint: disable=too-many-public-methods
                 username, password = (
                     base64.b64decode(auth["auth"]).decode("utf-8").split(":")
                 )
-                with suppress(Exception):
-                    return Image(
-                        image,
-                        username=username,
-                        password=password,
-                        auth_server=image_auth.auth_server,
-                        timeout=REQUEST_TIMEOUT,
-                    )
+
+                return SaasHerder._get_and_validate_image(
+                    full_image_path=image,
+                    username=username,
+                    password=password,
+                    auth_server=image_auth.auth_server,
+                    timeout=REQUEST_TIMEOUT,
+                    error_prefix=error_prefix,
+                )
 
         # basic auth fallback for backwards compatibility
+        return SaasHerder._get_and_validate_image(
+            full_image_path=image,
+            username=image_auth.username,
+            password=image_auth.password,
+            auth_server=image_auth.auth_server,
+            timeout=REQUEST_TIMEOUT,
+            error_prefix=error_prefix,
+        )
+
+    @staticmethod
+    def _get_and_validate_image(
+        full_image_path: str,
+        username: str | Any,
+        password: str | Any,
+        auth_server: str | Any,
+        timeout: int,
+        error_prefix: str,
+    ) -> Image | None:
         try:
-            return Image(
-                image,
-                username=image_auth.username,
-                password=image_auth.password,
-                auth_server=image_auth.auth_server,
-                timeout=REQUEST_TIMEOUT,
+            img = Image(
+                full_image_path,
+                username=username,
+                password=password,
+                auth_server=auth_server,
+                timeout=timeout,
             )
+            if img:
+                return img
+            else:
+                logging.error(
+                    f"{error_prefix} Image : {full_image_path} does not exist"
+                )
         except Exception as e:
             logging.error(
-                f"{error_prefix} Image is invalid: {image}. " + f"details: {e!s}"
+                f"{error_prefix} Image is invalid: {full_image_path}. "
+                + f"details: {e!s}"
             )
-
         return None
 
     def _check_images(