qontract-reconcile 0.10.1rc1153__py3-none-any.whl → 0.10.1rc1155__py3-none-any.whl

{qontract_reconcile-0.10.1rc1153.dist-info → qontract_reconcile-0.10.1rc1155.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: qontract-reconcile
-Version: 0.10.1rc1153
+Version: 0.10.1rc1155
 Summary: Collection of tools to reconcile services with their desired state as defined in the app-interface DB.
 Home-page: https://github.com/app-sre/qontract-reconcile
 Author: Red Hat App-SRE Team

{qontract_reconcile-0.10.1rc1153.dist-info → qontract_reconcile-0.10.1rc1155.dist-info}/RECORD

@@ -90,7 +90,7 @@ reconcile/openshift_users.py,sha256=63mar-swgidz8f10TCPJcofbMN9FETq-HuVFpi8dUL4,
 reconcile/openshift_vault_secrets.py,sha256=9rTqV6wzCQx2Oh712E_Xj8wMG7u8Oh-pY8DWjlv4mZw,1660
 reconcile/quay_base.py,sha256=h5xNjb7EZm8L2JgpO42r6w0UA4im5dabZXJSIW69zKU,1987
 reconcile/quay_membership.py,sha256=YDLY7ayDsatEpYCe_iMdf3pkvrbmN8mAwrDKUJUa4Lg,6260
-reconcile/quay_mirror.py,sha256=dWvYqZcFu6RFUwyOVxNByRWx2FLIYTO2OFr2N1YtjJc,14706
+reconcile/quay_mirror.py,sha256=mFp4Z5Nwl-DcFbbsJBOB8f9ldohFT-V67o868d5ux1s,15369
 reconcile/quay_mirror_org.py,sha256=utrJpJaKCs7U6WX6DODdfCeB0EmX-lUC8Y5fkmpgFSs,10764
 reconcile/quay_permissions.py,sha256=9KOutS1w4RFQqkvMSy54VtsKNx56-phzP6yI_rEW-B8,4244
 reconcile/quay_repos.py,sha256=cuEYG0HUe0ut5yvLdEwOF5-CmccpXQHRb_wDazvDrvQ,6895
@@ -199,7 +199,7 @@ reconcile/external_resources/integration_secrets_sync.py,sha256=dX09O3r6KURziUYY
 reconcile/external_resources/manager.py,sha256=wcqTawNS4qoBHFVfyCfHtWXh4L3AlgcNYx_Ov_vEjNg,17914
 reconcile/external_resources/meta.py,sha256=noaytFzmShpzLA_ebGh7wuP45mOfHIOnnoUxivjDa1I,672
 reconcile/external_resources/metrics.py,sha256=nMbyonGZEJDD1lYzpQY2eR9TNwvxYC4ZCcpi6wrExcM,1037
-reconcile/external_resources/model.py,sha256=ibOd0pa6hyJX-MK3LGVxOa3ra_Xfq7mbd5T_9d3bfhM,8444
+reconcile/external_resources/model.py,sha256=Ta8eOJ97RxCgBtWqsF4MWzQhgsOC2PoFfBKM5y3rM6U,8378
 reconcile/external_resources/reconciler.py,sha256=3KFmkHsN7YAwJUSBpN1Xd_D2zM9Ea5_c2uMGWsfruZo,9707
 reconcile/external_resources/secrets_sync.py,sha256=6n0oDPLjd9Ql0lf6zsr1AZw8A6EEe3yCzl20XodtgkE,16229
 reconcile/external_resources/state.py,sha256=UupSa6tl4-73_J6Fhisn-qHal3v3uAUS5s5sk85LGDs,9343
@@ -549,7 +549,7 @@ reconcile/test/test_openshift_tekton_resources.py,sha256=O6-qPQwSiPHQKm1a1iqRU2V
 reconcile/test/test_openshift_upgrade_watcher.py,sha256=0GDQ_YFHIX8DbkbDYSuLv9uZeeg4NwP1vlOqvSaZvN4,7183
 reconcile/test/test_prometheus_rules_tester.py,sha256=cgVkPM3KcAw69bOkJ6iR2Lfog_WgblyoqVRtXv4ly7o,5685
 reconcile/test/test_quay_membership.py,sha256=e29Giz5S9ckFgjpTO8PBo8qVPocIQmy4WqsRhgTFd9A,2643
-reconcile/test/test_quay_mirror.py,sha256=UBLQDtet5WkWnh98ev5cI3yAflQl07awg2dXTefqoUk,6311
+reconcile/test/test_quay_mirror.py,sha256=9TIu1-YQl0CG705m-FeEOs4OwKG3UVJzVhISw525Lco,6324
 reconcile/test/test_quay_mirror_org.py,sha256=67XwB0WkqO6l9SeR9cSfjODyt-P587Kvqvam7hR8rLQ,3008
 reconcile/test/test_quay_repos.py,sha256=TdkcRF_a8PLp01Kti9eZZN-vGup2yPBT4Iba3k08qe0,1810
 reconcile/test/test_queries.py,sha256=SpH3RmNpBjEr_ne3VjAMCgKK8RE1z1zo7bypkT5uoO4,1946
@@ -683,7 +683,7 @@ reconcile/utils/gpg.py,sha256=EKG7_fdMv8BMlV5yUdPiqoTx-KrzmVSEAl2sLkaKwWI,1123
 reconcile/utils/gql.py,sha256=C0thIm_k9MBldfqwHzyqtYZk9sIvMdm9IbbnXLGwjD8,14158
 reconcile/utils/grouping.py,sha256=vr9SFHZ7bqmHYrvYcEZt-Er3-yQYfAAdq5sHLZVmXPY,456
 reconcile/utils/helm.py,sha256=hr4J_9mBZwbc1FDNfFh4QKAj0h3eLxyTN2Y3UxIRp8U,3893
-reconcile/utils/helpers.py,sha256=1PK_6gTzg2kJ8Ac8zZHB2yEubewDWtVspTl5bVbvbEY,1462
+reconcile/utils/helpers.py,sha256=womAD2bKPUAFOjHvNPAe_2Hsb-oVTxuQiYPGeR-Thp0,1772
 reconcile/utils/imap_client.py,sha256=h8YDiCSCvroErhpH_-KGYI7Y2WU2Q2oSpuxDFbOkSbY,1989
 reconcile/utils/instrumented_wrappers.py,sha256=eVwMoa6FCrYxLv3RML3WpZF9qKVfCTjMxphgVXG03OM,1073
 reconcile/utils/jenkins_api.py,sha256=RaKuZmO7_lbI-hE6c_Pq2a6CQdmBVj7BcP2jR68cIbI,7081
@@ -880,8 +880,8 @@ tools/test/test_qontract_cli.py,sha256=iuzKbQ6ahinvjoQmQLBrG4shey0z-1rB6qCgS8T6d
 tools/test/test_saas_promotion_state.py,sha256=dy4kkSSAQ7bC0Xp2CociETGN-2aABEfL6FU5D9Jl00Y,6056
 tools/test/test_sd_app_sre_alert_report.py,sha256=v363r9zM7__0kR5K6mvJoGFcM9BvE33fWAayrqkpojA,2116
 tools/test/test_sre_checkpoints.py,sha256=SKqPPTl9ua0RFdSSofnoQX-JZE6dFLO3LRhfQzqtfh8,2607
-qontract_reconcile-0.10.1rc1153.dist-info/METADATA,sha256=W7PsNpp1_srAAOioGMxIeZNzgmkrmBV5ra6opFDI-58,2213
-qontract_reconcile-0.10.1rc1153.dist-info/WHEEL,sha256=eOLhNAGa2EW3wWl_TU484h7q1UNgy0JXjjoqKoxAAQc,92
-qontract_reconcile-0.10.1rc1153.dist-info/entry_points.txt,sha256=GKQqCl2j2X1BJQ69een6rHcR26PmnxnONLNOQB-nRjY,491
-qontract_reconcile-0.10.1rc1153.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
-qontract_reconcile-0.10.1rc1153.dist-info/RECORD,,
+qontract_reconcile-0.10.1rc1155.dist-info/METADATA,sha256=R8XN1xU4JfYBpQJVZ8l8iWuRWuQ8DpVGaYE-pIpLRwk,2213
+qontract_reconcile-0.10.1rc1155.dist-info/WHEEL,sha256=eOLhNAGa2EW3wWl_TU484h7q1UNgy0JXjjoqKoxAAQc,92
+qontract_reconcile-0.10.1rc1155.dist-info/entry_points.txt,sha256=GKQqCl2j2X1BJQ69een6rHcR26PmnxnONLNOQB-nRjY,491
+qontract_reconcile-0.10.1rc1155.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
+qontract_reconcile-0.10.1rc1155.dist-info/RECORD,,

reconcile/external_resources/model.py

@@ -76,7 +76,25 @@ SUPPORTED_RESOURCE_TYPES = (
 
 
 class ExternalResourcesInventory(MutableMapping):
-    _inventory: dict[ExternalResourceKey, ExternalResourceSpec] = {}
+    def __init__(self, namespaces: Iterable[NamespaceV1]) -> None:
+        self._inventory: dict[ExternalResourceKey, ExternalResourceSpec] = {}
+
+        desired_providers = [
+            (p, ns)
+            for ns in namespaces
+            for p in ns.external_resources or []
+            if isinstance(p, SUPPORTED_RESOURCE_PROVIDERS) and p.resources
+        ]
+
+        desired_specs = [
+            self._build_external_resource_spec(ns, p, r)
+            for (p, ns) in desired_providers
+            for r in p.resources
+            if isinstance(r, SUPPORTED_RESOURCE_TYPES) and r.managed_by_erv2
+        ]
+
+        for spec in desired_specs:
+            self._inventory[ExternalResourceKey.from_spec(spec)] = spec
 
     def _build_external_resource_spec(
         self,
@@ -100,24 +118,6 @@ class ExternalResourcesInventory(MutableMapping):
         spec.metadata[MODULE_OVERRIDES] = resource.module_overrides
         return spec
 
-    def __init__(self, namespaces: Iterable[NamespaceV1]) -> None:
-        desired_providers = [
-            (p, ns)
-            for ns in namespaces
-            for p in ns.external_resources or []
-            if isinstance(p, SUPPORTED_RESOURCE_PROVIDERS) and p.resources
-        ]
-
-        desired_specs = [
-            self._build_external_resource_spec(ns, p, r)
-            for (p, ns) in desired_providers
-            for r in p.resources
-            if isinstance(r, SUPPORTED_RESOURCE_TYPES) and r.managed_by_erv2
-        ]
-
-        for spec in desired_specs:
-            self._inventory[ExternalResourceKey.from_spec(spec)] = spec
-
     def __getitem__(self, key: ExternalResourceKey) -> ExternalResourceSpec | None:
         return self._inventory[key]
 
@@ -161,8 +161,6 @@ class ExternalResourceModuleKey(BaseModel, frozen=True):
 
 
 class ModuleInventory:
-    inventory: dict[ExternalResourceModuleKey, ExternalResourcesModuleV1]
-
     def __init__(
         self, inventory: dict[ExternalResourceModuleKey, ExternalResourcesModuleV1]
     ):

reconcile/quay_mirror.py

@@ -1,6 +1,5 @@
 import logging
 import os
-import re
 import sys
 import tempfile
 import time
@@ -29,6 +28,7 @@ from reconcile.utils import (
     metrics,
     sharding,
 )
+from reconcile.utils.helpers import match_patterns
 from reconcile.utils.instrumented_wrappers import InstrumentedImage as Image
 from reconcile.utils.instrumented_wrappers import InstrumentedSkopeo as Skopeo
 from reconcile.utils.secret_reader import SecretReader
@@ -205,20 +205,38 @@ class QuayMirror:
         return summary
 
     @staticmethod
-    def sync_tag(tags, tags_exclude, candidate):
-        if tags is not None:
-            # When tags is defined, we don't look at tags_exclude
-            return any(re.match(tag, candidate) for tag in tags)
-
-        if tags_exclude is not None:
-            for tag_exclude in tags_exclude:
-                if re.match(tag_exclude, candidate):
-                    return False
+    def sync_tag(
+        tags: Iterable[str] | None,
+        tags_exclude: Iterable[str] | None,
+        candidate: str,
+    ) -> bool:
+        """
+        Determine if the candidate tag should sync, tags_exclude check take precedence.
+        :param tags: regex patterns to filter, match means to sync, None means no filter
+        :param tags_exclude: regex patterns to filter, match means not to sync, None means no filter
+        :param candidate: tag to check
+        :return: bool, True means to sync, False means not to sync
+        """
+        if not tags and not tags_exclude:
             return True
 
-        # Both tags and tags_exclude are None, so
-        # tag must be synced
-        return True
+        if not tags:
+            # only tags_exclude provided
+            assert tags_exclude  # mypy can't infer not None
+            return not match_patterns(tags_exclude, candidate)
+
+        if not tags_exclude:
+            # only tags provided
+            return match_patterns(tags, candidate)
+
+        # both tags and tags_exclude provided
+        return not match_patterns(
+            tags_exclude,
+            candidate,
+        ) and match_patterns(
+            tags,
+            candidate,
+        )
 
     def process_sync_tasks(self):
         if self.is_compare_tags:

reconcile/test/test_quay_mirror.py

@@ -96,22 +96,15 @@ class TestIsCompareTags:
         (["^sha256-.+sig$", "^main-.+"], None, "main-755781cc", True),
         (["^sha256-.+sig$", "^main-.+"], None, "sha256-8b5.sig", True),
         (["^sha256-.+sig$", "^main-.+"], None, "1.2.3", False),
-        # Tags exclude tests.
+        # # Tags exclude tests.
         (None, ["^sha256-.+sig$", "^main-.+"], "main-755781cc", False),
         (None, ["^sha256-.+sig$", "^main-.+"], "sha256-8b5.sig", False),
-        # When both includes and excludes are explicitly given, includes take precedence.
-        (
-            ["^sha256-.+sig$", "^main-.+"],
-            ["^sha256-.+sig$", "^main-.+"],
-            "main-755781cc",
-            True,
-        ),
-        (
-            ["^sha256-.+sig$", "^main-.+"],
-            ["^sha256-.+sig$", "^main-.+"],
-            "sha256-8b5.sig",
-            True,
-        ),
+        (None, ["^sha256-.+sig$", "^main-.+"], "1.2.3", True),
+        # When both includes and excludes are explicitly given, exclude take precedence.
+        (["^sha256-.+sig$", "^main-.+"], ["main-755781cc"], "main-755781cc", False),
+        (["^sha256-.+sig$", "^main-.+"], ["main-755781cc"], "sha256-8b5.sig", True),
+        # both include and exclude are not set
+        (None, None, "main-755781cc", True),
     ],
 )
 def test_sync_tag(tags, tags_exclude, candidate, result):

reconcile/utils/helpers.py

@@ -1,5 +1,6 @@
 import logging
 import random
+import re
 import string
 from collections import Counter
 from collections.abc import (
@@ -52,3 +53,13 @@ def generate_random_password(string_length: int = 20) -> str:
     """Generate a random string of letters and digits"""
     letters_and_digits = string.ascii_letters + string.digits
     return "".join(random.choices(letters_and_digits, k=string_length))
+
+
+def match_patterns(patterns: Iterable[str], s: str) -> bool:
+    """
+    Check if any pattern matches the string.
+    :param patterns: patterns to match
+    :param s: string to check
+    :return: True if any pattern matches, False otherwise
+    """
+    return any(re.match(p, s) for p in patterns)