qontract-reconcile 0.10.1rc1132__py3-none-any.whl → 0.10.1rc1134__py3-none-any.whl

{qontract_reconcile-0.10.1rc1132.dist-info → qontract_reconcile-0.10.1rc1134.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: qontract-reconcile
-Version: 0.10.1rc1132
+Version: 0.10.1rc1134
 Summary: Collection of tools to reconcile services with their desired state as defined in the app-interface DB.
 Home-page: https://github.com/app-sre/qontract-reconcile
 Author: Red Hat App-SRE Team

{qontract_reconcile-0.10.1rc1132.dist-info → qontract_reconcile-0.10.1rc1134.dist-info}/RECORD

@@ -17,7 +17,7 @@ reconcile/dashdotdb_base.py,sha256=l34QDu1G96_Ctnh7ZXdxXgSeCE93GQMdLAkWxmN6vDA,4
 reconcile/dashdotdb_cso.py,sha256=IkI_KSZuH_kPn0cIQKXitJXiPPFSyHykrOuFy9h9ZpU,3643
 reconcile/dashdotdb_dora.py,sha256=YmfxD02tKUAQQzku2aj2DXv1oKkAr4V_2lrPVtTFGyI,17674
 reconcile/dashdotdb_dvo.py,sha256=lCkZ0iby6HrNQb-3kYb6xrt8wCjVUZYxKzz9SiStfHU,8946
-reconcile/dashdotdb_slo.py,sha256=S7j7xFeGaJkE82biWEdPu6ORCJEsJYNTDqcTzSl8AQY,6679
+reconcile/dashdotdb_slo.py,sha256=QKKqLzA2f6zUjQvQ_6U4DObpSOB80C7h-NWXJhzQwME,7812
 reconcile/database_access_manager.py,sha256=FfyXnYcUdX54BYR_6B9PWFmhT8xdNrPCfoz3Q7q39tg,25646
 reconcile/deadmanssnitch.py,sha256=n-5W-djUgwzpmdDM4eQIZpkkDmHY0vndt-42LJXI4Y8,7491
 reconcile/email_sender.py,sha256=-5L-Ag_jaEYSzYRoMr52KQBRXz1E8yx9GqLbg2X4XFU,3533
@@ -283,7 +283,7 @@ reconcile/gql_definitions/cost_report/app_names.py,sha256=fzqYXyiTSll359J1F1o7qa
 reconcile/gql_definitions/cost_report/cost_namespaces.py,sha256=wV76J8Ynq0ObSfjSZQRLmCPUZ96frGc82Z5HPM_e4F4,2219
 reconcile/gql_definitions/cost_report/settings.py,sha256=0nhBDJ5MZ1m7XkNDGrRLmsnUbzqZ4WRh_DDEEzKhcxU,2153
 reconcile/gql_definitions/dashdotdb_slo/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-reconcile/gql_definitions/dashdotdb_slo/slo_documents_query.py,sha256=zUa-CmpOwiymVmOV6KwDHH5mMl06p000320FcOas6hU,4315
+reconcile/gql_definitions/dashdotdb_slo/slo_documents_query.py,sha256=MYYpVOc8Ze9w7k6-tlUkp5OaPG_5bqHPS5FhfWTw00U,4335
 reconcile/gql_definitions/dynatrace_token_provider/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 reconcile/gql_definitions/dynatrace_token_provider/dynatrace_bootstrap_tokens.py,sha256=5gTuAnR2rnx2k6Rn7FMEAzw6GCZ6F5HZbqkmJ9-3NI4,2244
 reconcile/gql_definitions/dynatrace_token_provider/token_specs.py,sha256=XGsMuB8gowRpqJjkD_KRomx-1OswzyWbF4qjVdhionk,2555
@@ -871,8 +871,8 @@ tools/test/test_qontract_cli.py,sha256=_D61RFGAN5x44CY1tYbouhlGXXABwYfxKSWSQx3Jr
 tools/test/test_saas_promotion_state.py,sha256=dy4kkSSAQ7bC0Xp2CociETGN-2aABEfL6FU5D9Jl00Y,6056
 tools/test/test_sd_app_sre_alert_report.py,sha256=v363r9zM7__0kR5K6mvJoGFcM9BvE33fWAayrqkpojA,2116
 tools/test/test_sre_checkpoints.py,sha256=SKqPPTl9ua0RFdSSofnoQX-JZE6dFLO3LRhfQzqtfh8,2607
-qontract_reconcile-0.10.1rc1132.dist-info/METADATA,sha256=lELtTQsA2H3TPWaNDegyi61VlMiwzJkt9pEYK0BdARA,2213
-qontract_reconcile-0.10.1rc1132.dist-info/WHEEL,sha256=eOLhNAGa2EW3wWl_TU484h7q1UNgy0JXjjoqKoxAAQc,92
-qontract_reconcile-0.10.1rc1132.dist-info/entry_points.txt,sha256=GKQqCl2j2X1BJQ69een6rHcR26PmnxnONLNOQB-nRjY,491
-qontract_reconcile-0.10.1rc1132.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
-qontract_reconcile-0.10.1rc1132.dist-info/RECORD,,
+qontract_reconcile-0.10.1rc1134.dist-info/METADATA,sha256=HtnNYSBnLq4T0QQnHtSMfJvmXumkAWedjkfjqucyqAw,2213
+qontract_reconcile-0.10.1rc1134.dist-info/WHEEL,sha256=eOLhNAGa2EW3wWl_TU484h7q1UNgy0JXjjoqKoxAAQc,92
+qontract_reconcile-0.10.1rc1134.dist-info/entry_points.txt,sha256=GKQqCl2j2X1BJQ69een6rHcR26PmnxnONLNOQB-nRjY,491
+qontract_reconcile-0.10.1rc1134.dist-info/top_level.txt,sha256=l5ISPoXzt0SdR4jVdkfa7RPSKNc8zAHYWAnR-Dw8Ey8,24
+qontract_reconcile-0.10.1rc1134.dist-info/RECORD,,

reconcile/dashdotdb_slo.py

@@ -1,5 +1,6 @@
 from collections.abc import Iterable
 from dataclasses import dataclass
+from math import isnan
 from typing import Any
 
 import jinja2
@@ -83,10 +84,13 @@ class DashdotdbSLO(DashdotdbBase):
                 continue
 
             LOG.info("%s syncing slo %s", self.logmarker, slo_name)
-            response = self._do_post(endpoint, payload)
             try:
+                response = self._do_post(endpoint, payload)
                 response.raise_for_status()
-            except requests.exceptions.HTTPError as details:
+            except (
+                requests.exceptions.HTTPError,
+                requests.exceptions.InvalidJSONError,
+            ) as details:
                 LOG.error("%s error posting %s - %s", self.logmarker, slo_name, details)
 
             LOG.info("%s slo %s synced", self.logmarker, slo_name)
@@ -96,10 +100,10 @@ class DashdotdbSLO(DashdotdbBase):
         LOG.debug("SLO: processing %s", slo_document.name)
         result: list[ServiceSLO] = []
         for namespace_access in slo_document.namespaces:
-            # TODO: APPSRE-8513 Dashdotdb SLO collector should deal with
-            # namespaceTargets. This `if` is a temporary workaround until
-            # APPSRE-8513 is implemented.
-            if namespace_access.slo_namespace:
+            if (
+                namespace_access.slo_namespace
+                and namespace_access.prometheus_access is None
+            ):
                 continue
 
             ns = namespace_access.namespace
@@ -108,12 +112,16 @@ class DashdotdbSLO(DashdotdbBase):
             password: str | None = None
             if namespace_access.prometheus_access:
                 promurl = namespace_access.prometheus_access.url
-                username = self.secret_reader.read_secret(
+                if (
                     namespace_access.prometheus_access.username
-                )
-                password = self.secret_reader.read_secret(
-                    namespace_access.prometheus_access.password
-                )
+                    and namespace_access.prometheus_access.password
+                ):
+                    username = self.secret_reader.read_secret(
+                        namespace_access.prometheus_access.username
+                    )
+                    password = self.secret_reader.read_secret(
+                        namespace_access.prometheus_access.password
+                    )
             else:
                 promurl = ns.cluster.prometheus_url
                 if not ns.cluster.automation_token:
@@ -128,13 +136,22 @@ class DashdotdbSLO(DashdotdbBase):
                 template = jinja2.Template(expr)
                 window = slo.slo_parameters.window
                 promquery = template.render({"window": window})
-                prom_response = self._promget(
-                    url=promurl,
-                    params={"query": (f"{promquery}")},
-                    token=promtoken,
-                    username=username,
-                    password=password,
-                )
+                try:
+                    prom_response = self._promget(
+                        url=promurl,
+                        params={"query": (f"{promquery}")},
+                        token=promtoken,
+                        username=username,
+                        password=password,
+                    )
+                except requests.exceptions.ConnectionError as error:
+                    # This can happen when prometheus is unreachable, or when running locally
+                    # and some prometheus URL are openshift service names. The trick is to run
+                    # with `oc port-forward` and update the local hosts file if we need to query those.
+                    LOG.error(
+                        f"{self.logmarker} Could not reach prometheus at {promurl}: {error}. Skipping {slo.name}"
+                    )
+                    raise
                 prom_result = prom_response["data"]["result"]
                 if not prom_result:
                     continue
@@ -144,6 +161,12 @@ class DashdotdbSLO(DashdotdbBase):
                     continue
 
                 slo_value = float(slo_value[1])
+                if isnan(slo_value):
+                    LOG.warning(
+                        f"{self.logmarker} Skipping SLO '{slo.name}' in SLO doc '{slo_document.name}'"
+                        "as the obtained value is not a number (maybe a division by 0?)"
+                    )
+                    continue
                 slo_target = float(slo.slo_target)
 
                 # In Dash.DB we want to always store SLOs in percentages

reconcile/gql_definitions/dashdotdb_slo/slo_documents_query.py

@@ -84,8 +84,8 @@ class ConfiguredBaseModel(BaseModel):
 
 class SLOExternalPrometheusAccessV1(ConfiguredBaseModel):
     url: str = Field(..., alias="url")
-    username: VaultSecret = Field(..., alias="username")
-    password: VaultSecret = Field(..., alias="password")
+    username: Optional[VaultSecret] = Field(..., alias="username")
+    password: Optional[VaultSecret] = Field(..., alias="password")
 
 
 class AppV1(ConfiguredBaseModel):