pytrilogy 0.0.3.47__py3-none-any.whl → 0.0.3.48__py3-none-any.whl

{pytrilogy-0.0.3.47.dist-info → pytrilogy-0.0.3.48.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pytrilogy
-Version: 0.0.3.47
+Version: 0.0.3.48
 Summary: Declarative, typed query language that compiles to SQL.
 Home-page: 
 Author: 
@@ -53,7 +53,7 @@ Installation: `pip install pytrilogy`
 
 You can read more about the project [here](https://trilogydata.dev/) and try out an interactive demo [here](https://trilogydata.dev/demo/). 
 
-Trilogy:
+Trilogy looks like SQL:
 ```sql
 WHERE 
     name like '%lvis%'
@@ -65,7 +65,7 @@ ORDER BY
 LIMIT 10;
 ```
 ## Goals
-vs SQL, the goals are:
+And aims to:
 
 Preserve:
 - Correctness
@@ -85,6 +85,7 @@ Maintain:
 Save the following code in a file named `hello.preql`
 
 ```python
+# semantic model is abstract from data
 key sentence_id int;
 property sentence_id.word_one string; # comments after a definition 
 property sentence_id.word_two string; # are syntactic sugar for adding
@@ -92,7 +93,8 @@ property sentence_id.word_three string; # a description to it
 
 # comments in other places are just comments
 
-# define our datasources as queries in duckdb
+# define our datasource to bind the model to data
+# testing using query fixtures is a common pattern
 datasource word_one(
     sentence: sentence_id,
     word:word_one
@@ -126,25 +128,20 @@ union all
 select 2 as sentence, '!'
 ''';
 
+def concat_with_space(x,y) -> x || ' ' || y;
+
 # an actual select statement
 # joins are automatically resolved between the 3 sources
 with sentences as
-select sentence_id, word_one || ' ' || word_two ||  word_three as text;
+select sentence_id, @concat_with_space(word_one, word_two) || word_three as text;
 
-SELECT
-    --sentences.sentence_id,
-    sentences.text
 WHERE 
-    sentences.sentence_id = 1
-;
-
+    sentences.sentence_id in (1,2)
 SELECT
-    --sentences.sentence_id,
     sentences.text
-WHERE 
-    sentences.sentence_id = 2
 ;
-# semicolon termination for all statements
+
+
 
 ```
 

{pytrilogy-0.0.3.47.dist-info → pytrilogy-0.0.3.48.dist-info}/RECORD

@@ -1,9 +1,9 @@
-pytrilogy-0.0.3.47.dist-info/licenses/LICENSE.md,sha256=5ZRvtTyCCFwz1THxDTjAu3Lidds9WjPvvzgVwPSYNDo,1042
-trilogy/__init__.py,sha256=SPFHWIHKOsEgt2qXg_bEpYrsQE1oX5pNjD1gj43FZW4,303
+pytrilogy-0.0.3.48.dist-info/licenses/LICENSE.md,sha256=5ZRvtTyCCFwz1THxDTjAu3Lidds9WjPvvzgVwPSYNDo,1042
+trilogy/__init__.py,sha256=X7jtGsMd3bHz73UVPQxZzoipqeTD3gI4UEQZtAq3OUs,303
 trilogy/compiler.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 trilogy/constants.py,sha256=5eQxk1A0pv-TQk3CCvgZCFA9_K-6nxrOm7E5Lxd7KIY,1652
 trilogy/engine.py,sha256=OK2RuqCIUId6yZ5hfF8J1nxGP0AJqHRZiafcowmW0xc,1728
-trilogy/executor.py,sha256=_xihzIaUEbE5lzwHECsvQ75Dm5fdRPBdMCVz6gNBpV4,16091
+trilogy/executor.py,sha256=GwNhP9UW4565dxnpHbw-VWNE2lX8uroQJQtSpC_j2pI,16298
 trilogy/parser.py,sha256=o4cfk3j3yhUFoiDKq9ZX_GjBF3dKhDjXEwb63rcBkBM,293
 trilogy/py.typed,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 trilogy/render.py,sha256=qQWwduymauOlB517UtM-VGbVe8Cswa4UJub5aGbSO6c,1512
@@ -19,19 +19,18 @@ trilogy/core/exceptions.py,sha256=JPYyBcit3T_pRtlHdtKSeVJkIyWUTozW2aaut25A2xI,67
 trilogy/core/functions.py,sha256=4fEOGgXWDvgrJtCg_5m2Y9iWnHfLbvLQ82RkIMl_1K0,27722
 trilogy/core/graph_models.py,sha256=z17EoO8oky2QOuO6E2aMWoVNKEVJFhLdsQZOhC4fNLU,2079
 trilogy/core/internal.py,sha256=iicDBlC6nM8d7e7jqzf_ZOmpUsW8yrr2AA8AqEiLx-s,1577
-trilogy/core/optimization.py,sha256=aihzx4-2-mSjx5td1TDTYGvc7e9Zvy-_xEyhPqLS-Ig,8314
-trilogy/core/query_processor.py,sha256=FFZlTzF9DBDH7dvpTDgd5SxDkE4EkING-MVtUgqx9gQ,19459
+trilogy/core/optimization.py,sha256=O7ag0IVQlJyWdAXBi_hHeU3Df5DRyd75Vlz6pks2J10,8197
+trilogy/core/query_processor.py,sha256=NNzYPKN5HzivQFXugSbJC_MaupkwOYii7A_vnXuBIK4,20063
 trilogy/core/models/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 trilogy/core/models/author.py,sha256=NhTKuk1eYAuYBbpvaFUxr-LntIoVarFQlNuNJwZmMmw,76990
-trilogy/core/models/build.py,sha256=fFPGyHIPzQU8DNOxkGQGC3_sbZt-MHP0o5ftSA67LtU,61962
+trilogy/core/models/build.py,sha256=MPiHgyfOumZ8zF3iB61pzrAeDAlGV2F9R0Dw7mTTyqQ,62708
 trilogy/core/models/build_environment.py,sha256=s_C9xAHuD3yZ26T15pWVBvoqvlp2LdZ8yjsv2_HdXLk,5363
 trilogy/core/models/core.py,sha256=wx6hJcFECMG-Ij972ADNkr-3nFXkYESr82ObPiC46_U,10875
 trilogy/core/models/datasource.py,sha256=6RjJUd2u4nYmEwFBpJlM9LbHVYDv8iHJxqiBMZqUrwI,9422
 trilogy/core/models/environment.py,sha256=AVSrvjNcNX535GhCPtYhCRY2Lp_Hj0tdY3VVt_kZb9Q,27260
-trilogy/core/models/execute.py,sha256=mQm5Gydo2Ph0W7w9wm5dQEarS04PC-IKAgNVsdqOZsQ,34524
-trilogy/core/optimizations/__init__.py,sha256=EBanqTXEzf1ZEYjAneIWoIcxtMDite5-n2dQ5xcfUtg,356
+trilogy/core/models/execute.py,sha256=m_GodtQkhuPo5kyBNlfC9c_jgprV7M64kE6x_12_ExQ,34616
+trilogy/core/optimizations/__init__.py,sha256=YH2-mGXZnVDnBcWVi8vTbrdw7Qs5TivG4h38rH3js_I,290
 trilogy/core/optimizations/base_optimization.py,sha256=gzDOKImoFn36k7XBD3ysEYDnbnb6vdVIztUfFQZsGnM,513
-trilogy/core/optimizations/inline_constant.py,sha256=lvNTIXaLNkw3HseJyXyDNk5R52doLU9sIg3pmU2_S08,1332
 trilogy/core/optimizations/inline_datasource.py,sha256=AHuTGh2x0GQ8usOe0NiFncfTFQ_KogdgDl4uucmhIbI,4241
 trilogy/core/optimizations/predicate_pushdown.py,sha256=g4AYE8Aw_iMlAh68TjNXGP754NTurrDduFECkUjoBnc,9399
 trilogy/core/processing/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -42,7 +41,7 @@ trilogy/core/processing/node_generators/__init__.py,sha256=o8rOFHPSo-s_59hREwXMW
 trilogy/core/processing/node_generators/basic_node.py,sha256=UVsXMn6jTjm_ofVFt218jAS11s4RV4zD781vP4im-GI,3371
 trilogy/core/processing/node_generators/common.py,sha256=nVeH_AdO58ygtNSO0wNgMR7_h2D0dFSGM_rh1fJd4Yc,9468
 trilogy/core/processing/node_generators/filter_node.py,sha256=JymSKzA-9oQAZ3ZtJRK9c3w5FXs8MjJBGWU9TYUqx4E,9099
-trilogy/core/processing/node_generators/group_node.py,sha256=kO-ersxIL04rZwX5-vFIFQQnp357PFo_7ZKXoGq3wyc,5989
+trilogy/core/processing/node_generators/group_node.py,sha256=ISv2lLnr5m5nMpiXYJbgBqfUPQqeypjCAcaool9Kvnk,6109
 trilogy/core/processing/node_generators/group_to_node.py,sha256=jKcNCDOY6fNblrdZwaRU0sbUSr9H0moQbAxrGgX6iGA,3832
 trilogy/core/processing/node_generators/multiselect_node.py,sha256=GWV5yLmKTe1yyPhN60RG1Rnrn4ktfn9lYYXi_FVU4UI,7061
 trilogy/core/processing/node_generators/node_merge_node.py,sha256=sv55oynfqgpHEpo1OEtVDri-5fywzPhDlR85qaWikvY,16195
@@ -70,9 +69,9 @@ trilogy/core/statements/build.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hS
 trilogy/core/statements/common.py,sha256=KxEmz2ySySyZ6CTPzn0fJl5NX2KOk1RPyuUSwWhnK1g,759
 trilogy/core/statements/execute.py,sha256=cSlvpHFOqpiZ89pPZ5GDp9Hu6j6uj-5_h21FWm_L-KM,1248
 trilogy/dialect/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-trilogy/dialect/base.py,sha256=kIwkNWWhMEIWDJ-6nr5bb2CJgbpKvJ9CxbhH4tYOFEc,41482
+trilogy/dialect/base.py,sha256=RkfNoNSo46p-WCafAWC5tXqJ_FMZEXANLyZSqX7_Pxw,42082
 trilogy/dialect/bigquery.py,sha256=7LcgPLDkeNBk6YTfaE-RBBi7SjWFV-jjuvZM1VMIXqk,3350
-trilogy/dialect/common.py,sha256=XjHkP8Dqezjkd2JU5xoAlMRS_6HNyXQCF4CykLK3C8o,5011
+trilogy/dialect/common.py,sha256=JQ8ONloalaWEXsTTWUhZcYyzMRaZ9HdUw7cN6QWtY5c,5295
 trilogy/dialect/config.py,sha256=olnyeVU5W5T6b9-dMeNAnvxuPlyc2uefb7FRME094Ec,3834
 trilogy/dialect/dataframe.py,sha256=RUbNgReEa9g3pL6H7fP9lPTrAij5pkqedpZ99D8_5AE,1522
 trilogy/dialect/duckdb.py,sha256=XTBK4RhE1_wF2_IA_7c2W5ih0uxZx0wZ1mfJ3YFIuso,3768
@@ -87,11 +86,11 @@ trilogy/hooks/graph_hook.py,sha256=c-vC-IXoJ_jDmKQjxQyIxyXPOuUcLIURB573gCsAfzQ,2
 trilogy/hooks/query_debugger.py,sha256=1npRjww94sPV5RRBBlLqMJRaFkH9vhEY6o828MeoEcw,5583
 trilogy/metadata/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 trilogy/parsing/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-trilogy/parsing/common.py,sha256=CCCkoRkFG9nxBI6u0lWt81JZvtBvXbTdiblvexOaeSY,29250
+trilogy/parsing/common.py,sha256=u7V8uc2mdBtszVujk-hzllfDAqM3j5pKd8B9UEj-uNc,29223
 trilogy/parsing/config.py,sha256=Z-DaefdKhPDmSXLgg5V4pebhSB0h590vI0_VtHnlukI,111
 trilogy/parsing/exceptions.py,sha256=Xwwsv2C9kSNv2q-HrrKC1f60JNHShXcCMzstTSEbiCw,154
 trilogy/parsing/helpers.py,sha256=AbpHGcgLb-kRsJGnwFEktk7uzpZOCcBY74-YBdrKVGs,1
-trilogy/parsing/parse_engine.py,sha256=m8t6De4q-PhqthMl7iIJsB7JdSQ-YYnBlLumTkLzw1Q,68652
+trilogy/parsing/parse_engine.py,sha256=K3TwjCiiZtG3UrICF9Alik56_KPusVNWfqE-oUaKfho,68664
 trilogy/parsing/render.py,sha256=hI4y-xjXrEXvHslY2l2TQ8ic0zAOpN41ADH37J2_FZY,19047
 trilogy/parsing/trilogy.lark,sha256=q15J3P71yA_4lsWjC1vb7eDTemkJGLPKYvf5Hn9IBIk,13584
 trilogy/scripts/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -102,8 +101,8 @@ trilogy/std/display.preql,sha256=2BbhvqR4rcltyAbOXAUo7SZ_yGFYZgFnurglHMbjW2g,40
 trilogy/std/geography.preql,sha256=-fqAGnBL6tR-UtT8DbSek3iMFg66ECR_B_41pODxv-k,504
 trilogy/std/money.preql,sha256=ZHW-csTX-kYbOLmKSO-TcGGgQ-_DMrUXy0BjfuJSFxM,80
 trilogy/std/report.preql,sha256=LbV-XlHdfw0jgnQ8pV7acG95xrd1-p65fVpiIc-S7W4,202
-pytrilogy-0.0.3.47.dist-info/METADATA,sha256=pWnJM7LvUZHAV5x2DH41DNeZHCo3lqmuEwmSPeWCeJQ,9100
-pytrilogy-0.0.3.47.dist-info/WHEEL,sha256=DnLRTWE75wApRYVsjgc6wsVswC54sMSJhAEd4xhDpBk,91
-pytrilogy-0.0.3.47.dist-info/entry_points.txt,sha256=ewBPU2vLnVexZVnB-NrVj-p3E-4vukg83Zk8A55Wp2w,56
-pytrilogy-0.0.3.47.dist-info/top_level.txt,sha256=cAy__NW_eMAa_yT9UnUNlZLFfxcg6eimUAZ184cdNiE,8
-pytrilogy-0.0.3.47.dist-info/RECORD,,
+pytrilogy-0.0.3.48.dist-info/METADATA,sha256=xuGEKV1ZdJtS-uES50q5bj5x-_60E4Pb6VL5G_SKzNQ,9095
+pytrilogy-0.0.3.48.dist-info/WHEEL,sha256=DnLRTWE75wApRYVsjgc6wsVswC54sMSJhAEd4xhDpBk,91
+pytrilogy-0.0.3.48.dist-info/entry_points.txt,sha256=ewBPU2vLnVexZVnB-NrVj-p3E-4vukg83Zk8A55Wp2w,56
+pytrilogy-0.0.3.48.dist-info/top_level.txt,sha256=cAy__NW_eMAa_yT9UnUNlZLFfxcg6eimUAZ184cdNiE,8
+pytrilogy-0.0.3.48.dist-info/RECORD,,

trilogy/__init__.py

@@ -4,6 +4,6 @@ from trilogy.dialect.enums import Dialects
 from trilogy.executor import Executor
 from trilogy.parser import parse
 
-__version__ = "0.0.3.47"
+__version__ = "0.0.3.48"
 
 __all__ = ["parse", "Executor", "Dialects", "Environment", "CONFIG"]

trilogy/core/models/build.py

@@ -247,6 +247,17 @@ def get_concept_arguments(expr) -> List["BuildConcept"]:
     return output
 
 
+class BuildParamaterizedConceptReference(BaseModel):
+    concept: BuildConcept
+
+    def __str__(self):
+        return f":{self.concept.address}"
+
+    @property
+    def safe_address(self) -> str:
+        return self.concept.safe_address
+
+
 class BuildGrain(BaseModel):
     components: set[str] = Field(default_factory=set)
     where_clause: Optional[BuildWhereClause] = None
@@ -1578,7 +1589,7 @@ class Factory:
 
         new = BuildFunction.model_construct(
             operator=base.operator,
-            arguments=[self.build(c) for c in raw_args],
+            arguments=[self.handle_constant(self.build(c)) for c in raw_args],
             output_datatype=base.output_datatype,
             output_purpose=base.output_purpose,
             valid_inputs=base.valid_inputs,
@@ -1615,6 +1626,8 @@ class Factory:
 
     @build.register
     def _(self, base: Concept) -> BuildConcept:
+
+        # TODO: if we are using parameters, wrap it in a new model and use that in rendering
         if base.address in self.local_concepts:
             return self.local_concepts[base.address]
         new_lineage, final_grain, _ = base.get_select_grain_and_keys(
@@ -1738,8 +1751,8 @@ class Factory:
     @build.register
     def _(self, base: Conditional) -> BuildConditional:
         return BuildConditional.model_construct(
-            left=(self.build(base.left)),
-            right=(self.build(base.right)),
+            left=self.handle_constant(self.build(base.left)),
+            right=self.handle_constant(self.build(base.right)),
             operator=base.operator,
         )
 
@@ -1767,8 +1780,8 @@ class Factory:
             right_c, _ = self.instantiate_concept(right)
             right = right_c  # type: ignore
         return BuildComparison.model_construct(
-            left=(self.build(left)),
-            right=(self.build(right)),
+            left=self.handle_constant(self.build(left)),
+            right=self.handle_constant(self.build(right)),
             operator=base.operator,
         )
 
@@ -2015,3 +2028,12 @@ class Factory:
                 factory.build(base.non_partial_for) if base.non_partial_for else None
             ),
         )
+
+    def handle_constant(self, base):
+        if (
+            isinstance(base, BuildConcept)
+            and isinstance(base.lineage, BuildFunction)
+            and base.lineage.operator == FunctionType.CONSTANT
+        ):
+            return BuildParamaterizedConceptReference(concept=base)
+        return base

trilogy/core/models/execute.py

@@ -24,6 +24,7 @@ from trilogy.core.models.build import (
     BuildFunction,
     BuildGrain,
     BuildOrderBy,
+    BuildParamaterizedConceptReference,
     BuildParenthetical,
     BuildRowsetItem,
     LooseBuildConceptList,
@@ -447,7 +448,7 @@ class CTEConceptPair(ConceptPair):
 
 
 class InstantiatedUnnestJoin(BaseModel):
-    concept_to_unnest: BuildConcept
+    object_to_unnest: BuildConcept | BuildParamaterizedConceptReference | BuildFunction
     alias: str = "unnest"
 
 

trilogy/core/optimization.py

@@ -5,7 +5,6 @@ from trilogy.core.models.build import (
 )
 from trilogy.core.models.execute import CTE, UnionCTE
 from trilogy.core.optimizations import (
-    InlineConstant,
     InlineDatasource,
     OptimizationRule,
     PredicatePushdown,
@@ -206,8 +205,6 @@ def optimize_ctes(
         REGISTERED_RULES.append(PredicatePushdown())
     if CONFIG.optimizations.predicate_pushdown:
         REGISTERED_RULES.append(PredicatePushdownRemove())
-    if CONFIG.optimizations.constant_inlining:
-        REGISTERED_RULES.append(InlineConstant())
     for rule in REGISTERED_RULES:
         loops = 0
         complete = False

trilogy/core/optimizations/__init__.py

@@ -1,11 +1,9 @@
 from .base_optimization import OptimizationRule
-from .inline_constant import InlineConstant
 from .inline_datasource import InlineDatasource
 from .predicate_pushdown import PredicatePushdown, PredicatePushdownRemove
 
 __all__ = [
     "OptimizationRule",
-    "InlineConstant",
     "InlineDatasource",
     "PredicatePushdown",
     "PredicatePushdownRemove",

trilogy/core/processing/node_generators/group_node.py

@@ -1,6 +1,7 @@
 from typing import List
 
 from trilogy.constants import logger
+from trilogy.core.internal import ALL_ROWS_CONCEPT
 from trilogy.core.models.build import (
     BuildAggregateWrapper,
     BuildConcept,
@@ -92,7 +93,9 @@ def gen_group_node(
         logger.info(
             f"{padding(depth)}{LOGGER_PREFIX} fetching group node parents {LooseBuildConceptList(concepts=parent_concepts)}"
         )
-        parent_concepts = unique(parent_concepts, "address")
+        parent_concepts = unique(
+            [x for x in parent_concepts if not x.name == ALL_ROWS_CONCEPT], "address"
+        )
         parent = source_concepts(
             mandatory_list=parent_concepts,
             environment=environment,

trilogy/core/query_processor.py

@@ -12,7 +12,9 @@ from trilogy.core.models.build import (
     BuildConcept,
     BuildConditional,
     BuildDatasource,
+    BuildFunction,
     BuildMultiSelectLineage,
+    BuildParamaterizedConceptReference,
     BuildSelectLineage,
     Factory,
 )
@@ -55,8 +57,14 @@ def base_join_to_join(
     """This function converts joins at the datasource level
     to joins at the CTE level"""
     if isinstance(base_join, UnnestJoin):
+        object_to_unnest = base_join.parent.arguments[0]
+        if not isinstance(
+            object_to_unnest,
+            (BuildConcept | BuildParamaterizedConceptReference | BuildFunction),
+        ):
+            raise ValueError(f"Unnest join must be a concept; got {object_to_unnest}")
         return InstantiatedUnnestJoin(
-            concept_to_unnest=base_join.parent.concept_arguments[0],
+            object_to_unnest=object_to_unnest,
             alias=base_join.alias,
         )
 
@@ -220,6 +228,8 @@ def resolve_cte_base_name_and_alias_v2(
     source_map: Dict[str, list[str]],
     raw_joins: List[Join | InstantiatedUnnestJoin],
 ) -> Tuple[str | None, str | None]:
+    if not source.datasources:
+        return None, None
     if (
         isinstance(source.datasources[0], BuildDatasource)
         and not source.datasources[0].name == CONSTANT_DATASET
@@ -301,18 +311,23 @@ def datasource_to_cte(
 
     else:
         # source is the first datasource of the query datasource
-        source = query_datasource.datasources[0]
-        # this is required to ensure that constant datasets
-        # render properly on initial access; since they have
-        # no actual source
-        if source.name == CONSTANT_DATASET:
-            source_map = {k: [] for k in query_datasource.source_map}
-            existence_map = source_map
+        if query_datasource.datasources:
+
+            source = query_datasource.datasources[0]
+            # this is required to ensure that constant datasets
+            # render properly on initial access; since they have
+            # no actual source
+            if source.name == CONSTANT_DATASET:
+                source_map = {k: [] for k in query_datasource.source_map}
+                existence_map = source_map
+            else:
+                source_map = {
+                    k: [] if not v else [source.safe_identifier]
+                    for k, v in query_datasource.source_map.items()
+                }
+                existence_map = source_map
         else:
-            source_map = {
-                k: [] if not v else [source.safe_identifier]
-                for k, v in query_datasource.source_map.items()
-            }
+            source_map = {k: [] for k in query_datasource.source_map}
             existence_map = source_map
 
     human_id = generate_cte_name(query_datasource.identifier, name_map)

trilogy/dialect/base.py

@@ -3,7 +3,13 @@ from typing import Any, Callable, Dict, List, Optional, Sequence, Union
 
 from jinja2 import Template
 
-from trilogy.constants import CONFIG, MagicConstants, Rendering, logger
+from trilogy.constants import (
+    CONFIG,
+    DEFAULT_NAMESPACE,
+    MagicConstants,
+    Rendering,
+    logger,
+)
 from trilogy.core.enums import (
     DatePart,
     FunctionType,
@@ -22,6 +28,7 @@ from trilogy.core.models.build import (
     BuildFunction,
     BuildMultiSelectLineage,
     BuildOrderItem,
+    BuildParamaterizedConceptReference,
     BuildParenthetical,
     BuildRowsetItem,
     BuildSubselectComparison,
@@ -513,6 +520,9 @@ class BaseDialect:
             BuildWindowItem,
             BuildFilterItem,
             BuildParenthetical,
+            BuildParamaterizedConceptReference,
+            BuildMultiSelectLineage,
+            BuildRowsetItem,
             str,
             int,
             list,
@@ -693,6 +703,14 @@ class BaseDialect:
             return self.render_expr(e.type, cte=cte, cte_map=cte_map)
         elif isinstance(e, ListType):
             return f"{self.COMPLEX_DATATYPE_MAP[DataType.LIST](self.render_expr(e.value_data_type, cte=cte, cte_map=cte_map))}"
+        elif isinstance(e, BuildParamaterizedConceptReference):
+            if self.rendering.parameters:
+                if e.concept.namespace == DEFAULT_NAMESPACE:
+                    return f":{e.concept.name}"
+                return f":{e.concept.address}"
+            elif e.concept.lineage:
+                return self.render_expr(e.concept.lineage, cte=cte, cte_map=cte_map)
+            return f"{self.QUOTE_CHARACTER}{e.concept.address}{self.QUOTE_CHARACTER}"
         else:
             raise ValueError(f"Unable to render type {type(e)} {e}")
 
@@ -744,12 +762,12 @@ class BaseDialect:
                     UnnestMode.CROSS_APPLY,
                 ):
 
-                    source = f"{render_unnest(self.UNNEST_MODE, self.QUOTE_CHARACTER, cte.join_derived_concepts[0], self.render_concept_sql, cte)}"
+                    source = f"{render_unnest(self.UNNEST_MODE, self.QUOTE_CHARACTER, cte.join_derived_concepts[0], self.render_expr, cte)}"
                 elif (
                     cte.join_derived_concepts
                     and self.UNNEST_MODE == UnnestMode.SNOWFLAKE
                 ):
-                    source = f"{render_unnest(self.UNNEST_MODE, self.QUOTE_CHARACTER, cte.join_derived_concepts[0], self.render_concept_sql, cte)}"
+                    source = f"{render_unnest(self.UNNEST_MODE, self.QUOTE_CHARACTER, cte.join_derived_concepts[0], self.render_expr, cte)}"
                 # direct - eg DUCK DB - can be directly selected inline
                 elif (
                     cte.join_derived_concepts and self.UNNEST_MODE == UnnestMode.DIRECT
@@ -803,7 +821,6 @@ class BaseDialect:
                         render_join(
                             join,
                             self.QUOTE_CHARACTER,
-                            self.render_concept_sql,
                             self.render_expr,
                             cte,
                             self.UNNEST_MODE,

trilogy/dialect/common.py

@@ -1,7 +1,11 @@
 from typing import Callable
 
 from trilogy.core.enums import Modifier, UnnestMode
-from trilogy.core.models.build import BuildConcept, BuildFunction
+from trilogy.core.models.build import (
+    BuildConcept,
+    BuildFunction,
+    BuildParamaterizedConceptReference,
+)
 from trilogy.core.models.datasource import RawColumnExpr
 from trilogy.core.models.execute import (
     CTE,
@@ -19,21 +23,27 @@ def null_wrapper(lval: str, rval: str, modifiers: list[Modifier]) -> str:
 def render_unnest(
     unnest_mode: UnnestMode,
     quote_character: str,
-    concept: BuildConcept,
-    render_func: Callable[[BuildConcept, CTE, bool], str],
+    concept: BuildConcept | BuildParamaterizedConceptReference | BuildFunction,
+    render_func: Callable[
+        [BuildConcept | BuildParamaterizedConceptReference | BuildFunction, CTE], str
+    ],
     cte: CTE,
 ):
+    if not isinstance(concept, (BuildConcept, BuildParamaterizedConceptReference)):
+        address = "anon_function"
+    else:
+        address = concept.safe_address
     if unnest_mode == UnnestMode.CROSS_JOIN:
-        return f"{render_func(concept, cte, False)} as {quote_character}{concept.safe_address}{quote_character}"
+        return f"{render_func(concept, cte)} as {quote_character}{address}{quote_character}"
     elif unnest_mode == UnnestMode.CROSS_JOIN_ALIAS:
-        return f"{render_func(concept, cte, False)} as unnest_wrapper ({quote_character}{concept.safe_address}{quote_character})"
+        return f"{render_func(concept, cte)} as unnest_wrapper ({quote_character}{address}{quote_character})"
     elif unnest_mode == UnnestMode.SNOWFLAKE:
         # if we don't actually have a join, we're directly unnesting a concept, and we can skip the flatten
         if not cte.render_from_clause:
-            return f"{render_func(concept, cte, False)} as unnest_wrapper ( unnest1, unnest2, unnest3, unnest4, {quote_character}{cte.join_derived_concepts[0].safe_address}{quote_character})"
+            return f"{render_func(concept, cte)} as unnest_wrapper ( unnest1, unnest2, unnest3, unnest4, {quote_character}{cte.join_derived_concepts[0].safe_address}{quote_character})"
         # otherwise, flatten the concept for the join
-        return f"flatten({render_func(concept, cte, False)}) as unnest_wrapper ( unnest1, unnest2, unnest3, unnest4, {quote_character}{cte.join_derived_concepts[0].safe_address}{quote_character})"
-    return f"{render_func(concept, cte, False)} as {quote_character}{concept.safe_address}{quote_character}"
+        return f"flatten({render_func(concept, cte)}) as unnest_wrapper ( unnest1, unnest2, unnest3, unnest4, {quote_character}{cte.join_derived_concepts[0].safe_address}{quote_character})"
+    return f"{render_func(concept, cte)} as {quote_character}{address}{quote_character}"
 
 
 def render_join_concept(
@@ -60,8 +70,9 @@ def render_join_concept(
 def render_join(
     join: Join | InstantiatedUnnestJoin,
     quote_character: str,
-    render_func: Callable[[BuildConcept, CTE, bool], str],
-    render_expr_func: Callable[[BuildConcept, CTE], str],
+    render_expr_func: Callable[
+        [BuildConcept | BuildParamaterizedConceptReference | BuildFunction, CTE], str
+    ],
     cte: CTE,
     unnest_mode: UnnestMode = UnnestMode.CROSS_APPLY,
 ) -> str | None:
@@ -72,12 +83,12 @@ def render_join(
         if not cte:
             raise ValueError("must provide a cte to build an unnest joins")
         if unnest_mode == UnnestMode.CROSS_JOIN:
-            return f"CROSS JOIN {render_unnest(unnest_mode, quote_character, join.concept_to_unnest, render_func, cte)}"
+            return f"CROSS JOIN {render_unnest(unnest_mode, quote_character, join.object_to_unnest, render_expr_func, cte)}"
         if unnest_mode == UnnestMode.CROSS_JOIN_ALIAS:
-            return f"CROSS JOIN {render_unnest(unnest_mode, quote_character, join.concept_to_unnest, render_func, cte)}"
+            return f"CROSS JOIN {render_unnest(unnest_mode, quote_character, join.object_to_unnest, render_expr_func, cte)}"
         if unnest_mode == UnnestMode.SNOWFLAKE:
-            return f"LEFT JOIN LATERAL {render_unnest(unnest_mode, quote_character, join.concept_to_unnest, render_func, cte)}"
-        return f"FULL JOIN {render_unnest(unnest_mode, quote_character, join.concept_to_unnest, render_func, cte)}"
+            return f"LEFT JOIN LATERAL {render_unnest(unnest_mode, quote_character, join.object_to_unnest, render_expr_func, cte)}"
+        return f"FULL JOIN {render_unnest(unnest_mode, quote_character, join.object_to_unnest, render_expr_func, cte)}"
     # left_name = join.left_name
     right_name = join.right_name
     if cte.quote_address.get(join.right_name, False):

trilogy/executor.py

@@ -394,6 +394,9 @@ class Executor(object):
             if isinstance(rval, ListWrapper):
                 return [x for x in rval]
             if isinstance(rval, MapWrapper):
+                # duckdb expects maps in this format as variables
+                if self.dialect == Dialects.DUCK_DB:
+                    return {"key": [x for x in rval], "value": [rval[x] for x in rval]}
                 return {k: v for k, v in rval.items()}
             # if isinstance(rval, ConceptRef):
             #     return self._concept_to_value(self.environment.concepts[rval.address], local_concepts=local_concepts)

trilogy/parsing/common.py

@@ -211,7 +211,6 @@ def atom_is_relevant(
 
     if isinstance(atom, Function):
         relevant = False
-        print("atom args")
         for arg in atom.arguments:
             relevant = relevant or atom_is_relevant(arg, others, environment)
         return relevant

trilogy/parsing/parse_engine.py

@@ -1795,7 +1795,7 @@ class ParseToObjects(Transformer):
     def fyear(self, meta, args):
         return self.function_factory.create_function(args, FunctionType.YEAR, meta)
 
-    def internal_fcast(self, meta, args):
+    def internal_fcast(self, meta, args) -> Function:
         args = process_function_args(args, meta=meta, environment=self.environment)
         if isinstance(args[0], str):
             processed: date | datetime | int | float | bool | str

trilogy/core/optimizations/inline_constant.py

@@ -1,35 +0,0 @@
-from trilogy.core.enums import Derivation
-from trilogy.core.models.build import BuildConcept
-from trilogy.core.models.execute import (
-    CTE,
-    UnionCTE,
-)
-from trilogy.core.optimizations.base_optimization import OptimizationRule
-
-
-class InlineConstant(OptimizationRule):
-    def optimize(
-        self, cte: CTE | UnionCTE, inverse_map: dict[str, list[CTE | UnionCTE]]
-    ) -> bool:
-        if isinstance(cte, UnionCTE):
-            return any(self.optimize(x, inverse_map) for x in cte.internal_ctes)
-
-        to_inline: list[BuildConcept] = []
-        for x in cte.source.input_concepts:
-            if x.address not in cte.source_map:
-                continue
-            if x.derivation == Derivation.CONSTANT:
-                self.log(f"Found constant {x.address} on {cte.name}")
-                to_inline.append(x)
-        if to_inline:
-            inlined = False
-            for c in to_inline:
-                self.log(f"Attempting to inline constant {c.address} on {cte.name}")
-                test = cte.inline_constant(c)
-                if test:
-                    self.log(f"Successfully inlined constant {c.address} to {cte.name}")
-                    inlined = True
-                else:
-                    self.log(f"Could not inline constant to {cte.name}")
-            return inlined
-        return False