python-mobius 0.10.0__py3-none-any.whl → 0.10.1__py3-none-any.whl

mobius/__init__.py

@@ -87,7 +87,7 @@ from .mob import (
     MAX_PUMP_PRIMITIVE_SIZE,
 )
 
-__version__ = "0.10.0"
+__version__ = "0.10.1"
 
 __all__ = [
     "__version__",

mobius/device.py

@@ -169,26 +169,18 @@ def _schedule_checksum_attr(which: int) -> C2Attribute:
     return C2Attribute.Schedule1Checksum if which == 1 else C2Attribute.Schedule2Checksum
 
 
-def _configuration_requests(
+def _configuration_checksum_requests(
     configuration: tuple, cache: Optional[ConfigurationCache], supported_attribute_ids: set,
-) -> tuple[list, set]:
-    """
-    Poll requests for each (data attribute, checksum attribute) of
-    `configuration`: the checksum alone when `cache` holds the data, else
-    the data (plus the checksum, to store with it). Returns (requests,
-    data attributes requested).
-    """
-    requests, data_read = [], set()
-    for data_attr, checksum_attr in configuration:
-        checksum_usable = cache is not None and checksum_attr in supported_attribute_ids
-        if checksum_usable and data_attr in cache.entries:
-            requests.append((checksum_attr, 0, 1))
-            continue
-        requests.append((data_attr, 0, ALL_ELEMENTS))
-        data_read.add(data_attr)
-        if checksum_usable:
-            requests.append((checksum_attr, 0, 1))
-    return requests, data_read
+) -> list:
+    """The checksum request of each (data attribute, checksum attribute) of
+    `configuration` that the cache can use. The data itself is never part
+    of the poll batch (see _read_configuration())."""
+    if cache is None:
+        return []
+    return [
+        (checksum_attr, 0, 1) for _data_attr, checksum_attr in configuration
+        if checksum_attr in supported_attribute_ids
+    ]
 
 
 def _apply_static_cache(cache: ConfigurationCache, by_attr_id: dict, static_read: bool) -> None:
@@ -2506,10 +2498,12 @@ class MobiusDevice:
         get_device_info(), get_metadata_batch() and
         get_light_poll_batch() or get_pump_schedule()/get_pump_telemetry().
 
-        `cache` (one per device, kept by the caller): ConfiguredScenes and
-        the schedule are then read only when their checksum changed since
-        the previous poll (see ConfigurationCache); a changed checksum
-        costs a second, smaller request. With its static_refresh_interval
+        The schedule and ConfiguredScenes are read in requests of their
+        own after the batch, as the app does: combined with the rest, a
+        light's reply is too large to be relayed. `cache` (one per device,
+        kept by the caller): they are then read only when their checksum,
+        part of the batch, changed since the previous poll (see
+        ConfigurationCache). With its static_refresh_interval
         set, the STATIC_POLL_ATTRIBUTES are also read only that often.
         Used by the batched path only.
         """
@@ -2537,7 +2531,7 @@ class MobiusDevice:
             (schedule_attr, _schedule_checksum_attr(which)),
             (C2Attribute.ConfiguredScenes, C2Attribute.ConfiguredScenesChecksum),
         )
-        configuration_requests, data_read = _configuration_requests(configuration, cache, supported_attribute_ids)
+        configuration_requests = _configuration_checksum_requests(configuration, cache, supported_attribute_ids)
         if cache is not None:
             configuration_requests.append((C2Attribute.SupportedAttributesCRC, 0, 1))
         requests = _DEVICE_INFO_REQUESTS + _METADATA_REQUESTS + configuration_requests + [
@@ -2558,9 +2552,7 @@ class MobiusDevice:
             )
             if attribute_table_changed:
                 cache.invalidate_static()
-            data_read |= await self._apply_configuration_cache(
-                by_attr_id, cache, configuration, data_read, supported_attribute_ids,
-            )
+        data_read = await self._read_configuration(by_attr_id, cache, configuration, supported_attribute_ids)
 
         def first(attr_id, index=0):
             return _first_value(by_attr_id, attr_id, index)
@@ -2621,38 +2613,44 @@ class MobiusDevice:
             static_read=static_read,
         )
 
-    async def _apply_configuration_cache(
-        self, by_attr_id: dict, cache: ConfigurationCache,
-        configuration: tuple, data_read: set, supported_attribute_ids: set,
+    async def _read_configuration(
+        self, by_attr_id: dict, cache: Optional[ConfigurationCache],
+        configuration: tuple, supported_attribute_ids: set,
     ) -> set:
         """
-        After the poll batch: stores data read with its checksum, fills in
-        cached data whose checksum is unchanged, and reads the rest in a
-        second batch. Returns the attributes read by that second batch.
+        Fills each data attribute of `configuration` (the schedule, the
+        scenes) into `by_attr_id`: from `cache` when the checksum in the
+        poll batch matches the cached one, else with a request of its own
+        (plus its checksum, stored in the cache with it). Returns the
+        attributes read.
+
+        Each gets its own request, as in the app: a light's schedule or
+        scenes alone are close to the largest reply a relay carries, and
+        together with the rest of the poll a relayed reply is too large
+        and never arrives.
         """
-        stale = []
+        read = set()
         for data_attr, checksum_attr in configuration:
-            if data_attr not in supported_attribute_ids or checksum_attr not in supported_attribute_ids:
-                continue
-            reported = _unpack(_first_value(by_attr_id, checksum_attr), "<H")
-            if data_attr in data_read:
-                _store_configuration(cache, data_attr, reported, by_attr_id)
+            if data_attr not in supported_attribute_ids:
                 continue
-            cached = cache.entries.get(data_attr)
-            if cached is not None and reported is not None and reported == cached[0]:
-                by_attr_id[data_attr] = cached[1]
-            else:
-                stale.append((data_attr, checksum_attr))
-        if not stale:
-            return set()
-        second = await self._read_supported_batch(
-            [r for data_attr, checksum_attr in stale for r in ((data_attr, 0, ALL_ELEMENTS), (checksum_attr, 0, 1))],
-            supported_attribute_ids,
-        )
-        for data_attr, checksum_attr in stale:
-            by_attr_id[data_attr] = second.get(data_attr, [])
-            _store_configuration(cache, data_attr, _unpack(_first_value(second, checksum_attr), "<H"), second)
-        return {data_attr for data_attr, _checksum_attr in stale}
+            checksum_usable = cache is not None and checksum_attr in supported_attribute_ids
+            if checksum_usable:
+                reported = _unpack(_first_value(by_attr_id, checksum_attr), "<H")
+                cached = cache.entries.get(data_attr)
+                if cached is not None and reported is not None and reported == cached[0]:
+                    by_attr_id[data_attr] = cached[1]
+                    continue
+            requests = [(data_attr, 0, ALL_ELEMENTS)]
+            if checksum_usable:
+                requests.append((checksum_attr, 0, 1))
+            response = await self._read_supported_batch(requests, supported_attribute_ids)
+            by_attr_id[data_attr] = response.get(int(data_attr), [])
+            if checksum_usable:
+                _store_configuration(
+                    cache, data_attr, _unpack(_first_value(response, checksum_attr), "<H"), response,
+                )
+            read.add(data_attr)
+        return read
 
     async def _get_full_poll_via_individual_reads(
         self, primitive: PrimitiveType, model: Optional[Model],

{python_mobius-0.10.0.dist-info → python_mobius-0.10.1.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: python-mobius
-Version: 0.10.0
+Version: 0.10.1
 Summary: Reverse-engineered Python client for the Mobius BLE protocol (EcoTech Marine VorTech/Radion, AquaIllumination, Neptune Systems, NYOS)
 Project-URL: Homepage, https://code.r3pek.org/r3pek/python-mobius
 Project-URL: Documentation, https://code.r3pek.org/r3pek/python-mobius/src/branch/main/documentation

{python_mobius-0.10.0.dist-info → python_mobius-0.10.1.dist-info}/RECORD

@@ -1,10 +1,10 @@
-mobius/__init__.py,sha256=4KhKL5RgHdYk77_OmINsr2YiWa1N1fTpDL4EI6J_3EY,8555
+mobius/__init__.py,sha256=eObxukBi0TREh8e0TD74L5CzOxSma-dPaj9YAB_8QAc,8555
 mobius/checksums.py,sha256=PB9RqvaZu9AqfT6tU6NI2qbbZXrqaHUnow3Qi_6UFHs,5191
 mobius/cli.py,sha256=tyft0SzbuLgbmzps-Ym1hCzcr6A9D5MsALkg6o4ynBs,57876
 mobius/coap.py,sha256=-XV3kI4q-JoL8r0oLFNnHAdZAc_yUP-aICagKh-qbf4,4862
 mobius/constants.py,sha256=pcG9Su_b81pmMA_GxR41lZz9UM9BjtV0T6nuslMICko,41138
 mobius/crc.py,sha256=LOCHZe3a1UnR5thdpZ4S4SFP8BdmoMEnhDNiNMd0iJI,2508
-mobius/device.py,sha256=2WPsm-aJJdIDeypo_MQ6rpgI1NTljcOUC4lt04eISbQ,131678
+mobius/device.py,sha256=tY4vSTiqHExwgfxQA2Z8FOGWS5RMUn1Zq6HAp0mdk-E,131600
 mobius/device_status.py,sha256=XclYijAknrgT8SdSW4XvyBemWHUQqw6UPE4tmwq6Yug,15658
 mobius/discovery.py,sha256=poNeXGekB44cpHOFbGyps9d4mwW_hJptmJODwSMTUSg,7176
 mobius/dump.py,sha256=eQBYoi8J6CxRd2ojgWK5QoB8z416oywLRTBnnh0pLwo,9253
@@ -19,8 +19,8 @@ mobius/relay.py,sha256=trGkWQSarwURF05gXHeb5jTJ9UvWbQGu8NarEP6sRqE,10107
 mobius/scenes.py,sha256=VLfDdTKSv3qTsBt2bJGg8iPtUkfNEmNgu0TTtYT6jJE,4274
 mobius/schedule.py,sha256=si9uJdYOj5vh6owuxxMyMyZRY0-tAmCPt3s6ROAeRww,13243
 mobius/timezone.py,sha256=Q7oPKtCdEYcEHXLx4lt-VPq6KH-MNgQwVnDtIXJV-kQ,2267
-python_mobius-0.10.0.dist-info/METADATA,sha256=fGt7VhAS5SQAA7lmw5E90nBAnbQMscCgT5WHOB6fLtg,5829
-python_mobius-0.10.0.dist-info/WHEEL,sha256=W3fkpkm7-wf9vBI5Z-7s0eWkeM-spu78I8Neb98DeEg,87
-python_mobius-0.10.0.dist-info/entry_points.txt,sha256=Q2hlcek-bWm70zvd12v32essflPgC2su-dKDHAqbPoE,48
-python_mobius-0.10.0.dist-info/licenses/LICENSE,sha256=7a72Msu2Q-TnoiFxemxEGkwafJGObk1W3rw9hzmyM_Y,17984
-python_mobius-0.10.0.dist-info/RECORD,,
+python_mobius-0.10.1.dist-info/METADATA,sha256=B1lQHhsAB0OH_ViOqQChhl4_zJ1o496C73dFM8Cc8t4,5829
+python_mobius-0.10.1.dist-info/WHEEL,sha256=W3fkpkm7-wf9vBI5Z-7s0eWkeM-spu78I8Neb98DeEg,87
+python_mobius-0.10.1.dist-info/entry_points.txt,sha256=Q2hlcek-bWm70zvd12v32essflPgC2su-dKDHAqbPoE,48
+python_mobius-0.10.1.dist-info/licenses/LICENSE,sha256=7a72Msu2Q-TnoiFxemxEGkwafJGObk1W3rw9hzmyM_Y,17984
+python_mobius-0.10.1.dist-info/RECORD,,