python-general-be-lib 0.12.0__py3-none-any.whl → 0.12.1__py3-none-any.whl

general/interface/repository/crud_repository.py

@@ -169,14 +169,23 @@ class CrudRepository[Entity: Base | Type[Base]]:
         return _reduced_model(self.entity, frozenset(selected_columns))
 
     def _handle_exception(self, session: Session, e: Exception):
-        """Close the session, log the error and raise an HTTP-friendly exception.
+        """Roll back and close the session, log the error and raise an HTTP-friendly exception.
 
         An ``OperationalError`` becomes a ``ServiceUnavailableException``, a
         ``NoResultFound`` an ``EntityNotFoundException``, a ``DataError`` or an
         ``IntegrityError`` a ``BadRequestException``; any other exception is re-raised as is.
 
+        ``close`` alone already rolls back the database transaction. What the explicit
+        ``rollback`` adds is the expiry of the ORM instances: an entity still held by the
+        caller raises ``DetachedInstanceError`` on access instead of exposing values that
+        were flushed but never committed. It runs on every error, a failed SELECT included,
+        since on PostgreSQL that aborts the transaction as well. An external session is
+        rolled back and closed too, so the caller's transaction is lost. A failure of the
+        rollback itself is logged and does not replace ``e``, and the session is closed
+        anyway.
+
         Args:
-            session (Session): Session to close.
+            session (Session): Session to roll back and close.
             e (Exception): Caught exception to handle.
 
         Raises:
@@ -184,6 +193,11 @@ class CrudRepository[Entity: Base | Type[Base]]:
             EntityNotFoundException: If no record matches.
             BadRequestException: If the data is malformed or violates a constraint.
         """
+        try:
+            session.rollback()
+        except Exception:
+            # un rollback fallito non deve sostituire l'errore originale, né saltare la close
+            logging.exception("Rollback failed")
         session.close()
         logging.error(e)
         raise_http_exception(e)
@@ -195,12 +209,13 @@ class CrudRepository[Entity: Base | Type[Base]]:
             session (Session): Session to commit.
 
         Raises:
-            ServiceUnavailableException | BadRequestException: On error during the commit.
+            ServiceUnavailableException | BadRequestException: On error during the commit,
+                after rolling back and closing the session.
         """
         try:
             session.commit()
         except Exception as e:
-            self._handle_exception(session, e)
+            self._handle_exception(session=session, e=e)
 
     def _flush(self, session: Session):
         """Flush the session, handling the possible exceptions.
@@ -214,12 +229,13 @@ class CrudRepository[Entity: Base | Type[Base]]:
             session (Session): Session to flush.
 
         Raises:
-            ServiceUnavailableException | BadRequestException: On error during the flush.
+            ServiceUnavailableException | BadRequestException: On error during the flush,
+                after rolling back and closing the session.
         """
         try:
             session.flush()
         except Exception as e:
-            self._handle_exception(session, e)
+            self._handle_exception(session=session, e=e)
 
     def _entity_has_columns(self, *columns: str, entity: Type[Base] | Base = None) -> bool:
         """Check that every given name is a column of the entity.
@@ -441,7 +457,7 @@ class CrudRepository[Entity: Base | Type[Base]]:
             try:
                 entity = session.get(self.entity, values)
             except Exception as e:
-                self._handle_exception(session, e)
+                self._handle_exception(session=session, e=e)
             else:
                 return [entity] if entity is not None else []
 
@@ -607,7 +623,7 @@ class CrudRepository[Entity: Base | Type[Base]]:
         try:
             session.add_all(entities)
         except Exception as e:
-            self._handle_exception(session, e)
+            self._handle_exception(session=session, e=e)
         return self._return(session=session, entities=entities, keep_open=keep_open, commit=True, parsing_model=parsing_model)
 
     def update(self, session: Session = None, where: dict[str, Any] = None, returning: bool = True, parsing_model: Type[BaseModel] | BaseModel = None, **kwargs) -> list[Entity] | list[BaseModel]:
@@ -1049,9 +1065,9 @@ class CrudRepository[Entity: Base | Type[Base]]:
         """Execute a SQLAlchemy statement and return the result as it is.
 
         The method owns the error handling and nothing else: every exception goes to
-        ``_handle_exception``, which closes the session and maps the error to an HTTP
-        status. Reading the result is left to the caller, which is the only one knowing the
-        shape it needs — ``.scalars().all()`` for entities, ``.scalar()`` for an aggregate,
+        ``_handle_exception``, which rolls back and closes the session and maps the error
+        to an HTTP status. Reading the result is left to the caller, which is the only one
+        knowing the shape it needs — ``.scalars().all()`` for entities, ``.scalar()`` for an aggregate,
         ``.all()`` for the multi-column rows of a statement built with ``add_columns``,
         ``.rowcount`` for a DML without ``RETURNING``. The result is bound to the session,
         so it has to be consumed before the session is closed. ``Session.execute`` returns
@@ -1076,6 +1092,6 @@ class CrudRepository[Entity: Base | Type[Base]]:
         try:
             result = session.execute(statement=stmt, params=values)
         except Exception as e:
-            self._handle_exception(session, e)
+            self._handle_exception(session=session, e=e)
         else:
             return result

{python_general_be_lib-0.12.0.dist-info → python_general_be_lib-0.12.1.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: python-general-be-lib
-Version: 0.12.0
+Version: 0.12.1
 Summary: General purpose backend library — SQLAlchemy CRUD/Geometry repositories, FastAPI exceptions, Pydantic base models, Keycloak JWT auth, logger utilities.
 Author-email: Andrea Di Placido <a.diplacido@arpes.it>, "Arpes S.r.l." <it.admin@arpes.it>
 License: MIT

{python_general_be_lib-0.12.0.dist-info → python_general_be_lib-0.12.1.dist-info}/RECORD

@@ -24,7 +24,7 @@ general/interface/mixin/audit_mixin.py,sha256=N2JDD9JxXDMeBqu0yAlhVWFOK3EeUA2b21
 general/interface/mixin/softdelete_mixin.py,sha256=526luzM4DBCorcq99kZ6BYqtQKKJCpnxX9rSEigfyIU,2148
 general/interface/mixin/timestamp_mixin.py,sha256=wmcIx2Y8jgVqg9A-1E61BvkcKCo52ZjKNHeKfXJmUl0,2220
 general/interface/repository/__init__.py,sha256=QQD6okLfRozC0uOZPGrwOUDKJyZTgpObvwJ3OOSJdbM,1813
-general/interface/repository/crud_repository.py,sha256=Hr7APBsN1uFqEfM78ZSIcgheg4ilvND4OMc7TBNOlcw,55962
+general/interface/repository/crud_repository.py,sha256=Z7IgLz7dtfIyzZMJO7T_IDunHH1qTDYRApdWlbMkE2A,57031
 general/interface/repository/geometry_repository.py,sha256=Fmv0qhfqumnU5fiETMMAmiB0UyG43b19jlPXQ8cJ9CU,11289
 general/interface/repository/many_to_many_repository.py,sha256=KRJ2SMUGDYNoGV-ea541wlWg0FW4NQ_Ry85aJBarmC8,11183
 general/interface/repository/view_repository.py,sha256=wxDGw7kenuVrDd9nfh7-omw2m9Jex5WzF_lhEiqPoA0,7902
@@ -40,8 +40,8 @@ general/interface/repository/handler/soft_delete_handler.py,sha256=1WD1n6q5plyJ0
 general/interface/repository/handler/statement_manager.py,sha256=JSj6K-iQJ06kLdsMTOqK62cIvR87ioOA1LmLTGpqrB0,8205
 general/utils/__init__.py,sha256=_SPe88reIZ0JxwK7mp-u_p-9c4hCcZ-daUihi0gymNk,103
 general/utils/consts.py,sha256=nE75Ud7sVuDw9K_xmIJNjL_5f_BVJmwGNPGFYc26H3Y,264
-python_general_be_lib-0.12.0.dist-info/licenses/LICENSE,sha256=iUaO1XZyB9P3Tmog0OILuTisP6vXGe3QKz-4yRTxOFk,1069
-python_general_be_lib-0.12.0.dist-info/METADATA,sha256=5RrV-gffYJqAwx09wHOCqK-xN7GDSqK7dKgeP7Rfcyk,3995
-python_general_be_lib-0.12.0.dist-info/WHEEL,sha256=YVMoNqKzERt-wjUZwJ33xBGAwnFl-4cqbYkTtWa4itE,91
-python_general_be_lib-0.12.0.dist-info/top_level.txt,sha256=tTZePW8_CNUqSgKFd2SEH72ZbnhS0OYjRsgcv0ikSFY,8
-python_general_be_lib-0.12.0.dist-info/RECORD,,
+python_general_be_lib-0.12.1.dist-info/licenses/LICENSE,sha256=iUaO1XZyB9P3Tmog0OILuTisP6vXGe3QKz-4yRTxOFk,1069
+python_general_be_lib-0.12.1.dist-info/METADATA,sha256=8T5p8u9J9MUHT1xZjRf_Ss29Y97hEeJX5wZD71aVTyI,3995
+python_general_be_lib-0.12.1.dist-info/WHEEL,sha256=mOdXR9C3wMVov7cSY8PY-XCzo3SmmWCHvGQr5csJoao,91
+python_general_be_lib-0.12.1.dist-info/top_level.txt,sha256=tTZePW8_CNUqSgKFd2SEH72ZbnhS0OYjRsgcv0ikSFY,8
+python_general_be_lib-0.12.1.dist-info/RECORD,,

{python_general_be_lib-0.12.0.dist-info → python_general_be_lib-0.12.1.dist-info}/WHEEL

@@ -1,5 +1,5 @@
 Wheel-Version: 1.0
-Generator: setuptools (84.0.0)
+Generator: setuptools (84.2.1)
 Root-Is-Purelib: true
 Tag: py3-none-any