pyedb 0.57.0__py3-none-any.whl → 0.58.0__py3-none-any.whl

pyedb/generic/general_methods.py

@@ -50,13 +50,9 @@ is_linux = os.name == "posix"
 is_windows = not is_linux
 _pythonver = sys.version_info[0]
 
+import xml.etree.cElementTree as ET  # nosec B405
 
-try:
-    import xml.etree.cElementTree as ET
-
-    ET.VERSION
-except ImportError:
-    ET = None
+ET.VERSION
 
 
 class GrpcApiError(Exception):
@@ -694,13 +690,9 @@ def read_csv_pandas(filename, encoding="utf-8"):  # pragma: no cover
     :class:`pandas.DataFrame`
 
     """
-    try:
-        import pandas as pd
+    import pandas as pd
 
-        return pd.read_csv(filename, encoding=encoding, header=0, na_values=".")
-    except ImportError:
-        logging.error("Pandas is not available. Install it.")
-        return None
+    return pd.read_csv(filename, encoding=encoding, header=0, na_values=".")
 
 
 def read_tab(filename):  # pragma: no cover
@@ -734,14 +726,10 @@ def read_xlsx(filename):  # pragma: no cover
     list
 
     """
-    try:
-        import pandas as pd
+    import pandas as pd
 
-        lines = pd.read_excel(filename)
-        return lines
-    except ImportError:
-        lines = []
-        return lines
+    lines = pd.read_excel(filename)
+    return lines
 
 
 def write_csv(output, list_data, delimiter=",", quotechar="|", quoting=csv.QUOTE_MINIMAL):  # pragma: no cover
@@ -871,11 +859,7 @@ def compute_fft(time_vals, value):  # pragma: no cover
     tuple
         Frequency and Values.
     """
-    try:
-        import numpy as np
-    except ImportError:
-        logging.error("NumPy is not available. Install it.")
-        return False
+    import numpy as np
 
     deltaT = time_vals[-1] - time_vals[0]
     num_points = len(time_vals)
@@ -924,11 +908,8 @@ def parse_excitation_file(
     tuple
         Frequency, magnitude and phase.
     """
-    try:
-        import numpy as np
-    except ImportError:
-        logging.error("NumPy is not available. Install it.")
-        return False
+    import numpy as np
+
     df = read_csv_pandas(file_name, encoding=encoding)
     if is_time_domain:
         time = df[df.keys()[0]].values * x_scale
@@ -1165,6 +1146,11 @@ def install_with_pip(package_name, package_path=None, upgrade=False, uninstall=F
     """Install a new package using pip.
     This method is useful for installing a package from the AEDT Console without launching the Python environment.
 
+    .. warning::
+        Do not execute this function with untrusted function argument, environment
+        variables or pyedb global settings.
+        See the :ref:`security guide<ref_security_consideration>` for details.
+
     Parameters
     ----------
     package_name : str
@@ -1177,10 +1163,12 @@ def install_with_pip(package_name, package_path=None, upgrade=False, uninstall=F
         Whether to install the package or uninstall the package.
     """
 
-    import subprocess
+    import subprocess  # nosec B404
 
-    executable = '"{}"'.format(sys.executable) if is_windows else sys.executable
+    if not package_name or not isinstance(package_name, str):
+        raise ValueError("A valid package name must be provided.")
 
+    executable = sys.executable
     commands = []
     if uninstall:
         commands.append([executable, "-m", "pip", "uninstall", "--yes", package_name])
@@ -1194,12 +1182,12 @@ def install_with_pip(package_name, package_path=None, upgrade=False, uninstall=F
             command.append("-U")
 
         commands.append(command)
+
     for command in commands:
-        if is_linux:
-            p = subprocess.Popen(command)
-        else:
-            p = subprocess.Popen(" ".join(command))
-        p.wait()
+        try:
+            subprocess.run(command, check=True)  # nosec
+        except subprocess.CalledProcessError as e:  # nosec
+            raise RuntimeError("An error occurred while installing with pip") from e
 
 
 class Help:  # pragma: no cover

pyedb/generic/plot.py

@@ -1,31 +1,16 @@
 import os
-import warnings
 
-try:
-    import numpy  # noqa: F401
-except ImportError:
-    warnings.warn(
-        "The NumPy module is required to run some functionalities of PostProcess.\n"
-        "Install with \n\npip install numpy\n\nRequires CPython."
-    )
-try:
-    from matplotlib.patches import PathPatch
-    from matplotlib.path import Path
+from matplotlib.patches import PathPatch
+from matplotlib.path import Path
+import numpy  # noqa: F401
 
-    # Use matplotlib agg backend (non-interactive) when the CI is running.
-    if bool(int(os.getenv("PYEDB_CI_NO_DISPLAY", "0"))):  # pragma: no cover
-        import matplotlib
+# Use matplotlib agg backend (non-interactive) when the CI is running.
+if bool(int(os.getenv("PYEDB_CI_NO_DISPLAY", "0"))):  # pragma: no cover
+    import matplotlib
 
-        matplotlib.use("Agg")
-    import matplotlib.pyplot as plt
+    matplotlib.use("Agg")
 
-except ImportError:
-    warnings.warn(
-        "The Matplotlib module is required to run some functionalities of PostProcess.\n"
-        "Install with \n\npip install matplotlib\n\nRequires CPython."
-    )
-except Exception:
-    warnings.warn("Unknown error occurred while attempting to import Matplotlib.")
+import matplotlib.pyplot as plt
 
 
 def plot_matplotlib(

pyedb/generic/process.py

@@ -1,6 +1,6 @@
 import os.path
 from pathlib import Path
-import subprocess
+import subprocess  # nosec B404
 
 from pyedb.generic.general_methods import is_linux
 
@@ -23,7 +23,63 @@ class SiwaveSolve(object):
         full_path = Path(self._pedb.ansys_em_path) / executable
         return str(full_path)
 
+    def __create_exec(self, type):
+        base = os.path.splitext(self._pedb.edbpath)[0]
+        txt_path = base + ".txt"
+        exec_path = base + ".exec"
+        with open(txt_path, "w") as file:
+            if type:
+                if type == "DCIR":
+                    file.write("ExecDcSim")
+                elif type == "SYZ":
+                    file.write("ExecSyzSim")
+                elif type == "CPA":
+                    file.write("ExecSentinelCpaSim")
+                elif type == "TimeCrosstalk":
+                    file.write("ExecTimeDomainCrosstalkSim")
+                elif type == "FreqCrosstalk":
+                    file.write("ExecCrosstalkSim")
+                elif type == "Impedance":
+                    file.write("ExecZ0Sim")
+
+        os.rename(txt_path, exec_path)
+        return exec_path
+
+    def solve_siwave(self, edbpath, analysis_type):
+        """Solve an SIWave setup. Only non-graphical batch mode is supported.
+
+        Parameters
+        ----------
+        analysis_type: str
+            Type of SIWave analysis to perform. Available types are "SYZ", "DCIR", "CPA", "TimeCrosstalk",
+            "FreqCrosstalk", "Impedance".
+        edbpath: str
+            Full path to the .aedb folder, siw or siwz file to be solved.
+        siwave_ng: str, optinial
+            Path to the siwave_ng. Default is the SIWave installation path.
+        """
+
+        command = [
+            self.__siwave_ng_exe_path,
+            edbpath,
+            self.__create_exec(type=analysis_type),
+            "-formatOutput",
+            "-useSubdir",
+        ]
+        try:
+            subprocess.run(command, check=True)
+        except subprocess.CalledProcessError as e:
+            raise RuntimeError(f"An error occurred when launching the solver. Please check input paths") from e
+
     def solve(self, num_of_cores=4):
+        """Solve using siwave_ng.exe
+
+        .. warning::
+            Do not execute this function with untrusted function argument, environment
+            variables or pyedb global settings.
+            See the :ref:`security guide<ref_security_consideration>` for details.
+
+        """
         exec_file = os.path.splitext(self._pedb.edbpath)[0] + ".exec"
         if os.path.exists(exec_file):
             with open(exec_file, "r+") as f:
@@ -39,16 +95,21 @@ class SiwaveSolve(object):
                     f = open(exec_file, "w")
                     f.writelines(content)
         command = [self.__siwave_ng_exe_path, self._pedb.edbpath, exec_file, "-formatOutput -useSubdir"]
-        command_ = command if os.name == "posix" else " ".join(command)
-        # p = subprocess.Popen(command_)
-        p = subprocess.Popen(command)
-        p.wait()
+        try:
+            subprocess.run(command, check=True)  # nosec
+        except subprocess.CalledProcessError as e:  # nosec
+            raise RuntimeError("An error occurred while solving") from e
 
     def export_3d_cad(
         self, format_3d="Q3D", output_folder=None, net_list=None, num_cores=4, aedt_file_name=None, hidden=False
     ):  # pragma: no cover
         """Export edb to Q3D or HFSS
 
+        .. warning::
+            Do not execute this function with untrusted function argument, environment
+            variables or pyedb global settings.
+            See the :ref:`security guide<ref_security_consideration>` for details.
+
         Parameters
         ----------
         format_3d : str, default ``Q3D``
@@ -97,10 +158,10 @@ class SiwaveSolve(object):
         command += ["-RunScriptAndExit", scriptname]
         print(command)
         try:
-            result = subprocess.run(command, check=True, capture_output=True)
+            result = subprocess.run(command, check=True, capture_output=True)  # nosec
             print(result.stdout.decode())
-        except subprocess.CalledProcessError as e:
-            print(f"Error occurred: {e.stderr.decode()}")
+        except subprocess.CalledProcessError as e:  # nosec
+            raise RuntimeError("An error occurred while exporting 3D CAD") from e
         return os.path.join(output_folder, aedt_file_name)
 
     def export_dc_report(
@@ -119,6 +180,11 @@ class SiwaveSolve(object):
     ):
         """Close EDB and solve it with Siwave.
 
+        .. warning::
+            Do not execute this function with untrusted function argument, environment
+            variables or pyedb global settings.
+            See the :ref:`security guide<ref_security_consideration>` for details.
+
         Parameters
         ----------
         siwave_project : str
@@ -215,6 +281,8 @@ class SiwaveSolve(object):
         command.append("-RunScriptAndExit")
         command.append(scriptname)
         print(command)
-        p = subprocess.Popen(command)
-        p.wait()
+        try:
+            subprocess.run(command, check=True)  # nosec
+        except subprocess.CalledProcessError as e:  # nosec
+            raise RuntimeError("An error occurred while solving with Siwave") from e
         return output_list

pyedb/grpc/database/components.py

@@ -1010,8 +1010,6 @@ class Components(object):
                 if component_definition_pin.is_null:
                     self._logger.error(f"Failed to create component definition pin {name}-{pin.name}")
                     return None
-        else:
-            self._logger.warning("Found existing component definition for footprint {}".format(name))
         return component_definition
 
     def create(
@@ -1074,6 +1072,8 @@ class Components(object):
         if not compdef:
             return False
         new_cmp = GrpcComponentGroup.create(self._active_layout, component_name, compdef.name)
+        if new_cmp.is_null:
+            raise ValueError(f"Failed to create component {component_name}.")
         if hasattr(pins[0], "component") and pins[0].component:
             hosting_component_location = None
             if not pins[0].component.is_null:
@@ -1469,13 +1469,15 @@ class Components(object):
             sball_shape = GrpcSolderballShape.SOLDERBALL_SPHEROID
 
         cmp_property = cmp.component_property
-        if cmp.type == GrpcComponentType.IC:
+        if cmp.component_type == GrpcComponentType.IC:
             ic_die_prop = cmp_property.die_property
             ic_die_prop.die_type = GrpcDieType.FLIPCHIP
+            if not cmp.placement_layer == list(self._pedb.stackup.layers.keys())[0]:
+                chip_orientation = "chip_up"
             if chip_orientation.lower() == "chip_up":
-                ic_die_prop.orientation = GrpDieOrientation.CHIP_UP
+                ic_die_prop.die_orientation = GrpDieOrientation.CHIP_UP
             else:
-                ic_die_prop.orientation = GrpDieOrientation.CHIP_DOWN
+                ic_die_prop.die_orientation = GrpDieOrientation.CHIP_DOWN
             cmp_property.die_property = ic_die_prop
 
         solder_ball_prop = cmp_property.solder_ball_property

pyedb/grpc/database/control_file.py

@@ -23,10 +23,12 @@
 import copy
 import os
 import re
-import subprocess
+import subprocess  # nosec B404
 import sys
 from typing import Any, Dict, List, Optional, Union
 
+from defusedxml.ElementTree import parse as defused_parse
+
 from pyedb.generic.general_methods import ET, env_path, env_value, is_linux
 from pyedb.generic.settings import settings
 from pyedb.misc.aedtlib_personalib_install import write_pretty_xml
@@ -36,6 +38,11 @@ from pyedb.misc.misc import list_installed_ansysem
 def convert_technology_file(tech_file, edbversion=None, control_file=None):
     """Convert a technology file to EDB control file (XML).
 
+    .. warning::
+        Do not execute this function with untrusted function argument, environment
+        variables or pyedb global settings.
+        See the :ref:`security guide<ref_security_consideration>` for details.
+
         Parameters
         ----------
         tech_file : str
@@ -212,10 +219,11 @@ def convert_technology_file(tech_file, edbversion=None, control_file=None):
         ]
         commands.append(command)
         commands.append(["rm", "-r", vlc_file_name + ".aedb"])
-        my_env = os.environ.copy()
         for command in commands:
-            p = subprocess.Popen(command, env=my_env)
-            p.wait()
+            try:
+                subprocess.run(command, check=True)  # nosec
+            except subprocess.CalledProcessError as e:  # nosec
+                raise RuntimeError("An error occurred while converting a technology file to edb control file") from e
         if os.path.exists(control_file):
             settings.logger.info("XML file created.")
             return control_file
@@ -1652,7 +1660,7 @@ class ControlFile:
         bool
             ``True`` if successful, ``False`` otherwise.
         """
-        tree = ET.parse(xml_input)
+        tree = defused_parse(xml_input)
         root = tree.getroot()
         for el in root:
             if el.tag == "Stackup":

pyedb/grpc/database/definition/padstack_def.py

@@ -35,6 +35,7 @@ from ansys.edb.core.hierarchy.structure3d import MeshClosure as GrpcMeshClosure,
 from ansys.edb.core.primitive.circle import Circle as GrpcCircle
 
 from pyedb.generic.general_methods import generate_unique_name
+from pyedb.grpc.database.primitive.circle import Circle
 from pyedb.grpc.database.utility.value import Value
 
 
@@ -294,7 +295,11 @@ class PadstackDef(GrpcPadstackDef):
         List[:class:`PadstackInstance <pyedb.grpc.database.primitive.padstack_instance.PadstackInstance>`]
             List of PadstackInstance objects.
         """
-        return [i for i in list(self._pedb.padstacks.instances.values()) if i.padstack_def.name == self.name]
+        return [
+            i
+            for i in list(self._pedb.padstacks.instances.values())
+            if not i.is_null and i.padstack_def.name == self.name
+        ]
 
     @property
     def layers(self) -> list[str]:
@@ -717,7 +722,7 @@ class PadstackDef(GrpcPadstackDef):
                         net_name=via.net_name,
                     )
                 else:
-                    GrpcCircle.create(
+                    Circle(self._pedb).create(
                         layout,
                         self.start_layer,
                         via.net,
@@ -732,7 +737,7 @@ class PadstackDef(GrpcPadstackDef):
                         net_name=via.net_name,
                     )
                 else:
-                    GrpcCircle.create(
+                    Circle(self._pedb).create(
                         layout,
                         self.stop_layer,
                         via.net,
@@ -745,7 +750,7 @@ class PadstackDef(GrpcPadstackDef):
                     if layer_name == via.start_layer or started:
                         start = layer_name
                         stop = layer_names[layer_names.index(layer_name) + 1]
-                        cloned_circle = GrpcCircle.create(
+                        cloned_circle = Circle(self._pedb).create(
                             layout,
                             start,
                             via.net,
@@ -753,7 +758,7 @@ class PadstackDef(GrpcPadstackDef):
                             Value(pos[1]),
                             Value(rad1),
                         )
-                        cloned_circle2 = GrpcCircle.create(
+                        cloned_circle2 = Circle(self._pedb).create(
                             layout,
                             stop,
                             via.net,

pyedb/grpc/database/hierarchy/component.py

@@ -48,7 +48,9 @@ from ansys.edb.core.terminal.padstack_instance_terminal import (
     PadstackInstanceTerminal as GrpcPadstackInstanceTerminal,
 )
 from ansys.edb.core.utility.rlc import Rlc as GrpcRlc
+import numpy as np
 
+from pyedb.generic.general_methods import get_filename_without_extension
 from pyedb.grpc.database.hierarchy.pin_pair_model import PinPairModel
 from pyedb.grpc.database.hierarchy.s_parameter_model import SparamModel
 from pyedb.grpc.database.hierarchy.spice_model import SpiceModel
@@ -59,15 +61,6 @@ from pyedb.grpc.database.terminal.padstack_instance_terminal import (
 )
 from pyedb.grpc.database.utility.value import Value
 
-try:
-    import numpy as np
-except ImportError:
-    warnings.warn(
-        "The NumPy module is required to run some functionalities of EDB.\n"
-        "Install with \n\npip install numpy\n\nRequires CPython."
-    )
-from pyedb.generic.general_methods import get_filename_without_extension
-
 
 class Component(GrpcComponentGroup):
     """Manages EDB functionalities for components.

pyedb/grpc/database/modeler.py

@@ -25,16 +25,13 @@ This module contains these classes: `EdbLayout` and `Shape`.
 """
 
 import math
-from typing import Any, Dict, List, Optional, Union
+from typing import Any, Dict, Iterable, List, Optional, Union
 
-from ansys.edb.core.geometry.arc_data import ArcData as GrpcArcData
 from ansys.edb.core.geometry.point_data import PointData as GrpcPointData
 from ansys.edb.core.geometry.polygon_data import (
     PolygonData as GrpcPolygonData,
-    PolygonSenseType as GrpcPolygonSenseType,
 )
 from ansys.edb.core.hierarchy.pin_group import PinGroup as GrpcPinGroup
-from ansys.edb.core.inner.exceptions import InvalidArgumentException
 from ansys.edb.core.primitive.bondwire import BondwireType as GrpcBondwireType
 from ansys.edb.core.primitive.path import PathCornerType as GrpcPathCornerType, PathEndCapType as GrpcPathEndCapType
 from ansys.edb.core.primitive.rectangle import (
@@ -51,6 +48,25 @@ from pyedb.grpc.database.utility.layout_statistics import LayoutStatistics
 from pyedb.grpc.database.utility.value import Value
 
 
+def normalize_pairs(points: Iterable[float]) -> List[List[float]]:
+    """
+    Convert any reasonable point description into [[x1, y1], [x2, y2], …]
+    """
+    pts = list(points)
+    if not pts:  # empty input
+        return []
+
+    # Detect flat vs nested
+    if isinstance(pts[0], (list, tuple)):
+        # already nested – just ensure every item is a *list* (not tuple)
+        return [list(pair) for pair in pts]
+    else:
+        # flat list – chunk into pairs
+        if len(pts) % 2:
+            raise ValueError("Odd number of coordinates supplied")
+        return [[pts[i], pts[i + 1]] for i in range(0, len(pts), 2)]
+
+
 class Modeler(object):
     """Manages EDB methods for primitives management accessible from `Edb.modeler`.
 
@@ -683,7 +699,8 @@ class Modeler(object):
         else:
             corner_style = GrpcPathCornerType.MITER
         _points = []
-        if isinstance(points, list):
+        if isinstance(points, (list, tuple)):
+            points = normalize_pairs(points)
             for pt in points:
                 _pt = []
                 for coord in pt:
@@ -714,7 +731,7 @@ class Modeler(object):
 
     def create_trace(
         self,
-        path_list: Union[List[List[float]], GrpcPolygonData],
+        path_list: Union[Iterable[float], GrpcPolygonData],
         layer_name: str,
         width: float = 1,
         net_name: str = "",
@@ -726,8 +743,9 @@ class Modeler(object):
 
         Parameters
         ----------
-        path_list : list
-            List of [x,y] points.
+        path_list : Iterable
+            List of points [x,y] or [[x, y], ...]
+            or [(x, y)...].
         layer_name : str
             Layer name.
         width : float, optional
@@ -803,6 +821,8 @@ class Modeler(object):
         for void in voids:
             if isinstance(void, list):
                 void_polygon_data = GrpcPolygonData(points=void)
+            elif isinstance(void, GrpcPolygonData):
+                void_polygon_data = void
             else:
                 void_polygon_data = void.polygon_data
             if not void_polygon_data.points: