pycarlo 0.11.15__py3-none-any.whl → 0.12.2__py3-none-any.whl

pycarlo/features/metadata/metadata_filters_container.py

@@ -214,7 +214,7 @@ class MetadataFiltersContainer:
 
         default_effect_conditions = default_effect_op.join(
             [
-                f"({self._get_sql_field_condition(f, column_mapping, encoder, force_lowercase)})"
+                self._get_sql_field_condition(f, column_mapping, encoder, force_lowercase)
                 for f in default_effect_filters
             ]
         )
@@ -224,13 +224,15 @@ class MetadataFiltersContainer:
                 for f in other_effect_filters
             ]
         )
-        conditions = default_effect_conditions
-        if conditions and other_effect_conditions:
-            conditions += default_effect_op
-            conditions += "(" + other_effect_conditions + ")"
-        elif not conditions:
-            conditions = other_effect_conditions
-        return f"({conditions})" if conditions else ""
+
+        if default_effect_conditions and other_effect_conditions:
+            return f"(({default_effect_conditions}){default_effect_op}({other_effect_conditions}))"
+        elif default_effect_conditions:
+            return f"({default_effect_conditions})"
+        elif other_effect_conditions:
+            return f"({other_effect_conditions})"
+        else:
+            return None
 
     @staticmethod
     def _get_sql_field_condition(
@@ -238,7 +240,7 @@ class MetadataFiltersContainer:
         column_mapping: Dict,
         encoder: Callable[[str, str, FilterType], str],
         force_lowercase: Optional[bool] = True,
-    ):
+    ) -> str:
         # The comparison is performed case-insensitive (check MetadataFilter._safe_match)
         # We can use LOWER here since it is part of standard SQL (like AND/OR/NOT), so including it
         # here is a way to make sure that all comparisons are case-insensitive in the SQL sentences
@@ -255,4 +257,6 @@ class MetadataFiltersContainer:
                 if getattr(mf, field) is not None
             ]
         )
+        if not conditions:
+            return ""
         return f"NOT({conditions})" if mf.effect == FilterEffectType.BLOCK else f"({conditions})"

pycarlo/lib/README.md

@@ -1,3 +1,35 @@
-These files are auto-generated. **Do not edit**!
+# Monte Carlo GraphQL Schema Library
 
-Use `make generate` to update the schema (e.g. support new/modified queries & mutations).
+The `schema.json` and `schema.py` files are auto-generated. **Do not edit them directly**!
+
+If you need to customize the schema, see below. Refer to the
+[CONTRIBUTING.md](../../CONTRIBUTING.md) for general development guidelines.
+
+## Schema Customizations
+
+The generated `schema.py` is automatically modified during the build process to apply the following
+customizations. This is done via `sed` commands in the [Makefile](../../Makefile), but if we need to
+get fancier, we just can update the `customize-schema` target there to call whatever we need to do.
+
+### Connection Type Fix
+
+The `Connection` class is changed from `sgqlc.types.relay.Connection` to `sgqlc.types.Type`.
+
+**Why:** sgqlc automatically makes all types ending in "Connection" inherit from `relay.Connection`,
+which makes `Connection` not a valid field type. This causes requests to fail when attempting to
+resolve it. Changing it to inherit from `sgqlc.types.Type` fixes this issue.
+
+[Related PR](https://github.com/monte-carlo-data/python-sdk/pull/63)
+
+### Backward-Compatible Enums
+
+All GraphQL enum types use `pycarlo.lib.types.Enum` instead of `sgqlc.types.Enum`. This custom enum
+class gracefully handles unknown enum values by returning them as strings instead of raising errors.
+
+**Why:** When new enum values are added to the Monte Carlo API, older SDK versions would crash when
+deserializing responses containing these new values. Our custom Enum prevents this by:
+
+- Returning unknown values as plain strings (same type as known values)
+- Logging a warning when unknown values are encountered
+
+See [pycarlo/lib/types.py](types.py) for implementation details.