prefect-client 2.19.2__py3-none-any.whl → 3.0.0rc1__py3-none-any.whl

prefect/utilities/asyncutils.py

@@ -3,15 +3,13 @@ Utilities for interoperability with async functions and workers from various con
 """
 
 import asyncio
-import ctypes
 import inspect
 import threading
 import warnings
 from concurrent.futures import ThreadPoolExecutor
 from contextlib import asynccontextmanager
-from contextvars import copy_context
+from contextvars import ContextVar, copy_context
 from functools import partial, wraps
-from threading import Thread
 from typing import (
     Any,
     Awaitable,
@@ -20,7 +18,6 @@ from typing import (
     Dict,
     List,
     Optional,
-    Type,
     TypeVar,
     Union,
     cast,
@@ -29,9 +26,16 @@ from uuid import UUID, uuid4
 
 import anyio
 import anyio.abc
+import anyio.from_thread
+import anyio.to_thread
 import sniffio
 from typing_extensions import Literal, ParamSpec, TypeGuard
 
+from prefect._internal.concurrency.api import _cast_to_call, from_sync
+from prefect._internal.concurrency.threads import (
+    get_run_sync_loop,
+    in_run_sync_loop,
+)
 from prefect.logging import get_logger
 
 T = TypeVar("T")
@@ -46,6 +50,14 @@ EVENT_LOOP_GC_REFS = {}
 
 PREFECT_THREAD_LIMITER: Optional[anyio.CapacityLimiter] = None
 
+RUNNING_IN_RUN_SYNC_LOOP_FLAG = ContextVar("running_in_run_sync_loop", default=False)
+RUNNING_ASYNC_FLAG = ContextVar("run_async", default=False)
+BACKGROUND_TASKS: set[asyncio.Task] = set()
+background_task_lock = threading.Lock()
+
+# Thread-local storage to keep track of worker thread state
+_thread_local = threading.local()
+
 logger = get_logger()
 
 
@@ -82,12 +94,47 @@ def is_async_gen_fn(func):
     return inspect.isasyncgenfunction(func)
 
 
-def run_sync(coroutine: Coroutine[Any, Any, T]) -> T:
+def create_task(coroutine: Coroutine) -> asyncio.Task:
+    """
+    Replacement for asyncio.create_task that will ensure that tasks aren't
+    garbage collected before they complete. Allows for "fire and forget"
+    behavior in which tasks can be created and the application can move on.
+    Tasks can also be awaited normally.
+
+    See https://docs.python.org/3/library/asyncio-task.html#asyncio.create_task
+    for details (and essentially this implementation)
     """
-    Runs a coroutine from a synchronous context. A thread will be spawned
-    to run the event loop if necessary, which allows coroutines to run in
-    environments like Jupyter notebooks where the event loop runs on the main
-    thread.
+
+    task = asyncio.create_task(coroutine)
+
+    # Add task to the set. This creates a strong reference.
+    # Take a lock because this might be done from multiple threads.
+    with background_task_lock:
+        BACKGROUND_TASKS.add(task)
+
+    # To prevent keeping references to finished tasks forever,
+    # make each task remove its own reference from the set after
+    # completion:
+    task.add_done_callback(BACKGROUND_TASKS.discard)
+
+    return task
+
+
+def _run_sync_in_new_thread(coroutine: Coroutine[Any, Any, T]) -> T:
+    """
+    Note: this is an OLD implementation of `run_coro_as_sync` which liberally created
+    new threads and new loops. This works, but prevents sharing any objects
+    across coroutines, in particular httpx clients, which are very expensive to
+    instantiate.
+
+    This is here for historical purposes and can be removed if/when it is no
+    longer needed for reference.
+
+    ---
+
+    Runs a coroutine from a synchronous context. A thread will be spawned to run
+    the event loop if necessary, which allows coroutines to run in environments
+    like Jupyter notebooks where the event loop runs on the main thread.
 
     Args:
         coroutine: The coroutine to run.
@@ -96,15 +143,25 @@ def run_sync(coroutine: Coroutine[Any, Any, T]) -> T:
         The return value of the coroutine.
 
     Example:
-        Basic usage:
-        ```python
-        async def my_async_function(x: int) -> int:
+        Basic usage: ```python async def my_async_function(x: int) -> int:
             return x + 1
 
-        run_sync(my_async_function(1))
-        ```
+        run_sync(my_async_function(1)) ```
     """
+
     # ensure context variables are properly copied to the async frame
+    async def context_local_wrapper():
+        """
+        Wrapper that is submitted using copy_context().run to ensure
+        the RUNNING_ASYNC_FLAG mutations are tightly scoped to this coroutine's frame.
+        """
+        token = RUNNING_ASYNC_FLAG.set(True)
+        try:
+            result = await coroutine
+        finally:
+            RUNNING_ASYNC_FLAG.reset(token)
+        return result
+
     context = copy_context()
     try:
         loop = asyncio.get_running_loop()
@@ -113,102 +170,99 @@ def run_sync(coroutine: Coroutine[Any, Any, T]) -> T:
 
     if loop and loop.is_running():
         with ThreadPoolExecutor() as executor:
-            future = executor.submit(context.run, asyncio.run, coroutine)
-            return cast(T, future.result())
+            future = executor.submit(context.run, asyncio.run, context_local_wrapper())
+            result = cast(T, future.result())
     else:
-        return context.run(asyncio.run, coroutine)
+        result = context.run(asyncio.run, context_local_wrapper())
+    return result
 
 
-async def run_sync_in_worker_thread(
-    __fn: Callable[..., T], *args: Any, **kwargs: Any
-) -> T:
+def run_coro_as_sync(
+    coroutine: Awaitable[R],
+    force_new_thread: bool = False,
+    wait_for_result: bool = True,
+) -> R:
     """
-    Runs a sync function in a new worker thread so that the main thread's event loop
-    is not blocked
+    Runs a coroutine from a synchronous context, as if it were a synchronous
+    function.
 
-    Unlike the anyio function, this defaults to a cancellable thread and does not allow
-    passing arguments to the anyio function so users can pass kwargs to their function.
+    The coroutine is scheduled to run in the "run sync" event loop, which is
+    running in its own thread and is started the first time it is needed. This
+    allows us to share objects like async httpx clients among all coroutines
+    running in the loop.
 
-    Note that cancellation of threads will not result in interrupted computation, the
-    thread may continue running — the outcome will just be ignored.
-    """
-    call = partial(__fn, *args, **kwargs)
-    return await anyio.to_thread.run_sync(
-        call, cancellable=True, limiter=get_thread_limiter()
-    )
+    If run_sync is called from within the run_sync loop, it will run the
+    coroutine in a new thread, because otherwise a deadlock would occur. Note
+    that this behavior should not appear anywhere in the Prefect codebase or in
+    user code.
 
+    Args:
+        coroutine (Awaitable): The coroutine to be run as a synchronous function.
+        force_new_thread (bool, optional): If True, the coroutine will always be run in a new thread.
+            Defaults to False.
+        wait_for_result (bool, optional): If True, the function will wait for the coroutine to complete
+            and return the result. If False, the function will submit the coroutine to the "run sync"
+            event loop and return immediately, where it will eventually be run. Defaults to True.
 
-def raise_async_exception_in_thread(thread: Thread, exc_type: Type[BaseException]):
+    Returns:
+        The result of the coroutine if wait_for_result is True, otherwise None.
     """
-    Raise an exception in a thread asynchronously.
 
-    This will not interrupt long-running system calls like `sleep` or `wait`.
-    """
-    ret = ctypes.pythonapi.PyThreadState_SetAsyncExc(
-        ctypes.c_long(thread.ident), ctypes.py_object(exc_type)
-    )
-    if ret == 0:
-        raise ValueError("Thread not found.")
+    async def coroutine_wrapper():
+        """
+        Set flags so that children (and grandchildren...) of this task know they are running in a new
+        thread and do not try to run on the run_sync thread, which would cause a
+        deadlock.
+        """
+        token1 = RUNNING_IN_RUN_SYNC_LOOP_FLAG.set(True)
+        token2 = RUNNING_ASYNC_FLAG.set(True)
+        try:
+            # use `asyncio.create_task` because it copies context variables automatically
+            task = create_task(coroutine)
+            if wait_for_result:
+                return await task
+        finally:
+            RUNNING_IN_RUN_SYNC_LOOP_FLAG.reset(token1)
+            RUNNING_ASYNC_FLAG.reset(token2)
+
+    # if we are already in the run_sync loop, or a descendent of a coroutine
+    # that is running in the run_sync loop, we need to run this coroutine in a
+    # new thread
+    if in_run_sync_loop() or RUNNING_IN_RUN_SYNC_LOOP_FLAG.get() or force_new_thread:
+        return from_sync.call_in_new_thread(coroutine_wrapper)
+
+    # otherwise, we can run the coroutine in the run_sync loop
+    # and wait for the result
+    else:
+        call = _cast_to_call(coroutine_wrapper)
+        runner = get_run_sync_loop()
+        runner.submit(call)
+        return call.result()
 
 
-async def run_sync_in_interruptible_worker_thread(
+async def run_sync_in_worker_thread(
     __fn: Callable[..., T], *args: Any, **kwargs: Any
 ) -> T:
     """
-    Runs a sync function in a new interruptible worker thread so that the main
-    thread's event loop is not blocked
-
-    Unlike the anyio function, this performs best-effort cancellation of the
-    thread using the C API. Cancellation will not interrupt system calls like
-    `sleep`.
-    """
-
-    class NotSet:
-        pass
+    Runs a sync function in a new worker thread so that the main thread's event loop
+    is not blocked.
 
-    thread: Thread = None
-    result = NotSet
-    event = asyncio.Event()
-    loop = asyncio.get_running_loop()
+    Unlike the anyio function, this defaults to a cancellable thread and does not allow
+    passing arguments to the anyio function so users can pass kwargs to their function.
 
-    def capture_worker_thread_and_result():
-        # Captures the worker thread that AnyIO is using to execute the function so
-        # the main thread can perform actions on it
-        nonlocal thread, result
-        try:
-            thread = threading.current_thread()
-            result = __fn(*args, **kwargs)
-        except BaseException as exc:
-            result = exc
-            raise
-        finally:
-            loop.call_soon_threadsafe(event.set)
+    Note that cancellation of threads will not result in interrupted computation, the
+    thread may continue running — the outcome will just be ignored.
+    """
+    call = partial(__fn, *args, **kwargs)
+    result = await anyio.to_thread.run_sync(
+        call_with_mark, call, abandon_on_cancel=True, limiter=get_thread_limiter()
+    )
+    return result
 
-    async def send_interrupt_to_thread():
-        # This task waits until the result is returned from the thread, if cancellation
-        # occurs during that time, we will raise the exception in the thread as well
-        try:
-            await event.wait()
-        except anyio.get_cancelled_exc_class():
-            # NOTE: We could send a SIGINT here which allow us to interrupt system
-            # calls but the interrupt bubbles from the child thread into the main thread
-            # and there is not a clear way to prevent it.
-            raise_async_exception_in_thread(thread, anyio.get_cancelled_exc_class())
-            raise
-
-    async with anyio.create_task_group() as tg:
-        tg.start_soon(send_interrupt_to_thread)
-        tg.start_soon(
-            partial(
-                anyio.to_thread.run_sync,
-                capture_worker_thread_and_result,
-                cancellable=True,
-                limiter=get_thread_limiter(),
-            )
-        )
 
-    assert result is not NotSet
-    return result
+def call_with_mark(call):
+    mark_as_worker_thread()
+    return call()
 
 
 def run_async_from_worker_thread(
@@ -226,13 +280,12 @@ def run_async_in_new_loop(__fn: Callable[..., Awaitable[T]], *args: Any, **kwarg
     return anyio.run(partial(__fn, *args, **kwargs))
 
 
+def mark_as_worker_thread():
+    _thread_local.is_worker_thread = True
+
+
 def in_async_worker_thread() -> bool:
-    try:
-        anyio.from_thread.threadlocals.current_async_module
-    except AttributeError:
-        return False
-    else:
-        return True
+    return getattr(_thread_local, "is_worker_thread", False)
 
 
 def in_async_main_thread() -> bool:
@@ -245,7 +298,7 @@ def in_async_main_thread() -> bool:
         return not in_async_worker_thread()
 
 
-def sync_compatible(async_fn: T) -> T:
+def sync_compatible(async_fn: T, force_sync: bool = False) -> T:
     """
     Converts an async function into a dual async and sync function.
 
@@ -261,47 +314,53 @@ def sync_compatible(async_fn: T) -> T:
     """
 
     @wraps(async_fn)
-    def coroutine_wrapper(*args, **kwargs):
-        from prefect._internal.concurrency.api import create_call, from_sync
-        from prefect._internal.concurrency.calls import get_current_call, logger
-        from prefect._internal.concurrency.event_loop import get_running_loop
-        from prefect._internal.concurrency.threads import get_global_loop
-        from prefect.settings import PREFECT_EXPERIMENTAL_DISABLE_SYNC_COMPAT
-
-        if PREFECT_EXPERIMENTAL_DISABLE_SYNC_COMPAT:
-            return async_fn(*args, **kwargs)
-
-        global_thread_portal = get_global_loop()
-        current_thread = threading.current_thread()
-        current_call = get_current_call()
-        current_loop = get_running_loop()
+    def coroutine_wrapper(*args, _sync: bool = None, **kwargs):
+        from prefect.context import MissingContextError, get_run_context
+        from prefect.settings import (
+            PREFECT_EXPERIMENTAL_DISABLE_SYNC_COMPAT,
+        )
 
-        if current_thread.ident == global_thread_portal.thread.ident:
-            logger.debug(f"{async_fn} --> return coroutine for internal await")
-            # In the prefect async context; return the coro for us to await
+        if PREFECT_EXPERIMENTAL_DISABLE_SYNC_COMPAT or _sync is False:
             return async_fn(*args, **kwargs)
-        elif in_async_main_thread() and (
-            not current_call or is_async_fn(current_call.fn)
-        ):
-            # In the main async context; return the coro for them to await
-            logger.debug(f"{async_fn} --> return coroutine for user await")
-            return async_fn(*args, **kwargs)
-        elif in_async_worker_thread():
-            # In a sync context but we can access the event loop thread; send the async
-            # call to the parent
-            return run_async_from_worker_thread(async_fn, *args, **kwargs)
-        elif current_loop is not None:
-            logger.debug(f"{async_fn} --> run async in global loop portal")
-            # An event loop is already present but we are in a sync context, run the
-            # call in Prefect's event loop thread
-            return from_sync.call_soon_in_loop_thread(
-                create_call(async_fn, *args, **kwargs)
-            ).result()
+
+        is_async = True
+
+        # if _sync is set, we do as we're told
+        # otherwise, we make some determinations
+        if _sync is None:
+            try:
+                run_ctx = get_run_context()
+                parent_obj = getattr(run_ctx, "task", None)
+                if not parent_obj:
+                    parent_obj = getattr(run_ctx, "flow", None)
+                is_async = getattr(parent_obj, "isasync", True)
+            except MissingContextError:
+                # not in an execution context, make best effort to
+                # decide whether to syncify
+                try:
+                    asyncio.get_running_loop()
+                    is_async = True
+                except RuntimeError:
+                    is_async = False
+
+        async def ctx_call():
+            """
+            Wrapper that is submitted using copy_context().run to ensure
+            mutations of RUNNING_ASYNC_FLAG are tightly scoped to this coroutine's frame.
+            """
+            token = RUNNING_ASYNC_FLAG.set(True)
+            try:
+                result = await async_fn(*args, **kwargs)
+            finally:
+                RUNNING_ASYNC_FLAG.reset(token)
+            return result
+
+        if _sync is True:
+            return run_coro_as_sync(ctx_call())
+        elif _sync is False or RUNNING_ASYNC_FLAG.get() or is_async:
+            return ctx_call()
         else:
-            logger.debug(f"{async_fn} --> run async in new loop")
-            # Run in a new event loop, but use a `Call` for nested context detection
-            call = create_call(async_fn, *args, **kwargs)
-            return call()
+            return run_coro_as_sync(ctx_call())
 
     # TODO: This is breaking type hints on the callable... mypy is behind the curve
     #       on argument annotations. We can still fix this for editors though.