portacode 1.4.16.dev2__py3-none-any.whl → 1.4.16.dev4__py3-none-any.whl

portacode/_version.py

@@ -28,7 +28,7 @@ version_tuple: VERSION_TUPLE
 commit_id: COMMIT_ID
 __commit_id__: COMMIT_ID
 
-__version__ = version = '1.4.16.dev2'
-__version_tuple__ = version_tuple = (1, 4, 16, 'dev2')
+__version__ = version = '1.4.16.dev4'
+__version_tuple__ = version_tuple = (1, 4, 16, 'dev4')
 
 __commit_id__ = commit_id = None

portacode/connection/handlers/WEBSOCKET_PROTOCOL.md

@@ -1136,22 +1136,34 @@ Provides system information in response to a `system_info` action. Handled by [`
                     *   `bridge` (string): The bridge interface configured (typically `vmbr1`).
                     *   `health` (string|null): `"healthy"` when the connectivity verification succeeded.
                 *   `node_status` (object|null): Status response returned by the Proxmox API when validating the token.
-                *   `managed_containers` (object): Cached summary of the Portacode-managed containers:
-                    *   `updated_at` (string): ISO timestamp when this snapshot was last refreshed.
-                    *   `count` (integer): Number of managed containers.
-                    *   `total_ram_mib` (integer): RAM footprint summed across all containers.
-                    *   `total_disk_gib` (integer): Disk footprint summed across all containers.
-                    *   `total_cpu_share` (number): CPU shares requested across all containers.
-                    *   `containers` (array[object]): Container summaries with the following fields:
-                        *   `vmid` (string|null): Numeric CT ID.
-                        *   `hostname` (string|null): Hostname configured in the CT.
-                        *   `template` (string|null): Template identifier used.
-                        *   `storage` (string|null): Storage pool backing the rootfs.
-                        *   `disk_gib` (integer): Rootfs size in GiB.
-                        *   `ram_mib` (integer): Memory size in MiB.
-                        *   `cpu_share` (number): vCPU-equivalent share requested at creation.
-                        *   `status` (string): Lowercase lifecycle status (e.g., `running`, `stopped`, `deleted`).
-                        *   `created_at` (string|null): ISO timestamp recorded when the CT was provisioned.
+                    *   `managed_containers` (object): Cached summary of the Portacode-managed containers:
+                        *   `updated_at` (string): ISO timestamp when this snapshot was last refreshed.
+                        *   `count` (integer): Number of managed containers.
+                        *   `total_ram_mib` (integer): RAM footprint summed across all containers.
+                        *   `total_disk_gib` (integer): Disk footprint summed across all containers.
+                        *   `total_cpu_share` (number): CPU shares requested across all containers.
+                        *   `containers` (array[object]): Container summaries with the following fields:
+                            *   `vmid` (string|null): Numeric CT ID.
+                            *   `hostname` (string|null): Hostname configured in the CT.
+                            *   `template` (string|null): Template identifier used.
+                            *   `storage` (string|null): Storage pool backing the rootfs.
+                            *   `disk_gib` (integer): Rootfs size in GiB.
+                            *   `ram_mib` (integer): Memory size in MiB.
+                            *   `cpu_share` (number): vCPU-equivalent share requested at creation.
+                            *   `status` (string): Lowercase lifecycle status (e.g., `running`, `stopped`, `deleted`).
+                            *   `created_at` (string|null): ISO timestamp recorded when the CT was provisioned.
+                            *   `managed` (boolean): `true` for Portacode-managed entries.
+                        *   `unmanaged_containers` (array[object]): Facts about containers Portacode did not provision; fields mirror the managed list but are marked `managed=false`.
+                        *   `unmanaged_count` (integer): Number of unmanaged containers detected on the node.
+                        *   `allocated_ram_mib` (integer): Total RAM reserved by both managed and unmanaged containers.
+                        *   `allocated_disk_gib` (integer): Total disk reserved by both managed and unmanaged containers.
+                        *   `allocated_cpu_share` (number): Total CPU shares requested by both managed and unmanaged containers.
+                        *   `available_ram_mib` (integer|null): Remaining RAM after subtracting all reservations from the host total (null when unavailable).
+                        *   `available_disk_gib` (integer|null): Remaining disk GB after subtracting allocations from the host total.
+                        *   `available_cpu_share` (number|null): Remaining CPU shares after allocations.
+                        *   `host_total_ram_mib` (integer|null): Host memory capacity observed via Proxmox.
+                        *   `host_total_disk_gib` (integer|null): Host disk capacity observed via Proxmox.
+                        *   `host_total_cpu_cores` (integer|null): Number of CPU cores reported by Proxmox.
     *   `portacode_version` (string): Installed CLI version returned by `portacode.__version__`.
 
 ### `proxmox_infra_configured`

portacode/connection/handlers/proxmox_infra.py

@@ -7,6 +7,7 @@ import json
 import logging
 import math
 import os
+import re
 import secrets
 import shlex
 import shutil
@@ -18,7 +19,7 @@ import time
 import threading
 from datetime import datetime, timezone
 from pathlib import Path
-from typing import Any, Callable, Dict, Iterable, List, Optional, Sequence, Tuple
+from typing import Any, Callable, Dict, Iterable, List, Optional, Sequence, Set, Tuple
 
 import platformdirs
 
@@ -201,6 +202,70 @@ def _current_time_iso() -> str:
     return datetime.now(timezone.utc).isoformat()
 
 
+def _to_int(value: Any, default: int = 0) -> int:
+    try:
+        return int(value)
+    except (TypeError, ValueError):
+        return default
+
+
+def _to_float(value: Any, default: float = 0.0) -> float:
+    try:
+        return float(value)
+    except (TypeError, ValueError):
+        return default
+
+
+def _calculate_available(total: Optional[float], used: float) -> Optional[float]:
+    if total is None:
+        return None
+    delta = total - used
+    return delta if delta >= 0 else 0.0
+
+
+def _normalize_bytes(value: Any) -> float:
+    if isinstance(value, (int, float)):
+        return float(value)
+    text = str(value or "").strip()
+    if not text:
+        return 0.0
+    match = re.match(r"(?i)^\s*([0-9]*\.?[0-9]+)\s*([kmgtp]?i?b?)?\s*$", text)
+    if not match:
+        return 0.0
+    number = match.group(1)
+    unit = (match.group(2) or "").lower()
+    try:
+        value = float(number)
+    except ValueError:
+        return 0.0
+    if unit.startswith("k"):
+        return value * 1024
+    if unit.startswith("m"):
+        return value * 1024**2
+    if unit.startswith("g"):
+        return value * 1024**3
+    if unit.startswith("t"):
+        return value * 1024**4
+    if unit.startswith("p"):
+        return value * 1024**5
+    return value
+
+
+def _bytes_to_mib(value: Any) -> int:
+    return int(round(_normalize_bytes(value) / (1024**2)))
+
+
+def _bytes_to_gib(value: Any) -> int:
+    return int(round(_normalize_bytes(value) / (1024**3)))
+
+
+def _parse_bool_flag(value: Any) -> bool:
+    if isinstance(value, bool):
+        return value
+    text = str(value or "").strip().lower()
+    return text in {"1", "true", "yes", "on"}
+
+
 def _parse_iso_timestamp(value: str) -> Optional[datetime]:
     if not value:
         return None
@@ -381,35 +446,68 @@ def _load_managed_container_records() -> List[Dict[str, Any]]:
     return records
 
 
-def _build_managed_containers_summary(records: List[Dict[str, Any]]) -> Dict[str, Any]:
+def _extract_host_totals(node_status: Dict[str, Any] | None) -> Tuple[Optional[int], Optional[int], Optional[int]]:
+    if not node_status:
+        return None, None, None
+    memory_total = node_status.get("memory", {}).get("total")
+    disk_total = node_status.get("disk", {}).get("total")
+    cpu_cores = node_status.get("cpuinfo", {}).get("cores")
+    host_ram = _bytes_to_mib(memory_total) if memory_total is not None else None
+    host_disk = _bytes_to_gib(disk_total) if disk_total is not None else None
+    host_cpu = _to_int(cpu_cores) if cpu_cores is not None else None
+    return host_ram, host_disk, host_cpu
+
+
+def _build_unmanaged_container_entry(ct: Dict[str, Any], cfg: Dict[str, Any], vmid: str) -> Dict[str, Any]:
+    ram_mib = _to_int(cfg.get("memory")) or _bytes_to_mib(ct.get("maxmem"))
+    disk_gib = _bytes_to_gib(ct.get("maxdisk"))
+    cpu_share = _to_float(
+        cfg.get("cpulimit")
+        or cfg.get("cpus")
+        or cfg.get("cores")
+        or ct.get("cpus")
+        or ct.get("cpu")
+    )
+    hostname = ct.get("name") or cfg.get("hostname") or f"ct{vmid}"
+    storage = cfg.get("storage") or ct.get("storage")
+    status = (ct.get("status") or "unknown").lower()
+    reserved = _parse_bool_flag(cfg.get("onboot"))
+    return {
+        "vmid": vmid,
+        "hostname": hostname,
+        "template": cfg.get("ostemplate"),
+        "storage": storage,
+        "disk_gib": disk_gib,
+        "ram_mib": ram_mib,
+        "cpu_share": cpu_share,
+        "reserve_on_boot": reserved,
+        "status": status,
+        "managed": False,
+    }
+
+
+
+def _build_managed_containers_summary(
+    records: List[Dict[str, Any]],
+    unmanaged_records: List[Dict[str, Any]],
+    node_status: Dict[str, Any] | None,
+) -> Dict[str, Any]:
+    managed_containers: List[Dict[str, Any]] = []
     total_ram = 0
     total_disk = 0
     total_cpu_share = 0.0
-    containers: List[Dict[str, Any]] = []
-
-    def _as_int(value: Any) -> int:
-        try:
-            return int(value)
-        except (TypeError, ValueError):
-            return 0
 
-    def _as_float(value: Any) -> float:
-        try:
-            return float(value)
-        except (TypeError, ValueError):
-            return 0.0
-
-    for record in sorted(records, key=lambda entry: _as_int(entry.get("vmid"))):
-        ram_mib = _as_int(record.get("ram_mib"))
-        disk_gib = _as_int(record.get("disk_gib"))
-        cpu_share = _as_float(record.get("cpus"))
+    for record in sorted(records, key=lambda entry: _to_int(entry.get("vmid"))):
+        ram_mib = _to_int(record.get("ram_mib"))
+        disk_gib = _to_int(record.get("disk_gib"))
+        cpu_share = _to_float(record.get("cpus"))
         total_ram += ram_mib
         total_disk += disk_gib
         total_cpu_share += cpu_share
         status = (record.get("status") or "unknown").lower()
-        containers.append(
+        managed_containers.append(
             {
-                "vmid": str(_as_int(record.get("vmid"))) if record.get("vmid") is not None else None,
+                "vmid": str(_to_int(record.get("vmid"))) if record.get("vmid") is not None else None,
                 "device_id": record.get("device_id"),
                 "hostname": record.get("hostname"),
                 "template": record.get("template"),
@@ -419,44 +517,84 @@ def _build_managed_containers_summary(records: List[Dict[str, Any]]) -> Dict[str
                 "cpu_share": cpu_share,
                 "created_at": record.get("created_at"),
                 "status": status,
+                "managed": True,
             }
         )
 
+    unmanaged_total_ram = sum(
+        _to_int(entry.get("ram_mib"))
+        for entry in unmanaged_records
+        if entry.get("reserve_on_boot")
+    )
+    unmanaged_total_disk = sum(_to_int(entry.get("disk_gib")) for entry in unmanaged_records)
+    unmanaged_total_cpu = sum(
+        _to_float(entry.get("cpu_share"))
+        for entry in unmanaged_records
+        if entry.get("reserve_on_boot")
+    )
+
+    allocated_ram = total_ram + unmanaged_total_ram
+    allocated_disk = total_disk + unmanaged_total_disk
+    allocated_cpu = total_cpu_share + unmanaged_total_cpu
+
+    host_ram, host_disk, host_cpu = _extract_host_totals(node_status)
+
     return {
         "updated_at": datetime.utcnow().isoformat() + "Z",
-        "count": len(containers),
+        "count": len(managed_containers),
         "total_ram_mib": total_ram,
         "total_disk_gib": total_disk,
         "total_cpu_share": round(total_cpu_share, 2),
-        "containers": containers,
+        "containers": managed_containers,
+        "unmanaged_containers": unmanaged_records,
+        "unmanaged_count": len(unmanaged_records),
+        "allocated_ram_mib": allocated_ram,
+        "allocated_disk_gib": allocated_disk,
+        "allocated_cpu_share": round(allocated_cpu, 2),
+        "available_ram_mib": _calculate_available(host_ram, allocated_ram) if host_ram is not None else None,
+        "available_disk_gib": _calculate_available(host_disk, allocated_disk) if host_disk is not None else None,
+        "available_cpu_share": _calculate_available(host_cpu, allocated_cpu) if host_cpu is not None else None,
+        "host_total_ram_mib": host_ram,
+        "host_total_disk_gib": host_disk,
+        "host_total_cpu_cores": host_cpu,
     }
 
 
 def _get_managed_containers_summary(force: bool = False) -> Dict[str, Any]:
-    def _refresh_container_statuses(records: List[Dict[str, Any]], config: Dict[str, Any] | None) -> None:
-        if not records or not config:
-            return
+    def _refresh_container_statuses(
+        records: List[Dict[str, Any]],
+        config: Dict[str, Any] | None,
+        managed_vmids: Set[str],
+    ) -> Tuple[Dict[str, str], List[Dict[str, Any]], Dict[str, Any] | None]:
+        statuses: Dict[str, str] = {}
+        unmanaged: List[Dict[str, Any]] = []
+        node_status: Dict[str, Any] | None = None
+        if not config:
+            return statuses, unmanaged, node_status
         try:
             proxmox = _connect_proxmox(config)
             node = _get_node_from_config(config)
-            statuses = {
-                str(ct.get("vmid")): (ct.get("status") or "unknown").lower()
-                for ct in proxmox.nodes(node).lxc.get()
-            }
+            node_status = proxmox.nodes(node).status.get()
+            for ct in proxmox.nodes(node).lxc.get():
+                vmid_val = ct.get("vmid")
+                if vmid_val is None:
+                    continue
+                vmid_key = str(_to_int(vmid_val))
+                statuses[vmid_key] = (ct.get("status") or "unknown").lower()
+                if vmid_key in managed_vmids:
+                    continue
+                cfg: Dict[str, Any] = {}
+                try:
+                    cfg = proxmox.nodes(node).lxc(vmid_key).config.get() or {}
+                except Exception as exc:  # pragma: no cover - best effort
+                    logger.debug("Failed to read config for container %s: %s", vmid_key, exc)
+                description = (cfg.get("description") or "")
+                if MANAGED_MARKER in description:
+                    continue
+                unmanaged.append(_build_unmanaged_container_entry(ct, cfg, vmid_key))
         except Exception as exc:  # pragma: no cover - best effort
             logger.debug("Failed to refresh container statuses: %s", exc)
-            return
-        for record in records:
-            vmid = record.get("vmid")
-            if vmid is None:
-                continue
-            try:
-                vmid_key = str(int(vmid))
-            except (ValueError, TypeError):
-                continue
-            status = statuses.get(vmid_key)
-            if status:
-                record["status"] = status
+        return statuses, unmanaged, node_status
 
     now = time.monotonic()
     with _MANAGED_CONTAINERS_CACHE_LOCK:
@@ -466,8 +604,19 @@ def _get_managed_containers_summary(force: bool = False) -> Dict[str, Any]:
         return cached
     config = _load_config()
     records = _load_managed_container_records()
-    _refresh_container_statuses(records, config)
-    summary = _build_managed_containers_summary(records)
+    managed_vmids: Set[str] = {
+        str(_to_int(record.get("vmid"))) for record in records if record.get("vmid") is not None
+    }
+    statuses, unmanaged, node_status = _refresh_container_statuses(records, config, managed_vmids)
+    for record in records:
+        vmid = record.get("vmid")
+        if vmid is None:
+            continue
+        vmid_key = str(_to_int(vmid))
+        status = statuses.get(vmid_key)
+        if status:
+            record["status"] = status
+    summary = _build_managed_containers_summary(records, unmanaged, node_status)
     with _MANAGED_CONTAINERS_CACHE_LOCK:
         _MANAGED_CONTAINERS_CACHE["timestamp"] = now
         _MANAGED_CONTAINERS_CACHE["summary"] = summary

{portacode-1.4.16.dev2.dist-info → portacode-1.4.16.dev4.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: portacode
-Version: 1.4.16.dev2
+Version: 1.4.16.dev4
 Summary: Portacode CLI client and SDK
 Home-page: https://github.com/portacode/portacode
 Author: Meena Erian

{portacode-1.4.16.dev2.dist-info → portacode-1.4.16.dev4.dist-info}/RECORD

@@ -1,7 +1,7 @@
 portacode/README.md,sha256=4dKtpvR8LNgZPVz37GmkQCMWIr_u25Ao63iW56s7Ke4,775
 portacode/__init__.py,sha256=oB3sV1wXr-um-RXio73UG8E5Xx6cF2ZVJveqjNmC-vQ,1086
 portacode/__main__.py,sha256=jmHTGC1hzmo9iKJLv-SSYe9BSIbPPZ2IOpecI03PlTs,296
-portacode/_version.py,sha256=s515CTO7U0276keYdIuPfegW6lNay9X4hqIIs7ajLn4,719
+portacode/_version.py,sha256=hp5vdfqkrwByAm4WdqNsKpWfJgPUKIkE5hM-7_9gKU4,719
 portacode/cli.py,sha256=mGLKoZ-T2FBF7IA9wUq0zyG0X9__-A1ao7gajjcVRH8,21828
 portacode/data.py,sha256=5-s291bv8J354myaHm1Y7CQZTZyRzMU3TGe5U4hb-FA,1591
 portacode/keypair.py,sha256=0OO4vHDcF1XMxCDqce61xFTlFwlTcmqe5HyGsXFEt7s,5838
@@ -14,7 +14,7 @@ portacode/connection/client.py,sha256=jtLb9_YufqPkzi9t8VQH3iz_JEMisbtY6a8L9U5wei
 portacode/connection/multiplex.py,sha256=L-TxqJ_ZEbfNEfu1cwxgJ5vUdyRzZjsMy2Kx1diiZys,5237
 portacode/connection/terminal.py,sha256=n1Uu92JacV5K6d1Qwx94Tw9OB2Tpke5HqsW2NDn76Ls,49032
 portacode/connection/handlers/README.md,sha256=HsLZG1QK1JNm67HsgL6WoDg9nxzKXxwkc5fJPFJdX5g,12169
-portacode/connection/handlers/WEBSOCKET_PROTOCOL.md,sha256=Dfkx6is1Xwt1PgCRqTKrP2zhfy3TmkmhSx9G29VMLB8,101054
+portacode/connection/handlers/WEBSOCKET_PROTOCOL.md,sha256=U7zkUpwscWf5aqimNIP3uYXvg-t9S0MhyaZ3ygF-ADk,102593
 portacode/connection/handlers/__init__.py,sha256=WSeBmi65GWFQPYt9M3E10rn0uZ_EPCJzNJOzSf2HZyw,2921
 portacode/connection/handlers/base.py,sha256=oENFb-Fcfzwk99Qx8gJQriEMiwSxwygwjOiuCH36hM4,10231
 portacode/connection/handlers/chunked_content.py,sha256=h6hXRmxSeOgnIxoU8CkmvEf2Odv-ajPrpHIe_W3GKcA,9251
@@ -22,7 +22,7 @@ portacode/connection/handlers/diff_handlers.py,sha256=iYTIRCcpEQ03vIPKZCsMTE5aZb
 portacode/connection/handlers/file_handlers.py,sha256=nAJH8nXnX07xxD28ngLpgIUzcTuRwZBNpEGEKdRqohw,39507
 portacode/connection/handlers/project_aware_file_handlers.py,sha256=AqgMnDqX2893T2NsrvUSCwjN5VKj4Pb2TN0S_SuboOE,9803
 portacode/connection/handlers/project_state_handlers.py,sha256=v6ZefGW9i7n1aZLq2jOGumJIjYb6aHlPI4m1jkYewm8,1686
-portacode/connection/handlers/proxmox_infra.py,sha256=LEUj6jVyP73sD6Wp2-m3SAj0rkXQo_wpiXyyNdpg6Zo,72906
+portacode/connection/handlers/proxmox_infra.py,sha256=DQJX8-lENZxeAaC6pSw6AfXE_4E_q-63nCK7issIldU,78531
 portacode/connection/handlers/registry.py,sha256=qXGE60sYEWg6ZtVQzFcZ5YI2XWR6lMgw4hAL9x5qR1I,6181
 portacode/connection/handlers/session.py,sha256=uNGfiO_1B9-_yjJKkpvmbiJhIl6b-UXlT86UTfd6WYE,42219
 portacode/connection/handlers/system_handlers.py,sha256=fr12QpOr_Z8KYGUU-AYrTQwRPAcrLK85hvj3SEq1Kw8,14757
@@ -65,7 +65,7 @@ portacode/utils/__init__.py,sha256=NgBlWTuNJESfIYJzP_3adI1yJQJR0XJLRpSdVNaBAN0,3
 portacode/utils/diff_apply.py,sha256=4Oi7ft3VUCKmiUE4VM-OeqO7Gk6H7PF3WnN4WHXtjxI,15157
 portacode/utils/diff_renderer.py,sha256=S76StnQ2DLfsz4Gg0m07UwPfRp8270PuzbNaQq-rmYk,13850
 portacode/utils/ntp_clock.py,sha256=VqCnWCTehCufE43W23oB-WUdAZGeCcLxkmIOPwInYHc,2499
-portacode-1.4.16.dev2.dist-info/licenses/LICENSE,sha256=2FGbCnUDgRYuQTkB1O1dUUpu5CVAjK1j4_p6ack9Z54,1066
+portacode-1.4.16.dev4.dist-info/licenses/LICENSE,sha256=2FGbCnUDgRYuQTkB1O1dUUpu5CVAjK1j4_p6ack9Z54,1066
 test_modules/README.md,sha256=Do_agkm9WhSzueXjRAkV_xEj6Emy5zB3N3VKY5Roce8,9274
 test_modules/__init__.py,sha256=1LcbHodIHsB0g-g4NGjSn6AMuCoGbymvXPYLOb6Z7F0,53
 test_modules/test_device_online.py,sha256=QtYq0Dq9vME8Gp2O4fGSheqVf8LUtpsSKosXXk56gGM,1654
@@ -91,8 +91,8 @@ testing_framework/core/playwright_manager.py,sha256=Tw46qwxIhOFkS48C2IWIQHHNpEe-
 testing_framework/core/runner.py,sha256=j2QwNJmAxVBmJvcbVS7DgPJUKPNzqfLmt_4NNdaKmZU,19297
 testing_framework/core/shared_cli_manager.py,sha256=BESSNtyQb7BOlaOvZmm04T8Uezjms4KCBs2MzTxvzYQ,8790
 testing_framework/core/test_discovery.py,sha256=2FZ9fJ8Dp5dloA-fkgXoJ_gCMC_nYPBnA3Hs2xlagzM,4928
-portacode-1.4.16.dev2.dist-info/METADATA,sha256=J7EuYnoswnTNe3Qdhq_0fMvtZdHNqFvlXAtg4dfvDX8,13051
-portacode-1.4.16.dev2.dist-info/WHEEL,sha256=wUyA8OaulRlbfwMtmQsvNngGrxQHAvkKcvRmdizlJi0,92
-portacode-1.4.16.dev2.dist-info/entry_points.txt,sha256=lLUUL-BM6_wwe44Xv0__5NQ1BnAz6jWjSMFvZdWW3zU,48
-portacode-1.4.16.dev2.dist-info/top_level.txt,sha256=TGhTYUxfW8SyVZc_zGgzjzc24gGT7nSw8Qf73liVRKM,41
-portacode-1.4.16.dev2.dist-info/RECORD,,
+portacode-1.4.16.dev4.dist-info/METADATA,sha256=Ld82LaJqGIk-94oOxKNjvrJh_vCwvuadSBHkpr-FucQ,13051
+portacode-1.4.16.dev4.dist-info/WHEEL,sha256=wUyA8OaulRlbfwMtmQsvNngGrxQHAvkKcvRmdizlJi0,92
+portacode-1.4.16.dev4.dist-info/entry_points.txt,sha256=lLUUL-BM6_wwe44Xv0__5NQ1BnAz6jWjSMFvZdWW3zU,48
+portacode-1.4.16.dev4.dist-info/top_level.txt,sha256=TGhTYUxfW8SyVZc_zGgzjzc24gGT7nSw8Qf73liVRKM,41
+portacode-1.4.16.dev4.dist-info/RECORD,,