portacode 1.4.15.dev19__py3-none-any.whl → 1.4.15.dev21__py3-none-any.whl

portacode/_version.py

@@ -28,7 +28,7 @@ version_tuple: VERSION_TUPLE
 commit_id: COMMIT_ID
 __commit_id__: COMMIT_ID
 
-__version__ = version = '1.4.15.dev19'
-__version_tuple__ = version_tuple = (1, 4, 15, 'dev19')
+__version__ = version = '1.4.15.dev21'
+__version_tuple__ = version_tuple = (1, 4, 15, 'dev21')
 
 __commit_id__ = commit_id = None

portacode/connection/handlers/proxmox_infra.py

@@ -608,20 +608,28 @@ def _build_bootstrap_steps(
     steps.extend(
         [
             {"name": "user_exists", "cmd": f"id -u {user} >/dev/null 2>&1 || adduser --disabled-password --gecos '' {user}", "retries": 0},
-            {
-                "name": "add_sudo",
-                "cmd": (
-                    f"if command -v usermod >/dev/null 2>&1; then "
-                    f"usermod -aG sudo {user}; "
-                    "else "
-                    "  addgroup wheel >/dev/null 2>&1 || true; "
-                    "  addgroup sudo >/dev/null 2>&1 || true; "
-                    f"  addgroup {user} wheel >/dev/null 2>&1 || true; "
-                    f"  addgroup {user} sudo >/dev/null 2>&1 || true; "
-                    "fi"
-                ),
-                "retries": 0,
-            },
+        {
+            "name": "add_sudo",
+            "cmd": (
+                f"if command -v usermod >/dev/null 2>&1; then "
+                "  if ! getent group sudo >/dev/null 2>&1; then "
+                "    if command -v groupadd >/dev/null 2>&1; then "
+                "      groupadd sudo >/dev/null 2>&1 || true; "
+                "    fi; "
+                "  fi; "
+                f"  usermod -aG sudo {user}; "
+                "else "
+                "  for grp in wheel sudo; do "
+                "    if ! getent group \"$grp\" >/dev/null 2>&1 && command -v groupadd >/dev/null 2>&1; then "
+                "      groupadd \"$grp\" >/dev/null 2>&1 || true; "
+                "    fi; "
+                "    addgroup \"$grp\" >/dev/null 2>&1 || true; "
+                f"    addgroup {user} \"$grp\" >/dev/null 2>&1 || true; "
+                "  done; "
+                "fi"
+            ),
+            "retries": 0,
+        },
         ]
     )
     if password:
@@ -884,6 +892,10 @@ def _run_pct(vmid: int, cmd: str, input_text: Optional[str] = None) -> Dict[str,
     }
 
 
+def _su_command(user: str, command: str) -> str:
+    return f"su - {user} -s /bin/sh -c {shlex.quote(command)}"
+
+
 def _run_pct_check(vmid: int, cmd: str) -> Dict[str, Any]:
     res = _run_pct(vmid, cmd)
     if res["returncode"] != 0:
@@ -943,7 +955,7 @@ def _push_bytes_to_container(
 
 
 def _resolve_portacode_key_dir(vmid: int, user: str) -> str:
-    data_dir_cmd = f"su - {user} -c 'echo -n ${{XDG_DATA_HOME:-$HOME/.local/share}}'"
+    data_dir_cmd = _su_command(user, "echo -n ${XDG_DATA_HOME:-$HOME/.local/share}")
     data_home = _run_pct_check(vmid, data_dir_cmd)["stdout"].strip()
     portacode_dir = f"{data_home}/portacode"
     _run_pct_exec_check(vmid, ["mkdir", "-p", portacode_dir])
@@ -960,18 +972,19 @@ def _deploy_device_keypair(vmid: int, user: str, private_key: str, public_key: s
 
 
 def _portacode_connect_and_read_key(vmid: int, user: str, timeout_s: int = 10) -> Dict[str, Any]:
-    cmd = ["pct", "exec", str(vmid), "--", "bash", "-lc", f"su - {user} -c 'portacode connect'"]
+    su_connect_cmd = _su_command(user, "portacode connect")
+    cmd = ["pct", "exec", str(vmid), "--", "/bin/sh", "-c", su_connect_cmd]
     proc = subprocess.Popen(cmd, text=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     start = time.time()
 
-    data_dir_cmd = f"su - {user} -c 'echo -n ${{XDG_DATA_HOME:-$HOME/.local/share}}'"
+    data_dir_cmd = _su_command(user, "echo -n ${XDG_DATA_HOME:-$HOME/.local/share}")
     data_dir = _run_pct_check(vmid, data_dir_cmd)["stdout"].strip()
     key_dir = f"{data_dir}/portacode/keys"
     pub_path = f"{key_dir}/id_portacode.pub"
     priv_path = f"{key_dir}/id_portacode"
 
     def file_size(path: str) -> Optional[int]:
-        stat_cmd = f"su - {user} -c 'test -s {path} && stat -c %s {path}'"
+        stat_cmd = _su_command(user, f"test -s {path} && stat -c %s {path}")
         res = _run_pct(vmid, stat_cmd)
         if res["returncode"] != 0:
             return None
@@ -1029,7 +1042,7 @@ def _portacode_connect_and_read_key(vmid: int, user: str, timeout_s: int = 10) -
     final_pub = file_size(pub_path)
     final_priv = file_size(priv_path)
     if final_pub and final_priv:
-        key_res = _run_pct(vmid, f"su - {user} -c 'cat {pub_path}'")
+        key_res = _run_pct(vmid, _su_command(user, f"cat {pub_path}"))
         if not process_exited:
             proc.terminate()
             try:
@@ -1069,7 +1082,7 @@ def _portacode_connect_and_read_key(vmid: int, user: str, timeout_s: int = 10) -
     except subprocess.TimeoutExpired:
         proc.kill()
 
-    key_res = _run_pct(vmid, f"su - {user} -c 'cat {pub_path}'")
+    key_res = _run_pct(vmid, _su_command(user, f"cat {pub_path}"))
     return {
         "ok": True,
         "public_key": key_res["stdout"].strip(),
@@ -1612,7 +1625,7 @@ class CreateProxmoxContainerHandler(SyncHandler):
                 on_behalf_of_device=device_id,
             )
 
-            cmd = f"su - {payload['username']} -c 'sudo -S portacode service install'"
+            cmd = _su_command(payload["username"], "sudo -S portacode service install")
             res = _run_pct(vmid, cmd, input_text=payload["password"] + "\n")
 
             if res["returncode"] != 0:
@@ -1744,7 +1757,7 @@ class StartPortacodeServiceHandler(SyncHandler):
             on_behalf_of_device=on_behalf_of_device,
         )
 
-        cmd = f"su - {user} -c 'sudo -S portacode service install'"
+        cmd = _su_command(user, "sudo -S portacode service install")
         res = _run_pct(vmid, cmd, input_text=password + "\n")
 
         if res["returncode"] != 0:

{portacode-1.4.15.dev19.dist-info → portacode-1.4.15.dev21.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: portacode
-Version: 1.4.15.dev19
+Version: 1.4.15.dev21
 Summary: Portacode CLI client and SDK
 Home-page: https://github.com/portacode/portacode
 Author: Meena Erian

{portacode-1.4.15.dev19.dist-info → portacode-1.4.15.dev21.dist-info}/RECORD

@@ -1,7 +1,7 @@
 portacode/README.md,sha256=4dKtpvR8LNgZPVz37GmkQCMWIr_u25Ao63iW56s7Ke4,775
 portacode/__init__.py,sha256=oB3sV1wXr-um-RXio73UG8E5Xx6cF2ZVJveqjNmC-vQ,1086
 portacode/__main__.py,sha256=jmHTGC1hzmo9iKJLv-SSYe9BSIbPPZ2IOpecI03PlTs,296
-portacode/_version.py,sha256=SHpiSRJiC6Gyo_LZbcMuMheGquhQYp8kpipHfjZ1VCs,721
+portacode/_version.py,sha256=U9P73QDPcoNTjwvbpqz9ybWnBOiKr03eV2nhMcRk5Xo,721
 portacode/cli.py,sha256=mGLKoZ-T2FBF7IA9wUq0zyG0X9__-A1ao7gajjcVRH8,21828
 portacode/data.py,sha256=5-s291bv8J354myaHm1Y7CQZTZyRzMU3TGe5U4hb-FA,1591
 portacode/keypair.py,sha256=0OO4vHDcF1XMxCDqce61xFTlFwlTcmqe5HyGsXFEt7s,5838
@@ -22,7 +22,7 @@ portacode/connection/handlers/diff_handlers.py,sha256=iYTIRCcpEQ03vIPKZCsMTE5aZb
 portacode/connection/handlers/file_handlers.py,sha256=nAJH8nXnX07xxD28ngLpgIUzcTuRwZBNpEGEKdRqohw,39507
 portacode/connection/handlers/project_aware_file_handlers.py,sha256=AqgMnDqX2893T2NsrvUSCwjN5VKj4Pb2TN0S_SuboOE,9803
 portacode/connection/handlers/project_state_handlers.py,sha256=v6ZefGW9i7n1aZLq2jOGumJIjYb6aHlPI4m1jkYewm8,1686
-portacode/connection/handlers/proxmox_infra.py,sha256=6ILb0nSisU44UziVkONaVsYJSHjkvIMNP8x0oxAUgYo,70249
+portacode/connection/handlers/proxmox_infra.py,sha256=xm2utGUde1wZjH_ltMJHTL1Ibvxh_LYgeHmfFi4zUIw,70766
 portacode/connection/handlers/registry.py,sha256=qXGE60sYEWg6ZtVQzFcZ5YI2XWR6lMgw4hAL9x5qR1I,6181
 portacode/connection/handlers/session.py,sha256=uNGfiO_1B9-_yjJKkpvmbiJhIl6b-UXlT86UTfd6WYE,42219
 portacode/connection/handlers/system_handlers.py,sha256=fr12QpOr_Z8KYGUU-AYrTQwRPAcrLK85hvj3SEq1Kw8,14757
@@ -65,7 +65,7 @@ portacode/utils/__init__.py,sha256=NgBlWTuNJESfIYJzP_3adI1yJQJR0XJLRpSdVNaBAN0,3
 portacode/utils/diff_apply.py,sha256=4Oi7ft3VUCKmiUE4VM-OeqO7Gk6H7PF3WnN4WHXtjxI,15157
 portacode/utils/diff_renderer.py,sha256=S76StnQ2DLfsz4Gg0m07UwPfRp8270PuzbNaQq-rmYk,13850
 portacode/utils/ntp_clock.py,sha256=VqCnWCTehCufE43W23oB-WUdAZGeCcLxkmIOPwInYHc,2499
-portacode-1.4.15.dev19.dist-info/licenses/LICENSE,sha256=2FGbCnUDgRYuQTkB1O1dUUpu5CVAjK1j4_p6ack9Z54,1066
+portacode-1.4.15.dev21.dist-info/licenses/LICENSE,sha256=2FGbCnUDgRYuQTkB1O1dUUpu5CVAjK1j4_p6ack9Z54,1066
 test_modules/README.md,sha256=Do_agkm9WhSzueXjRAkV_xEj6Emy5zB3N3VKY5Roce8,9274
 test_modules/__init__.py,sha256=1LcbHodIHsB0g-g4NGjSn6AMuCoGbymvXPYLOb6Z7F0,53
 test_modules/test_device_online.py,sha256=QtYq0Dq9vME8Gp2O4fGSheqVf8LUtpsSKosXXk56gGM,1654
@@ -91,8 +91,8 @@ testing_framework/core/playwright_manager.py,sha256=Tw46qwxIhOFkS48C2IWIQHHNpEe-
 testing_framework/core/runner.py,sha256=j2QwNJmAxVBmJvcbVS7DgPJUKPNzqfLmt_4NNdaKmZU,19297
 testing_framework/core/shared_cli_manager.py,sha256=BESSNtyQb7BOlaOvZmm04T8Uezjms4KCBs2MzTxvzYQ,8790
 testing_framework/core/test_discovery.py,sha256=2FZ9fJ8Dp5dloA-fkgXoJ_gCMC_nYPBnA3Hs2xlagzM,4928
-portacode-1.4.15.dev19.dist-info/METADATA,sha256=JJoI5trJDjoXJyfMRfg2wL9S0EqmMalHzgYahQnyehc,13052
-portacode-1.4.15.dev19.dist-info/WHEEL,sha256=wUyA8OaulRlbfwMtmQsvNngGrxQHAvkKcvRmdizlJi0,92
-portacode-1.4.15.dev19.dist-info/entry_points.txt,sha256=lLUUL-BM6_wwe44Xv0__5NQ1BnAz6jWjSMFvZdWW3zU,48
-portacode-1.4.15.dev19.dist-info/top_level.txt,sha256=TGhTYUxfW8SyVZc_zGgzjzc24gGT7nSw8Qf73liVRKM,41
-portacode-1.4.15.dev19.dist-info/RECORD,,
+portacode-1.4.15.dev21.dist-info/METADATA,sha256=e65XngiIyI4jPmQqu43qYc3XVYJfYwzQJQAlftfm2ww,13052
+portacode-1.4.15.dev21.dist-info/WHEEL,sha256=wUyA8OaulRlbfwMtmQsvNngGrxQHAvkKcvRmdizlJi0,92
+portacode-1.4.15.dev21.dist-info/entry_points.txt,sha256=lLUUL-BM6_wwe44Xv0__5NQ1BnAz6jWjSMFvZdWW3zU,48
+portacode-1.4.15.dev21.dist-info/top_level.txt,sha256=TGhTYUxfW8SyVZc_zGgzjzc24gGT7nSw8Qf73liVRKM,41
+portacode-1.4.15.dev21.dist-info/RECORD,,