port-ocean 0.24.10__py3-none-any.whl → 0.24.11__py3-none-any.whl

port_ocean/core/handlers/webhook/processor_manager.py

@@ -8,6 +8,7 @@ from port_ocean.context.event import EventType, event_context
 from port_ocean.core.handlers.port_app_config.models import ResourceConfig
 from port_ocean.core.integrations.mixins.events import EventsMixin
 from port_ocean.core.integrations.mixins.live_events import LiveEventsMixin
+from port_ocean.exceptions.webhook_processor import WebhookEventNotSupportedError
 from .webhook_event import WebhookEvent, WebhookEventRawResults, LiveEventTimestamp
 from port_ocean.context.event import event
 
@@ -53,10 +54,12 @@ class LiveEventsProcessorManager(LiveEventsMixin, EventsMixin):
         """Find and extract the matching processor for an event"""
 
         created_processors: list[tuple[ResourceConfig, AbstractWebhookProcessor]] = []
+        event_processor_names = []
 
         for processor_class in self._processors_classes[path]:
             processor = processor_class(webhook_event.clone())
             if await processor.should_process_event(webhook_event):
+                event_processor_names.append(processor.__class__.__name__)
                 kinds = await processor.get_matching_kinds(webhook_event)
                 for kind in kinds:
                     for resource in event.port_app_config.resources:
@@ -64,7 +67,22 @@ class LiveEventsProcessorManager(LiveEventsMixin, EventsMixin):
                             created_processors.append((resource, processor))
 
         if not created_processors:
-            raise ValueError("No matching processors found")
+            if event_processor_names:
+                logger.info(
+                    "Webhook processors are available to handle this webhook event, but the corresponding kinds are not configured in the integration's mapping",
+                    processors_available=event_processor_names,
+                    webhook_path=path,
+                )
+                return []
+            else:
+                logger.warning(
+                    "Unknown webhook event type received",
+                    webhook_path=path,
+                    message="No processors registered to handle this webhook event type.",
+                )
+                raise WebhookEventNotSupportedError(
+                    "No matching processors found for webhook event"
+                )
 
         logger.info(
             "Found matching processors for webhook event",

port_ocean/exceptions/webhook_processor.py

@@ -1,4 +1,17 @@
+from port_ocean.exceptions.base import BaseOceanException
+
+
 class RetryableError(Exception):
     """Base exception class for errors that should trigger a retry."""
 
     pass
+
+
+class WebhookProcessingError(BaseOceanException):
+    """Base exception for webhook processing errors"""
+
+    pass
+
+
+class WebhookEventNotSupportedError(WebhookProcessingError):
+    pass

port_ocean/tests/core/handlers/webhook/test_processor_manager.py

@@ -37,7 +37,10 @@ from port_ocean.core.handlers.port_app_config.models import (
 )
 from port_ocean.core.integrations.mixins.live_events import LiveEventsMixin
 from port_ocean.core.models import Entity
-from port_ocean.exceptions.webhook_processor import RetryableError
+from port_ocean.exceptions.webhook_processor import (
+    RetryableError,
+    WebhookEventNotSupportedError,
+)
 from port_ocean.core.handlers.queue import LocalQueue
 
 
@@ -354,7 +357,9 @@ async def test_extractMatchingProcessors_noMatch(
     test_path = "/test"
     processor_manager.register_processor(test_path, MockProcessorFalse)
 
-    with pytest.raises(ValueError, match="No matching processors found"):
+    with pytest.raises(
+        WebhookEventNotSupportedError, match="No matching processors found"
+    ):
         async with event_context(
             EventType.HTTP_REQUEST, trigger_type="request"
         ) as event:
@@ -409,6 +414,82 @@ async def test_extractMatchingProcessors_onlyOneMatches(
     assert processor.event.payload == webhook_event.payload
 
 
+@pytest.mark.asyncio
+async def test_extractMatchingProcessors_noProcessorsRegistered(
+    processor_manager: LiveEventsProcessorManager,
+    webhook_event: WebhookEvent,
+    mock_port_app_config: PortAppConfig,
+) -> None:
+    """Test that WebhookEventNotSupportedError is raised for unknown events without any registered processors"""
+    test_path = "/unknown_path"
+    # No processors registered for this path
+
+    # Manually add the path to _processors_classes to simulate a path with no processors
+    processor_manager._processors_classes[test_path] = []
+
+    with pytest.raises(
+        WebhookEventNotSupportedError, match="No matching processors found"
+    ):
+        async with event_context(
+            EventType.HTTP_REQUEST, trigger_type="request"
+        ) as event:
+            event.port_app_config = mock_port_app_config
+            await processor_manager._extract_matching_processors(
+                webhook_event, test_path
+            )
+
+
+@pytest.mark.asyncio
+async def test_extractMatchingProcessors_processorsAvailableButKindsNotConfigured(
+    processor_manager: LiveEventsProcessorManager,
+    webhook_event: WebhookEvent,
+) -> None:
+    """Test that processors available but kinds not configured returns empty list"""
+    test_path = "/test"
+
+    from port_ocean.core.handlers.port_app_config.models import (
+        PortAppConfig,
+        ResourceConfig,
+    )
+
+    # Create a mock processor that will match the event but return a kind not in the port app config
+    class MockProcessorWithUnmappedKind(AbstractWebhookProcessor):
+        async def authenticate(
+            self, payload: Dict[str, Any], headers: Dict[str, str]
+        ) -> bool:
+            return True
+
+        async def validate_payload(self, payload: Dict[str, Any]) -> bool:
+            return True
+
+        async def handle_event(
+            self, payload: EventPayload, resource: ResourceConfig
+        ) -> WebhookEventRawResults:
+            return WebhookEventRawResults(
+                updated_raw_results=[], deleted_raw_results=[]
+            )
+
+        async def should_process_event(self, event: WebhookEvent) -> bool:
+            return True  # This processor will match
+
+        async def get_matching_kinds(self, event: WebhookEvent) -> list[str]:
+            return ["unmapped_kind"]  # This kind is not in the mock_port_app_config
+
+    processor_manager.register_processor(test_path, MockProcessorWithUnmappedKind)
+
+    empty_port_app_config = PortAppConfig(
+        resources=[],
+    )
+
+    async with event_context(EventType.HTTP_REQUEST, trigger_type="request") as event:
+        event.port_app_config = empty_port_app_config
+        processors = await processor_manager._extract_matching_processors(
+            webhook_event, test_path
+        )
+
+    assert len(processors) == 0
+
+
 def test_registerProcessor_registrationWorks(
     processor_manager: LiveEventsProcessorManager,
 ) -> None:
@@ -853,7 +934,10 @@ async def test_integrationTest_postRequestSent_noMatchingHandlers_entityNotUpser
     except asyncio.TimeoutError:
         pytest.fail("Event processing timed out")
 
-    assert isinstance(test_state["exception_thrown"], ValueError) is True
+    assert (
+        isinstance(test_state["exception_thrown"], WebhookEventNotSupportedError)
+        is True
+    )
 
     mock_upsert.assert_not_called()
     mock_delete.assert_not_called()

{port_ocean-0.24.10.dist-info → port_ocean-0.24.11.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: port-ocean
-Version: 0.24.10
+Version: 0.24.11
 Summary: Port Ocean is a CLI tool for managing your Port projects.
 Home-page: https://app.getport.io
 Keywords: ocean,port-ocean,port

{port_ocean-0.24.10.dist-info → port_ocean-0.24.11.dist-info}/RECORD

@@ -112,7 +112,7 @@ port_ocean/core/handlers/resync_state_updater/__init__.py,sha256=kG6y-JQGpPfuTHh
 port_ocean/core/handlers/resync_state_updater/updater.py,sha256=TRYq6QnTtPlJg6MvgZPtQdZPvkAhkvpcmWjtkxCnkg4,3764
 port_ocean/core/handlers/webhook/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 port_ocean/core/handlers/webhook/abstract_webhook_processor.py,sha256=5KwZkdkDd5HdVkXPzKiqabodZKl-hOtMypkTKd8Hq3M,3891
-port_ocean/core/handlers/webhook/processor_manager.py,sha256=ipyAXoFtF84EGczyzRcZCzQG4Ippjo4eMsnVxMVz12A,12072
+port_ocean/core/handlers/webhook/processor_manager.py,sha256=4u9Q_djZAzxgwGHlHBmVBG26svEigeSka6GajcETd20,12976
 port_ocean/core/handlers/webhook/webhook_event.py,sha256=9wHXLY6IGgjuqrwXXvZm_RbYEd-a9qIFNxWnGbfPv6o,3877
 port_ocean/core/integrations/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 port_ocean/core/integrations/base.py,sha256=dUhytVM9uUbcDRzG1QWyvBvEJOWZY0dPVV3hXuukOfg,3587
@@ -136,7 +136,7 @@ port_ocean/exceptions/context.py,sha256=mA8HII6Rl4QxKUz98ppy1zX3kaziaen21h1ZWuU3
 port_ocean/exceptions/core.py,sha256=3LpQrOWdZ-xZ8zm90DmTnFnk0Nms2OgrVIzZBK0Xw5M,931
 port_ocean/exceptions/port_defaults.py,sha256=2a7Koy541KxMan33mU-gbauUxsumG3NT4itVxSpQqfw,666
 port_ocean/exceptions/utils.py,sha256=gjOqpi-HpY1l4WlMFsGA9yzhxDhajhoGGdDDyGbLnqI,197
-port_ocean/exceptions/webhook_processor.py,sha256=yQYazg53Y-ohb7HfViwq1opH_ZUuUdhHSRxcUNveFpI,114
+port_ocean/exceptions/webhook_processor.py,sha256=4SnkVzVwiacH_Ip4qs1hRHa6GanhnojW_TLTdQQtm7Y,363
 port_ocean/helpers/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 port_ocean/helpers/async_client.py,sha256=SRlP6o7_FCSY3UHnRlZdezppePVxxOzZ0z861vE3K40,1783
 port_ocean/helpers/metric/metric.py,sha256=Aacz7bOd8ZCwEPpXAdwLbKRXf28Z4wiViG_GXiV_xWg,14529
@@ -171,7 +171,7 @@ port_ocean/tests/core/handlers/port_app_config/test_api.py,sha256=eJZ6SuFBLz71y4
 port_ocean/tests/core/handlers/port_app_config/test_base.py,sha256=hSh556bJM9zuELwhwnyKSfd9z06WqWXIfe-6hCl5iKI,9799
 port_ocean/tests/core/handlers/queue/test_local_queue.py,sha256=9Ly0HzZXbs6Rbl_bstsIdInC3h2bgABU3roP9S_PnJM,2582
 port_ocean/tests/core/handlers/webhook/test_abstract_webhook_processor.py,sha256=zKwHhPAYEZoZ5Z2UETp1t--mbkS8uyvlXThB0obZTTc,3340
-port_ocean/tests/core/handlers/webhook/test_processor_manager.py,sha256=6Zap3rKBd8Td7-a9af6_FWOGNDN4oZhNdWeeaICsLD0,49386
+port_ocean/tests/core/handlers/webhook/test_processor_manager.py,sha256=rqNFc-S_ZnPyDTSFTdiGcRFKbeDGfWQCH_f2UPbfcAA,52310
 port_ocean/tests/core/handlers/webhook/test_webhook_event.py,sha256=oR4dEHLO65mp6rkfNfszZcfFoRZlB8ZWee4XetmsuIk,3181
 port_ocean/tests/core/test_utils.py,sha256=Z3kdhb5V7Svhcyy3EansdTpgHL36TL6erNtU-OPwAcI,2647
 port_ocean/tests/core/utils/test_entity_topological_sorter.py,sha256=zuq5WSPy_88PemG3mOUIHTxWMR_js1R7tOzUYlgBd68,3447
@@ -200,8 +200,8 @@ port_ocean/utils/repeat.py,sha256=U2OeCkHPWXmRTVoPV-VcJRlQhcYqPWI5NfmPlb1JIbc,32
 port_ocean/utils/signal.py,sha256=mMVq-1Ab5YpNiqN4PkiyTGlV_G0wkUDMMjTZp5z3pb0,1514
 port_ocean/utils/time.py,sha256=pufAOH5ZQI7gXvOvJoQXZXZJV-Dqktoj9Qp9eiRwmJ4,1939
 port_ocean/version.py,sha256=UsuJdvdQlazzKGD3Hd5-U7N69STh8Dq9ggJzQFnu9fU,177
-port_ocean-0.24.10.dist-info/LICENSE.md,sha256=WNHhf_5RCaeuKWyq_K39vmp9F28LxKsB4SpomwSZ2L0,11357
-port_ocean-0.24.10.dist-info/METADATA,sha256=HmNsuzqUJLoc4RSEM9WmU7LKpzA2DI0pxkyvaZW0sQg,6853
-port_ocean-0.24.10.dist-info/WHEEL,sha256=Nq82e9rUAnEjt98J6MlVmMCZb-t9cYE2Ir1kpBmnWfs,88
-port_ocean-0.24.10.dist-info/entry_points.txt,sha256=F_DNUmGZU2Kme-8NsWM5LLE8piGMafYZygRYhOVtcjA,54
-port_ocean-0.24.10.dist-info/RECORD,,
+port_ocean-0.24.11.dist-info/LICENSE.md,sha256=WNHhf_5RCaeuKWyq_K39vmp9F28LxKsB4SpomwSZ2L0,11357
+port_ocean-0.24.11.dist-info/METADATA,sha256=5SPsmnSpVV2tiRRGdbP0SeRJZ3SJ2EUiPR_t-4oGupI,6853
+port_ocean-0.24.11.dist-info/WHEEL,sha256=Nq82e9rUAnEjt98J6MlVmMCZb-t9cYE2Ir1kpBmnWfs,88
+port_ocean-0.24.11.dist-info/entry_points.txt,sha256=F_DNUmGZU2Kme-8NsWM5LLE8piGMafYZygRYhOVtcjA,54
+port_ocean-0.24.11.dist-info/RECORD,,