pgdevkit 0.2.0__py3-none-any.whl → 0.2.1__py3-none-any.whl

pgdevkit/skills/pgdevkit/SKILL.md

@@ -75,6 +75,8 @@ def _testdb_env():
 
 `ensure_testdb()` starts the shared `pgdevkit-postgres` container if needed (via `podman`), creates a database scoped to this project+branch (so different worktrees/branches never collide), and applies every `.sql` file under `database_dir` in dependency order, seeding any `.test_data.json` sidecar files.
 
+**`migrations/` is never applied here, on purpose.** If the test schema is missing something, that's a sign the base `tables/`/`views`/... file has drifted behind a migration that was only ever run manually against a real database — fix the base file, don't add migration-replay to `apply_schema()` (tried once, reverted: a migration can't be judged "safe to re-run" from its SQL text alone — see `docs/database-layout.md`'s Migrations section).
+
 | What do you need? | Command |
 |---|---|
 | First-time setup / apply new files | `pgdb testdb up` |

pgdevkit/testdb/schema.py

@@ -172,54 +172,19 @@ async def _insert_test_data(
         await cur.executemany(insert_sql, rows)
 
 
-_UNSAFE_MIGRATION_PATTERNS = (
-    "DROP COLUMN",
-    "DROP TABLE",
-    "TRUNCATE",
-    "RENAME COLUMN",
-    "RENAME TO",
-    "DELETE FROM",
-    "OWNER TO",
-)
-
-
-def _is_additive_migration(sql: str) -> bool:
-    """Only pure-additive migrations (ADD COLUMN/CREATE ... IF NOT EXISTS,
-    etc.) are safe to (re-)apply against a schema that already reflects
-    later migrations — skip anything that could drop, rename, truncate, or
-    delete existing structure/data, alter an existing column, or change
-    ownership. This is a substring heuristic, not a SQL parser, so it errs
-    towards skipping (a false negative here means real data loss replayed
-    on every apply_schema() call) rather than trying to be exhaustive."""
-    normalized = sql.upper()
-    has_alter_column = "ALTER COLUMN" in normalized and "ADD COLUMN" not in normalized
-    has_unsafe_pattern = any(pattern in normalized for pattern in _UNSAFE_MIGRATION_PATTERNS)
-    return not (has_alter_column or has_unsafe_pattern)
-
-
-def _iter_migration_files(database_dir: Path):
-    """Yield every `*.sql` file in any `migrations/` subdirectory, in
-    filename order (the project's naming convention — numeric or date
-    prefixes — sorts chronologically)."""
-    for root, _, files in os.walk(database_dir):
-        if Path(root).name != "migrations":
-            continue
-        for file in sorted(files):
-            if file.endswith(".sql"):
-                yield Path(root) / file
-
-
 async def apply_schema(
     con: psycopg.AsyncConnection,
     database_dir: Path,
     extensions: tuple[str, ...] = (),
     force_reset: bool = False,
 ) -> None:
-    """Apply every .sql file under database_dir (in dependency-safe order),
-    seed any matching .test_data.json files, then apply purely-additive
-    `migrations/*.sql` files (see `_is_additive_migration`) so a schema that
-    ships changes via migration files rather than editing the base object
-    files stays in sync. Safe to call repeatedly."""
+    """Apply every .sql file under database_dir (in dependency-safe order)
+    and seed any matching .test_data.json files. Safe to call repeatedly.
+
+    `migrations/` subdirectories are never applied here — they're for
+    one-time manual application against real (already-provisioned)
+    databases, not for building a fresh schema. The base object files under
+    `database_dir` must reflect the current, final schema on their own."""
     await con.set_autocommit(True)
     for extension in extensions:
         await con.execute(SQL("CREATE EXTENSION IF NOT EXISTS {e}").format(e=Identifier(extension)))
@@ -243,13 +208,3 @@ async def apply_schema(
 
     for file, sql in failures:
         await _apply(file, sql)
-
-    for migration_file in _iter_migration_files(database_dir):
-        content = migration_file.read_text(encoding="utf-8")
-        if not _is_additive_migration(content):
-            continue
-        try:
-            await con.execute(cast(Any, content))
-            logger.info("Applied migration %s", migration_file.name)
-        except Exception as e:  # noqa: BLE001
-            logger.debug("Migration %s skipped (likely already applied): %s", migration_file.name, e)

{pgdevkit-0.2.0.dist-info → pgdevkit-0.2.1.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: pgdevkit
-Version: 0.2.0
+Version: 0.2.1
 Summary: A helper for developing with Postgres
 Requires-Python: >=3.14
 Requires-Dist: psycopg[binary]>=3.2.0

{pgdevkit-0.2.0.dist-info → pgdevkit-0.2.1.dist-info}/RECORD

@@ -20,12 +20,12 @@ pgdevkit/testdb/constants.py,sha256=xi8uIoEgN9LrRkr41j3mmWB9PqqU0r8aCUb2JJXBAs0,
 pgdevkit/testdb/container.py,sha256=24zl2_0mX24RTa2NCxps8RlJQAzdAif15TWgoVjNtMc,2974
 pgdevkit/testdb/naming.py,sha256=Kyk5qEfxUkbggUG5bD7U7CJ_kAET332VPQNB-O5kvTY,1318
 pgdevkit/testdb/query.py,sha256=e4UbgdCKKIot3a8Qixg-OX-Af0rlQ4a8ODhJBD8mtVM,2318
-pgdevkit/testdb/schema.py,sha256=99Wnl2JAD_kd5226uCAAHEcd_fl23D-kNYmt16asRgM,9573
+pgdevkit/testdb/schema.py,sha256=Pz5wWiDz9sNyCe-VK_au7A-saTXzTGKVIorGFrbyV5I,7730
 pgdevkit/docs/database-layout.md,sha256=dNvDH956xSXuAnLqkOopyOfaIm_A-RtUd57VTaZ1GQU,6035
-pgdevkit/skills/pgdevkit/SKILL.md,sha256=anvsNNeC1-ixUk70L9owyQlQtN6_wUhykOGqU3mAboY,11524
+pgdevkit/skills/pgdevkit/SKILL.md,sha256=CJS3LC5x8tjb6mJc8q_XQCknOwUd5LGSof3hteLsH2Y,11975
 pgdevkit/skills/pgdevkit/references/dynamic-sql.md,sha256=aTR1sx81moiTwaMaiOecaqk-9rT8y5Zxz7W1BoC3vK0,2774
 pgdevkit/skills/pgdevkit/references/temporal-tables.md,sha256=LwZnItvQWI7bB0oRHxIfUc0ynnq7N0V5Mnv-QHvFN3Q,1364
-pgdevkit-0.2.0.dist-info/METADATA,sha256=1KBvcghDMMHNmZ-IOBKawFnsdDiD2797b4dQZwX2mlg,5651
-pgdevkit-0.2.0.dist-info/WHEEL,sha256=lCkmxWfQsSc9CfIClYeavTdQeEX2toPqufh9gI35EQA,87
-pgdevkit-0.2.0.dist-info/entry_points.txt,sha256=FK2P55lf0WaGlOZJIINOGgCt8WB7ep0OnPsgnrp80bg,42
-pgdevkit-0.2.0.dist-info/RECORD,,
+pgdevkit-0.2.1.dist-info/METADATA,sha256=VFDuRtm67C2UT4kl2QffVrwL0RNuC2U4ySUFU0st8I0,5651
+pgdevkit-0.2.1.dist-info/WHEEL,sha256=lCkmxWfQsSc9CfIClYeavTdQeEX2toPqufh9gI35EQA,87
+pgdevkit-0.2.1.dist-info/entry_points.txt,sha256=FK2P55lf0WaGlOZJIINOGgCt8WB7ep0OnPsgnrp80bg,42
+pgdevkit-0.2.1.dist-info/RECORD,,