passagemath-modules 10.5.32__cp310-cp310-macosx_14_0_arm64.whl → 10.6.20__cp310-cp310-macosx_14_0_arm64.whl

sage/quadratic_forms/quadratic_form__local_field_invariants.py

@@ -617,7 +617,7 @@ def is_hyperbolic(self, p) -> bool:
             self.hasse_invariant(p) == 1)
 
 
-def is_anisotropic(self, p):
+def is_anisotropic(self, p) -> bool:
     r"""
     Check if the quadratic form is anisotropic over the `p`-adic numbers `\QQ_p` or `\RR`.
 
@@ -687,7 +687,7 @@ def is_anisotropic(self, p):
     raise NotImplementedError("we have not established a convention for 0-dim'l quadratic forms")
 
 
-def is_isotropic(self, p):
+def is_isotropic(self, p) -> bool:
     r"""
     Check if `Q` is isotropic over the `p`-adic numbers `\QQ_p` or `\RR`.
 
@@ -926,9 +926,9 @@ def compute_definiteness_string_by_determinants(self):
     return "pos_def" if first_coeff > 0 else "neg_def"
 
 
-def is_positive_definite(self):
+def is_positive_definite(self) -> bool:
     """
-    Determines if the given quadratic form is positive-definite.
+    Determine if the given quadratic form is positive-definite.
 
     .. NOTE::
 
@@ -963,9 +963,9 @@ def is_positive_definite(self):
     return (def_str == "pos_def") or (def_str == "zero")
 
 
-def is_negative_definite(self):
+def is_negative_definite(self) -> bool:
     """
-    Determines if the given quadratic form is negative-definite.
+    Determine if the given quadratic form is negative-definite.
 
     .. NOTE::
 
@@ -1000,9 +1000,9 @@ def is_negative_definite(self):
     return (def_str == "neg_def") or (def_str == "zero")
 
 
-def is_indefinite(self):
+def is_indefinite(self) -> bool:
     """
-    Determines if the given quadratic form is indefinite.
+    Determine if the given quadratic form is indefinite.
 
     .. NOTE::
 
@@ -1037,9 +1037,9 @@ def is_indefinite(self):
     return def_str == "indefinite"
 
 
-def is_definite(self):
+def is_definite(self) -> bool:
     """
-    Determines if the given quadratic form is (positive or negative) definite.
+    Determine if the given quadratic form is (positive or negative) definite.
 
     .. NOTE::
 

sage/quadratic_forms/quadratic_form__ternary_Tornaria.py

@@ -90,7 +90,7 @@ def content(self):
 
 
 # in quadratic_form.py
-# def is_primitive(self):
+# def is_primitive(self) -> bool:
 #     """
 #     Checks if the form is a multiple of another form... only over ZZ for now.
 #     """
@@ -111,7 +111,7 @@ def content(self):
 
 def adjoint(self):
     """
-    This gives the adjoint (integral) quadratic form associated to the
+    Return the adjoint (integral) quadratic form associated to the
     given form, essentially defined by taking the adjoint of the matrix.
 
     EXAMPLES::

sage/quadratic_forms/ternary_qf.py

@@ -71,7 +71,8 @@ class TernaryQF(SageObject):
         sage: TestSuite(TernaryQF).run()
     """
 
-    __slots__ = ['_a', '_b', '_c', '_r', '_s', '_t', '_automorphisms', '_number_of_automorphisms']
+    __slots__ = ['_a', '_b', '_c', '_r', '_s', '_t',
+                 '_automorphisms', '_number_of_automorphisms']
 
     possible_automorphisms = None
 
@@ -91,7 +92,6 @@ class TernaryQF(SageObject):
             [1 2 3]
             [4 5 6]
         """
-
         if len(v) != 6:
             # Check we have six coefficients
             raise ValueError("Ternary quadratic form must be given by a list of six coefficients")
@@ -99,9 +99,9 @@ class TernaryQF(SageObject):
         self._automorphisms = None
         self._number_of_automorphisms = None
 
-    def coefficients(self):
+    def coefficients(self) -> tuple:
         r"""
-        Return the list of coefficients of the ternary quadratic form.
+        Return the tuple of coefficients of the ternary quadratic form.
 
         EXAMPLES::
 
@@ -114,7 +114,7 @@ class TernaryQF(SageObject):
         """
         return self._a, self._b, self._c, self._r, self._s, self._t
 
-    def __hash__(self):
+    def __hash__(self) -> int:
         """
         Return a hash for ``self``.
 
@@ -125,7 +125,6 @@ class TernaryQF(SageObject):
             5881802312257552497  # 64-bit
             1770036893           # 32-bit
         """
-
         return hash(self.coefficients())
 
     def coefficient(self, n):
@@ -167,7 +166,7 @@ class TernaryQF(SageObject):
         x, y, z = polygens(ZZ, names)
         return self._a * x**2 + self._b * y**2 + self._c * z**2 + self._t * x*y + self._s * x*z + self._r * y*z
 
-    def _repr_(self):
+    def _repr_(self) -> str:
         r"""
         Display the quadratic form.
 
@@ -231,19 +230,19 @@ class TernaryQF(SageObject):
             # Check if v has 3 cols
             if v.ncols() == 3:
                 M = v.transpose() * self.matrix() * v
-                return TernaryQF([M[0, 0]//2, M[1, 1]//2, M[2, 2]//2,
+                return TernaryQF([M[0, 0] // 2, M[1, 1] // 2, M[2, 2] // 2,
                                   M[1, 2], M[0, 2], M[0, 1]])
-            else:
-                return QuadraticForm(ZZ, v.transpose() * self.matrix() * v)
-        elif isinstance(v, (Vector, list, tuple)):
+
+            return QuadraticForm(ZZ, v.transpose() * self.matrix() * v)
+        if isinstance(v, (Vector, list, tuple)):
             # Check that v has length 3
             if len(v) != 3:
                 raise TypeError("your vector needs to have length 3")
             v0, v1, v2 = v
             a, b, c, r, s, t = self.coefficients()
             return a*v0**2 + b*v1**2 + c*v2**2 + r*v1*v2 + s*v0*v2 + t*v0*v1
-        else:
-            raise TypeError("presently we can only evaluate a quadratic form on a list, tuple, vector or matrix")
+
+        raise TypeError("presently we can only evaluate a quadratic form on a list, tuple, vector or matrix")
 
     def quadratic_form(self):
         r"""
@@ -261,11 +260,13 @@ class TernaryQF(SageObject):
             sage: bool(QF1 == QF2)
             True
         """
-        return QuadraticForm(ZZ, 3, [self._a, self._t, self._s, self._b, self._r, self._c])
+        return QuadraticForm(ZZ, 3, [self._a, self._t, self._s,
+                                     self._b, self._r, self._c])
 
     def matrix(self):
         r"""
         Return the Hessian matrix associated to the ternary quadratic form.
+
         That is, if `Q` is a ternary quadratic form, `Q(x,y,z) = a\cdot x^2 + b\cdot y^2 + c\cdot z^2 + r\cdot y\cdot z + s\cdot x\cdot z + t\cdot x\cdot y`,
         then the Hessian matrix associated to `Q` is
         ::
@@ -290,12 +291,15 @@ class TernaryQF(SageObject):
             sage: (v*M*v.column())[0]//2
             28
         """
-        M = matrix(ZZ, 3, [2*self._a, self._t, self._s, self._t, 2*self._b, self._r, self._s, self._r, 2*self._c])
-        return M
+        return matrix(ZZ, 3, 3, [2 * self._a, self._t, self._s,
+                                 self._t, 2 * self._b, self._r,
+                                 self._s, self._r, 2 * self._c])
 
     def disc(self):
         r"""
-        Return the discriminant of the ternary quadratic form, this is the determinant of the matrix divided by 2.
+        Return the discriminant of the ternary quadratic form.
+
+        This is the determinant of the matrix divided by 2.
 
         EXAMPLES::
 
@@ -305,7 +309,8 @@ class TernaryQF(SageObject):
             sage: Q.matrix().det()
             -50
         """
-        return 4*self._a*self._b*self._c + self._r*self._s*self._t - self._a*self._r**2 - self._b*self._s**2 - self._c*self._t**2
+        return (4*self._a*self._b*self._c + self._r*self._s*self._t
+                - self._a*self._r**2 - self._b*self._s**2 - self._c*self._t**2)
 
     def is_definite(self) -> bool:
         """
@@ -325,28 +330,13 @@ class TernaryQF(SageObject):
         d1 = self._a
         if d1 == 0:
             return False
-        d2 = 4*self._a*self._b-self._t**2
-        if d2 == 0:
+        d2 = 4 * self._a * self._b - self._t**2
+        if d2 <= 0:
             return False
         d3 = self.disc()
         if d3 == 0:
             return False
-        if d1 > 0:
-            if d2 > 0:
-                if d3 > 0:
-                    return True
-                else:
-                    return False
-            else:
-                return False
-        else:
-            if d2 > 0:
-                if d3 < 0:
-                    return True
-                else:
-                    return False
-            else:
-                return False
+        return (d1 > 0) == (d3 > 0)
 
     def is_positive_definite(self) -> bool:
         """
@@ -371,22 +361,13 @@ class TernaryQF(SageObject):
         d1 = self._a
         if d1 == 0:
             return False
-        d2 = 4*self._a*self._b-self._t**2
-        if d2 == 0:
+        d2 = 4 * self._a * self._b - self._t**2
+        if d2 <= 0:
             return False
         d3 = self.disc()
         if d3 == 0:
             return False
-        if d1 > 0:
-            if d2 > 0:
-                if d3 > 0:
-                    return True
-                else:
-                    return False
-            else:
-                return False
-        else:
-            return False
+        return d1 > 0 and d3 > 0
 
     def is_negative_definite(self) -> bool:
         """
@@ -406,22 +387,13 @@ class TernaryQF(SageObject):
         d1 = self._a
         if d1 == 0:
             return False
-        d2 = 4*self._a*self._b-self._t**2
-        if d2 == 0:
+        d2 = 4 * self._a * self._b - self._t**2
+        if d2 <= 0:
             return False
         d3 = self.disc()
         if d3 == 0:
             return False
-        if d1 < 0:
-            if d2 > 0:
-                if d3 < 0:
-                    return True
-                else:
-                    return False
-            else:
-                return False
-        else:
-            return False
+        return d1 < 0 and d3 < 0
 
     def __neg__(self):
         """
@@ -488,7 +460,7 @@ class TernaryQF(SageObject):
         """
         l = self.coefficients()
         g = gcd(l)
-        return TernaryQF([a//g for a in l])
+        return TernaryQF([a // g for a in l])
 
     def scale_by_factor(self, k):
         """
@@ -951,7 +923,6 @@ class TernaryQF(SageObject):
             sage: neig.count(Q2)
             3
         """
-
         z = self.find_zeros_mod_p(p)
         return [self.find_p_neighbor_from_vec(p, v, mat) for v in z]
 
@@ -965,7 +936,6 @@ class TernaryQF(SageObject):
             sage: Q.basic_lemma(3)
             4
         """
-
         return _basic_lemma(self._a, self._b, self._c, self._r, self._s, self._t, p)
 
     def xi(self, p):
@@ -1056,7 +1026,7 @@ class TernaryQF(SageObject):
 
         return identity_matrix(3) - v.column()*matrix(v)*self.matrix()/self(v)
 
-    def automorphism_symmetries(self, A):
+    def automorphism_symmetries(self, A) -> list:
         """
         Given the automorphism `A`, if `A` is the identity, return the empty list.
         Otherwise, return a list of two vectors `v_1`, `v_2` such that the product of
@@ -1086,20 +1056,15 @@ class TernaryQF(SageObject):
             sage: Q.automorphism_symmetries(identity_matrix(ZZ,3))
             []
         """
-
         if A == identity_matrix(3):
             return []
-        else:
-            bs = (A - 1).columns()
-            for b1 in bs:
-                if b1 != 0:
-                    break
-            A1 = self.symmetry(b1)*A
-            bs = (A1 - 1).columns()
-            for b2 in bs:
-                if b2 != 0:
-                    break
-            return [b1, b2]
+
+        bs = (A - 1).columns()
+        b1 = next(v for v in bs if v)
+        A1 = self.symmetry(b1) * A
+        bs = (A1 - 1).columns()
+        b2 = next(v for v in bs if v)
+        return [b1, b2]
 
     def automorphism_spin_norm(self, A):
         """
@@ -1118,14 +1083,17 @@ class TernaryQF(SageObject):
         """
         if A == identity_matrix(ZZ, 3):
             return 1
-        bs = self.automorphism_symmetries(A)
-        s = self(bs[0]) * self(bs[1])
+        b1, b2 = self.automorphism_symmetries(A)
+        s = self(b1) * self(b2)
         return s.squarefree_part()
 
-    def _border(self, n):
+    def _border(self, n) -> bool:
         """
         Auxiliary function to find the automorphisms of a positive definite ternary quadratic form.
-        It return a boolean whether the n-condition is true. If Q = TernaryQF([a,b,c,r,s,t]), the conditions are:
+
+        It returns a boolean whether the n-condition is true.
+
+        If ``Q = TernaryQF([a,b,c,r,s,t])``, the conditions are:
 
         1.  a = t, s = 2r.
         2.  a = s, t = 2r.
@@ -1195,7 +1163,6 @@ class TernaryQF(SageObject):
             sage: Q16._border(16)
             True
         """
-
         a, b, c, r, s, t = self.coefficients()
         if n == 1:
             return (a == t) and (s == 2*r)
@@ -1308,7 +1275,6 @@ class TernaryQF(SageObject):
             sage: Q._automorphisms_reduced_fast()
             [(1, 0, 0, 0, 1, 0, 0, 0, 1)]
         """
-
         if self._border(1):
             if self._border(2):
                 if self._border(14):
@@ -1673,6 +1639,7 @@ class TernaryQF(SageObject):
     def _automorphisms_reduced_slow(self):
         """
         Return the automorphisms of the reduced ternary quadratic form.
+
         It searches over all 3x3 matrices with coefficients -1, 0, 1,
         determinant 1 and finite order, because Eisenstein reduced forms
         are Minkowski reduced. See Cassels.
@@ -2024,7 +1991,7 @@ def find_all_ternary_qf_by_level_disc(N, d):
         ...
         ValueError: There are no ternary forms of this level and discriminant
     """
-    return [TernaryQF(_) for _ in _find_all_ternary_qf_by_level_disc(N, d)]
+    return [TernaryQF(qf) for qf in _find_all_ternary_qf_by_level_disc(N, d)]
 
 
 def find_a_ternary_qf_by_level_disc(N, d):

sage/rings/cfinite_sequence.py

@@ -1,6 +1,6 @@
 # sage_setup: distribution = sagemath-modules
 r"""
-C-Finite Sequences
+C-finite sequences
 
 C-finite infinite sequences satisfy homogeneous linear recurrences with constant coefficients:
 
@@ -8,7 +8,7 @@ C-finite infinite sequences satisfy homogeneous linear recurrences with constant
 
     a_{n+d} = c_0a_n + c_1a_{n+1} + \cdots + c_{d-1}a_{n+d-1}, \quad d>0.
 
-CFiniteSequences are completely defined by their ordinary generating function (o.g.f., which
+They are completely defined by their ordinary generating function (o.g.f., which
 is always a :mod:`fraction <sage.rings.fraction_field_element>` of
 :mod:`polynomials <sage.rings.polynomial.polynomial_element>` over `\ZZ` or `\QQ` ).
 
@@ -69,9 +69,17 @@ can be guessed::
 
     :func:`fibonacci`, :class:`BinaryRecurrenceSequence`
 
-AUTHORS:
+.. TODO::
 
-- Ralf Stephan (2014): initial version
+    Implement a feature enabling::
+
+        sage: # not implemented
+        sage: CFiniteSequence(x+x^2+x^3+x^4+x^5+O(x^6))
+        sage: latex(r)
+        \big\{a_{n\ge0}\big|a_{n+2}=\sum_{i=0}^{1}c_ia_{n+i}, c=\{1,1\}, a_{n<2}=\{0,0,0,1\}\big\}
+        sage: r.egf()
+        exp(2*x)
+        sage: r = CFiniteSequence(1/(1-y-x*y), x)
 
 REFERENCES:
 
@@ -79,6 +87,10 @@ REFERENCES:
 - [KP2011]_
 - [SZ1994]_
 - [Zei2011]_
+
+AUTHORS:
+
+- Ralf Stephan (2014): initial version
 """
 
 # ****************************************************************************
@@ -1292,16 +1304,3 @@ class CFiniteSequences_generic(Parent, UniqueRepresentation):
         if num == 0 or sequence != S(num / den).list():
             return 0
         return CFiniteSequence(num / den)
-
-
-r"""
-.. TODO::
-
-    sage: # not implemented
-    sage: CFiniteSequence(x+x^2+x^3+x^4+x^5+O(x^6))
-    sage: latex(r)
-    \big\{a_{n\ge0}\big|a_{n+2}=\sum_{i=0}^{1}c_ia_{n+i}, c=\{1,1\}, a_{n<2}=\{0,0,0,1\}\big\}
-    sage: r.egf()
-    exp(2*x)
-    sage: r = CFiniteSequence(1/(1-y-x*y), x)
-"""

sage/rings/complex_double.pxd

@@ -1,4 +1,5 @@
 # sage_setup: distribution = sagemath-modules
+
 from sage.libs.gsl.types cimport gsl_complex
 
 cimport sage.structure.element

sage/rings/complex_double.pyx

@@ -1,6 +1,8 @@
 # sage_setup: distribution = sagemath-modules
 # distutils: extra_compile_args = -D_XPG6
-# distutils: libraries = m
+# distutils: libraries = M_LIBRARIES
+# distutils: language = c++
+# distutils: extra_compile_args = -std=c++11
 r"""
 Double precision floating point complex numbers
 
@@ -75,9 +77,8 @@ from sage.misc.randstate cimport randstate, current_randstate
 
 from sage.libs.gsl.complex cimport *
 
-cdef extern from "<complex.h>":
-    double complex csqrt(double complex)
-    double cabs(double complex)
+cimport libcpp.complex
+from libcpp.complex cimport abs, sqrt
 
 import sage.rings.abc
 cimport sage.rings.integer
@@ -1077,7 +1078,7 @@ cdef class ComplexDoubleElement(FieldElement):
 
         INPUT:
 
-        - ``format_spec`` -- string; a floating point format specificier as
+        - ``format_spec`` -- string; a floating point format specifier as
           defined by :python:`the format specification mini-language
           <library/string.html#formatspec>` in Python
 
@@ -2289,10 +2290,10 @@ cdef class ComplexDoubleElement(FieldElement):
 
             sage: a = CDF(-0.95,-0.65)
             sage: b = CDF(0.683,0.747)
-            sage: a.agm(b, algorithm='optimal')
-            -0.3715916523517613 + 0.31989466020683*I
-            sage: a.agm(b, algorithm='principal')  # rel tol 1e-15
-            0.33817546298618006 - 0.013532696956540503*I
+            sage: a.agm(b, algorithm='optimal')  # rel tol 1e-15
+            -0.3715916523517613 + 0.31989466020683005*I
+            sage: a.agm(b, algorithm='principal')  # rel tol 2e-15
+            0.33817546298618006 - 0.013532696956540483*I
             sage: a.agm(b, algorithm='pari')                                            # needs sage.libs.pari
             -0.37159165235176134 + 0.31989466020683005*I
 
@@ -2305,7 +2306,7 @@ cdef class ComplexDoubleElement(FieldElement):
             sage: a.agm(-a)
             0.0
         """
-        cdef double complex a, b, a1, b1, r
+        cdef libcpp.complex.complex[double] a, b, a1, b1, r
         cdef double d, e, eps = 2.0**-51
 
         if algorithm == "pari":
@@ -2326,21 +2327,21 @@ cdef class ComplexDoubleElement(FieldElement):
         if algorithm=="optimal":
             while True:
                 a1 = (a+b)/2
-                b1 = csqrt(a*b)
+                b1 = sqrt(a*b)
                 r = b1/a1
-                d  = cabs(r-1)
-                e  = cabs(r+1)
+                d  = abs(r-1)
+                e  = abs(r+1)
                 if e < d:
                     b1=-b1
                     d = e
-                if d < eps: return ComplexDoubleElement_from_doubles(a1.real, a1.imag)
+                if d < eps: return ComplexDoubleElement_from_doubles(a1.real(), a1.imag())
                 a, b = a1, b1
 
         elif algorithm=="principal":
             while True:
                 a1 = (a+b)/2
-                b1 = csqrt(a*b)
-                if cabs((b1/a1)-1) < eps: return ComplexDoubleElement_from_doubles(a1.real, a1.imag)
+                b1 = sqrt(a*b)
+                if abs((b1/a1)-1) < eps: return ComplexDoubleElement_from_doubles(a1.real(), a1.imag())
                 a, b = a1, b1
 
         else:
@@ -2441,34 +2442,38 @@ cdef class ComplexDoubleElement(FieldElement):
             from sage.libs.pari.convert_sage_complex_double import complex_double_element_zeta
         return complex_double_element_zeta(self)
 
-    def algdep(self, long n):
+    def algebraic_dependency(self, long n):
         """
         Return a polynomial of degree at most `n` which is
-        approximately satisfied by this complex number. Note that the
-        returned polynomial need not be irreducible, and indeed usually
-        won't be if `z` is a good approximation to an algebraic
-        number of degree less than `n`.
+        approximately satisfied by this complex number.
 
-        ALGORITHM: Uses the PARI C-library algdep command.
+        Note that the returned polynomial need not be irreducible, and
+        indeed usually will not be if `z` is a good approximation to an
+        algebraic number of degree less than `n`.
+
+        ALGORITHM: Uses the PARI C-library :pari:`algdep` command.
 
         EXAMPLES::
 
             sage: z = (1/2)*(1 + RDF(sqrt(3)) * CDF.0); z   # abs tol 1e-16             # needs sage.symbolic
             0.5 + 0.8660254037844387*I
-            sage: p = z.algdep(5); p                                                    # needs sage.libs.pari sage.symbolic
+            sage: p = z.algebraic_dependency(5); p                                      # needs sage.libs.pari sage.symbolic
             x^2 - x + 1
             sage: abs(z^2 - z + 1) < 1e-14                                              # needs sage.symbolic
             True
 
         ::
 
-            sage: CDF(0,2).algdep(10)                                                   # needs sage.libs.pari
+            sage: CDF(0,2).algebraic_dependency(10)                                     # needs sage.libs.pari
             x^2 + 4
-            sage: CDF(1,5).algdep(2)                                                    # needs sage.libs.pari
+            sage: CDF(1,5).algebraic_dependency(2)                                      # needs sage.libs.pari
             x^2 - 2*x + 26
         """
-        from sage.arith.misc import algdep
-        return algdep(self, n)
+        from sage.arith.misc import algebraic_dependency
+        return algebraic_dependency(self, n)
+
+    algdep = algebraic_dependency
+
 
 cdef class FloatToCDF(Morphism):
     """
@@ -2624,13 +2629,13 @@ def ComplexDoubleField():
 from sage.misc.parser import Parser
 cdef cdf_parser = Parser(float, float,  {"I": _CDF.gen(), "i": _CDF.gen()})
 
-cdef inline double complex extract_double_complex(ComplexDoubleElement x) noexcept:
+cdef inline libcpp.complex.complex[double] extract_double_complex(ComplexDoubleElement x) noexcept:
     """
-    Return the value of ``x`` as a c99 complex double.
+    Return the value of ``x`` as a C++ complex<double>
     """
-    cdef double complex z
-    z.real = GSL_REAL(x._complex)
-    z.imag = GSL_IMAG(x._complex)
+    cdef libcpp.complex.complex[double] z
+    z.real(GSL_REAL(x._complex))
+    z.imag(GSL_IMAG(x._complex))
     return z