otrs-somconnexio 0.7.0__py2.py3-none-any.whl → 0.7.2__py2.py3-none-any.whl

otrs_somconnexio/client.py

@@ -125,7 +125,7 @@ class OTRSClient:
             SessionNotCreated,
             ArgumentMissingError,
         ) as error:
-            raise TicketNotCreated(error.message, dynamic_fields)
+            raise TicketNotCreated(error.message, ticket, dynamic_fields)
         return OTRSCreationTicketResponse(client_response)
 
     def get_otrs_process_ticket(self, ticket_id):

otrs_somconnexio/exceptions.py

@@ -21,12 +21,24 @@ class TicketNotCreated(OTRSClientException):
             df_msg = df_msg + "{}: {}\n".format(df.name, df.value)
         return df_msg
 
-    def __init__(self, error_msg, dynamic_fields=None):
-
+    def _ticket_to_string(self, ticket):
+        if not ticket:
+            return ""
+        ticket_msg = ""
+        for field_key in ticket.fields.keys():
+            ticket_msg = ticket_msg + "{}: {}\n".format(
+                field_key, ticket.fields[field_key]
+            )
+        return ticket_msg
+
+    def __init__(self, error_msg, ticket=None, dynamic_fields=None):
         title_message = "Error creating the ticket with the next error message:"
         df_message = self._DF_to_string(dynamic_fields)
+        ticket_message = self._ticket_to_string(ticket)
 
-        message = "{}\n\t{}\n{}".format(title_message, error_msg, df_message)
+        message = "{}\n\t{}\n{}{}".format(
+            title_message, error_msg, ticket_message, df_message
+        )
 
         super(OTRSClientException, self).__init__(message)
 

otrs_somconnexio/otrs_models/internet_data.py

@@ -21,8 +21,6 @@ class InternetData(object):
         previous_owner_vat,
         previous_owner_name,
         previous_owner_surname,
-        notes,
-        activation_notes,
         product,
         adsl_coverage,
         mm_fiber_coverage,
@@ -35,6 +33,8 @@ class InternetData(object):
         previous_contract_address="",
         previous_contract_phone="",
         mobile_pack_contracts="",
+        notes="",
+        activation_notes="",
         confirmed_documentation=False,
     ):
         # Common all the Tickets

otrs_somconnexio/otrs_models/mobile_dynamic_fields.py

@@ -6,7 +6,6 @@ from otrs_somconnexio.otrs_models.provision_dynamic_fields import ProvisionDynam
 class MobileDynamicFields(ProvisionDynamicFields):
     def _build_specific_dynamic_fields(self):
         return [
-            self._order_id(),
             self._line(),
             self._icc_sc(),
             self._icc_donor(),
@@ -30,9 +29,6 @@ class MobileDynamicFields(ProvisionDynamicFields):
             self._confirm_doc(),
         ]
 
-    def _order_id(self):
-        return DynamicField("IDpeticio", self.service_data.order_id)
-
     def _line(self):
         return DynamicField("liniaMobil", self.service_data.phone_number)
 

otrs_somconnexio/otrs_models/provision_dynamic_fields.py

@@ -31,6 +31,7 @@ class ProvisionDynamicFields:
             self._lang(),
             self._order_id(),
             self._confirmed_documentation(),
+            self._notes(),
         ]
         dynamic_fields += self._build_specific_dynamic_fields()
 
@@ -116,3 +117,8 @@ class ProvisionDynamicFields:
             "1" if self.service_data.confirmed_documentation else "0"
         )
         return DynamicField(name="confirmarDocumentacio", value=confirmed_documentation)
+
+    def _notes(self):
+        return DynamicField(
+            name="consideracionsGenerals", value=self.service_data.notes
+        )

otrs_somconnexio/otrs_models/provision_ticket.py

@@ -49,7 +49,6 @@ class ProvisionTicket:
             self.service_data.technology,
             self.service_data.order_id,
             self.service_type(),
-            self.service_data.notes,
         )
         return provision_article.call()
 
@@ -87,4 +86,7 @@ class ProvisionTicket:
         return self.customer_data.id
 
     def _responsible_email(self):
-        return self.responsible_data.email
+        if hasattr(self.responsible_data, "email"):
+            return self.responsible_data.email
+        else:
+            return False

otrs_somconnexio/otrs_models/ticket_factory.py

@@ -14,7 +14,7 @@ class TicketFactory(object):
     the service of the EticomContract.
     """
 
-    def __init__(self, service_data, customer_data, responsible_data):
+    def __init__(self, service_data, customer_data, responsible_data=None):
         self.service_data = service_data
         self.customer_data = customer_data
         self.responsible_data = responsible_data

{otrs_somconnexio-0.7.0.dist-info → otrs_somconnexio-0.7.2.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: otrs-somconnexio
-Version: 0.7.0
+Version: 0.7.2
 Summary: Python package for Somconnexio data syncing in OTRS
 Home-page: https://gitlab.com/coopdevs/otrs_somconnexio
 Author: Coopdevs

{otrs_somconnexio-0.7.0.dist-info → otrs_somconnexio-0.7.2.dist-info}/RECORD

@@ -1,6 +1,6 @@
 otrs_somconnexio/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-otrs_somconnexio/client.py,sha256=WOkx3VvXpDuz2KEFJBZx9MwRrmCeyrlM1iXvNTXlo2A,7417
-otrs_somconnexio/exceptions.py,sha256=OyIcR17mynIYB6AfugViTJ1NrNPs_bBiHCMI1Kxqz4U,2131
+otrs_somconnexio/client.py,sha256=1pemhw9MZvNnpDrXmp9nLT-oUCdyo6388JH9hlPymxA,7425
+otrs_somconnexio/exceptions.py,sha256=3qha7dtTvXUDtEmnYC-C0vjZqNR41ybbdjatYJC_nEw,2546
 otrs_somconnexio/otrs_models/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 otrs_somconnexio/otrs_models/abstract_article.py,sha256=6eyMvOOyqs8vVAEbQINvl5K0gMaOyshKVwS-QM0Bb0Q,492
 otrs_somconnexio/otrs_models/adsl_data.py,sha256=mwi5UvGOoSbVSO37PlYeSKpDI9E4DUbXnGy4yRKb2Kg,315
@@ -13,15 +13,15 @@ otrs_somconnexio/otrs_models/customer_user.py,sha256=9LRUxWQS4gxoBoyFwU_wLb9zXiT
 otrs_somconnexio/otrs_models/fiber_data.py,sha256=b8OVbAPBBUUzcQQP5HXRjzm7fvdqlM8keNlGsAF6t9c,576
 otrs_somconnexio/otrs_models/fiber_dynamic_fields.py,sha256=nJzi-vjWhRyWsvH85KxzQ8FjOHkRJFsikkpDLLXZHjA,2559
 otrs_somconnexio/otrs_models/fiber_ticket.py,sha256=dCJBaJqDQWQk3XBvqGSWnpMdgOiyu64dh3xFCOOh7C0,938
-otrs_somconnexio/otrs_models/internet_data.py,sha256=6whT2bPLgMoOV0ylkvFwnLz65divdUSP8UDdsA60P6c,2740
+otrs_somconnexio/otrs_models/internet_data.py,sha256=BUBZIxSMnccO6RE7Tvf6DtMEMQ1RVX2cYqC_K2BJYtQ,2746
 otrs_somconnexio/otrs_models/internet_dynamic_fields.py,sha256=rsYuGQ8dEyBAqIgyqNVA-76WgCb0y67c3e-Kx9F6MsQ,5018
 otrs_somconnexio/otrs_models/mobile_data.py,sha256=Zl5AlbrtfxT4i6z83sAth_dZcOn0yXFm1AeBMFkG48o,1931
-otrs_somconnexio/otrs_models/mobile_dynamic_fields.py,sha256=tPRieBkGskBVySuSJ6Zob_ublrAB3h-eofqcfRz-rxY,3884
+otrs_somconnexio/otrs_models/mobile_dynamic_fields.py,sha256=qvwWgHRwaktoVF0KP_dfBgRG2n2TKWORIlrW-MWEc-o,3759
 otrs_somconnexio/otrs_models/mobile_ticket.py,sha256=aNtGteRzD-dOtPqqs3KoqggZaeLy_Za1KEBM5aHGCYI,1336
 otrs_somconnexio/otrs_models/providers.py,sha256=Jy5lm_gCuwy_BhpNE5JJ5-TrE8aFQpZvMiYZ-PTlgqs,181
 otrs_somconnexio/otrs_models/provision_article.py,sha256=jONH4lHzjg2jyx_mxjghw503oUT9VI9QwZrJ25HdOS0,469
-otrs_somconnexio/otrs_models/provision_dynamic_fields.py,sha256=UcMAj1UKSr71ENoBO7UGLdU7Q_6o7hbT6PeNiP7vvis,3989
-otrs_somconnexio/otrs_models/provision_ticket.py,sha256=FDGtyK-IH4RmVsciGjzz9TINWtj93fZL5CHbk61z2iw,2677
+otrs_somconnexio/otrs_models/provision_dynamic_fields.py,sha256=gXlshwEl-bXzXGQFlJFZB9BIRKDxP8n479hi9ISusec,4151
+otrs_somconnexio/otrs_models/provision_ticket.py,sha256=hruT5PCiNZUM1SyxlTRTWzc6b2DpXkHJfws61R_CyFw,2735
 otrs_somconnexio/otrs_models/responsible_data.py,sha256=KCXkCNe_NLRpVLzeK8iNlbuH-tYag4YOL-MqnCFXn0g,104
 otrs_somconnexio/otrs_models/router_4G_data.py,sha256=EQIVxVstFswmEcOHzzV1ZyDYaadiU7lbunb5CJg6xAM,194
 otrs_somconnexio/otrs_models/router_4G_dynamic_fields.py,sha256=NVrfwD2Mj1TTzOC8NYna1XQYXEN6ffAfovlP9VAIHh4,403
@@ -34,7 +34,7 @@ otrs_somconnexio/otrs_models/switchboard_header_dynamic_fields.py,sha256=WsVBchl
 otrs_somconnexio/otrs_models/switchboard_header_ticket.py,sha256=nI0icSuhOPYEEI7gn0YEYJJT6H1TfCnl1W3gm3MCDww,982
 otrs_somconnexio/otrs_models/switchboard_ticket.py,sha256=O5xONkHBiRHIi6OYNHCl00-AXxRNl3hT1pmDqGoJsgg,944
 otrs_somconnexio/otrs_models/telecom_company.py,sha256=yh8wIE7-AjWESdFsE479WWZ-3uFz_ljUBKF8GK44oow,3077
-otrs_somconnexio/otrs_models/ticket_factory.py,sha256=oZUJ3LfoQfNVM0eRueSV5baVV2DvUxF2vQ5hrFmtUhc,2210
+otrs_somconnexio/otrs_models/ticket_factory.py,sha256=QL2u-51EuXy1aJWZxUZMo4JisDoKBAQM83GViXJAPx8,2215
 otrs_somconnexio/otrs_models/vf_provisioning_article.py,sha256=AZbtXePA-FA3ufHJsngaXzUL4npJgUqMqvrMSUmCd9o,599
 otrs_somconnexio/otrs_models/configurations/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 otrs_somconnexio/otrs_models/configurations/changes/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -123,30 +123,30 @@ tests/otrs_models/common_helper.py,sha256=WAd7aenHTfHvxjZMlwFfr32ajaF285Y75eifMj
 tests/otrs_models/test_abstract_article.py,sha256=udzIihoP0h8Ien20JFz1jLm5Sv2b3wO6f2JZK6zRTKQ,861
 tests/otrs_models/test_adsl_data.py,sha256=_NGpe5mStNyKPhZ5xFVS62jMdMr5vkzp9SusHmFh4r4,1484
 tests/otrs_models/test_adsl_dynamic_fields.py,sha256=MI6ggXsm4nWQnCVfiIoAVdPJu0HjTbexg4sVA5gMJLo,19910
-tests/otrs_models/test_adsl_ticket.py,sha256=w3KScI7m9S4ej9XBZIUh6KJB-g7m9xE4z-F1iYeT7M0,4786
+tests/otrs_models/test_adsl_ticket.py,sha256=lw1BvezIPMJ0oMFgtqljdhdZlGTOkUIYS4Q740vJirM,4518
 tests/otrs_models/test_coverage_article.py,sha256=O_wm0l75m6sBWEcMdLOvBWDNSVXJ89IkL4IijIgiuPk,1519
 tests/otrs_models/test_coverage_ticket.py,sha256=0W4f28BMhtZDvPm71d7YPJuiVi9jUI6WJBbjh3xs0mg,1019
 tests/otrs_models/test_customer_user.py,sha256=9TDojrOsQBqd4kdC8SxvG5Ub18AXkJ_tsYuUeHALZnc,2227
 tests/otrs_models/test_fiber_data.py,sha256=rdFbcqzI49PV2m30vqnBOmZr2rn_MBqC0bJd0K0dcbI,1833
-tests/otrs_models/test_fiber_dynamic_fields.py,sha256=cK_x0Gi6ECDHACh31EHZfwBtW9CQuOOCLV7bVwdVo6c,26592
-tests/otrs_models/test_fiber_ticket.py,sha256=nScKLZ67HG_a6830AlfLhcpiQMhmsJTrTK9m1X4yHcQ,6390
+tests/otrs_models/test_fiber_dynamic_fields.py,sha256=Rc8qUu_nTiV5Cfm7DxYn4ezO_2SRqQkGT7t6qRXARv4,27097
+tests/otrs_models/test_fiber_ticket.py,sha256=9CeW1x2lZRIF40sD6iPqTGtMlvnKMRvD_uPJx9c5KgU,6361
 tests/otrs_models/test_mobile_data.py,sha256=EBtwJL9kUaThhnKuqpUk6GFv0KS7RhyCF6dJNgr1-m8,1110
-tests/otrs_models/test_mobile_dynamic_fields.py,sha256=8dV54xM9zq-rF2t8lLqe0aMnMeJdOSjMrE5Sdnu9ufM,19331
+tests/otrs_models/test_mobile_dynamic_fields.py,sha256=Xi8lj7PCJunwij-VQxqPYnafY2inEqeqQmQfSRFAmOM,19861
 tests/otrs_models/test_mobile_paused_ticket.py,sha256=T7Gyy7hoG994KHXkTWbJVQC_sC1sgZl4C1_sgpx3hwk,1418
-tests/otrs_models/test_mobile_ticket.py,sha256=3sZcfbsxNHCsyvUWNGO5RDSQTKIhi6KucAjztUlWzhc,4928
+tests/otrs_models/test_mobile_ticket.py,sha256=hFWKdqUpfFOTKAitx9cUPdoIEQu_Hy_tAVOGMuQkgCc,4859
 tests/otrs_models/test_provision_article.py,sha256=SwTA96si0tundnu6lGCJGQcaOpnkRnKUYRKO9NcsflI,1773
 tests/otrs_models/test_router_4G_data.py,sha256=3zKZzWd21j8q4oXFG-Pl1Ugtkp4J0_RZx8HtHRzpfKM,1443
 tests/otrs_models/test_router_4G_dynamic_fields.py,sha256=hwQS4SxPX4OQfIxPMNEvWxJrUirxj3cIaxBsOxLjvqw,21007
-tests/otrs_models/test_router_4G_ticket.py,sha256=0x5n-vCSsvu8C0ejIyu8lYNYgZvcPb7axpG-YbKbCiQ,4828
+tests/otrs_models/test_router_4G_ticket.py,sha256=QdMHFOhjxsCa-cxwRIIZMOzPABa6dFTrp4nLdpQXfSk,4799
 tests/otrs_models/test_service.py,sha256=fLFyJ5wE8jszrD9sZlSOebjioR8dv8z2SeGZVcA3r5U,6833
 tests/otrs_models/test_switchboard_data.py,sha256=QlO_vupDFeavLFH1EIXVzRf4qIJ5AtuyvgCg_v4sXTE,1233
-tests/otrs_models/test_switchboard_dynamic_fields.py,sha256=2HpLewDLiGJrFhB7FcisJnfa_cZFpRZDfVWVTISA68I,5684
+tests/otrs_models/test_switchboard_dynamic_fields.py,sha256=E8vysY5tnHAwZRHjzdi_oz7p495pFDFnmJXizVKTXlc,5903
 tests/otrs_models/test_switchboard_header_data.py,sha256=kXkicBHpIaBgVSDDhEIqVgDEu1rpQG0TQLUGL0Jr_3s,534
 tests/otrs_models/test_switchboard_header_dynamic_fields.py,sha256=2xaVzEC9-6NZ9ZMIAOf1GPpfWRw8BG1sn7ZEo86NxuM,3558
-tests/otrs_models/test_switchboard_header_ticket.py,sha256=J5GFBgNVG8k0MU8AxvQNj-J3QNAe8CS6B8rsC0uepGk,4651
-tests/otrs_models/test_switchboard_ticket.py,sha256=SJNYlVqr9oIywNiMH-TwtK9BRB1iuM4VpfmqvvmqZsw,4973
+tests/otrs_models/test_switchboard_header_ticket.py,sha256=j2Wu-02LNgkEBpGoq1IP9sRtGlNkTlIsujZL5h1X7wU,4568
+tests/otrs_models/test_switchboard_ticket.py,sha256=Fwk78xENfMXmkK5x_L8JWLGxh5I64q8BWjX2iT45sTI,4890
 tests/otrs_models/test_telecom_company.py,sha256=nC4uBleU2Lr3qHr5VDo-6kbcTVwKgguC85TcbhTOn1c,1450
-tests/otrs_models/test_ticket_factory.py,sha256=sDB6FwI5hr0DaCUwfMWWQPXtsG-o9W4kTn7bkGpDHFQ,3597
+tests/otrs_models/test_ticket_factory.py,sha256=nvye2LK3vfYv3xRNqsBO9M0zYWRWAPWjEFgdDpY1whQ,4048
 tests/otrs_models/test_vf_provisioning_article.py,sha256=Yj8vtaowhxP12K_-FMcJNW-5re3yyCCfGLRHCPYgrVA,897
 tests/otrs_models/configuration/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tests/otrs_models/configuration/changes/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -196,7 +196,7 @@ tests/services/test_update_ticket_with_provider_info.py,sha256=cZUg-hNV4BoMwafbp
 tests/user_management_client/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tests/user_management_client/test_client.py,sha256=088q9H1yf8Hii7zUF17KULqOO-JCxJLsR7vQ8lGHiqg,4410
 tests/user_management_client/test_user_management_response.py,sha256=HCCG7i2f6-ytrRpTzYZHODKCdW-X5GJn-BMVegd5FXg,1539
-otrs_somconnexio-0.7.0.dist-info/METADATA,sha256=Ld6dEmQZ66u5Ozmdd-xG3ZzjP-HXZB6wPD0Z6ZHVtVw,3458
-otrs_somconnexio-0.7.0.dist-info/WHEEL,sha256=fS9sRbCBHs7VFcwJLnLXN1MZRR0_TVTxvXKzOnaSFs8,110
-otrs_somconnexio-0.7.0.dist-info/top_level.txt,sha256=gvMaHGNwusWpSIy-PVyb0CKDIA4-4fXmEVER_2a-OnE,23
-otrs_somconnexio-0.7.0.dist-info/RECORD,,
+otrs_somconnexio-0.7.2.dist-info/METADATA,sha256=oaqa6am51HTsAPuTTMc1-SxxRH_dVyDOUKhpi7ZJmpw,3458
+otrs_somconnexio-0.7.2.dist-info/WHEEL,sha256=fS9sRbCBHs7VFcwJLnLXN1MZRR0_TVTxvXKzOnaSFs8,110
+otrs_somconnexio-0.7.2.dist-info/top_level.txt,sha256=gvMaHGNwusWpSIy-PVyb0CKDIA4-4fXmEVER_2a-OnE,23
+otrs_somconnexio-0.7.2.dist-info/RECORD,,

tests/otrs_models/test_adsl_ticket.py

@@ -9,8 +9,6 @@ from otrs_somconnexio.otrs_models.configurations.provision.adsl_ticket import (
 
 
 class ADSLTicketTestCase(unittest.TestCase):
-    def setUp(self):
-        self.responsible_data = Mock(spec=["email"])
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.Ticket")
     def test_build_ticket(self, MockTicket):
@@ -26,23 +24,23 @@ class ADSLTicketTestCase(unittest.TestCase):
             "Priority": ADSLTicketConfiguration.priority,
             "CustomerUser": customer_data.id,
             "CustomerID": customer_data.id,
-            "Responsible": self.responsible_data.email,
+            "Responsible": False,
         }
 
-        ADSLTicket(service_data, customer_data, self.responsible_data)._build_ticket()
+        ADSLTicket(service_data, customer_data, None)._build_ticket()
         MockTicket.assert_called_with(expected_ticket_arguments)
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
     def test_build_article(self, MockInternetArticle):
         customer_data = Mock(spec=[])
-        service_data = Mock(spec=["order_id", "notes", "technology"])
+        service_data = Mock(spec=["order_id", "technology"])
 
         mock_mobile_article = MockInternetArticle.return_value
 
-        ADSLTicket(service_data, customer_data, self.responsible_data)._build_article()
+        ADSLTicket(service_data, customer_data, None)._build_article()
 
         MockInternetArticle.assert_called_with(
-            service_data.technology, service_data.order_id, "adsl", service_data.notes
+            service_data.technology, service_data.order_id, "adsl"
         )
         mock_mobile_article.call.assert_called_once()
 
@@ -53,9 +51,7 @@ class ADSLTicketTestCase(unittest.TestCase):
 
         mock_adsl_dynamic_fields = MockADSLDynamicFields.return_value
 
-        ADSLTicket(
-            service_data, customer_data, self.responsible_data
-        )._build_dynamic_fields()
+        ADSLTicket(service_data, customer_data, None)._build_dynamic_fields()
 
         MockADSLDynamicFields.assert_called_with(
             service_data,
@@ -115,14 +111,13 @@ class ADSLTicketTestCase(unittest.TestCase):
                 "confirmed_documentation",
             ]
         )
-        self.responsible_data = Mock(spec=["email"])
 
         mock_otrs_client = Mock(spec=["create_otrs_process_ticket"])
         mock_otrs_client.create_otrs_process_ticket.return_value.id = 123
         mock_otrs_client.create_otrs_process_ticket.return_value.number = "#123"
         MockOTRSClient.return_value = mock_otrs_client
 
-        ticket = ADSLTicket(service_data, customer_data, self.responsible_data)
+        ticket = ADSLTicket(service_data, customer_data, None)
         ticket.create()
 
         mock_otrs_client.create_otrs_process_ticket.assert_called_once()

tests/otrs_models/test_fiber_dynamic_fields.py

@@ -773,3 +773,18 @@ class FiberDynamicFieldsTestCase(unittest.TestCase):
         self.assertEqual(
             dynamic_fields_dct["productBAMM"], self.service_data.product_ba_mm
         )
+
+    def test_consideracions_generals_field(self):
+        self.service_data.notes = "General notes"
+        dynamic_fields = FiberDynamicFields(
+            self.service_data,
+            self.customer_data,
+            self.fiber_otrs_process_id,
+            self.fiber_otrs_activity_id,
+        ).all()
+
+        dynamic_fields_dct = dynamic_fields_to_dct(dynamic_fields)
+        self.assertEqual(
+            dynamic_fields_dct["consideracionsGenerals"],
+            self.service_data.notes,
+        )

tests/otrs_models/test_fiber_ticket.py

@@ -57,14 +57,14 @@ class FiberTicketTestCase(unittest.TestCase):
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
     def test_build_article(self, MockInternetArticle):
         customer_data = Mock(spec=[])
-        service_data = Mock(spec=["order_id", "notes", "technology"])
+        service_data = Mock(spec=["order_id", "technology"])
 
         mock_mobile_article = MockInternetArticle.return_value
 
         FiberTicket(service_data, customer_data, self.responsible_data)._build_article()
 
         MockInternetArticle.assert_called_with(
-            service_data.technology, service_data.order_id, "fiber", service_data.notes
+            service_data.technology, service_data.order_id, "fiber"
         )
         mock_mobile_article.call.assert_called_once()
 

tests/otrs_models/test_mobile_dynamic_fields.py

@@ -44,6 +44,7 @@ class MobileDynamicFieldsTestCase(unittest.TestCase):
                 "delivery_city",
                 "delivery_zip_code",
                 "delivery_state",
+                "notes",
                 "activation_notes",
                 "technology",
                 "sales_team",
@@ -576,3 +577,18 @@ class MobileDynamicFieldsTestCase(unittest.TestCase):
 
         dynamic_fields_dct = dynamic_fields_to_dct(dynamic_fields)
         self.assertEqual(dynamic_fields_dct["confirmDoc"], "no")
+
+    def test_consideracions_generals_field(self):
+        self.mobile_data.notes = "General notes"
+        dynamic_fields = MobileDynamicFields(
+            self.mobile_data,
+            self.customer_data,
+            self.mobile_otrs_process_id,
+            self.mobile_otrs_activity_id,
+        ).all()
+
+        dynamic_fields_dct = dynamic_fields_to_dct(dynamic_fields)
+        self.assertEqual(
+            dynamic_fields_dct["consideracionsGenerals"],
+            self.mobile_data.notes,
+        )

tests/otrs_models/test_mobile_ticket.py

@@ -38,9 +38,8 @@ class MobileTicketTestCase(unittest.TestCase):
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
     def test_build_article(self, MockProvisionArticle):
-        mobile_data = Mock(spec=["order_id", "notes", "technology"])
+        mobile_data = Mock(spec=["order_id", "technology"])
         mobile_data.order_id = 123
-        mobile_data.notes = "Hola mundo"
 
         customer_data = Mock(spec=["order_id"])
 
@@ -49,7 +48,7 @@ class MobileTicketTestCase(unittest.TestCase):
         MobileTicket(mobile_data, customer_data, self.responsible_data)._build_article()
 
         MockProvisionArticle.assert_called_with(
-            mobile_data.technology, mobile_data.order_id, "mobile", mobile_data.notes
+            mobile_data.technology, mobile_data.order_id, "mobile"
         )
         mock_mobile_article.call.assert_called_once()
 

tests/otrs_models/test_router_4G_ticket.py

@@ -38,7 +38,7 @@ class Router4GTicketTestCase(unittest.TestCase):
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
     def test_build_article(self, MockInternetArticle):
         customer_data = Mock(spec=[])
-        service_data = Mock(spec=["order_id", "notes", "technology"])
+        service_data = Mock(spec=["order_id", "technology"])
 
         mock_internet_article = MockInternetArticle.return_value
 
@@ -47,7 +47,7 @@ class Router4GTicketTestCase(unittest.TestCase):
         )._build_article()
 
         MockInternetArticle.assert_called_with(
-            service_data.technology, service_data.order_id, "4G", service_data.notes
+            service_data.technology, service_data.order_id, "4G"
         )
         mock_internet_article.call.assert_called_once()
 

tests/otrs_models/test_switchboard_dynamic_fields.py

@@ -45,6 +45,7 @@ class SwitchboardDynamicFieldsTestCase(unittest.TestCase):
             shipment_subdivision=faker.state(),
             additional_products="A,B,C",
             confirmed_documentation=faker.boolean(),
+            notes=faker.word(),
         )
 
         self.switchboard_otrs_process_id = faker.uuid4()
@@ -181,3 +182,9 @@ class SwitchboardDynamicFieldsTestCase(unittest.TestCase):
             self.dynamic_fields_dct["confirmarDocumentacio"],
             "1" if self.service_data.confirmed_documentation else "0",
         )
+
+    def test_consideracions_generals_field(self):
+        self.assertEqual(
+            self.dynamic_fields_dct["consideracionsGenerals"],
+            self.service_data.notes,
+        )

tests/otrs_models/test_switchboard_header_ticket.py

@@ -42,9 +42,8 @@ class SwitchboardHeaderTicketTestCase(unittest.TestCase):
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
     def test_build_article(self, MockProvisionArticle):
-        service_data = Mock(spec=["order_id", "notes", "technology"])
+        service_data = Mock(spec=["order_id", "technology"])
         service_data.order_id = 123
-        service_data.notes = "Notes test"
         customer_data = Mock(spec=["order_id"])
 
         mock_article = MockProvisionArticle.return_value
@@ -57,7 +56,6 @@ class SwitchboardHeaderTicketTestCase(unittest.TestCase):
             service_data.technology,
             service_data.order_id,
             "switchboard_header",
-            service_data.notes,
         )
         mock_article.call.assert_called_once()
 

tests/otrs_models/test_switchboard_ticket.py

@@ -40,9 +40,8 @@ class SwitchboardTicketTestCase(unittest.TestCase):
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
     def test_build_article(self, MockProvisionArticle):
-        service_data = Mock(spec=["order_id", "notes", "technology"])
+        service_data = Mock(spec=["order_id", "technology"])
         service_data.order_id = 123
-        service_data.notes = "Notes test"
         customer_data = Mock(spec=["order_id"])
 
         mock_article = MockProvisionArticle.return_value
@@ -54,7 +53,6 @@ class SwitchboardTicketTestCase(unittest.TestCase):
             service_data.technology,
             service_data.order_id,
             "switchboard",
-            service_data.notes,
         )
         mock_article.call.assert_called_once()
 

tests/otrs_models/test_ticket_factory.py

@@ -88,6 +88,18 @@ class TicketFactoryTestCase(unittest.TestCase):
             responsible_data=self.responsible_data,
         )
 
+    @patch("otrs_somconnexio.otrs_models.ticket_factory.FiberTicket")
+    def test_build_fibre_ticket_without_responsible(self, MockFiberTicket):
+        self.service_data.service_type = "fiber"
+
+        TicketFactory(self.service_data, self.customer_data).build()
+
+        MockFiberTicket.assert_called_once_with(
+            service_data=self.service_data,
+            customer_data=self.customer_data,
+            responsible_data=None,
+        )
+
     def test_build_service_not_allowed_error(self):
         self.service_data.service_type = ""