otrs-somconnexio 0.7.0__py2.py3-none-any.whl → 0.7.1__py2.py3-none-any.whl

otrs_somconnexio/otrs_models/provision_ticket.py

@@ -87,4 +87,7 @@ class ProvisionTicket:
         return self.customer_data.id
 
     def _responsible_email(self):
-        return self.responsible_data.email
+        if hasattr(self.responsible_data, "email"):
+            return self.responsible_data.email
+        else:
+            return False

otrs_somconnexio/otrs_models/ticket_factory.py

@@ -14,7 +14,7 @@ class TicketFactory(object):
     the service of the EticomContract.
     """
 
-    def __init__(self, service_data, customer_data, responsible_data):
+    def __init__(self, service_data, customer_data, responsible_data=None):
         self.service_data = service_data
         self.customer_data = customer_data
         self.responsible_data = responsible_data

{otrs_somconnexio-0.7.0.dist-info → otrs_somconnexio-0.7.1.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: otrs-somconnexio
-Version: 0.7.0
+Version: 0.7.1
 Summary: Python package for Somconnexio data syncing in OTRS
 Home-page: https://gitlab.com/coopdevs/otrs_somconnexio
 Author: Coopdevs

{otrs_somconnexio-0.7.0.dist-info → otrs_somconnexio-0.7.1.dist-info}/RECORD

@@ -21,7 +21,7 @@ otrs_somconnexio/otrs_models/mobile_ticket.py,sha256=aNtGteRzD-dOtPqqs3KoqggZaeL
 otrs_somconnexio/otrs_models/providers.py,sha256=Jy5lm_gCuwy_BhpNE5JJ5-TrE8aFQpZvMiYZ-PTlgqs,181
 otrs_somconnexio/otrs_models/provision_article.py,sha256=jONH4lHzjg2jyx_mxjghw503oUT9VI9QwZrJ25HdOS0,469
 otrs_somconnexio/otrs_models/provision_dynamic_fields.py,sha256=UcMAj1UKSr71ENoBO7UGLdU7Q_6o7hbT6PeNiP7vvis,3989
-otrs_somconnexio/otrs_models/provision_ticket.py,sha256=FDGtyK-IH4RmVsciGjzz9TINWtj93fZL5CHbk61z2iw,2677
+otrs_somconnexio/otrs_models/provision_ticket.py,sha256=ANlfVsJyvR4iPDM1B8g7J6AOlwOTJ58BG2-18-63sIw,2772
 otrs_somconnexio/otrs_models/responsible_data.py,sha256=KCXkCNe_NLRpVLzeK8iNlbuH-tYag4YOL-MqnCFXn0g,104
 otrs_somconnexio/otrs_models/router_4G_data.py,sha256=EQIVxVstFswmEcOHzzV1ZyDYaadiU7lbunb5CJg6xAM,194
 otrs_somconnexio/otrs_models/router_4G_dynamic_fields.py,sha256=NVrfwD2Mj1TTzOC8NYna1XQYXEN6ffAfovlP9VAIHh4,403
@@ -34,7 +34,7 @@ otrs_somconnexio/otrs_models/switchboard_header_dynamic_fields.py,sha256=WsVBchl
 otrs_somconnexio/otrs_models/switchboard_header_ticket.py,sha256=nI0icSuhOPYEEI7gn0YEYJJT6H1TfCnl1W3gm3MCDww,982
 otrs_somconnexio/otrs_models/switchboard_ticket.py,sha256=O5xONkHBiRHIi6OYNHCl00-AXxRNl3hT1pmDqGoJsgg,944
 otrs_somconnexio/otrs_models/telecom_company.py,sha256=yh8wIE7-AjWESdFsE479WWZ-3uFz_ljUBKF8GK44oow,3077
-otrs_somconnexio/otrs_models/ticket_factory.py,sha256=oZUJ3LfoQfNVM0eRueSV5baVV2DvUxF2vQ5hrFmtUhc,2210
+otrs_somconnexio/otrs_models/ticket_factory.py,sha256=QL2u-51EuXy1aJWZxUZMo4JisDoKBAQM83GViXJAPx8,2215
 otrs_somconnexio/otrs_models/vf_provisioning_article.py,sha256=AZbtXePA-FA3ufHJsngaXzUL4npJgUqMqvrMSUmCd9o,599
 otrs_somconnexio/otrs_models/configurations/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 otrs_somconnexio/otrs_models/configurations/changes/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -123,7 +123,7 @@ tests/otrs_models/common_helper.py,sha256=WAd7aenHTfHvxjZMlwFfr32ajaF285Y75eifMj
 tests/otrs_models/test_abstract_article.py,sha256=udzIihoP0h8Ien20JFz1jLm5Sv2b3wO6f2JZK6zRTKQ,861
 tests/otrs_models/test_adsl_data.py,sha256=_NGpe5mStNyKPhZ5xFVS62jMdMr5vkzp9SusHmFh4r4,1484
 tests/otrs_models/test_adsl_dynamic_fields.py,sha256=MI6ggXsm4nWQnCVfiIoAVdPJu0HjTbexg4sVA5gMJLo,19910
-tests/otrs_models/test_adsl_ticket.py,sha256=w3KScI7m9S4ej9XBZIUh6KJB-g7m9xE4z-F1iYeT7M0,4786
+tests/otrs_models/test_adsl_ticket.py,sha256=j1uvZ3rJscf4qfO2vm1Vk4IFIuHvXzMQOJhMM020oV4,4547
 tests/otrs_models/test_coverage_article.py,sha256=O_wm0l75m6sBWEcMdLOvBWDNSVXJ89IkL4IijIgiuPk,1519
 tests/otrs_models/test_coverage_ticket.py,sha256=0W4f28BMhtZDvPm71d7YPJuiVi9jUI6WJBbjh3xs0mg,1019
 tests/otrs_models/test_customer_user.py,sha256=9TDojrOsQBqd4kdC8SxvG5Ub18AXkJ_tsYuUeHALZnc,2227
@@ -146,7 +146,7 @@ tests/otrs_models/test_switchboard_header_dynamic_fields.py,sha256=2xaVzEC9-6NZ9
 tests/otrs_models/test_switchboard_header_ticket.py,sha256=J5GFBgNVG8k0MU8AxvQNj-J3QNAe8CS6B8rsC0uepGk,4651
 tests/otrs_models/test_switchboard_ticket.py,sha256=SJNYlVqr9oIywNiMH-TwtK9BRB1iuM4VpfmqvvmqZsw,4973
 tests/otrs_models/test_telecom_company.py,sha256=nC4uBleU2Lr3qHr5VDo-6kbcTVwKgguC85TcbhTOn1c,1450
-tests/otrs_models/test_ticket_factory.py,sha256=sDB6FwI5hr0DaCUwfMWWQPXtsG-o9W4kTn7bkGpDHFQ,3597
+tests/otrs_models/test_ticket_factory.py,sha256=nvye2LK3vfYv3xRNqsBO9M0zYWRWAPWjEFgdDpY1whQ,4048
 tests/otrs_models/test_vf_provisioning_article.py,sha256=Yj8vtaowhxP12K_-FMcJNW-5re3yyCCfGLRHCPYgrVA,897
 tests/otrs_models/configuration/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tests/otrs_models/configuration/changes/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -196,7 +196,7 @@ tests/services/test_update_ticket_with_provider_info.py,sha256=cZUg-hNV4BoMwafbp
 tests/user_management_client/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tests/user_management_client/test_client.py,sha256=088q9H1yf8Hii7zUF17KULqOO-JCxJLsR7vQ8lGHiqg,4410
 tests/user_management_client/test_user_management_response.py,sha256=HCCG7i2f6-ytrRpTzYZHODKCdW-X5GJn-BMVegd5FXg,1539
-otrs_somconnexio-0.7.0.dist-info/METADATA,sha256=Ld6dEmQZ66u5Ozmdd-xG3ZzjP-HXZB6wPD0Z6ZHVtVw,3458
-otrs_somconnexio-0.7.0.dist-info/WHEEL,sha256=fS9sRbCBHs7VFcwJLnLXN1MZRR0_TVTxvXKzOnaSFs8,110
-otrs_somconnexio-0.7.0.dist-info/top_level.txt,sha256=gvMaHGNwusWpSIy-PVyb0CKDIA4-4fXmEVER_2a-OnE,23
-otrs_somconnexio-0.7.0.dist-info/RECORD,,
+otrs_somconnexio-0.7.1.dist-info/METADATA,sha256=2u54KWVBGnJ7IuG9O1aMU33aH7gbGjbP2XDQ8tXjMeQ,3458
+otrs_somconnexio-0.7.1.dist-info/WHEEL,sha256=fS9sRbCBHs7VFcwJLnLXN1MZRR0_TVTxvXKzOnaSFs8,110
+otrs_somconnexio-0.7.1.dist-info/top_level.txt,sha256=gvMaHGNwusWpSIy-PVyb0CKDIA4-4fXmEVER_2a-OnE,23
+otrs_somconnexio-0.7.1.dist-info/RECORD,,

tests/otrs_models/test_adsl_ticket.py

@@ -9,8 +9,6 @@ from otrs_somconnexio.otrs_models.configurations.provision.adsl_ticket import (
 
 
 class ADSLTicketTestCase(unittest.TestCase):
-    def setUp(self):
-        self.responsible_data = Mock(spec=["email"])
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.Ticket")
     def test_build_ticket(self, MockTicket):
@@ -26,10 +24,10 @@ class ADSLTicketTestCase(unittest.TestCase):
             "Priority": ADSLTicketConfiguration.priority,
             "CustomerUser": customer_data.id,
             "CustomerID": customer_data.id,
-            "Responsible": self.responsible_data.email,
+            "Responsible": False,
         }
 
-        ADSLTicket(service_data, customer_data, self.responsible_data)._build_ticket()
+        ADSLTicket(service_data, customer_data, None)._build_ticket()
         MockTicket.assert_called_with(expected_ticket_arguments)
 
     @patch("otrs_somconnexio.otrs_models.provision_ticket.ProvisionArticle")
@@ -39,7 +37,7 @@ class ADSLTicketTestCase(unittest.TestCase):
 
         mock_mobile_article = MockInternetArticle.return_value
 
-        ADSLTicket(service_data, customer_data, self.responsible_data)._build_article()
+        ADSLTicket(service_data, customer_data, None)._build_article()
 
         MockInternetArticle.assert_called_with(
             service_data.technology, service_data.order_id, "adsl", service_data.notes
@@ -53,9 +51,7 @@ class ADSLTicketTestCase(unittest.TestCase):
 
         mock_adsl_dynamic_fields = MockADSLDynamicFields.return_value
 
-        ADSLTicket(
-            service_data, customer_data, self.responsible_data
-        )._build_dynamic_fields()
+        ADSLTicket(service_data, customer_data, None)._build_dynamic_fields()
 
         MockADSLDynamicFields.assert_called_with(
             service_data,
@@ -115,14 +111,13 @@ class ADSLTicketTestCase(unittest.TestCase):
                 "confirmed_documentation",
             ]
         )
-        self.responsible_data = Mock(spec=["email"])
 
         mock_otrs_client = Mock(spec=["create_otrs_process_ticket"])
         mock_otrs_client.create_otrs_process_ticket.return_value.id = 123
         mock_otrs_client.create_otrs_process_ticket.return_value.number = "#123"
         MockOTRSClient.return_value = mock_otrs_client
 
-        ticket = ADSLTicket(service_data, customer_data, self.responsible_data)
+        ticket = ADSLTicket(service_data, customer_data, None)
         ticket.create()
 
         mock_otrs_client.create_otrs_process_ticket.assert_called_once()

tests/otrs_models/test_ticket_factory.py

@@ -88,6 +88,18 @@ class TicketFactoryTestCase(unittest.TestCase):
             responsible_data=self.responsible_data,
         )
 
+    @patch("otrs_somconnexio.otrs_models.ticket_factory.FiberTicket")
+    def test_build_fibre_ticket_without_responsible(self, MockFiberTicket):
+        self.service_data.service_type = "fiber"
+
+        TicketFactory(self.service_data, self.customer_data).build()
+
+        MockFiberTicket.assert_called_once_with(
+            service_data=self.service_data,
+            customer_data=self.customer_data,
+            responsible_data=None,
+        )
+
     def test_build_service_not_allowed_error(self):
         self.service_data.service_type = ""