ositah 24.9.dev3__py3-none-any.whl → 24.9.dev5__py3-none-any.whl

ositah/apps/validation/tables.py

@@ -23,6 +23,7 @@ from ositah.apps.validation.tools import (
     agent_project_time,
     agent_tooltip_txt,
     category_declarations,
+    define_declaration_thresholds,
     get_all_validation_status,
     validation_started,
 )
@@ -71,6 +72,7 @@ def build_validation_table(team, team_selection_date, declaration_set: int, peri
             validation_disabled = not validation_started(period_date)
 
     validation_data = get_all_validation_status(period_date)
+    define_declaration_thresholds(period_date)
 
     try:
         project_declarations = get_team_projects(

ositah/apps/validation/tools.py

@@ -2,7 +2,7 @@
 Various functions used by Validation sub-application
 """
 
-from datetime import datetime
+from datetime import date, datetime
 
 import dash_bootstrap_components as dbc
 import pandas as pd
@@ -54,7 +54,7 @@ def activity_time_cell(row, column, row_index):
     cell_id = f"validation-table-value-{row_index}-{column}"
 
     if column == "percent_global":
-        thresholds = global_params.declaration_options["thresholds"]
+        thresholds = global_params.declaration_options["thresholds"]["current"]
         percent = round(row["percent_global"], 1)
         if percent <= thresholds["low"]:
             percent_class = "table-danger"
@@ -374,6 +374,25 @@ def category_declarations(
     return category_declarations
 
 
+def define_declaration_thresholds(period_date: str):
+    """
+    Define the declaration thresholds (low, suspect, normal) for the current period
+
+    :param period_date: a date that must be inside the declaration period
+    """
+    global_params = GlobalParams()
+
+    period_datetime = date.fromisoformat(period_date)
+    if period_datetime.month >= 7:
+        global_params.declaration_options["thresholds"]["current"] = (
+            global_params.declaration_options["thresholds"]["s2"]
+        )
+    else:
+        global_params.declaration_options["thresholds"]["current"] = (
+            global_params.declaration_options["thresholds"]["s1"]
+        )
+
+
 def get_validation_data(agent_id, period_date: str, session=None):
     """
     Return the validation data for an agent or None if there is no entry in the database for this

ositah/ositah.example.cfg

@@ -84,8 +84,10 @@ server:
 
 # Options related to declarations
 declaration:
-  # Default date must be a date included into the selected validation period. It is a default, if no other explicitly select
+  # Default date must be a date included into the selected validation period. It is a default, if no other explicitly selection
   #default_date: 2021-07-01
+  # Delay (in days) before setting the default period to the next one, after the end of the period. Ignored if default_date is defined
+  period_change_delay: 60
   # max_hours specifies the upper valid value for activities declared in hours
   max_hours: 400
   # Agent statut whose declaration is not mandatory
@@ -99,11 +101,19 @@ declaration:
     - Administration
     - Support
   # Thresholds used to mark declarations as low, suspect or good
-  # The value is the upper bound for the corresonding class
+  # The value is the upper bound for the corresponding class
+  # Thresholds are declared by semester as they are typically different
   thresholds:
-    low: 50
-    suspect: 80
-    good: 100
+    # S1: assume ho holidays as the default
+    s1:
+      low: 50
+      suspect: 80
+      good: 100
+    # S2: assume 4 weeks of holidays by default (summer + Christmas)
+    s2:
+      low: 50
+      suspect: 70
+      good: 85
 
 # Information related to declaration analysis
 analysis:

ositah/utils/period.py

@@ -119,7 +119,8 @@ def get_declaration_periods(descending: bool = True) -> List[OSITAHDeclarationPe
 def get_default_period_date(periods: List[OSITAHDeclarationPeriod], date: datetime.date):
     """
     Return the start date of the default period. The default period is selected by passing a date
-    that must be between period start and end dates (included).
+    that must be between period start and end dates (included). If none matches, select the last
+    period.
 
     :param periods: period list
     :param date: date that must be inside the period (string)
@@ -127,9 +128,12 @@ def get_default_period_date(periods: List[OSITAHDeclarationPeriod], date: dateti
     """
 
     period_date = date.isoformat()
+    last_start_date = None
 
     for p in periods:
         if period_date >= p.start_date and period_date <= p.end_date:
             return p.start_date
+        if last_start_date is None or p.start_date > last_start_date:
+            last_start_date = p.start_date
 
-    return None
+    return last_start_date

ositah/utils/utils.py

@@ -1,6 +1,6 @@
 # Convenience objects for OSITAH application
 
-from datetime import datetime
+from datetime import datetime, timedelta
 from typing import List
 
 import dash_bootstrap_components as dbc
@@ -381,15 +381,24 @@ def define_config_params(file):
     if "max_hours" not in config["declaration"]:
         # Set a very high value
         config["declaration"]["max_hours"] = 99999
-    if "thresholds" in config["declaration"]:
+    missing_params = []
+    for semester in ["s1", "s2"]:
         for k in ["low", "suspect", "good"]:
-            if k not in config["declaration"]["thresholds"]:
-                raise ConfigMissingParam(f"declaration/thresholds/{k}", file)
-    else:
-        config["declaration"]["thresholds"] = {"low": 50, "suspect": 75, "good": 100}
+            if (
+                "thresholds" not in config["declaration"]
+                or semester not in config["declaration"]["thresholds"]
+                or k not in config["declaration"]["thresholds"][semester]
+            ):
+                missing_params.append(f"declaration/thresholds/{semester}/{k}")
+    if len(missing_params) > 0:
+        raise ConfigMissingParam(", ".join(missing_params), file)
     # Default declaration period date defaults to current day if not explicitly defined
     if "default_date" not in config["declaration"]:
-        config["declaration"]["default_date"] = datetime.now()
+        if "period_change_delay" in config["declaration"]:
+            change_delay = config["declaration"]["period_change_delay"]
+        else:
+            change_delay = 0
+        config["declaration"]["default_date"] = datetime.now() - timedelta(days=change_delay)
     global_params.declaration_options = config["declaration"]
 
     if "analysis" not in config:

{ositah-24.9.dev3.dist-info → ositah-24.9.dev5.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: ositah
-Version: 24.9.dev3
+Version: 24.9.dev5
 Summary: Outils de Suivi d'Activités basé sur Hito
 Author-email: Michel Jouvin <michel.jouvin@ijclab.in2p3.fr>
 License: BSD 3-Clause License
@@ -19,7 +19,7 @@ Requires-Dist: flask
 Requires-Dist: flask-multipass
 Requires-Dist: flask-sqlalchemy ~=3.0
 Requires-Dist: flask-wtf
-Requires-Dist: hito-tools >=24.8
+Requires-Dist: hito-tools >=24.8.1
 Requires-Dist: pandas >=2.2
 Requires-Dist: pymysql
 Requires-Dist: python-ldap

{ositah-24.9.dev3.dist-info → ositah-24.9.dev5.dist-info}/RECORD

@@ -1,7 +1,7 @@
 ositah/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 ositah/app.py,sha256=53ylXmqBSo31omZt-XBPBhOzlkGQBuDenU0Q8m7efCg,428
 ositah/main.py,sha256=vw8PBYP3ugtWKWUta3UKagh8lbp-ogl8LUNF-KSyo0s,15673
-ositah/ositah.example.cfg,sha256=uLJAcPNziiOBFqjnUGLs7fPEhntpRJ3Pzu5Ab4CSxXQ,7571
+ositah/ositah.example.cfg,sha256=4zQOL3ynGN9bO6j-bekJeJWUe7Xq-c0eySNOHKMr2K8,8000
 ositah/apps/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 ositah/apps/analysis.py,sha256=9EDXcCtXtAiCdyG8kZXJDAQXLuTG7gTZbsnKnL_ehiw,28635
 ositah/apps/export.py,sha256=4h9_nk9uKopwfxgzqKyFk5u4qVQ9mtgGvk3zmxbhTV0,47532
@@ -14,8 +14,8 @@ ositah/apps/validation/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3
 ositah/apps/validation/callbacks.py,sha256=N9j0HLe8Xp1zZUrVgx0woeDBwVtJLQZ_BPVNaJ9UIZo,9557
 ositah/apps/validation/main.py,sha256=en9D6c65DUosbU31dxLR6BhLCU3yj7uxyoS3MYzvw30,2896
 ositah/apps/validation/parameters.py,sha256=tDHqDnoWv1QhcTad2yhqLT9_wCpj8sTYxKWsi1UF-uk,1003
-ositah/apps/validation/tables.py,sha256=avzGAX2qRiuLCg0BLLt0a4cf6ZRD1bNBp5cHQVrShNI,24372
-ositah/apps/validation/tools.py,sha256=jyKQtVMylYkurVLTmRLtuICpjwN5LM4YMB4PPS4GMaA,18105
+ositah/apps/validation/tables.py,sha256=eJ8dhYukhT1y_y8W8fjFv5Wek3knmGxAcQFFV708llM,24456
+ositah/apps/validation/tools.py,sha256=5c4IbAB_8KCgl44gNI0Qe0f3hRwJ6GAVRyIFKJ7iNhc,18800
 ositah/assets/arrow_down_up.svg,sha256=jH7QOmbLkYnNENa2PlBktOYHKDGN5KbrrFcV6UpgkCY,503
 ositah/assets/ositah.css,sha256=_T3mwonAYMPoDJoHYgJ5XgdFllHMcE28vnMMDd_hdOQ,1094
 ositah/assets/sort_ascending.svg,sha256=Rg4wPgEBEBU9hDPgNnenFYkFLC18qKw0flaBk_8Y-uM,593
@@ -34,13 +34,13 @@ ositah/utils/exceptions.py,sha256=ZVngkr28pBxO-kZAeKW9FWAFyhzuWL98-S92mieHMSk,19
 ositah/utils/hito_db.py,sha256=awVGrd1DAyj6BaEkLjTVN1l9A5SjZUJ1-fQ5PAik7bI,1510
 ositah/utils/hito_db_model.py,sha256=GvCHp5u-mPQinbZPvF6ONJAWIc2no1KN_VNJv6NCaPk,9356
 ositah/utils/menus.py,sha256=Xoyo2ySX0MD7phzyO5WjEcR0PCXwsX1TSrzONXnX4yI,12005
-ositah/utils/period.py,sha256=CxT77mAQasD59BmecXRUwme-_76hOr2kotOwTy6ZKfk,4058
+ositah/utils/period.py,sha256=ZuaiZ2gvSIjd23isvygEVoAvonH4ehbexjrS4EwSGyI,4258
 ositah/utils/projects.py,sha256=LuyUVtKqTb3qUWbsgwrE-9DqyW1bkV9y-n_n0oRaotQ,43476
 ositah/utils/teams.py,sha256=K8Z6kqs-kFpNiIg6wgmmZ3_tmfUPaB7wp0OAGmmZPG4,1234
-ositah/utils/utils.py,sha256=N7Ze4PshzRi8v204mRdDJ6QSmUZvckqH3oHKkI7WaWI,16667
-ositah-24.9.dev3.dist-info/LICENSE,sha256=2C86YWCx1fvz92WySupcb6_t4NhHCVPE_ucy0YMTuoc,1550
-ositah-24.9.dev3.dist-info/METADATA,sha256=jibVKLeSDzkEn_7pljac1KFSwTmoAPDHLUHk9EMGVR8,8104
-ositah-24.9.dev3.dist-info/WHEEL,sha256=Mdi9PDNwEZptOjTlUcAth7XJDFtKrHYaQMPulZeBCiQ,91
-ositah-24.9.dev3.dist-info/entry_points.txt,sha256=t9oDDLUO1LwHJewlE862LbJMHpDTEyqbeUAPw_F7Q3I,44
-ositah-24.9.dev3.dist-info/top_level.txt,sha256=3kfj_oK4xoZFt0nsw6KKT_aoqshELBu0ryLXECbcqNI,7
-ositah-24.9.dev3.dist-info/RECORD,,
+ositah/utils/utils.py,sha256=NQq0roHDvIkKj1gl88yu3bvloH0dPnBE1rKXVP_hdK4,17082
+ositah-24.9.dev5.dist-info/LICENSE,sha256=2C86YWCx1fvz92WySupcb6_t4NhHCVPE_ucy0YMTuoc,1550
+ositah-24.9.dev5.dist-info/METADATA,sha256=sOyz93EedQL_ZsXMyavpBtsCpqoaZaBnp0HmTZHl7Rg,8106
+ositah-24.9.dev5.dist-info/WHEEL,sha256=Mdi9PDNwEZptOjTlUcAth7XJDFtKrHYaQMPulZeBCiQ,91
+ositah-24.9.dev5.dist-info/entry_points.txt,sha256=t9oDDLUO1LwHJewlE862LbJMHpDTEyqbeUAPw_F7Q3I,44
+ositah-24.9.dev5.dist-info/top_level.txt,sha256=3kfj_oK4xoZFt0nsw6KKT_aoqshELBu0ryLXECbcqNI,7
+ositah-24.9.dev5.dist-info/RECORD,,