orchestrator-core 2.10.0rc2__py3-none-any.whl → 3.0.0__py3-none-any.whl

orchestrator/migrations/versions/schema/2025-02-12_bac6be6f2b4f_added_input_state_table.py

@@ -0,0 +1,56 @@
+"""Added Input State Table.
+
+Revision ID: bac6be6f2b4f
+Revises: 4fjdn13f83ga
+Create Date: 2025-02-12 14:39:53.664284
+
+"""
+
+import sqlalchemy as sa
+import sqlalchemy_utils
+from alembic import op
+from sqlalchemy.dialects import postgresql
+
+from orchestrator import db
+
+# revision identifiers, used by Alembic.
+revision = "bac6be6f2b4f"
+down_revision = "4fjdn13f83ga"
+branch_labels = None
+depends_on = None
+
+
+def upgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.create_table(
+        "input_states",
+        sa.Column(
+            "input_state_id",
+            sqlalchemy_utils.types.uuid.UUIDType(),
+            server_default=sa.text("uuid_generate_v4()"),
+            nullable=False,
+        ),
+        sa.Column("pid", sqlalchemy_utils.types.uuid.UUIDType(), nullable=False),
+        sa.Column("input_state", postgresql.JSONB(astext_type=sa.Text()), nullable=False),  # type: ignore
+        sa.Column(
+            "input_time",
+            db.models.UtcTimestamp(timezone=True),
+            server_default=sa.text("current_timestamp"),
+            nullable=False,
+        ),
+        sa.Column("input_type", sa.Enum("user_input", "initial_state", name="inputtype"), nullable=False),
+        sa.ForeignKeyConstraint(
+            ["pid"],
+            ["processes.pid"],
+        ),
+        sa.PrimaryKeyConstraint("input_state_id"),
+    )
+    op.create_index(op.f("ix_input_state_input_state_id"), "input_states", ["input_state_id"], unique=False)
+    # ### end Alembic commands ###
+
+
+def downgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.drop_index(op.f("ix_input_state_input_state_id"), table_name="input_states")
+    op.drop_table("input_statse")
+    # ### end Alembic commands ###

orchestrator/schemas/engine_settings.py

@@ -16,7 +16,7 @@ import strawberry
 from pydantic import ConfigDict
 
 from orchestrator.schemas.base import OrchestratorBaseModel
-from orchestrator.types import strEnum
+from pydantic_forms.types import strEnum
 
 
 @strawberry.enum

orchestrator/schemas/subscription.py

@@ -22,7 +22,8 @@ from orchestrator.schemas.product import ProductBaseSchema
 from orchestrator.schemas.product_block import ProductBlockSchema
 from orchestrator.schemas.resource_type import ResourceTypeSchema
 from orchestrator.schemas.subscription_descriptions import SubscriptionDescriptionSchema
-from orchestrator.types import SubscriptionLifecycle, strEnum
+from orchestrator.types import SubscriptionLifecycle
+from pydantic_forms.types import strEnum
 
 
 class PortMode(strEnum):

orchestrator/services/celery.py

@@ -22,10 +22,11 @@ from kombu.exceptions import ConnectionError, OperationalError
 from orchestrator import app_settings
 from orchestrator.api.error_handling import raise_status
 from orchestrator.db import ProcessTable, db
+from orchestrator.services.input_state import store_input_state
 from orchestrator.services.processes import create_process, delete_process
 from orchestrator.targets import Target
-from orchestrator.types import State
 from orchestrator.workflows import get_workflow
+from pydantic_forms.types import State
 
 SYSTEM_USER = "SYSTEM"
 
@@ -53,9 +54,8 @@ def _celery_start_process(
     task_name = NEW_TASK if workflow.target == Target.SYSTEM else NEW_WORKFLOW
     trigger_task = get_celery_task(task_name)
     pstat = create_process(workflow_key, user_inputs, user)
-    tasks = pstat.state.s
     try:
-        result = trigger_task.delay(pstat.process_id, workflow_key, tasks, user)
+        result = trigger_task.delay(pstat.process_id, workflow_key, user)
         _block_when_testing(result)
         return pstat.process_id
     except (ConnectionError, OperationalError) as e:
@@ -82,9 +82,12 @@ def _celery_resume_process(
 
     task_name = RESUME_TASK if workflow.target == Target.SYSTEM else RESUME_WORKFLOW
     trigger_task = get_celery_task(task_name)
+
+    user_inputs = user_inputs or [{}]
+    store_input_state(pstat.process_id, user_inputs, "user_input")
     try:
         _celery_set_process_status_resumed(process)
-        result = trigger_task.delay(pstat.process_id, user_inputs, user)
+        result = trigger_task.delay(pstat.process_id, user)
         _block_when_testing(result)
 
         return pstat.process_id

orchestrator/services/input_state.py

@@ -0,0 +1,76 @@
+# Copyright 2019-2025 SURF.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+from typing import Any, Literal
+from uuid import UUID
+
+import structlog
+from sqlalchemy import select
+
+from orchestrator.db import db
+from orchestrator.db.models import InputStateTable
+
+logger = structlog.get_logger(__name__)
+
+InputType = Literal["initial_state", "user_input"]
+
+
+def retrieve_input_state(process_id: UUID, input_type: InputType) -> InputStateTable:
+    """Get user input.
+
+    Args:
+        process_id: Process ID
+        input_type: The type of the input.
+
+    Returns:
+        User input table
+
+    """
+
+    res: InputStateTable | None = db.session.scalars(
+        select(InputStateTable)
+        .filter(InputStateTable.process_id == process_id)
+        .filter(InputStateTable.input_type == input_type)
+        .order_by(InputStateTable.input_time.asc())
+    ).first()
+
+    if res:
+        logger.debug("Retrieved input state", process_id=process_id, input_state=res, input_type=input_type)
+        return res
+    raise ValueError(f"No input state for pid: {process_id}")
+
+
+def store_input_state(
+    process_id: UUID,
+    input_state: dict[str, Any] | list[dict[str, Any]],
+    input_type: InputType,
+) -> None:
+    """Store user input state.
+
+    Args:
+        process_id: Process ID
+        input_state: Dictionary of user input state
+        input_type: The type of the input.
+
+    Returns:
+        None
+
+    """
+    logger.debug("Store input state", process_id=process_id, input_state=input_state, input_type=input_type)
+    db.session.add(
+        InputStateTable(
+            process_id=process_id,
+            input_state=input_state,
+            input_type=input_type,
+        )
+    )
+    db.session.commit()

orchestrator/services/processes.py

@@ -18,7 +18,7 @@ from typing import Any
 from uuid import UUID, uuid4
 
 import structlog
-from deepmerge import Merger
+from deepmerge.merger import Merger
 from sqlalchemy import delete, select
 from sqlalchemy.exc import SQLAlchemyError
 from sqlalchemy.orm import joinedload
@@ -35,11 +35,12 @@ from orchestrator.db import (
 )
 from orchestrator.distlock import distlock_manager
 from orchestrator.schemas.engine_settings import WorkerStatus
+from orchestrator.services.input_state import store_input_state
 from orchestrator.services.settings import get_engine_settings_for_update
 from orchestrator.services.workflows import get_workflow_by_name
 from orchestrator.settings import ExecutorType, app_settings
 from orchestrator.targets import Target
-from orchestrator.types import BroadcastFunc, State
+from orchestrator.types import BroadcastFunc
 from orchestrator.utils.datetime import nowtz
 from orchestrator.utils.errors import error_state_to_dict
 from orchestrator.websocket import broadcast_invalidate_status_counts
@@ -60,6 +61,7 @@ from orchestrator.workflows import get_workflow
 from orchestrator.workflows.removed_workflow import removed_workflow
 from pydantic_forms.core import post_form
 from pydantic_forms.exceptions import FormValidationError
+from pydantic_forms.types import State
 
 logger = structlog.get_logger(__name__)
 
@@ -449,7 +451,7 @@ def create_process(
     )
 
     _db_create_process(pstat)
-
+    store_input_state(process_id, state | initial_state, "initial_state")
     return pstat
 
 
@@ -513,7 +515,7 @@ def thread_resume_process(
 
     if user_input:
         pstat.update(state=pstat.state.map(lambda state: StateMerger.merge(state, user_input)))
-
+    store_input_state(pstat.process_id, user_input, "user_input")
     # enforce an update to the process status to properly show the process
     process.last_status = ProcessStatus.RUNNING
     db.session.add(process)
@@ -528,8 +530,8 @@ def thread_validate_workflow(validation_workflow: str, json: list[State] | None)
 
 
 THREADPOOL_EXECUTION_CONTEXT: dict[str, Callable] = {
-    "start": lambda *args, **kwargs: thread_start_process(*args, **kwargs),
-    "resume": lambda *args, **kwargs: thread_resume_process(*args, **kwargs),
+    "start": thread_start_process,
+    "resume": thread_resume_process,
     "validate": thread_validate_workflow,
 }
 

orchestrator/services/products.py

@@ -18,7 +18,7 @@ from sqlalchemy import select
 from sqlalchemy.orm import joinedload
 
 from orchestrator.db import ProductTable, db
-from orchestrator.types import UUIDstr
+from pydantic_forms.types import UUIDstr
 
 
 def get_products(*, filters: list | None = None) -> list[ProductTable]:

orchestrator/services/subscriptions.py

@@ -43,9 +43,10 @@ from orchestrator.db.models import (
 )
 from orchestrator.domain.base import SubscriptionModel
 from orchestrator.targets import Target
-from orchestrator.types import SubscriptionLifecycle, UUIDstr
+from orchestrator.types import SubscriptionLifecycle
 from orchestrator.utils.datetime import nowtz
 from orchestrator.utils.helpers import is_ipaddress_type
+from pydantic_forms.types import UUIDstr
 
 logger = structlog.get_logger(__name__)
 

orchestrator/services/tasks.py

@@ -23,6 +23,7 @@ from kombu.serialization import registry
 
 from orchestrator.api.error_handling import raise_status
 from orchestrator.schemas.engine_settings import WorkerStatus
+from orchestrator.services.input_state import retrieve_input_state
 from orchestrator.services.processes import (
     _get_process,
     _run_process_async,
@@ -30,10 +31,11 @@ from orchestrator.services.processes import (
     safe_logstep,
     thread_resume_process,
 )
-from orchestrator.types import BroadcastFunc, State
+from orchestrator.types import BroadcastFunc
 from orchestrator.utils.json import json_dumps, json_loads
 from orchestrator.workflow import ProcessStat, ProcessStatus, Success, runwf
 from orchestrator.workflows import get_workflow
+from pydantic_forms.types import State
 
 logger = get_task_logger(__name__)
 
@@ -117,24 +119,28 @@ def initialise_celery(celery: Celery) -> None:  # noqa: C901
     celery_task = partial(celery.task, log=local_logger, serializer="orchestrator-json")
 
     @celery_task(name=NEW_TASK)  # type: ignore
-    def new_task(process_id, workflow_key: str, state: dict[str, Any], user: str) -> UUID | None:
+    def new_task(process_id, workflow_key: str, user: str) -> UUID | None:
         local_logger.info("Start task", process_id=process_id, workflow_key=workflow_key)
+        state = retrieve_input_state(process_id, "initial_state").input_state
         return start_process(process_id, workflow_key, state=state, user=user)
 
     @celery_task(name=NEW_WORKFLOW)  # type: ignore
-    def new_workflow(process_id, workflow_key: str, state: dict[str, Any], user: str) -> UUID | None:
+    def new_workflow(process_id, workflow_key: str, user: str) -> UUID | None:
         local_logger.info("Start workflow", process_id=process_id, workflow_key=workflow_key)
+        state = retrieve_input_state(process_id, "initial_state").input_state
         return start_process(process_id, workflow_key, state=state, user=user)
 
     @celery_task(name=RESUME_TASK)  # type: ignore
-    def resume_task(process_id: UUID, user_inputs: list[State] | None, user: str) -> UUID | None:
+    def resume_task(process_id: UUID, user: str) -> UUID | None:
         local_logger.info("Resume task", process_id=process_id)
-        return resume_process(process_id, user_inputs=user_inputs, user=user)
+        state = retrieve_input_state(process_id, "user_input").input_state
+        return resume_process(process_id, user_inputs=state, user=user)
 
     @celery_task(name=RESUME_WORKFLOW)  # type: ignore
-    def resume_workflow(process_id: UUID, user_inputs: list[State] | None, user: str) -> UUID | None:
+    def resume_workflow(process_id: UUID, user: str) -> UUID | None:
         local_logger.info("Resume workflow", process_id=process_id)
-        return resume_process(process_id, user_inputs=user_inputs, user=user)
+        state = retrieve_input_state(process_id, "user_input").input_state
+        return resume_process(process_id, user_inputs=state, user=user)
 
 
 class CeleryJobWorkerStatus(WorkerStatus):

orchestrator/services/workflows.py

@@ -1,3 +1,16 @@
+# Copyright 2019-2025 SURF.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 from collections.abc import Iterable
 
 from sqlalchemy import Select, select

orchestrator/settings.py

@@ -16,11 +16,11 @@ import string
 from pathlib import Path
 from typing import Literal
 
-from pydantic import PostgresDsn, RedisDsn
+from pydantic import Field, NonNegativeInt, PostgresDsn, RedisDsn
 from pydantic_settings import BaseSettings
 
 from oauth2_lib.settings import oauth2lib_settings
-from orchestrator.types import strEnum
+from pydantic_forms.types import strEnum
 
 
 class ExecutorType(strEnum):
@@ -57,6 +57,9 @@ class AppSettings(BaseSettings):
     CACHE_URI: RedisDsn = "redis://localhost:6379/0"  # type: ignore
     CACHE_DOMAIN_MODELS: bool = False
     CACHE_HMAC_SECRET: str | None = None  # HMAC signing key, used when pickling results in the cache
+    REDIS_RETRY_COUNT: NonNegativeInt = Field(
+        2, description="Number of retries for redis connection errors/timeouts, 0 to disable"
+    )  # More info: https://redis-py.readthedocs.io/en/stable/retry.html
     ENABLE_DISTLOCK_MANAGER: bool = True
     DISTLOCK_BACKEND: str = "memory"
     CC_NOC: int = 0

orchestrator/targets.py

@@ -13,7 +13,7 @@
 
 import strawberry
 
-from orchestrator.types import strEnum
+from pydantic_forms.types import strEnum
 
 
 @strawberry.enum

orchestrator/types.py

@@ -34,59 +34,24 @@ from annotated_types import Len, MaxLen, MinLen
 from more_itertools import first, last
 from pydantic.fields import FieldInfo
 
-# TODO #428: eventually enforce code migration for downstream users to import
-# these types from pydantic_forms themselves
-from pydantic_forms.types import (
-    JSON,
-    AcceptData,
-    AcceptItemType,
-    FormGenerator,
-    FormGeneratorAsync,
-    InputForm,
-    InputFormGenerator,
-    InputStepFunc,
-    SimpleInputFormGenerator,
-    State,
-    StateInputFormGenerator,
-    StateInputFormGeneratorAsync,
-    StateInputStepFunc,
-    StateSimpleInputFormGenerator,
-    SubscriptionMapping,
-    SummaryData,
-    UUIDstr,
-    strEnum,
-)
+from pydantic_forms.types import InputForm, State, strEnum
 
 __all__ = [
-    "JSON",
+    "SAFE_USED_BY_TRANSITIONS_FOR_STATUS",
     "BroadcastFunc",
-    "AcceptData",
-    "AcceptItemType",
     "ErrorDict",
     "ErrorState",
-    "FormGenerator",
-    "FormGeneratorAsync",
-    "InputForm",
-    "InputFormGenerator",
-    "InputStepFunc",
-    "SimpleInputFormGenerator",
-    "State",
-    "StateInputFormGenerator",
-    "StateInputFormGeneratorAsync",
-    "StateInputStepFunc",
-    "StateSimpleInputFormGenerator",
     "StateStepFunc",
     "StepFunc",
     "SubscriptionLifecycle",
-    "SubscriptionMapping",
-    "SummaryData",
-    "UUIDstr",
+    "filter_nonetype",
+    "get_origin_and_args",
+    "get_possible_product_block_types",
     "is_list_type",
     "is_of_type",
     "is_optional_type",
     "is_union_type",
-    "get_possible_product_block_types",
-    "strEnum",
+    "list_factory",
 ]
 
 if TYPE_CHECKING:
@@ -97,8 +62,8 @@ def is_union(tp: type[Any] | None) -> bool:
     return tp is Union or tp is types.UnionType  # type: ignore[comparison-overlap]
 
 
-# ErrorState is either a string containing an error message, a catched Exception or a tuple containing a message and
-# a HTTP status code
+# ErrorState is either a string containing an error message, a caught Exception, or a tuple containing a message and
+# an HTTP status code
 ErrorState = Union[str, Exception, tuple[str, Union[int, HTTPStatus]]]
 # An ErrorDict should have the following keys:
 # error: str  # A message describing the error

orchestrator/utils/errors.py

@@ -18,7 +18,8 @@ from typing import Any, cast
 import structlog
 
 from nwastdlib.ex import show_ex
-from orchestrator.types import JSON, ErrorDict
+from orchestrator.types import ErrorDict
+from pydantic_forms.types import JSON
 
 logger = structlog.get_logger(__name__)
 

orchestrator/utils/redis.py

@@ -17,22 +17,22 @@ from os import getenv
 from typing import Any, Callable
 from uuid import UUID
 
-import redis.exceptions
 from anyio import CancelScope, get_cancelled_exc_class
-from redis import Redis
 from redis.asyncio import Redis as AIORedis
 from redis.asyncio.client import Pipeline, PubSub
-from redis.asyncio.retry import Retry
-from redis.backoff import EqualJitterBackoff
 from structlog import get_logger
 
 from orchestrator.services.subscriptions import _generate_etag
 from orchestrator.settings import app_settings
 from orchestrator.utils.json import PY_JSON_TYPES, json_dumps, json_loads
+from orchestrator.utils.redis_client import (
+    create_redis_asyncio_client,
+    create_redis_client,
+)
 
 logger = get_logger(__name__)
 
-cache = Redis.from_url(str(app_settings.CACHE_URI))
+cache = create_redis_client(app_settings.CACHE_URI)
 
 ONE_WEEK = 3600 * 24 * 7
 
@@ -136,12 +136,7 @@ class RedisBroadcast:
     client: AIORedis
 
     def __init__(self, redis_url: str):
-        self.client = AIORedis.from_url(
-            redis_url,
-            retry_on_error=[redis.exceptions.ConnectionError],
-            retry_on_timeout=True,
-            retry=Retry(EqualJitterBackoff(base=0.05), 2),
-        )
+        self.client = create_redis_asyncio_client(redis_url)
         self.redis_url = redis_url
 
     @asynccontextmanager

orchestrator/utils/redis_client.py

@@ -0,0 +1,35 @@
+import redis.asyncio
+import redis.client
+import redis.exceptions
+from pydantic import RedisDsn
+from redis import Redis
+from redis.asyncio import Redis as AIORedis
+from redis.asyncio.retry import Retry as AIORetry
+from redis.backoff import EqualJitterBackoff
+from redis.retry import Retry
+
+from orchestrator.settings import app_settings
+
+REDIS_RETRY_ON_ERROR = [redis.exceptions.ConnectionError]
+REDIS_RETRY_ON_TIMEOUT = True
+REDIS_RETRY_BACKOFF = EqualJitterBackoff(base=0.05)
+
+
+def create_redis_client(redis_url: str | RedisDsn) -> redis.client.Redis:
+    """Create sync Redis client for the given Redis DSN with retry handling for connection errors and timeouts."""
+    return Redis.from_url(
+        str(redis_url),
+        retry_on_error=REDIS_RETRY_ON_ERROR,  # type: ignore[arg-type]
+        retry_on_timeout=REDIS_RETRY_ON_TIMEOUT,
+        retry=Retry(REDIS_RETRY_BACKOFF, app_settings.REDIS_RETRY_COUNT),
+    )
+
+
+def create_redis_asyncio_client(redis_url: str | RedisDsn) -> redis.asyncio.client.Redis:
+    """Create async Redis client for the given Redis DSN with retry handling for connection errors and timeouts."""
+    return AIORedis.from_url(
+        str(redis_url),
+        retry_on_error=REDIS_RETRY_ON_ERROR,  # type: ignore[arg-type]
+        retry_on_timeout=REDIS_RETRY_ON_TIMEOUT,
+        retry=AIORetry(REDIS_RETRY_BACKOFF, app_settings.REDIS_RETRY_COUNT),
+    )

orchestrator/utils/state.py

@@ -19,7 +19,7 @@ from typing import Any, cast, get_args
 from uuid import UUID
 
 from orchestrator.domain.base import SubscriptionModel
-from orchestrator.types import State, StepFunc, is_list_type, is_optional_type
+from orchestrator.types import StepFunc, is_list_type, is_optional_type
 from orchestrator.utils.functional import logger
 from pydantic_forms.types import (
     FormGenerator,
@@ -27,6 +27,7 @@ from pydantic_forms.types import (
     InputFormGenerator,
     InputStepFunc,
     SimpleInputFormGenerator,
+    State,
     StateInputStepFunc,
 )
 

orchestrator/workflow.py

@@ -43,7 +43,7 @@ from orchestrator.config.assignee import Assignee
 from orchestrator.db import db, transactional
 from orchestrator.services.settings import get_engine_settings
 from orchestrator.targets import Target
-from orchestrator.types import ErrorDict, State, StepFunc, strEnum
+from orchestrator.types import ErrorDict, StepFunc
 from orchestrator.utils.docs import make_workflow_doc
 from orchestrator.utils.errors import error_state_to_dict
 from orchestrator.utils.state import form_inject_args, inject_args
@@ -52,9 +52,11 @@ from pydantic_forms.types import (
     FormGenerator,
     InputFormGenerator,
     InputStepFunc,
+    State,
     StateInputFormGenerator,
     StateInputStepFunc,
     StateSimpleInputFormGenerator,
+    strEnum,
 )
 
 logger = structlog.get_logger(__name__)

orchestrator/workflows/modify_note.py

@@ -15,12 +15,11 @@ from orchestrator.forms import SubmitFormPage
 from orchestrator.services import subscriptions
 from orchestrator.settings import app_settings
 from orchestrator.targets import Target
-from orchestrator.types import UUIDstr
 from orchestrator.utils.json import to_serializable
 from orchestrator.workflow import StepList, conditional, done, init, step, workflow
 from orchestrator.workflows.steps import cache_domain_models, store_process_subscription
 from orchestrator.workflows.utils import wrap_modify_initial_input_form
-from pydantic_forms.types import FormGenerator, State
+from pydantic_forms.types import FormGenerator, State, UUIDstr
 from pydantic_forms.validators import LongText
 
 

orchestrator/workflows/steps.py

@@ -23,11 +23,12 @@ from orchestrator.domain.base import ProductBlockModel, SubscriptionModel
 from orchestrator.services.settings import reset_search_index
 from orchestrator.services.subscriptions import build_extended_domain_model, get_subscription
 from orchestrator.targets import Target
-from orchestrator.types import State, SubscriptionLifecycle, UUIDstr
+from orchestrator.types import SubscriptionLifecycle
 from orchestrator.utils.json import to_serializable
 from orchestrator.utils.redis import delete_from_redis, to_redis
 from orchestrator.websocket import sync_invalidate_subscription_cache
 from orchestrator.workflow import Step, step
+from pydantic_forms.types import State, UUIDstr
 
 logger = structlog.get_logger(__name__)
 

orchestrator/workflows/tasks/cleanup_tasks_log.py

@@ -19,9 +19,9 @@ from sqlalchemy import select
 from orchestrator.db import ProcessTable, db
 from orchestrator.settings import app_settings
 from orchestrator.targets import Target
-from orchestrator.types import State
 from orchestrator.utils.datetime import nowtz
 from orchestrator.workflow import ProcessStatus, StepList, done, init, step, workflow
+from pydantic_forms.types import State
 
 
 @step("Clean up completed tasks older than TASK_LOG_RETENTION_DAYS")

orchestrator/workflows/tasks/resume_workflows.py

@@ -18,8 +18,8 @@ from sqlalchemy import select
 from orchestrator.db import ProcessTable, db
 from orchestrator.services import processes
 from orchestrator.targets import Target
-from orchestrator.types import State, UUIDstr
 from orchestrator.workflow import ProcessStatus, StepList, done, init, step, workflow
+from pydantic_forms.types import State, UUIDstr
 
 logger = structlog.get_logger(__name__)
 

orchestrator/workflows/tasks/validate_product_type.py

@@ -26,8 +26,8 @@ from orchestrator.services.workflows import (
     start_validation_workflow_for_workflows,
 )
 from orchestrator.targets import Target
-from orchestrator.types import FormGenerator, State
 from orchestrator.workflow import StepList, done, init, step, workflow
+from pydantic_forms.types import FormGenerator, State
 
 logger = structlog.get_logger(__name__)
 

orchestrator/workflows/tasks/validate_products.py

@@ -27,10 +27,10 @@ from orchestrator.services.products import get_products
 from orchestrator.services.translations import generate_translations
 from orchestrator.services.workflows import get_workflow_by_name, get_workflows
 from orchestrator.targets import Target
-from orchestrator.types import State
 from orchestrator.utils.errors import ProcessFailureError
 from orchestrator.utils.fixed_inputs import fixed_input_configuration as fi_configuration
 from orchestrator.workflow import StepList, done, init, step, workflow
+from pydantic_forms.types import State
 
 # Since these errors are probably programming failures we should not throw AssertionErrors