openmetadata-ingestion 1.2.4.0__py3-none-any.whl → 1.3.2.0rc1__py3-none-any.whl

metadata/ingestion/source/dashboard/dashboard_service.py

@@ -34,7 +34,6 @@ from metadata.generated.schema.entity.services.dashboardService import (
     DashboardConnection,
     DashboardService,
 )
-from metadata.generated.schema.entity.teams.user import User
 from metadata.generated.schema.metadataIngestion.dashboardServiceMetadataPipeline import (
     DashboardServiceMetadataPipeline,
 )
@@ -55,8 +54,8 @@ from metadata.ingestion.models.patch_request import PatchRequest
 from metadata.ingestion.models.topology import (
     NodeStage,
     ServiceTopology,
+    TopologyContext,
     TopologyNode,
-    create_source_context,
 )
 from metadata.ingestion.ometa.ometa_api import OpenMetadata
 from metadata.ingestion.source.connections import get_connection, get_test_connection_fn
@@ -105,7 +104,7 @@ class DashboardServiceTopology(ServiceTopology):
             ),
             NodeStage(
                 type_=OMetaTagAndClassification,
-                processor="yield_tag",
+                processor="yield_bulk_tags",
                 nullable=True,
             ),
         ],
@@ -133,14 +132,19 @@ class DashboardServiceTopology(ServiceTopology):
     dashboard = TopologyNode(
         producer="get_dashboard",
         stages=[
+            NodeStage(
+                type_=OMetaTagAndClassification,
+                processor="yield_tags",
+                nullable=True,
+            ),
             NodeStage(
                 type_=Chart,
                 context="charts",
                 processor="yield_dashboard_chart",
                 consumer=["dashboard_service"],
                 nullable=True,
-                cache_all=True,
-                clear_cache=True,
+                store_all_in_context=True,
+                clear_context=True,
                 use_cache=True,
             ),
             NodeStage(
@@ -149,8 +153,8 @@ class DashboardServiceTopology(ServiceTopology):
                 processor="yield_datamodel",
                 consumer=["dashboard_service"],
                 nullable=True,
-                cache_all=True,
-                clear_cache=True,
+                store_all_in_context=True,
+                clear_context=True,
                 use_cache=True,
             ),
             NodeStage(
@@ -160,12 +164,6 @@ class DashboardServiceTopology(ServiceTopology):
                 consumer=["dashboard_service"],
                 use_cache=True,
             ),
-            NodeStage(
-                type_=User,
-                context="owner",
-                processor="process_owner",
-                consumer=["dashboard_service"],
-            ),
             NodeStage(
                 type_=AddLineageRequest,
                 processor="yield_dashboard_lineage",
@@ -196,7 +194,7 @@ class DashboardServiceSource(TopologyRunnerMixin, Source, ABC):
     service_connection: DashboardConnection.__fields__["config"].type_
 
     topology = DashboardServiceTopology()
-    context = create_source_context(topology)
+    context = TopologyContext.create(topology)
     dashboard_source_state: Set = set()
     datamodel_source_state: Set = set()
 
@@ -218,6 +216,10 @@ class DashboardServiceSource(TopologyRunnerMixin, Source, ABC):
         self.connection_obj = self.client
         self.test_connection()
 
+    @property
+    def name(self) -> str:
+        return self.service_connection.type.name
+
     @abstractmethod
     def yield_dashboard(
         self, dashboard_details: Any
@@ -333,7 +335,16 @@ class DashboardServiceSource(TopologyRunnerMixin, Source, ABC):
                 dashboard_details, db_service_name
             ) or []
 
-    def yield_tag(self, *args, **kwargs) -> Iterable[Either[OMetaTagAndClassification]]:
+    def yield_bulk_tags(
+        self, *args, **kwargs
+    ) -> Iterable[Either[OMetaTagAndClassification]]:
+        """
+        Method to bulk fetch dashboard tags
+        """
+
+    def yield_tags(
+        self, dashboard_details
+    ) -> Iterable[Either[OMetaTagAndClassification]]:
         """
         Method to fetch dashboard tags
         """
@@ -386,34 +397,16 @@ class DashboardServiceSource(TopologyRunnerMixin, Source, ABC):
                 params={"service": self.context.dashboard_service},
             )
 
-    def process_owner(self, dashboard_details):
+    def get_owner_ref(  # pylint: disable=unused-argument, useless-return
+        self, dashboard_details
+    ) -> Optional[EntityReference]:
         """
-        Method to process the dashboard onwers
+        Method to process the dashboard owners
         """
-        try:
-            if self.source_config.includeOwners:
-                owner = self.get_owner_details(  # pylint: disable=assignment-from-none
-                    dashboard_details=dashboard_details
-                )
-                if owner:
-                    dashboard_fqn = fqn.build(
-                        self.metadata,
-                        entity_type=Dashboard,
-                        service_name=self.context.dashboard_service,
-                        dashboard_name=self.context.dashboard,
-                    )
-                    dashboard_entity = self.metadata.get_by_name(
-                        entity=Dashboard, fqn=dashboard_fqn
-                    )
-                    self.metadata.patch_owner(
-                        entity=Dashboard,
-                        source=dashboard_entity,
-                        owner=owner,
-                        force=False,
-                    )
-        except Exception as exc:
-            logger.debug(traceback.format_exc())
-            logger.warning(f"Error processing owner for {dashboard_details}: {exc}")
+        logger.debug(
+            f"Processing ownership is not supported for {self.service_connection.type.name}"
+        )
+        return None
 
     def register_record(self, dashboard_request: CreateDashboardRequest) -> None:
         """
@@ -429,7 +422,7 @@ class DashboardServiceSource(TopologyRunnerMixin, Source, ABC):
         self.dashboard_source_state.add(dashboard_fqn)
 
     def register_record_datamodel(
-        self, datamodel_requst: CreateDashboardDataModelRequest
+        self, datamodel_request: CreateDashboardDataModelRequest
     ) -> None:
         """
         Mark the datamodel record as scanned and update the datamodel_source_state
@@ -437,27 +430,12 @@ class DashboardServiceSource(TopologyRunnerMixin, Source, ABC):
         datamodel_fqn = fqn.build(
             self.metadata,
             entity_type=DashboardDataModel,
-            service_name=datamodel_requst.service.__root__,
-            data_model_name=datamodel_requst.name.__root__,
+            service_name=datamodel_request.service.__root__,
+            data_model_name=datamodel_request.name.__root__,
         )
 
         self.datamodel_source_state.add(datamodel_fqn)
 
-    def get_owner_details(  # pylint: disable=useless-return
-        self, dashboard_details  # pylint: disable=unused-argument
-    ) -> Optional[EntityReference]:
-        """Get dashboard owner
-
-        Args:
-            dashboard_details:
-        Returns:
-            Optional[EntityReference]
-        """
-        logger.debug(
-            f"Processing ownership is not supported for {self.service_connection.type.name}"
-        )
-        return None
-
     @staticmethod
     def _get_add_lineage_request(
         to_entity: Union[Dashboard, DashboardDataModel],
@@ -505,7 +483,7 @@ class DashboardServiceSource(TopologyRunnerMixin, Source, ABC):
                 self.context.project_name = (  # pylint: disable=assignment-from-none
                     self.get_project_name(dashboard_details=dashboard_details)
                 )
-                if self.context.project_name and filter_by_project(
+                if filter_by_project(
                     self.source_config.projectFilterPattern,
                     self.context.project_name,
                 ):
@@ -553,7 +531,6 @@ class DashboardServiceSource(TopologyRunnerMixin, Source, ABC):
         )
 
     def check_database_schema_name(self, database_schema_name: str):
-
         """
         Check if the input database schema name is equal to "<default>" and return the input name if it is not.
 

metadata/ingestion/source/dashboard/domodashboard/metadata.py

@@ -32,11 +32,14 @@ from metadata.generated.schema.entity.services.connections.dashboard.domoDashboa
 from metadata.generated.schema.entity.services.connections.metadata.openMetadataConnection import (
     OpenMetadataConnection,
 )
+from metadata.generated.schema.entity.services.ingestionPipelines.status import (
+    StackTraceError,
+)
 from metadata.generated.schema.metadataIngestion.workflow import (
     Source as WorkflowSource,
 )
 from metadata.generated.schema.type.entityReference import EntityReference
-from metadata.ingestion.api.models import Either, StackTraceError
+from metadata.ingestion.api.models import Either
 from metadata.ingestion.api.steps import InvalidSourceException
 from metadata.ingestion.ometa.ometa_api import OpenMetadata
 from metadata.ingestion.source.dashboard.dashboard_service import DashboardServiceSource
@@ -90,19 +93,14 @@ class DomodashboardSource(DashboardServiceSource):
     def get_dashboard_details(self, dashboard: DomoDashboardDetails) -> dict:
         return dashboard
 
-    def get_owner_details(
+    def get_owner_ref(
         self, dashboard_details: DomoDashboardDetails
     ) -> Optional[EntityReference]:
-        for owner in dashboard_details.owners:
+        for owner in dashboard_details.owners or []:
             try:
                 owner_details = self.client.domo.users_get(owner.id)
                 if owner_details.get("email"):
-                    user = self.metadata.get_user_by_email(owner_details["email"])
-                    if user:
-                        return EntityReference(id=user.id.__root__, type="user")
-                    logger.warning(
-                        f"No user found with email [{owner_details['email']}] in OMD"
-                    )
+                    return self.metadata.get_reference_by_email(owner_details["email"])
             except Exception as exc:
                 logger.warning(
                     f"Error while getting details of user {owner.displayName} - {exc}"
@@ -129,9 +127,10 @@ class DomodashboardSource(DashboardServiceSource):
                         service_name=self.context.dashboard_service,
                         chart_name=chart,
                     )
-                    for chart in self.context.charts
+                    for chart in self.context.charts or []
                 ],
                 service=self.context.dashboard_service,
+                owner=self.get_owner_ref(dashboard_details=dashboard_details),
             )
             yield Either(right=dashboard_request)
             self.register_record(dashboard_request=dashboard_request)
@@ -140,7 +139,7 @@ class DomodashboardSource(DashboardServiceSource):
                 left=StackTraceError(
                     name=dashboard_details.name,
                     error=f"Error extracting data from {dashboard_details.name} - {err}",
-                    stack_trace=traceback.format_exc(),
+                    stackTrace=traceback.format_exc(),
                 )
             )
         except ValidationError as err:
@@ -148,7 +147,7 @@ class DomodashboardSource(DashboardServiceSource):
                 left=StackTraceError(
                     name=dashboard_details.name,
                     error=f"Error building pydantic model for {dashboard_details.name} - {err}",
-                    stack_trace=traceback.format_exc(),
+                    stackTrace=traceback.format_exc(),
                 )
             )
         except Exception as err:
@@ -156,7 +155,7 @@ class DomodashboardSource(DashboardServiceSource):
                 left=StackTraceError(
                     name=dashboard_details.name,
                     error=f"Wild error ingesting dashboard {dashboard_details.name} - {err}",
-                    stack_trace=traceback.format_exc(),
+                    stackTrace=traceback.format_exc(),
                 )
             )
 
@@ -230,7 +229,7 @@ class DomodashboardSource(DashboardServiceSource):
                     left=StackTraceError(
                         name=name,
                         error=f"Error creating chart [{name}]: {exc}",
-                        stack_trace=traceback.format_exc(),
+                        stackTrace=traceback.format_exc(),
                     )
                 )
 

metadata/ingestion/source/dashboard/lightdash/metadata.py

@@ -114,9 +114,10 @@ class LightdashSource(DashboardServiceSource):
                         service_name=self.context.dashboard_service,
                         chart_name=chart,
                     )
-                    for chart in self.context.charts
+                    for chart in self.context.charts or []
                 ],
                 service=self.context.dashboard_service,
+                owner=self.get_owner_ref(dashboard_details=dashboard_details),
             )
             yield dashboard_request
             self.register_record(dashboard_request=dashboard_request)

metadata/ingestion/source/dashboard/looker/metadata.py

@@ -8,6 +8,7 @@
 #  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
+# pylint: disable=too-many-lines
 """
 Looker source module.
 Supports:
@@ -46,9 +47,7 @@ from metadata.generated.schema.api.data.createDashboardDataModel import (
 )
 from metadata.generated.schema.api.lineage.addLineage import AddLineageRequest
 from metadata.generated.schema.entity.data.chart import Chart
-from metadata.generated.schema.entity.data.dashboard import (
-    Dashboard as MetadataDashboard,
-)
+from metadata.generated.schema.entity.data.dashboard import Dashboard
 from metadata.generated.schema.entity.data.dashboardDataModel import (
     DashboardDataModel,
     DataModelType,
@@ -62,6 +61,9 @@ from metadata.generated.schema.entity.services.dashboardService import (
     DashboardServiceType,
 )
 from metadata.generated.schema.entity.services.databaseService import DatabaseService
+from metadata.generated.schema.entity.services.ingestionPipelines.status import (
+    StackTraceError,
+)
 from metadata.generated.schema.metadataIngestion.workflow import (
     Source as WorkflowSource,
 )
@@ -75,7 +77,7 @@ from metadata.generated.schema.type.entityLineage import EntitiesEdge, LineageDe
 from metadata.generated.schema.type.entityLineage import Source as LineageSource
 from metadata.generated.schema.type.entityReference import EntityReference
 from metadata.generated.schema.type.usageRequest import UsageRequest
-from metadata.ingestion.api.models import Either, StackTraceError
+from metadata.ingestion.api.models import Either
 from metadata.ingestion.api.steps import InvalidSourceException
 from metadata.ingestion.lineage.models import ConnectionTypeDialectMapper
 from metadata.ingestion.lineage.parser import LineageParser
@@ -403,7 +405,7 @@ class LookerSource(DashboardServiceSource):
                     project=model.project_name,
                 )
                 yield Either(right=explore_datamodel)
-                self.register_record_datamodel(datamodel_requst=explore_datamodel)
+                self.register_record_datamodel(datamodel_request=explore_datamodel)
 
                 # build datamodel by our hand since ack_sink=False
                 self.context.dataModel = self._build_data_model(datamodel_name)
@@ -440,7 +442,7 @@ class LookerSource(DashboardServiceSource):
                 left=StackTraceError(
                     name=model.name,
                     error=f"Validation error yielding Data Model [{model.name}]: {err}",
-                    stack_trace=traceback.format_exc(),
+                    stackTrace=traceback.format_exc(),
                 )
             )
         except Exception as err:
@@ -448,7 +450,7 @@ class LookerSource(DashboardServiceSource):
                 left=StackTraceError(
                     name=model.name,
                     error=f"Wild error yielding Data Model [{model.name}]: {err}",
-                    stack_trace=traceback.format_exc(),
+                    stackTrace=traceback.format_exc(),
                 )
             )
 
@@ -504,14 +506,14 @@ class LookerSource(DashboardServiceSource):
                 self._view_data_model = self._build_data_model(
                     build_datamodel_name(explore.model_name, view.name)
                 )
-                self.register_record_datamodel(datamodel_requst=data_model_request)
+                self.register_record_datamodel(datamodel_request=data_model_request)
                 yield from self.add_view_lineage(view, explore)
             else:
                 yield Either(
                     left=StackTraceError(
                         name=view_name,
                         error=f"Cannot find the view [{view_name}]: empty",
-                        stack_trace=traceback.format_exc(),
+                        stackTrace=traceback.format_exc(),
                     )
                 )
 
@@ -579,7 +581,7 @@ class LookerSource(DashboardServiceSource):
                 left=StackTraceError(
                     name=view.name,
                     error=f"Error to yield lineage details for view [{view.name}]: {err}",
-                    stack_trace=traceback.format_exc(),
+                    stackTrace=traceback.format_exc(),
                 )
             )
 
@@ -612,7 +614,7 @@ class LookerSource(DashboardServiceSource):
             dashboard_id=dashboard.id, fields=",".join(GET_DASHBOARD_FIELDS)
         )
 
-    def get_owner_details(
+    def get_owner_ref(
         self, dashboard_details: LookerDashboard
     ) -> Optional[EntityReference]:
         """Get dashboard owner
@@ -630,9 +632,7 @@ class LookerSource(DashboardServiceSource):
         try:
             if dashboard_details.user_id is not None:
                 dashboard_owner = self.client.user(dashboard_details.user_id)
-                user = self.metadata.get_user_by_email(dashboard_owner.email)
-                if user:
-                    return EntityReference(id=user.id.__root__, type="user")
+                return self.metadata.get_reference_by_email(dashboard_owner.email)
 
         except Exception as err:
             logger.debug(traceback.format_exc())
@@ -657,19 +657,19 @@ class LookerSource(DashboardServiceSource):
                     service_name=self.context.dashboard_service,
                     chart_name=chart,
                 )
-                for chart in self.context.charts
+                for chart in self.context.charts or []
             ],
             # Dashboards are created from the UI directly. They are not linked to a project
             # like LookML assets, but rather just organised in folders.
-            project=self._get_dashboard_project(dashboard_details),
+            project=self.get_project_name(dashboard_details),
             sourceUrl=f"{clean_uri(self.service_connection.hostPort)}/dashboards/{dashboard_details.id}",
             service=self.context.dashboard_service,
+            owner=self.get_owner_ref(dashboard_details=dashboard_details),
         )
         yield Either(right=dashboard_request)
         self.register_record(dashboard_request=dashboard_request)
 
-    @staticmethod
-    def _get_dashboard_project(dashboard_details: LookerDashboard) -> Optional[str]:
+    def get_project_name(self, dashboard_details: LookerDashboard) -> Optional[str]:
         """
         Get dashboard project if the folder is informed
         """
@@ -679,7 +679,7 @@ class LookerSource(DashboardServiceSource):
             logger.debug(
                 f"Cannot get folder name from dashboard [{dashboard_details.title}] - [{exc}]"
             )
-            return None
+        return None
 
     @staticmethod
     def _clean_table_name(table_name: str) -> str:
@@ -756,12 +756,12 @@ class LookerSource(DashboardServiceSource):
                 if cached_explore:
                     dashboard_fqn = fqn.build(
                         self.metadata,
-                        entity_type=MetadataDashboard,
+                        entity_type=Dashboard,
                         service_name=self.context.dashboard_service,
                         dashboard_name=self.context.dashboard,
                     )
                     dashboard_entity = self.metadata.get_by_name(
-                        entity=MetadataDashboard, fqn=dashboard_fqn
+                        entity=Dashboard, fqn=dashboard_fqn
                     )
                     yield Either(
                         right=AddLineageRequest(
@@ -786,7 +786,7 @@ class LookerSource(DashboardServiceSource):
                 left=StackTraceError(
                     name=dashboard_entity.displayName,
                     error=f"Unexpected exception yielding lineage from [{dashboard_entity.displayName}]: {exc}",
-                    stack_trace=traceback.format_exc(),
+                    stackTrace=traceback.format_exc(),
                 )
             )
 
@@ -794,7 +794,7 @@ class LookerSource(DashboardServiceSource):
         self,
         source: str,
         db_service_name: str,
-        to_entity: Union[MetadataDashboard, DashboardDataModel],
+        to_entity: Union[Dashboard, DashboardDataModel],
     ) -> Optional[Either[AddLineageRequest]]:
         """
         Once we have a list of origin data sources, check their components
@@ -832,7 +832,6 @@ class LookerSource(DashboardServiceSource):
                     to_entity.id.__root__
                     not in self._added_lineage[from_entity.id.__root__]
                 ):
-
                     self._added_lineage[from_entity.id.__root__].append(
                         to_entity.id.__root__
                     )
@@ -879,7 +878,7 @@ class LookerSource(DashboardServiceSource):
                     left=StackTraceError(
                         name=chart.id,
                         error=f"Error creating chart [{chart}]: {exc}",
-                        stack_trace=traceback.format_exc(),
+                        stackTrace=traceback.format_exc(),
                     )
                 )
 
@@ -939,9 +938,22 @@ class LookerSource(DashboardServiceSource):
         :return: UsageRequest, if not computed
         """
 
-        dashboard: MetadataDashboard = self.context.dashboard
+        dashboard_name = self.context.dashboard
 
         try:
+            dashboard_fqn = fqn.build(
+                metadata=self.metadata,
+                entity_type=Dashboard,
+                service_name=self.context.dashboard_service,
+                dashboard_name=dashboard_name,
+            )
+
+            dashboard: Dashboard = self.metadata.get_by_name(
+                entity=Dashboard,
+                fqn=dashboard_fqn,
+                fields=["usageSummary"],
+            )
+
             current_views = dashboard_details.view_count
 
             if not current_views:
@@ -993,8 +1005,8 @@ class LookerSource(DashboardServiceSource):
         except Exception as exc:
             yield Either(
                 left=StackTraceError(
-                    name=f"{dashboard.name} Usage",
-                    error=f"Exception computing dashboard usage for {dashboard.fullyQualifiedName.__root__}: {exc}",
-                    stack_trace=traceback.format_exc(),
+                    name=f"{dashboard_name} Usage",
+                    error=f"Exception computing dashboard usage for {dashboard_name}: {exc}",
+                    stackTrace=traceback.format_exc(),
                 )
             )

metadata/ingestion/source/dashboard/looker/utils.py

@@ -54,14 +54,16 @@ def _clone_repo(
             return
 
         url = None
+        allow_unsafe_protocols = False
         if isinstance(credential, GitHubCredentials):
             url = f"https://x-oauth-basic:{credential.token.__root__.get_secret_value()}@github.com/{repo_name}.git"
         elif isinstance(credential, BitBucketCredentials):
-            url = f"https://x-token-auth::{credential.token.__root__.get_secret_value()}@bitbucket.or/{repo_name}.git"
+            url = f"https://x-token-auth:{credential.token.__root__.get_secret_value()}@bitbucket.org/{repo_name}.git"
+            allow_unsafe_protocols = True
 
         assert url is not None
 
-        Repo.clone_from(url, path)
+        Repo.clone_from(url, path, allow_unsafe_protocols=allow_unsafe_protocols)
 
         logger.info(f"repo {repo_name} cloned to {path}")
     except Exception as exc:

metadata/ingestion/source/dashboard/metabase/client.py

@@ -124,6 +124,10 @@ class MetabaseClient:
         try:
             resp_dashboard = self.client.get(f"/dashboard/{dashboard_id}")
             if resp_dashboard:
+                # Small hack needed to support Metabase versions older than 0.48
+                # https://www.metabase.com/releases/metabase-48#fyi--breaking-changes
+                if "ordered_cards" in resp_dashboard:
+                    resp_dashboard["dashcards"] = resp_dashboard["ordered_cards"]
                 return MetabaseDashboardDetails(**resp_dashboard)
         except Exception:
             logger.debug(traceback.format_exc())

metadata/ingestion/source/dashboard/metabase/metadata.py

@@ -26,11 +26,16 @@ from metadata.generated.schema.entity.services.connections.dashboard.metabaseCon
 from metadata.generated.schema.entity.services.connections.metadata.openMetadataConnection import (
     OpenMetadataConnection,
 )
+from metadata.generated.schema.entity.services.databaseService import DatabaseService
+from metadata.generated.schema.entity.services.ingestionPipelines.status import (
+    StackTraceError,
+)
 from metadata.generated.schema.metadataIngestion.workflow import (
     Source as WorkflowSource,
 )
-from metadata.ingestion.api.models import Either, StackTraceError
+from metadata.ingestion.api.models import Either
 from metadata.ingestion.api.steps import InvalidSourceException
+from metadata.ingestion.lineage.models import ConnectionTypeDialectMapper
 from metadata.ingestion.lineage.parser import LineageParser
 from metadata.ingestion.lineage.sql_lineage import search_table_entities
 from metadata.ingestion.ometa.ometa_api import OpenMetadata
@@ -147,9 +152,10 @@ class MetabaseSource(DashboardServiceSource):
                         service_name=self.context.dashboard_service,
                         chart_name=chart,
                     )
-                    for chart in self.context.charts
+                    for chart in self.context.charts or []
                 ],
                 service=self.context.dashboard_service,
+                owner=self.get_owner_ref(dashboard_details=dashboard_details),
             )
             yield Either(right=dashboard_request)
             self.register_record(dashboard_request=dashboard_request)
@@ -158,7 +164,7 @@ class MetabaseSource(DashboardServiceSource):
                 left=StackTraceError(
                     name=dashboard_details.name,
                     error=f"Error creating dashboard [{dashboard_details.name}]: {exc}",
-                    stack_trace=traceback.format_exc(),
+                    stackTrace=traceback.format_exc(),
                 )
             )
 
@@ -172,7 +178,7 @@ class MetabaseSource(DashboardServiceSource):
         Returns:
             Iterable[CreateChartRequest]
         """
-        charts = dashboard_details.ordered_cards
+        charts = dashboard_details.dashcards
         for chart in charts:
             try:
                 chart_details = chart.card
@@ -202,7 +208,7 @@ class MetabaseSource(DashboardServiceSource):
                     left=StackTraceError(
                         name="Chart",
                         error=f"Error creating chart [{chart}]: {exc}",
-                        stack_trace=traceback.format_exc(),
+                        stackTrace=traceback.format_exc(),
                     )
                 )
 
@@ -219,7 +225,7 @@ class MetabaseSource(DashboardServiceSource):
         if not db_service_name:
             return
         chart_list, dashboard_name = (
-            dashboard_details.ordered_cards,
+            dashboard_details.dashcards,
             str(dashboard_details.id),
         )
         for chart in chart_list:
@@ -253,10 +259,13 @@ class MetabaseSource(DashboardServiceSource):
                     left=StackTraceError(
                         name="Lineage",
                         error=f"Error adding lineage: {exc}",
-                        stack_trace=traceback.format_exc(),
+                        stackTrace=traceback.format_exc(),
                     )
                 )
 
+    def _get_database_service(self, db_service_name: str):
+        return self.metadata.get_by_name(DatabaseService, db_service_name)
+
     def _yield_lineage_from_query(
         self, chart_details: MetabaseChart, db_service_name: str, dashboard_name: str
     ) -> Iterable[Either[AddLineageRequest]]:
@@ -275,7 +284,15 @@ class MetabaseSource(DashboardServiceSource):
 
         database_name = database.details.db if database and database.details else None
 
-        lineage_parser = LineageParser(query)
+        db_service = self._get_database_service(db_service_name)
+
+        lineage_parser = LineageParser(
+            query,
+            ConnectionTypeDialectMapper.dialect_of(db_service.serviceType.value)
+            if db_service
+            else None,
+        )
+
         for table in lineage_parser.source_tables:
             database_schema_name, table = fqn.split(str(table))[-2:]
             database_schema_name = self.check_database_schema_name(database_schema_name)
@@ -307,8 +324,9 @@ class MetabaseSource(DashboardServiceSource):
         self, chart_details: MetabaseChart, db_service_name: str, dashboard_name: str
     ) -> Iterable[Either[AddLineageRequest]]:
         table = self.client.get_table(chart_details.table_id)
+        table_name = table.name or table.display_name
 
-        if table is None or table.display_name is None:
+        if table is None or table_name is None:
             return
 
         database_name = table.db.details.db if table.db and table.db.details else None
@@ -317,7 +335,7 @@ class MetabaseSource(DashboardServiceSource):
             database=database_name,
             service_name=db_service_name,
             database_schema=table.table_schema,
-            table=table.display_name,
+            table=table_name,
         )
 
         to_fqn = fqn.build(