openedx-learning 0.16.3__py2.py3-none-any.whl → 0.18.0__py2.py3-none-any.whl

openedx_learning/__init__.py

@@ -2,4 +2,4 @@
 Open edX Learning ("Learning Core").
 """
 
-__version__ = "0.16.3"
+__version__ = "0.18.0"

openedx_learning/apps/authoring/components/admin.py

@@ -71,7 +71,6 @@ class ContentInline(admin.TabularInline):
     fields = [
         "key",
         "format_size",
-        "learner_downloadable",
         "rendered_data",
     ]
     readonly_fields = [

openedx_learning/apps/authoring/components/api.py

@@ -215,7 +215,6 @@ def create_next_component_version(
                     content_id=content_pk,
                     component_version=component_version,
                     key=key,
-                    learner_downloadable=False,
                 )
         # Now copy any old associations that existed, as long as they aren't
         # in conflict with the new stuff or marked for deletion.
@@ -227,7 +226,6 @@ def create_next_component_version(
                     content_id=cvrc.content_id,
                     component_version=component_version,
                     key=cvrc.key,
-                    learner_downloadable=cvrc.learner_downloadable,
                 )
 
         return component_version
@@ -422,7 +420,6 @@ def create_component_version_content(
     content_id: int,
     /,
     key: str,
-    learner_downloadable: bool = False,
 ) -> ComponentVersionContent:
     """
     Add a Content to the given ComponentVersion
@@ -445,7 +442,6 @@ def create_component_version_content(
         component_version_id=component_version_id,
         content_id=content_id,
         key=key,
-        learner_downloadable=learner_downloadable,
     )
     return cvrc
 
@@ -453,7 +449,6 @@ def create_component_version_content(
 class AssetError(StrEnum):
     """Error codes related to fetching ComponentVersion assets."""
     ASSET_PATH_NOT_FOUND_FOR_COMPONENT_VERSION = auto()
-    ASSET_NOT_LEARNER_DOWNLOADABLE = auto()
     ASSET_HAS_NO_DOWNLOAD_FILE = auto()
 
 
@@ -484,7 +479,6 @@ def get_redirect_response_for_component_asset(
     component_version_uuid: UUID,
     asset_path: Path,
     public: bool = False,
-    learner_downloadable_only: bool = True,
 ) -> HttpResponse:
     """
     ``HttpResponse`` for a reverse-proxy to serve a ``ComponentVersion`` asset.
@@ -498,11 +492,6 @@ def get_redirect_response_for_component_asset(
         If ``True``, this will return an ``HttpResponse`` that can be cached in
         a CDN and shared across many clients.
 
-    :param learner_downloadable_only: Only return assets that are meant to be
-        downloadable by Learners, i.e. in the LMS experience. If this is
-        ``True``, then requests for assets that are not meant for student
-        download will return a ``404`` error response.
-
     **Response Codes**
 
     If the asset exists for this ``ComponentVersion``, this function will return
@@ -512,15 +501,10 @@ def get_redirect_response_for_component_asset(
     the ``ComponentVersion`` itself does not exist, the response code will be
     ``404``.
 
-    Other than checking the coarse-grained ``learner_downloadable_only`` flag,
-    *this function does not do auth checking of any sort*–it will never return
+    This function does not do auth checking of any sort. It will never return
     a ``401`` or ``403`` response code. That is by design. Figuring out who is
     making the request and whether they have permission to do so is the
-    responsiblity of whatever is calling this function. The
-    ``learner_downloadable_only`` flag is intended to be a filter for the entire
-    view. When it's True, not even staff can download component-internal assets.
-    This is intended to protect us from accidentally allowing sensitive grading
-    code to get leaked out.
+    responsiblity of whatever is calling this function.
 
     **Metadata Headers**
 
@@ -596,24 +580,6 @@ def get_redirect_response_for_component_asset(
         )
         return HttpResponseNotFound(headers=info_headers)
 
-    # Check: If we're asking only for Learner Downloadable assets, and the asset
-    # in question is not supposed to be downloadable by learners, then we give a
-    # 404 error. Even staff members are not expected to be able to download
-    # these assets via the LMS endpoint that serves students. Studio would be
-    # expected to have an entirely different view to serve these assets in that
-    # context (along with different timeouts, auth, and cache settings). So in
-    # that sense, the asset doesn't exist for that particular endpoint.
-    if learner_downloadable_only and (not cv_content.learner_downloadable):
-        logger.error(
-           f"ComponentVersion {component_version_uuid} has asset {asset_path}, "
-           "but it is not meant to be downloadable by learners "
-           "(ComponentVersionContent.learner_downloadable=False)."
-        )
-        info_headers.update(
-            _error_header(AssetError.ASSET_NOT_LEARNER_DOWNLOADABLE)
-        )
-        return HttpResponseNotFound(headers=info_headers)
-
     # At this point, we know that there is valid Content that we want to send.
     # This adds Content-level headers, like the hash/etag and content type.
     info_headers.update(contents_api.get_content_info_headers(content))

openedx_learning/apps/authoring/components/migrations/0003_remove_componentversioncontent_learner_downloadable.py

@@ -0,0 +1,17 @@
+# Generated by Django 4.2.16 on 2024-11-06 17:14
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('oel_components', '0002_alter_componentversioncontent_key'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='componentversioncontent',
+            name='learner_downloadable',
+        ),
+    ]

openedx_learning/apps/authoring/components/models.py

@@ -254,43 +254,6 @@ class ComponentVersionContent(models.Model):
     # identifiers that don't map as cleanly to file paths at some point.
     key = key_field(db_column="_key")
 
-    # Long explanation for the ``learner_downloadable`` field:
-    #
-    # Is this Content downloadable during the learning experience? This is
-    # NOT about public vs. private permissions on course assets, as that will be
-    # a policy that can be changed independently of new versions of the content.
-    # For instance, a course team could decide to flip their course assets from
-    # private to public for CDN caching reasons, and that should not require
-    # new ComponentVersions to be created.
-    #
-    # What the ``learner_downloadable`` field refers to is whether this asset is
-    # supposed to *ever* be directly downloadable by browsers during the
-    # learning experience. This will be True for things like images, PDFs, and
-    # video transcript files. This field will be False for things like:
-    #
-    # * Problem Block OLX will contain the answers to the problem. The XBlock
-    #   runtime and ProblemBlock will use this information to generate HTML and
-    #   grade responses, but the the user's browser is never permitted to
-    #   actually download the raw OLX itself.
-    # * Many courses include a python_lib.zip file holding custom Python code
-    #   to be used by codejail to assess student answers. This code will also
-    #   potentially reveal answers, and is never intended to be downloadable by
-    #   the student's browser.
-    # * Some course teams will upload other file formats that their OLX is
-    #   derived from (e.g. specially formatted LaTeX files). These files will
-    #   likewise contain answers and should never be downloadable by the
-    #   student.
-    # * Other custom metadata may be attached as files in the import, such as
-    #   custom identifiers, author information, etc.
-    #
-    # Even if ``learner_downloadble`` is True, the LMS may decide that this
-    # particular student isn't allowed to see this particular piece of content
-    # yet–e.g. because they are not enrolled, or because the exam this Component
-    # is a part of hasn't started yet. That's a matter of LMS permissions and
-    # policy that is not intrinsic to the content itself, and exists at a layer
-    # above this.
-    learner_downloadable = models.BooleanField(default=False)
-
     class Meta:
         constraints = [
             # Uniqueness is only by ComponentVersion and key. If for some reason

openedx_learning/apps/authoring/publishing/api.py

@@ -50,6 +50,7 @@ __all__ = [
     "soft_delete_draft",
     "reset_drafts_to_published",
     "register_content_models",
+    "filter_publishable_entities",
 ]
 
 
@@ -493,3 +494,22 @@ def register_content_models(
     return PublishableContentModelRegistry.register(
         content_model_cls, content_version_model_cls
     )
+
+
+def filter_publishable_entities(
+    entities: QuerySet[PublishableEntity],
+    has_draft=None,
+    has_published=None
+) -> QuerySet[PublishableEntity]:
+    """
+    Filter an entities query set.
+
+    has_draft: You can filter by entities that has a draft or not.
+    has_published: You can filter by entities that has a published version or not.
+    """
+    if has_draft is not None:
+        entities = entities.filter(draft__version__isnull=not has_draft)
+    if has_published is not None:
+        entities = entities.filter(published__version__isnull=not has_published)
+
+    return entities

openedx_learning/contrib/media_server/views.py

@@ -5,7 +5,7 @@ Views for the media server application
 """
 from pathlib import Path
 
-from django.core.exceptions import ObjectDoesNotExist, PermissionDenied
+from django.core.exceptions import ObjectDoesNotExist
 from django.http import FileResponse, Http404
 
 from openedx_learning.apps.authoring.components.api import look_up_component_version_content
@@ -34,11 +34,6 @@ def component_asset(
     except ObjectDoesNotExist:
         raise Http404("File not found")  # pylint: disable=raise-missing-from
 
-    if not cvc.learner_downloadable and not (
-        request.user and request.user.is_superuser
-    ):
-        raise PermissionDenied("This file is not publicly downloadable.")
-
     response = FileResponse(cvc.raw_content.file, filename=Path(asset_path).name)
     response["Content-Type"] = cvc.raw_content.mime_type
 

{openedx_learning-0.16.3.dist-info → openedx_learning-0.18.0.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: openedx-learning
-Version: 0.16.3
+Version: 0.18.0
 Summary: Open edX Learning Core and Tagging.
 Home-page: https://github.com/openedx/openedx-learning
 Author: David Ormsbee
@@ -18,12 +18,12 @@ Classifier: Programming Language :: Python :: 3.11
 Classifier: Programming Language :: Python :: 3.12
 Requires-Python: >=3.11
 License-File: LICENSE.txt
-Requires-Dist: edx-drf-extensions
-Requires-Dist: Django<5.0
-Requires-Dist: celery
-Requires-Dist: djangorestframework<4.0
 Requires-Dist: attrs
 Requires-Dist: rules<4.0
+Requires-Dist: Django<5.0
+Requires-Dist: djangorestframework<4.0
+Requires-Dist: edx-drf-extensions
+Requires-Dist: celery
 
 Open edX Learning Core (and Tagging)
 ====================================

{openedx_learning-0.16.3.dist-info → openedx_learning-0.18.0.dist-info}/RECORD

@@ -1,4 +1,4 @@
-openedx_learning/__init__.py,sha256=bkrow8r93asdRsP0nSEgewxu6wo1JajZgTv--0P_RKk,69
+openedx_learning/__init__.py,sha256=WQCJfrV8nUpwAaGx2NCUAw0d22YgqZqryjy0wIiV01M,69
 openedx_learning/py.typed,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 openedx_learning/api/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 openedx_learning/api/authoring.py,sha256=vbRpiQ2wOfN3oR2bbN0-bI2ra0QRtha9tVixKW1ENis,929
@@ -17,15 +17,16 @@ openedx_learning/apps/authoring/collections/migrations/0004_collection_key.py,sh
 openedx_learning/apps/authoring/collections/migrations/0005_alter_collection_options_alter_collection_enabled.py,sha256=HdU_3zxN32nzzvOFpiVpQXleHleJhnq2d8k7jAxhUTM,504
 openedx_learning/apps/authoring/collections/migrations/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 openedx_learning/apps/authoring/components/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-openedx_learning/apps/authoring/components/admin.py,sha256=3kFu_PR0BFb8U0zVv3WWhi27i__TDuJG0pFlwr3tKAw,4614
-openedx_learning/apps/authoring/components/api.py,sha256=BhLlEEBzxFNDHA1dBxoNvIFj92t-vaDF44VExWBbWrc,26861
+openedx_learning/apps/authoring/components/admin.py,sha256=zfEpuBEySMYpUZzygaE2MDoI8SH-2H3xIL20YCSCMLo,4582
+openedx_learning/apps/authoring/components/api.py,sha256=Kd8dscUAB5HWX84upmpfK-HjB_1olR7QBP7Ybxn0FVM,24894
 openedx_learning/apps/authoring/components/apps.py,sha256=YoYPsI9gcleA3uEs8CiLIrjUncRMo2DKbYt4mDfzePg,770
-openedx_learning/apps/authoring/components/models.py,sha256=T-wc7vxaWMlulQmMsVH7m6Pd857P3Eguo0vtflTLURI,13415
+openedx_learning/apps/authoring/components/models.py,sha256=VX-pi4ZPJkCP3UtyTcVihgBdBj2pmenwdVC_xx8wCi0,11190
 openedx_learning/apps/authoring/components/management/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 openedx_learning/apps/authoring/components/management/commands/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 openedx_learning/apps/authoring/components/management/commands/add_assets_to_component.py,sha256=0dJ77NZZoNzYheOdFPXtJrjdL_Z-pCNg3l1rbEGnMCY,3175
 openedx_learning/apps/authoring/components/migrations/0001_initial.py,sha256=446LkJSFeK8J_-l-bxakZ_BVx_CiJIllGcBYqWcEenA,4664
 openedx_learning/apps/authoring/components/migrations/0002_alter_componentversioncontent_key.py,sha256=98724dtucRjJCRyLt5p45qXYb2d6-ouVGp7PB6zTG6E,539
+openedx_learning/apps/authoring/components/migrations/0003_remove_componentversioncontent_learner_downloadable.py,sha256=hDAkKdBvKULepML9pVMqkZg31nAyCeszQHJsFJ4qGws,382
 openedx_learning/apps/authoring/components/migrations/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 openedx_learning/apps/authoring/contents/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 openedx_learning/apps/authoring/contents/admin.py,sha256=9Njd_lje1emcd168KBWUTGf0mVJ6K-dMYMcqHNjRU4k,1761
@@ -36,7 +37,7 @@ openedx_learning/apps/authoring/contents/migrations/0001_initial.py,sha256=FtOTm
 openedx_learning/apps/authoring/contents/migrations/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 openedx_learning/apps/authoring/publishing/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 openedx_learning/apps/authoring/publishing/admin.py,sha256=F-0QlVQmuovLIF258XK_vKJdOnn7lLa_0A5veE72TKc,4830
-openedx_learning/apps/authoring/publishing/api.py,sha256=CbJ8bvUGbN879JMX29auLfHeTQ_CotA6n868qglyaPM,16845
+openedx_learning/apps/authoring/publishing/api.py,sha256=dawwRDbqbA_02xtPAwFIukWShrkO6MoQptmEKdAN7uA,17475
 openedx_learning/apps/authoring/publishing/apps.py,sha256=jUfd78xvXaZg3dwkqXihatbeajJGm3Uz1rJpuyd-3g0,402
 openedx_learning/apps/authoring/publishing/model_mixins.py,sha256=DGM6cZSNX4KZHy5xWtNy6yO4bRT04VDus8yZJ4v3vI0,14447
 openedx_learning/apps/authoring/publishing/models.py,sha256=ImMAujPDc2-CECZw_yvVlUOdtGYwmt99TJ2r1HJkkV8,20488
@@ -47,7 +48,7 @@ openedx_learning/contrib/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZ
 openedx_learning/contrib/media_server/__init__.py,sha256=iYijWFCl5RNR9omSu22kMl49EfponoqXBqXr0HMp4QI,56
 openedx_learning/contrib/media_server/apps.py,sha256=FPT0rsUFtPyhFpWKjSI1e_s58wU0IbDyaAW_66V6sY4,816
 openedx_learning/contrib/media_server/urls.py,sha256=newNjV41sM9A9Oy_rgnZSXdkTFxSHiupIiAsVIGE2CE,365
-openedx_learning/contrib/media_server/views.py,sha256=A4umcQr9xU5l-7dCSUX9jP9-gtwf4LGjoMn7NlsdLsk,1547
+openedx_learning/contrib/media_server/views.py,sha256=qZPhdEW_oYj1MEdgLVP6Cq3tRiZtp7dTb7ASaSKZ2HY,1350
 openedx_learning/lib/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 openedx_learning/lib/admin_utils.py,sha256=5z9NrXxmT5j8azx9u1t0AgxV5PIDTc2jPyM5z5yW8cw,4021
 openedx_learning/lib/cache.py,sha256=ppT36KiPLdsAF3GfZCF0IdiHodckd2gLiF1sNhjSJuk,958
@@ -111,8 +112,8 @@ openedx_tagging/core/tagging/rest_api/v1/serializers.py,sha256=D7brBbgmU7MnbU7Ln
 openedx_tagging/core/tagging/rest_api/v1/urls.py,sha256=dNUKCtUCx_YzrwlbEbpDfjGVQbb2QdJ1VuJCkladj6E,752
 openedx_tagging/core/tagging/rest_api/v1/views.py,sha256=LA0EF7-p91JgVrLZpZaG474elKD1dswODGvoPIw47Mg,35837
 openedx_tagging/core/tagging/rest_api/v1/views_import.py,sha256=kbHUPe5A6WaaJ3J1lFIcYCt876ecLNQfd19m7YYub6c,1470
-openedx_learning-0.16.3.dist-info/LICENSE.txt,sha256=QTW2QN7q3XszgUAXm9Dzgtu5LXYKbR1SGnqMa7ufEuY,35139
-openedx_learning-0.16.3.dist-info/METADATA,sha256=DmGqGCSBExCF06ztJhI0YSnT_IFUnbLt__WYV9He0qU,8777
-openedx_learning-0.16.3.dist-info/WHEEL,sha256=TJ49d73sNs10F0aze1W_bTW2P_X7-F4YXOlBqoqA-jY,109
-openedx_learning-0.16.3.dist-info/top_level.txt,sha256=IYFbr5mgiEHd-LOtZmXj3q3a0bkGK1M9LY7GXgnfi4M,33
-openedx_learning-0.16.3.dist-info/RECORD,,
+openedx_learning-0.18.0.dist-info/LICENSE.txt,sha256=QTW2QN7q3XszgUAXm9Dzgtu5LXYKbR1SGnqMa7ufEuY,35139
+openedx_learning-0.18.0.dist-info/METADATA,sha256=0TzunzFQsdhZ0vYpqBy0XCsW02pFP0mACyskAekcA4w,8777
+openedx_learning-0.18.0.dist-info/WHEEL,sha256=OpXWERl2xLPRHTvd2ZXo_iluPEQd8uSbYkJ53NAER_Y,109
+openedx_learning-0.18.0.dist-info/top_level.txt,sha256=IYFbr5mgiEHd-LOtZmXj3q3a0bkGK1M9LY7GXgnfi4M,33
+openedx_learning-0.18.0.dist-info/RECORD,,

{openedx_learning-0.16.3.dist-info → openedx_learning-0.18.0.dist-info}/WHEEL

@@ -1,5 +1,5 @@
 Wheel-Version: 1.0
-Generator: setuptools (75.2.0)
+Generator: setuptools (75.3.0)
 Root-Is-Purelib: true
 Tag: py2-none-any
 Tag: py3-none-any