odxtools 6.6.1__py3-none-any.whl → 9.3.0__py3-none-any.whl

odxtools/cli/compare.py

@@ -3,15 +3,16 @@
 
 import argparse
 import os
-from typing import Any, Dict, List, Optional, Set, Union
+from typing import Any, Dict, List, Optional, Set, Union, cast
 
-from rich import print
-from tabulate import tabulate  # TODO: switch to rich tables
+from rich import print as rich_print
+from rich.padding import Padding as RichPadding
+from rich.table import Table as RichTable
 
 from ..database import Database
-from ..diaglayer import DiagLayer
+from ..diaglayers.diaglayer import DiagLayer
 from ..diagservice import DiagService
-from ..load_file import load_file
+from ..loadfile import load_file
 from ..odxtypes import AtomicOdxType
 from ..parameters.codedconstparameter import CodedConstParameter
 from ..parameters.nrcconstparameter import NrcConstParameter
@@ -19,6 +20,7 @@ from ..parameters.parameter import Parameter
 from ..parameters.physicalconstantparameter import PhysicalConstantParameter
 from ..parameters.valueparameter import ValueParameter
 from . import _parser_utils
+from ._parser_utils import SubparsersList
 from ._print_utils import (extract_service_tabulation_data, print_dl_metrics,
                            print_service_parameters)
 
@@ -45,11 +47,14 @@ class Display:
     # class with variables and functions to display the result of the comparison
 
     # TODO
-    # Idea: results as json export
-    # - write results of comparison in json structure
-    # - use odxlinks to refer to dignostic services / objects if changes have already been detected (e.g. in another ecu variant / diagnostic layer)
-
-    # print all information about parameter properties (request, pos. response & neg. response parameters) for changed diagnostic services
+    # - Idea: results as json export
+    #  - write results of comparison in json structure
+    #  - use odxlinks to refer to dignostic services / objects if
+    #    changes have already been detected (e.g. in another ecu
+    #    variant / diagnostic layer)
+    # - print all information about parameter properties (request,
+    #   pos. response & neg. response parameters) for changed diagnostic
+    #   services
     param_detailed: bool
     obj_detailed: bool
 
@@ -61,56 +66,69 @@ class Display:
         if service_dict["new_services"] or service_dict["deleted_services"] or service_dict[
                 "changed_name_of_service"][0] or service_dict["changed_parameters_of_service"][0]:
             assert isinstance(service_dict["diag_layer"], str)
-            print()
-            print(
+            rich_print()
+            rich_print(
                 f"Changed diagnostic services for diagnostic layer '{service_dict['diag_layer']}' ({service_dict['diag_layer_type']}):"
             )
         if service_dict["new_services"]:
             assert isinstance(service_dict["new_services"], List)
-            print()
-            print(" [blue]New services[/blue]")
-            table = extract_service_tabulation_data(
-                service_dict["new_services"])  # type: ignore[arg-type]
-            print(tabulate(table, headers="keys", tablefmt="presto"))
+            rich_print()
+            rich_print(" [blue]New services[/blue]")
+            rich_print(extract_service_tabulation_data(
+                service_dict["new_services"]))  # type: ignore[arg-type]
         if service_dict["deleted_services"]:
             assert isinstance(service_dict["deleted_services"], List)
-            print()
-            print(" [blue]Deleted services[/blue]")
-            table = extract_service_tabulation_data(
-                service_dict["deleted_services"])  # type: ignore[arg-type]
-            print(tabulate(table, headers="keys", tablefmt="presto"))
+            rich_print()
+            rich_print(" [blue]Deleted services[/blue]")
+            rich_print(extract_service_tabulation_data(
+                service_dict["deleted_services"]))  # type: ignore[arg-type]
         if service_dict["changed_name_of_service"][0]:
-            print()
-            print(" [blue]Renamed services[/blue]")
-            table = extract_service_tabulation_data(
-                service_dict["changed_name_of_service"][0])  # type: ignore[arg-type]
-            table["Old service name"] = service_dict["changed_name_of_service"][1]
-            print(tabulate(table, headers="keys", tablefmt="presto"))
+            rich_print()
+            rich_print(" [blue]Renamed services[/blue]")
+            rich_print(extract_service_tabulation_data(
+                service_dict["changed_name_of_service"][0]))  # type: ignore[arg-type]
         if service_dict["changed_parameters_of_service"][0]:
-            print()
-            print(" [blue]Services with parameter changes[/blue]")
+            rich_print()
+            rich_print(" [blue]Services with parameter changes[/blue]")
             # create table with information about services with parameter changes
+            changed_param_column = [
+                str(x) for x in service_dict["changed_parameters_of_service"][
+                    1]  # type: ignore[union-attr]
+            ]
             table = extract_service_tabulation_data(
-                service_dict["changed_parameters_of_service"][0])  # type: ignore[arg-type]
-            # add information about changed parameters
-            table["Changed parameters"] = service_dict["changed_parameters_of_service"][1]
-            print(tabulate(table, headers="keys", tablefmt="presto"))
+                service_dict["changed_parameters_of_service"][0],  # type: ignore[arg-type]
+                additional_columns=[("Changed Parameters", changed_param_column)])
+            rich_print(table)
 
             for service_idx, service in enumerate(
                     service_dict["changed_parameters_of_service"][0]):  # type: ignore[arg-type]
                 assert isinstance(service, DiagService)
-                print()
-                print(
+                rich_print()
+                rich_print(
                     f"  Detailed changes of diagnostic service [u cyan]{service.short_name}[/u cyan]"
                 )
                 #   detailed_info in [infotext1, dict1, infotext2, dict2, ...]
-                for detailed_info in service_dict["changed_parameters_of_service"][2][
-                        service_idx]:  # type: ignore[arg-type, index, union-attr]
+                info_list = cast(
+                    list,  # type: ignore[type-arg]
+                    service_dict["changed_parameters_of_service"])[2][service_idx]
+                for detailed_info in info_list:
                     if isinstance(detailed_info, str):
-                        print()
-                        print(detailed_info)
+                        rich_print()
+                        rich_print(detailed_info)
                     elif isinstance(detailed_info, dict):
-                        print(tabulate(detailed_info, headers="keys", tablefmt="presto"))
+                        table = RichTable(
+                            show_header=True,
+                            header_style="bold cyan",
+                            border_style="blue",
+                            show_lines=True)
+                        for header in detailed_info:
+                            table.add_column(header)
+                        rows = zip(*detailed_info.values())
+                        for row in rows:
+                            table.add_row(*map(str, row))
+
+                        rich_print(RichPadding(table, pad=(0, 0, 0, 4)))
+                        rich_print()
                 if self.param_detailed:
                     # print all parameter details of diagnostic service
                     print_service_parameters(service, allow_unknown_bit_lengths=True)
@@ -121,16 +139,18 @@ class Display:
         # diagnostic layers
         if changes_variants["new_diagnostic_layers"] or changes_variants[
                 "deleted_diagnostic_layers"]:
-            print()
-            print("[bright_blue]Changed diagnostic layers[/bright_blue]: ")
-            print(" New diagnostic layers: ")
+            rich_print()
+            rich_print("[bright_blue]Changed diagnostic layers[/bright_blue]: ")
+            rich_print(" New diagnostic layers: ")
             for variant in changes_variants["new_diagnostic_layers"]:
                 assert isinstance(variant, DiagLayer)
-                print(f"  [magenta]{variant.short_name}[/magenta] ({variant.variant_type.value})")
-            print(" Deleted diagnostic layers: ")
+                rich_print(
+                    f"  [magenta]{variant.short_name}[/magenta] ({variant.variant_type.value})")
+            rich_print(" Deleted diagnostic layers: ")
             for variant in changes_variants["deleted_diagnostic_layers"]:
                 assert isinstance(variant, DiagLayer)
-                print(f"  [magenta]{variant.short_name}[/magenta] ({variant.variant_type.value})")
+                rich_print(
+                    f"  [magenta]{variant.short_name}[/magenta] ({variant.variant_type.value})")
 
         # diagnostic services
         for _, value in changes_variants.items():
@@ -256,7 +276,8 @@ class Comparison(Display):
 
         return {"Property": property, "Old Value": old, "New Value": new}
 
-    def compare_services(self, service1: DiagService, service2: DiagService) -> list:
+    def compare_services(self, service1: DiagService,
+                         service2: DiagService) -> List[SpecsServiceDict]:
         # compares request, positive response and negative response parameters of two diagnostic services
 
         information: List[Union[str, Dict[str, Any]]] = [
@@ -271,8 +292,8 @@ class Comparison(Display):
                     if res1_idx == res2_idx:
                         # find changed request parameter properties
                         table = self.compare_parameters(param1, param2)
-                        infotext = (f"   Properties of request parameter '{param2.short_name}'"
-                                    f" have changed\n")
+                        infotext = (f"   Properties of request parameter '{param2.short_name}' "
+                                    f"that have changed:\n")
                         # array index starts with 0 -> param[0] is 1. service parameter
 
                         if table["Property"]:
@@ -307,8 +328,8 @@ class Comparison(Display):
                                         # find changed positive response parameter properties
                                         table = self.compare_parameters(param1, param2)
                                         infotext = (
-                                            f"   Properties of positive response parameter '{param2.short_name}'"
-                                            f"have changed\n")
+                                            f"   Properties of positive response parameter '{param2.short_name}' that "
+                                            f"have changed:\n")
                                         # array index starts with 0 -> param[0] is first service parameter
 
                                         if table["Property"]:
@@ -350,7 +371,7 @@ class Comparison(Display):
                                     if param1_idx == param2_idx:
                                         # find changed negative response parameter properties
                                         table = self.compare_parameters(param1, param2)
-                                        infotext = f"   Properties of response parameter '{param2.short_name}' have changed\n"
+                                        infotext = f"   Properties of response parameter '{param2.short_name}' that have changed:\n"
                                         # array index starts with 0 -> param[0] is 1. service parameter
 
                                         if table["Property"]:
@@ -382,9 +403,10 @@ class Comparison(Display):
                            str(service2.negative_responses)]
             })
 
-        return [information, changed_params]
+        return [information, changed_params]  # type: ignore[list-item]
 
-    def compare_diagnostic_layers(self, dl1: DiagLayer, dl2: DiagLayer) -> dict:
+    def compare_diagnostic_layers(self, dl1: DiagLayer,
+                                  dl2: DiagLayer) -> dict:  # type: ignore[type-arg]
         # compares diagnostic services of two diagnostic layers with each other
         # save changes in dictionary (service_dict)
         # TODO: add comparison of SingleECUJobs
@@ -467,21 +489,23 @@ class Comparison(Display):
                         # add parameters which have been changed (type: String)
                         service_dict["changed_parameters_of_service"][
                             1].append(  # type: ignore[union-attr]
-                                detailed_information[1])
+                                detailed_information[1])  # type: ignore[arg-type]
                         # add detailed information about changed service parameters (type: list) [infotext1, table1, infotext2, table2, ...]
                         service_dict["changed_parameters_of_service"][
                             2].append(  # type: ignore[union-attr]
-                                detailed_information[0])
+                                detailed_information[0])  # type: ignore[arg-type]
 
             for service2_idx, service2 in enumerate(dl2.services):
 
                 # check for deleted diagnostic services
                 if service2.short_name not in dl1_service_names and dl2_request_prefixes[
-                        service2_idx] not in dl1_request_prefixes and service2 not in service_dict[
-                            "deleted_services"]:
+                        service2_idx] not in dl1_request_prefixes:
 
-                    service_dict["deleted_services"].append(  # type: ignore[union-attr]
-                        service2)  # type: ignore[arg-type]
+                    deleted_list = service_dict["deleted_services"]
+                    assert isinstance(deleted_list, list)
+                    if service2 not in deleted_list:
+                        service_dict["deleted_services"].append(  # type: ignore[union-attr]
+                            service2)  # type: ignore[arg-type]
 
                 if service1.short_name == service2.short_name:
                     # compare request, pos. response and neg. response parameters of both diagnostic services
@@ -496,13 +520,14 @@ class Comparison(Display):
                                 service1)
                         # add parameters which have been changed (type: String)
                         service_dict["changed_parameters_of_service"][  # type: ignore[union-attr]
-                            1].append(detailed_information[1])
+                            1].append(detailed_information[1])  # type: ignore[arg-type]
                         # add detailed information about changed service parameters (type: list) [infotext1, table1, infotext2, table2, ...]
                         service_dict["changed_parameters_of_service"][  # type: ignore[union-attr]
-                            2].append(detailed_information[0])
+                            2].append(detailed_information[0])  # type: ignore[arg-type]
         return service_dict
 
-    def compare_databases(self, database_new: Database, database_old: Database) -> dict:
+    def compare_databases(self, database_new: Database,
+                          database_old: Database) -> dict:  # type: ignore[type-arg]
         # compares two PDX-files with each other
 
         new_variants: NewVariants = []
@@ -539,7 +564,7 @@ class Comparison(Display):
         return changes_variants
 
 
-def add_subparser(subparsers: "argparse._SubParsersAction") -> None:
+def add_subparser(subparsers: SubparsersList) -> None:
     parser = subparsers.add_parser(
         "compare",
         description="\n".join([
@@ -614,7 +639,7 @@ def run(args: argparse.Namespace) -> None:
 
         for name in args.variants:
             if name not in task.diagnostic_layer_names:
-                print(f"The variant '{name}' could not be found!")
+                rich_print(f"The variant '{name}' could not be found!")
                 return
 
         task.db_indicator_1 = 0
@@ -624,19 +649,20 @@ def run(args: argparse.Namespace) -> None:
                 break
             task.db_indicator_2 = db_idx + 1
 
-            print()
-            print(f"Changes in file '{os.path.basename(db_names[0])}'")
-            print(f" (compared to '{os.path.basename(db_names[db_idx + 1])}')")
+            rich_print()
+            rich_print(f"Changes in file '{os.path.basename(db_names[0])}'")
+            rich_print(f" (compared to '{os.path.basename(db_names[db_idx + 1])}')")
 
-            print()
-            print(f"Overview of diagnostic layers (for {os.path.basename(db_names[0])})")
+            rich_print()
+            rich_print(f"Overview of diagnostic layers (for {os.path.basename(db_names[0])})")
             print_dl_metrics([
                 variant for variant in task.databases[0].diag_layers
                 if variant.short_name in task.diagnostic_layer_names
             ])
 
-            print()
-            print(f"Overview of diagnostic layers (for {os.path.basename(db_names[db_idx+1])})")
+            rich_print()
+            rich_print(
+                f"Overview of diagnostic layers (for {os.path.basename(db_names[db_idx+1])})")
             print_dl_metrics([
                 variant for variant in task.databases[db_idx + 1].diag_layers
                 if variant.short_name in task.diagnostic_layer_names
@@ -665,16 +691,17 @@ def run(args: argparse.Namespace) -> None:
                 break
             task.db_indicator_2 = db_idx + 1
 
-            print()
-            print(f"Changes in file '{os.path.basename(db_names[0])}")
-            print(f" (compared to '{os.path.basename(db_names[db_idx + 1])}')")
+            rich_print()
+            rich_print(f"Changes in file '{os.path.basename(db_names[0])}")
+            rich_print(f" (compared to '{os.path.basename(db_names[db_idx + 1])}')")
 
-            print()
-            print(f"Overview of diagnostic layers (for {os.path.basename(db_names[0])})")
+            rich_print()
+            rich_print(f"Overview of diagnostic layers (for {os.path.basename(db_names[0])})")
             print_dl_metrics(list(task.databases[0].diag_layers))
 
-            print()
-            print(f"Overview of diagnostic layers (for {os.path.basename(db_names[db_idx+1])})")
+            rich_print()
+            rich_print(
+                f"Overview of diagnostic layers (for {os.path.basename(db_names[db_idx+1])})")
             print_dl_metrics(list(task.databases[db_idx + 1].diag_layers))
 
             task.print_database_changes(
@@ -696,20 +723,20 @@ def run(args: argparse.Namespace) -> None:
 
         for name in args.variants:
             if name not in task.diagnostic_layer_names:
-                print(f"The variant '{name}' could not be found!")
+                rich_print(f"The variant '{name}' could not be found!")
                 return
 
-        print()
-        print(f"Overview of diagnostic layers: ")
+        rich_print()
+        rich_print(f"Overview of diagnostic layers: ")
         print_dl_metrics(task.diagnostic_layers)
 
         for db_idx, dl in enumerate(task.diagnostic_layers):
             if db_idx + 1 >= len(task.diagnostic_layers):
                 break
 
-            print()
-            print(f"Changes in diagnostic layer '{dl.short_name}' ({dl.variant_type.value})")
-            print(
+            rich_print()
+            rich_print(f"Changes in diagnostic layer '{dl.short_name}' ({dl.variant_type.value})")
+            rich_print(
                 f" (compared to '{task.diagnostic_layers[db_idx + 1].short_name}' ({task.diagnostic_layers[db_idx + 1].variant_type.value}))"
             )
             task.print_dl_changes(
@@ -717,4 +744,4 @@ def run(args: argparse.Namespace) -> None:
 
     else:
         # no databases & no variants specified
-        print("Please specify either a database or variant for a comparison")
+        rich_print("Please specify either a database or variant for a comparison")

odxtools/cli/decode.py

@@ -9,6 +9,7 @@ from ..exceptions import odxraise
 from ..odxtypes import ParameterValue
 from ..singleecujob import SingleEcuJob
 from . import _parser_utils
+from ._parser_utils import SubparsersList
 
 # name of the tool
 _odxtools_tool_name_ = "decode"
@@ -70,7 +71,7 @@ def print_summary(
                 print(f"  {param_name}={get_display_value(param_value)}")
 
 
-def add_subparser(subparsers: "argparse._SubParsersAction") -> None:
+def add_subparser(subparsers: SubparsersList) -> None:
     parser = subparsers.add_parser(
         "decode",
         description="\n".join([

odxtools/cli/dummy_sub_parser.py

@@ -4,6 +4,8 @@ import sys
 import traceback
 from io import StringIO
 
+from ._parser_utils import SubparsersList
+
 
 class DummyTool:
     """A tool which acts as a placeholder for a "real" tool that
@@ -20,7 +22,7 @@ class DummyTool:
         self._odxtools_tool_name_ = tool_name
         self._error = error
 
-    def add_subparser(self, subparser_list: "argparse._SubParsersAction") -> None:
+    def add_subparser(self, subparser_list: SubparsersList) -> None:
         desc = StringIO()
 
         print(f"Tool '{self._odxtools_tool_name_}' is unavailable: {self._error}", file=desc)

odxtools/cli/find.py

@@ -7,6 +7,7 @@ from ..diagservice import DiagService
 from ..odxtypes import ParameterValue
 from ..singleecujob import SingleEcuJob
 from . import _parser_utils
+from ._parser_utils import SubparsersList
 from ._print_utils import print_diagnostic_service
 
 # name of the tool
@@ -66,7 +67,7 @@ def print_summary(odxdb: Database,
             print(f"Unknown service: {service}")
 
 
-def add_subparser(subparsers: "argparse._SubParsersAction") -> None:
+def add_subparser(subparsers: SubparsersList) -> None:
     parser = subparsers.add_parser(
         "find",
         description="\n".join([

odxtools/cli/list.py

@@ -4,12 +4,18 @@ from typing import Callable, List, Optional
 
 import rich
 
+from ..comparaminstance import ComparamInstance
 from ..database import Database
+from ..dataobjectproperty import DataObjectProperty
 from ..diagcomm import DiagComm
-from ..diaglayer import DiagLayer
+from ..diaglayers.basevariant import BaseVariant
+from ..diaglayers.diaglayer import DiagLayer
+from ..diaglayers.ecuvariant import EcuVariant
+from ..diaglayers.hierarchyelement import HierarchyElement
 from ..diagservice import DiagService
 from ..singleecujob import SingleEcuJob
 from . import _parser_utils
+from ._parser_utils import SubparsersList
 from ._print_utils import format_desc, print_diagnostic_service, print_dl_metrics
 
 # name of the tool
@@ -46,7 +52,7 @@ def print_summary(odxdb: Database,
     if diag_layers:
         rich.print("\n")
         rich.print(f"Overview of diagnostic layers: ")
-        print_dl_metrics(diag_layers, print_fn=rich.print)
+        print_dl_metrics(diag_layers)
 
     for dl in diag_layers:
         rich.print("\n")
@@ -55,15 +61,14 @@ def print_summary(odxdb: Database,
 
         all_services: List[DiagComm] = sorted(dl.services, key=lambda x: x.short_name)
 
-        data_object_properties = dl.diag_data_dictionary_spec.data_object_props
-        comparams = dl.comparams
+        if isinstance(dl, (BaseVariant, EcuVariant)):
+            for proto in dl.protocols:
+                if (can_rx_id := dl.get_can_receive_id(proto.short_name)) is not None:
+                    rich.print(
+                        f"  CAN receive ID for protocol '{proto.short_name}': 0x{can_rx_id:x}")
 
-        for proto in dl.protocols:
-            if (can_rx_id := dl.get_can_receive_id(proto.short_name)) is not None:
-                rich.print(f"  CAN receive ID for protocol '{proto.short_name}': 0x{can_rx_id:x}")
-
-            if (can_tx_id := dl.get_can_send_id(proto.short_name)) is not None:
-                rich.print(f"  CAN send ID for protocol '{proto.short_name}': 0x{can_tx_id:x}")
+                if (can_tx_id := dl.get_can_send_id(proto.short_name)) is not None:
+                    rich.print(f"  CAN send ID for protocol '{proto.short_name}': 0x{can_tx_id:x}")
 
         if dl.description:
             desc = format_desc(dl.description, indent=2)
@@ -88,13 +93,14 @@ def print_summary(odxdb: Database,
                             print_pre_condition_states=print_pre_condition_states,
                             print_state_transitions=print_state_transitions,
                             print_audiences=print_audiences,
-                            allow_unknown_bit_lengths=allow_unknown_bit_lengths,
-                            print_fn=rich.print)
+                            allow_unknown_bit_lengths=allow_unknown_bit_lengths)
                     elif isinstance(service, SingleEcuJob):
                         rich.print(f" Single ECU job: {service.odx_id}")
                     else:
                         rich.print(f" Unidentifiable service: {service}")
-
+        ddd_spec = dl.diag_data_dictionary_spec
+        data_object_properties: List[
+            DataObjectProperty] = [] if ddd_spec is None else ddd_spec.data_object_props
         if print_dops and len(data_object_properties) > 0:
             rich.print("\n")
             rich.print(f"The DOPs of the {dl.variant_type.value} '{dl.short_name}' are: ")
@@ -102,16 +108,20 @@ def print_summary(odxdb: Database,
                     data_object_properties, key=lambda x: (type(x).__name__, x.short_name)):
                 rich.print("  " + str(dop.short_name).replace("\n", "\n  "))
 
-        if print_comparams and len(comparams) > 0:
+        comparam_refs: List[ComparamInstance] = []
+        if isinstance(dl, HierarchyElement):
+            comparam_refs = dl.comparam_refs
+
+        if print_comparams and len(comparam_refs) > 0:
             rich.print("\n")
             rich.print(
                 f"The communication parameters of the {dl.variant_type.value} '{dl.short_name}' are: "
             )
-            for com_param in comparams:
+            for com_param in comparam_refs:
                 rich.print(f"  {com_param.short_name}: {com_param.value}")
 
 
-def add_subparser(subparsers: "argparse._SubParsersAction") -> None:
+def add_subparser(subparsers: SubparsersList) -> None:
     parser = subparsers.add_parser(
         "list",
         description="\n".join([

odxtools/cli/main.py

@@ -4,6 +4,7 @@ import importlib
 from typing import Any, List
 
 import odxtools
+import odxtools.exceptions
 
 from ..version import __version__ as odxtools_version
 from .dummy_sub_parser import DummyTool

odxtools/cli/snoop.py

@@ -4,17 +4,19 @@
 import argparse
 import asyncio
 import sys
-from typing import Any, Type
+from typing import Any, List, Optional, Type
 
 import can
 
 import odxtools.isotp_state_machine as ism
 import odxtools.uds as uds
+from odxtools.diaglayers.protocol import Protocol
 from odxtools.exceptions import DecodeError
 from odxtools.isotp_state_machine import IsoTpStateMachine
 from odxtools.response import Response, ResponseType
 
 from . import _parser_utils
+from ._parser_utils import SubparsersList
 
 # name of the tool
 _odxtools_tool_name_ = "snoop"
@@ -30,6 +32,8 @@ def handle_telegram(telegram_id: int, payload: bytes) -> None:
     global odx_diag_layer
     global last_request
 
+    assert odx_diag_layer is not None
+
     if telegram_id == ecu_tx_id:
         if uds.is_response_pending(payload):
             print(f" ... (response pending)")
@@ -209,7 +213,7 @@ def add_cli_arguments(parser: argparse.ArgumentParser) -> None:
     _parser_utils.add_pdx_argument(parser)
 
 
-def add_subparser(subparsers: "argparse._SubParsersAction") -> None:
+def add_subparser(subparsers: SubparsersList) -> None:
     parser = subparsers.add_parser(
         "snoop",
         description="Live decoding of a diagnostic session.",
@@ -242,21 +246,43 @@ def run(args: argparse.Namespace) -> None:
 
     protocol_name = args.protocol
     if odx_diag_layer is not None and protocol_name is not None:
-        protocol_names = [x.short_name for x in odx_diag_layer.protocols]
+        protocols: Optional[List[Protocol]] = getattr(odx_diag_layer, "protocols", None)
+
+        if protocols is None:
+            print(f"ECU variant {odx_diag_layer.short_name} is of type "
+                  f"{odx_diag_layer.variant_type.value} and thus does not "
+                  f"feature any protocols")
+            sys.exit(1)
+
+        protocol_names = [x.short_name for x in protocols]
         if protocol_name not in protocol_names:
             print(f"ECU variant {odx_diag_layer.short_name} does not support "
                   f"a protocol named '{protocol_name}'. Supported protocols are:")
-            for x in odx_diag_layer.protocols:
+            for x in protocols:
                 desc = "" if x.description is None else f": {x.description}"
                 print(f"  {x.short_name}{desc}")
             sys.exit(1)
 
     # if no can IDs have been explicitly specified, take them from the DL
     if args.rx is None and odx_diag_layer:
-        args.rx = str(odx_diag_layer.get_can_receive_id(protocol=protocol_name))
+        get_can_rx_id = getattr(odx_diag_layer, "get_can_receive_id", None)
+        if get_can_rx_id is None:
+            print(f"ECU variant {odx_diag_layer.short_name} is of type "
+                  f"{odx_diag_layer.variant_type.value} and thus does not "
+                  f"provide any communication parameters")
+            sys.exit(1)
+
+        args.rx = str(get_can_rx_id(protocol=protocol_name))
 
     if args.tx is None and odx_diag_layer:
-        args.tx = str(odx_diag_layer.get_can_send_id(protocol=protocol_name))
+        get_can_tx_id = getattr(odx_diag_layer, "get_can_send_id", None)
+        if get_can_tx_id is None:
+            print(f"ECU variant {odx_diag_layer.short_name} is of type "
+                  f"{odx_diag_layer.variant_type.value} and thus does not "
+                  f"provide any communication parameters")
+            sys.exit(1)
+
+        args.tx = str(get_can_tx_id(protocol=protocol_name))
 
     if args.rx is None:
         print(f"Could not determine a CAN receive ID.")