odoo-addon-stock-request 15.0.1.7.0.1__py3-none-any.whl → 16.0.1.0.0.3__py3-none-any.whl

odoo/addons/stock_request/tests/test_stock_request.py

@@ -1,137 +1,136 @@
 # Copyright 2017 ForgeFlow S.L.
-# Copyright 2022-2023 Tecnativa - Víctor Martínez
 # License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl-3.0).
-
 from collections import Counter
 from datetime import datetime
 
 from odoo import exceptions, fields
-from odoo.tests import common, new_test_user
-
-
-class TestStockRequest(common.TransactionCase):
-    def setUp(self):
-        super().setUp()
-        self.env = self.env(
-            context=dict(
-                self.env.context,
-                mail_create_nolog=True,
-                mail_create_nosubscribe=True,
-                mail_notrack=True,
-                no_reset_password=True,
-                tracking_disable=True,
-            )
-        )
+from odoo.tests import new_test_user
+
+from odoo.addons.base.tests.common import BaseCommon
+
+
+class TestStockRequest(BaseCommon):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+
         # common models
-        self.stock_request = self.env["stock.request"]
-        self.request_order = self.env["stock.request.order"]
+        cls.stock_request = cls.env["stock.request"]
+        cls.request_order = cls.env["stock.request.order"]
+
         # refs
-        self.stock_request_user_group = self.env.ref(
+        cls.stock_request_user_group = cls.env.ref(
             "stock_request.group_stock_request_user"
         )
-        self.main_company = self.env.ref("base.main_company")
-        self.warehouse = self.env.ref("stock.warehouse0")
-        self.categ_unit = self.env.ref("uom.product_uom_categ_unit")
-        self.virtual_loc = self.env.ref("stock.stock_location_customers")
+        cls.main_company = cls.env.ref("base.main_company")
+        cls.warehouse = cls.env.ref("stock.warehouse0")
+        cls.categ_unit = cls.env.ref("uom.product_uom_categ_unit")
+        cls.virtual_loc = cls.env.ref("stock.stock_location_customers")
+
         # common data
-        self.company_2 = self.env["res.company"].create(
-            {"name": "Comp2", "parent_id": self.main_company.id}
+        cls.company_2 = cls.env["res.company"].create(
+            {"name": "Comp2", "parent_id": cls.main_company.id}
         )
-        self.company_2_address = (
-            self.env["res.partner"]
-            .with_context(company_id=self.company_2.id)
+        cls.company_2_address = (
+            cls.env["res.partner"]
+            .with_context(company_id=cls.company_2.id)
             .create({"name": "Peñiscola"})
         )
-        self.wh2 = self.env["stock.warehouse"].search(
-            [("company_id", "=", self.company_2.id)], limit=1
+        cls.wh = cls.env["stock.warehouse"].search(
+            [("company_id", "=", cls.main_company.id)], limit=1
         )
-        self.stock_request_user = new_test_user(
-            self.env,
+        cls.wh2 = cls.env["stock.warehouse"].search(
+            [("company_id", "=", cls.company_2.id)], limit=1
+        )
+        cls.stock_request_user = new_test_user(
+            cls.env,
             login="stock_request_user",
             groups="stock_request.group_stock_request_user",
-            company_ids=[(6, 0, [self.main_company.id, self.company_2.id])],
+            company_ids=[(4, cls.main_company.id), (4, cls.company_2.id)],
         )
-        self.stock_request_manager = new_test_user(
-            self.env,
+        cls.stock_request_manager = new_test_user(
+            cls.env,
             login="stock_request_manager",
             groups="stock_request.group_stock_request_manager",
-            company_ids=[(6, 0, [self.main_company.id, self.company_2.id])],
-        )
-        self.product = self._create_product("SH", "Shoes", False)
-        self.product_company_2 = self._create_product(
-            "SH_2", "Shoes", self.company_2.id
+            company_ids=[(4, cls.main_company.id), (4, cls.company_2.id)],
         )
-        self.ressuply_loc = self._create_location(
+        cls.product = cls._create_product("SH", "Shoes", False)
+        cls.product_company_2 = cls._create_product("SH_2", "Shoes", cls.company_2.id)
+
+        cls.ressuply_loc = cls._create_location(
             name="Ressuply",
-            location_id=self.warehouse.view_location_id.id,
-            company_id=self.main_company.id,
+            location_id=cls.warehouse.view_location_id.id,
+            company_id=cls.main_company.id,
         )
-        self.ressuply_loc_2 = self._create_location(
+        cls.ressuply_loc_2 = cls._create_location(
             name="Ressuply",
-            location_id=self.wh2.view_location_id.id,
-            company_id=self.company_2.id,
-        )
-        self.route = self._create_location_route(
-            name="Transfer", company_id=self.main_company.id
-        )
-        self.route_2 = self._create_location_route(
-            name="Transfer", company_id=self.company_2.id
+            location_id=cls.wh2.view_location_id.id,
+            company_id=cls.company_2.id,
         )
-        self.uom_dozen = self.env["uom.uom"].create(
+
+        cls.route = cls._create_route(name="Transfer", company_id=cls.main_company.id)
+        cls.route_2 = cls._create_route(name="Transfer", company_id=cls.company_2.id)
+
+        cls.uom_dozen = cls.env["uom.uom"].create(
             {
                 "name": "Test-DozenA",
-                "category_id": self.categ_unit.id,
+                "category_id": cls.categ_unit.id,
                 "factor_inv": 12,
                 "uom_type": "bigger",
                 "rounding": 0.001,
             }
         )
-        self.env["stock.rule"].create(
+
+        cls.env["stock.rule"].create(
             {
                 "name": "Transfer",
-                "route_id": self.route.id,
-                "location_src_id": self.ressuply_loc.id,
-                "location_id": self.warehouse.lot_stock_id.id,
+                "route_id": cls.route.id,
+                "location_src_id": cls.ressuply_loc.id,
+                "location_dest_id": cls.warehouse.lot_stock_id.id,
                 "action": "pull",
-                "picking_type_id": self.warehouse.int_type_id.id,
+                "picking_type_id": cls.warehouse.int_type_id.id,
                 "procure_method": "make_to_stock",
-                "warehouse_id": self.warehouse.id,
-                "company_id": self.main_company.id,
+                "warehouse_id": cls.warehouse.id,
+                "company_id": cls.main_company.id,
             }
         )
-        self.env["stock.rule"].create(
+
+        cls.env["stock.rule"].create(
             {
                 "name": "Transfer",
-                "route_id": self.route_2.id,
-                "location_src_id": self.ressuply_loc_2.id,
-                "location_id": self.wh2.lot_stock_id.id,
+                "route_id": cls.route_2.id,
+                "location_src_id": cls.ressuply_loc_2.id,
+                "location_dest_id": cls.wh2.lot_stock_id.id,
                 "action": "pull",
-                "picking_type_id": self.wh2.int_type_id.id,
+                "picking_type_id": cls.wh2.int_type_id.id,
                 "procure_method": "make_to_stock",
-                "warehouse_id": self.wh2.id,
-                "company_id": self.company_2.id,
+                "warehouse_id": cls.wh2.id,
+                "company_id": cls.company_2.id,
             }
         )
-        self.env["ir.config_parameter"].sudo().set_param(
+
+        cls.env["ir.config_parameter"].sudo().set_param(
             "stock.no_auto_scheduler", "True"
         )
 
-    def _create_product(self, default_code, name, company_id, **vals):
-        return self.env["product.product"].create(
+    @classmethod
+    def _create_product(cls, default_code, name, company_id, **vals):
+        return cls.env["product.product"].create(
             dict(
                 name=name,
                 default_code=default_code,
-                uom_id=self.env.ref("uom.product_uom_unit").id,
+                uom_id=cls.env.ref("uom.product_uom_unit").id,
                 company_id=company_id,
                 type="product",
                 **vals
             )
         )
 
+    @classmethod
     def _create_product_template_attribute_line(
-        self, product_tmpl_id, attribute_id, value_id
+        cls, product_tmpl_id, attribute_id, value_id
     ):
-        return self.env["product.template.attribute.line"].create(
+        return cls.env["product.template.attribute.line"].create(
             {
                 "product_tmpl_id": product_tmpl_id,
                 "attribute_id": attribute_id,
@@ -139,19 +138,23 @@ class TestStockRequest(common.TransactionCase):
             }
         )
 
-    def _create_product_attribute_value(self, name, attribute):
-        return self.env["product.attribute.value"].create(
+    @classmethod
+    def _create_product_attribute_value(cls, name, attribute):
+        return cls.env["product.attribute.value"].create(
             {"name": name, "attribute_id": attribute}
         )
 
-    def _create_product_attribute(self, name):
-        return self.env["product.attribute"].create({"name": name})
+    @classmethod
+    def _create_product_attribute(cls, name):
+        return cls.env["product.attribute"].create({"name": name})
 
-    def _create_location(self, **vals):
-        return self.env["stock.location"].create(dict(usage="internal", **vals))
+    @classmethod
+    def _create_location(cls, **vals):
+        return cls.env["stock.location"].create(dict(usage="internal", **vals))
 
-    def _create_location_route(self, **vals):
-        return self.env["stock.location.route"].create(
+    @classmethod
+    def _create_route(cls, **vals):
+        return cls.env["stock.route"].create(
             dict(
                 product_categ_selectable=False,
                 product_selectable=True,
@@ -162,9 +165,6 @@ class TestStockRequest(common.TransactionCase):
 
 
 class TestStockRequestBase(TestStockRequest):
-    def setUp(self):
-        super().setUp()
-
     def _create_stock_quant(self, product, location, qty):
         self.env["stock.quant"].create(
             {"product_id": product.id, "location_id": location.id, "quantity": qty}
@@ -176,30 +176,17 @@ class TestStockRequestBase(TestStockRequest):
             "product_uom_id": self.product.uom_id.id,
             "product_uom_qty": 5.0,
         }
-        stock_request = (
-            self.stock_request.with_user(self.stock_request_user)
-            .with_context(company_id=self.main_company.id)
-            .create(vals)
-        )
-
+        request_model = self.stock_request.with_user(self.stock_request_user)
+        stock_request = request_model.with_company(self.main_company).create(vals)
         self.assertEqual(stock_request.requested_by, self.stock_request_user)
-
         self.assertEqual(stock_request.warehouse_id, self.warehouse)
-
         self.assertEqual(stock_request.location_id, self.warehouse.lot_stock_id)
 
     def test_defaults_order(self):
-        vals = {}
-        order = (
-            self.request_order.with_user(self.stock_request_user)
-            .with_context(company_id=self.main_company.id)
-            .create(vals)
-        )
-
+        request_model = self.request_order.with_user(self.stock_request_user)
+        order = request_model.with_company(self.main_company).create({})
         self.assertEqual(order.requested_by, self.stock_request_user)
-
         self.assertEqual(order.warehouse_id, self.warehouse)
-
         self.assertEqual(order.location_id, self.warehouse.lot_stock_id)
 
     def test_onchanges_order(self):
@@ -228,7 +215,6 @@ class TestStockRequestBase(TestStockRequest):
         order = self.request_order.with_user(self.stock_request_user).new(vals)
         self.stock_request_user.company_id = self.company_2
         order.company_id = self.company_2
-
         order.onchange_company_id()
 
         stock_request = order.stock_request_ids
@@ -264,6 +250,7 @@ class TestStockRequestBase(TestStockRequest):
     def test_onchanges(self):
         self.product.route_ids = [(6, 0, self.route.ids)]
         vals = {
+            "product_id": self.product.id,
             "product_uom_id": self.product.uom_id.id,
             "product_uom_qty": 5.0,
             "company_id": self.main_company.id,
@@ -303,7 +290,7 @@ class TestStockRequestBase(TestStockRequest):
         # Test onchange_warehouse_id
         wh2_2 = (
             self.env["stock.warehouse"]
-            .with_context(company_id=self.company_2.id)
+            .with_company(self.company_2)
             .create(
                 {
                     "name": "C2_2",
@@ -776,14 +763,15 @@ class TestStockRequestBase(TestStockRequest):
             "warehouse_id": self.warehouse.id,
             "location_id": self.warehouse.lot_stock_id.id,
         }
-
         stock_request_1 = (
-            self.env["stock.request"].with_user(self.stock_request_user).create(vals)
+            self.env["stock.request"]
+            .with_user(self.stock_request_user)
+            .create(vals.copy())
         )
         stock_request_2 = (
             self.env["stock.request"]
             .with_user(self.stock_request_manager.id)
-            .create(vals)
+            .create(vals.copy())
         )
         stock_request_2.product_uom_qty = 6.0
         self.product.route_ids = [(6, 0, self.route.ids)]
@@ -915,10 +903,10 @@ class TestStockRequestBase(TestStockRequest):
             ],
         }
 
-        order = self.request_order.create(vals)
+        order = self.request_order.with_user(self.stock_request_manager).create(vals)
         self.product.route_ids = [(6, 0, self.route.ids)]
 
-        order.with_user(self.stock_request_manager).action_confirm()
+        order.action_confirm()
         stock_request = order.stock_request_ids
         self.assertTrue(stock_request.picking_ids)
         self.assertTrue(order.picking_ids)
@@ -1195,9 +1183,9 @@ class TestStockRequestBase(TestStockRequest):
         picking = order.picking_ids
         self.assertEqual(1, len(picking))
         picking.action_assign()
-        self.assertEqual(3, len(picking.move_lines))
-        line = picking.move_lines.filtered(lambda r: r.product_id == self.product)
-        line.quantity_done = 1
+        self.assertEqual(3, len(picking.move_line_ids))
+        line = picking.move_line_ids.filtered(lambda r: r.product_id == self.product)
+        line.qty_done = 1
         sr1 = order.stock_request_ids.filtered(lambda r: r.product_id == self.product)
         sr2 = order.stock_request_ids.filtered(lambda r: r.product_id == product2)
         sr3 = order.stock_request_ids.filtered(lambda r: r.product_id == product3)
@@ -1207,9 +1195,9 @@ class TestStockRequestBase(TestStockRequest):
         self.env["stock.backorder.confirmation"].with_context(
             button_validate_picking_ids=[picking.id]
         ).create({"pick_ids": [(4, picking.id)]}).process()
-        sr1.refresh()
-        sr2.refresh()
-        sr3.refresh()
+        sr1.env.invalidate_all()
+        sr2.env.invalidate_all()
+        sr3.env.invalidate_all()
         self.assertNotEqual(sr1.state, "done")
         self.assertNotEqual(sr2.state, "done")
         self.assertNotEqual(sr3.state, "done")
@@ -1218,62 +1206,58 @@ class TestStockRequestBase(TestStockRequest):
         )
         self.assertEqual(1, len(picking))
         picking.action_assign()
-        self.assertEqual(3, len(picking.move_lines))
-        line = picking.move_lines.filtered(lambda r: r.product_id == self.product)
-        line.quantity_done = 4
-        line = picking.move_lines.filtered(lambda r: r.product_id == product2)
-        line.quantity_done = 1
+        self.assertEqual(3, len(picking.move_line_ids))
+        line = picking.move_line_ids.filtered(lambda r: r.product_id == self.product)
+        line.qty_done = 4
+        line = picking.move_line_ids.filtered(lambda r: r.product_id == product2)
+        line.qty_done = 1
         self.env["stock.backorder.confirmation"].with_context(
             button_validate_picking_ids=[picking.id]
         ).create({"pick_ids": [(4, picking.id)]}).process_cancel_backorder()
-        sr1.refresh()
-        sr2.refresh()
-        sr3.refresh()
+        sr1.env.invalidate_all()
+        sr2.env.invalidate_all()
+        sr3.env.invalidate_all()
         self.assertEqual(sr1.state, "done")
-        self.assertEqual(sr1.qty_done, 5)
         self.assertEqual(sr1.qty_cancelled, 0)
         self.assertEqual(sr2.state, "cancel")
-        self.assertEqual(sr2.qty_done, 1)
         self.assertEqual(sr2.qty_cancelled, 4)
         self.assertEqual(sr3.state, "cancel")
-        self.assertEqual(sr3.qty_done, 0)
         self.assertEqual(sr3.qty_cancelled, 5)
-        # Set the request order to done if there are any delivered lines
-        self.assertEqual(order.state, "done")
 
 
 class TestStockRequestOrderState(TestStockRequest):
-    def setUp(self):
-        super().setUp()
-        self.product_a = self._create_product(
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.product_a = cls._create_product(
             "CODEA",
             "Product A",
-            self.main_company.id,
+            cls.main_company.id,
         )
-        self.product_a.route_ids = [(6, 0, self.route.ids)]
-        self.product_b = self._create_product(
+        cls.product_a.route_ids = [(6, 0, cls.route.ids)]
+        cls.product_b = cls._create_product(
             "CODEB",
             "Product B",
-            self.main_company.id,
+            cls.main_company.id,
         )
-        self.product_b.route_ids = [(6, 0, self.route.ids)]
+        cls.product_b.route_ids = [(6, 0, cls.route.ids)]
         expected_date = fields.Datetime.now()
         vals = {
-            "company_id": self.main_company.id,
-            "warehouse_id": self.warehouse.id,
-            "location_id": self.warehouse.lot_stock_id.id,
+            "company_id": cls.main_company.id,
+            "warehouse_id": cls.warehouse.id,
+            "location_id": cls.warehouse.lot_stock_id.id,
             "expected_date": expected_date,
             "stock_request_ids": [
                 (
                     0,
                     0,
                     {
-                        "product_id": self.product_a.id,
-                        "product_uom_id": self.product_a.uom_id.id,
+                        "product_id": cls.product_a.id,
+                        "product_uom_id": cls.product_a.uom_id.id,
                         "product_uom_qty": 1.0,
-                        "company_id": self.main_company.id,
-                        "warehouse_id": self.warehouse.id,
-                        "location_id": self.warehouse.lot_stock_id.id,
+                        "company_id": cls.main_company.id,
+                        "warehouse_id": cls.warehouse.id,
+                        "location_id": cls.warehouse.lot_stock_id.id,
                         "expected_date": expected_date,
                     },
                 ),
@@ -1281,23 +1265,23 @@ class TestStockRequestOrderState(TestStockRequest):
                     0,
                     0,
                     {
-                        "product_id": self.product_b.id,
-                        "product_uom_id": self.product_b.uom_id.id,
+                        "product_id": cls.product_b.id,
+                        "product_uom_id": cls.product_b.uom_id.id,
                         "product_uom_qty": 1.0,
-                        "company_id": self.main_company.id,
-                        "warehouse_id": self.warehouse.id,
-                        "location_id": self.warehouse.lot_stock_id.id,
+                        "company_id": cls.main_company.id,
+                        "warehouse_id": cls.warehouse.id,
+                        "location_id": cls.warehouse.lot_stock_id.id,
                         "expected_date": expected_date,
                     },
                 ),
             ],
         }
-        self.order = self.request_order.new(vals)
-        self.request_a = self.order.stock_request_ids.filtered(
-            lambda x: x.product_id == self.product_a
+        cls.order = cls.request_order.create(vals)
+        cls.request_a = cls.order.stock_request_ids.filtered(
+            lambda x: x.product_id == cls.product_a
         )
-        self.request_b = self.order.stock_request_ids.filtered(
-            lambda x: x.product_id == self.product_b
+        cls.request_b = cls.order.stock_request_ids.filtered(
+            lambda x: x.product_id == cls.product_b
         )
 
     def test_stock_request_order_state_01(self):

odoo/addons/stock_request/views/res_config_settings_views.xml

@@ -13,6 +13,7 @@
                 <div
                     class="app_settings_block"
                     data-string="Stock Request"
+                    string="Stock Request"
                     data-key="stock_request"
                     groups="stock_request.group_stock_request_manager"
                 >
@@ -42,7 +43,8 @@
                                     for="stock_request_allow_virtual_loc"
                                 />
                                 <div class="text-muted">
-                                    By default only internal and transit locations are allowed in Stock Request and Orders.
+                                    By default only internal and transit locations are allowed in
+                                    Stock Request and Orders.
                                 </div>
                             </div>
                         </div>
@@ -56,7 +58,8 @@
                                     for="module_stock_request_purchase"
                                 />
                                 <div class="text-muted">
-                                    Add State to Stock Request and Stock Request Orders if activated.
+                                    Add State to Stock Request and Stock Request Orders if
+                                    activated.
                                 </div>
                             </div>
                         </div>

odoo/addons/stock_request/views/stock_request_order_views.xml

@@ -6,6 +6,7 @@
         <field name="arch" type="xml">
             <tree>
                 <field name="name" />
+                <field name="allow_virtual_location" invisible="1" />
                 <field name="warehouse_id" groups="stock.group_stock_multi_locations" />
                 <field name="location_id" groups="stock.group_stock_multi_locations" />
                 <field name="state" />
@@ -17,6 +18,11 @@
         <field name="model">stock.request.order</field>
         <field name="arch" type="xml">
             <form>
+                <field name="allow_virtual_location" invisible="1" />
+                <field name="company_id" invisible="1" />
+                <field name="warehouse_id" invisible="1" />
+                <field name="location_id" invisible="1" />
+                <field name="procurement_group_id" invisible="1" />
                 <header>
                     <button
                         name="action_confirm"
@@ -40,7 +46,11 @@
                 </header>
                 <sheet>
                     <div class="oe_button_box" name="button_box">
-                        <field name="picking_ids" invisible="1" />
+                        <field
+                            name="picking_ids"
+                            invisible="1"
+                            groups="stock.group_stock_user"
+                        />
                         <button
                             type="object"
                             name="action_view_transfer"
@@ -51,6 +61,7 @@
                         >
                             <field
                                 name="picking_count"
+                                groups="stock.group_stock_user"
                                 widget="statinfo"
                                 string="Transfers"
                             />
@@ -91,7 +102,6 @@
                                 name="location_id"
                                 groups="stock.group_stock_multi_locations"
                             />
-                            <field name="allow_virtual_location" invisible="1" />
                             <field
                                 name="procurement_group_id"
                                 groups="stock.group_adv_location"
@@ -127,6 +137,7 @@
                                         options="{'no_open': True, 'no_create': True}"
                                         groups="uom.group_uom"
                                     />
+                                    <field name="product_uom_id" invisible="1" />
                                     <field
                                         name="route_id"
                                         options="{'no_create': True}"
@@ -138,11 +149,11 @@
                                     <field name="qty_done" />
                                     <field name="expected_date" invisible="1" />
                                     <field name="picking_policy" invisible="1" />
-                                    <field name="warehouse_id" invisible="1" />
                                     <field
                                         name="allow_virtual_location"
                                         invisible="1"
                                     />
+                                    <field name="warehouse_id" invisible="1" />
                                     <field name="location_id" invisible="1" />
                                     <field name="procurement_group_id" invisible="1" />
                                     <field name="company_id" invisible="1" />