odoo-addon-stock-move-location 16.0.1.4.1__py3-none-any.whl → 18.0.1.0.0.4__py3-none-any.whl

odoo/addons/stock_move_location/tests/test_common.py

@@ -1,17 +1,17 @@
 # Copyright (C) 2011 Julius Network Solutions SARL <contact@julius.fr>
 # Copyright 2018 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
+from odoo.tests import Form
 
-from odoo.tests import Form, common
+from odoo.addons.base.tests.common import BaseCommon
 
 
-class TestsCommon(common.TransactionCase):
+class TestsCommon(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
         cls.location_obj = cls.env["stock.location"]
-        product_obj = cls.env["product.product"]
+        cls.product_obj = cls.env["product.product"]
         cls.wizard_obj = cls.env["wiz.stock.move.location"]
         cls.quant_obj = cls.env["stock.quant"]
         cls.company = cls.env.ref("base.main_company")
@@ -43,14 +43,14 @@ class TestsCommon(common.TransactionCase):
             }
         )
         cls.uom_unit = cls.env.ref("uom.product_uom_unit")
-        cls.product_no_lots = product_obj.create(
-            {"name": "Pineapple", "type": "product", "tracking": "none"}
+        cls.product_no_lots = cls.product_obj.create(
+            {"name": "Pineapple", "is_storable": True, "tracking": "none"}
         )
-        cls.product_lots = product_obj.create(
-            {"name": "Apple", "type": "product", "tracking": "lot"}
+        cls.product_lots = cls.product_obj.create(
+            {"name": "Apple", "is_storable": True, "tracking": "lot"}
         )
-        cls.product_package = product_obj.create(
-            {"name": "Orange", "type": "product", "tracking": "lot"}
+        cls.product_package = cls.product_obj.create(
+            {"name": "Orange", "is_storable": True, "tracking": "lot"}
         )
         cls.lot1 = cls.env["stock.lot"].create(
             {
@@ -73,8 +73,8 @@ class TestsCommon(common.TransactionCase):
                 "company_id": cls.company.id,
             }
         )
-        cls.product_package = product_obj.create(
-            {"name": "Orange", "type": "product", "tracking": "lot"}
+        cls.product_package = cls.product_obj.create(
+            {"name": "Orange", "is_storable": True, "tracking": "lot"}
         )
         cls.lot4 = cls.env["stock.lot"].create(
             {
@@ -157,12 +157,15 @@ class TestsCommon(common.TransactionCase):
             amount,
         )
 
-    def _create_wizard(self, origin_location, destination_location):
+    def _create_wizard(
+        self, origin_location, destination_location, exclude_reserved_qty=False
+    ):
         move_location_wizard = self.env["wiz.stock.move.location"]
         return move_location_wizard.create(
             {
                 "origin_location_id": origin_location.id,
                 "destination_location_id": destination_location.id,
+                "exclude_reserved_qty": exclude_reserved_qty,
             }
         )
 

odoo/addons/stock_move_location/tests/test_move_location.py

@@ -84,20 +84,18 @@ class TestMoveLocation(TestsCommon):
         wizard = self._create_wizard(self.internal_loc_1, self.internal_loc_2)
         wizard.onchange_origin_location()
         self.assertEqual(len(wizard.stock_move_location_line_ids), 7)
-        wizard._onchange_destination_location_id()
-        self.assertEqual(len(wizard.stock_move_location_line_ids), 7)
         dest_location_line = wizard.stock_move_location_line_ids.mapped(
             "destination_location_id"
         )
         self.assertEqual(dest_location_line, wizard.destination_location_id)
-        wizard._onchange_origin_location_id()
+        wizard.clear_lines()
         self.assertEqual(len(wizard.stock_move_location_line_ids), 0)
 
     def test_wizard_onchange_origin_location(self):
         """Test a product that have existing quants with undefined quantity."""
 
         product_not_available = self.env["product.product"].create(
-            {"name": "Mango", "type": "product", "tracking": "none"}
+            {"name": "Mango", "is_storable": True, "tracking": "none"}
         )
         self.quant_obj.create(
             {
@@ -137,7 +135,7 @@ class TestMoveLocation(TestsCommon):
         )
         picking_lines = sorted(
             [
-                (line.product_id.id, line.lot_id.id, line.reserved_uom_qty)
+                (line.product_id.id, line.lot_id.id, line.quantity)
                 for line in picking.move_line_ids
             ],
             key=lambda x: (x[0], x[1]),
@@ -148,13 +146,13 @@ class TestMoveLocation(TestsCommon):
             "Mismatch between move location lines and move lines",
         )
         self.assertEqual(
-            sorted(picking.move_line_ids.mapped("reserved_uom_qty")),
+            sorted(picking.move_line_ids.mapped("quantity")),
             [1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 123.0],
         )
 
     def test_planned_transfer_strict(self):
         product = self.env["product.product"].create(
-            {"name": "Test", "type": "product", "tracking": "lot"}
+            {"name": "Test", "is_storable": True, "tracking": "lot"}
         )
         lot = self.env["stock.lot"].create(
             {
@@ -193,14 +191,14 @@ class TestMoveLocation(TestsCommon):
             location_line.move_quantity,
         ]
         line = picking.move_line_ids
-        picking_lines = [line.product_id.id, line.lot_id.id, line.reserved_uom_qty]
+        picking_lines = [line.product_id.id, line.lot_id.id, line.quantity]
         self.assertEqual(
             wizard_lines,
             picking_lines,
             "Mismatch between move location lines and move lines",
         )
         self.assertEqual(
-            picking.move_line_ids.reserved_uom_qty,
+            picking.move_line_ids.quantity,
             10.0,
         )
 
@@ -214,14 +212,10 @@ class TestMoveLocation(TestsCommon):
         location_lines.unlink()
         wizard.action_move_location()
         picking = wizard.picking_id
-        self.assertEqual(picking.state, "assigned")
-        self.assertEqual(
-            len(wizard.stock_move_location_line_ids), len(picking.move_line_ids)
-        )
-        self.assertEqual(
-            picking.move_line_ids.mapped("reserved_uom_qty"),
-            [0.0],
-        )
+        # Planned transfer state is "confirmed"
+        # move lines (quantity is zero) are removed
+        self.assertEqual(picking.state, "confirmed")
+        self.assertFalse(picking.move_line_ids)
 
     def test_quant_transfer(self):
         """Test quants transfer."""
@@ -241,10 +235,8 @@ class TestMoveLocation(TestsCommon):
         wizard.onchange_origin_location()
         self.assertEqual(len(lines), 3)
         wizard.destination_location_id = self.internal_loc_1
-        wizard._onchange_destination_location_id()
         self.assertEqual(lines.mapped("destination_location_id"), self.internal_loc_1)
         wizard.origin_location_id = self.internal_loc_2
-        wizard._onchange_destination_location_id()
         self.assertEqual(len(lines), 3)
 
     def test_readonly_location_computation(self):
@@ -276,7 +268,7 @@ class TestMoveLocation(TestsCommon):
             lambda p: p.product_id == self.product_no_lots
         )[0]
         self.assertEqual(
-            putaway_line.destination_location_id, self.internal_loc_2_shelf
+            putaway_line.destination_location_id, wizard.destination_location_id
         )
         picking_action = wizard.action_move_location()
         picking = self.env["stock.picking"].browse(picking_action["res_id"])
@@ -302,6 +294,7 @@ class TestMoveLocation(TestsCommon):
 
         # Create and assign a delivery picking to reserve some quantities
         delivery_picking = self._create_picking(delivery_order_type)
+        # delivery_picking.location_id = wh_stock_shelf_1
         delivery_move = self.env["stock.move"].create(
             {
                 "name": "Delivery move",
@@ -315,12 +308,14 @@ class TestMoveLocation(TestsCommon):
         )
         delivery_picking.action_confirm()
         self.assertEqual(delivery_picking.state, "assigned")
+        self.assertEqual(delivery_move.move_line_ids.location_id, wh_stock_shelf_1)
 
         # Move all quantities to other location using module's wizard
         wizard = self._create_wizard(wh_stock_shelf_1, wh_stock_shelf_2)
         wizard.onchange_origin_location()
         wizard.action_move_location()
-        self.assertEqual(delivery_picking.state, "confirmed")
+        self.assertEqual(delivery_picking.state, "assigned")
+        self.assertEqual(delivery_move.move_line_ids.location_id, wh_stock_shelf_2)
 
         # Do a planned transfer to move quantities to other location
         #  without using module's wizard
@@ -344,8 +339,8 @@ class TestMoveLocation(TestsCommon):
         self.assertEqual(delivery_picking.state, "confirmed")
         internal_picking.action_confirm()
         internal_picking.action_assign()
-        internal_picking.move_line_ids.qty_done = (
-            internal_picking.move_line_ids.reserved_uom_qty
+        internal_picking.move_line_ids.quantity = (
+            internal_picking.move_line_ids.quantity
         )
         internal_picking.button_validate()
         self.assertEqual(internal_picking.state, "done")
@@ -354,5 +349,5 @@ class TestMoveLocation(TestsCommon):
         self.assertEqual(delivery_picking.state, "assigned")
         # The old reserved quantities must be in new location after confirm wizard
         self.assertEqual(len(delivery_move.move_line_ids), 1)
-        self.assertEqual(delivery_move.move_line_ids.reserved_uom_qty, 20.0)
+        self.assertEqual(delivery_move.move_line_ids.quantity, 20.0)
         self.assertEqual(delivery_move.move_line_ids.location_id, wh_stock_shelf_3)

odoo/addons/stock_move_location/tests/test_stock_fillwithstock.py

@@ -2,63 +2,58 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 
-import odoo.tests.common as common
+from odoo.addons.base.tests.common import BaseCommon
 
 
-class TestFillwithStock(common.TransactionCase):
-    def setUp(self):
-        super(TestFillwithStock, self).setUp()
-        self.env = self.env(
-            context=dict(
-                self.env.context,
-                tracking_disable=True,
-            )
-        )
+class TestFillwithStock(BaseCommon):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
 
-        self.stock_location = self.env.ref("stock.stock_location_stock")
-        self.pack_location = self.env.ref("stock.location_pack_zone")
+        cls.stock_location = cls.env.ref("stock.stock_location_stock")
+        cls.pack_location = cls.env.ref("stock.location_pack_zone")
 
-        self.shelf1_location = self.env["stock.location"].create(
+        cls.shelf1_location = cls.env["stock.location"].create(
             {
                 "name": "Test location",
                 "usage": "internal",
-                "location_id": self.stock_location.id,
+                "location_id": cls.stock_location.id,
             }
         )
 
-        self.product1 = self.env["product.product"].create(
+        cls.product1 = cls.env["product.product"].create(
             {
                 "name": "Product A",
-                "type": "product",
+                "is_storable": True,
             }
         )
-        self.product2 = self.env["product.product"].create(
+        cls.product2 = cls.env["product.product"].create(
             {
                 "name": "Product B",
-                "type": "product",
+                "is_storable": True,
             }
         )
 
-        self.env["stock.quant"].create(
+        cls.env["stock.quant"].create(
             {
-                "product_id": self.product1.id,
-                "location_id": self.shelf1_location.id,
+                "product_id": cls.product1.id,
+                "location_id": cls.shelf1_location.id,
                 "quantity": 5.0,
                 "reserved_quantity": 0.0,
             }
         )
-        self.env["stock.quant"].create(
+        cls.env["stock.quant"].create(
             {
-                "product_id": self.product1.id,
-                "location_id": self.shelf1_location.id,
+                "product_id": cls.product1.id,
+                "location_id": cls.shelf1_location.id,
                 "quantity": 10.0,
                 "reserved_quantity": 5.0,
             }
         )
-        self.env["stock.quant"].create(
+        cls.env["stock.quant"].create(
             {
-                "product_id": self.product2.id,
-                "location_id": self.shelf1_location.id,
+                "product_id": cls.product2.id,
+                "location_id": cls.shelf1_location.id,
                 "quantity": 5.0,
                 "reserved_quantity": 0.0,
             }
@@ -80,7 +75,7 @@ class TestFillwithStock(common.TransactionCase):
             picking_stock_pack.move_ids.filtered(
                 lambda m: m.product_id == self.product1
             ).product_uom_qty,
-            10.0,
+            15.0,
         )
         self.assertEqual(
             picking_stock_pack.move_ids.filtered(

odoo/addons/stock_move_location/views/stock_picking.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0" ?>
 <odoo>
-
     <record id="view_picking_form" model="ir.ui.view">
         <field name="name">stock.picking.form.fillwithstock</field>
         <field name="model">stock.picking</field>
@@ -9,7 +8,7 @@
             <button name="action_confirm" position="before">
                 <button
                     name="button_fillwithstock"
-                    states="draft"
+                    invisible="state != 'draft'"
                     string="Fill with stock"
                     type="object"
                     class="oe_highlight"
@@ -18,5 +17,4 @@
             </button>
         </field>
     </record>
-
 </odoo>

odoo/addons/stock_move_location/views/stock_picking_type_views.xml

@@ -5,11 +5,8 @@
         <field name="model">stock.picking.type</field>
         <field name="inherit_id" ref="stock.view_picking_type_form" />
         <field name="arch" type="xml">
-            <field name="show_operations" position="after">
-                <field
-                    name="show_move_onhand"
-                    attrs='{"invisible": [("code", "not in", ["internal", "outgoing"])]}'
-                />
+            <field name="create_backorder" position="after">
+                <field name="show_move_onhand" invisible="code != 'internal'" />
             </field>
         </field>
     </record>
@@ -20,7 +17,7 @@
             <field name="code" position="after">
                 <field name="show_move_onhand" />
             </field>
-            <xpath expr="//div[hasclass('o_kanban_primary_left')]" position="inside">
+            <button name="get_action_picking_tree_ready" position="after">
                 <div t-if="record.show_move_onhand.raw_value">
                     <button
                         name="action_move_location"
@@ -31,7 +28,7 @@
                         Move On Hand
                     </button>
                 </div>
-            </xpath>
+            </button>
         </field>
     </record>
 </odoo>

odoo/addons/stock_move_location/wizard/stock_move_location.py

@@ -3,9 +3,8 @@
 # Copyright 2019 Sergio Teruel - Tecnativa <sergio.teruel@tecnativa.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
 
-from itertools import groupby
 
-from odoo import api, fields, models
+from odoo import Command, api, fields, models
 from odoo.fields import first
 from odoo.osv import expression
 
@@ -39,17 +38,20 @@ class StockMoveLocationWizard(models.TransientModel):
         "move_location_wizard_id",
         string="Move Location lines",
     )
+    company_id = fields.Many2one("res.company", default=lambda self: self.env.company)
     picking_type_id = fields.Many2one(
         compute="_compute_picking_type_id",
         comodel_name="stock.picking.type",
         readonly=False,
         store=True,
+        domain="[('company_id', '=', company_id), ('code', '=', 'internal')]",
     )
     picking_id = fields.Many2one(
         string="Connected Picking", comodel_name="stock.picking"
     )
     edit_locations = fields.Boolean(default=True)
     apply_putaway_strategy = fields.Boolean()
+    exclude_reserved_qty = fields.Boolean(default=True)
 
     @api.depends("edit_locations")
     def _compute_readonly_locations(self):
@@ -67,15 +69,20 @@ class StockMoveLocationWizard(models.TransientModel):
     @api.depends_context("company")
     @api.depends("origin_location_id")
     def _compute_picking_type_id(self):
-        company_id = self.env.context.get("company_id") or self.env.company.id
         for rec in self:
             picking_type = self.env["stock.picking.type"]
             base_domain = [
-                ("code", "in", ("internal", "outgoing")),
-                ("warehouse_id.company_id", "=", company_id),
+                ("code", "=", "internal"),
+                ("warehouse_id.company_id", "=", self.company_id.id),
             ]
             if rec.origin_location_id:
                 location_id = rec.origin_location_id
+                if (
+                    location_id
+                    and rec.picking_type_id
+                    and rec.picking_type_id.default_location_src_id == location_id
+                ):
+                    continue
                 while location_id and not picking_type:
                     domain = [("default_location_src_id", "=", location_id.id)]
                     domain = expression.AND([base_domain, domain])
@@ -102,8 +109,7 @@ class StockMoveLocationWizard(models.TransientModel):
     @api.model
     def _prepare_wizard_move_lines(self, quants):
         res = []
-        exclude_reserved_qty = self.env.context.get("only_reserved_qty", False)
-        if not exclude_reserved_qty:
+        if not self.exclude_reserved_qty:
             res = [
                 (
                     0,
@@ -113,6 +119,7 @@ class StockMoveLocationWizard(models.TransientModel):
                         "move_quantity": quant.quantity,
                         "max_quantity": quant.quantity,
                         "reserved_quantity": quant.reserved_quantity,
+                        "total_quantity": quant.quantity,
                         "origin_location_id": quant.location_id.id,
                         "lot_id": quant.lot_id.id,
                         "package_id": quant.package_id.id,
@@ -125,12 +132,13 @@ class StockMoveLocationWizard(models.TransientModel):
             ]
         else:
             # if need move only available qty per product on location
-            for _product, quant in groupby(quants, lambda r: r.product_id):
-                # we need only one quant per product
-                quant = list(quant)[0]
+            for quant in quants:
                 qty = quant._get_available_quantity(
                     quant.product_id,
                     quant.location_id,
+                    quant.lot_id,
+                    quant.package_id,
+                    quant.owner_id,
                 )
                 if qty:
                     res.append(
@@ -142,6 +150,7 @@ class StockMoveLocationWizard(models.TransientModel):
                                 "move_quantity": qty,
                                 "max_quantity": qty,
                                 "reserved_quantity": quant.reserved_quantity,
+                                "total_quantity": quant.quantity,
                                 "origin_location_id": quant.location_id.id,
                                 "lot_id": quant.lot_id.id,
                                 "package_id": quant.package_id.id,
@@ -153,16 +162,6 @@ class StockMoveLocationWizard(models.TransientModel):
                     )
         return res
 
-    @api.onchange("origin_location_id")
-    def _onchange_origin_location_id(self):
-        if not self.env.context.get("origin_location_disable", False):
-            self._clear_lines()
-
-    @api.onchange("destination_location_id")
-    def _onchange_destination_location_id(self):
-        for line in self.stock_move_location_line_ids:
-            line.destination_location_id = self.destination_location_id
-
     def _clear_lines(self):
         self.stock_move_location_line_ids = False
 
@@ -196,8 +195,7 @@ class StockMoveLocationWizard(models.TransientModel):
         groups = self.group_lines()
         moves = self.env["stock.move"]
         for lines in groups.values():
-            move = self._create_move(picking, lines)
-            moves |= move
+            moves |= self._create_move(picking, lines)
         return moves
 
     def _get_move_values(self, picking, lines):
@@ -224,17 +222,8 @@ class StockMoveLocationWizard(models.TransientModel):
         lines.create_move_lines(picking, move)
         if self.env.context.get("planned"):
             for line in lines:
-                available_quantity = self.env["stock.quant"]._get_available_quantity(
-                    line.product_id,
-                    line.origin_location_id,
-                    lot_id=line.lot_id,
-                    package_id=line.package_id,
-                    owner_id=line.owner_id,
-                    strict=True,
-                )
                 move._update_reserved_quantity(
                     line.move_quantity,
-                    available_quantity,
                     line.origin_location_id,
                     lot_id=line.lot_id,
                     package_id=line.package_id,
@@ -244,10 +233,11 @@ class StockMoveLocationWizard(models.TransientModel):
             # Force the state to be assigned, instead of _action_assign,
             # to avoid discarding the selected move_location_line.
             move.state = "assigned"
+            move.move_line_ids.filtered(lambda ml: not ml.quantity).unlink()
             move.move_line_ids.write({"state": "assigned"})
         return move
 
-    def _unreserve_moves(self):
+    def _unreserve_moves(self, picking):
         """
         Try to unreserve moves that they has reserved quantity before user
         moves products from a location to other one and change move origin
@@ -256,9 +246,9 @@ class StockMoveLocationWizard(models.TransientModel):
         """
         moves_to_reassign = self.env["stock.move"]
         lines_to_ckeck_reverve = self.stock_move_location_line_ids.filtered(
-            lambda l: (
-                l.move_quantity > l.max_quantity - l.reserved_quantity
-                and not l.origin_location_id.should_bypass_reservation()
+            lambda line: (
+                line.move_quantity > line.max_quantity
+                and not line.origin_location_id.should_bypass_reservation()
             )
         )
         for line in lines_to_ckeck_reverve:
@@ -270,7 +260,8 @@ class StockMoveLocationWizard(models.TransientModel):
                     ("lot_id", "=", line.lot_id.id),
                     ("package_id", "=", line.package_id.id),
                     ("owner_id", "=", line.owner_id.id),
-                    ("qty_done", ">", 0.0),
+                    ("quantity", ">", 0.0),
+                    ("picking_id", "!=", picking.id),
                 ]
             )
             moves_to_unreserve = move_lines.mapped("move_id")
@@ -281,17 +272,10 @@ class StockMoveLocationWizard(models.TransientModel):
 
     def action_move_location(self):
         self.ensure_one()
-        if not self.picking_id:
-            picking = self._create_picking()
-        else:
-            picking = self.picking_id
-        # Prevent putaway rules to be excuted when we don't need to
-        picking = picking.with_context(
-            avoid_putaway_rules=not self.apply_putaway_strategy
-        )
+        picking = self.picking_id if self.picking_id else self._create_picking()
         self._create_moves(picking)
         if not self.env.context.get("planned"):
-            moves_to_reassign = self._unreserve_moves()
+            moves_to_reassign = self._unreserve_moves(picking)
             picking.button_validate()
             moves_to_reassign._action_assign()
         self.picking_id = picking
@@ -322,7 +306,7 @@ class StockMoveLocationWizard(models.TransientModel):
                 "quantity:sum",
                 "reserved_quantity:sum",
             ],
-            groupby=["product_id", "lot_id", "package_id", "owner_id"],
+            groupby=["id", "product_id", "lot_id", "package_id", "owner_id"],
             orderby="id",
             lazy=False,
         )
@@ -339,12 +323,18 @@ class StockMoveLocationWizard(models.TransientModel):
                 and self.destination_location_id._get_putaway_strategy(product).id
                 or self.destination_location_id.id
             )
+            res_qty = group.get("reserved_quantity", 0.0)
+            total_qty = group.get("quantity", 0.0)
+            max_qty = (
+                total_qty if not self.exclude_reserved_qty else total_qty - res_qty
+            )
             product_data.append(
                 {
                     "product_id": product.id,
-                    "move_quantity": group.get("quantity") or 0,
-                    "max_quantity": group.get("quantity") or 0,
-                    "reserved_quantity": group.get("reserved_quantity"),
+                    "move_quantity": max_qty,
+                    "max_quantity": max_qty,
+                    "reserved_quantity": res_qty,
+                    "total_quantity": total_qty,
                     "origin_location_id": self.origin_location_id.id,
                     "destination_location_id": location_dest_id,
                     # cursor returns None instead of False
@@ -361,21 +351,7 @@ class StockMoveLocationWizard(models.TransientModel):
             )
         return product_data
 
-    def _reset_stock_move_location_lines(self):
-        lines = []
-        line_model = self.env["wiz.stock.move.location.line"]
-        for line_val in self._get_stock_move_location_lines_values():
-            if line_val.get("max_quantity") <= 0:
-                continue
-            line = line_model.create(line_val)
-            line.max_quantity = line.get_max_quantity()
-            line.reserved_quantity = line.reserved_quantity
-            lines.append(line)
-        self.update(
-            {"stock_move_location_line_ids": [(6, 0, [line.id for line in lines])]}
-        )
-
-    @api.onchange("origin_location_id")
+    @api.onchange("origin_location_id", "exclude_reserved_qty")
     def onchange_origin_location(self):
         # Get origin_location_disable context key to prevent load all origin
         # location products when user opens the wizard from stock quants to
@@ -384,7 +360,12 @@ class StockMoveLocationWizard(models.TransientModel):
             not self.env.context.get("origin_location_disable")
             and self.origin_location_id
         ):
-            self._reset_stock_move_location_lines()
+            lines = [Command.clear()] + [
+                Command.create(line_vals)
+                for line_vals in self._get_stock_move_location_lines_values()
+                if line_vals.get("max_quantity", 0.0) > 0.0
+            ]
+            self.update({"stock_move_location_line_ids": lines})
 
     def clear_lines(self):
         self._clear_lines()