odoo-addon-shopfloor-mobile 16.0.1.3.0__py3-none-any.whl → 18.0.1.0.0.3__py3-none-any.whl

odoo/addons/shopfloor_mobile/static/wms/src/demo/{demo.checkout.js → demo.checkout.esm.js}

@@ -4,7 +4,7 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {demotools} from "/shopfloor_mobile_base/static/wms/src/demo/demo.core.js";
+import {demotools} from "/shopfloor_mobile_base/static/src/demo/demo.core.esm.js";
 
 const select_pack_picking = demotools.makePicking(
     {},
@@ -72,7 +72,7 @@ const DEMO_CHECKOUT = {
     scan_package_action: function (data) {
         const res = data_for_select_package;
         const line = res.data.select_package.selected_move_lines.find(function (x) {
-            return x.product.barcode == data.barcode;
+            return x.product.barcode === data.barcode;
         });
         line.qty_done++;
         return res;
@@ -102,7 +102,7 @@ const DEMO_CHECKOUT = {
     set_line_qty: function (data) {
         const res = data_for_set_line_qty;
         const line = res.data.select_package.selected_move_lines.filter(function (x) {
-            return x.id == data.move_line_id;
+            return x.id === data.move_line_id;
         })[0];
         line.qty_done = line.quantity;
         return res;
@@ -110,7 +110,7 @@ const DEMO_CHECKOUT = {
     reset_line_qty: function (data) {
         const res = data_for_set_line_qty;
         const line = res.data.select_package.selected_move_lines.filter(function (x) {
-            return x.id == data.move_line_id;
+            return x.id === data.move_line_id;
         })[0];
         line.qty_done = 0;
         return res;

odoo/addons/shopfloor_mobile/static/wms/src/demo/{demo.cluster_picking.js → demo.cluster_picking.esm.js}

@@ -4,7 +4,7 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {demotools} from "/shopfloor_mobile_base/static/wms/src/demo/demo.core.js";
+import {demotools} from "/shopfloor_mobile_base/static/src/demo/demo.core.esm.js";
 
 const DEMO_CLUSTER_PICKING_1 = {
     find_batch: {

odoo/addons/shopfloor_mobile/static/wms/src/demo/{demo.delivery.js → demo.delivery.esm.js}

@@ -4,7 +4,7 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {demotools} from "/shopfloor_mobile_base/static/wms/src/demo/demo.core.js";
+import {demotools} from "/shopfloor_mobile_base/static/src/demo/demo.core.esm.js";
 
 const pickings = [];
 const count = 8;
@@ -14,9 +14,9 @@ for (let i = 1; i < count + 1; i++) {
         {},
         {lines_count: demotools.getRandomInt(5), line_random_pack: true}
     );
-    for (let i = 0; i < demotools.getRandomInt(move_lines.length); i++) {
+    for (let j = 0; j < demotools.getRandomInt(move_lines.length); j++) {
         // Set some as done
-        move_lines[i].qty_done = move_lines[i].quantity;
+        move_lines[j].qty_done = move_lines[j].quantity;
     }
     pickings.push(
         demotools.makePicking(

odoo/addons/shopfloor_mobile/static/wms/src/demo/{demo.location_content_transfer.js → demo.location_content_transfer.esm.js}

@@ -4,7 +4,7 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {demotools} from "/shopfloor_mobile_base/static/wms/src/demo/demo.core.js";
+import {demotools} from "/shopfloor_mobile_base/static/src/demo/demo.core.esm.js";
 
 // Case for recover existing work on single move line
 const recover_single_move_line_menu_id = demotools.addAppMenu({

odoo/addons/shopfloor_mobile/static/wms/src/demo/{demo.scan_anything.js → demo.scan_anything.esm.js}

@@ -5,7 +5,7 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {demotools} from "/shopfloor_mobile_base/static/wms/src/demo/demo.core.js";
+import {demotools} from "/shopfloor_mobile_base/static/src/demo/demo.core.esm.js";
 
 const DEMO_SCAN_ANYTHING_PACK1 = {
     data: {

odoo/addons/shopfloor_mobile/static/wms/src/demo/{demo.single_pack_transfer.js → demo.single_pack_transfer.esm.js}

@@ -4,7 +4,7 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {demotools} from "/shopfloor_mobile_base/static/wms/src/demo/demo.core.js";
+import {demotools} from "/shopfloor_mobile_base/static/src/demo/demo.core.esm.js";
 
 // TODO: refactor w/ demotools data
 const CANCEL_MSG_DEFAULT = {

odoo/addons/shopfloor_mobile/static/wms/src/demo/{demo.zone_picking.js → demo.zone_picking.esm.js}

@@ -4,7 +4,7 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {demotools} from "/shopfloor_mobile_base/static/wms/src/demo/demo.core.js";
+import {demotools} from "/shopfloor_mobile_base/static/src/demo/demo.core.esm.js";
 
 function _makePickingType() {
     const lines_count = demotools.getRandomInt(10);
@@ -64,7 +64,7 @@ const move_lines = demotools.makePickingLines(
 const select_line_move_lines = _.orderBy(move_lines, ["priority"], ["desc"]);
 _.forEach(select_line_move_lines, function (line, i) {
     // Simulate random flag
-    line.location_will_be_empty = i % 3 == 0;
+    line.location_will_be_empty = i % 3 === 0;
     // Simulate adding 1 qty
     line.qty_done++;
 });
@@ -111,7 +111,7 @@ const DEMO_CASE_1 = {
     },
     list_move_lines: function (data) {
         const res = _.cloneDeep(list_move_lines);
-        if (data.order == "location") {
+        if (data.order === "location") {
             res.data.select_line.move_lines = _.orderBy(
                 res.data.select_line.move_lines,
                 ["location_src.name"]

odoo/addons/shopfloor_mobile/static/wms/src/i18n/{add_translations_to_registry.js → add_translations_to_registry.esm.js}

@@ -1,4 +1,4 @@
-import {translation_registry} from "/shopfloor_mobile_base/static/wms/src/services/translation_registry.js";
+import {translation_registry} from "/shopfloor_mobile_base/static/src/services/translation_registry.esm.js";
 
 translation_registry.load("fr-FR", "/shopfloor_mobile/static/wms/src/i18n/fr.json");
 translation_registry.load("en-US", "/shopfloor_mobile/static/wms/src/i18n/en.json");

odoo/addons/shopfloor_mobile/static/wms/src/scenario/{checkout.js → checkout.esm.js}

@@ -4,10 +4,11 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/wms/src/scenario/mixins.js";
-import {process_registry} from "/shopfloor_mobile_base/static/wms/src/services/process_registry.js";
-import {checkout_states} from "./checkout_states.js";
-import event_hub from "/shopfloor_mobile_base/static/wms/src/services/event_hub.js";
+/* eslint-disable sort-imports */
+import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/src/scenario/mixins.esm.js";
+import event_hub from "/shopfloor_mobile_base/static/src/services/event_hub.esm.js";
+import {process_registry} from "/shopfloor_mobile_base/static/src/services/process_registry.esm.js";
+import {checkout_states} from "./checkout_states.esm.js";
 
 const Checkout = {
     mixins: [ScenarioBaseMixin],
@@ -297,7 +298,7 @@ const Checkout = {
                             path: "priority",
                             render_component: "priority-widget",
                             render_options: function (record) {
-                                const priority = parseInt(record.priority);
+                                const priority = parseInt(record.priority, 10) || 0;
                                 // We need to pass the label to the component as an option instead of using "display_no_value"
                                 // because pickings with no priority will still have a string value of "0"
                                 // and the label would always be displayed.
@@ -351,7 +352,7 @@ const Checkout = {
         select_line_detail_picking_select_props: function () {
             const picking = this.state.data.picking;
             const lines = picking.move_lines;
-            let grouped_lines = undefined;
+            let grouped_lines = [];
             if (this.state.data.group_lines_by_location) {
                 grouped_lines = this.select_line_manual_select_group_lines(lines);
             }

odoo/addons/shopfloor_mobile/static/wms/src/scenario/{checkout_states.js → checkout_states.esm.js}

@@ -24,6 +24,7 @@ export const checkout_states = function ($instance) {
                     $instance.odoo.call("scan_document", {barcode: scanned.text})
                 );
             },
+            // eslint-disable-next-line no-unused-vars
             on_manual_selection: (evt) => {
                 $instance.wait_call($instance.odoo.call("list_stock_picking"));
             },
@@ -65,6 +66,7 @@ export const checkout_states = function ($instance) {
                         barcode: scanned.text,
                         confirm_pack_all:
                             $instance.state.data.need_confirm_pack_all || "",
+                        confirm_lot: $instance.state.data.need_confirm_lot,
                     })
                 );
             },
@@ -149,7 +151,8 @@ export const checkout_states = function ($instance) {
                         );
                     })
                 );
-                let endpoint, move_line;
+                let endpoint = "",
+                    move_line = {};
                 if (to_unselect) {
                     endpoint = "reset_line_qty";
                     move_line = to_unselect;

odoo/addons/shopfloor_mobile/static/wms/src/scenario/{cluster_picking.js → cluster_picking.esm.js}

@@ -4,8 +4,8 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/wms/src/scenario/mixins.js";
-import {process_registry} from "/shopfloor_mobile_base/static/wms/src/services/process_registry.js";
+import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/src/scenario/mixins.esm.js";
+import {process_registry} from "/shopfloor_mobile_base/static/src/services/process_registry.esm.js";
 
 // TODO: consider replacing the dynamic "autofocus" in the searchbar by an event.
 // At the moment, we need autofocus to be disabled if there's a user popup.
@@ -189,10 +189,10 @@ const ClusterPicking = {
             scan_destination_qty: 0,
             states: {
                 start: {
-                    on_get_work: (evt) => {
+                    on_get_work: () => {
                         this.wait_call(this.odoo.call("find_batch"));
                     },
-                    on_manual_selection: (evt) => {
+                    on_manual_selection: () => {
                         this.wait_call(this.odoo.call("list_batch"));
                     },
                 },
@@ -375,8 +375,8 @@ const ClusterPicking = {
                         // FIXME: use state_load or traverse the state
                         // this.current_state_key = "unload_all";
                         // this.state.on_scan(scanned, confirmation);
-                        confirmation = this.state.data.confirmation || "";
-                        this.states.unload_all.on_scan(scanned, confirmation);
+                        const confirm = this.state.data.confirmation || confirmation;
+                        this.states.unload_all.on_scan(scanned, confirm);
                     },
                 },
                 unload_single: {
@@ -422,7 +422,8 @@ const ClusterPicking = {
                         this.wait_call(
                             this.odoo.call("unload_scan_destination", {
                                 picking_batch_id: this.current_batch().id,
-                                package_id: null, // FIXME: where does it come from? backend data?
+                                // FIXME: where does it come from? backend data?
+                                package_id: null,
                                 barcode: scanned.text,
                                 confirmation: this.state.data.confirmation || "",
                             })

odoo/addons/shopfloor_mobile/static/wms/src/scenario/{delivery.js → delivery.esm.js}

@@ -4,8 +4,8 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/wms/src/scenario/mixins.js";
-import {process_registry} from "/shopfloor_mobile_base/static/wms/src/services/process_registry.js";
+import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/src/scenario/mixins.esm.js";
+import {process_registry} from "/shopfloor_mobile_base/static/src/services/process_registry.esm.js";
 
 const Delivery = {
     mixins: [ScenarioBaseMixin],
@@ -129,12 +129,13 @@ const Delivery = {
                     "package_src"
                 ),
                 group_color_maker: function (lines) {
-                    return self.utils.wms.move_lines_completeness(lines) == 100
+                    return self.utils.wms.move_lines_completeness(lines) === 100
                         ? "screen_step_done"
                         : "screen_step_todo";
                 },
             });
         },
+        /* eslint-disable no-unused-vars */
         deliver_move_line_list_options: function (picking) {
             return {
                 list_item_options: {
@@ -174,9 +175,8 @@ const Delivery = {
             const operation_progress = this._get_operation_progress_data();
             if (operation_progress.done === operation_progress.to_do) {
                 return this.utils.colors.color_for("screen_step_done");
-            } else {
-                return this.utils.colors.color_for("screen_step_todo");
             }
+            return this.utils.colors.color_for("screen_step_todo");
         },
         _get_operation_progress_data: function () {
             return _.result(this.state, "data.sublocation.operation_progress", false);
@@ -202,6 +202,7 @@ const Delivery = {
                 {
                     path: "move_line_count",
                     label: "Lines",
+
                     renderer: function (rec, field) {
                         return (
                             self.utils.wms.completed_move_lines(rec.move_lines) +
@@ -236,6 +237,7 @@ const Delivery = {
                             this.odoo.call("scan_deliver", {barcode: scanned.text})
                         );
                     },
+
                     on_manual_selection: (evt) => {
                         this.wait_call(this.odoo.call("list_stock_picking"));
                     },
@@ -257,6 +259,7 @@ const Delivery = {
                             })
                         );
                     },
+
                     on_manual_selection: (evt) => {
                         this.wait_call(
                             this.odoo.call("list_stock_picking", {
@@ -265,7 +268,8 @@ const Delivery = {
                         );
                     },
                     on_cancel: (data) => {
-                        let endpoint, endpoint_data;
+                        let endpoint = "";
+                        let endpoint_data = "";
                         // TODO: can't we have a single endpoint as per checkout.summary.destroy?
                         if (data.package_id) {
                             endpoint = "reset_qty_done_pack";

odoo/addons/shopfloor_mobile/static/wms/src/scenario/{location_content_transfer.js → location_content_transfer.esm.js}

@@ -4,8 +4,8 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/wms/src/scenario/mixins.js";
-import {process_registry} from "/shopfloor_mobile_base/static/wms/src/services/process_registry.js";
+import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/src/scenario/mixins.esm.js";
+import {process_registry} from "/shopfloor_mobile_base/static/src/services/process_registry.esm.js";
 
 // TODO: consider replacing the dynamic "autofocus" in the searchbar by an event.
 // At the moment, we need autofocus to be disabled if there's a user popup.
@@ -190,10 +190,11 @@ const LocationContentTransfer = {
         },
         // Common actions
         on_line_action: function (action) {
-            this["on_" + action.event_name].call(this);
+            this["on_" + action.event_name](this);
         },
         on_action_postpone: function () {
-            let endpoint, endpoint_data;
+            let endpoint = "";
+            let endpoint_data = {};
             const data = this.state.data;
             if (data.package_level) {
                 endpoint = "postpone_package";
@@ -235,9 +236,11 @@ const LocationContentTransfer = {
                     },
                 },
                 get_work: {
+                    /* eslint-disable no-unused-vars */
                     on_get_work: (evt) => {
                         this.wait_call(this.odoo.call("find_work"));
                     },
+                    /* eslint-disable no-unused-vars */
                     on_manual_selection: (evt) => {
                         this.state_to("scan_location");
                     },
@@ -292,7 +295,8 @@ const LocationContentTransfer = {
                         ),
                     },
                     on_scan: (scanned) => {
-                        let endpoint, endpoint_data;
+                        let endpoint = "";
+                        let endpoint_data = {};
                         const data = this.state.data;
                         if (data.package_level) {
                             endpoint = "scan_package";
@@ -329,7 +333,8 @@ const LocationContentTransfer = {
                         this.scan_destination_qty = parseInt(qty, 10);
                     },
                     on_scan: (scanned) => {
-                        let endpoint, endpoint_data;
+                        let endpoint = "";
+                        let endpoint_data = {};
                         const data = this.state.data;
                         if (data.package_level) {
                             endpoint = "set_destination_package";
@@ -363,7 +368,8 @@ const LocationContentTransfer = {
                         this.reset_notification();
                     },
                     on_confirm_stock_issue: () => {
-                        let endpoint, endpoint_data;
+                        let endpoint = "";
+                        let endpoint_data = {};
                         const data = this.state.data;
                         if (data.package_level) {
                             endpoint = "stock_out_package";

odoo/addons/shopfloor_mobile/static/wms/src/scenario/{single_pack_transfer.js → single_pack_transfer.esm.js}

@@ -6,8 +6,8 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/wms/src/scenario/mixins.js";
-import {process_registry} from "/shopfloor_mobile_base/static/wms/src/services/process_registry.js";
+import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/src/scenario/mixins.esm.js";
+import {process_registry} from "/shopfloor_mobile_base/static/src/services/process_registry.esm.js";
 
 export var SinglePackStatesMixin = {
     data: function () {

odoo/addons/shopfloor_mobile/static/wms/src/scenario/{zone_picking.js → zone_picking.esm.js}

@@ -4,8 +4,8 @@
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
 
-import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/wms/src/scenario/mixins.js";
-import {process_registry} from "/shopfloor_mobile_base/static/wms/src/services/process_registry.js";
+import {ScenarioBaseMixin} from "/shopfloor_mobile_base/static/src/scenario/mixins.esm.js";
+import {process_registry} from "/shopfloor_mobile_base/static/src/services/process_registry.esm.js";
 
 // TODO: consider replacing the dynamic "autofocus" in the searchbar by an event.
 // At the moment, we need autofocus to be disabled if there's a user popup.
@@ -378,6 +378,7 @@ const ZonePicking = {
                 },
             ];
         },
+        /* eslint-disable no-unused-vars */
         picking_type_render_lines_count(record, field) {
             return _.template("(${counters}) ${name}")({
                 counters: this.$t("misc.lines_count", record),
@@ -525,9 +526,8 @@ const ZonePicking = {
                     renderer: function (rec, field) {
                         if (rec.handle_complete_mix_pack) {
                             return "";
-                        } else {
-                            return rec.product.display_name;
                         }
+                        return rec.product.display_name;
                     },
                 },
                 {
@@ -583,7 +583,7 @@ const ZonePicking = {
         },
         toggle_sort_lines_by() {
             this.order_lines_by =
-                this.order_lines_by == "priority" ? "location" : "priority";
+                this.order_lines_by === "priority" ? "location" : "priority";
             return this.list_move_lines(this.current_picking_type().id);
         },
         list_move_lines(picking_type_id) {
@@ -594,7 +594,7 @@ const ZonePicking = {
             return this.wait_call(this.odoo.call("list_move_lines", {}));
         },
         scan_source(barcode) {
-            let data = {
+            const data = {
                 barcode: barcode,
                 confirmation: this.state.data.confirmation_required || "",
             };
@@ -670,7 +670,7 @@ const ZonePicking = {
     },
     computed: {
         sort_lines_by_btn_label() {
-            return this.order_lines_by == "priority"
+            return this.order_lines_by === "priority"
                 ? this.$t("order_lines_by.location")
                 : this.$t("order_lines_by.priority");
         },
@@ -783,12 +783,11 @@ const ZonePicking = {
                                         return "Scan product / lot";
                                     }
                                     return "Scan product";
-                                } else {
-                                    if (this.any_line_with_lot()) {
-                                        return "Scan pack / product / lot";
-                                    }
-                                    return "Scan pack / product";
                                 }
+                                if (this.any_line_with_lot()) {
+                                    return "Scan pack / product / lot";
+                                }
+                                return "Scan pack / product";
                             }
                             if (this.any_line_with_lot()) {
                                 return "Scan location / pack / product / lot";
@@ -817,8 +816,8 @@ const ZonePicking = {
                         while (!barcode) {
                             _.forEach(
                                 ["lot.name", "product.barcode", "location_src.barcode"],
-                                function (path) {
-                                    barcode = _.result(selected, path);
+                                function (pth) {
+                                    barcode = _.result(selected, pth);
                                 }
                             );
                         }
@@ -863,16 +862,14 @@ const ZonePicking = {
                             // Only locations are allowed.
                             display_info.scan_placeholder =
                                 display_info.scan_placeholder_location;
+                        } else if (full_qty === 0 || full_qty === false) {
+                            // Only packages are allowed.
+                            display_info.scan_placeholder =
+                                display_info.scan_placeholder_package;
                         } else {
-                            if (!full_qty) {
-                                // Only packages are allowed.
-                                display_info.scan_placeholder =
-                                    display_info.scan_placeholder_package;
-                            } else {
-                                // Both are allowed.
-                                display_info.scan_placeholder =
-                                    display_info.scan_placeholder_full;
-                            }
+                            // Both are allowed.
+                            display_info.scan_placeholder =
+                                display_info.scan_placeholder_full;
                         }
                     },
                     on_scan: (scanned) => {
@@ -889,7 +886,7 @@ const ZonePicking = {
                                 barcode: scanned.text,
                                 quantity: quantity,
                                 confirmation: data.confirmation_required || "",
-                                // package_id: data.is_complete_mix_pack ? data.move_line.package_src.id : null,
+                                // Package_id: data.is_complete_mix_pack ? data.move_line.package_src.id : null,
                                 handle_complete_mix_pack: data.handle_complete_mix_pack,
                             })
                         );

odoo/addons/shopfloor_mobile/static/wms/src/{wms_utils.js → wms_utils.esm.js}

@@ -4,19 +4,20 @@
  * @author Simone Orsi <simahawk@gmail.com>
  * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
  */
-import {utils_registry} from "/shopfloor_mobile_base/static/wms/src/services/utils_registry.js";
+import {utils_registry} from "/shopfloor_mobile_base/static/src/services/utils_registry.esm.js";
 
 export class WMSUtils {
-    group_lines_by_location(lines, options) {
+    group_lines_by_location(lines, opts) {
         const self = this;
         // {'key': 'no-group', 'title': '', 'records': []}
-        options = _.defaults(options || {}, {
+        const options = _.defaults(opts || {}, {
             group_key: "location_src",
             group_no_title: false,
             name_prefix: "Location",
             prepare_records: function (recs) {
                 return recs;
             },
+            /* eslint-disable no-unused-vars */
             group_color_maker: function (recs) {
                 return "";
             },
@@ -32,11 +33,12 @@ export class WMSUtils {
         // TODO: grouped.forEach?
         _.forEach(grouped, function (value, loc_id) {
             const location = _.first(_.filter(locations, {id: parseInt(loc_id, 10)}));
-            const title = options.group_no_title
-                ? ""
-                : options.name_prefix
-                ? options.name_prefix + ": " + location.name
-                : location.name;
+            let title = location.name;
+            if (options.group_no_title) {
+                title = "";
+            } else if (options.name_prefix) {
+                title = options.name_prefix + ": " + location.name;
+            }
             res.push({
                 _is_group: true,
                 key: loc_id,
@@ -48,10 +50,10 @@ export class WMSUtils {
         return res;
     }
 
-    group_lines_by_locations(lines, options) {
+    group_lines_by_locations(lines, opts) {
         const self = this;
         // {key: 'no-group', location_src: {}, location_dest: {} records: []}
-        options = _.defaults(options || {}, {
+        const options = _.defaults(opts || {}, {
             prepare_records: function (recs) {
                 return recs;
             },
@@ -86,10 +88,10 @@ export class WMSUtils {
         return res;
     }
 
-    group_lines_by_product(lines, options) {
+    group_lines_by_product(lines, opts) {
         const self = this;
         // {'key': 'no-group', 'title': '', 'records': []}
-        options = _.defaults(options || {}, {
+        const options = _.defaults(opts || {}, {
             group_no_title: false,
             prepare_records: function (recs) {
                 return recs;
@@ -101,18 +103,19 @@ export class WMSUtils {
         const res = [];
         const products = _.uniqBy(
             _.map(lines, function (x) {
-                return x["product"];
+                return x.product;
             }),
             "id"
         );
         const grouped = _.groupBy(lines, "product.id");
         _.forEach(grouped, function (value, prod_id) {
             const product = _.first(_.filter(products, {id: parseInt(prod_id, 10)}));
-            const title = options.group_no_title
-                ? ""
-                : options.name_prefix
-                ? options.name_prefix + ": " + product.name
-                : product.name;
+            let title = product.name;
+            if (options.group_no_title) {
+                title = "";
+            } else if (options.name_prefix) {
+                title = `${options.name_prefix}: ${product.name}`;
+            }
             res.push({
                 _is_group: true,
                 key: prod_id,
@@ -169,8 +172,8 @@ export class WMSUtils {
             res.push({
                 _is_group: true,
                 // GroupBy gives undefined as string
-                key: packaging_name == "undefined" ? "no-packaging" : packaging_name,
-                title: packaging_name == "undefined" ? "" : packaging_name,
+                key: packaging_name === "undefined" ? "no-packaging" : packaging_name,
+                title: packaging_name === "undefined" ? "" : packaging_name,
                 records: products,
             });
         });
@@ -201,7 +204,7 @@ export class WMSUtils {
         const res = [];
         grouped.forEach(function (group) {
             if (group.pack) {
-                let single_line = group.records[0];
+                const single_line = group.records[0];
                 single_line._grouped_by_pack = true;
                 single_line._pack_lines = group.records;
                 res.push(single_line);
@@ -244,11 +247,11 @@ export class WMSUtils {
             line = line.records[0];
         }
         let klass = "";
-        if (line.qty_done == line.quantity) {
+        if (line.qty_done === line.quantity) {
             klass = "done screen_step_done lighten-1";
         } else if (line.qty_done && line.qty_done < line.quantity) {
             klass = "partial screen_step_todo lighten-2";
-        } else if (line.qty_done == 0) {
+        } else if (line.qty_done === 0) {
             klass = "not-done screen_step_todo lighten-1";
         }
         return "move-line-" + klass;
@@ -259,7 +262,7 @@ export class WMSUtils {
         if (!records) {
             return;
         }
-        let avg_progress =
+        const avg_progress =
             records.reduce((acc, next) => {
                 return next.progress + acc;
             }, 0) / records.length;
@@ -283,7 +286,7 @@ export class WMSUtils {
      *
      * @param {*} line The move line
      */
-    move_line_product_detail_options(line, options = {}) {
+    move_line_product_detail_options(line, opts = {}) {
         const self = this;
         const default_fields = [
             {path: "product.supplier_code", label: "Vendor code", klass: "loud"},
@@ -301,7 +304,7 @@ export class WMSUtils {
             },
             {path: "product.qty_available", label: "Qty on hand"},
         ];
-        options = _.defaults({}, options, {
+        const options = _.defaults({}, opts, {
             main: true,
             key_title: "product.display_name",
             title_action_field: {