odoo-addon-l10n-br-fiscal 18.0.2.0.0.10__py3-none-any.whl → 18.0.5.0.0.1__py3-none-any.whl

odoo/addons/l10n_br_fiscal/models/document_line_mixin_methods.py

@@ -4,44 +4,22 @@
 from copy import deepcopy
 
 from lxml import etree
+from lxml.builder import E
 
 from odoo import Command, api, models
 
-from ..constants.fiscal import CFOP_DESTINATION_EXPORT, FISCAL_IN
-from ..constants.icms import ICMS_BASE_TYPE_DEFAULT, ICMS_ST_BASE_TYPE_DEFAULT
-
-FISCAL_TAX_ID_FIELDS = [
-    "cofins_tax_id",
-    "cofins_wh_tax_id",
-    "cofinsst_tax_id",
-    "csll_tax_id",
-    "csll_wh_tax_id",
-    "icms_tax_id",
-    "icmsfcp_tax_id",
-    "icmssn_tax_id",
-    "icmsst_tax_id",
-    "icmsfcpst_tax_id",
-    "ii_tax_id",
-    "inss_tax_id",
-    "inss_wh_tax_id",
-    "ipi_tax_id",
-    "irpj_tax_id",
-    "irpj_wh_tax_id",
-    "issqn_tax_id",
-    "issqn_wh_tax_id",
-    "pis_tax_id",
-    "pis_wh_tax_id",
-    "pisst_tax_id",
-]
-
-FISCAL_CST_ID_FIELDS = [
-    "icms_cst_id",
-    "ipi_cst_id",
-    "pis_cst_id",
-    "pisst_cst_id",
-    "cofins_cst_id",
-    "cofinsst_cst_id",
-]
+from ..constants.fiscal import (
+    CFOP_DESTINATION_EXPORT,
+    FISCAL_IN,
+    FISCAL_TAX_ID_FIELDS,
+    TAX_BASE_TYPE_PERCENT,
+    TAX_DOMAIN_ICMS,
+)
+from ..constants.icms import (
+    ICMS_BASE_TYPE_DEFAULT,
+    ICMS_ORIGIN_DEFAULT,
+    ICMS_ST_BASE_TYPE_DEFAULT,
+)
 
 
 class FiscalDocumentLineMixinMethods(models.AbstractModel):
@@ -81,6 +59,23 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
         Inject common fiscal fields into view placeholder elements.
         Used for invoice line, sale order line, purchase order line...
         """
+
+        # the list of computed fields we will add to the view when missing
+        missing_line_fields = set(
+            [
+                fname
+                for fname, _field in filter(
+                    lambda item: item[1].compute
+                    in (
+                        "_compute_tax_fields",
+                        "_compute_fiscal_tax_ids",
+                        "_compute_product_fiscal_fields",
+                    ),
+                    self.env["l10n_br_fiscal.document.line.mixin"]._fields.items(),
+                )
+            ]
+        )
+
         fiscal_view = self.env.ref(
             "l10n_br_fiscal.document_fiscal_line_mixin_form"
         ).sudo()
@@ -129,13 +124,19 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
                         e.attrib["name"] for e in target_node if e.tag == "field"
                     ]
                     for fiscal_node in fiscal_nodes:
+                        if fiscal_node.attrib["name"] in missing_line_fields:
+                            missing_line_fields.remove(fiscal_node.attrib["name"])
                         if fiscal_node.attrib["name"] in existing_fields:
                             continue
                         field = deepcopy(fiscal_node)
                         if not field.attrib.get("optional"):
-                            field.attrib["invisible"] = "0"
                             field.attrib["optional"] = "hide"
                         target_node.append(field)
+                    for fname in missing_line_fields:
+                        if fname not in existing_fields:
+                            target_node.append(
+                                E.field(name=fname, string=fname, optional="hide")
+                            )
         return doc
 
     @api.model
@@ -146,23 +147,22 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
         return arch, view
 
     @api.depends(
-        "fiscal_price",
         "discount_value",
-        "insurance_value",
-        "other_value",
-        "freight_value",
-        "fiscal_quantity",
         "amount_tax_not_included",
-        "amount_tax_included",
         "amount_tax_withholding",
-        "uot_id",
-        "product_id",
-        "partner_id",
-        "company_id",
         "price_unit",
         "quantity",
-        "icms_relief_id",
         "fiscal_operation_line_id",
+        "cfop_id",
+        "icms_relief_value",
+        "insurance_value",
+        "other_value",
+        "freight_value",
+        "pis_value",
+        "cofins_value",
+        "icms_value",
+        "ii_value",
+        "ii_customhouse_charges",
     )
     def _compute_fiscal_amounts(self):
         for record in self:
@@ -171,11 +171,11 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
             # Total value of products or services
             record.price_gross = round_curr.round(record.price_unit * record.quantity)
             record.amount_fiscal = record.price_gross - record.discount_value
-            record.amount_tax = record.amount_tax_not_included
+            record.fiscal_amount_tax = record.amount_tax_not_included
 
             add_to_amount = sum(record[a] for a in record._add_fields_to_amount())
             rm_to_amount = sum(record[r] for r in record._rm_fields_to_amount())
-            record.amount_untaxed = (
+            record.fiscal_amount_untaxed = (
                 record.price_gross
                 - record.discount_value
                 + add_to_amount
@@ -183,13 +183,17 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
             )
 
             # Valor do documento (NF)
-            record.amount_total = record.amount_untaxed + record.amount_tax
+            record.fiscal_amount_total = (
+                record.fiscal_amount_untaxed + record.fiscal_amount_tax
+            )
 
             # Valor Liquido (TOTAL + IMPOSTOS - RETENÇÕES)
-            record.amount_taxed = record.amount_total - record.amount_tax_withholding
+            record.amount_taxed = (
+                record.fiscal_amount_total - record.amount_tax_withholding
+            )
 
             # Valor do documento (NF) - RETENÇÕES
-            record.amount_total = record.amount_taxed
+            record.fiscal_amount_total = record.amount_taxed
 
             # Valor financeiro
             if (
@@ -206,7 +210,7 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
                 record.financial_total_gross = record.financial_total = 0.0
                 record.financial_discount_value = 0.0
 
-    @api.depends("tax_icms_or_issqn", "partner_is_public_entity")
+    @api.depends("tax_icms_or_issqn", "partner_id")
     def _compute_allow_csll_irpj(self):
         """Calculates the possibility of 'CSLL' and 'IRPJ' tax charges."""
         for line in self:
@@ -233,82 +237,63 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
             return {f"default_{k}": vals[k] for k in vals.keys()}
         return vals
 
-    @api.onchange("fiscal_operation_id", "company_id", "partner_id", "product_id")
-    def _onchange_fiscal_operation_id(self):
-        if self.fiscal_operation_id:
-            self.fiscal_operation_line_id = self.fiscal_operation_id.line_definition(
-                company=self.company_id,
-                partner=self._get_fiscal_partner(),
-                product=self.product_id,
-            )
+    @api.depends("fiscal_operation_id", "partner_id", "product_id")
+    def _compute_fiscal_operation_line_id(self):
+        for line in self:
+            if line.fiscal_operation_id:
+                line.fiscal_operation_line_id = (
+                    line.fiscal_operation_id.line_definition(
+                        company=line.company_id,
+                        partner=line.partner_id,
+                        product=line.product_id,
+                    )
+                )
 
-    def _get_fiscal_tax_ids_dependencies(self):
-        """
-        Dynamically get the list of fields dependencies, overriden in l10n_br_purchase.
-        """
-        return [
-            "company_id",
-            "partner_id",
-            "fiscal_operation_line_id",
-            "product_id",
-            "ncm_id",
-            "nbs_id",
-            "nbm_id",
-            "cest_id",
-            "city_taxation_code_id",
-            "service_type_id",
-            "ind_final",
-        ]
-
-    @api.depends(lambda self: self._get_fiscal_tax_ids_dependencies())
+    @api.depends(
+        "partner_id",
+        "fiscal_operation_line_id",
+        "product_id",
+        "ncm_id",
+        "nbs_id",
+        "nbm_id",
+        "cest_id",
+        "city_taxation_code_id",
+        "service_type_id",
+        "ind_final",
+    )
     def _compute_fiscal_tax_ids(self):
-        """
-        Use fiscal_operation_line_id to map and compute the applicable Brazilian taxes.
-
-        Among the dependencies, company_id, partner_id and ind_final are related
-        to the fiscal document/line container. When called from account.move.line
-        via _inherits on newID records, we read these values from the related aml
-        to work around and _inherits/precompute limitation.
-        """
-        if self._context.get("skip_compute_fiscal_tax_ids"):
-            return
         for line in self:
-            if hasattr(line, "account_line_ids") and line.account_line_ids:
-                # it seems Odoo 16 ORM has a limitation when line is an
-                # l10n_br_fiscal.document.line that is edited via an account.move.line
-                # form and when both are a newID, then line relational field might be
-                # empty here. But in this case, we detect it and we wrap it back in the
-                wrapped_line = line.account_line_ids[0]
-            else:
-                wrapped_line = line
-
-            if wrapped_line.fiscal_operation_line_id:
-                mapping_result = wrapped_line.fiscal_operation_line_id.map_fiscal_taxes(
-                    company=wrapped_line.company_id,
-                    partner=wrapped_line._get_fiscal_partner(),
-                    product=wrapped_line.product_id,
-                    ncm=wrapped_line.ncm_id,
-                    nbm=wrapped_line.nbm_id,
-                    nbs=wrapped_line.nbs_id,
-                    cest=wrapped_line.cest_id,
-                    city_taxation_code=wrapped_line.city_taxation_code_id,
-                    service_type=wrapped_line.service_type_id,
-                    ind_final=wrapped_line.ind_final,
+            if line.fiscal_operation_line_id:
+                mapping_result = line.fiscal_operation_line_id.map_fiscal_taxes(
+                    company=line.company_id,
+                    partner=line._get_fiscal_partner(),
+                    product=line.product_id,
+                    ncm=line.ncm_id,
+                    nbm=line.nbm_id,
+                    nbs=line.nbs_id,
+                    cest=line.cest_id,
+                    city_taxation_code=line.city_taxation_code_id,
+                    service_type=line.service_type_id,
+                    ind_final=line.ind_final,
                 )
                 line.cfop_id = mapping_result["cfop"]
                 line.ipi_guideline_id = mapping_result["ipi_guideline"]
                 line.icms_tax_benefit_id = mapping_result["icms_tax_benefit_id"]
-                if wrapped_line._is_imported():
-                    return
+
+                if line._is_imported():
+                    continue
 
                 taxes = line.env["l10n_br_fiscal.tax"]
                 for tax in mapping_result["taxes"].values():
                     taxes |= tax
                 line.fiscal_tax_ids = taxes
-                line.comment_ids = line.fiscal_operation_line_id.comment_ids
 
-            else:
-                line.fiscal_tax_ids = [Command.clear()]
+    @api.depends("fiscal_operation_line_id")
+    def _compute_comment_ids(self):
+        for line in self:
+            line.comment_ids = [
+                Command.set(line.fiscal_operation_line_id.comment_ids.ids)
+            ]
 
     @api.model
     def _build_null_mask_dict(self) -> dict:
@@ -326,85 +311,115 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
             mask_dict[fiscal_tax_field] = False
         return mask_dict
 
-    def _get_tax_fields_dependencies(self):
-        """
-        Dynamically get the list of fields dependencies, overriden in l10n_br_purchase.
-        """
-        # IMPORTANT NOTE: as _compute_fiscal_tax_ids triggers _compute_tax_fields,
-        # we don't put fields that trigger _compute_fiscal_tax_ids as dependencies here.
-        return [
-            "price_unit",
-            "quantity",
-            "uom_id",
-            "fiscal_price",
-            "fiscal_quantity",
-            "uot_id",
-            "discount_value",
-            "insurance_value",
-            "ii_customhouse_charges",
-            "ii_iof_value",
-            "other_value",
-            "freight_value",
-            "cfop_id",
-            "icmssn_range_id",
-            "icms_origin",
-            "icms_cst_id",
-            "icms_relief_id",
-            "fiscal_tax_ids",
-        ]
-
-    @api.depends(lambda self: self._get_tax_fields_dependencies())
+    def write(self, vals):
+        res = super().write(vals)
+
+        # Verifica se algum campo de imposto relevante foi alterado no 'write'
+        tax_fields_in_vals = [fld for fld in vals if fld in FISCAL_TAX_ID_FIELDS]
+
+        if tax_fields_in_vals:
+            # Por segurança, sempre recalcula se um campo relevante mudou.
+            self._update_fiscal_tax_ids()
+
+        return res
+
+    def _update_fiscal_tax_ids(self):
+        taxes = self.env["l10n_br_fiscal.tax"]
+        for fiscal_tax_field in FISCAL_TAX_ID_FIELDS:
+            taxes |= self[fiscal_tax_field]
+
+        for line in self:
+            taxes_groups = line.fiscal_tax_ids.mapped("tax_domain")
+            fiscal_taxes = line.fiscal_tax_ids.filtered(
+                lambda ft, taxes_groups=taxes_groups: ft.tax_domain not in taxes_groups
+            )
+            line.fiscal_tax_ids = fiscal_taxes + taxes
+
+    @api.onchange(*FISCAL_TAX_ID_FIELDS)
+    def _onchange_fiscal_taxes(self):
+        self._update_fiscal_tax_ids()
+
+    @api.depends(
+        "partner_id",
+        "fiscal_tax_ids",
+        "product_id",
+        "price_unit",
+        "quantity",
+        "uom_id",
+        "fiscal_price",
+        "fiscal_quantity",
+        "uot_id",
+        "discount_value",
+        "insurance_value",
+        "ii_customhouse_charges",
+        "ii_iof_value",
+        "other_value",
+        "freight_value",
+        "ncm_id",
+        "nbs_id",
+        "nbm_id",
+        "cest_id",
+        "fiscal_operation_line_id",
+        "cfop_id",
+        "icmssn_range_id",
+        "icms_origin",
+        "icms_cst_id",
+        "ind_final",
+        "icms_relief_id",
+    )
     def _compute_tax_fields(self):
         """
         Compute base, percent, value... tax fields for ICMS, IPI, PIS, COFINS... taxes.
         """
-        if self._context.get("skip_compute_tax_fields"):
-            return
-
         null_mask = None
         for line in self.filtered(lambda line: not line._is_imported()):
-            if hasattr(line, "account_line_ids") and line.account_line_ids:
-                # it seems Odoo 16 ORM has a limitation when line is an
-                # l10n_br_fiscal.document.line that is edited via an account.move.line
-                # form and when both are a newID, then line relational field might be
-                # empty here. But in this case, we detect it and we wrap it back in the
-                wrapped_line = line.account_line_ids[0]
-            else:
-                wrapped_line = line
-
             if null_mask is None:
                 null_mask = self._build_null_mask_dict()
             to_update = null_mask.copy()
-            if wrapped_line.fiscal_operation_line_id:
-                compute_result = wrapped_line.fiscal_tax_ids.compute_taxes(
-                    company=wrapped_line.company_id,
-                    partner=wrapped_line._get_fiscal_partner(),
-                    product=wrapped_line.product_id,
-                    price_unit=wrapped_line.price_unit,
-                    quantity=wrapped_line.quantity,
-                    uom_id=wrapped_line.uom_id,
-                    fiscal_price=wrapped_line.fiscal_price,
-                    fiscal_quantity=wrapped_line.fiscal_quantity,
-                    uot_id=wrapped_line.uot_id,
-                    discount_value=wrapped_line.discount_value,
-                    insurance_value=wrapped_line.insurance_value,
-                    ii_customhouse_charges=wrapped_line.ii_customhouse_charges,
-                    ii_iof_value=wrapped_line.ii_iof_value,
-                    other_value=wrapped_line.other_value,
-                    freight_value=wrapped_line.freight_value,
-                    ncm=wrapped_line.ncm_id,
-                    nbs=wrapped_line.nbs_id,
-                    nbm=wrapped_line.nbm_id,
-                    cest=wrapped_line.cest_id,
-                    operation_line=wrapped_line.fiscal_operation_line_id,
-                    cfop=wrapped_line.cfop_id,
-                    icmssn_range=wrapped_line.icmssn_range_id,
-                    icms_origin=wrapped_line.icms_origin,
-                    icms_cst_id=wrapped_line.icms_cst_id,
-                    ind_final=wrapped_line.ind_final,
-                    icms_relief_id=wrapped_line.icms_relief_id,
+            # prepare with default values
+            to_update.update(
+                {
+                    "icms_base_type": ICMS_BASE_TYPE_DEFAULT,
+                    "icmsst_base_type": ICMS_ST_BASE_TYPE_DEFAULT,
+                    "ipi_base_type": TAX_BASE_TYPE_PERCENT,
+                    "cofins_base_type": TAX_BASE_TYPE_PERCENT,
+                    "cofinsst_base_type": TAX_BASE_TYPE_PERCENT,
+                    "cofins_wh_base_type": TAX_BASE_TYPE_PERCENT,
+                    "pis_base_type": TAX_BASE_TYPE_PERCENT,
+                    "pisst_base_type": TAX_BASE_TYPE_PERCENT,
+                    "pis_wh_base_type": TAX_BASE_TYPE_PERCENT,
+                }
+            )
+            if line.fiscal_operation_line_id:
+                compute_result = line.fiscal_tax_ids.compute_taxes(
+                    company=line.company_id,
+                    partner=line._get_fiscal_partner(),
+                    product=line.product_id,
+                    price_unit=line.price_unit,
+                    quantity=line.quantity,
+                    uom_id=line.uom_id,
+                    fiscal_price=line.fiscal_price,
+                    fiscal_quantity=line.fiscal_quantity,
+                    uot_id=line.uot_id,
+                    discount_value=line.discount_value,
+                    insurance_value=line.insurance_value,
+                    ii_customhouse_charges=line.ii_customhouse_charges,
+                    ii_iof_value=line.ii_iof_value,
+                    other_value=line.other_value,
+                    freight_value=line.freight_value,
+                    ncm=line.ncm_id,
+                    nbs=line.nbs_id,
+                    nbm=line.nbm_id,
+                    cest=line.cest_id,
+                    operation_line=line.fiscal_operation_line_id,
+                    cfop=line.cfop_id,
+                    icmssn_range=line.icmssn_range_id,
+                    icms_origin=line.icms_origin,
+                    icms_cst_id=line.icms_cst_id,
+                    ind_final=line.ind_final,
+                    icms_relief_id=line.icms_relief_id,
                 )
-                to_update.update(wrapped_line._prepare_tax_fields(compute_result))
+                to_update.update(line._prepare_tax_fields(compute_result))
             else:
                 compute_result = {}
             to_update.update(
@@ -419,11 +434,11 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
                     "estimate_tax": compute_result.get("estimate_tax", 0.0),
                 }
             )
-            in_draft_mode = wrapped_line != wrapped_line._origin
+            in_draft_mode = line != line._origin
             if in_draft_mode:
-                wrapped_line.update(to_update)
+                line.update(to_update)
             else:
-                wrapped_line.write(to_update)
+                line.write(to_update)
 
     def _prepare_tax_fields(self, compute_result):
         self.ensure_one()
@@ -454,6 +469,10 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
                 "cost_price": line.product_id.standard_price,
             }.get(line.fiscal_operation_id.default_price_unit, 0)
 
+    def _get_document(self):
+        self.ensure_one()
+        return self.document_id
+
     def _get_fiscal_partner(self):
         """
         Meant to be overriden when the l10n_br_fiscal.document partner_id should not
@@ -465,48 +484,47 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
         self.ensure_one()
         return self.partner_id
 
-    @api.onchange("product_id")
-    def _onchange_product_id_fiscal(self):
-        if not self.fiscal_operation_id:
-            return
-        if self.product_id:
-            self.name = self.product_id.display_name
-            self.fiscal_type = self.product_id.fiscal_type
-            self.uom_id = self.product_id.uom_id
-            self.ncm_id = self.product_id.ncm_id
-            self.nbm_id = self.product_id.nbm_id
-            self.tax_icms_or_issqn = self.product_id.tax_icms_or_issqn
-            self.icms_origin = self.product_id.icms_origin
-            self.cest_id = self.product_id.cest_id
-            self.nbs_id = self.product_id.nbs_id
-            self.fiscal_genre_id = self.product_id.fiscal_genre_id
-            self.service_type_id = self.product_id.service_type_id
-            self.uot_id = self.product_id.uot_id or self.product_id.uom_id
-            if self.product_id.city_taxation_code_ids:
-                company_city_id = self.company_id.city_id
-                city_id = self.product_id.city_taxation_code_ids.filtered(
-                    lambda r: r.city_id == company_city_id
-                )
-                if city_id:
-                    self.city_taxation_code_id = city_id
-                    self.issqn_fg_city_id = company_city_id
-        else:
-            self.name = False
-            self.fiscal_type = False
-            self.uom_id = False
-            self.ncm_id = False
-            self.nbm_id = False
-            self.tax_icms_or_issqn = False
-            self.icms_origin = False
-            self.cest_id = False
-            self.nbs_id = False
-            self.fiscal_genre_id = False
-            self.service_type_id = False
-            self.city_taxation_code_id = False
-            self.uot_id = False
-
-        self._compute_price_unit_fiscal()
-        self._onchange_fiscal_operation_id()
+    @api.depends("product_id")
+    def _compute_product_fiscal_fields(self):
+        for line in self:
+            if not line.product_id:
+                # reset to default values:
+                line.fiscal_type = False
+                line.ncm_id = False
+                line.nbm_id = False
+                line.tax_icms_or_issqn = TAX_DOMAIN_ICMS
+                line.icms_origin = ICMS_ORIGIN_DEFAULT
+                line.cest_id = False
+                line.nbs_id = False
+                line.fiscal_genre_id = False
+                line.service_type_id = False
+                continue
+            p = line.product_id
+            line.fiscal_type = p.fiscal_type
+            line.ncm_id = p.ncm_id
+            line.nbm_id = p.nbm_id
+            line.tax_icms_or_issqn = p.tax_icms_or_issqn
+            line.icms_origin = p.icms_origin
+            line.cest_id = p.cest_id
+            line.nbs_id = p.nbs_id
+            line.fiscal_genre_id = p.fiscal_genre_id
+            line.service_type_id = p.service_type_id
+
+    @api.depends("product_id")
+    def _compute_city_taxation_code_id(self):
+        for line in self:
+            if not line.product_id:
+                line.city_taxation_code_id = False
+                continue
+            company_city = line.company_id.city_id
+            city_tax_codes = line.product_id.city_taxation_code_ids
+            city_tax_code = city_tax_codes.filtered(
+                lambda r, _city_id=company_city: r.city_id == _city_id
+            )
+            if city_tax_code:
+                line.city_taxation_code_id = city_tax_code
+            else:
+                line.city_taxation_code_id = False
 
     def _prepare_fields_issqn(self, tax_dict):
         self.ensure_one()
@@ -749,68 +767,31 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
             "cofinsst_value": tax_dict.get("tax_value", 0.00),
         }
 
-    @api.onchange(*FISCAL_TAX_ID_FIELDS)
-    def _onchange_fiscal_taxes(self):
-        taxes = self.env["l10n_br_fiscal.tax"]
-        for fiscal_tax_field in FISCAL_TAX_ID_FIELDS:
-            taxes |= self[fiscal_tax_field]
-
-        for line in self:
-            taxes_groups = line.fiscal_tax_ids.mapped("tax_domain")
-            fiscal_taxes = line.fiscal_tax_ids.filtered(
-                lambda ft, taxes_groups=taxes_groups: ft.tax_domain not in taxes_groups
-            )
-            line.fiscal_tax_ids = fiscal_taxes + taxes
-
-    @api.depends("uom_id")
+    @api.depends("product_id", "uom_id")
     def _compute_uot_id(self):
         for line in self:
-            if not line.uot_id:
-                line.uot_id = line.uom_id
-
-    @api.onchange("price_unit")
-    def _onchange_price_unit_fiscal(self):
-        self.fiscal_price = 0
-        self._compute_fiscal_price()
+            p = line.product_id
+            line.uot_id = (p.uot_id if p else False) or line.uom_id
 
     @api.depends("price_unit")
     def _compute_fiscal_price(self):
         for line in self:
-            # this test and the onchange are required to avoid
-            # resetting manual changes in fiscal_price
-            if not line.fiscal_price:
-                if line.product_id and line.price_unit:
-                    line.fiscal_price = line.price_unit / (
-                        line.product_id.uot_factor or 1.0
-                    )
-                else:
-                    line.fiscal_price = line.price_unit
-
-    @api.onchange("quantity")
-    def _onchange_quantity_fiscal(self):
-        self.fiscal_quantity = 0
-        self._compute_fiscal_quantity()
+            if line.product_id and line.price_unit:
+                line.fiscal_price = line.price_unit / (
+                    line.product_id.uot_factor or 1.0
+                )
+            else:
+                line.fiscal_price = line.price_unit
 
     @api.depends("quantity")
     def _compute_fiscal_quantity(self):
         for line in self:
-            # this test and the onchange are required to avoid
-            # resetting manual changes in fiscal_quantity
-            if not line.fiscal_quantity:
-                if line.product_id and line.quantity:
-                    line.fiscal_quantity = line.quantity * (
-                        line.product_id.uot_factor or 1.0
-                    )
-                else:
-                    line.fiscal_quantity = line.quantity
-
-    @api.onchange("city_taxation_code_id")
-    def _onchange_city_taxation_code_id(self):
-        if self.city_taxation_code_id:
-            self.cnae_id = self.city_taxation_code_id.cnae_id
-            self._onchange_fiscal_operation_id()
-            if self.city_taxation_code_id.city_id:
-                self.update({"issqn_fg_city_id": self.city_taxation_code_id.city_id})
+            if line.product_id and line.quantity:
+                line.fiscal_quantity = line.quantity * (
+                    line.product_id.uot_factor or 1.0
+                )
+            else:
+                line.fiscal_quantity = line.quantity
 
     @api.model
     def _add_fields_to_amount(self):