odoo-addon-l10n-br-fiscal 17.0.2.1.0__py3-none-any.whl → 17.0.3.1.0__py3-none-any.whl

odoo/addons/l10n_br_fiscal/models/document_line_mixin_methods.py

@@ -7,8 +7,12 @@ from lxml import etree
 
 from odoo import Command, api, models
 
-from ..constants.fiscal import CFOP_DESTINATION_EXPORT, FISCAL_IN
-from ..constants.icms import ICMS_BASE_TYPE_DEFAULT, ICMS_ST_BASE_TYPE_DEFAULT
+from ..constants.fiscal import CFOP_DESTINATION_EXPORT, FISCAL_IN, TAX_DOMAIN_ICMS
+from ..constants.icms import (
+    ICMS_BASE_TYPE_DEFAULT,
+    ICMS_ORIGIN_DEFAULT,
+    ICMS_ST_BASE_TYPE_DEFAULT,
+)
 
 FISCAL_TAX_ID_FIELDS = [
     "cofins_tax_id",
@@ -171,11 +175,11 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
             # Total value of products or services
             record.price_gross = round_curr.round(record.price_unit * record.quantity)
             record.amount_fiscal = record.price_gross - record.discount_value
-            record.amount_tax = record.amount_tax_not_included
+            record.fiscal_amount_tax = record.amount_tax_not_included
 
             add_to_amount = sum(record[a] for a in record._add_fields_to_amount())
             rm_to_amount = sum(record[r] for r in record._rm_fields_to_amount())
-            record.amount_untaxed = (
+            record.fiscal_amount_untaxed = (
                 record.price_gross
                 - record.discount_value
                 + add_to_amount
@@ -183,13 +187,17 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
             )
 
             # Valor do documento (NF)
-            record.amount_total = record.amount_untaxed + record.amount_tax
+            record.fiscal_amount_total = (
+                record.fiscal_amount_untaxed + record.fiscal_amount_tax
+            )
 
             # Valor Liquido (TOTAL + IMPOSTOS - RETENÇÕES)
-            record.amount_taxed = record.amount_total - record.amount_tax_withholding
+            record.amount_taxed = (
+                record.fiscal_amount_total - record.amount_tax_withholding
+            )
 
             # Valor do documento (NF) - RETENÇÕES
-            record.amount_total = record.amount_taxed
+            record.fiscal_amount_total = record.amount_taxed
 
             # Valor financeiro
             if (
@@ -305,11 +313,16 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
                 for tax in mapping_result["taxes"].values():
                     taxes |= tax
                 line.fiscal_tax_ids = taxes
-                line.comment_ids = line.fiscal_operation_line_id.comment_ids
-
             else:
                 line.fiscal_tax_ids = [Command.clear()]
 
+    @api.depends("fiscal_operation_line_id")
+    def _compute_comment_ids(self):
+        for line in self:
+            line.comment_ids = [
+                Command.set(line.fiscal_operation_line_id.comment_ids.ids)
+            ]
+
     @api.model
     def _build_null_mask_dict(self) -> dict:
         """
@@ -465,48 +478,50 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
         self.ensure_one()
         return self.partner_id
 
-    @api.onchange("product_id")
-    def _onchange_product_id_fiscal(self):
-        if not self.fiscal_operation_id:
+    @api.depends("product_id")
+    def _compute_product_fiscal_fields(self):
+        if self._context.get("skip_compute_product_fiscal_fields"):
             return
-        if self.product_id:
-            self.name = self.product_id.display_name
-            self.fiscal_type = self.product_id.fiscal_type
-            self.uom_id = self.product_id.uom_id
-            self.ncm_id = self.product_id.ncm_id
-            self.nbm_id = self.product_id.nbm_id
-            self.tax_icms_or_issqn = self.product_id.tax_icms_or_issqn
-            self.icms_origin = self.product_id.icms_origin
-            self.cest_id = self.product_id.cest_id
-            self.nbs_id = self.product_id.nbs_id
-            self.fiscal_genre_id = self.product_id.fiscal_genre_id
-            self.service_type_id = self.product_id.service_type_id
-            self.uot_id = self.product_id.uot_id or self.product_id.uom_id
-            if self.product_id.city_taxation_code_ids:
-                company_city_id = self.company_id.city_id
-                city_id = self.product_id.city_taxation_code_ids.filtered(
-                    lambda r: r.city_id == company_city_id
+        for line in self:
+            if not line.product_id:
+                # reset to default values:
+                line.fiscal_type = False
+                line.ncm_id = False
+                line.nbm_id = False
+                line.tax_icms_or_issqn = TAX_DOMAIN_ICMS
+                line.icms_origin = ICMS_ORIGIN_DEFAULT
+                line.cest_id = False
+                line.nbs_id = False
+                line.fiscal_genre_id = False
+                line.service_type_id = False
+                line.city_taxation_code_id = False
+                line.issqn_fg_city_id = False
+                continue
+
+            product = line.product_id
+            line.fiscal_type = product.fiscal_type
+            line.ncm_id = product.ncm_id
+            line.nbm_id = product.nbm_id
+            line.tax_icms_or_issqn = product.tax_icms_or_issqn
+            line.icms_origin = product.icms_origin
+            line.cest_id = product.cest_id
+            line.nbs_id = product.nbs_id
+            line.fiscal_genre_id = product.fiscal_genre_id
+            line.service_type_id = product.service_type_id
+            if product.city_taxation_code_ids and line.company_id:
+                city = product.city_taxation_code_ids.filtered(
+                    lambda r, current_line=line: r.city_id
+                    == current_line.company_id.city_id
                 )
-                if city_id:
-                    self.city_taxation_code_id = city_id
-                    self.issqn_fg_city_id = company_city_id
-        else:
-            self.name = False
-            self.fiscal_type = False
-            self.uom_id = False
-            self.ncm_id = False
-            self.nbm_id = False
-            self.tax_icms_or_issqn = False
-            self.icms_origin = False
-            self.cest_id = False
-            self.nbs_id = False
-            self.fiscal_genre_id = False
-            self.service_type_id = False
-            self.city_taxation_code_id = False
-            self.uot_id = False
-
-        self._compute_price_unit_fiscal()
-        self._onchange_fiscal_operation_id()
+                if city:
+                    line.city_taxation_code_id = city
+                    line.issqn_fg_city_id = line.company_id.city_id
+                else:
+                    line.city_taxation_code_id = False
+                    line.issqn_fg_city_id = False
+            else:
+                line.city_taxation_code_id = False
+                line.issqn_fg_city_id = False
 
     def _prepare_fields_issqn(self, tax_dict):
         self.ensure_one()
@@ -762,11 +777,18 @@ class FiscalDocumentLineMixinMethods(models.AbstractModel):
             )
             line.fiscal_tax_ids = fiscal_taxes + taxes
 
-    @api.depends("uom_id")
+    @api.depends("product_id", "uom_id")
     def _compute_uot_id(self):
         for line in self:
-            if not line.uot_id:
-                line.uot_id = line.uom_id
+            if line.uom_id:
+                line.uot_id = line.uom_id.id
+            elif line.product_id:
+                if line.product_id.uot_id:
+                    line.uot_id = line.product_id.uot_id.id
+                else:
+                    line.uot_id = line.product_id.uom_id.id
+            else:
+                line.uot_id = False
 
     @api.onchange("price_unit")
     def _onchange_price_unit_fiscal(self):

odoo/addons/l10n_br_fiscal/models/document_mixin.py

@@ -126,7 +126,7 @@ class FiscalDocumentMixin(models.AbstractModel):
         help="Amount without discount.",
     )
 
-    amount_untaxed = fields.Monetary(
+    fiscal_amount_untaxed = fields.Monetary(
         compute="_compute_fiscal_amount",
         store=True,
     )
@@ -394,12 +394,12 @@ class FiscalDocumentMixin(models.AbstractModel):
         store=True,
     )
 
-    amount_tax = fields.Monetary(
+    fiscal_amount_tax = fields.Monetary(
         compute="_compute_fiscal_amount",
         store=True,
     )
 
-    amount_total = fields.Monetary(
+    fiscal_amount_total = fields.Monetary(
         compute="_compute_fiscal_amount",
         store=True,
     )

odoo/addons/l10n_br_fiscal/models/document_mixin_methods.py

@@ -73,7 +73,8 @@ class FiscalDocumentMixinMethods(models.AbstractModel):
     def _get_amount_fields(self):
         """Get all fields with 'amount_' prefix"""
         fields = self.env["l10n_br_fiscal.document.mixin"]._fields.keys()
-        amount_fields = [f for f in fields if f.startswith("amount_")]
+        prefixes = ("amount_", "fiscal_amount_")
+        amount_fields = [f for f in fields if f.startswith(prefixes)]
         return amount_fields
 
     @api.depends("document_serie_id", "issuer")
@@ -198,152 +199,37 @@ class FiscalDocumentMixinMethods(models.AbstractModel):
             elif doc.comment_ids is None:
                 doc.comment_ids = []
 
-    def _inverse_amount_freight(self):
-        for record in self.filtered(lambda doc: doc._get_product_amount_lines()):
-            if (
+    def _distribute_amount_to_lines(self, amount_field_name, line_field_name):
+        for record in self:
+            if not (
                 record.delivery_costs == "total"
                 or record.force_compute_delivery_costs_by_total
             ):
-                amount_freight_value = record.amount_freight_value
-                if all(record._get_product_amount_lines().mapped("freight_value")):
-                    amount_freight_old = sum(
-                        record._get_product_amount_lines().mapped("freight_value")
-                    )
-                    for line in record._get_product_amount_lines()[:-1]:
-                        line.freight_value = amount_freight_value * (
-                            line.freight_value / amount_freight_old
-                        )
-                    record._get_product_amount_lines()[-1].freight_value = (
-                        amount_freight_value
-                        - sum(
-                            line.freight_value
-                            for line in record._get_product_amount_lines()[:-1]
-                        )
-                    )
-                else:
-                    amount_total = sum(
-                        record._get_product_amount_lines().mapped("price_gross")
+                continue
+            lines = record._get_product_amount_lines()
+            if not lines:
+                continue
+            amount_to_distribute = record[amount_field_name]
+            total_gross = sum(lines.mapped("price_gross"))
+            if total_gross > 0:
+                distributed_amount = 0
+                for line in lines[:-1]:
+                    proportional_amount = record.currency_id.round(
+                        amount_to_distribute * (line.price_gross / total_gross)
                     )
-                    for line in record._get_product_amount_lines()[:-1]:
-                        if line.price_gross and amount_total:
-                            line.freight_value = amount_freight_value * (
-                                line.price_gross / amount_total
-                            )
-                    record._get_product_amount_lines()[-1].freight_value = (
-                        amount_freight_value
-                        - sum(
-                            line.freight_value
-                            for line in record._get_product_amount_lines()[:-1]
-                        )
-                    )
-                for line in record._get_product_amount_lines():
-                    line._onchange_fiscal_taxes()
-                record._fields["amount_total"].compute_value(record)
-                record.write(
-                    {
-                        name: value
-                        for name, value in record._cache.items()
-                        if record._fields[name].compute == "_amount_all"
-                        and not record._fields[name].inverse
-                    }
-                )
+                    line[line_field_name] = proportional_amount
+                    distributed_amount += proportional_amount
+                lines[-1][line_field_name] = amount_to_distribute - distributed_amount
+            else:
+                lines.write({line_field_name: 0.0})
+                if lines:
+                    lines[0][line_field_name] = amount_to_distribute
+
+    def _inverse_amount_freight(self):
+        self._distribute_amount_to_lines("amount_freight_value", "freight_value")
 
     def _inverse_amount_insurance(self):
-        for record in self.filtered(lambda doc: doc._get_product_amount_lines()):
-            if (
-                record.delivery_costs == "total"
-                or record.force_compute_delivery_costs_by_total
-            ):
-                amount_insurance_value = record.amount_insurance_value
-                if all(record._get_product_amount_lines().mapped("insurance_value")):
-                    amount_insurance_old = sum(
-                        record._get_product_amount_lines().mapped("insurance_value")
-                    )
-                    for line in record._get_product_amount_lines()[:-1]:
-                        line.insurance_value = amount_insurance_value * (
-                            line.insurance_value / amount_insurance_old
-                        )
-                    record._get_product_amount_lines()[-1].insurance_value = (
-                        amount_insurance_value
-                        - sum(
-                            line.insurance_value
-                            for line in record._get_product_amount_lines()[:-1]
-                        )
-                    )
-                else:
-                    amount_total = sum(
-                        record._get_product_amount_lines().mapped("price_gross")
-                    )
-                    for line in record._get_product_amount_lines()[:-1]:
-                        if line.price_gross and amount_total:
-                            line.insurance_value = amount_insurance_value * (
-                                line.price_gross / amount_total
-                            )
-                    record._get_product_amount_lines()[-1].insurance_value = (
-                        amount_insurance_value
-                        - sum(
-                            line.insurance_value
-                            for line in record._get_product_amount_lines()[:-1]
-                        )
-                    )
-                for line in record._get_product_amount_lines():
-                    line._onchange_fiscal_taxes()
-                record._fields["amount_total"].compute_value(record)
-                record.write(
-                    {
-                        name: value
-                        for name, value in record._cache.items()
-                        if record._fields[name].compute == "_amount_all"
-                        and not record._fields[name].inverse
-                    }
-                )
+        self._distribute_amount_to_lines("amount_insurance_value", "insurance_value")
 
     def _inverse_amount_other(self):
-        for record in self.filtered(lambda doc: doc._get_product_amount_lines()):
-            if (
-                record.delivery_costs == "total"
-                or record.force_compute_delivery_costs_by_total
-            ):
-                amount_other_value = record.amount_other_value
-                if all(record._get_product_amount_lines().mapped("other_value")):
-                    amount_other_old = sum(
-                        record._get_product_amount_lines().mapped("other_value")
-                    )
-                    for line in record._get_product_amount_lines()[:-1]:
-                        line.other_value = amount_other_value * (
-                            line.other_value / amount_other_old
-                        )
-                    record._get_product_amount_lines()[-1].other_value = (
-                        amount_other_value
-                        - sum(
-                            line.other_value
-                            for line in record._get_product_amount_lines()[:-1]
-                        )
-                    )
-                else:
-                    amount_total = sum(
-                        record._get_product_amount_lines().mapped("price_gross")
-                    )
-                    for line in record._get_product_amount_lines()[:-1]:
-                        if line.price_gross and amount_total:
-                            line.other_value = amount_other_value * (
-                                line.price_gross / amount_total
-                            )
-                    record._get_product_amount_lines()[-1].other_value = (
-                        amount_other_value
-                        - sum(
-                            line.other_value
-                            for line in record._get_product_amount_lines()[:-1]
-                        )
-                    )
-                for line in record._get_product_amount_lines():
-                    line._onchange_fiscal_taxes()
-                record._fields["amount_total"].compute_value(record)
-                record.write(
-                    {
-                        name: value
-                        for name, value in record._cache.items()
-                        if record._fields[name].compute == "_amount_all"
-                        and not record._fields[name].inverse
-                    }
-                )
+        self._distribute_amount_to_lines("amount_other_value", "other_value")

odoo/addons/l10n_br_fiscal/models/document_related.py

@@ -104,7 +104,7 @@ class DocumentRelated(models.Model):
             return False
 
         self.document_type_id = related.document_type_id
-        self.document_total_amount = related.amount_total
+        self.document_total_amount = related.fiscal_amount_total
         self.document_total_weight = related.total_weight
 
         if related.document_type_id.electronic:

odoo/addons/l10n_br_fiscal/security/ir.model.access.csv

@@ -67,7 +67,7 @@
 "l10n_br_fiscal_operation_line_manager","Fiscal Operation Line for Manager","model_l10n_br_fiscal_operation_line","l10n_br_fiscal.group_manager",1,1,1,1
 "l10n_br_fiscal_operation_document_type_user","Fiscal Operation Document Type for User","model_l10n_br_fiscal_operation_document_type","l10n_br_fiscal.group_user",1,0,0,0
 "l10n_br_fiscal_operation_document_type_manager","Fiscal Operation Document Type for Manager","model_l10n_br_fiscal_operation_document_type","l10n_br_fiscal.group_manager",1,1,1,1
-"l10n_br_fiscal_partner_profile_user","Fiscal Partner Profile for User","model_l10n_br_fiscal_partner_profile","l10n_br_fiscal.group_user",1,0,0,0
+"l10n_br_fiscal_partner_profile_user","Fiscal Partner Profile for User","model_l10n_br_fiscal_partner_profile","base.group_user",1,0,0,0
 "l10n_br_fiscal_partner_profile_manager","Fiscal Partner Profile for Manager","model_l10n_br_fiscal_partner_profile","l10n_br_fiscal.group_manager",1,1,1,1
 "l10n_br_fiscal_document_user","Fiscal Document for User","model_l10n_br_fiscal_document","l10n_br_fiscal.group_user",1,1,1,0
 "l10n_br_fiscal_document_manager","Fiscal Document for Manager","model_l10n_br_fiscal_document","l10n_br_fiscal.group_manager",1,1,1,1

odoo/addons/l10n_br_fiscal/static/description/index.html

@@ -372,7 +372,7 @@ ul.auto-toc {
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:486f72a947ff411ae1ec91ca2ada5d0f563c8421580c7d069ef01f3bbbd9b5f7
+!! source digest: sha256:a94263259afc7260a25f60fd10ada9ac820d816d2f4a157bb688764b76b7fe27
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
 <p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-brazil/tree/17.0/l10n_br_fiscal"><img alt="OCA/l10n-brazil" src="https://img.shields.io/badge/github-OCA%2Fl10n--brazil-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-brazil-17-0/l10n-brazil-17-0-l10n_br_fiscal"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-brazil&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p><img alt="image" src="https://raw.githubusercontent.com/OCA/l10n-brazil/17.0/l10n_br_fiscal/static/img/fiscal_dashboard.png" /></p>

odoo/addons/l10n_br_fiscal/tests/test_document_edition.py

@@ -12,6 +12,10 @@ class TestDocumentEdition(TransactionCase):
     def setUpClass(cls):
         super().setUpClass()
         cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
+        cls.user = cls.env.user
+        cls.company = cls.env.ref("l10n_br_base.empresa_lucro_presumido")
+        cls.user.company_ids |= cls.company
+        cls.user.company_id = cls.company.id
 
     def test_basic_doc_edition(self):
         doc_form = Form(
@@ -141,3 +145,112 @@ class TestDocumentEdition(TransactionCase):
         self.assertEqual(doc.fiscal_line_ids[0].fiscal_price, 112)
         self.assertEqual(doc.fiscal_line_ids[0].quantity, 10)
         self.assertEqual(doc.fiscal_line_ids[0].fiscal_quantity, 5)
+
+    def test_landed_costs_by_line_and_by_total(self):
+        """
+        Tests both landed cost scenarios: 'by line' and 'by total'.
+        1. By Line: Enters costs on lines and verifies the header totals.
+        2. By Total: Enters costs on the header and verifies lines distribution.
+        """
+        self.env.user.groups_id |= self.env.ref("l10n_br_fiscal.group_user")
+        product1 = self.env.ref("product.product_product_6")
+        product2 = self.env.ref("product.product_product_7")
+
+        # Part 1: Test with delivery_costs = 'line'
+        # ----------------------------------------------------
+        self.company.delivery_costs = "line"
+        doc_form = Form(self.env["l10n_br_fiscal.document"])
+        doc_form.company_id = self.company
+        doc_form.partner_id = self.env.ref("l10n_br_base.res_partner_cliente1_sp")
+        doc_form.fiscal_operation_id = self.env.ref("l10n_br_fiscal.fo_venda")
+
+        with doc_form.fiscal_line_ids.new() as line1:
+            line1.product_id = product1
+            line1.fiscal_operation_line_id = self.env.ref(
+                "l10n_br_fiscal.fo_venda_venda"
+            )
+            line1.price_unit = 1000.0
+            line1.quantity = 2.0  # Gross: 2000
+            line1.freight_value = 10.0
+            line1.insurance_value = 20.0
+            line1.other_value = 5.0
+
+        with doc_form.fiscal_line_ids.new() as line2:
+            line2.product_id = product2
+            line2.fiscal_operation_line_id = self.env.ref(
+                "l10n_br_fiscal.fo_venda_venda"
+            )
+            line2.price_unit = 500.0
+            line2.quantity = 1.0  # Gross: 500
+            line2.freight_value = 4.0
+            line2.insurance_value = 6.0
+            line2.other_value = 2.0
+
+        doc = doc_form.save()
+
+        self.assertEqual(doc.company_id.delivery_costs, "line")
+        # Assert header totals are the SUM of line values
+        self.assertAlmostEqual(doc.amount_freight_value, 14.0)  # 10.0 + 4.0
+        self.assertAlmostEqual(doc.amount_insurance_value, 26.0)  # 20.0 + 6.0
+        self.assertAlmostEqual(doc.amount_other_value, 7.0)  # 5.0 + 2.0
+
+        # Assert final fiscal totals (bottom-up calculation)
+        # price_gross = (1000*2) + (500*1) = 2500
+        # landed_costs = 14 + 26 + 7 = 47
+        # fiscal_amount_untaxed (IPI Base) = 2500 + 47 = 2547
+        self.assertAlmostEqual(doc.fiscal_amount_untaxed, 2547.00)
+        # fiscal_amount_tax (IPI) = (2035 * 3.25%) + (512 * 5%) = 66.14 + 25.60 = 91.74
+        self.assertAlmostEqual(doc.fiscal_amount_tax, 91.74, places=2)
+        # fiscal_amount_total = 2547.00 + 91.74 = 2638.74
+        self.assertAlmostEqual(doc.fiscal_amount_total, 2638.74, places=2)
+
+        # Part 2: Test with delivery_costs = 'total'
+        # ----------------------------------------------------
+        self.company.delivery_costs = "total"
+        doc_form_edit = Form(doc)
+        # Set new header totals, which should trigger inverse methods to distribute
+        doc_form_edit.amount_freight_value = 30.0
+        doc_form_edit.amount_insurance_value = 60.0
+        doc_form_edit.amount_other_value = 90.0
+        doc_after_total_update = doc_form_edit.save()
+
+        line1 = doc_after_total_update.fiscal_line_ids[0]
+        line2 = doc_after_total_update.fiscal_line_ids[1]
+
+        # Assert values were distributed proportionally to price_gross
+        # (2000 vs 500 -> 80% vs 20%)
+        # Freight: 30.0 * 0.8 = 24.0 | 30.0 * 0.2 = 6.0
+        self.assertAlmostEqual(line1.freight_value, 24.0)
+        self.assertAlmostEqual(line2.freight_value, 6.0)
+        # Insurance: 60.0 * 0.8 = 48.0 | 60.0 * 0.2 = 12.0
+        self.assertAlmostEqual(line1.insurance_value, 48.0)
+        self.assertAlmostEqual(line2.insurance_value, 12.0)
+        # Other: 90.0 * 0.8 = 72.0 | 90.0 * 0.2 = 18.0
+        self.assertAlmostEqual(line1.other_value, 72.0)
+        self.assertAlmostEqual(line2.other_value, 18.0)
+
+        # Assert final fiscal totals are recomputed correctly (top-down calculation)
+        # price_gross = 2500
+        # landed_costs = 30 + 60 + 90 = 180
+        # fiscal_amount_untaxed (IPI Base) = 2500 + 180 = 2680
+        self.assertAlmostEqual(doc_after_total_update.fiscal_amount_untaxed, 2680.00)
+        # Line 1 IPI Base = 2000 (product) + 24 (freight) + 48 (insurance)
+        # + 72 (other) = 2144
+        # Line 1 IPI Value = 2144 * 3.25% = 69.68
+        self.assertAlmostEqual(line1.ipi_base, 2144.00)
+        self.assertAlmostEqual(line1.ipi_value, 69.68, places=2)
+
+        # Line 2 IPI Base = 500 (product) + 6 (freight) + 12 (insurance)
+        # + 18 (other) = 536
+        # Line 2 IPI Value = 536 * 5% = 26.80
+        self.assertAlmostEqual(line2.ipi_base, 536.00)
+        self.assertAlmostEqual(line2.ipi_value, 26.80, places=2)
+
+        # fiscal_amount_tax (IPI) = 69.68 + 26.80 = 96.48
+        self.assertAlmostEqual(
+            doc_after_total_update.fiscal_amount_tax, 96.48, places=2
+        )
+        # fiscal_amount_total = 2680.00 + 96.48 = 2776.48
+        self.assertAlmostEqual(
+            doc_after_total_update.fiscal_amount_total, 2776.48, places=2
+        )

odoo/addons/l10n_br_fiscal/tests/test_fiscal_document_generic.py

@@ -40,8 +40,6 @@ class TestFiscalDocumentGeneric(TransactionCase):
     def test_nfe_same_state(self):
         """Test NFe same state."""
         for line in self.nfe_same_state.fiscal_line_ids:
-            line._onchange_product_id_fiscal()
-
             # Restore the original price_unit value,
             # as the product change might have altered it.
             line.price_unit = 100
@@ -163,7 +161,6 @@ class TestFiscalDocumentGeneric(TransactionCase):
     def test_nfe_other_state(self):
         """Test NFe other state."""
         for line in self.nfe_other_state.fiscal_line_ids:
-            line._onchange_product_id_fiscal()
             line._onchange_fiscal_operation_id()
             line._onchange_fiscal_taxes()
 
@@ -278,7 +275,6 @@ class TestFiscalDocumentGeneric(TransactionCase):
     def test_nfe_not_taxpayer(self):
         """Test NFe not taxpayer."""
         for line in self.nfe_not_taxpayer.fiscal_line_ids:
-            line._onchange_product_id_fiscal()
             line._onchange_fiscal_operation_id()
             line._onchange_fiscal_taxes()
 
@@ -380,7 +376,6 @@ class TestFiscalDocumentGeneric(TransactionCase):
     def test_nfe_not_taxpayer_not_company(self):
         """Test NFe not taxpayer not Company."""
         for line in self.nfe_not_taxpayer_pf.fiscal_line_ids:
-            line._onchange_product_id_fiscal()
             line._onchange_fiscal_operation_id()
             line._onchange_fiscal_taxes()
 
@@ -482,7 +477,6 @@ class TestFiscalDocumentGeneric(TransactionCase):
     def test_nfe_export(self):
         """Test NFe export."""
         for line in self.nfe_export.fiscal_line_ids:
-            line._onchange_product_id_fiscal()
             line._onchange_fiscal_operation_id()
             line._onchange_fiscal_taxes()
 
@@ -576,8 +570,6 @@ class TestFiscalDocumentGeneric(TransactionCase):
     def test_nfe_sn_same_state(self):
         """Test NFe Simples Nacional same state."""
         for line in self.nfe_sn_same_state.fiscal_line_ids:
-            line._onchange_product_id_fiscal()
-
             # set fake estimate tax
             line.ncm_id.tax_estimate_ids.create(
                 {
@@ -689,7 +681,6 @@ class TestFiscalDocumentGeneric(TransactionCase):
     def test_nfe_sn_other_state(self):
         """Test NFe SN other state."""
         for line in self.nfe_sn_other_state.fiscal_line_ids:
-            line._onchange_product_id_fiscal()
             line._onchange_fiscal_operation_id()
             line._onchange_fiscal_taxes()
 
@@ -787,7 +778,6 @@ class TestFiscalDocumentGeneric(TransactionCase):
     def test_nfe_sn_not_taxpayer(self):
         """Test NFe SN not taxpayer."""
         for line in self.nfe_sn_not_taxpayer.fiscal_line_ids:
-            line._onchange_product_id_fiscal()
             line._onchange_fiscal_operation_id()
             line._onchange_fiscal_taxes()
 
@@ -872,7 +862,6 @@ class TestFiscalDocumentGeneric(TransactionCase):
     def test_nfe_sn_export(self):
         """Test NFe SN export."""
         for line in self.nfe_sn_export.fiscal_line_ids:
-            line._onchange_product_id_fiscal()
             line._onchange_fiscal_operation_id()
             line._onchange_fiscal_taxes()
 

odoo/addons/l10n_br_fiscal/tests/test_fiscal_document_nfse.py

@@ -15,7 +15,6 @@ class TestFiscalDocumentNFSe(TransactionCase):
         """Test NFSe same state."""
 
         for line in self.nfse_same_state.fiscal_line_ids:
-            line._onchange_product_id_fiscal()
             line._onchange_fiscal_operation_id()
             line._onchange_fiscal_taxes()
 

odoo/addons/l10n_br_fiscal/tests/test_tax_benefit.py

@@ -40,7 +40,6 @@ class TestTaxBenefit(TransactionCase):
         """Test NFe with tax benefit."""
 
         for line in self.nfe_tax_benefit.fiscal_line_ids:
-            line._onchange_product_id_fiscal()
             line._onchange_fiscal_operation_id()
             line._onchange_fiscal_taxes()
 

odoo/addons/l10n_br_fiscal/views/document_line_view.xml

@@ -102,13 +102,13 @@
                     <page name="amounts" string="Amounts">
                         <group>
                             <group>
-                                <field name="amount_untaxed" />
+                                <field name="fiscal_amount_untaxed" />
                                 <field name="amount_fiscal" />
-                                <field name="amount_tax" />
+                                <field name="fiscal_amount_tax" />
                                 <field name="estimate_tax" />
                             </group>
                             <group>
-                                <field name="amount_total" />
+                                <field name="fiscal_amount_total" />
                                 <field name="amount_tax_withholding" />
                                 <field name="amount_taxed" />
                             </group>