odoo-addon-account-statement-import-sheet-file 16.0.1.1.1.2__py3-none-any.whl → 16.0.1.1.2__py3-none-any.whl

odoo/addons/account_statement_import_sheet_file/README.rst

@@ -7,7 +7,7 @@ Bank Statement TXT/CSV/XLSX Import
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:622f4de81eaea0676a7c563933b1d1a0d0eae98e7e22d882526af7b611ba3d50
+   !! source digest: sha256:52fd7c31d7753fa4ea912b113bfc30c98f54839022ff9071e6b4604483f28f30
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png

odoo/addons/account_statement_import_sheet_file/__manifest__.py

@@ -5,7 +5,7 @@
 {
     "name": "Bank Statement TXT/CSV/XLSX Import",
     "summary": "Import TXT/CSV or XLSX files as Bank Statements in Odoo",
-    "version": "16.0.1.1.1",
+    "version": "16.0.1.1.2",
     "category": "Accounting",
     "website": "https://github.com/OCA/bank-statement-import",
     "author": "ForgeFlow, CorporateHub, Odoo Community Association (OCA)",

odoo/addons/account_statement_import_sheet_file/i18n/es.po

@@ -7,8 +7,8 @@ msgstr ""
 "Project-Id-Version: Odoo Server 15.0\n"
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2023-10-18 06:13+0000\n"
-"PO-Revision-Date: 2024-02-08 20:34+0000\n"
-"Last-Translator: Ivorra78 <informatica@totmaterial.es>\n"
+"PO-Revision-Date: 2024-05-12 21:35+0000\n"
+"Last-Translator: Sergio Ariel Ameghino <ariel.ameghino@gmail.com>\n"
 "Language-Team: none\n"
 "Language: es\n"
 "MIME-Version: 1.0\n"
@@ -606,7 +606,7 @@ msgstr "ninguno"
 #. module: account_statement_import_sheet_file
 #: model:ir.model.fields.selection,name:account_statement_import_sheet_file.selection__account_statement_import_sheet_mapping__float_thousands_sep__quote
 msgid "quote (')"
-msgstr ""
+msgstr "cita (')"
 
 #. module: account_statement_import_sheet_file
 #: model:ir.model.fields.selection,name:account_statement_import_sheet_file.selection__account_statement_import_sheet_mapping__delimiter__semicolon

odoo/addons/account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py

@@ -4,6 +4,8 @@
 
 import itertools
 import logging
+import math
+import re
 from collections.abc import Iterable
 from datetime import datetime
 from decimal import Decimal
@@ -83,8 +85,8 @@ class AccountStatementImportSheetParser(models.TransientModel):
             balance_end = last_line["balance"]
             data.update(
                 {
-                    "balance_start": float(balance_start),
-                    "balance_end_real": float(balance_end),
+                    "balance_start": balance_start,
+                    "balance_end_real": balance_end,
                 }
             )
         transactions = list(
@@ -336,14 +338,14 @@ class AccountStatementImportSheetParser(models.TransientModel):
                 balance = None
 
             if debit_credit is not None:
-                amount = amount.copy_abs()
+                amount = abs(amount)
                 if debit_credit == mapping.debit_value:
                     amount = -amount
 
             if original_amount:
-                original_amount = self._parse_decimal(
-                    original_amount, mapping
-                ).copy_sign(amount)
+                original_amount = math.copysign(
+                    self._parse_decimal(original_amount, mapping), amount
+                )
             else:
                 original_amount = 0.0
             if mapping.amount_inverse_sign:
@@ -457,11 +459,18 @@ class AccountStatementImportSheetParser(models.TransientModel):
     @api.model
     def _parse_decimal(self, value, mapping):
         if isinstance(value, Decimal):
-            return value
+            return float(value)
         elif isinstance(value, float):
-            return Decimal(value)
-        value = value or "0"
+            return value
         thousands, decimal = mapping._get_float_separators()
+        # Remove all characters except digits, thousands separator,
+        # decimal separator, and signs
+        value = (
+            re.sub(
+                r"[^\d\-+" + re.escape(thousands) + re.escape(decimal) + "]+", "", value
+            )
+            or "0"
+        )
         value = value.replace(thousands, "")
         value = value.replace(decimal, ".")
-        return Decimal(value)
+        return float(value)

odoo/addons/account_statement_import_sheet_file/static/description/index.html

@@ -366,7 +366,7 @@ ul.auto-toc {
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:622f4de81eaea0676a7c563933b1d1a0d0eae98e7e22d882526af7b611ba3d50
+!! source digest: sha256:52fd7c31d7753fa4ea912b113bfc30c98f54839022ff9071e6b4604483f28f30
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
 <p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/bank-statement-import/tree/16.0/account_statement_import_sheet_file"><img alt="OCA/bank-statement-import" src="https://img.shields.io/badge/github-OCA%2Fbank--statement--import-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_sheet_file"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/bank-statement-import&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module allows you to import any TXT/CSV or XLSX file in Odoo as bank

odoo/addons/account_statement_import_sheet_file/tests/test_account_statement_import_sheet_file.py

@@ -3,7 +3,9 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 from base64 import b64encode
+from decimal import Decimal
 from os import path
+from unittest.mock import Mock
 
 from odoo import fields
 from odoo.exceptions import UserError
@@ -45,6 +47,12 @@ class TestAccountStatementImportSheetFile(common.TransactionCase):
                 "account_type": "asset_current",
             }
         )
+        self.parser = self.env["account.statement.import.sheet.parser"]
+        # Mock the mapping object to return predefined separators
+        self.mock_mapping_comma_dot = Mock()
+        self.mock_mapping_comma_dot._get_float_separators.return_value = (",", ".")
+        self.mock_mapping_dot_comma = Mock()
+        self.mock_mapping_dot_comma._get_float_separators.return_value = (".", ",")
 
     def _data_file(self, filename, encoding=None):
         mode = "rt" if encoding else "rb"
@@ -538,3 +546,135 @@ class TestAccountStatementImportSheetFile(common.TransactionCase):
         line2 = statement.line_ids.filtered(lambda x: x.payment_ref == "LABEL 2")
         self.assertEqual(line2.amount, 1525.00)
         self.assertEqual(line2.amount_currency, 1000.00)
+
+    def test_import_xlsx_empty_values(self):
+        sample_statement_map_empty_values = (
+            self.AccountStatementImportSheetMapping.create(
+                {
+                    "name": "Sample Statement with empty values",
+                    "amount_type": "distinct_credit_debit",
+                    "float_decimal_sep": "comma",
+                    "delimiter": "n/a",
+                    "no_header": 0,
+                    "footer_lines_skip_count": 1,
+                    "amount_inverse_sign": 0,
+                    "header_lines_skip_count": 1,
+                    "quotechar": '"',
+                    "float_thousands_sep": "dot",
+                    "reference_column": "REF",
+                    "description_column": "DESCRIPTION",
+                    "amount_credit_column": "DEBIT",
+                    "amount_debit_column": "CREDIT",
+                    "balance_column": "BALANCE",
+                    "timestamp_format": "%d/%m/%Y",
+                    "timestamp_column": "DATE",
+                }
+            )
+        )
+        journal = self.AccountJournal.create(
+            {
+                "name": "Bank 2",
+                "type": "bank",
+                "code": "BAN2",
+                "currency_id": self.currency_usd.id,
+                "suspense_account_id": self.suspense_account.id,
+            }
+        )
+        data = self._data_file("fixtures/sample_statement_en_empty_values.xlsx")
+        wizard = self.AccountStatementImport.with_context(journal_id=journal.id).create(
+            {
+                "statement_filename": "fixtures/sample_statement_en_empty_values.xlsx",
+                "statement_file": data,
+                "sheet_mapping_id": sample_statement_map_empty_values.id,
+            }
+        )
+        wizard.with_context(
+            account_statement_import_sheet_file_test=True
+        ).import_file_button()
+        statement = self.AccountBankStatement.search([("journal_id", "=", journal.id)])
+        self.assertEqual(len(statement), 1)
+        self.assertEqual(len(statement.line_ids), 3)
+
+    def test_parse_decimal(self):
+        # Define a series of test cases
+        test_cases = [
+            (
+                "1,234.56",
+                1234.56,
+                self.mock_mapping_comma_dot,
+            ),  # standard case with thousands separator
+            (
+                "1,234,567.89",
+                1234567.89,
+                self.mock_mapping_comma_dot,
+            ),  # multiple thousands separators
+            (
+                "-1,234.56",
+                -1234.56,
+                self.mock_mapping_comma_dot,
+            ),  # negative value
+            (
+                "$1,234.56",
+                1234.56,
+                self.mock_mapping_comma_dot,
+            ),  # prefixed with currency symbol
+            (
+                "1,234.56 USD",
+                1234.56,
+                self.mock_mapping_comma_dot,
+            ),  # suffixed with currency code
+            (
+                "   1,234.56   ",
+                1234.56,
+                self.mock_mapping_comma_dot,
+            ),  # leading and trailing spaces
+            (
+                "not a number",
+                0,
+                self.mock_mapping_comma_dot,
+            ),  # non-numeric input
+            (" ", 0, self.mock_mapping_comma_dot),  # empty string
+            ("", 0, self.mock_mapping_comma_dot),  # empty space
+            ("USD", 0, self.mock_mapping_comma_dot),  # empty dolar
+            (
+                "12,34.56",
+                1234.56,
+                self.mock_mapping_comma_dot,
+            ),  # unusual thousand separator placement
+            (
+                "1234,567.89",
+                1234567.89,
+                self.mock_mapping_comma_dot,
+            ),  # missing one separator
+            (
+                "1234.567,89",
+                1234567.89,
+                self.mock_mapping_dot_comma,
+            ),  # inverted separators
+        ]
+
+        for value, expected, mock_mapping in test_cases:
+            with self.subTest(value=value):
+                result = self.parser._parse_decimal(value, mock_mapping)
+                self.assertEqual(result, expected, f"Failed for value: {value}")
+
+    def test_decimal_and_float_inputs(self):
+        # Test direct Decimal and float inputs
+        self.assertEqual(
+            self.parser._parse_decimal(-1234.56, self.mock_mapping_comma_dot),
+            -1234.56,
+        )
+        self.assertEqual(
+            self.parser._parse_decimal(1234.56, self.mock_mapping_comma_dot),
+            1234.56,
+        )
+        self.assertEqual(
+            self.parser._parse_decimal(
+                Decimal("-1234.56"), self.mock_mapping_comma_dot
+            ),
+            -1234.56,
+        )
+        self.assertEqual(
+            self.parser._parse_decimal(Decimal("1234.56"), self.mock_mapping_comma_dot),
+            1234.56,
+        )

{odoo_addon_account_statement_import_sheet_file-16.0.1.1.1.2.dist-info → odoo_addon_account_statement_import_sheet_file-16.0.1.1.2.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: odoo-addon-account-statement-import-sheet-file
-Version: 16.0.1.1.1.2
+Version: 16.0.1.1.2
 Summary: Import TXT/CSV or XLSX files as Bank Statements in Odoo
 Home-page: https://github.com/OCA/bank-statement-import
 Author: ForgeFlow, CorporateHub, Odoo Community Association (OCA)
@@ -26,7 +26,7 @@ Bank Statement TXT/CSV/XLSX Import
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:622f4de81eaea0676a7c563933b1d1a0d0eae98e7e22d882526af7b611ba3d50
+   !! source digest: sha256:52fd7c31d7753fa4ea912b113bfc30c98f54839022ff9071e6b4604483f28f30
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png

{odoo_addon_account_statement_import_sheet_file-16.0.1.1.1.2.dist-info → odoo_addon_account_statement_import_sheet_file-16.0.1.1.2.dist-info}/RECORD

@@ -1,9 +1,9 @@
-odoo/addons/account_statement_import_sheet_file/README.rst,sha256=yT4QE7ZzY9_sPFAqmU-cfNll6-QYZP7e3wdOmYFxNp8,4501
+odoo/addons/account_statement_import_sheet_file/README.rst,sha256=bntJdQ0pEAidWrx3OViFse6jsvQ870b4PtaybKYEZnM,4501
 odoo/addons/account_statement_import_sheet_file/__init__.py,sha256=X9EJGOE2GtZbS0G82PtSXmWSZ_R8jEM0rlJTDliQjp4,21
-odoo/addons/account_statement_import_sheet_file/__manifest__.py,sha256=AmS3qfWQ2I9C43eLgkEZVqP4HDGLzGZv0u_ygTVyKfc,934
+odoo/addons/account_statement_import_sheet_file/__manifest__.py,sha256=2rRWupnaApuJBz-mFe2Z-_7cEFx1IA4hqqEa4CpZ6EE,934
 odoo/addons/account_statement_import_sheet_file/data/map_data.xml,sha256=nz_4CchVMF9pb_SI4I6UZAt2IBPxWapX37lU6J6sTJ0,1225
 odoo/addons/account_statement_import_sheet_file/i18n/account_statement_import_sheet_file.pot,sha256=Xf56lTES-y5d_bliUsekQdwLRKZl6KhlilArFQXfziI,26423
-odoo/addons/account_statement_import_sheet_file/i18n/es.po,sha256=cPPNy1M24-extpf1qBavVkg_93eseH8RQN6-2osBsBw,31866
+odoo/addons/account_statement_import_sheet_file/i18n/es.po,sha256=r0dB7FwIyf4CnqrrUUwIoscwqY1oFjtLDHb8yaUyisw,31885
 odoo/addons/account_statement_import_sheet_file/i18n/es_AR.po,sha256=M0scXwemt20iY_usFw1x38I315Na5Hsl4PI-R7Nch1M,30172
 odoo/addons/account_statement_import_sheet_file/i18n/it.po,sha256=GtD-H3cuavdvEu5qxvevsCADm54pNdYPkQUvZYtQFgw,30838
 odoo/addons/account_statement_import_sheet_file/i18n/nl.po,sha256=OIfIbKptYzCICzo4vUiTYgYSfcMdQu_SxBbFEMFewzk,27321
@@ -15,7 +15,7 @@ odoo/addons/account_statement_import_sheet_file/models/__init__.py,sha256=RsEvd8
 odoo/addons/account_statement_import_sheet_file/models/account_journal.py,sha256=F4_deAvNErZ6o1gkw9uhDrEnHyWXUKNvk09mzCVzTIw,562
 odoo/addons/account_statement_import_sheet_file/models/account_statement_import.py,sha256=KWDYgO9-C1ZAF7JO9Qlq2ghROcJIwKhGp1CueTnA368,1932
 odoo/addons/account_statement_import_sheet_file/models/account_statement_import_sheet_mapping.py,sha256=KYZYk796CeNZ-j9GH8JC7QIEv2Osbn5jcV5pX1XUm18,8830
-odoo/addons/account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py,sha256=3kYbRDSMKETnAXOfwlv8NVFs1f5RePSLDkVryVoKlBI,17084
+odoo/addons/account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py,sha256=hxDQUv_CN9uXSWn4yvoj_iGsMQGMWQu1sbQcEq1y7sk,17335
 odoo/addons/account_statement_import_sheet_file/readme/CONFIGURE.rst,sha256=imX9sFGbzYnr4I07MZvHBZyyhBm8pLZ6AmpKNVY6zR4,213
 odoo/addons/account_statement_import_sheet_file/readme/CONTRIBUTORS.rst,sha256=IK3_tHCu2A5OhQq1TbYtOURyUOzywj7htdWpjbo07fw,469
 odoo/addons/account_statement_import_sheet_file/readme/DESCRIPTION.rst,sha256=lHrjCbQdpNU9QhA9vwxyRgJWJHk87YujRn6P8L2Ha3A,86
@@ -23,9 +23,9 @@ odoo/addons/account_statement_import_sheet_file/readme/HISTORY.rst,sha256=XHPod2
 odoo/addons/account_statement_import_sheet_file/readme/USAGE.rst,sha256=5wVe6CMUaGqAsE-yxAuc03YSxIFnRQ9mHeFkw-UBI68,184
 odoo/addons/account_statement_import_sheet_file/security/ir.model.access.csv,sha256=ofB5jVirJJ3FQ-uWfKFD-DIg8Lh9bYLaUDQWnb9MkgM,685
 odoo/addons/account_statement_import_sheet_file/static/description/icon.png,sha256=6xBPJauaFOF0KDHfHgQopSc28kKvxMaeoQFQWZtfZDo,9455
-odoo/addons/account_statement_import_sheet_file/static/description/index.html,sha256=6nZqmd006DVKW-MD4KGezPqw0PzoXJmgQv4jDBw3OEo,15285
+odoo/addons/account_statement_import_sheet_file/static/description/index.html,sha256=aXNBtq1kttPAYjdPypuvon9Ub9MhK08WsSqxufP6A1g,15285
 odoo/addons/account_statement_import_sheet_file/tests/__init__.py,sha256=f7vTpmONnfbbcMp5wZ1p7muSkyLC2vcDONaw2VGyiBw,121
-odoo/addons/account_statement_import_sheet_file/tests/test_account_statement_import_sheet_file.py,sha256=6B5XWNNefvnd4baSAOf3dDgn226mghxl4gQ4e0xY5bM,22328
+odoo/addons/account_statement_import_sheet_file/tests/test_account_statement_import_sheet_file.py,sha256=3V98ug6c9xjrSMMhUAk5bXWgBjjgmZzIkx0ttFju62g,27703
 odoo/addons/account_statement_import_sheet_file/tests/fixtures/balance.csv,sha256=-7VrGM_IbKhOJzbX-bUMIsnd99uDIBkalTytlj2jVtk,209
 odoo/addons/account_statement_import_sheet_file/tests/fixtures/debit_credit.csv,sha256=AaVQ9G5gqsLhxtAsYXCmFCTxpBPonKA1uxy7ue5gYYE,223
 odoo/addons/account_statement_import_sheet_file/tests/fixtures/debit_credit_amount.csv,sha256=y-VoBcF_7WaUZhnmOqSuCv7ElCKSHRbsqKWpCH49Ams,369
@@ -40,10 +40,11 @@ odoo/addons/account_statement_import_sheet_file/tests/fixtures/original_currency
 odoo/addons/account_statement_import_sheet_file/tests/fixtures/sample_statement_credit_card_inverse_sign_en.csv,sha256=19xKZlVxR6yqSGGC2WR6_YpBKfev6pMTMThENamE8DA,222
 odoo/addons/account_statement_import_sheet_file/tests/fixtures/sample_statement_en.csv,sha256=6WexRDEog728ur2DK7J_xI056FCrX5CkB-3xK6LixAM,265
 odoo/addons/account_statement_import_sheet_file/tests/fixtures/sample_statement_en.xlsx,sha256=eOpaIIiKh6hTE_ebGwCgIaJBpoehKEQAqrXjHiMklVQ,5101
+odoo/addons/account_statement_import_sheet_file/tests/fixtures/sample_statement_en_empty_values.xlsx,sha256=hNsBB9zBQG11On56axs8nZRrzff9d6DFVyQGsyuRb_M,6501
 odoo/addons/account_statement_import_sheet_file/views/account_journal_views.xml,sha256=iROLliBEfXvtXNsyHg5Ycvx9Rw9uuNWaXxdJsk8V1V4,670
 odoo/addons/account_statement_import_sheet_file/views/account_statement_import.xml,sha256=KhgiMxHjI5tq1RlkmDYOhejqrxN4mXLc5nT9EM9gQ5s,842
 odoo/addons/account_statement_import_sheet_file/views/account_statement_import_sheet_mapping.xml,sha256=1MoNt2wsvb2qHaYzrh7iVMHMjBEfwq2caRJ5mLCeEBc,6999
-odoo_addon_account_statement_import_sheet_file-16.0.1.1.1.2.dist-info/METADATA,sha256=4CmcKubxAaAZAM74-uFjKu-9qwRenjHMyS-iOHkSeJM,5229
-odoo_addon_account_statement_import_sheet_file-16.0.1.1.1.2.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
-odoo_addon_account_statement_import_sheet_file-16.0.1.1.1.2.dist-info/top_level.txt,sha256=qBj40grFkGOfDZ2WDSw3y1RnDlgG0u8rP8pvGNdbz4w,5
-odoo_addon_account_statement_import_sheet_file-16.0.1.1.1.2.dist-info/RECORD,,
+odoo_addon_account_statement_import_sheet_file-16.0.1.1.2.dist-info/METADATA,sha256=xiiaHZ2tQ9c2lQPBoMImKEaJghm0uejz4jyM9t6jsJ0,5227
+odoo_addon_account_statement_import_sheet_file-16.0.1.1.2.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
+odoo_addon_account_statement_import_sheet_file-16.0.1.1.2.dist-info/top_level.txt,sha256=qBj40grFkGOfDZ2WDSw3y1RnDlgG0u8rP8pvGNdbz4w,5
+odoo_addon_account_statement_import_sheet_file-16.0.1.1.2.dist-info/RECORD,,