ob-dj-store 0.0.12__py3-none-any.whl → 0.0.12.2__py3-none-any.whl

ob_dj_store/apis/stores/rest/serializers/serializers.py

@@ -1,5 +1,4 @@
 import calendar
-import sys
 import typing
 from datetime import time, timedelta
 
@@ -7,7 +6,9 @@ from django.conf import settings
 from django.contrib.contenttypes.models import ContentType
 from django.contrib.gis.geos import Point
 from django.core.exceptions import ObjectDoesNotExist, ValidationError
+from django.db import models
 from django.shortcuts import get_object_or_404
+from django.utils.module_loading import import_string
 from django.utils.timezone import now
 from django.utils.translation import gettext_lazy as _
 from rest_framework import serializers
@@ -963,18 +964,25 @@ class GenericSerializer(serializers.Serializer):
         return serializer_class(context=context).to_representation(value)
 
     def get_serializer_for_instance(self, instance):
-        serializer_class = instance.__class__.__name__ + "Serializer"
-        if hasattr(sys.modules[__name__], serializer_class):
-            return getattr(sys.modules[__name__], serializer_class)
-        else:
-            raise NameError(_(f"name '{serializer_class}' is not defined"))
+        serializer_class = instance.__class__.__name__
+        return import_string(
+            store_settings.FAVORITES_SERIALIZERS_PATHS[serializer_class]
+        )
+
+
+def get_favorite_extras_models():
+    extras_list = []
+    for key, value in settings.FAVORITE_TYPES.items():
+        if "extras" in value:
+            extras_list.extend(value["extras"].keys())
+    return extras_list
 
 
 class FavoriteExtraSerializer(serializers.ModelSerializer):
     content_object = GenericSerializer(read_only=True)
     object_id = serializers.IntegerField(min_value=1, write_only=True)
     object_type = serializers.ChoiceField(
-        write_only=True, choices=store_settings.EXTRA_FAVORITE_TYPES
+        write_only=True, choices=get_favorite_extras_models()
     )
 
     class Meta:
@@ -986,13 +994,23 @@ class FavoriteExtraSerializer(serializers.ModelSerializer):
             "object_type",
         )
 
+    def to_representation(self, instance):
+        data = super().to_representation(instance)
+        extras = get_favorite_extras_models()
+        model_name = instance.content_type.model
+        for extra in extras:
+            if model_name == extra.lower():
+                data["object_type"] = extra
+                break
+        return data
+
 
 class FavoriteSerializer(serializers.ModelSerializer):
     content_object = GenericSerializer(read_only=True)
     extras = FavoriteExtraSerializer(many=True)
     object_id = serializers.IntegerField(min_value=1, write_only=True)
     object_type = serializers.ChoiceField(
-        write_only=True, choices=store_settings.FAVORITE_TYPES
+        write_only=True, choices=list(store_settings.FAVORITE_TYPES.keys())
     )
 
     class Meta:
@@ -1009,63 +1027,87 @@ class FavoriteSerializer(serializers.ModelSerializer):
             "name": {"required": True},
         }
 
+    def to_representation(self, instance):
+        data = super().to_representation(instance)
+        model_name = instance.content_type.model
+        for favorite in store_settings.FAVORITE_TYPES.keys():
+            if model_name == favorite.lower():
+                data["object_type"] = favorite
+                break
+        return data
+
     def _lookup_validation(self, data):
-        content_type = ContentType.objects.get_for_model(type(data["content_object"]))
-        extras_lookup_content_type = {}
-        for extra in data["extras"]:
-            content_type_extra = extra.model
-            extras_lookup_content_type[content_type_extra] = extra
+        content_type = ContentType.objects.get_for_model(data["content_object"])
         queryset = Favorite.objects.filter(
             content_type=content_type,
             object_id=data["content_object"].id,
             user=self.context["request"].user,
-        )
-        for key in extras_lookup_content_type.keys():
-            queryset = queryset.filter(
-                extras__content_type=ContentType.objects.get_for_model(key),
-                extras__object_id__in=[
-                    extra.id for extra in extras_lookup_content_type[key]
-                ],
-            )
-        if queryset.exists():
+        ).prefetch_related("extras")
+
+        if not queryset.exists():
+            return
+
+        for favorite in queryset:
+            content_objects = [
+                instance.content_object for instance in favorite.extras.all()
+            ]
+            if data["extras"] == content_objects:
+                raise serializers.ValidationError(
+                    _(f"You cannot favorite the same item twice")
+                )
+
+    def get_object(self, model: models.Model, id: int):
+        try:
+            object = model.objects.get(pk=id)
+            return object
+        except model.DoesNotExist:
             raise serializers.ValidationError(
-                _(f"You cannot favorite the same item twice")
+                _(f"{model.__name__} with the id of {id} does not exist")
             )
 
     def validate(self, attrs):
         validated_data = super().validate(attrs)
+        extras_data = {}
         name = validated_data["name"]
         object_type = validated_data["object_type"]
-        if object_type not in store_settings.FAVORITE_TYPES and hasattr(
-            sys.modules[__name__], object_type
-        ):
-            raise serializers.ValidationError(
-                _(f"Cannot resolve keyword '{object_type}' into an object type")
-            )
-        object_type_model = getattr(sys.modules[__name__], object_type)
+        object_type_model = import_string(
+            store_settings.FAVORITE_TYPES[object_type]["path"]
+        )
         object_instance = get_object_or_404(
             object_type_model, pk=validated_data["object_id"]
         )
-        extras_data = {}
-        extras = []
         for extra in validated_data["extras"]:
-            extra_object_type = extra["object_type"]
-            if extra_object_type not in store_settings.EXTRA_FAVORITE_TYPES:
+            if (
+                extra["object_type"]
+                not in store_settings.FAVORITE_TYPES[object_type]["extras"]
+            ):
                 raise serializers.ValidationError(
-                    _(
-                        f"Cannot resolve keyword '{extra_object_type}' into an object type"
-                    )
+                    _(f"{extra['object_type']} Cannot be extra of {object_type}")
                 )
-            extras_data.setdefault(extra_object_type, [])
-            extras_data[extra_object_type].append(extra["object_id"])
-        try:
-            for key in extras_data.keys():
-                model_class = getattr(sys.modules[__name__], key, None)
-                if model_class:
-                    extras.append(model_class.objects.filter(id__in=extras_data[key]))
-        except ObjectDoesNotExist:
-            raise serializers.ValidationError(_("No matches the given query."))
+            extra_object_type = extra["object_type"]
+            extras_data.setdefault(
+                extra_object_type,
+                {
+                    "model": import_string(
+                        store_settings.FAVORITE_TYPES[object_type]["extras"][
+                            extra_object_type
+                        ]["path"]
+                    ),
+                    "ids": [],
+                },
+            )
+            extras_data[extra_object_type]["ids"].append(extra["object_id"])
 
+        extras = []
+        for key, value in extras_data.items():
+            type = store_settings.FAVORITE_TYPES[object_type]["extras"][key]["type"]
+            if len(value["ids"]) > 1 and type == store_settings.SIGNLE_FAVORITE_EXTRA:
+                raise serializers.ValidationError(_(f"Cannot set multiple {key}s"))
+            for id in value["ids"]:
+                extras.append(
+                    self.get_object(value["model"], id)
+                )  # get objects of extras instead of ids
+        extras = list(set(extras))  # remove duplicated extras
         validated_data = {
             "content_object": object_instance,
             "extras": extras,

ob_dj_store/core/stores/models/_favorite.py

@@ -44,13 +44,12 @@ class Favorite(DjangoModelCleanMixin, models.Model):
         )
         favorite.save()
         for extra in extras:
-            for obj in extra:
-                extra_content_type = ContentType.objects.get_for_model(type(obj))
-                favorite.extras.create(
-                    content_type=extra_content_type,
-                    object_id=obj.id,
-                    content_object=obj,
-                )
+            extra_content_type = ContentType.objects.get_for_model(type(extra))
+            favorite.extras.create(
+                content_type=extra_content_type,
+                object_id=extra.id,
+                content_object=extra,
+            )
         return favorite
 
 

ob_dj_store/core/stores/settings_validation.py

@@ -40,6 +40,49 @@ def store_validation_settings(app_configs, **kwargs):
                 )
             )
 
-    if getattr(settings, "GIFT_PAYMENT_METHOD_PATH", None):
+    if hasattr(settings, "GIFT_PAYMENT_METHOD_PATH"):
         _path_validation(settings.GIFT_PAYMENT_METHOD_PATH)
+
+    # Favorite validation settings
+    if hasattr(settings, "FAVORITE_TYPES"):
+        for key, favorite in settings.FAVORITE_TYPES.items():
+            if not favorite.get("path"):
+                errors.append(
+                    Error(
+                        f"Model path should be set for {key}",
+                        id="store_validation_settings_error",
+                    )
+                )
+            else:
+                _path_validation(favorite["path"])
+            if favorite.get("extras", None):
+                for key_extra, extra in favorite["extras"].items():
+                    if not extra.get("path", None):
+                        errors.append(
+                            Error(
+                                f"Model path should be set for {key}",
+                                id="store_validation_settings_error",
+                            )
+                        )
+                    else:
+                        _path_validation(extra["path"])
+                    if extra.get("type", None) == None:
+                        errors.append(
+                            Error(
+                                f"type must be set for {key_extra}",
+                                id="store_validation_settings_error",
+                            )
+                        )
+                    else:
+                        if not (
+                            hasattr(settings, "SIGNLE_FAVORITE_EXTRA")
+                            and hasattr(settings, "MULTIPLE_FAVORITE_EXTRA")
+                        ):
+                            errors.append(
+                                Error(
+                                    f"SIGNLE_FAVORITE_EXTRA and MULTIPLE_FAVORITE_EXTRA must be set",
+                                    id="store_validation_settings_error",
+                                )
+                            )
+
     return errors

{ob_dj_store-0.0.12.dist-info → ob_dj_store-0.0.12.2.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: ob-dj-store
-Version: 0.0.12
+Version: 0.0.12.2
 Summary: OBytes django application for managing ecommerce stores.
 Home-page: https://www.obytes.com/
 Author: OBytes

{ob_dj_store-0.0.12.dist-info → ob_dj_store-0.0.12.2.dist-info}/RECORD

@@ -3,7 +3,7 @@ ob_dj_store/apis/stores/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG
 ob_dj_store/apis/stores/filters.py,sha256=18Sb8Id1mgCC0zAzTOQRfBaS7bkyD_sgM8_jAbf1ulE,6349
 ob_dj_store/apis/stores/urls.py,sha256=cPForgFpOgOGCUVAk6DZcZ7qOooMf1zpDIr1BA0L_8A,1593
 ob_dj_store/apis/stores/views.py,sha256=0MTOaEHAFR4nKKjOc_bdpo93sYHkp2JvkX7hRlK3GNs,31701
-ob_dj_store/apis/stores/rest/serializers/serializers.py,sha256=-w5KQ24UHGFI-Zp0ix3ALrjLiVaGpllOrOcu1em5fig,37731
+ob_dj_store/apis/stores/rest/serializers/serializers.py,sha256=b3Gka1WflitjxN6Gp-8BD1gKlCouQDZtrZOt2crFd38,38966
 ob_dj_store/apis/tap/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 ob_dj_store/apis/tap/serializers.py,sha256=KPrBK4h2-fWvEVf6vOj2ww5-USV9WqpyYicIqoHIiXI,1065
 ob_dj_store/apis/tap/urls.py,sha256=bnOTv6an11kxpo_FdqlhsizlGPLVpNxBjCyKcf3_C9M,367
@@ -15,7 +15,7 @@ ob_dj_store/core/stores/admin_inlines.py,sha256=SLj8mMa-Sc3oP693R0W9c3Ocyk7eb34I
 ob_dj_store/core/stores/apps.py,sha256=ZadmEER_dNcQTH617b3fAsYZJSyRw0g46Kjp4eOAsOU,498
 ob_dj_store/core/stores/managers.py,sha256=6fCyTGgRnZshTri9UdEFlAPv3lKjyMllK0BG-OqUwOs,6804
 ob_dj_store/core/stores/receivers.py,sha256=PCe40N6S31fTiGGty94LC-CIUQsBoxRlZiTxxCaYlHU,3611
-ob_dj_store/core/stores/settings_validation.py,sha256=iz1VAYXZ5nU2L2NhhntKhaTkp_JzBzOvBqc-wAT_b7Y,1254
+ob_dj_store/core/stores/settings_validation.py,sha256=T_gQ2WbQlG7lqu3XgqiCZ9mqfSN4tlijdRG7efcDmkA,3123
 ob_dj_store/core/stores/utils.py,sha256=_FwZEIwKdfj3CuYHCz3wKqq5TBb8xak7UiiCB1oggKc,1850
 ob_dj_store/core/stores/gateway/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 ob_dj_store/core/stores/gateway/tap/__init__.py,sha256=5Z6azpb6tmr1nRvKwQWzlYw9ruvw-9ZMBWRqEngDKTM,40
@@ -101,7 +101,7 @@ ob_dj_store/core/stores/migrations/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQe
 ob_dj_store/core/stores/models/__init__.py,sha256=fNB_sn6HM6EmTp_Z-Q7KXD8HDWVjG3qlayrWqvygvbw,1617
 ob_dj_store/core/stores/models/_address.py,sha256=qS5TQ9Z12zx_4CrrHvG8PoYVkdiOq_MtbKR14WKh3Hw,1661
 ob_dj_store/core/stores/models/_cart.py,sha256=qgjg5MXTMRIZRJJDx5BQ1pa9__ylfrnYMMRGbB2R53c,4555
-ob_dj_store/core/stores/models/_favorite.py,sha256=bpXlFBNK8jsQkZG1RiDAbNTNSoVP0NOUUxZI8c46QzI,2561
+ob_dj_store/core/stores/models/_favorite.py,sha256=IA3p4u_-U0KcpofFMSkcuNWaI7C1hFkFdgMwQYYZGzw,2513
 ob_dj_store/core/stores/models/_feedback.py,sha256=eCUVgprNK5hSRKOS4M_pdR7QH2-rqhoYevlpykhCOLg,1472
 ob_dj_store/core/stores/models/_inventory.py,sha256=vAXSpCyUdYDIWgUEUUObQfhAcCcQO6j6zATrHf5dPuQ,3928
 ob_dj_store/core/stores/models/_order.py,sha256=lizkG-HEsxsC7Xasi5nnAtUnBL4riXezR48LblX-Zsk,8246
@@ -113,7 +113,7 @@ ob_dj_store/utils/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU
 ob_dj_store/utils/helpers.py,sha256=FtXXJOD2PILqZTyuf80bmf0KuWW64hxbJG6naJdxI5w,1607
 ob_dj_store/utils/model.py,sha256=DV7hOhTaZL3gh9sptts2jTUFlTArKG3i7oPioq9HLFE,303
 ob_dj_store/utils/utils.py,sha256=8UVAFB56qUSjJJ5f9vnermtw638gdFy4CFRCuMbns_M,1342
-ob_dj_store-0.0.12.dist-info/METADATA,sha256=krJMaAhSkUXwpHngiQUPwRwwJdey-Kdy2Yf1Cseafww,2825
-ob_dj_store-0.0.12.dist-info/WHEEL,sha256=2wepM1nk4DS4eFpYrW1TTqPcoGNfHhhO_i5m4cOimbo,92
-ob_dj_store-0.0.12.dist-info/top_level.txt,sha256=CZG3G0ptTkzGnc0dFYN-ZD7YKdJBmm47bsmGwofD_lk,12
-ob_dj_store-0.0.12.dist-info/RECORD,,
+ob_dj_store-0.0.12.2.dist-info/METADATA,sha256=ReVvSLpSZepJmFvkEIOo0tV9ZjtH9JoKpFvx3MDLg-Q,2827
+ob_dj_store-0.0.12.2.dist-info/WHEEL,sha256=2wepM1nk4DS4eFpYrW1TTqPcoGNfHhhO_i5m4cOimbo,92
+ob_dj_store-0.0.12.2.dist-info/top_level.txt,sha256=CZG3G0ptTkzGnc0dFYN-ZD7YKdJBmm47bsmGwofD_lk,12
+ob_dj_store-0.0.12.2.dist-info/RECORD,,