oarepo-runtime 1.5.32__py3-none-any.whl → 1.5.34__py3-none-any.whl

oarepo_runtime/cli/index.py

@@ -95,17 +95,6 @@ def record_or_service(model):
     return record
 
 
-def model_records_generator(model_class):
-    try:
-        for x in db.session.query(model_class.model_cls.id).filter(
-            model_class.model_cls.is_deleted.is_(False)
-        ):
-            rec_id = x[0]
-            yield model_class.get_record(rec_id)
-    except Exception as e:
-        click.secho(f"Could not index {model_class}: {e}", fg="red", file=sys.stderr)
-
-
 @index.command()
 @with_appcontext
 @click.argument("model", required=False)
@@ -119,14 +108,22 @@ def reindex(model, bulk_size, verbose):
     for service_id in services:
         click.secho(f"Preparing to index {service_id}", file=sys.stderr)
 
-        service = current_service_registry.get(service_id)
+        try:
+            service = current_service_registry.get(service_id)
+        except KeyError:
+            click.secho(f"Service {service_id} not in known services:", color="red")
+            for known_service_id, known_service in sorted(current_service_registry._services.items()):
+                click.secho(f"    {known_service_id} -> {type(known_service).__module__}.{type(known_service).__name__}", color="red")
+            sys.exit(1)
         record_class = getattr(service.config, "record_cls", None)
 
         id_generators = []
 
+        record_generator = RECORD_GENERATORS.get(service_id,  model_records_generator)
+
         if record_class and hasattr(service, "indexer"):
             try:
-                id_generators.append(model_records_generator(record_class))
+                id_generators.append(record_generator(record_class))
             except Exception as e:
                 click.secho(
                     f"Could not get record ids for {service_id}, exception {e}",
@@ -137,7 +134,7 @@ def reindex(model, bulk_size, verbose):
 
         if draft_class and hasattr(service, "indexer"):
             try:
-                id_generators.append(model_records_generator(draft_class))
+                id_generators.append(record_generator(draft_class))
             except Exception as e:
                 click.secho(
                     f"Could not get draft record ids for {service_id}, exception {e}",
@@ -151,7 +148,6 @@ def reindex(model, bulk_size, verbose):
             for bulk in generate_bulk_data(gen, service.indexer, bulk_size=bulk_size):
                 index_result = service.indexer.client.bulk(bulk)
                 count += len(bulk) // 2
-
                 for index_item_result in index_result["items"]:
                     result = index_item_result["index"]
                     if result["status"] != 200:
@@ -215,3 +211,28 @@ def dump_yaml(data):
     io = StringIO()
     yaml.dump(data, io, allow_unicode=True)
     return io.getvalue()
+
+
+def model_records_generator(model_class):
+    try:
+        for x in db.session.query(model_class.model_cls.id).filter(
+            model_class.model_cls.is_deleted.is_(False)
+        ):
+            rec_id = x[0]
+            yield model_class.get_record(rec_id)
+    except Exception as e:
+        click.secho(f"Could not index {model_class}: {e}", fg="red", file=sys.stderr)
+
+def users_record_generator(model_class):
+    from invenio_accounts.models import User
+    from invenio_users_resources.records.api import UserAggregate
+    try:
+        for x in db.session.query(User.id):
+            rec_id = x[0]
+            yield UserAggregate.get_record(rec_id)
+    except Exception as e:
+        click.secho(f"Could not index {model_class}: {e}", fg="red", file=sys.stderr)
+
+RECORD_GENERATORS = {
+    'users': users_record_generator
+}

oarepo_runtime/i18n/__init__.py

@@ -1,10 +1,3 @@
-from oarepo import __version__ as oarepo_version
-
-# compatibility setting between invenio rdm 11 and invenio rdm 12
-# can be removed when invenio rdm 11 is no longer supported
-if oarepo_version.split(".")[0] == "11":
-    from flask_babelex import get_locale, gettext, lazy_gettext
-else:
-    from flask_babel import get_locale, gettext, lazy_gettext
+from flask_babel import get_locale, gettext, lazy_gettext
 
 __all__ = ("gettext", "lazy_gettext", "get_locale")

oarepo_runtime/records/entity_resolvers/__init__.py

@@ -1,90 +1,6 @@
-from oarepo import __version__ as oarepo_version
+from oarepo_runtime.records.entity_resolvers.proxies import DraftProxy, RecordProxy
 
-from oarepo_runtime.records.entity_resolvers.proxies import DraftProxy
+from invenio_records_resources.references import EntityResolver, RecordResolver
+from invenio_users_resources.entity_resolvers import UserResolver, GroupResolver
 
-# compatibility setting between invenio rdm 11 and invenio rdm 12
-# can be removed when invenio rdm 11 is no longer supported
-if oarepo_version.split(".")[0] == "11":
-    from invenio_records_resources.references import EntityResolver, RecordResolver
-    from invenio_users_resources.resolvers import UserResolver
-
-    #copyied from newer invenio_users_resources, GroupResolver isn't in older versions
-    from flask_principal import RoleNeed
-    from invenio_accounts.models import Role
-    from invenio_records_resources.references.resolvers import (
-        EntityProxy,
-        EntityResolver,
-    )
-    from invenio_users_resources.services.groups.config import GroupsServiceConfig
-    from sqlalchemy.exc import NoResultFound
-
-    class GroupProxy(EntityProxy):
-        """Resolver proxy for a Role entity."""
-
-        def _resolve(self):
-            """Resolve the User from the proxy's reference dict, or system_identity."""
-            # Resolves to role name, not id
-            role_id = self._parse_ref_dict_id()
-            try:
-                return Role.query.filter(
-                    Role.name == role_id  # TODO to be changed to role id
-                ).one()
-            except NoResultFound:
-                return {}
-
-        def pick_resolved_fields(self, identity, resolved_dict):
-            """Select which fields to return when resolving the reference."""
-            serialized_role = {}
-
-            return serialized_role
-
-        def get_needs(self, ctx=None):
-            """Return needs based on the given roles."""
-            role_id = self._parse_ref_dict_id()
-            return [RoleNeed(role_id)]
-
-        def ghost_record(self, value):
-            """Return default representation of not resolved group.
-
-            .. note::
-
-                Only groups that are not indexed should need this. Non-indexed groups include groups that were not created by users
-                e.g. user-moderation.
-            """
-            return {}
-
-
-    class GroupResolver(EntityResolver):
-        """Group entity resolver."""
-
-        type_id = "group"
-        """Type identifier for this resolver."""
-
-        def __init__(self):
-            """Constructor."""
-            # There's a bit of a mixup of type_key and type_id. Base resolver has no
-            # type_key, but RecordResolvers have.
-            self.type_key = self.type_id
-            super().__init__(GroupsServiceConfig.service_id)
-
-        def matches_reference_dict(self, ref_dict):
-            """Check if the reference dict references a role."""
-            return self._parse_ref_dict_type(ref_dict) == self.type_id
-
-        def _reference_entity(self, entity):
-            """Create a reference dict for the given user."""
-            return {"group": str(entity.id)}
-
-        def matches_entity(self, entity):
-            """Check if the entity is a Role."""
-            return isinstance(entity, Role)
-
-        def _get_entity_proxy(self, ref_dict):
-            """Return a GroupProxy for the given reference dict."""
-            return GroupProxy(self, ref_dict)
-
-else:
-    from invenio_records_resources.references import EntityResolver, RecordResolver
-    from invenio_users_resources.entity_resolvers import UserResolver, GroupResolver
-
-__all__ = ["DraftProxy", "UserResolver", "GroupResolver", "RecordResolver", "EntityResolver"]
+__all__ = ["DraftProxy", "UserResolver", "GroupResolver", "RecordResolver", "EntityResolver", "RecordProxy"]

oarepo_runtime/records/entity_resolvers/proxies.py

@@ -1,22 +1,46 @@
 from invenio_pidstore.errors import PIDUnregistered
-from oarepo import __version__ as oarepo_version
 
-# compatibility setting between invenio rdm 11 and invenio rdm 12
-# can be removed when invenio rdm 11 is no longer supported
-if oarepo_version.split(".")[0] == "11":
-    from invenio_records_resources.references.resolvers.records import RecordProxy
-else:
-    from invenio_records_resources.references.entity_resolvers.records import (
-        RecordProxy,
-    )
+from invenio_records_resources.references.entity_resolvers.records import (
+    RecordProxy as InvenioRecordProxy,
+)
 
 from sqlalchemy.exc import NoResultFound
 
 
+def set_field(result, resolved_dict, field_name):
+    from_metadata = resolved_dict.get("metadata", {}).get(field_name)
+    from_data = resolved_dict.get(field_name)
+
+    if from_metadata:
+        result.setdefault("metadata", {})[field_name] = from_metadata
+    if from_data:
+        result[field_name] = from_data
+
+
+class RecordProxy(InvenioRecordProxy):
+    picked_fields = ["title", "creators", "contributors"]
+
+    def pick_resolved_fields(self, identity, resolved_dict):
+        """Select which fields to return when resolving the reference."""
+        resolved_fields = super().pick_resolved_fields(identity, resolved_dict)
+
+        for fld in self.picked_fields:
+            set_field(resolved_fields, resolved_dict, fld)
+
+        return resolved_fields
+
+    def ghost_record(self, value):
+        return {
+            **value,
+            "metadata": {
+                "title": "Deleted record",
+            },
+        }
+
+
 class DraftProxy(RecordProxy):
     def _resolve(self):
         pid_value = self._parse_ref_dict_id()
-
         try:
             return self.record_cls.pid.resolve(pid_value, registered_only=False)
         except (PIDUnregistered, NoResultFound):

oarepo_runtime/services/schema/i18n.py

@@ -1,6 +1,7 @@
 from functools import lru_cache
-
+import importlib
 import langcodes
+from invenio_base.utils import obj_or_import_string
 from marshmallow import Schema, ValidationError, fields, validates
 
 """
@@ -10,39 +11,41 @@ it for each project.
 
 
 @lru_cache
-def get_i18n_schema(lang_field, value_field):
-    @validates(lang_field)
+def get_i18n_schema(lang_name, value_name, value_field="marshmallow_utils.fields.SanitizedHTML"):
+    @validates(lang_name)
     def validate_lang(self, value):
         if value != "_" and not langcodes.Language.get(value).is_valid():
             raise ValidationError("Invalid language code")
 
+    value_field_class = obj_or_import_string(value_field)
+
     return type(
-        f"I18nSchema_{lang_field}_{value_field}",
+        f"I18nSchema_{lang_name}_{value_name}",
         (Schema,),
         {
             "validate_lang": validate_lang,
-            lang_field: fields.String(required=True),
-            value_field: fields.String(required=True),
+            lang_name: fields.String(required=True),
+            value_name: value_field_class(required=True),
         },
     )
 
 
 def MultilingualField(  # noqa NOSONAR
-    *args, lang_field="lang", value_field="value", **kwargs
+    *args, lang_name="lang", value_name="value", value_field="marshmallow_utils.fields.SanitizedHTML", **kwargs
 ):
     # TODO: args are not used but oarepo-model-builder-multilingual generates them
     # should be fixed there and subsequently removed here
     return fields.List(
-        fields.Nested(get_i18n_schema(lang_field, value_field)),
+        fields.Nested(get_i18n_schema(lang_name, value_name, value_field)),
         **kwargs,
     )
 
 
 def I18nStrField(  # noqa NOSONAR
-    *args, lang_field="lang", value_field="value", **kwargs
+    *args, lang_name="lang", value_name="value", value_field="marshmallow_utils.fields.SanitizedHTML", **kwargs
 ):
     return fields.Nested(
-        get_i18n_schema(lang_field, value_field),
+        get_i18n_schema(lang_name, value_name, value_field),
         *args,
         **kwargs,
     )

oarepo_runtime/services/schema/i18n_ui.py

@@ -1,72 +1,74 @@
 from functools import lru_cache
 
 from marshmallow import Schema, fields
-
+from marshmallow_utils.fields import SanitizedHTML
+from invenio_base.utils import obj_or_import_string
 
 @lru_cache
-def get_i18n_ui_schema(lang_field, value_field):
+def get_i18n_ui_schema(lang_name, value_name, value_field="marshmallow_utils.fields.SanitizedHTML"):
+    value_field_class = obj_or_import_string(value_field)
     return type(
-        f"I18nUISchema_{lang_field}_{value_field}",
+        f"I18nUISchema_{lang_name}_{value_name}",
         (Schema,),
         {
-            lang_field: fields.String(required=True),
-            value_field: fields.String(required=True),
+            lang_name: fields.String(required=True),
+            value_name: value_field_class(required=True),
         },
     )
 
 
 def MultilingualUIField(  # noqa NOSONAR
-    *args, lang_field="lang", value_field="value", **kwargs
+    *args, lang_name="lang", value_name="value", value_field="marshmallow_utils.fields.SanitizedHTML", **kwargs
 ):
     return fields.List(
-        fields.Nested(get_i18n_ui_schema(lang_field, value_field)),
+        fields.Nested(get_i18n_ui_schema(lang_name, value_name, value_field)),
         **kwargs,
     )
 
 
 def I18nStrUIField(  # noqa NOSONAR
-    *args, lang_field="lang", value_field="value", **kwargs
+    *args, lang_name="lang", value_name="value", value_field="marshmallow_utils.fields.SanitizedHTML", **kwargs
 ):
     return fields.Nested(
-        get_i18n_ui_schema(lang_field, value_field),
+        get_i18n_ui_schema(lang_name, value_name, value_field),
         *args,
         **kwargs,
     )
 
 
 @lru_cache
-def get_i18n_localized_ui_schema(lang_field, value_field):
+def get_i18n_localized_ui_schema(lang_name, value_name):
     class I18nLocalizedUISchema(Schema):
         def _serialize(self, value, attr=None, obj=None, **kwargs):
             if not value:
                 return None
             language = self.context["locale"].language
             for v in value:
-                if language == v[lang_field]:
-                    return v[value_field]
-            return next(iter(value))[value_field]
+                if language == v[lang_name]:
+                    return v[value_name]
+            return next(iter(value))[value_name]
 
     # inherit to get a nice name for debugging
     return type(
-        f"I18nLocalizedUISchema_{lang_field}_{value_field}",
+        f"I18nLocalizedUISchema_{lang_name}_{value_name}",
         (I18nLocalizedUISchema,),
         {},
     )
 
 
 def MultilingualLocalizedUIField(  # noqa NOSONAR
-    *args, lang_field="lang", value_field="value", **kwargs
+    *args, lang_name="lang", value_name="value", **kwargs
 ):
     return fields.Nested(
-        get_i18n_localized_ui_schema(lang_field, value_field), **kwargs
+        get_i18n_localized_ui_schema(lang_name, value_name), **kwargs
     )
 
 
 def I18nStrLocalizedUIField(  # noqa NOSONAR
-    *args, lang_field="lang", value_field="value", **kwargs
+    *args, lang_name="lang", value_name="value", **kwargs
 ):
     return fields.Nested(
-        get_i18n_ui_schema(lang_field, value_field),
+        get_i18n_ui_schema(lang_name, value_name),
         *args,
         **kwargs,
     )

{oarepo_runtime-1.5.32.dist-info → oarepo_runtime-1.5.34.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: oarepo-runtime
-Version: 1.5.32
+Version: 1.5.34
 Summary: A set of runtime extensions of Invenio repository
 Description-Content-Type: text/markdown
 License-File: LICENSE

{oarepo_runtime-1.5.32.dist-info → oarepo_runtime-1.5.34.dist-info}/RECORD

@@ -11,7 +11,7 @@ oarepo_runtime/cli/cf.py,sha256=W0JEJK2JqKubQw8qtZJxohmADDRUBode4JZAqYLDGvc,339
 oarepo_runtime/cli/check.py,sha256=AvC5VHAnwmtCd8R-Caj8v6nCAREKjObTdNtLJ24aJO8,4935
 oarepo_runtime/cli/configuration.py,sha256=cLXoGDtjuA5uv9ZfYFcH0C4wcadj0qWC3P_E4Bf5-z0,1061
 oarepo_runtime/cli/fixtures.py,sha256=teMbU-ocrSOmmCJvK-ICl6lMTAOWxJ5Tpkg6JQc0Y0s,5486
-oarepo_runtime/cli/index.py,sha256=H4nSZnClnlCSI8Thlz_jx-uPpgNVVQyagpWIPtQoIr4,7239
+oarepo_runtime/cli/index.py,sha256=6SaM3Ml6qCRakXbGz3afBAYM9hFRYrPIa6vw3pwqR_Q,8158
 oarepo_runtime/cli/validate.py,sha256=HpSvHQCGHlrdgdpKix9cIlzlBoJEiT1vACZdMnOUGEY,2827
 oarepo_runtime/datastreams/__init__.py,sha256=_i52Ek9J8DMARST0ejZAZPzUKm55xrrlKlCSO7dl6y4,1008
 oarepo_runtime/datastreams/asynchronous.py,sha256=1I1mEaTxyrcHD7LK6O9z2QX37AgeejflxynGmLreLQ0,7396
@@ -39,15 +39,15 @@ oarepo_runtime/datastreams/writers/service.py,sha256=PvCxYASDxOqT6iyL6cjw0aH41La
 oarepo_runtime/datastreams/writers/utils.py,sha256=Lk_ZLNeXTLuFEn04lw1-6bJ7duG6kwA8X4wf9c_GiL4,1067
 oarepo_runtime/datastreams/writers/validation_errors.py,sha256=wOCXdniR6so_4ExpdFYYgBRyENp7_6kVFZM2L-Hy3G8,661
 oarepo_runtime/datastreams/writers/yaml.py,sha256=XchUJHQ58E2Mfgs8elImXbL38jFtI8Hfoye6yaR0gKI,1482
-oarepo_runtime/i18n/__init__.py,sha256=G4PJ_kQlPDiBW6ntjQZ-O4qHQgkJWAXsNLUuOBcglNM,402
+oarepo_runtime/i18n/__init__.py,sha256=h0knW_HwiyIt5TBHfdGqN7_BBYfpz1Fw6zhVy0C28fM,111
 oarepo_runtime/info/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 oarepo_runtime/info/views.py,sha256=jtI2JJBdApuT5ZIxU2kskJBz6GpJVTgUGrM8EMNIiAk,11137
 oarepo_runtime/records/__init__.py,sha256=w1vtMmGDpcn9PQ2gbwihrYBZhawhzDWWOpnDdeaOPVo,1038
 oarepo_runtime/records/dumpers/__init__.py,sha256=OmzNhLdMNKibmCksnj9eTX9xPBG30dziiK3j3bAAp3k,233
 oarepo_runtime/records/dumpers/edtf_interval.py,sha256=YCShZAoqBQYaxVilEVotS-jXZsxxoXO67yu2urhkaMA,1198
 oarepo_runtime/records/dumpers/multilingual_dumper.py,sha256=PbNFCLsiH4XV3E1v8xga_fzlcEImHy8OXn_UKh_8VBU,1090
-oarepo_runtime/records/entity_resolvers/__init__.py,sha256=QvGxjfDRCg21eD5zDjWf0TSGFotEYG1PydrjT2wG7DY,3465
-oarepo_runtime/records/entity_resolvers/proxies.py,sha256=hHUzJA1yDhp7nM35gHoAAv7w4zWuaSE-tLBNvIR0tD8,882
+oarepo_runtime/records/entity_resolvers/__init__.py,sha256=fZFUh53idLswFIlF-5miLPQXMlDX6YEHAolJGgxgh6k,356
+oarepo_runtime/records/entity_resolvers/proxies.py,sha256=dhWYIjjWzXdoAooHvGeT2PHlfuvFHPSw_839TMXW8jA,1518
 oarepo_runtime/records/owners/__init__.py,sha256=R4hudCBqLRRzgCnkEjXIL7hSp068z-s6YOwYSkWyuaw,93
 oarepo_runtime/records/owners/registry.py,sha256=fYgBuW5nBKn6pyz2OBgfNlynk64_yhQ9J7FzPk8QU1U,795
 oarepo_runtime/records/relations/__init__.py,sha256=bDAgxl_LdKsqpGG3qluxAkQnn5u2ItJngnHQKkqzlkE,373
@@ -96,8 +96,8 @@ oarepo_runtime/services/relations/errors.py,sha256=VtlOKq9MEUeJ4IsiZhY7lWoshrusA
 oarepo_runtime/services/relations/mapping.py,sha256=D7IYk83SXVgTv-0ohSnHOCzvCwbFLXJsayO1eQfQn0U,1285
 oarepo_runtime/services/schema/__init__.py,sha256=gD0II1Lz6fnW1Cgt4gtneZeyKWl_YZ47Wu0gmeKqtH8,1395
 oarepo_runtime/services/schema/cf.py,sha256=-m9seIH5VYUdxDsJlPVXS0-8f7xkpN7YfW1q9E1GacI,475
-oarepo_runtime/services/schema/i18n.py,sha256=myyg0tU8up0BmMt9IESKD91w5KC0V9v8Qa-9fF0ptIs,1341
-oarepo_runtime/services/schema/i18n_ui.py,sha256=18tA6uA067TP_wcit47hTel2M4hz88wYtwBgaeZDrew,1880
+oarepo_runtime/services/schema/i18n.py,sha256=rCO8hZqRA_653uLn7eobJIsibbjgSLO9Q9Ka-2RG5r0,1645
+oarepo_runtime/services/schema/i18n_ui.py,sha256=D3YGKToB3MZVqGyiPf_xWPtg9PhGUuOZ5VNfm7fwf68,2203
 oarepo_runtime/services/schema/i18n_validation.py,sha256=fyMTi2Rw-KiHv7c7HN61zGxRVa9sAjAEEkAL5wUyKNo,236
 oarepo_runtime/services/schema/marshmallow.py,sha256=LmcSxvbZ9jIhkNHCqqxt1SA2UNijoDmIzqli1MkoTrE,1153
 oarepo_runtime/services/schema/oneofschema.py,sha256=X_pXzrkYcLGGAtGN1qltrz45OzD_atrJHkHkp3L01xg,6660
@@ -115,9 +115,9 @@ oarepo_runtime/utils/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hS
 oarepo_runtime/utils/functools.py,sha256=gKS9YZtlIYcDvdNA9cmYO00yjiXBYV1jg8VpcRUyQyg,1324
 oarepo_runtime/utils/path.py,sha256=V1NVyk3m12_YLbj7QHYvUpE1wScO78bYsX1LOLeXDkI,3108
 tests/pkg_data/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-oarepo_runtime-1.5.32.dist-info/LICENSE,sha256=h2uWz0OaB3EN-J1ImdGJZzc7yvfQjvHVYdUhQ-H7ypY,1064
-oarepo_runtime-1.5.32.dist-info/METADATA,sha256=_PPldeHNddy89KosMLaNCm1xzAEjET1eHnno3M-31PU,4680
-oarepo_runtime-1.5.32.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
-oarepo_runtime-1.5.32.dist-info/entry_points.txt,sha256=QrlXAKuPDVBinaSh_v3yO9_Nb9ZNmJCJ0VFcCW-z0Jg,327
-oarepo_runtime-1.5.32.dist-info/top_level.txt,sha256=bHhlkT1_RQC4IkfTQCqA3iN4KCB6cSFQlsXpQMSP-bE,21
-oarepo_runtime-1.5.32.dist-info/RECORD,,
+oarepo_runtime-1.5.34.dist-info/LICENSE,sha256=h2uWz0OaB3EN-J1ImdGJZzc7yvfQjvHVYdUhQ-H7ypY,1064
+oarepo_runtime-1.5.34.dist-info/METADATA,sha256=0JbXNMjCdPlCOSa9qn7U5nJm2k2JF6tOG3CRo6hnYtU,4680
+oarepo_runtime-1.5.34.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
+oarepo_runtime-1.5.34.dist-info/entry_points.txt,sha256=QrlXAKuPDVBinaSh_v3yO9_Nb9ZNmJCJ0VFcCW-z0Jg,327
+oarepo_runtime-1.5.34.dist-info/top_level.txt,sha256=bHhlkT1_RQC4IkfTQCqA3iN4KCB6cSFQlsXpQMSP-bE,21
+oarepo_runtime-1.5.34.dist-info/RECORD,,