netbox-plugin-dns 1.2.11__py3-none-any.whl → 1.2.13__py3-none-any.whl

netbox_dns/__init__.py

@@ -4,7 +4,7 @@ from django.core.exceptions import ImproperlyConfigured
 from netbox.plugins import PluginConfig
 from netbox.plugins.utils import get_plugin_config
 
-__version__ = "1.2.11"
+__version__ = "1.2.13"
 
 
 def _check_list(setting):

netbox_dns/management/commands/remove_orphaned_ptr_records.py

@@ -0,0 +1,35 @@
+from django.core.management.base import BaseCommand
+
+from netbox_dns.models import Record
+from netbox_dns.choices import RecordTypeChoices
+
+
+class Command(BaseCommand):
+    help = "Remove managed PTR records without an address record"
+
+    def handle(self, *model_names, **options):
+        orphaned_ptr_records = Record.objects.filter(
+            type=RecordTypeChoices.PTR,
+            address_records__isnull=True,
+            managed=True,
+        )
+
+        if not orphaned_ptr_records.exists():
+            if options.get("verbosity") >= 1:
+                self.stdout.write("No orphaned PTR records found")
+            return
+
+        if options.get("verbosity") >= 1:
+            self.stdout.write(
+                f"Removing {orphaned_ptr_records.count()} orphaned PTR record(s) ..."
+            )
+
+        for record in orphaned_ptr_records:
+            if options.get("verbosity") >= 2:
+                self.stdout.write(
+                    f"removing PTR record {record} from zone {record.zone}"
+                )
+            record.delete()
+
+        if options.get("verbosity") >= 1:
+            self.stdout.write("... done.")

netbox_dns/models/record.py

@@ -353,6 +353,21 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
     def is_delegation_record(self):
         return self in self.zone.delegation_records
 
+    def get_ptr_name(self, ptr_zone=None):
+        if ptr_zone is None:
+            ptr_zone = self.ptr_zone
+
+        if ptr_zone.is_rfc2317_zone:
+            ptr_name = self.rfc2317_ptr_name
+        else:
+            ptr_name = (
+                dns_name.from_text(ipaddress.ip_address(self.value).reverse_pointer)
+                .relativize(dns_name.from_text(ptr_zone.name))
+                .to_text()
+            )
+
+        return ptr_name
+
     def update_ptr_record(self, update_rfc2317_cname=True, save_zone_serial=True):
         ptr_zone = self.ptr_zone
 
@@ -368,15 +383,7 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
                     self.ptr_record = None
             return
 
-        if ptr_zone.is_rfc2317_zone:
-            ptr_name = self.rfc2317_ptr_name
-        else:
-            ptr_name = (
-                dns_name.from_text(ipaddress.ip_address(self.value).reverse_pointer)
-                .relativize(dns_name.from_text(ptr_zone.name))
-                .to_text()
-            )
-
+        ptr_name = self.get_ptr_name(ptr_zone)
         ptr_value = self.fqdn
         ptr_record = self.ptr_record
 
@@ -647,6 +654,36 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
                 }
             )
 
+    def check_unique_ptr_record(self):
+        if (
+            self.disable_ptr
+            or not self.is_active
+            or not self.is_address_record
+            or not (ptr_zone := self.ptr_zone)
+            or not get_plugin_config("netbox_dns", "enforce_unique_records", False)
+        ):
+            return
+
+        ptr_record = Record.objects.filter(
+            zone__view=self.zone.view,
+            zone=self.ptr_zone,
+            name=self.get_ptr_name(ptr_zone),
+            value=self.fqdn,
+            status__in=RECORD_ACTIVE_STATUS_LIST,
+        )
+
+        if not self._state.adding and self.ptr_record is not None:
+            ptr_record = ptr_record.exclude(pk=self.ptr_record.pk)
+
+        if ptr_record.exists():
+            raise ValidationError(
+                {
+                    "value": _(
+                        "There is already an active PTR record for {value} with value {fqdn}."
+                    ).format(fqdn=self.fqdn, value=self.value)
+                }
+            )
+
     @property
     def absolute_value(self):
         if self.type in RecordTypeChoices.CUSTOM_TYPES:
@@ -790,6 +827,7 @@ class Record(ObjectModificationMixin, ContactsMixin, NetBoxModel):
         self.validate_name(new_zone=new_zone)
         self.validate_value()
         self.check_unique_record(new_zone=new_zone)
+        self.check_unique_ptr_record()
         if self._state.adding:
             self.check_unique_rrset_ttl()
 

netbox_dns/models/zone.py

@@ -664,6 +664,27 @@ class Zone(ObjectModificationMixin, ContactsMixin, NetBoxModel):
                 }
             )
 
+    def check_ptr_records(self):
+        if self._state.adding:
+            return
+
+        validation_errors = []
+
+        address_records = self.records.filter(
+            type__in=(RecordTypeChoices.A, RecordTypeChoices.AAAA),
+            disable_ptr=False,
+            status__in=RECORD_ACTIVE_STATUS_LIST,
+        )
+
+        for record in address_records:
+            try:
+                record.check_unique_ptr_record()
+            except ValidationError as exc:
+                validation_errors.append(exc)
+
+        if validation_errors:
+            raise ValidationError(validation_errors)
+
     def get_auto_serial(self):
         records = Record.objects.filter(zone_id=self.pk).exclude(
             type=RecordTypeChoices.SOA
@@ -888,6 +909,8 @@ class Zone(ObjectModificationMixin, ContactsMixin, NetBoxModel):
         if self.is_reverse_zone:
             self.arpa_network = self.network_from_name
 
+        self.check_ptr_records()
+
         if self.is_rfc2317_zone:
             if self.arpa_network is not None:
                 raise ValidationError(

netbox_dns/views/record.py

@@ -156,6 +156,7 @@ class RecordView(generic.ObjectView):
 
                 if Zone.objects.filter(
                     active=True,
+                    view=instance.zone.view,
                     name__iregex=regex_from_list(
                         get_parent_zone_names(
                             instance.fqdn,

{netbox_plugin_dns-1.2.11.dist-info → netbox_plugin_dns-1.2.13.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: netbox-plugin-dns
-Version: 1.2.11
+Version: 1.2.13
 Summary: NetBox DNS is a NetBox plugin for managing DNS data.
 Author-email: Peter Eckel <pete@netbox-dns.org>
 Project-URL: Homepage, https://github.com/peteeckel/netbox-plugin-dns

{netbox_plugin_dns-1.2.11.dist-info → netbox_plugin_dns-1.2.13.dist-info}/RECORD

@@ -1,4 +1,4 @@
-netbox_dns/__init__.py,sha256=J3IJiBb3U8rQEKBa-KZ1ArvhWpqxHgtz5pA2Fngr-jY,4891
+netbox_dns/__init__.py,sha256=ypuFIfHwUIr6Bnloc-3OMM0JZQC0I_zn8vDO_NnXBc4,4891
 netbox_dns/apps.py,sha256=JCW5eS-AQBUubDJve1DjP-IRFKTFGQh1NLGWzJpC5MI,151
 netbox_dns/navigation.py,sha256=u90MwWBySg1Z9yfZEdvUctYWEkab5z1Y3019J7U_-3g,7741
 netbox_dns/template_content.py,sha256=irgHJe91TnmmL9K1Xnv07uGmOeJMn9zTrIKtJev88XI,4283
@@ -65,6 +65,7 @@ netbox_dns/locale/fr/LC_MESSAGES/django.mo,sha256=vL8TcVYyBiDFZ3GVdZe4Kkc42mmtbM
 netbox_dns/management/commands/cleanup_database.py,sha256=1-tAl0Sht80qaNZyfFyUW19Eh9gBUuc7GdbHN4aemGU,5935
 netbox_dns/management/commands/cleanup_rrset_ttl.py,sha256=UFRURLBcFeGHUS2lrYFv7UWIebjI72aG1EUQJt0XsXw,2046
 netbox_dns/management/commands/rebuild_dnssync.py,sha256=Tcl385u6kJTX47SvSyRzKm1RIx4nYRYCMcKr3uVnV60,1246
+netbox_dns/management/commands/remove_orphaned_ptr_records.py,sha256=vYYvI2yr4U1EiAoWm26PkULzaz3rr_Yfaw2eg9i4oIw,1142
 netbox_dns/management/commands/setup_dnssync.py,sha256=qtVj6egSjclaQbuI60hLfl-zg89VJVbX-TB17f1k77Y,5730
 netbox_dns/management/commands/update_soa.py,sha256=Rj_Xk-qpwkAVRubVnM5OqSTwgzi93E0PqjwGb3rYjf0,660
 netbox_dns/migrations/0001_squashed_netbox_dns_0_15.py,sha256=3U0810NWSHPu2dTSHpfzlleDgwMS04FhJ_CkO76SDaw,10283
@@ -105,12 +106,12 @@ netbox_dns/models/__init__.py,sha256=CuwFENIVUv0FNMDlY18Am-mvN5kBGkPOGavCP0cle7c
 netbox_dns/models/dnssec_key_template.py,sha256=h6YniKfLx1ILAbvko6Mps-bhsI743uHIOiLgtfStZTI,2790
 netbox_dns/models/dnssec_policy.py,sha256=eD13F_zTUgpP8fNGg0FssMNBUtpBRvkJiM6ZSYh1Pws,5466
 netbox_dns/models/nameserver.py,sha256=ivZpIVfgQLdDhrtqYPi-zRbygVgl3aff2FMsq1M3qA8,4044
-netbox_dns/models/record.py,sha256=GAl4JQCGX5Ip_R4zAQ-ZA-2Kn-Pr7zBmSgFCGsfbM5M,29806
+netbox_dns/models/record.py,sha256=cchwU_KO0qIL9gKbrjZH4ZXF-utl4bZGU4nTiVjFBRo,31040
 netbox_dns/models/record_template.py,sha256=kt-_sMFSMKmuKU8voVqz1-Lh7Wi7lPcA2ExPFQYLoxM,5345
 netbox_dns/models/registrar.py,sha256=L5tbO8rtOa0VCs_y90nHYLKSRKBnnUhh_6sxZ3Mm2kk,1942
 netbox_dns/models/registration_contact.py,sha256=O7T1clUjuilZnDjvhJKaHZdmNEF4aLg2h8K5p4llWOs,3825
 netbox_dns/models/view.py,sha256=gQvKNr_FmhG2EMz2T8kWbdK4b8CyqI-Qc67-Dgrx2SI,4808
-netbox_dns/models/zone.py,sha256=oKPWEFfe6AHea4mV1Z28U4TpusMK7-o-mEsch4rZkKE,35830
+netbox_dns/models/zone.py,sha256=YWJuase7OyXbMfJ9O7lV673Gu5X04uItI1YyM_5pgsE,36466
 netbox_dns/models/zone_template.py,sha256=TpM4LNBStwoyHXkvMGa8zUdBp28ZnauolkbFntt9hPk,5249
 netbox_dns/signals/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 netbox_dns/signals/dnssec.py,sha256=o4MOEg6ftxoDWFAhDtajkXzb7Nb6KuUHjtx1zNu7C1w,1040
@@ -166,15 +167,15 @@ netbox_dns/views/__init__.py,sha256=tObkTOHw_6kVtEcwdyshN0Ql-8VGhwsgQw7owL_s2lI,
 netbox_dns/views/dnssec_key_template.py,sha256=TfBtODl7EzGvmC2NVDLd-P1zMalLCjClb9pKgPzIsBk,3050
 netbox_dns/views/dnssec_policy.py,sha256=7bQRr9X-7U4RM3I_9k-SEfX2_WoZnHlbGpgXTG_HH7M,4807
 netbox_dns/views/nameserver.py,sha256=6lHg8fqBjc_SoITzFj1FiRARpPF7nSn9knAZxe9x5Rg,3932
-netbox_dns/views/record.py,sha256=6tOTC7BbQ5XOC7wr94LjFMR3epOi47HP5qIETNvj5sE,6715
+netbox_dns/views/record.py,sha256=lplgHzGABrucFB5Kflu7IhGpVyn2g7pEvExYafioCD8,6760
 netbox_dns/views/record_template.py,sha256=CbSyckBvyEvcZCeZgK3q0fJsa1_5HbwUflh_iM7JjH0,3134
 netbox_dns/views/registrar.py,sha256=Um_2wnzmP2bqbdMUhBPhny2My0R8fMXScQ9GLiTCrvg,2808
 netbox_dns/views/registration_contact.py,sha256=c9KrNkfFNsb55pL74A5rN1CNx32M82V6mdwBYduNxas,3596
 netbox_dns/views/view.py,sha256=VfrKaLC9D_KNZNmRyFVohRlmMlMbtblAuPgNg0LNyf8,3421
 netbox_dns/views/zone.py,sha256=DU_esPOMHGMRQIgy5vS8miZe-FNozBcIyMLZPwZK4_c,7453
 netbox_dns/views/zone_template.py,sha256=IIW1lr6RQmhShtqJu6A6LnHdxdBrkkZQHxIDSTqQeyc,2705
-netbox_plugin_dns-1.2.11.dist-info/licenses/LICENSE,sha256=I3tDu11bZfhFm3EkV4zOD5TmWgLjnUNLEFwrdjniZYs,1112
-netbox_plugin_dns-1.2.11.dist-info/METADATA,sha256=f5dwyaXsyAwarK5_ELsBgX9CMlxQ9mXxoulyzHeGVAU,7659
-netbox_plugin_dns-1.2.11.dist-info/WHEEL,sha256=wXxTzcEDnjrTwFYjLPcsW_7_XihufBwmpiBeiXNBGEA,91
-netbox_plugin_dns-1.2.11.dist-info/top_level.txt,sha256=sA1Rwl1mRKvMC6XHe2ylZ1GF-Q1NGd08XedK9Y4xZc4,11
-netbox_plugin_dns-1.2.11.dist-info/RECORD,,
+netbox_plugin_dns-1.2.13.dist-info/licenses/LICENSE,sha256=I3tDu11bZfhFm3EkV4zOD5TmWgLjnUNLEFwrdjniZYs,1112
+netbox_plugin_dns-1.2.13.dist-info/METADATA,sha256=tPSQO9L5Vo1nWGJk17xt78APuRsd5M4pXTDPw6nw8zo,7659
+netbox_plugin_dns-1.2.13.dist-info/WHEEL,sha256=zaaOINJESkSfm_4HQVc5ssNzHCPXhJm0kEUakpsEHaU,91
+netbox_plugin_dns-1.2.13.dist-info/top_level.txt,sha256=sA1Rwl1mRKvMC6XHe2ylZ1GF-Q1NGd08XedK9Y4xZc4,11
+netbox_plugin_dns-1.2.13.dist-info/RECORD,,

{netbox_plugin_dns-1.2.11.dist-info → netbox_plugin_dns-1.2.13.dist-info}/WHEEL

@@ -1,5 +1,5 @@
 Wheel-Version: 1.0
-Generator: setuptools (80.1.0)
+Generator: setuptools (80.8.0)
 Root-Is-Purelib: true
 Tag: py3-none-any