netbox-plugin-dns 1.0.1__py3-none-any.whl → 1.0.3__py3-none-any.whl

netbox_dns/__init__.py

@@ -1,6 +1,6 @@
 from netbox.plugins import PluginConfig
 
-__version__ = "1.0.1"
+__version__ = "1.0.3"
 
 
 class DNSConfig(PluginConfig):
@@ -21,7 +21,9 @@ class DNSConfig(PluginConfig):
         "zone_soa_expire": 2419200,
         "zone_soa_minimum": 3600,
         "feature_ipam_coupling": False,
-        "tolerate_underscores_in_hostnames": False,
+        "tolerate_characters_in_zone_labels": "",
+        "tolerate_underscores_in_labels": False,
+        "tolerate_underscores_in_hostnames": False,  # Deprecated, will be removed in 1.2.0
         "tolerate_leading_underscore_types": [
             "TXT",
             "SRV",
@@ -30,6 +32,8 @@ class DNSConfig(PluginConfig):
         "enable_root_zones": False,
         "enforce_unique_records": True,
         "enforce_unique_rrset_ttl": True,
+        "menu_name": "NetBox DNS",
+        "top_level_menu": True,
     }
     base_url = "netbox-dns"
 

netbox_dns/mixins/__init__.py

@@ -0,0 +1 @@
+from .object_modification import *

netbox_dns/mixins/object_modification.py

@@ -0,0 +1,26 @@
+from netbox.models import NetBoxModel
+
+
+class ObjectModificationMixin:
+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs)
+
+        if not hasattr(self.__class__, "check_fields"):
+            self.__class__.check_fields = (
+                {field.name for field in self._meta.fields}
+                - {field.name for field in NetBoxModel._meta.fields}
+                - {"id"}
+            )
+
+    @property
+    def changed_fields(self):
+        if self.pk is None:
+            return None
+
+        saved = self.__class__.objects.get(pk=self.pk)
+
+        return {
+            field
+            for field in self.check_fields
+            if getattr(self, field) != getattr(saved, field)
+        }

netbox_dns/models/nameserver.py

@@ -14,11 +14,12 @@ from netbox_dns.utilities import (
     NameFormatError,
 )
 from netbox_dns.validators import validate_fqdn
+from netbox_dns.mixins import ObjectModificationMixin
 
 from .record import Record, RecordTypeChoices
 
 
-class NameServer(NetBoxModel):
+class NameServer(ObjectModificationMixin, NetBoxModel):
     name = models.CharField(
         unique=True,
         max_length=255,
@@ -79,14 +80,12 @@ class NameServer(NetBoxModel):
     def save(self, *args, **kwargs):
         self.full_clean()
 
-        name_changed = (
-            self.pk is not None and self.name != NameServer.objects.get(pk=self.pk).name
-        )
+        changed_fields = self.changed_fields
 
         with transaction.atomic():
             super().save(*args, **kwargs)
 
-            if name_changed:
+            if changed_fields is not None and "name" in changed_fields:
                 soa_zones = self.zones_soa.all()
                 for soa_zone in soa_zones:
                     soa_zone.update_soa_record()

netbox_dns/models/record.py

@@ -22,9 +22,10 @@ from netbox_dns.utilities import (
 )
 from netbox_dns.validators import (
     validate_fqdn,
-    validate_extended_hostname,
+    validate_generic_name,
     validate_domain_name,
 )
+from netbox_dns.mixins import ObjectModificationMixin
 
 # +
 # This is a hack designed to break cyclic imports between Record and Zone
@@ -102,7 +103,7 @@ class RecordStatusChoices(ChoiceSet):
     ]
 
 
-class Record(NetBoxModel):
+class Record(ObjectModificationMixin, NetBoxModel):
     ACTIVE_STATUS_LIST = (RecordStatusChoices.STATUS_ACTIVE,)
 
     unique_ptr_qs = Q(
@@ -211,9 +212,12 @@ class Record(NetBoxModel):
 
     def __str__(self):
         try:
-            name = dns_name.from_text(self.fqdn).relativize(dns_name.root).to_unicode()
+            fqdn = dns_name.from_text(
+                self.name, origin=dns_name.from_text(self.zone.name)
+            ).relativize(dns_name.root)
+            name = fqdn.to_unicode()
         except dns_name.IDNAException:
-            name = self.name
+            name = fqdn.to_text()
         except dns_name.LabelTooLong:
             name = f"{self.name[:59]}..."
 
@@ -490,7 +494,7 @@ class Record(NetBoxModel):
             "netbox_dns", "tolerate_non_rfc1035_types", default=[]
         ):
             try:
-                validate_extended_hostname(
+                validate_generic_name(
                     self.name,
                     (
                         self.type
@@ -537,8 +541,7 @@ class Record(NetBoxModel):
                     )
 
                 case (
-                    RecordTypeChoices.DNAME
-                    | RecordTypeChoices.NS
+                    RecordTypeChoices.NS
                     | RecordTypeChoices.HTTPS
                     | RecordTypeChoices.SRV
                     | RecordTypeChoices.SVCB
@@ -546,6 +549,12 @@ class Record(NetBoxModel):
                     _validate_idn(rr.target)
                     validate_domain_name(rr.target.to_text(), always_tolerant=True)
 
+                case RecordTypeChoices.DNAME:
+                    _validate_idn(rr.target)
+                    validate_domain_name(
+                        rr.target.to_text(), always_tolerant=True, zone_name=True
+                    )
+
                 case RecordTypeChoices.PTR | RecordTypeChoices.NSAP_PTR:
                     _validate_idn(rr.target)
                     validate_fqdn(rr.target.to_text(), always_tolerant=True)
@@ -566,7 +575,7 @@ class Record(NetBoxModel):
 
                 case RecordTypeChoices.NAPTR:
                     _validate_idn(rr.replacement)
-                    validate_extended_hostname(
+                    validate_generic_name(
                         rr.replacement.to_text(), always_tolerant=True
                     )
 
@@ -783,7 +792,9 @@ class Record(NetBoxModel):
             self.ptr_record.delete()
             self.ptr_record = None
 
-        super().save(*args, **kwargs)
+        changed_fields = self.changed_fields
+        if changed_fields is None or changed_fields:
+            super().save(*args, **kwargs)
 
         _zone = self.zone
         if self.type != RecordTypeChoices.SOA and _zone.soa_serial_auto:

netbox_dns/models/view.py

@@ -7,8 +7,10 @@ from netbox.search import SearchIndex, register_search
 from netbox.context import current_request
 from utilities.exceptions import AbortRequest
 
+from netbox_dns.mixins import ObjectModificationMixin
 
-class View(NetBoxModel):
+
+class View(ObjectModificationMixin, NetBoxModel):
     name = models.CharField(
         unique=True,
         max_length=255,
@@ -53,13 +55,11 @@ class View(NetBoxModel):
         super().delete(*args, **kwargs)
 
     def clean(self, *args, old_state=None, **kwargs):
-        if self.pk is None:
+        if (changed_fields := self.changed_fields) is None:
             return
 
-        old_state = View.objects.get(pk=self.pk)
-
         if (
-            old_state.default_view
+            "default_view" in changed_fields
             and not self.default_view
             and not View.objects.filter(default_view=True).exclude(pk=self.pk).exists()
         ):
@@ -74,12 +74,14 @@ class View(NetBoxModel):
     def save(self, *args, **kwargs):
         self.clean()
 
-        old_state = None if self.pk is None else View.objects.get(pk=self.pk)
+        changed_fields = self.changed_fields
 
         super().save(*args, **kwargs)
 
-        if (old_state is None and self.default_view) or (
-            old_state is not None and self.default_view and not old_state.default_view
+        if (changed_fields is None and self.default_view) or (
+            changed_fields is not None
+            and self.default_view
+            and "default_view" in changed_fields
         ):
             other_views = View.objects.filter(default_view=True).exclude(pk=self.pk)
             for view in other_views:

netbox_dns/models/zone.py

@@ -1,3 +1,4 @@
+import re
 from math import ceil
 from datetime import datetime
 
@@ -35,6 +36,7 @@ from netbox_dns.validators import (
     validate_fqdn,
     validate_domain_name,
 )
+from netbox_dns.mixins import ObjectModificationMixin
 
 # +
 # This is a hack designed to break cyclic imports between View, Record and Zone
@@ -77,7 +79,7 @@ class ZoneStatusChoices(ChoiceSet):
     ]
 
 
-class Zone(NetBoxModel):
+class Zone(ObjectModificationMixin, NetBoxModel):
     ACTIVE_STATUS_LIST = (ZoneStatusChoices.STATUS_ACTIVE,)
 
     view = models.ForeignKey(
@@ -352,6 +354,22 @@ class Zone(NetBoxModel):
             )
         )
 
+    @property
+    def child_zones(self):
+        return Zone.objects.filter(
+            name__iregex=rf"^[^.]+\.{re.escape(self.name)}$", view=self.view
+        )
+
+    @property
+    def parent_zone(self):
+        parent_name = (
+            dns_name.from_text(self.name).parent().relativize(dns_name.root).to_text()
+        )
+        try:
+            return Zone.objects.get(name=parent_name, view=self.view)
+        except Zone.DoesNotExist:
+            return None
+
     def record_count(self, managed=False):
         return record.Record.objects.filter(zone=self, managed=managed).count()
 
@@ -592,7 +610,7 @@ class Zone(NetBoxModel):
             ) from None
 
         try:
-            validate_domain_name(self.name)
+            validate_domain_name(self.name, zone_name=True)
         except ValidationError as exc:
             raise ValidationError(
                 {
@@ -683,17 +701,7 @@ class Zone(NetBoxModel):
     def save(self, *args, **kwargs):
         self.full_clean()
 
-        new_zone = self.pk is None
-        if not new_zone:
-            old_zone = Zone.objects.get(pk=self.pk)
-
-        name_changed = not new_zone and old_zone.name != self.name
-        view_changed = not new_zone and old_zone.view != self.view
-        status_changed = not new_zone and old_zone.status != self.status
-        rfc2317_changed = not new_zone and (
-            old_zone.rfc2317_prefix != self.rfc2317_prefix
-            or old_zone.rfc2317_parent_managed != self.rfc2317_parent_managed
-        )
+        changed_fields = self.changed_fields
 
         if self.soa_serial_auto:
             self.soa_serial = self.get_auto_serial()
@@ -701,7 +709,7 @@ class Zone(NetBoxModel):
         super().save(*args, **kwargs)
 
         if (
-            new_zone or name_changed or view_changed or status_changed
+            changed_fields is None or {"name", "view", "status"} & changed_fields
         ) and self.is_reverse_zone:
             zones = Zone.objects.filter(
                 view=self.view,
@@ -733,11 +741,9 @@ class Zone(NetBoxModel):
                     child_zone.update_rfc2317_parent_zone()
 
         if (
-            new_zone
-            or name_changed
-            or view_changed
-            or status_changed
-            or rfc2317_changed
+            changed_fields is None
+            or {"name", "view", "status", "rfc2317_prefix", "rfc2317_parent_managed"}
+            & changed_fields
         ) and self.is_rfc2317_zone:
             zones = Zone.objects.filter(
                 view=self.view,
@@ -763,7 +769,7 @@ class Zone(NetBoxModel):
 
             self.update_rfc2317_parent_zone()
 
-        elif name_changed or view_changed or status_changed:
+        elif changed_fields is not None and {"name", "view", "status"} & changed_fields:
             for address_record in self.record_set.filter(
                 type__in=(record.RecordTypeChoices.A, record.RecordTypeChoices.AAAA)
             ):
@@ -772,7 +778,7 @@ class Zone(NetBoxModel):
             # Fix name in IP Address when zone name is changed
             if (
                 get_plugin_config("netbox_dns", "feature_ipam_coupling")
-                and name_changed
+                and "name" in changed_fields
             ):
                 for ip in IPAddress.objects.filter(
                     custom_field_data__ipaddress_dns_zone_id=self.pk
@@ -780,7 +786,7 @@ class Zone(NetBoxModel):
                     ip.dns_name = f'{ip.custom_field_data["ipaddress_dns_record_name"]}.{self.name}'
                     ip.save(update_fields=["dns_name"])
 
-        if name_changed:
+        if changed_fields is not None and "name" in changed_fields:
             for _record in self.record_set.all():
                 _record.save(
                     update_fields=["fqdn"],

netbox_dns/navigation.py

@@ -1,4 +1,8 @@
 from netbox.plugins import PluginMenuButton, PluginMenuItem, PluginMenu
+from netbox.plugins.utils import get_plugin_config
+
+menu_name = get_plugin_config("netbox_dns", "menu_name")
+top_level_menu = get_plugin_config("netbox_dns", "top_level_menu")
 
 view_menu_item = PluginMenuItem(
     link="plugins:netbox_dns:view_list",
@@ -126,26 +130,38 @@ contact_menu_item = PluginMenuItem(
     ),
 )
 
-menu = PluginMenu(
-    label="NetBox DNS",
-    groups=(
-        (
-            "DNS Configuration",
+
+if top_level_menu:
+    menu = PluginMenu(
+        label=menu_name,
+        groups=(
             (
-                view_menu_item,
-                zone_menu_item,
-                nameserver_menu_item,
-                record_menu_item,
-                managed_record_menu_item,
+                "DNS Configuration",
+                (
+                    view_menu_item,
+                    zone_menu_item,
+                    nameserver_menu_item,
+                    record_menu_item,
+                    managed_record_menu_item,
+                ),
             ),
-        ),
-        (
-            "Domain Registration",
             (
-                registrar_menu_item,
-                contact_menu_item,
+                "Domain Registration",
+                (
+                    registrar_menu_item,
+                    contact_menu_item,
+                ),
             ),
         ),
-    ),
-    icon_class="mdi mdi-dns",
-)
+        icon_class="mdi mdi-dns",
+    )
+else:
+    menu_items = (
+        view_menu_item,
+        zone_menu_item,
+        nameserver_menu_item,
+        record_menu_item,
+        managed_record_menu_item,
+        registrar_menu_item,
+        contact_menu_item,
+    )

netbox_dns/tables/view.py

@@ -10,7 +10,7 @@ class ViewTable(TenancyColumnsMixin, NetBoxTable):
     name = tables.Column(
         linkify=True,
     )
-    default_view = tables.Column(
+    default_view = tables.BooleanColumn(
         verbose_name="Default View",
     )
     tags = TagColumn(url_name="plugins:netbox_dns:view_list")

netbox_dns/templates/netbox_dns/record.html

@@ -94,25 +94,25 @@
                 {% if object.ptr_record %}
                 <tr>
                     <th scope="row">PTR Record</th>
-                    <td><a href="{% url 'plugins:netbox_dns:record' pk=object.ptr_record.pk %}">{{ object.ptr_record }}</td>
+                    <td>{{ object.ptr_record|linkify }}</td>
                 </tr>
                 {% endif %}
                 {% if object.address_record %}
                 <tr>
                     <th scope="row">Address Record</th>
-                    <td><a href="{% url 'plugins:netbox_dns:record' pk=object.address_record.pk %}">{{ object.address_record }}</td>
+                    <td>{{ object.address_record|linkify }}</td>
                 </tr>
                     {% if object.address_record.ipam_ip_address %}
                     <tr>
                         <th scope="row">IPAM IP Address</th>
-                        <td><a href="{% url 'ipam:ipaddress' pk=object.address_record.ipam_ip_address.pk %}">{{ object.address_record.ipam_ip_address }}</td>
+                        <td>{{ object.address_record.ipam_ip_address|linkify }}</td>
                     </tr>
                     {% endif %}
                 {% endif %}
                 {% if object.ipam_ip_address %}
                 <tr>
                     <th scope="row">IPAM IP Address</th>
-                    <td><a href="{% url 'ipam:ipaddress' pk=object.ipam_ip_address.pk %}">{{ object.ipam_ip_address }}</td>
+                    <td>{{ object.ipam_ip_address|linkify }}</td>
                 </tr>
                 {% endif %}
                 <tr>

netbox_dns/templates/netbox_dns/zone/child_zone.html

@@ -0,0 +1,18 @@
+{% extends 'netbox_dns/zone/base.html' %}
+{% load helpers %}
+{% load render_table from django_tables2 %}
+{% load perms %}
+
+{% block content %}
+    {% include 'inc/table_controls_htmx.html' with table_modal="ChildZoneTable_config" %}
+    <div class="card">
+        <div class="htmx-container table-responsive" id="object_list">
+            {% include 'htmx/table.html' %}
+        </div>
+    </div>
+{% endblock %}
+
+{% block modals %}
+    {{ block.super }}
+    {% table_config_form table %}
+{% endblock modals %}

netbox_dns/templates/netbox_dns/zone.html

@@ -20,13 +20,15 @@
                         <td>{{ unicode_name }}</td>
                     </tr>
                 {% endif %}
+                {% if parent_zone %}
+                    <tr>
+                        <th scope="row">Parent Zone</th>
+                        <td>{{ parent_zone|linkify }}</td>
+                    </tr>
+                {% endif %}
                 <tr>
                     <th scope="row">View</th>
-                    <td>
-                        <a href="{% url 'plugins:netbox_dns:view' pk=object.view.pk %}">
-                            {{ object.view }}
-                        </a>
-                    </td>
+                    <td>{{ object.view|linkify }}</td>
                 </tr>
                 {% if object.description %}
                 <tr>
@@ -52,13 +54,7 @@
                     <td>
                         <table>
                             {% for nameserver in object.nameservers.all %}
-                            <tr>
-                                <td>
-                                    <a href="{% url 'plugins:netbox_dns:nameserver' pk=nameserver.pk %}">
-                                        {{ nameserver }}
-                                    </a>
-                                </td>
-                            </tr>
+                            <tr><td>{{ nameserver|linkify }}</td></tr>
                             {% endfor %}
                         </table>
                     </td>
@@ -115,7 +111,7 @@
                 </tr>
                 <tr>
                     <th scope="row">MName</th>
-                    <td><a href="{% url 'plugins:netbox_dns:nameserver' pk=object.soa_mname.pk %}">{{ object.soa_mname }}</a></td>
+                    <td>{{ object.soa_mname|linkify }}</td>
                 </tr>
                 <tr>
                     <th scope="row">RName</th>
@@ -153,7 +149,7 @@
         {% if object.rfc2317_prefix %}
         <div class="card">
             <h5 class="card-header">RFC2317</h5>
-            <table class="table table-hover soa-table">
+            <table class="table table-hover attr-table">
                 <tr>
                     <th scope="row">Prefix</th>
                     <td>{{ object.rfc2317_prefix }}</td>
@@ -165,7 +161,7 @@
                 {% if object.rfc2317_parent_managed %}
                 <tr>
                     <th scope="row">Parent Zone</th>
-                    <td><a href="{% url 'plugins:netbox_dns:zone' pk=object.rfc2317_parent_zone.pk %}">{{ object.rfc2317_parent_zone }}</a></td>
+                    <td>{{ object.rfc2317_parent_zone|linkify }}</td>
                 </tr>
                 {% endif %}
             </table>

netbox_dns/urls/zone.py

@@ -15,6 +15,7 @@ from netbox_dns.views import (
     ZoneManagedRecordListView,
     ZoneRegistrationView,
     ZoneRFC2317ChildZoneListView,
+    ZoneChildZoneListView,
 )
 
 zone_urlpatterns = [
@@ -37,6 +38,11 @@ zone_urlpatterns = [
         ZoneRFC2317ChildZoneListView.as_view(),
         name="zone_rfc2317_child_zones",
     ),
+    path(
+        "zones/<int:pk>/childzones/",
+        ZoneChildZoneListView.as_view(),
+        name="zone_child_zones",
+    ),
     path(
         "zones/<int:pk>/registration/",
         ZoneRegistrationView.as_view(),

netbox_dns/utilities/__init__.py

@@ -21,7 +21,7 @@ def arpa_to_prefix(arpa_name):
 
         try:
             return IPNetwork(f"{address}/{mask}")
-        except AddrFormatError:
+        except (AddrFormatError, ValueError):
             return None
 
     elif name.endswith("ip6.arpa"):

netbox_dns/validators/dns_name.py

@@ -4,10 +4,40 @@ from django.core.exceptions import ValidationError
 
 from netbox.plugins.utils import get_plugin_config
 
-LABEL = r"[a-z0-9][a-z0-9-]*(?<!-)"
-TOLERANT_LABEL = r"[a-z0-9][a-z0-9-_]*(?<![-_])"
-LEADING_UNDERSCORE_LABEL = r"[a-z0-9_][a-z0-9-]*(?<!-)"
-TOLERANT_LEADING_UNDERSCORE_LABEL = r"[a-z0-9_][a-z0-9-_]*(?<![-_])"
+import logging
+
+
+def _get_label(tolerate_leading_underscores=False, always_tolerant=False):
+    tolerate_characters = re.escape(
+        get_plugin_config("netbox_dns", "tolerate_characters_in_zone_labels", "")
+    )
+    label_characters = rf"a-z0-9{tolerate_characters}"
+
+    if always_tolerant:
+        label = rf"[a-z0-9_][a-z0-9_-]*(?<![-_])"
+        zone_label = rf"[{label_characters}_][{label_characters}_-]*(?<![-_])"
+
+        return label, zone_label
+
+    tolerate_underscores = get_plugin_config(
+        "netbox_dns", "tolerate_underscores_in_labels"
+    ) or get_plugin_config("netbox_dns", "tolerate_underscores_in_hostnames")
+
+    if tolerate_leading_underscores:
+        if tolerate_underscores:
+            label = r"[a-z0-9_][a-z0-9_-]*(?<![-_])"
+            zone_label = rf"[{label_characters}_][{label_characters}_-]*(?<![-_])"
+        else:
+            label = rf"[a-z0-9_][a-z0-9-]*(?<!-)"
+            zone_label = rf"[{label_characters}_][{label_characters}-]*(?<!-)"
+    elif tolerate_underscores:
+        label = rf"[a-z0-9][a-z0-9_-]*(?<![-_])"
+        zone_label = rf"[{label_characters}][{label_characters}_-]*(?<![-_])"
+    else:
+        label = rf"[a-z0-9][a-z0-9-]*(?<!-)"
+        zone_label = rf"[{label_characters}][{label_characters}-]*(?<!-)"
+
+    return label, zone_label
 
 
 def has_invalid_double_dash(name):
@@ -15,37 +45,29 @@ def has_invalid_double_dash(name):
 
 
 def validate_fqdn(name, always_tolerant=False):
-    if always_tolerant or get_plugin_config(
-        "netbox_dns", "tolerate_underscores_in_hostnames"
-    ):
-        regex = rf"^(\*|{TOLERANT_LABEL})(\.{TOLERANT_LABEL})+\.?$"
-    else:
-        regex = rf"^(\*|{LABEL})(\.{LABEL})+\.?$"
+    label, zone_label = _get_label(always_tolerant=always_tolerant)
+    regex = rf"^(\*|{label})(\.{zone_label})+\.?$"
 
     if not re.match(regex, name, flags=re.IGNORECASE) or has_invalid_double_dash(name):
         raise ValidationError(f"{name} is not a valid fully qualified DNS host name")
 
 
-def validate_extended_hostname(
+def validate_generic_name(
     name, tolerate_leading_underscores=False, always_tolerant=False
 ):
-    if always_tolerant or tolerate_leading_underscores:
-        if always_tolerant or get_plugin_config(
-            "netbox_dns", "tolerate_underscores_in_hostnames"
-        ):
-            regex = rf"^([*@]|(\*\.)?{TOLERANT_LEADING_UNDERSCORE_LABEL}(\.{TOLERANT_LEADING_UNDERSCORE_LABEL})*\.?)$"
-        else:
-            regex = rf"^([*@]|(\*\.)?{LEADING_UNDERSCORE_LABEL}(\.{LEADING_UNDERSCORE_LABEL})*\.?)$"
-    elif get_plugin_config("netbox_dns", "tolerate_underscores_in_hostnames"):
-        regex = rf"^([*@]|(\*\.)?{TOLERANT_LABEL}(\.{TOLERANT_LABEL})*\.?)$"
-    else:
-        regex = rf"^([*@]|(\*\.)?{LABEL}(\.{LABEL})*\.?)$"
+    label, zone_label = _get_label(
+        tolerate_leading_underscores=tolerate_leading_underscores,
+        always_tolerant=always_tolerant,
+    )
+    regex = rf"^([*@]|(\*\.)?{label}(\.{zone_label})*\.?)$"
 
     if not re.match(regex, name, flags=re.IGNORECASE) or has_invalid_double_dash(name):
         raise ValidationError(f"{name} is not a valid DNS host name")
 
 
-def validate_domain_name(name, always_tolerant=False, allow_empty_label=False):
+def validate_domain_name(
+    name, always_tolerant=False, allow_empty_label=False, zone_name=False
+):
     if name == "@" and allow_empty_label:
         return
 
@@ -54,12 +76,11 @@ def validate_domain_name(name, always_tolerant=False, allow_empty_label=False):
     ):
         return
 
-    if always_tolerant or get_plugin_config(
-        "netbox_dns", "tolerate_underscores_in_hostnames"
-    ):
-        regex = rf"^{TOLERANT_LABEL}(\.{TOLERANT_LABEL})*\.?$"
+    label, zone_label = _get_label(always_tolerant=always_tolerant)
+    if zone_name:
+        regex = rf"^{zone_label}(\.{zone_label})*\.?$"
     else:
-        regex = rf"^{LABEL}(\.{LABEL})*\.?$"
+        regex = rf"^{label}(\.{zone_label})*\.?$"
 
     if not re.match(regex, name, flags=re.IGNORECASE) or has_invalid_double_dash(name):
         raise ValidationError(f"{name} is not a valid DNS domain name")

netbox_dns/views/zone.py

@@ -40,6 +40,7 @@ class ZoneView(generic.ObjectView):
         context = {
             "nameserver_warnings": ns_warnings,
             "nameserver_errors": ns_errors,
+            "parent_zone": instance.parent_zone,
         }
 
         name = dns_name.from_text(instance.name)
@@ -165,3 +166,22 @@ class ZoneRFC2317ChildZoneListView(generic.ObjectChildrenView):
 
     def get_children(self, request, parent):
         return parent.rfc2317_child_zones.all()
+
+
+@register_model_view(Zone, "child_zones")
+class ZoneChildZoneListView(generic.ObjectChildrenView):
+    queryset = Zone.objects.all()
+    child_model = Zone
+    table = ZoneTable
+    filterset = ZoneFilterSet
+    template_name = "netbox_dns/zone/child_zone.html"
+
+    tab = ViewTab(
+        label="Child Zones",
+        permission="netbox_dns.view_zone",
+        badge=lambda obj: obj.child_zones.count(),
+        hide_if_empty=True,
+    )
+
+    def get_children(self, request, parent):
+        return parent.child_zones

{netbox_plugin_dns-1.0.1.dist-info → netbox_plugin_dns-1.0.3.dist-info}/LICENSE

@@ -1,6 +1,7 @@
 MIT License
 
-Copyright (c) 2021 Aurora Research Lab
+Copyright (c) 2021-2023 Aurora Research Lab
+Copyright (c) 2023 Peter Eckel
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

{netbox_plugin_dns-1.0.1.dist-info → netbox_plugin_dns-1.0.3.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: netbox-plugin-dns
-Version: 1.0.1
+Version: 1.0.3
 Summary: NetBox DNS is a NetBox plugin for managing DNS data.
 Home-page: https://github.com/peteeckel/netbox-plugin-dns
 License: MIT
@@ -44,6 +44,7 @@ The main focus of the plugin is to ensure the quality of the data stored in it.
 * Validation of record names and values
 * Automatic maintenance of PTR records for IPv6 and IPv4 address records
 * Automatic generation of SOA records, optionally including the serial number of the zone data
+* Validation of changes to the SOA SERIAL number, whether they are done automatically or manually
 * Validation of record types such as CNAME and singletons, to ensure DNS zone validity
 * Support for [RFC 2317](https://datatracker.ietf.org/doc/html/rfc2317) delegation of PTR zones for IPv4 subnets longer than 24 bits
 

{netbox_plugin_dns-1.0.1.dist-info → netbox_plugin_dns-1.0.3.dist-info}/RECORD

@@ -1,4 +1,4 @@
-netbox_dns/__init__.py,sha256=zdgTkVLTJz0gaJh2i7N7iKc8fLnfdL3jrCkCSk4Njeg,1038
+netbox_dns/__init__.py,sha256=lhlLlERkb4Bbex6ypL5-ra35zq2Uro7qTZlC95JLmiI,1244
 netbox_dns/api/nested_serializers.py,sha256=kkTU4Hylkbam9-lIniv8E0nTQwE1bz8D_GzIEOUy0Mw,2145
 netbox_dns/api/serializers.py,sha256=C4-TP1luq9QjEHjPS5cW7u2flAEdIFjghpVd_sa5S_Y,249
 netbox_dns/api/serializers_/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -54,14 +54,16 @@ netbox_dns/migrations/0027_alter_registrar_iana_id.py,sha256=QUtRIrqqfkraFmzzeJF
 netbox_dns/migrations/0028_rfc2317_fields.py,sha256=D8r43xxBjYXiL6ycmX8RY5_WG7tRYEDjutOeYM1H56I,1364
 netbox_dns/migrations/0029_record_fqdn.py,sha256=UAAU38ekKQyiYDOJlcrz6Qbk4bqZfSHZyAHUZFFQrOw,808
 netbox_dns/migrations/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
+netbox_dns/mixins/__init__.py,sha256=LxTEfpod_RHCyMtnzDljv0_dwqp2z3Q6tqbXW8LTGD8,35
+netbox_dns/mixins/object_modification.py,sha256=wq01fyCAai2staM2g5wV9BbW1hDUeRdXfJrSSkc2YK8,726
 netbox_dns/models/__init__.py,sha256=Q7UIEe2vGh18AZN4er6CykciwXPQGgUq0L-9718wZqU,182
 netbox_dns/models/contact.py,sha256=xXmNGuM6k1U98jO3mMmp93PXamh1YZQ270JOcy0FFnE,2958
-netbox_dns/models/nameserver.py,sha256=DD1cp7uxSQFOS6gzMl65XCbNhcX3iDlVapeEYqI-1lo,3078
-netbox_dns/models/record.py,sha256=Hn6ag9imobkLKRkxuSqcQfk32l6JKRiZJp326w9lT0M,26016
+netbox_dns/models/nameserver.py,sha256=5Z0sFTqpxksCFCOExxXZEY_mpEVTKLMtFv5urD9yvdg,3121
+netbox_dns/models/record.py,sha256=BTMt9Tq-3v_fZcNeLZvlkZHfWYpfgwcLbbxdB6F1s5M,26476
 netbox_dns/models/registrar.py,sha256=yidjVCq7WPECsHLKQRRCSzGbvG2jIXu8lqAKox0SU5Q,1502
-netbox_dns/models/view.py,sha256=PykIODa9lc5duYoXF2ZM7mRnvk5aOh-2LZy7XbJdo0g,2633
-netbox_dns/models/zone.py,sha256=mU1aUwj2C0BddlV6fREuNbYvXleO95VxteGswGiH2To,28442
-netbox_dns/navigation.py,sha256=ykZJE5X-sqlnaTIU_pRzsio8Ux8zZVLH-iNsC2QqIxs,4062
+netbox_dns/models/view.py,sha256=HgQSpD8zQCxDpNel0b1_m4GlMYoRBpxiu6-Dtb1YnxI,2712
+netbox_dns/models/zone.py,sha256=eaFNlDdvfNn9Ky6sUUl2HA-_SkcWnYJzExB3GLDaoLo,28655
+netbox_dns/navigation.py,sha256=9NdvJ-0IIFvf3hMccoailepu7QLkVYEk0dpDxfuGo80,4572
 netbox_dns/signals/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 netbox_dns/signals/ipam_coupling.py,sha256=kJUKHUgq5XgWMhxB-312SPaZAYTLIYGgKO0lz2-z_rg,5594
 netbox_dns/tables/__init__.py,sha256=Aw8HrCTjaJfu5JSwJsQRHfOUz4zKwAmZNByT9q6BrFU,136
@@ -69,35 +71,36 @@ netbox_dns/tables/contact.py,sha256=guT_wC3NJMYbVbXeMOg6nqmmmDcnjfbRI-SkjFDEYdU,
 netbox_dns/tables/nameserver.py,sha256=8BfXzDXNuhZHEyHjGlL4EA1LYx7XU3EPGHlby0k33II,767
 netbox_dns/tables/record.py,sha256=VwBWMiZN_Lkl9SXfJLzd8-7TM1CKetwE7azhScF4r7I,3162
 netbox_dns/tables/registrar.py,sha256=6C8XpxvR9O7IoVK0RD5RoZgXjkm-ORSBeKP6KbwcjHA,648
-netbox_dns/tables/view.py,sha256=90nc1_gLxOdKNYsV6_fYbAglTmyQklxMzLjCEC5HmCU,692
+netbox_dns/tables/view.py,sha256=NaZmDVefmrRWF711_zOJqOmguU66LtI6bOZQ9ZdxniA,699
 netbox_dns/tables/zone.py,sha256=4TlTB7lVsztZJ41aetkqr6PWosjZP-xc2sB9gDnw0z8,1886
 netbox_dns/template_content.py,sha256=NmtfseYrYcU3RxzCI5okwCpMTfTEs4d8aJnDYwo4MO8,3801
 netbox_dns/templates/netbox_dns/contact.html,sha256=fMHAQyLXIxohKoCTxFEnKetl9UVXeQgjasfpv_JONaw,2855
 netbox_dns/templates/netbox_dns/nameserver.html,sha256=DpTdetQVV_jKThDbi62LvbhiCay-1QxR-yiJEiPFm4w,1554
 netbox_dns/templates/netbox_dns/record/managed.html,sha256=G6LPG1koUGuzUiwYdv1okdVa4sKaofiQegDBnsFL0kA,89
 netbox_dns/templates/netbox_dns/record/related.html,sha256=Aqor8uGcuHQTHjlX-Xmni2Yp4N7lOBrMOqQiszrQOC0,742
-netbox_dns/templates/netbox_dns/record.html,sha256=uJfZSgBcWpVXMfOwROmV5P73KS94caenvxxgsKG4qVA,5498
+netbox_dns/templates/netbox_dns/record.html,sha256=WtEkWy_CstGWE9UDFsATxz0bNpP_Gx9joZusAYGHDFQ,5235
 netbox_dns/templates/netbox_dns/registrar.html,sha256=O5veGmW59Pf5yN25ihPLvRIkA2P7xmSGv0G3NrRG8vI,2152
 netbox_dns/templates/netbox_dns/related_dns_objects.html,sha256=KSzlnw1cStrJa3poKkwrt_ycIH0oH0STWIHRNy3ks4g,806
 netbox_dns/templates/netbox_dns/view.html,sha256=XCa7Sg8fjSkhVqjLvw652FINQdWURLWdQqw8is82iaI,1499
 netbox_dns/templates/netbox_dns/zone/base.html,sha256=n_E4aVYdGeZZl-ARE8sb4DgAAgPs92X1UEFepX3xIlM,495
 netbox_dns/templates/netbox_dns/zone/child.html,sha256=kH56PJFBGCjiRdIh7zCtClnZdfOChqN_sYslsyoz5gU,2147
+netbox_dns/templates/netbox_dns/zone/child_zone.html,sha256=b9CSGWEfWT7hLQ80gApMnu7mXM8w2LT-3UaOYe6HIRQ,510
 netbox_dns/templates/netbox_dns/zone/managed_record.html,sha256=LOchMAJyfMZIICE6q0pX1eorRbtgUtOQ1u0VvJKCDZ8,514
 netbox_dns/templates/netbox_dns/zone/record.html,sha256=tu5RFm2eYJ3fjeUxZYDJqJ9qK8tGslXl1iGs60DlRyM,2194
 netbox_dns/templates/netbox_dns/zone/registration.html,sha256=de2Kph-G8Gv5LD_Wf294SLfO0UKPS9NmHeQYRfJf-Ck,1151
 netbox_dns/templates/netbox_dns/zone/rfc2317_child_zone.html,sha256=rWlmb3zRQbLYQ_1dsa0twwu6y1dRj2tfFVEERH07p-s,517
-netbox_dns/templates/netbox_dns/zone.html,sha256=K-jNmluO_TqOhv_DPBkJ8y0JF5zu9N574gkWCvVWruE,6633
+netbox_dns/templates/netbox_dns/zone.html,sha256=zPi1sLFnya-ytx8-Pcf_ujc1sKllCRuz48x2E-S1HSo,6285
 netbox_dns/urls/__init__.py,sha256=ky-ertisnz10vB18bi7JGwZwkvbRAeDErAqn621Xmbc,438
 netbox_dns/urls/contact.py,sha256=OSQO-AkAhTaBruAdzVgcC7ip_OuiacvFI_ozgkWlNFU,1549
 netbox_dns/urls/nameserver.py,sha256=BBbY-wqPqCquvLLv1_JhqToj7oDHhPNGCWHt0IfjBNM,1941
 netbox_dns/urls/record.py,sha256=bDprohTso1N0GtPXH4X3TNHnkxopiOSQFXWItifEZ_k,1432
 netbox_dns/urls/registrar.py,sha256=u6B0zGGYNUJIKTo9uGiUeZLPD0QMGaQOAPShGEy4NaA,1728
 netbox_dns/urls/view.py,sha256=8AeBnOHWusXXQs4JXpNfMSHqszXAY1GDXGWmNsMulQ8,1327
-netbox_dns/urls/zone.py,sha256=wYRAhtq695K0QSrvNj6gdFaf1gExEN5vwmYXLAA9FrU,1849
-netbox_dns/utilities/__init__.py,sha256=dVPi1gAGaRum-aQYi0oLgagRYrTVQNY5bmi2Ig02cOo,1835
+netbox_dns/urls/zone.py,sha256=rmB1BkzmWNG06ILUf-39Aj6-SBFkwQouyixMQiamqPc,2005
+netbox_dns/utilities/__init__.py,sha256=-6-qmb1yTAt9QEtGtokNFBQV_TSheobkLjbWFKEYpfw,1849
 netbox_dns/utilities/ipam_coupling.py,sha256=6z1Fx8fhesf15gLTHYc0KVqE3_YhJbNPAjqFOvWlqK8,3441
 netbox_dns/validators/__init__.py,sha256=5W8s31R1aT5B_mKJjTRwogEKj-Xun05iCyvRuYVGkdM,47
-netbox_dns/validators/dns_name.py,sha256=sxa0tyJw4Ep1uYw3nVsLZNqnykRbmn9pd7oAFDTKFp4,2449
+netbox_dns/validators/dns_name.py,sha256=rb4nd3zfVotoS0lZXfoHL7uTZWN2QPCIuf7uYxXsasg,2991
 netbox_dns/validators/rfc2317.py,sha256=L2Z-z5ghktFyWMLVZPeK8OEVGnQzbXD11fha2xGHM5E,501
 netbox_dns/views/__init__.py,sha256=Aw8HrCTjaJfu5JSwJsQRHfOUz4zKwAmZNByT9q6BrFU,136
 netbox_dns/views/contact.py,sha256=mBWM92UVjoz90JCUGO7kaFUI0_yA7tH4lSHxOZQB3MQ,2253
@@ -105,8 +108,8 @@ netbox_dns/views/nameserver.py,sha256=Sxl1h8v1W-uP0Qxz-Re0Ei1LgnWJuQGjI7ZaHS7qLe
 netbox_dns/views/record.py,sha256=DDHbxQ33P_mduoPquvyXrdrqNT6r79qShLg1uJzU4Ic,4347
 netbox_dns/views/registrar.py,sha256=NK6jTYRwRjaVjYmI7T4Phh_gjXg9yPrxl-7vciZ9doc,2090
 netbox_dns/views/view.py,sha256=a3l6pybhqGb_RMxrRgFT1Gia9tRq8EmXFxPv9WUId0U,1913
-netbox_dns/views/zone.py,sha256=EqkjXuX1xhkjDgaSNgFBvnA74IhuK_zDWlHPb3_4YKQ,4591
-netbox_plugin_dns-1.0.1.dist-info/LICENSE,sha256=tziMJKpkMbySr09L6bIwsu7Ca9ICoqpMO3yAXgEMQA4,1076
-netbox_plugin_dns-1.0.1.dist-info/METADATA,sha256=v3F-UQK6_k3KOOE8lQZgls9hfvL2hxwje1Bm7aCBZQ0,6048
-netbox_plugin_dns-1.0.1.dist-info/WHEEL,sha256=sP946D7jFCHeNz5Iq4fL4Lu-PrWrFsgfLXbbkciIZwg,88
-netbox_plugin_dns-1.0.1.dist-info/RECORD,,
+netbox_dns/views/zone.py,sha256=bOWnHtnlYH8BiB3L7ZKJLqS_VVOYCEFZNnOxbmFmsNY,5161
+netbox_plugin_dns-1.0.3.dist-info/LICENSE,sha256=I3tDu11bZfhFm3EkV4zOD5TmWgLjnUNLEFwrdjniZYs,1112
+netbox_plugin_dns-1.0.3.dist-info/METADATA,sha256=xdA1apPJLWo-Y9QDq5pXYx-acxDhf1vTOynMISktZU8,6146
+netbox_plugin_dns-1.0.3.dist-info/WHEEL,sha256=sP946D7jFCHeNz5Iq4fL4Lu-PrWrFsgfLXbbkciIZwg,88
+netbox_plugin_dns-1.0.3.dist-info/RECORD,,