nautobot 2.4.9__py3-none-any.whl → 2.4.11__py3-none-any.whl

nautobot/dcim/tests/test_models.py

@@ -50,6 +50,7 @@ from nautobot.dcim.models import (
     Module,
     ModuleBay,
     ModuleBayTemplate,
+    ModuleFamily,
     ModuleType,
     Platform,
     PowerOutlet,
@@ -3404,6 +3405,130 @@ class ModuleTestCase(ModelTestCases.BaseModelTestCase):
         )
         self.assertEqual(child_module.interfaces.first().name, "Interface " + module_bay_position + "/3/2")
 
+    def test_module_manufacturer_constraint_requires_first_party_false(self):
+        """Test that modules are allowed when requires_first_party_modules is False, regardless of manufacturer."""
+        manufacturer = Manufacturer.objects.create(name="Different Manufacturer")
+        module_type = ModuleType.objects.create(manufacturer=manufacturer, model="Different Module")
+        module_bay = ModuleBay.objects.create(
+            parent_device=self.device, position="test1", requires_first_party_modules=False
+        )
+        module = Module(
+            module_type=module_type,
+            parent_module_bay=module_bay,
+            status=self.status,
+        )
+
+        module.full_clean()
+        module.save()
+
+    def test_module_manufacturer_constraint_device_parent_same_manufacturer(self):
+        """Test that modules are allowed when requires_first_party_modules is True and manufacturers match."""
+        device_manufacturer = self.device.device_type.manufacturer
+        module_type = ModuleType.objects.create(manufacturer=device_manufacturer, model="Same Manufacturer Module")
+        module_bay = ModuleBay.objects.create(
+            parent_device=self.device, position="test2", requires_first_party_modules=True
+        )
+        module = Module(
+            module_type=module_type,
+            parent_module_bay=module_bay,
+            status=self.status,
+        )
+
+        module.full_clean()
+        module.save()
+
+    def test_module_manufacturer_constraint_device_parent_different_manufacturer(self):
+        """Test that modules are rejected when requires_first_party_modules is True and manufacturers don't match."""
+        manufacturer = Manufacturer.objects.create(name="Different Manufacturer")
+        module_type = ModuleType.objects.create(manufacturer=manufacturer, model="Different Module")
+        module_bay = ModuleBay.objects.create(
+            parent_device=self.device, position="test3", requires_first_party_modules=True
+        )
+        module = Module(
+            module_type=module_type,
+            parent_module_bay=module_bay,
+            status=self.status,
+        )
+
+        with self.assertRaises(ValidationError) as context:
+            module.full_clean()
+
+        self.assertIn("module_type", context.exception.message_dict)
+        self.assertIn(
+            "The selected module bay requires a module type from the same manufacturer as the parent device or module",
+            context.exception.message_dict["module_type"],
+        )
+
+    def test_module_manufacturer_constraint_module_parent_same_manufacturer(self):
+        """Test that modules are allowed when requires_first_party_modules is True and manufacturers match."""
+        manufacturer = Manufacturer.objects.create(name="Parent Manufacturer")
+        parent_module_type = ModuleType.objects.create(manufacturer=manufacturer, model="Parent Module")
+        ModuleBayTemplate.objects.create(module_type=parent_module_type, position="child1")
+
+        parent_module = Module.objects.create(
+            module_type=parent_module_type,
+            location=self.location,
+            status=self.status,
+        )
+        child_module_type = ModuleType.objects.create(manufacturer=manufacturer, model="Child Module")
+        parent_module_bay = parent_module.module_bays.first()
+        parent_module_bay.requires_first_party_modules = True
+        parent_module_bay.save()
+
+        child_module = Module(
+            module_type=child_module_type,
+            parent_module_bay=parent_module_bay,
+            status=self.status,
+        )
+
+        child_module.full_clean()
+        child_module.save()
+
+    def test_module_manufacturer_constraint_module_parent_different_manufacturer(self):
+        """Test that modules are rejected when requires_first_party_modules is True and manufacturers don't match."""
+        parent_manufacturer = Manufacturer.objects.create(name="Parent Manufacturer")
+        parent_module_type = ModuleType.objects.create(manufacturer=parent_manufacturer, model="Parent Module")
+        ModuleBayTemplate.objects.create(module_type=parent_module_type, position="child2")
+
+        parent_module = Module.objects.create(
+            module_type=parent_module_type,
+            location=self.location,
+            status=self.status,
+        )
+        child_manufacturer = Manufacturer.objects.create(name="Child Manufacturer")
+        child_module_type = ModuleType.objects.create(manufacturer=child_manufacturer, model="Child Module")
+        parent_module_bay = parent_module.module_bays.first()
+        parent_module_bay.requires_first_party_modules = True
+        parent_module_bay.save()
+
+        child_module = Module(
+            module_type=child_module_type,
+            parent_module_bay=parent_module_bay,
+            status=self.status,
+        )
+
+        with self.assertRaises(ValidationError) as context:
+            child_module.full_clean()
+
+        self.assertIn("module_type", context.exception.message_dict)
+        self.assertIn(
+            "The selected module bay requires a module type from the same manufacturer as the parent device or module",
+            context.exception.message_dict["module_type"],
+        )
+
+    def test_module_manufacturer_constraint_no_parent_module_bay(self):
+        """Test that manufacturer constraint validation is skipped when parent_module_bay is None."""
+        manufacturer = Manufacturer.objects.create(name="Any Manufacturer")
+        module_type = ModuleType.objects.create(manufacturer=manufacturer, model="Any Module")
+        module = Module(
+            module_type=module_type,
+            location=self.location,
+            status=self.status,
+        )
+
+        module.full_clean()
+        module.save()
+
 
 class ModuleTypeTestCase(ModelTestCases.BaseModelTestCase):
     model = ModuleType
@@ -3507,3 +3632,24 @@ class VirtualDeviceContextTestCase(ModelTestCases.BaseModelTestCase):
             vdc.validated_save()
 
         self.assertIn("Virtual Device Context's device cannot be changed once created", str(err.exception))
+
+
+class ModuleFamilyTestCase(ModelTestCases.BaseModelTestCase):
+    """Test cases for the ModuleFamily model."""
+
+    model = ModuleFamily
+
+    def setUp(self):
+        """Create a ModuleFamily for use in test methods."""
+        self.module_family = ModuleFamily.objects.create(
+            name="Test Module Family", description="A module family for testing"
+        )
+
+    def test_create_modulefamily(self):
+        """Test the creation of a ModuleFamily instance."""
+        self.assertEqual(self.module_family.name, "Test Module Family")
+        self.assertEqual(self.module_family.description, "A module family for testing")
+
+    def test_modulefamily_str(self):
+        """Test string representation of ModuleFamily."""
+        self.assertEqual(str(self.module_family), "Test Module Family")

nautobot/dcim/tests/test_views.py

@@ -85,6 +85,7 @@ from nautobot.dcim.models import (
     Module,
     ModuleBay,
     ModuleBayTemplate,
+    ModuleFamily,
     ModuleType,
     Platform,
     PowerFeed,
@@ -2007,6 +2008,7 @@ class ModuleBayTemplateTestCase(ViewTestCases.DeviceComponentTemplateViewTestCas
     def setUpTestData(cls):
         device_type = DeviceType.objects.first()
         module_type = ModuleType.objects.first()
+        module_family = ModuleFamily.objects.create(name="Test Module Family")
 
         cls.form_data = {
             "device_type": device_type.pk,
@@ -2015,6 +2017,7 @@ class ModuleBayTemplateTestCase(ViewTestCases.DeviceComponentTemplateViewTestCas
             "position": "Test modulebaytemplate position",
             "description": "Test modulebaytemplate description",
             "label": "Test modulebaytemplate label",
+            "module_family": module_family.pk,
         }
 
         cls.bulk_create_data = {
@@ -2023,10 +2026,12 @@ class ModuleBayTemplateTestCase(ViewTestCases.DeviceComponentTemplateViewTestCas
             "position_pattern": "Test Module Bay Template Position [10-12]",
             "label_pattern": "Test modulebaytemplate label [1-3]",
             "description": "Test modulebaytemplate description",
+            "module_family": module_family.pk,
         }
 
         cls.bulk_edit_data = {
             "description": "Description changed",
+            "module_family": module_family.pk,
         }
 
         test_instance = cls.model.objects.first()
@@ -2037,6 +2042,7 @@ class ModuleBayTemplateTestCase(ViewTestCases.DeviceComponentTemplateViewTestCas
             "position": "new test position",
             "label": "new test label",
             "description": "new test description",
+            "module_family": module_family.pk,
         }
 
 
@@ -2560,6 +2566,16 @@ class DeviceTestCase(ViewTestCases.PrimaryObjectViewTestCase):
 
 class ModuleTestCase(ViewTestCases.PrimaryObjectViewTestCase):
     model = Module
+    custom_action_required_permissions = {
+        "dcim:module_consoleports": ["dcim.view_module", "dcim.view_consoleport"],
+        "dcim:module_consoleserverports": ["dcim.view_module", "dcim.view_consoleserverport"],
+        "dcim:module_powerports": ["dcim.view_module", "dcim.view_powerport"],
+        "dcim:module_poweroutlets": ["dcim.view_module", "dcim.view_poweroutlet"],
+        "dcim:module_interfaces": ["dcim.view_module", "dcim.view_interface"],
+        "dcim:module_rearports": ["dcim.view_module", "dcim.view_rearport"],
+        "dcim:module_frontports": ["dcim.view_module", "dcim.view_frontport"],
+        "dcim:module_modulebays": ["dcim.view_module", "dcim.view_modulebay"],
+    }
 
     @classmethod
     def setUpTestData(cls):
@@ -2668,50 +2684,6 @@ class ModuleTestCase(ViewTestCases.PrimaryObjectViewTestCase):
             "status": statuses[2].pk,
         }
 
-    @override_settings(EXEMPT_VIEW_PERMISSIONS=["*"])
-    def test_module_consoleports(self):
-        module = Module.objects.first()
-
-        ConsolePort.objects.create(module=module, name="Console Port 1")
-        ConsolePort.objects.create(module=module, name="Console Port 2")
-        ConsolePort.objects.create(module=module, name="Console Port 3")
-
-        url = reverse("dcim:module_consoleports", kwargs={"pk": module.pk})
-        self.assertHttpStatus(self.client.get(url), 200)
-
-    @override_settings(EXEMPT_VIEW_PERMISSIONS=["*"])
-    def test_module_consoleserverports(self):
-        module = Module.objects.first()
-
-        ConsoleServerPort.objects.create(module=module, name="Console Server Port 1")
-        ConsoleServerPort.objects.create(module=module, name="Console Server Port 2")
-        ConsoleServerPort.objects.create(module=module, name="Console Server Port 3")
-
-        url = reverse("dcim:module_consoleserverports", kwargs={"pk": module.pk})
-        self.assertHttpStatus(self.client.get(url), 200)
-
-    @override_settings(EXEMPT_VIEW_PERMISSIONS=["*"])
-    def test_module_powerports(self):
-        module = Module.objects.first()
-
-        PowerPort.objects.create(module=module, name="Power Port 1")
-        PowerPort.objects.create(module=module, name="Power Port 2")
-        PowerPort.objects.create(module=module, name="Power Port 3")
-
-        url = reverse("dcim:module_powerports", kwargs={"pk": module.pk})
-        self.assertHttpStatus(self.client.get(url), 200)
-
-    @override_settings(EXEMPT_VIEW_PERMISSIONS=["*"])
-    def test_module_poweroutlets(self):
-        module = Module.objects.first()
-
-        PowerOutlet.objects.create(module=module, name="Power Outlet 1")
-        PowerOutlet.objects.create(module=module, name="Power Outlet 2")
-        PowerOutlet.objects.create(module=module, name="Power Outlet 3")
-
-        url = reverse("dcim:module_poweroutlets", kwargs={"pk": module.pk})
-        self.assertHttpStatus(self.client.get(url), 200)
-
     @override_settings(EXEMPT_VIEW_PERMISSIONS=["*"])
     def test_module_interfaces(self):
         module = Module.objects.filter(interfaces__isnull=False).first()
@@ -2793,59 +2765,6 @@ class ModuleTestCase(ViewTestCases.PrimaryObjectViewTestCase):
                 sorted(interface_ips),
             )
 
-    @override_settings(EXEMPT_VIEW_PERMISSIONS=["*"])
-    def test_module_rearports(self):
-        module = Module.objects.first()
-
-        RearPort.objects.create(module=module, name="Rear Port 1")
-        RearPort.objects.create(module=module, name="Rear Port 2")
-        RearPort.objects.create(module=module, name="Rear Port 3")
-
-        url = reverse("dcim:module_rearports", kwargs={"pk": module.pk})
-        self.assertHttpStatus(self.client.get(url), 200)
-
-    @override_settings(EXEMPT_VIEW_PERMISSIONS=["*"])
-    def test_module_frontports(self):
-        module = Module.objects.first()
-        rear_ports = (
-            RearPort.objects.create(module=module, name="Rear Port 1"),
-            RearPort.objects.create(module=module, name="Rear Port 2"),
-            RearPort.objects.create(module=module, name="Rear Port 3"),
-        )
-
-        FrontPort.objects.create(
-            module=module,
-            name="Front Port 1",
-            rear_port=rear_ports[0],
-            rear_port_position=1,
-        )
-        FrontPort.objects.create(
-            module=module,
-            name="Front Port 2",
-            rear_port=rear_ports[1],
-            rear_port_position=1,
-        )
-        FrontPort.objects.create(
-            module=module,
-            name="Front Port 3",
-            rear_port=rear_ports[2],
-            rear_port_position=1,
-        )
-
-        url = reverse("dcim:module_frontports", kwargs={"pk": module.pk})
-        self.assertHttpStatus(self.client.get(url), 200)
-
-    @override_settings(EXEMPT_VIEW_PERMISSIONS=["*"])
-    def test_module_modulebays(self):
-        module = Module.objects.first()
-
-        ModuleBay.objects.create(parent_module=module, name="Test View Module Bay 1")
-        ModuleBay.objects.create(parent_module=module, name="Test View Module Bay 2")
-        ModuleBay.objects.create(parent_module=module, name="Test View Module Bay 3")
-
-        url = reverse("dcim:module_modulebays", kwargs={"pk": module.pk})
-        self.assertHttpStatus(self.client.get(url), 200)
-
 
 class ConsolePortTestCase(ViewTestCases.DeviceComponentViewTestCase):
     model = ConsolePort
@@ -4587,6 +4506,15 @@ class InterfaceRedundancyGroupTestCase(ViewTestCases.PrimaryObjectViewTestCase):
 class SoftwareImageFileTestCase(ViewTestCases.PrimaryObjectViewTestCase):
     model = SoftwareImageFile
     filterset = SoftwareImageFileFilterSet
+    custom_action_required_permissions = {
+        "dcim:softwareimagefile_devices": ["dcim.view_softwareimagefile", "dcim.view_device"],
+        "dcim:softwareimagefile_device_types": ["dcim.view_softwareimagefile", "dcim.view_devicetype"],
+        "dcim:softwareimagefile_virtual_machines": [
+            "dcim.view_softwareimagefile",
+            "virtualization.view_virtualmachine",
+        ],
+        "dcim:softwareimagefile_inventory_items": ["dcim.view_softwareimagefile", "dcim.view_inventoryitem"],
+    }
 
     @classmethod
     def setUpTestData(cls):
@@ -4659,6 +4587,12 @@ class SoftwareVersionTestCase(ViewTestCases.PrimaryObjectViewTestCase):
 class ControllerTestCase(ViewTestCases.PrimaryObjectViewTestCase):
     model = Controller
     filterset = ControllerFilterSet
+    custom_action_required_permissions = {
+        "dcim:controller_wirelessnetworks": [
+            "dcim.view_controller",
+            "wireless.view_controllermanageddevicegroupwirelessnetworkassignment",
+        ],
+    }
 
     @classmethod
     def setUpTestData(cls):
@@ -4695,6 +4629,16 @@ class ControllerTestCase(ViewTestCases.PrimaryObjectViewTestCase):
 class ControllerManagedDeviceGroupTestCase(ViewTestCases.PrimaryObjectViewTestCase):
     model = ControllerManagedDeviceGroup
     filterset = ControllerManagedDeviceGroupFilterSet
+    custom_action_required_permissions = {
+        "dcim:controllermanageddevicegroup_wireless_networks": [
+            "dcim.view_controllermanageddevicegroup",
+            "wireless.view_controllermanageddevicegroupwirelessnetworkassignment",
+        ],
+        "dcim:controllermanageddevicegroup_radio_profiles": [
+            "dcim.view_controllermanageddevicegroup",
+            "wireless.view_radioprofile",
+        ],
+    }
 
     @classmethod
     def setUpTestData(cls):
@@ -4781,3 +4725,32 @@ class VirtualDeviceContextTestCase(ViewTestCases.PrimaryObjectViewTestCase):
         vdc.refresh_from_db()
         self.assertEqual(vdc.primary_ip6, ip_v6)
         self.assertEqual(vdc.primary_ip4, ip_v4)
+
+
+class ModuleFamilyTestCase(ViewTestCases.PrimaryObjectViewTestCase):
+    """Test cases for ModuleFamily views."""
+
+    model = ModuleFamily
+
+    @classmethod
+    def setUpTestData(cls):
+        """Create test data for ModuleFamily views."""
+        ModuleFamily.objects.create(name="Module Family 1", description="First Module Family")
+        ModuleFamily.objects.create(name="Module Family 2", description="Second Module Family")
+        ModuleFamily.objects.create(name="Module Family 3", description="Third Module Family")
+
+        cls.form_data = {
+            "name": "Module Family X",
+            "description": "A new module family",
+        }
+
+        cls.csv_data = (
+            "name,description",
+            "Module Family 4,Fourth Module Family",
+            "Module Family 5,Fifth Module Family",
+            "Module Family 6,Sixth Module Family",
+        )
+
+        cls.bulk_edit_data = {
+            "description": "Modified description",
+        }

nautobot/dcim/urls.py

@@ -34,12 +34,14 @@ router.register("device-redundancy-groups", views.DeviceRedundancyGroupUIViewSet
 router.register("device-types", views.DeviceTypeUIViewSet)
 router.register("interface-redundancy-groups", views.InterfaceRedundancyGroupUIViewSet)
 router.register("interface-redundancy-groups-associations", views.InterfaceRedundancyGroupAssociationUIViewSet)
+router.register("locations", views.LocationUIViewSet)
 router.register("location-types", views.LocationTypeUIViewSet)
 router.register("manufacturers", views.ManufacturerUIViewSet)
-router.register("module-bays", views.ModuleBayUIViewSet)
 router.register("module-bay-templates", views.ModuleBayTemplateUIViewSet)
-router.register("modules", views.ModuleUIViewSet)
+router.register("module-bays", views.ModuleBayUIViewSet)
+router.register("module-families", views.ModuleFamilyUIViewSet)
 router.register("module-types", views.ModuleTypeUIViewSet)
+router.register("modules", views.ModuleUIViewSet)
 router.register("platforms", views.PlatformUIViewSet)
 router.register("power-feeds", views.PowerFeedUIViewSet)
 router.register("power-panels", views.PowerPanelUIViewSet)
@@ -51,26 +53,6 @@ router.register("virtual-device-contexts", views.VirtualDeviceContextUIViewSet)
 
 urlpatterns = [
     # Locations
-    path("locations/", views.LocationListView.as_view(), name="location_list"),
-    path("locations/add/", views.LocationEditView.as_view(), name="location_add"),
-    path("locations/edit/", views.LocationBulkEditView.as_view(), name="location_bulk_edit"),
-    path("locations/import/", views.LocationBulkImportView.as_view(), name="location_import"),  # 3.0 TODO: remove
-    path("locations/delete/", views.LocationBulkDeleteView.as_view(), name="location_bulk_delete"),
-    path("locations/<uuid:pk>/", views.LocationView.as_view(), name="location"),
-    path("locations/<uuid:pk>/edit/", views.LocationEditView.as_view(), name="location_edit"),
-    path("locations/<uuid:pk>/delete/", views.LocationDeleteView.as_view(), name="location_delete"),
-    path(
-        "locations/<uuid:pk>/changelog/",
-        ObjectChangeLogView.as_view(),
-        name="location_changelog",
-        kwargs={"model": Location},
-    ),
-    path(
-        "locations/<uuid:pk>/notes/",
-        ObjectNotesView.as_view(),
-        name="location_notes",
-        kwargs={"model": Location},
-    ),
     path(
         "locations/<uuid:pk>/migrate-data-to-contact/",
         views.MigrateLocationDataToContactView.as_view(),