nautobot 2.3.3__py3-none-any.whl → 2.3.5__py3-none-any.whl

nautobot/core/celery/schedulers.py

@@ -1,5 +1,5 @@
 from collections.abc import Mapping
-from datetime import datetime
+from datetime import datetime, timedelta
 import logging
 from pathlib import Path
 
@@ -83,7 +83,7 @@ class NautobotScheduleEntry(ModelEntry):
             # This will trigger the job to run at start_time
             # and avoid the heap block.
             if model.start_time:
-                model.last_run_at = model.last_run_at - datetime.timedelta(days=365 * 30)
+                model.last_run_at = model.last_run_at - timedelta(days=365 * 30)
 
         self.last_run_at = model.last_run_at
 

nautobot/core/settings.py

@@ -641,6 +641,8 @@ LOGIN_REDIRECT_URL = "home"
 CONSTANCE_BACKEND = "constance.backends.database.DatabaseBackend"
 CONSTANCE_DATABASE_PREFIX = "constance:nautobot:"
 CONSTANCE_DATABASE_CACHE_BACKEND = "default"
+# Constance defaults to a 24-hour timeout when autofilling its cache, which is undesirable in many cases.
+CONSTANCE_DATABASE_CACHE_AUTOFILL_TIMEOUT = int(os.getenv("NAUTOBOT_CACHES_TIMEOUT", "300"))
 CONSTANCE_IGNORE_ADMIN_VERSION_CHECK = True  # avoid potential errors in a multi-node deployment
 
 CONSTANCE_ADDITIONAL_FIELDS = {
@@ -853,7 +855,7 @@ CACHES = {
             "django_prometheus.cache.backends.redis.RedisCache" if METRICS_ENABLED else "django_redis.cache.RedisCache",
         ),
         "LOCATION": parse_redis_connection(redis_database=1),
-        "TIMEOUT": 300,
+        "TIMEOUT": int(os.getenv("NAUTOBOT_CACHES_TIMEOUT", "300")),
         "OPTIONS": {
             "CLIENT_CLASS": "django_redis.client.DefaultClient",
             "PASSWORD": "",

nautobot/core/settings.yaml

@@ -47,7 +47,7 @@ properties:
     description: >-
       A list of valid fully-qualified domain names (FQDNs) and/or IP addresses that can be used to reach the
       Nautobot service. (If provided as an environment variable, it should be a space-separated string, for example
-      `NAUTOBOT_ALLOWED_HOSTS="localhost 127.0.0.1 example.com"`)
+      `NAUTOBOT_ALLOWED_HOSTS="localhost 127.0.0.1 nautobot.example.com"`)
     details: |-
       Usually this is the same as the hostname for the Nautobot server, but can also be different; for example,
       when using a reverse proxy serving the Nautobot website under a different FQDN than the hostname of the
@@ -70,7 +70,7 @@ properties:
 
       !!! tip
           If there is more than one hostname in this list, you may also need to set
-          [CSRF_TRUSTED_ORIGINS](optional-settings.md#csrf_trusted_origins) as well.
+          [CSRF_TRUSTED_ORIGINS](settings.md#csrf_trusted_origins) as well.
 
       If you are not yet sure what the domain name and/or IP address of the Nautobot installation will be,
       and are comfortable accepting the risks in doing so, you can set this to a wildcard (asterisk) to
@@ -83,7 +83,6 @@ properties:
       !!! warning
           It is not recommended to leave this value as `['*']` for production deployments.
     environment_variable: "NAUTOBOT_ALLOWED_HOSTS"
-    is_required_setting: true
     items:
       type: "string"
     see_also:
@@ -297,19 +296,21 @@ properties:
         TIMEOUT: 300
     description: "The `CACHES` setting is required to simplify the configuration for `django-redis`."
     details: |-
-      The [`django-redis`](https://github.com/jazzband/django-redis) Django plugin is used to enable Redis
-      as a concurrent write lock for preventing race conditions when allocating IP address objects.
+      The [`django-redis`](https://github.com/jazzband/django-redis) Django plugin is used to enable Redis as a
+      concurrent write lock for preventing race conditions when allocating IP address objects.
+      Nautobot also uses the built-in [Django cache framework](https://docs.djangoproject.com/en/stable/topics/cache/)
+      (which also relies on the `CACHES` setting) to perform caching. This includes caching of the values of
+      [administratively configurable settings](#administratively-configurable-settings) as stored in the database.
 
-      !!! important
-          Nautobot also utilizes the built-in
-          [Django cache framework](https://docs.djangoproject.com/en/stable/topics/cache/)
-          (which also relies on the `CACHES` setting) to perform caching.
-
-      +/- 2.0.0
-          The default value of `CACHES["default"]["LOCATION"]` has changed from `redis://localhost:6379/0`
-          to `redis://localhost:6379/1`, as Django's native caching is now taking the role previously occupied by
-          `django-cacheops`.
-    is_required_setting: true
+      !!! tip
+          Rather than directly setting `CACHES["default"]["LOCATION"]`, we recommend managing this setting via
+          the various `NAUTOBOT_REDIS_*` environment variables, as those variables apply to both `CACHES` and
+          [`CELERY_BROKER_URL`](#celery_broker_url) alike, which is typically preferable.
+
+      +++ 2.3.4 "`NAUTOBOT_CACHES_TIMEOUT` environment variable"
+          Added support for the environment variable `NAUTOBOT_CACHES_TIMEOUT` for configuring the
+          `CACHES["default"]["TIMEOUT"]` setting. This environment variable also controls the cache timeout
+          for administratively configurable settings.
     properties:
       default:
         properties:
@@ -322,6 +323,13 @@ properties:
             type: "string"
           LOCATION:
             default: "redis://localhost:6379/1"
+            environment_variables:
+            - "NAUTOBOT_REDIS_SCHEME"
+            - "NAUTOBOT_REDIS_SSL"
+            - "NAUTOBOT_REDIS_USERNAME"
+            - "NAUTOBOT_REDIS_PASSWORD"
+            - "NAUTOBOT_REDIS_HOST"
+            - "NAUTOBOT_REDIS_PORT"
             format: "uri"
             type: "string"
           OPTIONS:
@@ -336,10 +344,11 @@ properties:
             type: "object"
           TIMEOUT:
             default: 300
+            environment_variable: "NAUTOBOT_CACHES_TIMEOUT"
             type: "integer"
         type: "object"
     see_also:
-      "Guide to Nautobot Caching, including TLS and HA configuration": "../../administration/guides/caching.md"
+      "Guide to Nautobot Redis configuration, including TLS and HA configuration": "redis.md"
     type: "object"
   CELERY_BEAT_HEARTBEAT_FILE:
     default: "/tmp/nautobot_celery_beat_heartbeat"
@@ -351,8 +360,7 @@ properties:
     default: {}
     description: "A dict of additional options passed to the Celery broker transport."
     details: >-
-      This is only required when
-      [configuring Celery to utilize Redis Sentinel](../../administration/guides/caching.md#celery-sentinel-configuration).
+      This is only required when [configuring Celery to utilize Redis Sentinel](redis.md#celery-sentinel-configuration).
     properties:
       master_name:
         type: "string"
@@ -366,7 +374,18 @@ properties:
   CELERY_BROKER_URL:
     default: "redis://localhost:6379/0"
     description: "Celery broker URL used to tell workers where queues are located."
-    environment_variable: "NAUTOBOT_CELERY_BROKER_URL"
+    details: >-
+      If the `NAUTOBOT_CELERY_BROKER_URL` environment variable is not set, the default for this setting will be
+      influenced by the various `NAUTOBOT_REDIS_*` environment variables instead, which is often preferable as those
+      variables also influence the [`CACHES`](#caches) configuration as well.
+    environment_variables:
+    - "NAUTOBOT_CELERY_BROKER_URL"
+    - "NAUTOBOT_REDIS_SCHEME"
+    - "NAUTOBOT_REDIS_SSL"
+    - "NAUTOBOT_REDIS_USERNAME"
+    - "NAUTOBOT_REDIS_PASSWORD"
+    - "NAUTOBOT_REDIS_HOST"
+    - "NAUTOBOT_REDIS_PORT"
     format: "uri"
     type: "string"
   CELERY_BROKER_USE_SSL:
@@ -628,7 +647,6 @@ properties:
 
           As of Nautobot 1.1.5 and later, if you have generated a new `nautobot_config.py` using
           `nautobot-server init`, this line is already present in your config and no action is required.
-    is_required_setting: true
     properties:
       default:
         additionalProperties: true
@@ -828,7 +846,7 @@ properties:
   FORCE_SCRIPT_NAME:
     default: null
     description: >-
-      If not None, this will be used as the value of the SCRIPT_NAME environment variable in any HTTP request.
+      If not None, this will be used as the value of the `SCRIPT_NAME` environment variable in any HTTP request.
     details: |-
       This setting can be used to override the server-provided value of `SCRIPT_NAME`, which is most commonly used
       for hosting Nautobot in a subdirectory (e.g. _example.com/nautobot/_).
@@ -1205,7 +1223,7 @@ properties:
       !!! note
           The Docker container normally attempts to run migrations on startup; however, if the database is
           in a read-only state the Docker container will fail to start. Setting the environment variable
-          [`NAUTOBOT_DOCKER_SKIP_INIT`](../installation-extras/docker.md#nautobot_docker_skip_init) to `true`
+          [`NAUTOBOT_DOCKER_SKIP_INIT`](../guides/docker.md#nautobot_docker_skip_init) to `true`
           will prevent the migrations from occurring.
 
       !!! note
@@ -1609,7 +1627,6 @@ properties:
           In the case of a highly available installation with multiple web servers, `SECRET_KEY` must be identical
           among all servers in order to maintain a persistent user session state.
     environment_variable: "NAUTOBOT_SECRET_KEY"
-    is_required_setting: true
     type: "string"
   SESSION_CACHE_ALIAS:
     default: "default"

nautobot/core/tests/runner.py

@@ -64,9 +64,16 @@ class NautobotTestRunner(DiscoverRunner):
             action="store_true",
             help="Save test database to a json fixture file to re-use on subsequent tests.",
         )
+        parser.add_argument(
+            "--no-reusedb",
+            action="store_false",
+            dest="reusedb",
+            help="Supplement to --keepdb; if --no-reusedb is set an existing database will NOT be reused.",
+        )
 
-    def __init__(self, cache_test_fixtures=False, **kwargs):
+    def __init__(self, cache_test_fixtures=False, reusedb=True, **kwargs):
         self.cache_test_fixtures = cache_test_fixtures
+        self.reusedb = reusedb
 
         # Assert "integration" hasn't been provided w/ --tag
         incoming_tags = kwargs.get("tags") or []
@@ -118,7 +125,9 @@ class NautobotTestRunner(DiscoverRunner):
                         connection.creation.create_test_db(
                             verbosity=self.verbosity,
                             autoclobber=not self.interactive,
-                            keepdb=self.keepdb,
+                            keepdb=self.keepdb
+                            # Extra check added for Nautobot:
+                            and self.reusedb,
                             serialize=connection.settings_dict["TEST"].get("SERIALIZE", True),
                         )
 
@@ -149,7 +158,7 @@ class NautobotTestRunner(DiscoverRunner):
                                     verbosity=self.verbosity,
                                     keepdb=self.keepdb
                                     # Extra check added for Nautobot:
-                                    and not settings.TEST_USE_FACTORIES,
+                                    and self.reusedb,
                                 )
 
                 # Configure all other connections as mirrors of the first one
@@ -179,9 +188,7 @@ class NautobotTestRunner(DiscoverRunner):
                         connection.creation.destroy_test_db(
                             suffix=str(index + 1),
                             verbosity=self.verbosity,
-                            keepdb=self.keepdb
-                            # Extra check added for Nautobot
-                            and not settings.TEST_USE_FACTORIES,
+                            keepdb=self.keepdb,
                         )
 
                 # Extra block added for Nautobot

nautobot/core/tests/test_settings_schema.py

@@ -35,10 +35,13 @@ SETTINGS_DOCUMENTATION_SCHEMA = {
         "environment_variable": {
             "type": "string",
         },
-        "is_constance_config": {
-            "type": "boolean",
+        "environment_variables": {
+            "type": "array",
+            "items": {
+                "type": "string",
+            },
         },
-        "is_required_setting": {
+        "is_constance_config": {
             "type": "boolean",
         },
         "see_also": {
@@ -122,6 +125,7 @@ class SettingsJSONSchemaTestCase(TestCase):
             "CONSTANCE_BACKEND",
             "CONSTANCE_CONFIG",
             "CONSTANCE_CONFIG_FIELDSETS",
+            "CONSTANCE_DATABASE_CACHE_AUTOFILL_TIMEOUT",
             "CONSTANCE_DATABASE_CACHE_BACKEND",
             "CONSTANCE_DATABASE_PREFIX",
             "CSRF_FAILURE_VIEW",

nautobot/core/tests/test_views.py

@@ -1,8 +1,9 @@
 import re
-from unittest import mock
+from unittest import mock, skipIf
 import urllib.parse
 
 from django.apps import apps
+from django.conf import settings
 from django.contrib.contenttypes.models import ContentType
 from django.core.files.uploadedfile import SimpleUploadedFile
 from django.test import override_settings, RequestFactory
@@ -572,3 +573,41 @@ class SilkUIAccessTestCase(TestCase):
 
         # Check for success status code (e.g., 200)
         self.assertEqual(response.status_code, 200)
+
+
+class ExampleViewWithCustomPermissionsTest(TestCase):
+    @skipIf(
+        "example_app" not in settings.PLUGINS,
+        "example_app not in settings.PLUGINS",
+    )
+    @override_settings(EXEMPT_VIEW_PERMISSIONS=[])
+    def test_permission_classes_attribute_is_enforced(self):
+        """
+        If example app is installed, check if the ViewWithCustomPermissions
+        is enforcing the permissions specified in its `permission_classes` attribute.
+        """
+        # Test IsAuthenticated permission
+        self.add_permissions("example_app.view_examplemodel")
+        self.client.logout()
+        url = reverse("plugins:example_app:view_with_custom_permissions")
+        response = self.client.get(url, follow=True)
+        self.assertHttpStatus(response, 200)
+        response_body = response.content.decode(response.charset)
+        # check if the user is redirected to the login page
+        self.assertIn(f'<input type="hidden" name="next" value="{url}" />', response_body)
+
+        # Test IsAdmin permission
+        self.client.force_login(self.user)
+        response = self.client.get(url, follow=True)
+        self.assertHttpStatus(response, 403)
+        response_body = response.content.decode(response.charset)
+        # check if the users have to have the permission to access the page
+        self.assertIn("You do not have permission to access this page.", response_body)
+
+        # View should be successfully accessed
+        self.user.is_staff = True
+        self.user.save()
+        response = self.client.get(url)
+        self.assertHttpStatus(response, 200)
+        response_body = response.content.decode(response.charset)
+        self.assertIn("You are viewing a table of example models", response_body)

nautobot/core/views/generic.py

@@ -17,7 +17,7 @@ from django.db.models import ManyToManyField, ProtectedError, Q
 from django.forms import Form, ModelMultipleChoiceField, MultipleHiddenInput
 from django.http import HttpResponse
 from django.shortcuts import get_object_or_404, redirect, render
-from django.urls import reverse
+from django.urls import resolve, reverse
 from django.utils.encoding import iri_to_uri
 from django.utils.html import format_html
 from django.utils.http import url_has_allowed_host_and_scheme
@@ -205,17 +205,16 @@ class ObjectListView(ObjectPermissionRequiredMixin, View):
         filter_form = None
         hide_hierarchy_ui = False
         clear_view = request.GET.get("clear_view", False)
+        resolved_path = resolve(request.path)
+        list_url = f"{resolved_path.app_name}:{resolved_path.url_name}"
 
         # If the user clicks on the clear view button, we do not check for global or user defaults
         if not clear_view and not request.GET.get("saved_view"):
             # Check if there is a default for this view for this specific user
-            app_label, model_name = model._meta.label.split(".")
-            view_name = f"{app_label}:{model_name.lower()}_list"
-
             if not isinstance(user, AnonymousUser):
                 try:
                     user_default_saved_view_pk = UserSavedViewAssociation.objects.get(
-                        user=user, view_name=view_name
+                        user=user, view_name=list_url
                     ).saved_view.pk
                     # Saved view should either belong to the user or be public
                     SavedView.objects.get(
@@ -229,7 +228,7 @@ class ObjectListView(ObjectPermissionRequiredMixin, View):
 
             # Check if there is a global default for this view
             try:
-                global_saved_view = SavedView.objects.get(view=view_name, is_global_default=True)
+                global_saved_view = SavedView.objects.get(view=list_url, is_global_default=True)
                 return redirect(reverse("extras:savedview", kwargs={"pk": global_saved_view.pk}))
             except ObjectDoesNotExist:
                 pass
@@ -302,7 +301,6 @@ class ObjectListView(ObjectPermissionRequiredMixin, View):
         table_config_form = None
         current_saved_view = None
         current_saved_view_pk = self.request.GET.get("saved_view", None)
-        list_url = validated_viewname(model, "list")
         # We are not using .restrict(request.user, "view") here
         # User should be able to see any saved view that he has the list view access to.
         if user.has_perms(["extras.view_savedview"]):
@@ -315,15 +313,17 @@ class ObjectListView(ObjectPermissionRequiredMixin, View):
                 SavedView.objects.filter(view=list_url, owner=user).order_by("name").only("pk", "name")
             )
             saved_views = shared_saved_views | user_owned_saved_views
+
+        if current_saved_view_pk:
+            try:
+                # We are not using .restrict(request.user, "view") here
+                # User should be able to see any saved view that he has the list view access to.
+                current_saved_view = SavedView.objects.get(view=list_url, pk=current_saved_view_pk)
+            except ObjectDoesNotExist:
+                messages.error(request, f"Saved view {current_saved_view_pk} not found")
+
+        # Construct the objects table
         if self.table:
-            # Construct the objects table
-            if current_saved_view_pk:
-                try:
-                    # We are not using .restrict(request.user, "view") here
-                    # User should be able to see any saved view that he has the list view access to.
-                    current_saved_view = SavedView.objects.get(view=list_url, pk=current_saved_view_pk)
-                except ObjectDoesNotExist:
-                    messages.error(request, f"Saved view {current_saved_view_pk} not found")
             if self.request.GET.getlist("sort") or (
                 current_saved_view is not None and current_saved_view.config.get("sort_order")
             ):

nautobot/core/views/mixins.py

@@ -234,6 +234,7 @@ class NautobotViewSetMixin(GenericViewSet, AccessMixin, GetReturnURLMixin, FormV
     serializer_class = None
     table_class = None
     notes_form_class = NoteForm
+    permission_classes = []
 
     def get_permissions_for_model(self, model, actions):
         """
@@ -267,7 +268,7 @@ class NautobotViewSetMixin(GenericViewSet, AccessMixin, GetReturnURLMixin, FormV
         """
         user = self.request.user
         permission_required = self.get_required_permission()
-        # Check that the user has been granted the required permission(s) one by one.
+        # Check that the user has been granted the required Nautobot-specific object permission(s) one by one.
         # In case the permission has `message` or `code`` attribute, we want to include those information in the permission_denied error.
         for permission in permission_required:
             # If the user does not have the permission required, we raise DRF's `NotAuthenticated` or `PermissionDenied` exception
@@ -280,6 +281,16 @@ class NautobotViewSetMixin(GenericViewSet, AccessMixin, GetReturnURLMixin, FormV
                     code=getattr(permission, "code", None),
                 )
 
+        # Check for drf-specific permissions (IsAutheticated, etc) in permission_classes which is empty by default.
+        # self.get_permissions() iterates through permissions specified in the `permission_classes` attribute.
+        for permission in self.get_permissions():
+            # If the user does not have the permission required, we raise DRF's `NotAuthenticated` or `PermissionDenied` exception
+            # which will be handled by self.handle_no_permission() in the UI appropriately in the dispatch() method
+            if not permission.has_permission(request, self):
+                self.permission_denied(
+                    request, message=getattr(permission, "message", None), code=getattr(permission, "code", None)
+                )
+
     def dispatch(self, request, *args, **kwargs):
         """
         Override the default dispatch() method to check permissions first.

nautobot/core/views/renderers.py

@@ -5,6 +5,7 @@ from django.contrib.contenttypes.models import ContentType
 from django.core.exceptions import ObjectDoesNotExist
 from django.db.models import Q
 from django.template import engines, loader
+from django.urls import resolve
 from django_tables2 import RequestConfig
 from rest_framework import renderers
 
@@ -295,7 +296,8 @@ class NautobotHTMLRenderer(renderers.BrowsableAPIRenderer):
             # Construct valid actions for list view.
             valid_actions = self.validate_action_buttons(view, request)
             # Query SavedViews for dropdown button
-            list_url = validated_viewname(model, "list")
+            resolved_path = resolve(request.path)
+            list_url = f"{resolved_path.app_name}:{resolved_path.url_name}"
             saved_views = None
             if model.is_saved_view_model:
                 # We are not using .restrict(request.user, "view") here

nautobot/core/views/utils.py

@@ -213,7 +213,7 @@ def handle_protectederror(obj_list, request, e):
     protected_objects = list(e.protected_objects)
     protected_count = len(protected_objects) if len(protected_objects) <= 50 else "More than 50"
     err_message = format_html(
-        "Unable to delete <strong>{}</strong>. {} dependent objects were found: ",
+        str(e.args[0]) if e.args else "Unable to delete <strong>{}</strong>. {} dependent objects were found: ",
         ", ".join(str(obj) for obj in obj_list),
         protected_count,
     )

nautobot/dcim/api/serializers.py

@@ -389,6 +389,7 @@ class RackElevationDetailFilterSerializer(serializers.Serializer):
     expand_devices = serializers.BooleanField(required=False, default=True)
     include_images = serializers.BooleanField(required=False, default=True)
     display_fullname = serializers.BooleanField(required=False, default=True)
+    is_occupied = serializers.BooleanField(required=False, allow_null=True, default=None)
 
     def validate(self, attrs):
         attrs.setdefault("unit_width", get_settings_or_config("RACK_ELEVATION_DEFAULT_UNIT_WIDTH"))

nautobot/dcim/api/views.py

@@ -231,6 +231,8 @@ class RackViewSet(NautobotModelViewSet):
                 exclude=data["exclude"],
                 expand_devices=data["expand_devices"],
             )
+            if data["is_occupied"] is not None:
+                elevation = [u for u in elevation if u["occupied"] == data["is_occupied"]]
 
             # Enable filtering rack units by ID
             q = data["q"]

nautobot/dcim/forms.py

@@ -1900,7 +1900,7 @@ class DeviceForm(LocatableModelFormMixin, NautobotModelForm, TenancyForm, LocalC
         widget=APISelect(
             api_url="/api/dcim/racks/{{rack}}/elevation/",
             attrs={
-                "disabled-indicator": "device",
+                "disabled-indicator": "occupied",
                 "data-query-param-face": '["$face"]',
             },
         ),

nautobot/dcim/tables/power.py

@@ -29,7 +29,7 @@ class PowerPanelTable(BaseTable):
     location = tables.Column(linkify=True)
     power_feed_count = LinkedCountColumn(
         viewname="dcim:powerfeed_list",
-        url_params={"power_panel_id": "pk"},
+        url_params={"power_panel": "pk"},
         verbose_name="Feeds",
     )
     tags = TagColumn(url_name="dcim:powerpanel_list")

nautobot/dcim/templates/dcim/devicefamily_retrieve.html

@@ -16,7 +16,7 @@
                 </tr>
                 <tr>
                     <td>Device Types</td>
-                    <td><a href="{% url 'dcim:devicetype_list' %}?device_family={{ object.name }}">{{ object.device_type_count }}</a></td>
+                    <td><a href="{% url 'dcim:devicetype_list' %}?device_family={{ object.name }}">{{ device_type_count }}</a></td>
                 </tr>
                 <tr>
                     <td>Total Devices</td>

nautobot/dcim/tests/test_api.py

@@ -139,7 +139,7 @@ class Mixins:
             super().setUpTestData()
             cls.device_type = DeviceType.objects.first()
             cls.manufacturer = cls.device_type.manufacturer
-            cls.location = Location.objects.filter(location_type=LocationType.objects.get(name="Campus")).first()
+            cls.location = Location.objects.filter(location_type__name="Campus").first()
             cls.device_role = Role.objects.get_for_model(Device).first()
             cls.device_status = Status.objects.get_for_model(Device).first()
             cls.device = Device.objects.create(
@@ -539,6 +539,8 @@ class RackGroupTest(APIViewTestCases.APIViewTestCase, APIViewTestCases.TreeModel
     def setUpTestData(cls):
         cls.status = Status.objects.get_for_model(Location).first()
         location_type = LocationType.objects.create(name="Location Type 1")
+        location_type.content_types.add(ContentType.objects.get_for_model(RackGroup))
+
         cls.locations = (
             Location.objects.create(name="Location 1", location_type=location_type, status=cls.status),
             Location.objects.create(name="Location 2", location_type=location_type, status=cls.status),
@@ -548,8 +550,6 @@ class RackGroupTest(APIViewTestCases.APIViewTestCase, APIViewTestCases.TreeModel
             RackGroup.objects.create(location=cls.locations[1], name="Parent Rack Group 2"),
         )
 
-        location_type.content_types.add(ContentType.objects.get_for_model(RackGroup))
-
         RackGroup.objects.create(
             location=cls.locations[0],
             name="Rack Group 1",
@@ -643,7 +643,9 @@ class RackTest(APIViewTestCases.APIViewTestCase):
 
     @classmethod
     def setUpTestData(cls):
-        locations = Location.objects.all()[:2]
+        locations = Location.objects.filter(devices__isnull=False)[:2]
+        for location in locations:
+            location.location_type.content_types.add(ContentType.objects.get_for_model(RackGroup))
 
         rack_groups = (
             RackGroup.objects.create(location=locations[0], name="Rack Group 1"),
@@ -675,6 +677,20 @@ class RackTest(APIViewTestCases.APIViewTestCase):
             status=statuses[0],
         )
 
+        populated_rack = Rack.objects.create(
+            location=locations[0],
+            rack_group=rack_groups[0],
+            role=rack_roles[0],
+            name="Populated Rack",
+            status=statuses[0],
+        )
+        # Place a device in Rack 4
+        device = Device.objects.filter(location=populated_rack.location, rack=None).first()
+        device.rack = populated_rack
+        device.face = "front"
+        device.position = 10
+        device.save()
+
         cls.create_data = [
             {
                 "name": "Test Rack 4",
@@ -742,6 +758,44 @@ class RackTest(APIViewTestCases.APIViewTestCase):
         response = self.client.get(url, params, **self.header)
         self.assertHttpStatus(response, 200)
 
+    def test_filter_rack_elevation_is_occupied(self):
+        """
+        Test filtering the list of rack elevations by occupied status.
+        """
+        rack = Rack.objects.get(name="Populated Rack")
+        self.add_permissions("dcim.view_rack")
+        url = reverse("dcim-api:rack-elevation", kwargs={"pk": rack.pk})
+        # Get all units first
+        params = {"face": "front"}
+        response = self.client.get(url, params, **self.header)
+        all_units = response.data["results"]
+        # Assert the count is equal to the number of units in the rack
+        self.assertEqual(len(all_units), rack.u_height)
+
+        # Next get only unoccupied units
+        params = {"face": "front", "is_occupied": False}
+        response = self.client.get(url, params, **self.header)
+        unoccupied_units = response.data["results"]
+        # Assert the count is more than 0
+        self.assertGreater(len(unoccupied_units), 0)
+        # Assert the unoccupied count is less than the total number of units
+        self.assertLess(len(unoccupied_units), len(all_units))
+
+        # Next get only occupied units
+        params = {"face": "front", "is_occupied": True}
+        response = self.client.get(url, params, **self.header)
+        occupied_units = response.data["results"]
+        # Assert the count is more than 0
+        self.assertGreater(len(occupied_units), 0)
+        # Assert the occupied count is less than the total number of units
+        self.assertLess(len(occupied_units), len(all_units))
+
+        # Assert that the sum of unoccupied and occupied units is equal to the total number of units
+        self.assertEqual(len(unoccupied_units) + len(occupied_units), len(all_units))
+        # Assert that the lists are mutually exclusive
+        self.assertEqual(len([unit for unit in unoccupied_units if unit in occupied_units]), 0)
+        self.assertEqual(len([unit for unit in occupied_units if unit in unoccupied_units]), 0)
+
     def test_get_rack_elevation_svg(self):
         """
         GET a single rack elevation in SVG format.

nautobot/dcim/tests/test_filters.py

@@ -3349,7 +3349,7 @@ class CableTestCase(FilterTestCases.FilterTestCase):
 
     def test_device(self):
         """Test that the device filter returns all cables for a device and its modules."""
-        interfaces = Interface.objects.filter(cable__isnull=True)[:3]
+        interfaces = list(Interface.objects.filter(cable__isnull=True)[:3])
         manufacturer = Manufacturer.objects.first()
         device_type = DeviceType.objects.create(
             manufacturer=manufacturer, model="Test Device Filter for Cable Device Type"

nautobot/dcim/tests/test_models.py

@@ -65,7 +65,6 @@ from nautobot.dcim.models import (
 from nautobot.extras import context_managers
 from nautobot.extras.choices import CustomFieldTypeChoices
 from nautobot.extras.models import CustomField, Role, SecretsGroup, Status
-from nautobot.ipam.factory import VLANGroupFactory
 from nautobot.ipam.models import IPAddress, IPAddressToInterface, Namespace, Prefix, VLAN, VLANGroup
 from nautobot.tenancy.models import Tenant
 from nautobot.users.models import User
@@ -2351,7 +2350,6 @@ class InterfaceTestCase(ModularDeviceComponentTestCaseMixin, ModelTestCases.Base
             vid=100,
             location=location_2,
             status=vlan_status,
-            vlan_group=VLANGroupFactory.create(location=location_2),
         )
 
         cls.namespace = Namespace.objects.create(name="dcim_test_interface_ip_addresses")