nautobot 2.1.0__py3-none-any.whl → 2.1.1__py3-none-any.whl

nautobot/extras/migrations/0101_externalintegration.py

@@ -1,13 +1,15 @@
 # Generated by Django 3.2.22 on 2023-11-01 21:29
 
+import uuid
+
 import django.core.serializers.json
 import django.core.validators
 from django.db import migrations, models
 import django.db.models.deletion
+
 import nautobot.core.models.fields
 import nautobot.core.models.validators
 import nautobot.extras.models.mixins
-import uuid
 
 
 class Migration(migrations.Migration):

nautobot/extras/models/__init__.py

@@ -1,6 +1,4 @@
 from .change_logging import ChangeLoggedModel, ObjectChange
-from .roles import Role, RoleField
-from .statuses import Status, StatusField, StatusModel
 from .customfields import ComputedField, CustomField, CustomFieldChoice, CustomFieldModel
 from .datasources import GitRepository
 from .groups import DynamicGroup, DynamicGroupMembership
@@ -29,10 +27,11 @@ from .models import (
     Webhook,
 )
 from .relationships import Relationship, RelationshipAssociation, RelationshipModel
+from .roles import Role, RoleField
 from .secrets import Secret, SecretsGroup, SecretsGroupAssociation
+from .statuses import Status, StatusField, StatusModel
 from .tags import Tag, TaggedItem
 
-
 __all__ = (
     "ChangeLoggedModel",
     "ComputedField",

nautobot/extras/models/change_logging.py

@@ -14,7 +14,6 @@ from nautobot.extras.choices import ObjectChangeActionChoices, ObjectChangeEvent
 from nautobot.extras.constants import CHANGELOG_MAX_CHANGE_CONTEXT_DETAIL, CHANGELOG_MAX_OBJECT_REPR
 from nautobot.extras.utils import extras_features
 
-
 #
 # Change logging
 #

nautobot/extras/models/customfields.py

@@ -1,14 +1,14 @@
+from collections import OrderedDict
+from datetime import date, datetime
 import logging
 import re
-from collections import OrderedDict
-from datetime import datetime, date
 
 from django import forms
-from django.db import models, transaction
 from django.contrib.contenttypes.models import ContentType
 from django.core.exceptions import ObjectDoesNotExist
 from django.core.serializers.json import DjangoJSONEncoder
 from django.core.validators import RegexValidator, ValidationError
+from django.db import models, transaction
 from django.forms.widgets import TextInput
 from django.utils.html import format_html
 
@@ -37,7 +37,7 @@ from nautobot.extras.choices import CustomFieldFilterLogicChoices, CustomFieldTy
 from nautobot.extras.models import ChangeLoggedModel
 from nautobot.extras.models.mixins import NotesMixin
 from nautobot.extras.tasks import delete_custom_field_data, update_custom_field_choice_data
-from nautobot.extras.utils import check_if_key_is_graphql_safe, FeatureQuery, extras_features
+from nautobot.extras.utils import check_if_key_is_graphql_safe, extras_features, FeatureQuery
 
 logger = logging.getLogger(__name__)
 

nautobot/extras/models/datasources.py

@@ -10,7 +10,7 @@ from django.db import models
 
 from nautobot.core.models.fields import AutoSlugField, slugify_dashes_to_underscores
 from nautobot.core.models.generics import PrimaryModel
-from nautobot.extras.utils import extras_features, check_if_key_is_graphql_safe
+from nautobot.extras.utils import check_if_key_is_graphql_safe, extras_features
 
 
 @extras_features(
@@ -152,8 +152,8 @@ class GitRepository(PrimaryModel):
             JobResult
         """
         from nautobot.extras.datasources import (
-            enqueue_pull_git_repository_and_refresh_data,
             enqueue_git_repository_diff_origin_and_local,
+            enqueue_pull_git_repository_and_refresh_data,
         )
 
         if dry_run:

nautobot/extras/models/groups.py

@@ -3,7 +3,6 @@
 import logging
 import pickle
 
-import django_filters
 from django import forms
 from django.contrib.contenttypes.models import ContentType
 from django.core.cache import cache
@@ -11,6 +10,7 @@ from django.core.exceptions import ValidationError
 from django.core.serializers.json import DjangoJSONEncoder
 from django.db import models
 from django.utils.functional import cached_property
+import django_filters
 
 from nautobot.core.forms.constants import BOOLEAN_WITH_BLANK_CHOICES
 from nautobot.core.forms.fields import DynamicModelChoiceField
@@ -20,10 +20,9 @@ from nautobot.core.models.generics import OrganizationalModel
 from nautobot.core.utils.config import get_settings_or_config
 from nautobot.core.utils.lookup import get_filterset_for_model, get_form_for_model
 from nautobot.extras.choices import DynamicGroupOperatorChoices
-from nautobot.extras.querysets import DynamicGroupQuerySet, DynamicGroupMembershipQuerySet
+from nautobot.extras.querysets import DynamicGroupMembershipQuerySet, DynamicGroupQuerySet
 from nautobot.extras.utils import extras_features
 
-
 logger = logging.getLogger(__name__)
 
 
@@ -336,7 +335,7 @@ class DynamicGroup(OrganizationalModel):
         try:
             cached_query = cache.get(self.members_cache_key)
             if cached_query is not None:
-                unpickled_query = pickle.loads(cached_query)
+                unpickled_query = pickle.loads(cached_query)  # noqa: S301  # suspicious-pickle-usage -- we know, but we control what's in the DB
         except pickle.UnpicklingError:
             logger.warning("Failed to unpickle cached members for %s", self)
         finally:

nautobot/extras/models/jobs.py

@@ -41,9 +41,9 @@ from nautobot.extras.constants import (
     JOB_MAX_NAME_LENGTH,
     JOB_OVERRIDABLE_FIELDS,
 )
+from nautobot.extras.managers import JobResultManager, ScheduledJobsManager
 from nautobot.extras.models import ChangeLoggedModel, GitRepository
 from nautobot.extras.models.mixins import NotesMixin
-from nautobot.extras.managers import JobResultManager, ScheduledJobsManager
 from nautobot.extras.querysets import JobQuerySet, ScheduledJobExtendedQuerySet
 from nautobot.extras.utils import (
     ChangeLoggedModelsQuery,
@@ -52,7 +52,6 @@ from nautobot.extras.utils import (
 
 from .customfields import CustomFieldModel
 
-
 logger = logging.getLogger(__name__)
 
 
@@ -453,9 +452,9 @@ class JobResult(BaseModel, CustomFieldModel):
         to="extras.Job", null=True, blank=True, on_delete=models.SET_NULL, related_name="job_results"
     )
     name = models.CharField(max_length=255, db_index=True)
-    task_name = models.CharField(
+    task_name = models.CharField(  # noqa: DJ001  # django-nullable-model-string-field
         max_length=255,
-        null=True,
+        null=True,  # TODO: should this be blank=True instead?
         db_index=True,
         help_text="Registered name of the Celery task for this job. Internal use only.",
     )
@@ -479,11 +478,15 @@ class JobResult(BaseModel, CustomFieldModel):
         verbose_name="Result Data",
         help_text="The data returned by the task",
     )
-    worker = models.CharField(max_length=100, default=None, null=True)
+    worker = models.CharField(  # noqa: DJ001  # django-nullable-model-string-field
+        max_length=100,
+        default=None,
+        null=True,  # TODO: should this be default="", blank=True instead?
+    )
     task_args = models.JSONField(blank=True, default=list, encoder=NautobotKombuJSONEncoder)
     task_kwargs = models.JSONField(blank=True, default=dict, encoder=NautobotKombuJSONEncoder)
     celery_kwargs = models.JSONField(blank=True, default=dict, encoder=NautobotKombuJSONEncoder)
-    traceback = models.TextField(blank=True, null=True)
+    traceback = models.TextField(blank=True, null=True)  # noqa: DJ001  # django-nullable-model-string-field -- TODO: can we remove null=True?
     meta = models.JSONField(null=True, default=None, editable=False)
     scheduled_job = models.ForeignKey(to="extras.ScheduledJob", on_delete=models.SET_NULL, null=True, blank=True)
 
@@ -797,6 +800,9 @@ class ScheduledJobs(models.Model):
 
     objects = ScheduledJobsManager()
 
+    def __str__(self):
+        return str(self.ident)
+
     @classmethod
     def changed(cls, instance, raw=False, **kwargs):
         """This function acts as a signal handler to track changes to the scheduled job that is triggered before a change"""

nautobot/extras/models/models.py

@@ -6,8 +6,8 @@ from db_file_storage.storage import DatabaseFileStorage
 from django.conf import settings
 from django.contrib.contenttypes.fields import GenericForeignKey
 from django.contrib.contenttypes.models import ContentType
-from django.core.files.storage import get_storage_class
 from django.core.exceptions import ValidationError
+from django.core.files.storage import get_storage_class
 from django.core.serializers.json import DjangoJSONEncoder
 from django.core.validators import MinValueValidator
 from django.db import models
@@ -37,7 +37,7 @@ from nautobot.extras.querysets import ConfigContextQuerySet, NotesQuerySet
 from nautobot.extras.utils import extras_features, FeatureQuery, image_upload
 
 # Avoid breaking backward compatibility on anything that might expect these to still be defined here:
-from .jobs import JOB_LOGS, Job, JobLogEntry, JobResult, ScheduledJob, ScheduledJobs  # noqa: F401
+from .jobs import Job, JOB_LOGS, JobLogEntry, JobResult, ScheduledJob, ScheduledJobs  # noqa: F401  # unused-import
 
 #
 # Config contexts

nautobot/extras/models/relationships.py

@@ -1,8 +1,8 @@
 import logging
 
 from django import forms
-from django.contrib.contenttypes.models import ContentType
 from django.contrib.contenttypes.fields import GenericForeignKey, GenericRelation
+from django.contrib.contenttypes.models import ContentType
 from django.core.exceptions import ValidationError
 from django.core.serializers.json import DjangoJSONEncoder
 from django.db import models
@@ -21,11 +21,10 @@ from nautobot.core.models.fields import AutoSlugField, slugify_dashes_to_undersc
 from nautobot.core.models.querysets import RestrictedQuerySet
 from nautobot.core.templatetags.helpers import bettertitle
 from nautobot.core.utils.lookup import get_filterset_for_model, get_route_for_model
-from nautobot.extras.choices import RelationshipTypeChoices, RelationshipRequiredSideChoices, RelationshipSideChoices
-from nautobot.extras.utils import FeatureQuery, check_if_key_is_graphql_safe, extras_features
+from nautobot.extras.choices import RelationshipRequiredSideChoices, RelationshipSideChoices, RelationshipTypeChoices
 from nautobot.extras.models import ChangeLoggedModel
 from nautobot.extras.models.mixins import NotesMixin
-
+from nautobot.extras.utils import check_if_key_is_graphql_safe, extras_features, FeatureQuery
 
 logger = logging.getLogger(__name__)
 

nautobot/extras/models/roles.py

@@ -3,7 +3,7 @@ from django.db import models
 
 from nautobot.core.models.fields import ForeignKeyLimitedByContentTypes
 from nautobot.core.models.name_color_content_types import NameColorContentTypesModel
-from nautobot.extras.utils import RoleModelsQuery, extras_features
+from nautobot.extras.utils import extras_features, RoleModelsQuery
 
 
 @extras_features(

nautobot/extras/models/secrets.py

@@ -3,8 +3,7 @@ import logging
 from django.core.exceptions import ValidationError
 from django.core.serializers.json import DjangoJSONEncoder
 from django.db import models
-
-from jinja2.exceptions import UndefinedError, TemplateSyntaxError
+from jinja2.exceptions import TemplateSyntaxError, UndefinedError
 
 from nautobot.core.models import BaseModel
 from nautobot.core.models.generics import OrganizationalModel, PrimaryModel
@@ -14,7 +13,6 @@ from nautobot.extras.registry import registry
 from nautobot.extras.secrets.exceptions import SecretError, SecretParametersError, SecretProviderError
 from nautobot.extras.utils import extras_features
 
-
 logger = logging.getLogger(__name__)
 
 

nautobot/extras/models/tags.py

@@ -11,7 +11,6 @@ from nautobot.extras.models.mixins import NotesMixin
 from nautobot.extras.models.relationships import RelationshipModel
 from nautobot.extras.utils import extras_features, TaggableClassesQuery
 
-
 #
 # Tags
 #

nautobot/extras/navigation.py

@@ -8,7 +8,6 @@ from nautobot.core.apps import (
     NavMenuTab,
 )
 
-
 menu_items = (
     NavMenuTab(
         name="Organization",

nautobot/extras/plugins/__init__.py

@@ -1,27 +1,26 @@
 import collections
-import inspect
 from functools import partial
 from importlib import import_module
+import inspect
 from logging import getLogger
 
-from packaging import version
-
 from django.core.exceptions import ValidationError
 from django.template.loader import get_template
 from django.urls import get_resolver, URLPattern
+from packaging import version
 
 from nautobot.core.apps import (
     NautobotConfig,
     NavMenuTab,
-    register_menu_items,
     register_homepage_panels,
+    register_menu_items,
 )
-from nautobot.core.utils.deprecation import class_deprecated_in_favor_of
 from nautobot.core.signals import nautobot_database_ready
+from nautobot.core.utils.deprecation import class_deprecated_in_favor_of
 from nautobot.extras.choices import BannerClassChoices
-from nautobot.extras.registry import registry, register_datasource_contents
 from nautobot.extras.plugins.exceptions import PluginImproperlyConfigured
 from nautobot.extras.plugins.utils import import_object
+from nautobot.extras.registry import register_datasource_contents, registry
 from nautobot.extras.secrets import register_secrets_provider
 
 logger = getLogger(__name__)
@@ -462,8 +461,8 @@ def register_filter_extensions(filter_extensions, plugin_name):
     """
     Register a list of FilterExtension classes
     """
-    from nautobot.core.utils.lookup import get_filterset_for_model, get_form_for_model
     from nautobot.core.forms.utils import add_field_to_filter_form_class
+    from nautobot.core.utils.lookup import get_filterset_for_model, get_form_for_model
 
     for filter_extension in filter_extensions:
         if not issubclass(filter_extension, FilterExtension):

nautobot/extras/plugins/tables.py

@@ -1,7 +1,6 @@
 from django.contrib.auth.models import AnonymousUser
 from django.urls import reverse
 from django.utils.html import format_html
-
 import django_tables2 as tables
 
 

nautobot/extras/plugins/utils.py

@@ -9,9 +9,9 @@ import sys
 from django.core.exceptions import ImproperlyConfigured
 from django.utils.module_loading import import_string
 
-from .exceptions import PluginNotFound, PluginImproperlyConfigured
 from nautobot.core.settings_funcs import ConstanceConfigItem
 
+from .exceptions import PluginImproperlyConfigured, PluginNotFound
 
 # Logging object
 logger = logging.getLogger(__name__)

nautobot/extras/plugins/views.py

@@ -7,14 +7,13 @@ from django.http import Http404
 from django.shortcuts import render
 from django.urls.exceptions import NoReverseMatch
 from django.views.generic import View
+from django_tables2 import RequestConfig
 from drf_spectacular.utils import extend_schema
 from rest_framework import permissions
 from rest_framework.response import Response
 from rest_framework.reverse import reverse
 from rest_framework.views import APIView
 
-from django_tables2 import RequestConfig
-
 from nautobot.core.api.views import NautobotAPIVersionMixin
 from nautobot.core.forms import TableConfigForm
 from nautobot.core.views.mixins import AdminRequiredMixin

nautobot/extras/querysets.py

@@ -1,12 +1,12 @@
-from django.core.cache import cache
 from django.conf import settings
 from django.contrib.contenttypes.models import ContentType
-from django.db.models import Model, OuterRef, Subquery, Q, F
+from django.core.cache import cache
+from django.db.models import F, Model, OuterRef, Q, Subquery
 from django.db.models.functions import JSONObject
 from django_celery_beat.managers import ExtendedQuerySet
 
-from nautobot.core.models.querysets import RestrictedQuerySet
 from nautobot.core.models.query_functions import EmptyGroupByJSONBAgg
+from nautobot.core.models.querysets import RestrictedQuerySet
 from nautobot.core.utils.config import get_settings_or_config
 from nautobot.extras.models.tags import TaggedItem
 

nautobot/extras/signals.py

@@ -1,9 +1,9 @@
 import contextvars
+from datetime import timedelta
+import logging
 import os
-import random
+import secrets
 import shutil
-import logging
-from datetime import timedelta
 
 from db_file_storage.model_utils import delete_file
 from db_file_storage.storage import DatabaseFileStorage
@@ -13,15 +13,15 @@ from django.core.cache import cache
 from django.core.exceptions import ValidationError
 from django.core.files.storage import get_storage_class
 from django.db import transaction
-from django.db.models.signals import m2m_changed, pre_delete, post_save, pre_save, post_delete
+from django.db.models.signals import m2m_changed, post_delete, post_save, pre_delete, pre_save
 from django.dispatch import receiver
 from django.utils import timezone
 from django_prometheus.models import model_deletes, model_inserts, model_updates
 
 from nautobot.core.celery import app, import_jobs_as_celery_tasks
 from nautobot.core.utils.config import get_settings_or_config
-from nautobot.extras.constants import CHANGELOG_MAX_CHANGE_CONTEXT_DETAIL
 from nautobot.extras.choices import JobResultStatusChoices, ObjectChangeActionChoices
+from nautobot.extras.constants import CHANGELOG_MAX_CHANGE_CONTEXT_DETAIL
 from nautobot.extras.models import (
     CustomField,
     DynamicGroup,
@@ -34,7 +34,6 @@ from nautobot.extras.querysets import NotesQuerySet
 from nautobot.extras.tasks import delete_custom_field_data, provision_field
 from nautobot.extras.utils import refresh_job_model_from_job_class
 
-
 # thread safe change context state variable
 change_context_state = contextvars.ContextVar("change_context_state", default=None)
 logger = logging.getLogger(__name__)
@@ -127,7 +126,7 @@ def _handle_changed_object(sender, instance, raw=False, **kwargs):
 
     # Housekeeping: 0.1% chance of clearing out expired ObjectChanges
     changelog_retention = get_settings_or_config("CHANGELOG_RETENTION")
-    if changelog_retention and random.randint(1, 1000) == 1:
+    if changelog_retention and secrets.randbelow(1000) == 0:
         cutoff = timezone.now() - timedelta(days=changelog_retention)
         ObjectChange.objects.filter(time__lt=cutoff).delete()
 

nautobot/extras/tables.py

@@ -1,10 +1,9 @@
-import django_tables2 as tables
 from django.conf import settings
 from django.utils.html import format_html
+import django_tables2 as tables
 from django_tables2.utils import Accessor
 from jsonschema.exceptions import ValidationError as JSONSchemaValidationError
 
-from nautobot.core.templatetags.helpers import render_boolean, render_markdown
 from nautobot.core.tables import (
     BaseTable,
     BooleanColumn,
@@ -16,6 +15,8 @@ from nautobot.core.tables import (
     TagColumn,
     ToggleColumn,
 )
+from nautobot.core.templatetags.helpers import render_boolean, render_markdown
+
 from .choices import LogLevelChoices
 from .models import (
     ComputedField,
@@ -32,8 +33,8 @@ from .models import (
     Job as JobModel,
     JobButton,
     JobHook,
-    JobResult,
     JobLogEntry,
+    JobResult,
     Note,
     ObjectChange,
     Relationship,
@@ -49,7 +50,6 @@ from .models import (
 )
 from .registry import registry
 
-
 TAGGED_ITEM = """
 {% if value.get_absolute_url %}
     <a href="{{ value.get_absolute_url }}">{{ value }}</a>

nautobot/extras/tasks.py

@@ -1,16 +1,15 @@
 from logging import getLogger
 
-import requests
 from django.conf import settings
 from django.contrib.contenttypes.models import ContentType
 from django.db import transaction
 from jinja2.exceptions import TemplateError
+import requests
 
 from nautobot.core.celery import nautobot_task
 from nautobot.extras.choices import CustomFieldTypeChoices, ObjectChangeActionChoices
 from nautobot.extras.utils import generate_signature
 
-
 logger = getLogger("nautobot.extras.tasks")
 
 

nautobot/extras/templates/extras/configcontext_edit.html

@@ -8,7 +8,7 @@
             {% render_field form.name %}
             {% render_field form.weight %}
             {% render_field form.description %}
-            {% render_field form.schema %}
+            {% render_field form.config_context_schema %}
             {% render_field form.is_active %}
         </div>
     </div>

nautobot/extras/templates/extras/graphqlquery.html

@@ -37,9 +37,11 @@
                     </tr>
                 </table>
             {% endif %}
-            <pre id="query_output">
+            <div class="panel-footer">
+                <pre id="query_output">
 
-            </pre>
+                </pre>
+            </div>
         </div>
 {% endblock content_right_page %}
 

nautobot/extras/templates/extras/secretsgroup_edit.html

@@ -14,57 +14,52 @@
         <div class="panel-heading"><strong>Secret Assignment</strong></div>
         <div class="panel-body">
             {% if secrets.errors %}
-                <div class="panel panel-danger">
-                    <div class="panel-heading"><strong>Errors</strong></div>
-                    <div class="panel-body">
-                        Please correct the error(s) below:
+                <div class="text-danger">
+                    Please correct the error(s) below:
 
-                        {% for secret in secrets.forms %}
-                            {% if secret.errors %}
-                                {% for error in secret.errors.values %}{{ error }}{% endfor %}
-                            {% endif %}
-                        {% endfor %}
-                    </div>
+                    {% for secret in secrets.forms %}
+                        {% if secret.errors %}
+                            {% for error in secret.errors.values %}{{ error }}{% endfor %}
+                        {% endif %}
+                    {% endfor %}
                 </div>
             {% endif %}
             {{ secrets.non_field_errors }}
-            <div class="form-group{% if secrets.errors %} has-error{% endif %}">
-                <table class="table" id="secrets">
-                    {{ secrets.management_form }}
-                    {% for secret_form in secrets.forms %}
-                        {% if forloop.first %}
-                            <thead>
-                                <tr>
-                                    {% for field in secret_form.visible_fields %}
-                                        <th>{{ field.label|capfirst }}</th>
+            <table class="table" id="secrets">
+                {{ secrets.management_form }}
+                {% for secret_form in secrets.forms %}
+                    {% if forloop.first %}
+                        <thead>
+                            <tr>
+                                {% for field in secret_form.visible_fields %}
+                                    <th>{{ field.label|capfirst }}</th>
+                                {% endfor %}
+                            </tr>
+                        </thead>
+                    {% endif %}
+                    <tr class="formset_row-{{ secrets.prefix }}">
+                        {% for field in secret_form.visible_fields %}
+                            <td>
+                                {% if forloop.first %}
+                                    {% for hidden in secret_form.hidden_fields %}
+                                        {{ hidden }}
                                     {% endfor %}
-                                </tr>
-                            </thead>
-                        {% endif %}
-                        <tr class="formset_row-{{ secrets.prefix }}">
-                            {% for field in secret_form.visible_fields %}
-                                <td>
-                                    {% if forloop.first %}
-                                        {% for hidden in secret_form.hidden_fields %}
-                                            {{ hidden }}
+                                {% endif %}
+                                {{ field }}
+                                {% if field.errors %}
+                                    <ul>
+                                        {% for error in field.errors %}
+                                            {# Embed an HTML comment indicating the error for extraction by tests #}
+                                            <!-- FORM-ERROR {{ field.name }}: {{ error }} -->
+                                            <li clas="text-danger">{{ error }}</li>
                                         {% endfor %}
-                                    {% endif %}
-                                    {{ field }}
-                                    {% if field.errors %}
-                                        <ul>
-                                            {% for error in field.errors %}
-                                                {# Embed an HTML comment indicating the error for extraction by tests #}
-                                                <!-- FORM-ERROR {{ field.name }}: {{ error }} -->
-                                                <li clas="text-danger">{{ error }}</li>
-                                            {% endfor %}
-                                        </ul>
-                                    {% endif %}
-                                </td>
-                            {% endfor %}
-                        </tr>
-                    {% endfor %}
-                </table>
-            </div>
+                                    </ul>
+                                {% endif %}
+                            </td>
+                        {% endfor %}
+                    </tr>
+                {% endfor %}
+            </table>
         </div>
     </div>
     {% include "inc/extras_features_edit_form_fields.html" %}

nautobot/extras/templatetags/custom_links.py

@@ -8,7 +8,6 @@ from django.utils.safestring import mark_safe
 from nautobot.core.utils.data import render_jinja2
 from nautobot.extras.models import CustomLink
 
-
 register = template.Library()
 
 LINK_BUTTON = '<a href="{}"{} class="btn btn-sm btn-{}">{}</a>\n'
@@ -41,7 +40,7 @@ def custom_links(context, obj):
         "user": context["user"],  # django.contrib.auth.context_processors.auth
         "perms": context["perms"],  # django.contrib.auth.context_processors.auth
     }
-    template_code = mark_safe("")  # noqa: S308
+    template_code = mark_safe("")  # noqa: S308  # suspicious-mark-safe-usage -- this one is safe
     group_names = OrderedDict()
 
     for cl in links:
@@ -71,7 +70,7 @@ def custom_links(context, obj):
 
     # Add grouped links to template
     for group, links in group_names.items():
-        links_rendered = mark_safe("")  # noqa: S308
+        links_rendered = mark_safe("")  # noqa: S308  # suspicious-mark-safe-usage -- this one is safe
 
         for cl in links:
             try:

nautobot/extras/templatetags/job_buttons.py

@@ -6,9 +6,8 @@ from django.urls import reverse
 from django.utils.html import format_html
 from django.utils.safestring import mark_safe
 
-from nautobot.extras.models import Job, JobButton
 from nautobot.core.utils.data import render_jinja2
-
+from nautobot.extras.models import Job, JobButton
 
 register = template.Library()
 
@@ -70,7 +69,7 @@ CONFIRM_MODAL = """
 </div>
 """
 
-SAFE_EMPTY_STR = mark_safe("")  # noqa: S308
+SAFE_EMPTY_STR = mark_safe("")  # noqa: S308  # suspicious-mark-safe-usage -- this one is safe
 
 
 def _render_job_button_for_obj(job_button, obj, context, content_type):