moteus 0.3.89__py3-none-any.whl → 0.3.90__py3-none-any.whl

moteus/moteus_tool.py

@@ -84,7 +84,7 @@ def stddev(data):
     mean = sum(data) / len(data)
     return math.sqrt(sum((x - mean) ** 2 for x in data) / len(data))
 
-SUPPORTED_ABI_VERSION = 0x010b
+SUPPORTED_ABI_VERSION = 0x010c
 
 # Old firmwares used a slightly incorrect definition of Kv/v_per_hz
 # that didn't match with vendors or oscilloscope tests.
@@ -111,6 +111,15 @@ class FirmwareUpgrade:
         lines = old_config.split(b'\n')
         items = dict([line.split(b' ') for line in lines if b' ' in line])
 
+        if self.new <= 0x010b and self.old >= 0x010c:
+            # Update all pll_filter_hz parameters.
+            for mpsource in range(0, 3):
+                key = f'motor_position.sources.{mpsource}.pll_filter_hz'.encode('utf8')
+                pll_filter_hz = float(items.get(key, 150.0))
+                natural_hz = pll_filter_hz / 2.48
+                items[key] = str(natural_hz).encode('utf8')
+                print(f"Downgraded motor_position.sources.{mpsource}.pll_filter_hz from {pll_filter_hz} to {natural_hz}")
+
         if self.new <= 0x010a and self.old >= 0x010b:
             flux_brake_margin_voltage = float(items.pop(b'servo.flux_brake_margin_voltage'))
             max_voltage = float(items[b'servo.max_voltage'])
@@ -572,6 +581,16 @@ class FirmwareUpgrade:
                 print(f"Upgraded servo.motor_derate_temperature to servo.motor_temperature_margin={motor_temperature_margin}")
                 items[b'servo.motor_temperature_margin'] = str(motor_temperature_margin).encode('utf8')
 
+        if self.new >= 0x010c and self.old <= 0x010b:
+            # Update all pll_filter_hz parameters.
+            for mpsource in range(0, 3):
+                key = f'motor_position.sources.{mpsource}.pll_filter_hz'.encode('utf8')
+                natural_hz = float(items.get(key, 400.0))
+                pll_filter_hz = natural_hz * 2.48
+                items[key] = str(pll_filter_hz).encode('utf8')
+                print(f"Upgraded motor_position.sources.{mpsource}.pll_filter_hz from {natural_hz} to {pll_filter_hz}")
+
+
         lines = [key + b' ' + value for key, value in items.items()]
         return b'\n'.join(lines)
 
@@ -1018,18 +1037,19 @@ class Stream:
             cmd = f"w {final_address:x} {'ff' * remaining_to_flush}"
             result = await self.command(cmd)
 
-        verify_ctx = FlashContext(elfs)
-        while True:
-            expected_block = verify_ctx.get_next_block()
-            cmd = f"r {expected_block.address:x} {len(expected_block.data):x}"
-            result = await self.command(cmd, allow_any_response=True)
-            # Emit progress first, to make it easier to see where
-            # things go wrong.
-            self._emit_flash_progress(verify_ctx, "verifying")
-            _verify_blocks(expected_block, result)
-            done = verify_ctx.advance_block()
-            if done:
-                break
+        if not self.args.no_verify:
+            verify_ctx = FlashContext(elfs)
+            while True:
+                expected_block = verify_ctx.get_next_block()
+                cmd = f"r {expected_block.address:x} {len(expected_block.data):x}"
+                result = await self.command(cmd, allow_any_response=True)
+                # Emit progress first, to make it easier to see where
+                # things go wrong.
+                self._emit_flash_progress(verify_ctx, "verifying")
+                _verify_blocks(expected_block, result)
+                done = verify_ctx.advance_block()
+                if done:
+                    break
 
     async def read_servo_stats(self):
         servo_stats = await self.read_data("servo_stats")
@@ -1777,31 +1797,36 @@ class Stream:
                 if output_type == 4:  # kHall
                     hall_output = True
 
-            if inductance and hall_output:
-                desired_encoder_bw_hz = min(
-                    desired_encoder_bw_hz, 2e-2 / inductance)
+            # If we are calibrating a device with older firmware, we
+            # artifically limit the bandwidth for hall commutation
+            # sensors.
+            if self.firmware.version <= 0x010b:
+                if inductance and hall_output:
+                    desired_encoder_bw_hz = min(
+                        desired_encoder_bw_hz, 2e-2 / inductance)
 
-            # Also, limit the bandwidth for halls based on the number
-            # of poles and the estimated calibration speed.
-            if hall_output:
-                max_pole_bandwidth_hz = (
-                    0.5 * self.args.cal_motor_poles *
-                    self.args.cal_motor_speed)
-                desired_encoder_bw_hz = min(
-                    desired_encoder_bw_hz, max_pole_bandwidth_hz)
+                # Also, limit the bandwidth for halls based on the number
+                # of poles and the estimated calibration speed.
+                if hall_output:
+                    max_pole_bandwidth_hz = (
+                        0.5 * self.args.cal_motor_poles *
+                        self.args.cal_motor_speed)
+                    desired_encoder_bw_hz = min(
+                        desired_encoder_bw_hz, max_pole_bandwidth_hz)
 
 
         # And our bandwidth with the filter can be no larger than
-        # 1/30th the control rate.
-        encoder_bw_hz = min(control_rate_hz / 30, desired_encoder_bw_hz)
+        # a fixed fraction of the control rate.
+        encoder_bw_hz = min(control_rate_hz / 10, desired_encoder_bw_hz)
 
         if encoder_bw_hz != desired_encoder_bw_hz:
             print(f"Warning: using lower encoder bandwidth than "+
                   f"requested: {encoder_bw_hz:.1f}Hz")
 
-        w_3db = encoder_bw_hz * 2 * math.pi
-        kp = 2 * w_3db
-        ki = w_3db * w_3db
+        encoder_natural_frequency_hz = encoder_bw_hz / 2.48
+        w_n = encoder_natural_frequency_hz * 2 * math.pi  # natural frequency for zeta=1.0
+        kp = 2 * w_n
+        ki = w_n * w_n
 
         if servo_style:
             await self.command(f"conf set servo.encoder_filter.enabled 1")
@@ -1809,7 +1834,12 @@ class Stream:
             await self.command(f"conf set servo.encoder_filter.ki {ki}")
         elif motor_position_style:
             commutation_source = await self.read_config_int("motor_position.commutation_source")
-            await self.command(f"conf set motor_position.sources.{commutation_source}.pll_filter_hz {encoder_bw_hz}")
+            output_hz = encoder_bw_hz if self.firmware.version >= 0x010c else encoder_natural_frequency_hz
+            await self.command(f"conf set motor_position.sources.{commutation_source}.pll_filter_hz {output_hz}")
+
+            output_source = await self.read_config_int("motor_position.output.source")
+            if output_source != commutation_source:
+                await self.command(f"conf set motor_position.sources.{output_source}.pll_filter_hz {output_hz}")
         else:
             assert False
         return kp, ki, encoder_bw_hz
@@ -2066,65 +2096,6 @@ class Stream:
             await asyncio.sleep(0.2)
 
 
-    async def do_restore_calibration(self, filename):
-        report = json.load(open(filename, "r"))
-
-        # Verify that the serial number matches.
-        device_info = await self.get_device_info()
-        if device_info['serial_number'] != report['device_info']['serial_number']:
-            raise RuntimeError(
-                f"Serial number in calibration ({report['serial_number']}) " +
-                f"does not match device ({device_info['serial_number']})")
-
-        cal_result = report['calibration']
-
-        await self.command(
-            f"conf set motor.poles {cal_result['poles']}")
-        if await self.is_config_supported("motor_position.sources.0.sign"):
-            await self.command(f"conf set motor_position.sources.0.sign {-1 if cal_result['invert'] else 1}")
-        else:
-            await self.command(
-                f"conf set motor.invert {1 if cal_result['invert'] else 0}")
-        if await self.is_config_supported("motor.phase_invert"):
-            phase_invert = cal_result.get('phase_invert', False)
-            await self.command(
-                f"conf set motor.phase_invert {1 if phase_invert else 0}")
-        for index, offset in enumerate(cal_result['offset']):
-            await self.command(f"conf set motor.offset.{index} {offset}")
-
-        await self.command(f"conf set motor.resistance_ohm {report['winding_resistance']}")
-        if await self.is_config_supported("motor.v_per_hz"):
-            await self.command(f"conf set motor.v_per_hz {report['v_per_hz']}")
-        elif await self.is_config_supported("motor.Kv"):
-            await self.command(f"conf set motor.Kv {report['kv']}")
-
-        pid_dq_kp = report.get('pid_dq_kp', None)
-        if pid_dq_kp is not None:
-            await self.command(f"conf set servo.pid_dq.kp {pid_dq_kp}")
-
-        pid_dq_ki = report.get('pid_dq_ki', None)
-        if pid_dq_ki is not None:
-            await self.command(f"conf set servo.pid_dq.ki {pid_dq_ki}")
-
-        enc_kp = report.get('encoder_filter_kp', None)
-        enc_ki = report.get('encoder_filter_ki', None)
-        enc_hz = report.get('encoder_filter_bw_hz', None)
-        if (enc_hz and
-            await self.is_config_supported(
-                "motor_position.sources.0.pll_filter_hz")):
-            await self.command(
-                f"conf set motor_position.sources.0.pll_filter_hz {enc_hz}")
-        elif await self.is_config_supported("servo.encoder_filter.kp"):
-            if enc_kp:
-                await self.command(f"conf set servo.encoder_filter.kp {enc_kp}")
-            if enc_ki:
-                await self.command(f"conf set servo.encoder_filter.ki {enc_ki}")
-
-        await self.command("conf write")
-
-        print("Calibration restored")
-
-
 class Runner:
     def __init__(self, args):
         self.args = args
@@ -2222,8 +2193,6 @@ class Runner:
             await stream.do_flash(self.args.flash)
         elif self.args.calibrate:
             await stream.do_calibrate()
-        elif self.args.restore_cal:
-            await stream.do_restore_calibration(self.args.restore_cal)
         else:
             raise RuntimeError("No action specified")
 
@@ -2260,6 +2229,8 @@ async def async_main():
                        help='write the given configuration')
     group.add_argument('--flash', metavar='FILE',
                        help='write the given elf file to flash')
+    parser.add_argument('--no-verify', action='store_true',
+                        help='do not verify after flashing')
 
     parser.add_argument('--no-restore-config', action='store_true',
                         help='do not restore config after flash')
@@ -2269,8 +2240,6 @@ async def async_main():
     group.add_argument('--calibrate', action='store_true',
                         help='calibrate the motor, requires full freedom of motion')
 
-    group.add_argument('--restore-cal', metavar='FILE', type=str,
-                        help='restore calibration from logged data')
     group.add_argument('--zero-offset', action='store_true',
                         help='set the motor\'s position offset')
     group.add_argument('--set-offset', metavar='O',
@@ -2288,7 +2257,7 @@ async def async_main():
                         help='calibrate a motor with hall commutation sensors')
 
     parser.add_argument('--cal-bw-hz', metavar='HZ', type=float,
-                        default=100.0,
+                        default=200.0,
                         help='configure current loop bandwidth in Hz')
     parser.add_argument('--encoder-bw-hz', metavar='HZ', type=float,
                         default=None,

moteus/version.py

@@ -12,4 +12,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-VERSION="0.3.89"
+VERSION="0.3.90"

{moteus-0.3.89.dist-info → moteus-0.3.90.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: moteus
-Version: 0.3.89
+Version: 0.3.90
 Summary: moteus brushless controller library and tools
 Home-page: https://github.com/mjbots/moteus
 Author: mjbots Robotic Systems

{moteus-0.3.89.dist-info → moteus-0.3.90.dist-info}/RECORD

@@ -6,7 +6,7 @@ moteus/command.py,sha256=UkOsbtkso6Oyex8CfbpAKpBNriik519ymxL86EZGkRs,1169
 moteus/export.py,sha256=XitBUuf4MDRIneXQSUptizIhZi2BdHyFO2Vo_2d2CFI,1742
 moteus/fdcanusb.py,sha256=SOAvUlleI6bKwQiApo7nYAaqBM4JoNPn4PHdPqsgsQQ,7707
 moteus/moteus.py,sha256=r-aFtIFaj-0s438bKBc0feOo-G8v4G6jlWk4_siQshE,53322
-moteus/moteus_tool.py,sha256=2uiQyOvdn-Yd2mt0pTsZ2fzJIVb2kJeeyfT2taIiIX0,98391
+moteus/moteus_tool.py,sha256=YSij2l0HhldsdRYnehgs2Xp5sPf4QUSlRUfzseA3YyM,97403
 moteus/multiplex.py,sha256=2tdNX5JSh21TOjN6N9LKribLQtVYyyYbXjzwXB64sfA,12119
 moteus/posix_aioserial.py,sha256=2oDrw8TBEwuEQjY41g9rHeuFeffcPHqMwNS3nf5NVq8,3137
 moteus/pythoncan.py,sha256=j7Gv9tugQqTZbanm1lQGIoTvfmeS2kAxigB0n1a50lo,5039
@@ -14,10 +14,10 @@ moteus/reader.py,sha256=9i1-h4aGd4syfqtWJcpg70Bl-bmunkGU4FmXmOLyRt8,12121
 moteus/regression.py,sha256=M5gjDBYJQ64iBXIrvBhMkD8TYhtlnQ85x8U4py0niGA,1196
 moteus/router.py,sha256=501W5GZ12rFoc1lmcH3S7IYsoc-Q_-FJ4B3i37RzE3Q,2061
 moteus/transport.py,sha256=WhkW2G9i25lkOlO55eI5_oXmU0PhDmxTeJ75Sg_7nTI,1021
-moteus/version.py,sha256=awY4LvZ9OK5lPoCwGam-n3a3hS_9hqodOOLIH3OHQCw,627
+moteus/version.py,sha256=p-7him8WSagVK_VPWEM3hijP6IQe1euIvhNF2hqFEaM,627
 moteus/win32_aioserial.py,sha256=culdl-vYxBKD5n2s5LkIMGyUaHyCcEc8BL5-DWEaxX8,2025
-moteus-0.3.89.dist-info/METADATA,sha256=CYM1GbGI8SfVCd58_tRUgHAXwiL-CCOJWSlUjoxqiYY,3417
-moteus-0.3.89.dist-info/WHEEL,sha256=oiQVh_5PnQM0E3gPdiz09WCNmwiHDMaGer_elqB3coM,92
-moteus-0.3.89.dist-info/entry_points.txt,sha256=accRcwir_K8wCf7i3qHb5R6CPh5SiSgd5a1A92ibb9E,56
-moteus-0.3.89.dist-info/top_level.txt,sha256=aZzmI_yecTaDrdSp29pTJuowaSQ9dlIZheQpshGg4YQ,7
-moteus-0.3.89.dist-info/RECORD,,
+moteus-0.3.90.dist-info/METADATA,sha256=Iv4mDWBnQZtzCS5UBySeI3AAtVwIKl-NMX9xwke-NjU,3417
+moteus-0.3.90.dist-info/WHEEL,sha256=oiQVh_5PnQM0E3gPdiz09WCNmwiHDMaGer_elqB3coM,92
+moteus-0.3.90.dist-info/entry_points.txt,sha256=accRcwir_K8wCf7i3qHb5R6CPh5SiSgd5a1A92ibb9E,56
+moteus-0.3.90.dist-info/top_level.txt,sha256=aZzmI_yecTaDrdSp29pTJuowaSQ9dlIZheQpshGg4YQ,7
+moteus-0.3.90.dist-info/RECORD,,