monoco-toolkit 0.1.1__py3-none-any.whl → 0.2.8__py3-none-any.whl

monoco/features/issue/linter.py

@@ -1,68 +1,54 @@
-from typing import List, Optional, Tuple, Set
+from typing import List, Optional, Set, Tuple
 from pathlib import Path
 from rich.console import Console
 from rich.table import Table
 import typer
-
+import re
+from monoco.core import git
 from . import core
-from .models import IssueStatus, IssueStage
+from .validator import IssueValidator
+from monoco.core.lsp import Diagnostic, DiagnosticSeverity
 
 console = Console()
 
-
-def validate_issue(path: Path, meta: core.IssueMetadata, all_issue_ids: Set[str] = set(), issues_root: Optional[Path] = None) -> List[str]:
+def check_environment_policy(project_root: Path):
     """
-    Validate a single issue's integrity.
+    Guardrail: Prevent direct modifications on protected branches (main/master).
     """
-    errors = []
-    
-    # A. Directory/Status Consistency
-    expected_status = meta.status.value
-    path_parts = path.parts
-    # We might be validating a temp file, so we skip path check if it's not in the tree?
-    # Or strict check? For "Safe Edit", the file might be in a temp dir. 
-    # So we probably only care about content/metadata integrity.
-    
-    # But wait, if we overwrite the file, it MUST be valid.
-    # Let's assume the validation is about the content itself (metadata logic).
-    
-    # B. Solution Compliance
-    if meta.status == IssueStatus.CLOSED and not meta.solution:
-        errors.append(f"[red]Solution Missing:[/red] {meta.id} is closed but has no [dim]solution[/dim] field.")
-        
-    # C. Link Integrity
-    if meta.parent:
-        if all_issue_ids and meta.parent not in all_issue_ids:
-             # Check workspace (fallback)
-             found = False
-             if issues_root:
-                 if core.find_issue_path(issues_root, meta.parent):
-                     found = True
-             
-             if not found:
-                 errors.append(f"[red]Broken Link:[/red] {meta.id} refers to non-existent parent [bold]{meta.parent}[/bold].")
+    # Only enforce if it is a git repo
+    try:
+        if not git.is_git_repo(project_root):
+            return
 
-    # D. Lifecycle Guard (Backlog)
-    if meta.status == IssueStatus.BACKLOG and meta.stage != IssueStage.FREEZED:
-        errors.append(f"[red]Lifecycle Error:[/red] {meta.id} is backlog but stage is not [bold]freezed[/bold] (found: {meta.stage}).")
+        current_branch = git.get_current_branch(project_root)
+        # Standard protected branches
+        if current_branch in ["main", "master", "production"]:
+            # Check if dirty (uncommitted changes)
+            changed_files = git.get_git_status(project_root)
+            if changed_files:
+                console.print(f"\n[bold red]🛑 Environment Policy Violation[/bold red]")
+                console.print(f"You are modifying code directly on protected branch: [bold cyan]{current_branch}[/bold cyan]")
+                console.print(f"Found {len(changed_files)} uncommitted changes.")
+                console.print(f"[yellow]Action Required:[/yellow] Please stash your changes and switch to a feature branch.")
+                console.print(f"  > git stash")
+                console.print(f"  > monoco issue start <ID> --branch")
+                console.print(f"  > git stash pop")
+                raise typer.Exit(code=1)
+    except Exception:
+        # Fail safe: Do not block linting if git check fails unexpectedly
+        pass
 
-    return errors
-
-def check_integrity(issues_root: Path, recursive: bool = False) -> List[str]:
+def check_integrity(issues_root: Path, recursive: bool = False) -> List[Diagnostic]:
     """
-    Verify the integrity of the Issues directory.
-    Returns a list of error messages.
-    
-    If recursive=True, performs workspace-level validation including:
-    - Cross-project ID collision detection
-    - Cross-project UID collision detection
+    Verify the integrity of the Issues directory using LSP Validator.
     """
-    errors = []
-    all_issue_ids = set()  # For parent reference validation (includes namespaced IDs)
-    id_to_projects = {}  # local_id -> [(project_name, meta, file)]
-    all_uids = {}  # uid -> (project, issue_id)
+    diagnostics = []
+    validator = IssueValidator(issues_root)
+    
+    all_issue_ids = set()
     all_issues = []
     
+    # 1. Collection Phase (Build Index)
     # Helper to collect issues from a project
     def collect_project_issues(project_issues_root: Path, project_name: str = "local"):
         project_issues = []
@@ -79,94 +65,313 @@ def check_integrity(issues_root: Path, recursive: bool = False) -> List[str]:
                     meta = core.parse_issue(f)
                     if meta:
                         local_id = meta.id
-                        full_id = f"{project_name}::{local_id}" if project_name != "local" else local_id
-                        
-                        # Track ID occurrences per project
-                        if local_id not in id_to_projects:
-                            id_to_projects[local_id] = []
-                        id_to_projects[local_id].append((project_name, meta, f))
+                        full_id = f"{project_name}::{local_id}"
                         
-                        # Add IDs for reference validation
-                        all_issue_ids.add(local_id)  # Local ID
-                        if project_name != "local":
-                            all_issue_ids.add(full_id)  # Namespaced ID
+                        all_issue_ids.add(local_id)
+                        all_issue_ids.add(full_id)
                         
-                        # Check UID collision (if UID exists)
-                        if meta.uid:
-                            if meta.uid in all_uids:
-                                existing_project, existing_id = all_uids[meta.uid]
-                                errors.append(
-                                    f"[red]UID Collision:[/red] UID {meta.uid} is duplicated.\n"
-                                    f"  - {existing_project}::{existing_id}\n"
-                                    f"  - {project_name}::{local_id}"
-                                )
-                            else:
-                                all_uids[meta.uid] = (project_name, local_id)
-                        
-                        project_issues.append((f, meta, project_name))
+                        project_issues.append((f, meta))
         return project_issues
 
-    # 1. Collect local issues
-    all_issues.extend(collect_project_issues(issues_root, "local"))
+    from monoco.core.config import get_config
+    conf = get_config(str(issues_root.parent))
+    
+    # Identify local project name
+    local_project_name = "local"
+    if conf and conf.project and conf.project.name:
+        local_project_name = conf.project.name.lower()
 
-    # 2. If recursive, collect workspace member issues
+    # Find Topmost Workspace Root
+    workspace_root = issues_root.parent
+    for parent in [workspace_root] + list(workspace_root.parents):
+        if (parent / ".monoco" / "workspace.yaml").exists() or (parent / ".monoco" / "project.yaml").exists():
+            workspace_root = parent
+            
+    # Collect from local issues_root
+    all_issues.extend(collect_project_issues(issues_root, local_project_name))
+    
     if recursive:
         try:
-            from monoco.core.config import get_config
-            project_root = issues_root.parent
-            conf = get_config(str(project_root))
+            # Re-read config from workspace root to get all members
+            ws_conf = get_config(str(workspace_root))
             
-            for member_name, rel_path in conf.project.members.items():
-                member_root = (project_root / rel_path).resolve()
+            # Index Root project if different from current
+            if workspace_root != issues_root.parent:
+                root_issues_dir = workspace_root / "Issues"
+                if root_issues_dir.exists():
+                    all_issues.extend(collect_project_issues(root_issues_dir, ws_conf.project.name.lower()))
+
+            # Index all members
+            for member_name, rel_path in ws_conf.project.members.items():
+                member_root = (workspace_root / rel_path).resolve()
                 member_issues_dir = member_root / "Issues"
-                
-                if member_issues_dir.exists():
-                    all_issues.extend(collect_project_issues(member_issues_dir, member_name))
-        except Exception as e:
-            # Fail gracefully if workspace config is missing
+                if member_issues_dir.exists() and member_issues_dir != issues_root:
+                    all_issues.extend(collect_project_issues(member_issues_dir, member_name.lower()))
+        except Exception:
             pass
 
-    # 3. Check for ID collisions within same project
-    for local_id, occurrences in id_to_projects.items():
-        # Group by project
-        projects_with_id = {}
-        for project_name, meta, f in occurrences:
-            if project_name not in projects_with_id:
-                projects_with_id[project_name] = []
-            projects_with_id[project_name].append((meta, f))
+    # 2. Validation Phase
+    for path, meta in all_issues:
+        content = path.read_text() # Re-read content for validation
         
-        # Check for duplicates within same project
-        for project_name, metas in projects_with_id.items():
-            if len(metas) > 1:
-                # Same ID appears multiple times in same project - this is an error
-                error_msg = f"[red]ID Collision:[/red] {local_id} appears {len(metas)} times in project '{project_name}':\n"
-                for idx, (meta, f) in enumerate(metas, 1):
-                    error_msg += f"  {idx}. uid: {meta.uid or 'N/A'} | created: {meta.created_at} | stage: {meta.stage} | status: {meta.status.value}\n"
-                error_msg += f"  [yellow]→ Action:[/yellow] Remove duplicate or use 'monoco issue move --to <target> --renumber' to resolve."
-                errors.append(error_msg)
-
-    # 4. Validation
-    for path, meta, project_name in all_issues:
-        # A. Directory/Status Consistency (Only check this for files in the tree)
-        expected_status = meta.status.value
-        path_parts = path.parts
-        if expected_status not in path_parts:
-             errors.append(f"[yellow]Placement Error:[/yellow] {meta.id} has status [cyan]{expected_status}[/cyan] but is not under a [dim]{expected_status}/[/dim] directory.")
+        # A. Run Core Validator
+        file_diagnostics = validator.validate(meta, content, all_issue_ids)
         
-        # Reuse common logic
-        errors.extend(validate_issue(path, meta, all_issue_ids, issues_root))
+        # Add context to diagnostics (Path)
+        for d in file_diagnostics:
+             d.source = f"{meta.id}" # Use ID as source context
+             d.data = {'path': path} # Attach path for potential fixers
+             diagnostics.append(d)
+             
+    return diagnostics
 
-    return errors
 
+def run_lint(issues_root: Path, recursive: bool = False, fix: bool = False, format: str = "table", file_path: Optional[str] = None):
+    """
+    Run lint with optional auto-fix and format selection.
+    
+    Args:
+        issues_root: Root directory of issues
+        recursive: Recursively scan workspace members
+        fix: Apply auto-fixes
+        format: Output format (table, json)
+        file_path: Optional path to a single file to validate (LSP mode)
+    """
+    # 0. Environment Policy Check (Guardrail)
+    # We assume issues_root.parent is the project root or close enough for git context
+    check_environment_policy(issues_root.parent)
 
-def run_lint(issues_root: Path, recursive: bool = False):
-    errors = check_integrity(issues_root, recursive)
+    # Single-file mode (for LSP integration)
+    if file_path:
+        file = Path(file_path).resolve()
+        if not file.exists():
+            console.print(f"[red]Error:[/red] File not found: {file_path}")
+            raise typer.Exit(code=1)
+        
+        # Parse and validate single file
+        try:
+            meta = core.parse_issue(file)
+            if not meta:
+                console.print(f"[red]Error:[/red] Failed to parse issue metadata from {file_path}")
+                raise typer.Exit(code=1)
+            
+            content = file.read_text()
+            validator = IssueValidator(issues_root)
+            
+            # For single-file mode, we need to build a minimal index
+            # We'll scan the entire workspace to get all issue IDs for reference validation
+            all_issue_ids = set()
+            for subdir in ["Epics", "Features", "Chores", "Fixes"]:
+                d = issues_root / subdir
+                if d.exists():
+                    for status in ["open", "closed", "backlog"]:
+                        status_dir = d / status
+                        if status_dir.exists():
+                            for f in status_dir.rglob("*.md"):
+                                try:
+                                    m = core.parse_issue(f)
+                                    if m:
+                                        all_issue_ids.add(m.id)
+                                except Exception:
+                                    pass
+            
+            diagnostics = validator.validate(meta, content, all_issue_ids)
+            
+            # Add context
+            for d in diagnostics:
+                d.source = meta.id
+                d.data = {'path': file}
+                
+        except Exception as e:
+            console.print(f"[red]Error:[/red] Validation failed: {e}")
+            raise typer.Exit(code=1)
+    else:
+        # Full workspace scan mode
+        diagnostics = check_integrity(issues_root, recursive)
+    
+    # Filter only Warnings and Errors
+    issues = [d for d in diagnostics if d.severity <= DiagnosticSeverity.Warning]
     
-    if not errors:
+    if fix:
+        fixed_count = 0
+        console.print("[dim]Attempting auto-fixes...[/dim]")
+        
+        # We must track processed paths to avoid redundant writes if multiple errors exist
+        processed_paths = set()
+        
+        for d in issues:
+            path = d.data.get('path')
+            if not path: continue
+            
+            # Read fresh content iteration
+            pass
+
+        # Group diagnostics by file path
+        from collections import defaultdict
+        file_diags = defaultdict(list)
+        for d in issues:
+            if d.data.get('path'):
+                file_diags[d.data['path']].append(d)
+        
+        for path, diags in file_diags.items():
+            try:
+                content = path.read_text()
+                new_content = content
+                has_changes = False
+                
+                # Parse meta once for the file
+                try:
+                    meta = core.parse_issue(path)
+                except Exception:
+                    console.print(f"[yellow]Skipping fix for {path.name}: Cannot parse metadata[/yellow]")
+                    continue
+
+                # Apply fixes for this file
+                for d in diags:
+                    if "Structure Error" in d.message:
+                        expected_header = f"## {meta.id}: {meta.title}"
+                        
+                        # Check if strictly present
+                        if expected_header in new_content:
+                            continue
+                            
+                        # Strategy: Look for existing heading with same ID to replace
+                        # Matches: "## ID..." or "## ID ..."
+                        # Regex: ^##\s+ID\b.*$
+                        # We use meta.id which is safe.
+                        heading_regex = re.compile(rf"^##\s+{re.escape(meta.id)}.*$", re.MULTILINE)
+                        
+                        match_existing = heading_regex.search(new_content)
+                        
+                        if match_existing:
+                            # Replace existing incorrect heading
+                            # We use sub to replace just the first occurrence
+                            new_content = heading_regex.sub(expected_header, new_content, count=1)
+                            has_changes = True
+                        else:
+                            # Insert after frontmatter
+                            fm_match = re.search(r"^---(.*?)---", new_content, re.DOTALL | re.MULTILINE)
+                            if fm_match:
+                                end_pos = fm_match.end()
+                                header_block = f"\n\n{expected_header}\n"
+                                new_content = new_content[:end_pos] + header_block + new_content[end_pos:].lstrip()
+                                has_changes = True
+
+                    if "Review Requirement: Missing '## Review Comments' section" in d.message:
+                         if "## Review Comments" not in new_content:
+                             new_content = new_content.rstrip() + "\n\n## Review Comments\n\n- [ ] Self-Review\n"
+                             has_changes = True
+
+                    if "Malformed ID" in d.message:
+                        lines = new_content.splitlines()
+                        if d.range and d.range.start.line < len(lines):
+                            line_idx = d.range.start.line
+                            line = lines[line_idx]
+                            # Remove # from quoted strings or raw values
+                            new_line = line.replace("'#", "'").replace('"#', '"')
+                            if new_line != line:
+                                lines[line_idx] = new_line
+                                new_content = "\n".join(lines) + "\n"
+                                has_changes = True
+                    
+                    if "Tag Check: Missing required context tags" in d.message:
+                         # Extract missing tags from message
+                         # Message format: "Tag Check: Missing required context tags: #TAG1, #TAG2"
+                         try:
+                             parts = d.message.split(": ")
+                             if len(parts) >= 3:
+                                 tags_str = parts[-1]
+                                 missing_tags = [t.strip() for t in tags_str.split(",")]
+                                 
+                                 # We need to update content via core.update_issue logic effectively
+                                 # But we are in a loop potentially with other string edits.
+                                 # IMPORTANT: Mixed strategy (Regex vs Object Update) is risky.
+                                 # However, tags are in YAML frontmatter.
+                                 # Since we might have modified new_content already (string), using core.update_issue on file is dangerous (race condition with memory).
+                                 # Better to append to tags list in YAML via regex or yaml parser on new_content.
+                                 
+                                 # Parsing Frontmatter from new_content
+                                 fm_match = re.search(r"^---(.*?)---", new_content, re.DOTALL | re.MULTILINE)
+                                 if fm_match:
+                                      import yaml
+                                      fm_text = fm_match.group(1)
+                                      data = yaml.safe_load(fm_text) or {}
+                                      current_tags = data.get('tags', [])
+                                      if not isinstance(current_tags, list): current_tags = []
+                                      
+                                      # Add missing
+                                      updated_tags = sorted(list(set(current_tags) | set(missing_tags)))
+                                      data['tags'] = updated_tags
+                                      
+                                      # Dump back
+                                      new_fm_text = yaml.dump(data, sort_keys=False, allow_unicode=True)
+                                      
+                                      # Replace FM block
+                                      new_content = new_content.replace(fm_match.group(1), "\n" + new_fm_text)
+                                      has_changes = True
+                         except Exception as ex:
+                             console.print(f"[red]Failed to fix tags: {ex}[/red]")
+
+                if has_changes:
+                    path.write_text(new_content)
+                    fixed_count += 1
+                    console.print(f"[dim]Fixed: {path.name}[/dim]")
+            except Exception as e:
+                console.print(f"[red]Failed to fix {path.name}: {e}[/red]")
+
+        console.print(f"[green]Applied auto-fixes to {fixed_count} files.[/green]")
+        
+        # Re-run validation to verify
+        if file_path:
+            # Re-validate single file
+            file = Path(file_path).resolve()
+            meta = core.parse_issue(file)
+            content = file.read_text()
+            validator = IssueValidator(issues_root)
+            diagnostics = validator.validate(meta, content, all_issue_ids)
+            for d in diagnostics:
+                d.source = meta.id
+                d.data = {'path': file}
+        else:
+            diagnostics = check_integrity(issues_root, recursive)
+        issues = [d for d in diagnostics if d.severity <= DiagnosticSeverity.Warning]
+
+    # Output formatting
+    if format == "json":
+        import json
+        from pydantic import RootModel
+        # Use RootModel to export a list of models
+        print(RootModel(issues).model_dump_json(indent=2))
+        if any(d.severity == DiagnosticSeverity.Error for d in issues):
+            raise typer.Exit(code=1)
+        return
+
+    if not issues:
         console.print("[green]✔[/green] Issue integrity check passed. No integrity errors found.")
     else:
-        table = Table(title="Issue Integrity Issues", show_header=False, border_style="red")
-        for err in errors:
-            table.add_row(err)
+        table = Table(title="Issue Integrity Report", show_header=True, header_style="bold magenta", border_style="red")
+        table.add_column("Issue", style="cyan")
+        table.add_column("Severity", justify="center")
+        table.add_column("Line", justify="right", style="dim")
+        table.add_column("Message")
+        
+        for d in issues:
+            sev_style = "red" if d.severity == DiagnosticSeverity.Error else "yellow"
+            sev_label = "ERROR" if d.severity == DiagnosticSeverity.Error else "WARN"
+            line_str = str(d.range.start.line + 1) if d.range else "-"
+            table.add_row(
+                d.source or "Unknown",
+                f"[{sev_style}]{sev_label}[/{sev_style}]",
+                line_str,
+                d.message
+            )
+            
         console.print(table)
-        raise typer.Exit(code=1)
+        
+        if any(d.severity == DiagnosticSeverity.Error for d in issues):
+            console.print("\n[yellow]Tip: Run 'monoco issue lint --fix' to attempt automatic repairs.[/yellow]")
+            raise typer.Exit(code=1)
+        
+        if issues:
+             console.print("\n[yellow]Tip: Run 'monoco issue lint --fix' to attempt automatic repairs.[/yellow]")
+

monoco/features/issue/lsp/__init__.py

@@ -0,0 +1,3 @@
+from .definition import DefinitionProvider
+
+__all__ = ["DefinitionProvider"]

monoco/features/issue/lsp/definition.py

@@ -0,0 +1,72 @@
+from pathlib import Path
+from typing import Optional, List
+from monoco.core.lsp import Location, Position, Range
+from ..domain.parser import MarkdownParser
+from ..domain.workspace import WorkspaceSymbolIndex, IssueLocation
+
+class DefinitionProvider:
+    def __init__(self, workspace_root: Path):
+        self.workspace_root = workspace_root
+        self.index = WorkspaceSymbolIndex(workspace_root)
+        # Lazy indexing handled by the index class itself
+
+    def provide_definition(self, file_path: Path, position: Position) -> List[Location]:
+        """
+        Resolve definition at the given position in the file.
+        """
+        if not file_path.exists():
+            return []
+
+        content = file_path.read_text()
+        
+        # 1. Parse the document to find spans
+        # We only need to find the span at the specific line
+        issue = MarkdownParser.parse(content, path=str(file_path))
+        
+        target_span = None
+        for block in issue.body.blocks:
+            # Check if position is within block
+             # Note: block.line_start is inclusive, line_end is exclusive for content
+            if block.line_start <= position.line < block.line_end:
+                 for span in block.spans:
+                     if span.range.start.line == position.line:
+                         # Check character range
+                         if span.range.start.character <= position.character <= span.range.end.character:
+                             target_span = span
+                             break
+            if target_span:
+                break
+        
+        if not target_span:
+            return []
+
+        # 2. Resolve based on span type
+        if target_span.type in ["wikilink", "issue_id"]:
+            issue_id = target_span.metadata.get("issue_id")
+            if issue_id:
+                # Resolve using Workspace Index
+                location = self.index.resolve(issue_id, context_project=self._get_context_project(file_path))
+                if location:
+                    return [
+                        Location(
+                            uri=f"file://{location.file_path}",
+                            range=Range(
+                                start=Position(line=0, character=0),
+                                end=Position(line=0, character=0)
+                            )
+                        )
+                    ]
+        
+        return []
+
+    def _get_context_project(self, file_path: Path) -> Optional[str]:
+        # Simple heuristic: look for parent directory name if it's a known project structure?
+        # Or rely on configuration. 
+        # For now, let's assume the index handles context if passed, or we pass None.
+        # Actually resolving context project from file path is tricky without config loaded for that specific root.
+        # Let's try to deduce from path relative to workspace root.
+        try:
+             rel = file_path.relative_to(self.workspace_root)
+             return rel.parts[0] # First dir is likely project name in a workspace
+        except ValueError:
+             return "local"