monoco-toolkit 0.1.0__py3-none-any.whl → 0.2.5__py3-none-any.whl

monoco/features/issue/core.py

@@ -6,7 +6,9 @@ from typing import List, Dict, Optional, Tuple, Any, Set, Set
 from datetime import datetime
 from .models import IssueMetadata, IssueType, IssueStatus, IssueSolution, IssueStage, IssueDetail, IsolationType, IssueIsolation, IssueID, current_time, generate_uid
 from monoco.core import git
-from monoco.core.config import get_config
+from monoco.core.config import get_config, MonocoConfig
+from monoco.core.lsp import DiagnosticSeverity
+from .validator import IssueValidator
 
 PREFIX_MAP = {
     IssueType.EPIC: "EPIC",
@@ -17,6 +19,27 @@ PREFIX_MAP = {
 
 REVERSE_PREFIX_MAP = {v: k for k, v in PREFIX_MAP.items()}
 
+def enforce_lifecycle_policy(meta: IssueMetadata) -> None:
+    """
+    Apply business rules to ensure IssueMetadata consistency.
+    Should be called during Create or Update (but NOT during Read/Lint).
+    """
+    if meta.status == IssueStatus.BACKLOG:
+        meta.stage = IssueStage.FREEZED
+    
+    elif meta.status == IssueStatus.CLOSED:
+        # Enforce stage=done for closed issues
+        if meta.stage != IssueStage.DONE:
+            meta.stage = IssueStage.DONE
+        # Auto-fill closed_at if missing
+        if not meta.closed_at:
+            meta.closed_at = current_time()
+    
+    elif meta.status == IssueStatus.OPEN:
+        # Ensure valid stage for open status
+        if meta.stage is None:
+            meta.stage = IssueStage.DRAFT
+
 def _get_slug(title: str) -> str:
     slug = title.lower()
     # Replace non-word characters (including punctuation, spaces) with hyphens
@@ -51,7 +74,11 @@ def parse_issue(file_path: Path) -> Optional[IssueMetadata]:
         data = yaml.safe_load(match.group(1))
         if not isinstance(data, dict):
              return None
-        return IssueMetadata(**data)
+        
+        data['path'] = str(file_path.absolute())
+        meta = IssueMetadata(**data)
+        meta.actions = get_available_actions(meta)
+        return meta
     except Exception:
         return None
 
@@ -72,6 +99,8 @@ def parse_issue_detail(file_path: Path) -> Optional[IssueDetail]:
         data = yaml.safe_load(yaml_str)
         if not isinstance(data, dict):
              return None
+             
+        data['path'] = str(file_path.absolute())
         return IssueDetail(**data, body=body, raw_content=content)
     except Exception:
         return None
@@ -139,8 +168,10 @@ def create_issue_file(
         tags=tags,
         opened_at=current_time() if status == IssueStatus.OPEN else None
     )
-
     
+    # Enforce lifecycle policies (defaults, auto-corrections)
+    enforce_lifecycle_policy(metadata)
+
     yaml_header = yaml.dump(metadata.model_dump(exclude_none=True, mode='json'), sort_keys=False, allow_unicode=True)
     slug = _get_slug(title)
     filename = f"{issue_id}-{slug}.md"
@@ -161,60 +192,56 @@ def create_issue_file(
     file_path = target_dir / filename
     file_path.write_text(file_content)
     
+    # Inject path into returned metadata
+    metadata.path = str(file_path.absolute())
+    
     return metadata, file_path
-def validate_transition(
-    current_status: IssueStatus,
-    current_stage: Optional[IssueStage],
-    target_status: IssueStatus,
-    target_stage: Optional[IssueStage],
-    target_solution: Optional[str],
-    issue_dependencies: List[str],
-    issues_root: Path,
-    issue_id: str
-):
-    """
-    Centralized validation logic for state transitions.
-    """
-    # Policy: Prevent Backlog -> Review
-    if target_stage == IssueStage.REVIEW and current_status == IssueStatus.BACKLOG:
-         raise ValueError(f"Lifecycle Policy: Cannot submit Backlog issue directly. Run `monoco issue pull {issue_id}` first.")
+def get_available_actions(meta: IssueMetadata) -> List[Any]:
+    from .models import IssueAction
+    actions = []
+
+    if meta.status == IssueStatus.OPEN:
+        # Stage-based movements
+        if meta.stage == IssueStage.DRAFT:
+            actions.append(IssueAction(label="Start", target_status=IssueStatus.OPEN, target_stage=IssueStage.DOING))
+            actions.append(IssueAction(label="Freeze", target_status=IssueStatus.BACKLOG))
+        elif meta.stage == IssueStage.DOING:
+            actions.append(IssueAction(label="Stop", target_status=IssueStatus.OPEN, target_stage=IssueStage.DRAFT))
+            actions.append(IssueAction(label="Submit", target_status=IssueStatus.OPEN, target_stage=IssueStage.REVIEW))
+        elif meta.stage == IssueStage.REVIEW:
+            actions.append(IssueAction(label="Approve", target_status=IssueStatus.CLOSED, target_stage=IssueStage.DONE, target_solution=IssueSolution.IMPLEMENTED))
+            actions.append(IssueAction(label="Reject", target_status=IssueStatus.OPEN, target_stage=IssueStage.DOING))
+        elif meta.stage == IssueStage.DONE:
+            actions.append(IssueAction(label="Reopen", target_status=IssueStatus.OPEN, target_stage=IssueStage.DRAFT))
+            actions.append(IssueAction(label="Close", target_status=IssueStatus.CLOSED, target_stage=IssueStage.DONE, target_solution=IssueSolution.IMPLEMENTED))
+        
+        # Generic cancel
+        actions.append(IssueAction(label="Cancel", target_status=IssueStatus.CLOSED, target_stage=IssueStage.DONE, target_solution=IssueSolution.CANCELLED))
 
-    if target_status == IssueStatus.CLOSED:
-        if not target_solution:
-            raise ValueError(f"Closing an issue requires a solution. Please provide --solution or edit the file metadata.")
-            
-        # Policy: IMPLEMENTED requires REVIEW stage (unless we are already in REVIEW)
-        # Check current stage.
-        if target_solution == IssueSolution.IMPLEMENTED.value:
-            # If we are transitioning FROM Review, it's fine.
-            # If we are transitioning TO Closed, current stage must be Review.
-            if current_stage != IssueStage.REVIEW:
-                raise ValueError(f"Lifecycle Policy: 'Implemented' issues must be submitted for review first.\nCurrent stage: {current_stage}\nAction: Run `monoco issue submit {issue_id}`.")
-
-        # Policy: No closing from DOING (General Safety)
-        if current_stage == IssueStage.DOING:
-             raise ValueError("Cannot close issue in progress (Doing). Please review (`monoco issue submit`) or stop (`monoco issue open`) first.")
-             
-        # Policy: Dependencies must be closed
-        if issue_dependencies:
-            for dep_id in issue_dependencies:
-                dep_path = find_issue_path(issues_root, dep_id)
-                if dep_path:
-                    dep_meta = parse_issue(dep_path)
-                    if dep_meta and dep_meta.status != IssueStatus.CLOSED:
-                        raise ValueError(f"Dependency Block: Cannot close {issue_id} because dependency {dep_id} is not closed.")
+    elif meta.status == IssueStatus.BACKLOG:
+        actions.append(IssueAction(label="Pull", target_status=IssueStatus.OPEN, target_stage=IssueStage.DRAFT))
+        actions.append(IssueAction(label="Cancel", target_status=IssueStatus.CLOSED, target_stage=IssueStage.DONE, target_solution=IssueSolution.CANCELLED))
+
+    elif meta.status == IssueStatus.CLOSED:
+        actions.append(IssueAction(label="Reopen", target_status=IssueStatus.OPEN, target_stage=IssueStage.DRAFT))
+
+    return actions
 
 def find_issue_path(issues_root: Path, issue_id: str) -> Optional[Path]:
     parsed = IssueID(issue_id)
 
     if not parsed.is_local:
+        if not parsed.namespace:
+            return None
+
         # Resolve Workspace
-        # Assumption: issues_root is direct child of project_root. 
-        # This is a weak assumption but fits current architecture.
+        # Traverse up from issues_root to find a config that defines the namespace
         project_root = issues_root.parent
-        conf = get_config(str(project_root))
         
+        # Try current root first
+        conf = MonocoConfig.load(str(project_root))
         member_rel_path = conf.project.members.get(parsed.namespace)
+        
         if not member_rel_path:
             return None
             
@@ -244,7 +271,19 @@ def find_issue_path(issues_root: Path, issue_id: str) -> Optional[Path]:
         return f
     return None
 
-def update_issue(issues_root: Path, issue_id: str, status: Optional[IssueStatus] = None, stage: Optional[IssueStage] = None, solution: Optional[IssueSolution] = None) -> IssueMetadata:
+def update_issue(
+    issues_root: Path, 
+    issue_id: str, 
+    status: Optional[IssueStatus] = None, 
+    stage: Optional[IssueStage] = None, 
+    solution: Optional[IssueSolution] = None,
+    title: Optional[str] = None,
+    parent: Optional[str] = None,
+    sprint: Optional[str] = None,
+    dependencies: Optional[List[str]] = None,
+    related: Optional[List[str]] = None,
+    tags: Optional[List[str]] = None
+) -> IssueMetadata:
     path = find_issue_path(issues_root, issue_id)
     if not path:
         raise FileNotFoundError(f"Issue {issue_id} not found.")
@@ -253,7 +292,7 @@ def update_issue(issues_root: Path, issue_id: str, status: Optional[IssueStatus]
     content = path.read_text()
     
     # Split Frontmatter and Body
-    match = re.search(r"^---(.*?)---\n(.*)$\n", content, re.DOTALL | re.MULTILINE)
+    match = re.search(r"^---(.*?)---\n(.*)\n", content, re.DOTALL | re.MULTILINE)
     if not match:
         # Fallback
         match_simple = re.search(r"^---(.*?)---", content, re.DOTALL | re.MULTILINE)
@@ -289,9 +328,7 @@ def update_issue(issues_root: Path, issue_id: str, status: Optional[IssueStatus]
          raise ValueError(f"Lifecycle Policy: Cannot submit Backlog issue directly. Run `monoco issue pull {issue_id}` first.")
 
     if target_status == IssueStatus.CLOSED:
-        if not effective_solution:
-            raise ValueError(f"Closing an issue requires a solution. Please provide --solution or edit the file metadata.")
-            
+        # Validator will check solution presence
         current_data_stage = data.get('stage')
         
         # Policy: IMPLEMENTED requires REVIEW stage
@@ -304,14 +341,29 @@ def update_issue(issues_root: Path, issue_id: str, status: Optional[IssueStatus]
              raise ValueError("Cannot close issue in progress (Doing). Please review (`monoco issue submit`) or stop (`monoco issue open`) first.")
              
         # Policy: Dependencies must be closed
-        dependencies = data.get('dependencies', [])
-        if dependencies:
-            for dep_id in dependencies:
+        dependencies_to_check = dependencies if dependencies is not None else data.get('dependencies', [])
+        if dependencies_to_check:
+            for dep_id in dependencies_to_check:
                 dep_path = find_issue_path(issues_root, dep_id)
                 if dep_path:
                     dep_meta = parse_issue(dep_path)
                     if dep_meta and dep_meta.status != IssueStatus.CLOSED:
                         raise ValueError(f"Dependency Block: Cannot close {issue_id} because dependency {dep_id} is [Status: {dep_meta.status.value}].")
+    
+    # Validate new parent/dependencies/related exist
+    if parent is not None and parent != "":
+        if not find_issue_path(issues_root, parent):
+            raise ValueError(f"Parent issue {parent} not found.")
+    
+    if dependencies is not None:
+        for dep_id in dependencies:
+            if not find_issue_path(issues_root, dep_id):
+                raise ValueError(f"Dependency issue {dep_id} not found.")
+    
+    if related is not None:
+        for rel_id in related:
+            if not find_issue_path(issues_root, rel_id):
+                raise ValueError(f"Related issue {rel_id} not found.")
             
     # Update Data
     if status:
@@ -322,6 +374,27 @@ def update_issue(issues_root: Path, issue_id: str, status: Optional[IssueStatus]
     if solution:
         data['solution'] = solution.value
     
+    if title:
+        data['title'] = title
+
+    if parent is not None:
+        if parent == "":
+            data.pop('parent', None)  # Remove parent field
+        else:
+            data['parent'] = parent
+
+    if sprint is not None:
+        data['sprint'] = sprint
+    
+    if dependencies is not None:
+        data['dependencies'] = dependencies
+    
+    if related is not None:
+        data['related'] = related
+    
+    if tags is not None:
+        data['tags'] = tags
+    
     # Lifecycle Hooks
     # 1. Opened At: If transitioning to OPEN
     if target_status == IssueStatus.OPEN and current_status != IssueStatus.OPEN:
@@ -336,9 +409,24 @@ def update_issue(issues_root: Path, issue_id: str, status: Optional[IssueStatus]
     # Touch updated_at
     data['updated_at'] = current_time()
     
-    # Re-hydrate through Model to trigger Logic (Stage, ClosedAt defaults)
+    # Re-hydrate through Model
     try:
         updated_meta = IssueMetadata(**data)
+        
+        # Enforce lifecycle policies (defaults, auto-corrections)
+        # This ensures that when we update, we also fix invalid states (like Closed but not Done)
+        enforce_lifecycle_policy(updated_meta)
+
+        # Delegate to IssueValidator for static state validation
+        # We need to construct the full content to validate body-dependent rules (like checkboxes)
+        # Note: 'body' here is the OLD body. We assume update_issue doesn't change body.
+        # If body is invalid (unchecked boxes) and we move to DONE, this MUST fail.
+        validator = IssueValidator(issues_root)
+        diagnostics = validator.validate(updated_meta, body)
+        errors = [d for d in diagnostics if d.severity == DiagnosticSeverity.Error]
+        if errors:
+             raise ValueError(f"Validation Failed: {errors[0].message}")
+
     except Exception as e:
         raise ValueError(f"Failed to validate updated metadata: {e}")
         
@@ -376,11 +464,15 @@ def update_issue(issues_root: Path, issue_id: str, status: Optional[IssueStatus]
         if path != target_path:
             target_path.parent.mkdir(parents=True, exist_ok=True)
             path.rename(target_path)
+            path = target_path # Update local path variable for returned meta
 
     # Hook: Recursive Aggregation (FEAT-0003)
     if updated_meta.parent:
         recalculate_parent(issues_root, updated_meta.parent)
-        
+    
+    # Update returned metadata with final absolute path
+    updated_meta.path = str(path.absolute())
+    updated_meta.actions = get_available_actions(updated_meta)
     return updated_meta
 
 def start_issue_isolation(issues_root: Path, issue_id: str, mode: IsolationType, project_root: Path) -> IssueMetadata:
@@ -392,6 +484,8 @@ def start_issue_isolation(issues_root: Path, issue_id: str, mode: IsolationType,
         raise FileNotFoundError(f"Issue {issue_id} not found.")
 
     issue = parse_issue(path)
+    if not issue:
+        raise ValueError(f"Could not parse metadata for issue {issue_id}")
     
     # Idempotency / Conflict Check
     if issue.isolation:
@@ -467,6 +561,9 @@ def prune_issue_resources(issues_root: Path, issue_id: str, force: bool, project
         raise FileNotFoundError(f"Issue {issue_id} not found.")
         
     issue = parse_issue(path)
+    if not issue:
+        raise ValueError(f"Could not parse metadata for issue {issue_id}")
+        
     deleted_items = []
 
     if not issue.isolation:
@@ -574,15 +671,6 @@ description: Monoco Issue System 的官方技能定义。将 Issue 视为通用
 5. **Modification**: `monoco issue start/submit/delete <id>`
 """
 
-PROMPT_CONTENT = """
-### Issue Management
-System for managing tasks using `monoco issue`.
-- **Create**: `monoco issue create <type> -t "Title"` (types: epic, feature, chore, fix)
-- **Status**: `monoco issue open|close|backlog <id>`
-- **Check**: `monoco issue lint` (Must run after manual edits)
-- **Lifecycle**: `monoco issue start|submit|delete <id>`
-- **Structure**: `Issues/{CapitalizedPluralType}/{lowercase_status}/` (e.g. `Issues/Features/open/`). Do not deviate.
-"""
 
 def init(issues_root: Path):
     """Initialize the Issues directory structure."""
@@ -603,9 +691,7 @@ def get_resources() -> Dict[str, Any]:
         "skills": {
             "issues-management": SKILL_CONTENT
         },
-        "prompts": {
-            "issues-management": PROMPT_CONTENT
-        }
+        "prompts": {} # Handled by adapter via resource files
     }
 
 
@@ -653,7 +739,7 @@ def get_board_data(issues_root: Path) -> Dict[str, List[IssueMetadata]]:
     Get open issues grouped by their stage for Kanban view.
     """
     board = {
-        IssueStage.TODO.value: [],
+        IssueStage.DRAFT.value: [],
         IssueStage.DOING.value: [],
         IssueStage.REVIEW.value: [],
         IssueStage.DONE.value: []
@@ -769,7 +855,10 @@ def generate_delivery_report(issues_root: Path, issue_id: str, project_root: Pat
     commits = git.search_commits_by_message(project_root, f"Ref: {issue_id}")
     
     if not commits:
-        return parse_issue(path)
+        meta = parse_issue(path)
+        if not meta:
+            raise ValueError(f"Could not parse metadata for issue {issue_id}")
+        return meta
         
     # 2. Aggregate Data
     all_files = set()
@@ -825,7 +914,10 @@ def generate_delivery_report(issues_root: Path, issue_id: str, project_root: Pat
     # We can add it to 'extra' or extend the model later.
     # For now, just persisting the text is enough for FEAT-0002.
     
-    return parse_issue(path)
+    meta = parse_issue(path)
+    if not meta:
+         raise ValueError(f"Could not parse metadata for issue {issue_id}")
+    return meta
 
 def get_children(issues_root: Path, parent_id: str) -> List[IssueMetadata]:
     """Find all direct children of an issue."""
@@ -1033,11 +1125,11 @@ def recalculate_parent(issues_root: Path, parent_id: str):
         # FEAT-0003 Req: "If first child starts doing, auto-start Parent?"
         # If parent is OPEN/TODO and child is DOING/REVIEW/DONE, set parent to DOING?
         current_status = data.get("status", "open").lower()
-        current_stage = data.get("stage", "todo").lower()
+        current_stage = data.get("stage", "draft").lower()
         
-        if current_status == "open" and current_stage == "todo":
+        if current_status == "open" and current_stage == "draft":
             # Check if any child is active
-            active_children = [c for c in children if c.status == IssueStatus.OPEN and c.stage != IssueStage.TODO]
+            active_children = [c for c in children if c.status == IssueStatus.OPEN and c.stage != IssueStage.DRAFT]
             closed_children = [c for c in children if c.status == IssueStatus.CLOSED]
             
             if active_children or closed_children:
@@ -1143,7 +1235,7 @@ def move_issue(
     # 5. Update content if ID changed
     if new_id != old_id:
         # Update frontmatter
-        content = issue.raw_content
+        content = issue.raw_content or ""
         match = re.search(r"^---(.*?)---", content, re.DOTALL | re.MULTILINE)
         if match:
             yaml_str = match.group(1)
@@ -1159,9 +1251,9 @@ def move_issue(
             
             new_content = f"---\n{new_yaml}---{body}"
         else:
-            new_content = issue.raw_content
+            new_content = issue.raw_content or ""
     else:
-        new_content = issue.raw_content
+        new_content = issue.raw_content or ""
     
     # 6. Write to target
     target_path.write_text(new_content)
@@ -1171,4 +1263,7 @@ def move_issue(
     
     # 8. Return updated metadata
     final_meta = parse_issue(target_path)
+    if not final_meta:
+        raise ValueError(f"Failed to parse moved issue at {target_path}")
+        
     return final_meta, target_path